lsd-pi 1.0.0 → 1.1.0

package/src/resources/extensions/gsd/tests/worktree.test.ts

@@ -1,279 +0,0 @@
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, symlinkSync, realpathSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { execSync } from "node:child_process";
-
-import {
-  autoCommitCurrentBranch,
-  captureIntegrationBranch,
-  detectWorktreeName,
-  getCurrentBranch,
-  getMainBranch,
-  getSliceBranchName,
-  parseSliceBranch,
-  resolveProjectRoot,
-  setActiveMilestoneId,
-  SLICE_BRANCH_RE,
-} from "../worktree.ts";
-import { readIntegrationBranch } from "../git-service.ts";
-import { _resetHasChangesCache } from "../native-git-bridge.ts";
-import { describe, test } from 'node:test';
-import assert from 'node:assert/strict';
-
-
-/**
- * Normalize a path for reliable comparison on Windows CI runners.
- * `os.tmpdir()` may return the 8.3 short-path form (e.g. `C:\Users\RUNNER~1`)
- * while `realpathSync` and git resolve to the long form (`C:\Users\runneradmin`).
- * Apply `realpathSync` and lowercase on Windows to eliminate both discrepancies.
- */
-function normalizePath(p: string): string {
-  const resolved = process.platform === "win32" ? realpathSync.native(p) : realpathSync(p);
-  return process.platform === "win32" ? resolved.toLowerCase() : resolved;
-}
-
-function run(command: string, cwd: string): string {
-  return execSync(command, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-const base = mkdtempSync(join(tmpdir(), "gsd-branch-test-"));
-run("git init -b main", base);
-run('git config user.name "Pi Test"', base);
-run('git config user.email "pi@example.com"', base);
-mkdirSync(join(base, ".gsd", "milestones", "M001", "slices", "S01", "tasks"), { recursive: true });
-writeFileSync(join(base, "README.md"), "hello\n", "utf-8");
-writeFileSync(join(base, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), `# M001: Demo\n\n## Slices\n- [ ] **S01: Slice One** \`risk:low\` \`depends:[]\`\n  > After this: demo works\n`, "utf-8");
-writeFileSync(join(base, ".gsd", "milestones", "M001", "slices", "S01", "S01-PLAN.md"), `# S01: Slice One\n\n**Goal:** Demo\n**Demo:** Demo\n\n## Must-Haves\n- done\n\n## Tasks\n- [ ] **T01: Implement** \`est:10m\`\n  do it\n`, "utf-8");
-run("git add .", base);
-run('git commit -m "chore: init"', base);
-
-describe('worktree', async () => {
-
-  console.log("\n=== autoCommitCurrentBranch ===");
-  // Clean — should return null
-  const cleanResult = autoCommitCurrentBranch(base, "execute-task", "M001/S01/T01");
-  assert.deepStrictEqual(cleanResult, null, "returns null for clean repo");
-
-  // Make dirty — reset the nativeHasChanges cache so the fresh dirt is detected
-  _resetHasChangesCache();
-  writeFileSync(join(base, "dirty.txt"), "uncommitted\n", "utf-8");
-  const dirtyResult = autoCommitCurrentBranch(base, "execute-task", "M001/S01/T01");
-  assert.ok(dirtyResult !== null, "returns commit message for dirty repo");
-  assert.ok(dirtyResult!.includes("M001/S01/T01"), "commit message includes unit id");
-  assert.deepStrictEqual(run("git status --short", base), "", "repo is clean after auto-commit");
-
-  console.log("\n=== getSliceBranchName ===");
-  assert.deepStrictEqual(getSliceBranchName("M001", "S01"), "gsd/M001/S01", "branch name format correct");
-  assert.deepStrictEqual(getSliceBranchName("M001", "S01", null), "gsd/M001/S01", "null worktree = plain branch");
-  assert.deepStrictEqual(getSliceBranchName("M001", "S01", "my-wt"), "gsd/my-wt/M001/S01", "worktree-namespaced branch");
-
-  console.log("\n=== parseSliceBranch ===");
-  const plain = parseSliceBranch("gsd/M001/S01");
-  assert.ok(plain !== null, "parses plain branch");
-  assert.deepStrictEqual(plain!.worktreeName, null, "plain branch has no worktree name");
-  assert.deepStrictEqual(plain!.milestoneId, "M001", "plain branch milestone");
-  assert.deepStrictEqual(plain!.sliceId, "S01", "plain branch slice");
-
-  const namespaced = parseSliceBranch("gsd/feature-auth/M001/S01");
-  assert.ok(namespaced !== null, "parses worktree-namespaced branch");
-  assert.deepStrictEqual(namespaced!.worktreeName, "feature-auth", "worktree name extracted");
-  assert.deepStrictEqual(namespaced!.milestoneId, "M001", "namespaced branch milestone");
-  assert.deepStrictEqual(namespaced!.sliceId, "S01", "namespaced branch slice");
-
-  const invalid = parseSliceBranch("main");
-  assert.deepStrictEqual(invalid, null, "non-slice branch returns null");
-
-  const worktreeBranch = parseSliceBranch("worktree/foo");
-  assert.deepStrictEqual(worktreeBranch, null, "worktree/ prefix is not a slice branch");
-
-  console.log("\n=== SLICE_BRANCH_RE ===");
-  assert.ok(SLICE_BRANCH_RE.test("gsd/M001/S01"), "regex matches plain branch");
-  assert.ok(SLICE_BRANCH_RE.test("gsd/my-wt/M001/S01"), "regex matches worktree branch");
-  assert.ok(!SLICE_BRANCH_RE.test("main"), "regex rejects main");
-  assert.ok(!SLICE_BRANCH_RE.test("gsd/"), "regex rejects bare gsd/");
-  assert.ok(!SLICE_BRANCH_RE.test("worktree/foo"), "regex rejects worktree/foo");
-
-  console.log("\n=== detectWorktreeName ===");
-  assert.deepStrictEqual(detectWorktreeName("/projects/myapp"), null, "no worktree in plain path");
-  assert.deepStrictEqual(detectWorktreeName("/projects/myapp/.gsd/worktrees/feature-auth"), "feature-auth", "detects worktree name");
-  assert.deepStrictEqual(detectWorktreeName("/projects/myapp/.gsd/worktrees/my-wt/subdir"), "my-wt", "detects worktree with subdir");
-
-  // ═══════════════════════════════════════════════════════════════════════
-  // Integration branch — facade-level tests
-  // ═══════════════════════════════════════════════════════════════════════
-
-  // ── captureIntegrationBranch on a feature branch ──────────────────────
-
-  console.log("\n=== captureIntegrationBranch: records current branch ===");
-
-  {
-    const repo = mkdtempSync(join(tmpdir(), "gsd-integ-facade-"));
-    run("git init -b main", repo);
-    run("git config user.name 'Pi Test'", repo);
-    run("git config user.email 'pi@example.com'", repo);
-    writeFileSync(join(repo, "README.md"), "init\n");
-    run("git add -A && git commit -m init", repo);
-
-    run("git checkout -b f-123-thing", repo);
-    assert.deepStrictEqual(getCurrentBranch(repo), "f-123-thing", "on feature branch");
-
-    const commitsBefore = run("git rev-list --count HEAD", repo);
-    captureIntegrationBranch(repo, "M001");
-    assert.deepStrictEqual(readIntegrationBranch(repo, "M001"), "f-123-thing",
-      "captureIntegrationBranch records the current branch");
-
-    // Metadata is stored in external state, not committed to git.
-    const commitsAfter = run("git rev-list --count HEAD", repo);
-    assert.deepStrictEqual(commitsAfter, commitsBefore, "captureIntegrationBranch does not create a git commit");
-
-    rmSync(repo, { recursive: true, force: true });
-  }
-
-  // ── captureIntegrationBranch skips slice branches ─────────────────────
-
-  console.log("\n=== captureIntegrationBranch: skips slice branches ===");
-
-  {
-    const repo = mkdtempSync(join(tmpdir(), "gsd-integ-skip-"));
-    run("git init -b main", repo);
-    run("git config user.name 'Pi Test'", repo);
-    run("git config user.email 'pi@example.com'", repo);
-    writeFileSync(join(repo, "README.md"), "init\n");
-    run("git add -A && git commit -m init", repo);
-
-    run("git checkout -b gsd/M001/S01", repo);
-    captureIntegrationBranch(repo, "M001");
-
-    assert.deepStrictEqual(readIntegrationBranch(repo, "M001"), null,
-      "capture from slice branch is a no-op");
-
-    rmSync(repo, { recursive: true, force: true });
-  }
-
-  // ── setActiveMilestoneId makes getMainBranch return integration branch ─
-
-  console.log("\n=== setActiveMilestoneId + getMainBranch ===");
-
-  {
-    const repo = mkdtempSync(join(tmpdir(), "gsd-integ-main-"));
-    run("git init -b main", repo);
-    run("git config user.name 'Pi Test'", repo);
-    run("git config user.email 'pi@example.com'", repo);
-    writeFileSync(join(repo, "README.md"), "init\n");
-    run("git add -A && git commit -m init", repo);
-
-    run("git checkout -b my-feature", repo);
-    captureIntegrationBranch(repo, "M001");
-
-    // Without milestone set, getMainBranch returns "main"
-    setActiveMilestoneId(repo, null);
-    assert.deepStrictEqual(getMainBranch(repo), "main",
-      "getMainBranch returns main without milestone set");
-
-    // With milestone set, getMainBranch returns feature branch
-    setActiveMilestoneId(repo, "M001");
-    assert.deepStrictEqual(getMainBranch(repo), "my-feature",
-      "getMainBranch returns integration branch with milestone set");
-
-    rmSync(repo, { recursive: true, force: true });
-  }
-
-  // ── detectWorktreeName: symlink-resolved paths ───────────────────────────
-  console.log("\n=== detectWorktreeName (symlink-resolved paths) ===");
-  assert.deepStrictEqual(
-    detectWorktreeName("/Users/fran/.gsd/projects/89e1c9ad49bf/worktrees/M001"),
-    "M001",
-    "detects milestone in symlink-resolved path",
-  );
-  assert.deepStrictEqual(
-    detectWorktreeName("/Users/fran/.gsd/projects/abc123/worktrees/M002/subdir"),
-    "M002",
-    "detects milestone with trailing subdir in symlink-resolved path",
-  );
-  assert.deepStrictEqual(
-    detectWorktreeName("/Users/fran/.gsd/projects/abc123"),
-    null,
-    "returns null for project root without worktrees segment",
-  );
-  assert.deepStrictEqual(
-    detectWorktreeName("/foo/.gsd/worktrees/M001"),
-    "M001",
-    "still detects direct layout path",
-  );
-
-  // ── resolveProjectRoot: symlink-resolved paths ──────────────────────────
-  console.log("\n=== resolveProjectRoot (symlink-resolved paths) ===");
-
-  // BUG FIX: symlink-resolved paths that land inside ~/.gsd should NOT
-  // resolve to the home directory. When the .git file fallback can't find
-  // the real project root (no git worktree metadata in these synthetic paths),
-  // resolveProjectRoot returns the input unchanged rather than returning ~.
-  
-  // With GSD_PROJECT_ROOT env var set (layer 1 — coordinator passes it)
-  process.env.GSD_PROJECT_ROOT = "/real/project";
-  assert.deepStrictEqual(
-    resolveProjectRoot("/Users/fran/.gsd/projects/89e1c9ad49bf/worktrees/M001"),
-    "/real/project",
-    "uses GSD_PROJECT_ROOT when set",
-  );
-  delete process.env.GSD_PROJECT_ROOT;
-
-  // Without GSD_PROJECT_ROOT, direct layout still works (no ~/.gsd collision)
-  assert.deepStrictEqual(
-    resolveProjectRoot("/some/repo"),
-    "/some/repo",
-    "ignores GSD_PROJECT_ROOT override for non-worktree paths",
-  );
-  delete process.env.GSD_PROJECT_ROOT;
-
-  // Without GSD_PROJECT_ROOT, direct layout still works (no ~/.gsd collision)
-  assert.deepStrictEqual(
-    resolveProjectRoot("/foo/.gsd/worktrees/M001"),
-    "/foo",
-    "still resolves direct layout path",
-  );
-  assert.deepStrictEqual(
-    resolveProjectRoot("/some/repo"),
-    "/some/repo",
-    "returns unchanged for non-worktree path",
-  );
-
-  // Without GSD_PROJECT_ROOT, direct layout with nested subdirs
-  assert.deepStrictEqual(
-    resolveProjectRoot("/data/.gsd/worktrees/M003/nested"),
-    "/data",
-    "resolves correctly with nested subdirs after worktree name (direct layout)",
-  );
-
-  // Real symlink + git worktree scenario, with deep nested path from cwd
-  {
-    const fakeHome = mkdtempSync(join(tmpdir(), "gsd-home-"));
-    const project = realpathSync(mkdtempSync(join(tmpdir(), "gsd-proj-")));
-    const storage = join(fakeHome, ".gsd", "projects", "abc123def456");
-    mkdirSync(storage, { recursive: true });
-    symlinkSync(storage, join(project, ".gsd"));
-
-    run("git init -b main", project);
-    run("git config user.name 'Pi Test'", project);
-    run("git config user.email 'pi@example.com'", project);
-    writeFileSync(join(project, "README.md"), "init\n");
-    run("git add -A && git commit -m init", project);
-    run("git worktree add .gsd/worktrees/M001 -b worktree/M001", project);
-
-    const deep = join(project, ".gsd", "worktrees", "M001", "a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k");
-    mkdirSync(deep, { recursive: true });
-
-    process.env.LSD_HOME = join(fakeHome, ".gsd");
-    assert.deepStrictEqual(
-      normalizePath(resolveProjectRoot(realpathSync(deep))),
-      normalizePath(project),
-      "resolves to real project root from deep symlink-resolved worktree path",
-    );
-    delete process.env.LSD_HOME;
-
-    rmSync(project, { recursive: true, force: true });
-    rmSync(fakeHome, { recursive: true, force: true });
-  }
-
-  rmSync(base, { recursive: true, force: true });
-});

package/src/resources/extensions/gsd/tests/write-gate.test.ts

@@ -1,193 +0,0 @@
-/**
- * Unit tests for the CONTEXT.md write-gate (D031 guard chain).
- *
- * Exercises shouldBlockContextWrite() — a pure function that implements:
- *   (a) toolName !== "write" → pass
- *   (b) milestoneId null → pass (not in discussion)
- *   (c) path doesn't match /M\d+-CONTEXT\.md$/ → pass
- *   (d) depthVerified → pass
- *   (e) else → block with actionable reason
- */
-
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import {
-  shouldBlockContextWrite,
-  isDepthVerified,
-  isQueuePhaseActive,
-  setQueuePhaseActive,
-} from '../index.ts';
-import {
-  markDepthVerified,
-  clearDiscussionFlowState,
-  resetWriteGateState,
-} from '../bootstrap/write-gate.ts';
-
-// ─── Scenario 1: Blocks CONTEXT.md write during discussion without depth verification (absolute path) ──
-
-test('write-gate: blocks CONTEXT.md write during discussion without depth verification (absolute path)', () => {
-  const result = shouldBlockContextWrite(
-    'write',
-    '/Users/dev/project/.gsd/milestones/M001/M001-CONTEXT.md',
-    'M001',
-    false,
-  );
-  assert.strictEqual(result.block, true, 'should block the write');
-  assert.ok(result.reason, 'should provide a reason');
-});
-
-// ─── Scenario 2: Blocks CONTEXT.md write during discussion without depth verification (relative path) ──
-
-test('write-gate: blocks CONTEXT.md write during discussion without depth verification (relative path)', () => {
-  const result = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M005/M005-CONTEXT.md',
-    'M005',
-    false,
-  );
-  assert.strictEqual(result.block, true, 'should block the write');
-  assert.ok(result.reason, 'should provide a reason');
-});
-
-// ─── Scenario 3: Allows CONTEXT.md write after depth verification ──
-
-test('write-gate: allows CONTEXT.md write after depth verification', () => {
-  const result = shouldBlockContextWrite(
-    'write',
-    '/Users/dev/project/.gsd/milestones/M001/M001-CONTEXT.md',
-    'M001',
-    true,
-  );
-  assert.strictEqual(result.block, false, 'should not block after depth verification');
-  assert.strictEqual(result.reason, undefined, 'should have no reason');
-});
-
-// ─── Scenario 4: Allows CONTEXT.md write outside discussion phase (milestoneId null) ──
-
-test('write-gate: allows CONTEXT.md write outside discussion phase', () => {
-  const result = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M001/M001-CONTEXT.md',
-    null,
-    false,
-  );
-  assert.strictEqual(result.block, false, 'should not block outside discussion phase');
-});
-
-// ─── Scenario 5: Allows non-CONTEXT.md writes during discussion ──
-
-test('write-gate: allows non-CONTEXT.md writes during discussion', () => {
-  // DISCUSSION.md
-  const r1 = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M001/M001-DISCUSSION.md',
-    'M001',
-    false,
-  );
-  assert.strictEqual(r1.block, false, 'DISCUSSION.md should pass');
-
-  // Slice file
-  const r2 = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M001/slices/S01/S01-PLAN.md',
-    'M001',
-    false,
-  );
-  assert.strictEqual(r2.block, false, 'slice plan should pass');
-
-  // Regular code file
-  const r3 = shouldBlockContextWrite(
-    'write',
-    'src/index.ts',
-    'M001',
-    false,
-  );
-  assert.strictEqual(r3.block, false, 'regular code file should pass');
-});
-
-// ─── Scenario 6: Regex specificity — doesn't match S01-CONTEXT.md ──
-
-test('write-gate: regex does not match slice context files (S01-CONTEXT.md)', () => {
-  const result = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M001/slices/S01/S01-CONTEXT.md',
-    'M001',
-    false,
-  );
-  assert.strictEqual(result.block, false, 'S01-CONTEXT.md should not be blocked');
-});
-
-// ─── Scenario 7: Error message contains actionable instruction ──
-
-test('write-gate: blocked reason contains depth_verification keyword', () => {
-  const result = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M999/M999-CONTEXT.md',
-    'M999',
-    false,
-  );
-  assert.strictEqual(result.block, true);
-  assert.ok(result.reason!.includes('depth_verification'), 'reason should mention depth_verification question id');
-  assert.ok(result.reason!.includes('ask_user_questions'), 'reason should mention ask_user_questions tool');
-});
-
-// ─── Scenario 8: Queue mode blocks CONTEXT.md write without depth verification ──
-
-test('write-gate: blocks CONTEXT.md write in queue mode without depth verification', () => {
-  const result = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M001/M001-CONTEXT.md',
-    null,   // no milestoneId in queue mode
-    false,  // not depth-verified
-    true,   // queue phase active
-  );
-  assert.strictEqual(result.block, true, 'should block in queue mode without depth verification');
-  assert.ok(result.reason, 'should provide a reason');
-});
-
-// ─── Scenario 9: Queue mode allows CONTEXT.md write after depth verification ──
-
-test('write-gate: allows CONTEXT.md write in queue mode after depth verification', () => {
-  const result = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M001/M001-CONTEXT.md',
-    null,   // no milestoneId in queue mode
-    true,   // depth-verified
-    true,   // queue phase active
-  );
-  assert.strictEqual(result.block, false, 'should not block in queue mode after depth verification');
-});
-
-// ─── Scenario 10: markDepthVerified works in queue-only mode (no milestoneId) ──
-// This is the core regression for #1812: in queue mode, the tool_result handler
-// must call markDepthVerified() even when getDiscussionMilestoneId() is null.
-
-test('write-gate: markDepthVerified unblocks queue-mode writes when milestoneId is null', () => {
-  clearDiscussionFlowState();
-  setQueuePhaseActive(true);
-
-  // Before marking: should block
-  const blocked = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M001/M001-CONTEXT.md',
-    null,
-    isDepthVerified(),
-    isQueuePhaseActive(),
-  );
-  assert.strictEqual(blocked.block, true, 'should block before markDepthVerified');
-
-  // Simulate what the fixed tool_result handler does
-  markDepthVerified();
-
-  // After marking: should pass
-  const allowed = shouldBlockContextWrite(
-    'write',
-    '.gsd/milestones/M001/M001-CONTEXT.md',
-    null,
-    isDepthVerified(),
-    isQueuePhaseActive(),
-  );
-  assert.strictEqual(allowed.block, false, 'should allow after markDepthVerified in queue mode');
-
-  clearDiscussionFlowState();
-});

package/src/resources/extensions/gsd/tests/write-intercept.test.ts

@@ -1,76 +0,0 @@
-// GSD Extension — write-intercept unit tests
-// Tests isBlockedStateFile() and BLOCKED_WRITE_ERROR constant.
-
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import { isBlockedStateFile, BLOCKED_WRITE_ERROR } from '../write-intercept.ts';
-
-// ─── isBlockedStateFile: blocked paths ───────────────────────────────────
-
-test('write-intercept: blocks unix .gsd/STATE.md path', () => {
-  assert.strictEqual(isBlockedStateFile('/project/.gsd/STATE.md'), true);
-});
-
-test('write-intercept: blocks relative path with dir prefix before .gsd/STATE.md', () => {
-  assert.strictEqual(isBlockedStateFile('project/.gsd/STATE.md'), true);
-});
-
-test('write-intercept: blocks bare relative .gsd/STATE.md (no leading separator)', () => {
-  // (^|[/\\]) matches paths that start with .gsd/ — covers the case where write
-  // tools receive a bare relative path before the file exists (realpathSync fails).
-  assert.strictEqual(isBlockedStateFile('.gsd/STATE.md'), true);
-});
-
-test('write-intercept: blocks nested project .gsd/STATE.md path', () => {
-  assert.strictEqual(isBlockedStateFile('/Users/dev/my-project/.gsd/STATE.md'), true);
-});
-
-test('write-intercept: blocks .gsd/projects/<name>/STATE.md (symlinked projects path)', () => {
-  assert.strictEqual(isBlockedStateFile('/home/user/.gsd/projects/my-project/STATE.md'), true);
-});
-
-// ─── isBlockedStateFile: allowed paths ───────────────────────────────────
-
-test('write-intercept: allows .gsd/ROADMAP.md', () => {
-  assert.strictEqual(isBlockedStateFile('/project/.gsd/ROADMAP.md'), false);
-});
-
-test('write-intercept: allows .gsd/PLAN.md', () => {
-  assert.strictEqual(isBlockedStateFile('/project/.gsd/PLAN.md'), false);
-});
-
-test('write-intercept: allows .gsd/REQUIREMENTS.md', () => {
-  assert.strictEqual(isBlockedStateFile('/project/.gsd/REQUIREMENTS.md'), false);
-});
-
-test('write-intercept: allows .gsd/SUMMARY.md', () => {
-  assert.strictEqual(isBlockedStateFile('/project/.gsd/SUMMARY.md'), false);
-});
-
-test('write-intercept: allows .gsd/PROJECT.md', () => {
-  assert.strictEqual(isBlockedStateFile('/project/.gsd/PROJECT.md'), false);
-});
-
-test('write-intercept: allows regular source files', () => {
-  assert.strictEqual(isBlockedStateFile('/project/src/index.ts'), false);
-});
-
-test('write-intercept: allows slice plan files', () => {
-  assert.strictEqual(isBlockedStateFile('/project/.gsd/milestones/M001/slices/S01/S01-PLAN.md'), false);
-});
-
-test('write-intercept: does not block files named STATE.md outside .gsd/', () => {
-  assert.strictEqual(isBlockedStateFile('/project/docs/STATE.md'), false);
-});
-
-// ─── BLOCKED_WRITE_ERROR: content ────────────────────────────────────────
-
-test('write-intercept: BLOCKED_WRITE_ERROR is a non-empty string', () => {
-  assert.strictEqual(typeof BLOCKED_WRITE_ERROR, 'string');
-  assert.ok(BLOCKED_WRITE_ERROR.length > 0);
-});
-
-test('write-intercept: BLOCKED_WRITE_ERROR mentions engine tool calls', () => {
-  assert.ok(BLOCKED_WRITE_ERROR.includes('gsd_complete_task'), 'should mention gsd_complete_task');
-  assert.ok(BLOCKED_WRITE_ERROR.includes('engine tool calls'), 'should mention engine tool calls');
-});

package/src/resources/extensions/gsd/tests/zombie-gsd-state.test.ts

@@ -1,95 +0,0 @@
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertTrue, assertMatch, assertNoMatch, report } = createTestContext();
-
-// ─── #2942: Zombie .gsd state skips init wizard ─────────────────────────────
-//
-// A partially initialized .gsd/ (symlink exists but no PREFERENCES.md or
-// milestones/) causes the init wizard gate in showSmartEntry to be skipped,
-// resulting in an uninitialized project session.
-
-console.log("\n=== #2942: zombie .gsd state must not skip init wizard ===");
-
-// ── guided-flow.ts — init wizard gate must check bootstrap completeness ──
-
-const guidedFlowSrc = readFileSync(
-  join(import.meta.dirname, "..", "guided-flow.ts"),
-  "utf-8",
-);
-
-// Find the showSmartEntry function
-const smartEntryIdx = guidedFlowSrc.indexOf("export async function showSmartEntry(");
-assertTrue(smartEntryIdx >= 0, "guided-flow.ts defines showSmartEntry");
-
-// Extract the region between showSmartEntry and the first showProjectInit call
-// This is where the init wizard gate lives.
-const afterSmartEntry = smartEntryIdx >= 0 ? guidedFlowSrc.slice(smartEntryIdx, smartEntryIdx + 3000) : "";
-
-// The gate must NOT be a bare `!existsSync(gsdRoot(basePath))` check.
-// It must also verify that bootstrap artifacts (PREFERENCES.md or milestones/) exist.
-assertTrue(
-  afterSmartEntry.includes("PREFERENCES.md") || afterSmartEntry.includes("PREFERENCES"),
-  "init wizard gate checks for PREFERENCES.md, not just .gsd/ existence (#2942)",
-);
-
-assertTrue(
-  afterSmartEntry.includes("milestones"),
-  "init wizard gate checks for milestones/ directory, not just .gsd/ existence (#2942)",
-);
-
-// The init wizard should be shown when .gsd/ exists but has no bootstrap artifacts.
-// The old code was: if (!existsSync(gsdRoot(basePath))) { ... showProjectInit ... }
-// The fix should use a compound check so zombie states trigger the wizard.
-// Verify we no longer have the bare existence check as the sole gate.
-
-// Find the specific init wizard gate pattern — the detection preamble block.
-const detectionPreambleIdx = afterSmartEntry.indexOf("Detection preamble");
-const detectionRegion = detectionPreambleIdx >= 0
-  ? afterSmartEntry.slice(detectionPreambleIdx, detectionPreambleIdx + 600)
-  : afterSmartEntry.slice(0, 1500);
-
-// The gate condition must reference PREFERENCES.md or milestones (bootstrap artifacts)
-assertMatch(
-  detectionRegion,
-  /PREFERENCES\.md|milestones/,
-  "detection preamble gate references bootstrap artifacts, not just directory existence (#2942)",
-);
-
-// ── auto-start.ts — milestones/ dir creation must not be dead code ──────────
-
-console.log("\n=== #2942: auto-start milestones/ bootstrap not dead code ===");
-
-const autoStartSrc = readFileSync(
-  join(import.meta.dirname, "..", "auto-start.ts"),
-  "utf-8",
-);
-
-// After ensureGsdSymlink, the code that creates milestones/ must check for
-// the milestones directory specifically (not .gsd/ which ensureGsdSymlink already created).
-const symlinkIdx = autoStartSrc.indexOf("ensureGsdSymlink(base)");
-assertTrue(symlinkIdx >= 0, "auto-start.ts calls ensureGsdSymlink(base)");
-
-const afterSymlink = symlinkIdx >= 0 ? autoStartSrc.slice(symlinkIdx, symlinkIdx + 800) : "";
-
-// The milestones bootstrap must check milestones path, not gsdDir
-// Old (dead) code: if (!existsSync(gsdDir)) { mkdirSync(join(gsdDir, "milestones"), ...) }
-// Fixed code should check: if (!existsSync(milestonesPath)) or similar
-assertTrue(
-  afterSymlink.includes("milestones") && afterSymlink.includes("mkdirSync"),
-  "auto-start.ts creates milestones/ directory after ensureGsdSymlink (#2942)",
-);
-
-// The guard for milestones/ creation should NOT be `!existsSync(gsdDir)` —
-// that's dead code since ensureGsdSymlink already created gsdDir.
-// It should check for the milestones/ dir directly.
-const mkdirRegion = afterSymlink.slice(0, afterSymlink.indexOf("mkdirSync") + 200);
-assertMatch(
-  mkdirRegion,
-  /existsSync\([^)]*milestones/,
-  "milestones bootstrap checks milestones path existence, not .gsd/ (#2942)",
-);
-
-report();