lsd-pi 1.0.0 → 1.1.0

package/src/resources/extensions/gsd/tests/undo.test.ts

@@ -1,462 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import {
-  extractCommitShas,
-  findCommitsForUnit,
-  handleUndo,
-  handleUndoTask,
-  handleResetSlice,
-  uncheckTaskInPlan,
-} from "../undo.ts";
-import {
-  openDatabase,
-  closeDatabase,
-  insertMilestone,
-  insertSlice,
-  insertTask,
-  getTask,
-  getSlice,
-} from "../gsd-db.ts";
-import { invalidateAllCaches } from "../cache.ts";
-import { existsSync } from "node:fs";
-
-function makeTempDir(prefix: string): string {
-  return mkdtempSync(join(tmpdir(), `${prefix}-`));
-}
-
-test("handleUndo without --force only warns and leaves completed units intact", async () => {
-  const base = makeTempDir("gsd-undo-confirm");
-  try {
-    mkdirSync(join(base, ".gsd"), { recursive: true });
-    mkdirSync(join(base, ".gsd", "activity"), { recursive: true });
-    writeFileSync(
-      join(base, ".gsd", "completed-units.json"),
-      JSON.stringify(["execute-task/M001/S01/T01"]),
-      "utf-8",
-    );
-    writeFileSync(
-      join(base, ".gsd", "activity", "001-execute-task-M001-S01-T01.jsonl"),
-      "",
-      "utf-8",
-    );
-
-    const notifications: Array<{ message: string; level: string }> = [];
-    const ctx = {
-      ui: {
-        notify(message: string, level: string) {
-          notifications.push({ message, level });
-        },
-      },
-    };
-
-    await handleUndo("", ctx as any, {} as any, base);
-
-    assert.equal(notifications.length, 1);
-    assert.equal(notifications[0]?.level, "warning");
-    assert.match(notifications[0]?.message ?? "", /Run \/gsd undo --force to confirm\./);
-    assert.deepEqual(
-      JSON.parse(readFileSync(join(base, ".gsd", "completed-units.json"), "utf-8")),
-      ["execute-task/M001/S01/T01"],
-    );
-  } finally {
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("uncheckTaskInPlan flips a checked task back to unchecked", () => {
-  const base = makeTempDir("gsd-undo-plan");
-  try {
-    const sliceDir = join(base, ".gsd", "milestones", "M001", "slices", "S01");
-    mkdirSync(sliceDir, { recursive: true });
-    const planFile = join(sliceDir, "S01-PLAN.md");
-    writeFileSync(
-      planFile,
-      [
-        "# Slice Plan",
-        "",
-        "- [x] **T01**: Ship the feature",
-        "- [ ] **T02**: Follow-up",
-      ].join("\n"),
-      "utf-8",
-    );
-
-    assert.equal(uncheckTaskInPlan(base, "M001", "S01", "T01"), true);
-    assert.match(readFileSync(planFile, "utf-8"), /- \[ \] \*\*T01\*\*: Ship the feature/);
-  } finally {
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("findCommitsForUnit reads the newest matching activity log and dedupes SHAs", () => {
-  const base = makeTempDir("gsd-undo-activity");
-  try {
-    const activityDir = join(base, ".gsd", "activity");
-    mkdirSync(activityDir, { recursive: true });
-
-    writeFileSync(
-      join(activityDir, "2026-03-14-execute-task-M001-S01-T01.jsonl"),
-      `${JSON.stringify({
-        message: {
-          content: [
-            { type: "tool_result", content: "[main abc1234] old commit" },
-          ],
-        },
-      })}\n`,
-      "utf-8",
-    );
-
-    writeFileSync(
-      join(activityDir, "2026-03-15-execute-task-M001-S01-T01.jsonl"),
-      [
-        JSON.stringify({
-          message: {
-            content: [
-              { type: "tool_result", content: "[main deadbee] new commit\n[main cafe123] another commit" },
-              { type: "tool_result", content: "[main deadbee] duplicate commit" },
-            ],
-          },
-        }),
-        "{not-json}",
-      ].join("\n"),
-      "utf-8",
-    );
-
-    assert.deepEqual(
-      findCommitsForUnit(activityDir, "execute-task", "M001/S01/T01"),
-      ["deadbee", "cafe123"],
-    );
-  } finally {
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("extractCommitShas returns unique commit hashes from git output blocks", () => {
-  const content = [
-    "[main abc1234] first commit",
-    "[feature deadbeef] second commit",
-    "[main abc1234] duplicate commit",
-  ].join("\n");
-
-  assert.deepEqual(extractCommitShas(content), ["abc1234", "deadbeef"]);
-});
-
-test("extractCommitShas ignores malformed commit tokens", () => {
-  const content = [
-    "[main abc1234; touch /tmp/pwned] not a real sha token",
-    "[main not-a-sha] ignored",
-    "[main 1234567] valid",
-  ].join("\n");
-
-  assert.deepEqual(extractCommitShas(content), ["1234567"]);
-});
-
-// ─── handleUndoTask tests ────────────────────────────────────────────────────
-
-function makeCtx(): { notifications: Array<{ message: string; level: string }>; ctx: any } {
-  const notifications: Array<{ message: string; level: string }> = [];
-  const ctx = {
-    ui: {
-      notify(message: string, level: string) {
-        notifications.push({ message, level });
-      },
-    },
-  };
-  return { notifications, ctx };
-}
-
-function setupTaskFixture(base: string): void {
-  // Create milestone/slice/task directory structure
-  const sliceDir = join(base, ".gsd", "milestones", "M001", "slices", "S01");
-  const tasksDir = join(sliceDir, "tasks");
-  mkdirSync(tasksDir, { recursive: true });
-
-  // Write plan file with checked task
-  writeFileSync(
-    join(sliceDir, "S01-PLAN.md"),
-    [
-      "# S01: Test Slice",
-      "",
-      "## Tasks",
-      "",
-      "- [x] **T01: First task** `est:30m`",
-      "- [ ] **T02: Second task** `est:30m`",
-    ].join("\n"),
-    "utf-8",
-  );
-
-  // Write task summary file
-  writeFileSync(
-    join(tasksDir, "T01-SUMMARY.md"),
-    "# T01 Summary\nDone.",
-    "utf-8",
-  );
-
-  // Set up DB
-  openDatabase(":memory:");
-  insertMilestone({ id: "M001", title: "Test Milestone", status: "active" });
-  insertSlice({ id: "S01", milestoneId: "M001", title: "Test Slice", status: "active", risk: "low", depends: [] });
-  insertTask({ id: "T01", sliceId: "S01", milestoneId: "M001", title: "First task", status: "complete" });
-  insertTask({ id: "T02", sliceId: "S01", milestoneId: "M001", title: "Second task", status: "pending" });
-  invalidateAllCaches();
-}
-
-test("handleUndoTask without args shows usage", async () => {
-  const { notifications, ctx } = makeCtx();
-  const base = makeTempDir("gsd-undo-task-usage");
-  try {
-    await handleUndoTask("", ctx, {} as any, base);
-    assert.equal(notifications.length, 1);
-    assert.equal(notifications[0]?.level, "warning");
-    assert.match(notifications[0]?.message ?? "", /Usage:/);
-  } finally {
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("handleUndoTask without --force shows confirmation", async () => {
-  const base = makeTempDir("gsd-undo-task-confirm");
-  try {
-    setupTaskFixture(base);
-    const { notifications, ctx } = makeCtx();
-    await handleUndoTask("M001/S01/T01", ctx, {} as any, base);
-    assert.equal(notifications.length, 1);
-    assert.equal(notifications[0]?.level, "warning");
-    assert.match(notifications[0]?.message ?? "", /--force to confirm/);
-    // Verify state was NOT modified
-    const task = getTask("M001", "S01", "T01");
-    assert.equal(task?.status, "complete");
-  } finally {
-    closeDatabase();
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("handleUndoTask with --force resets task and re-renders plan", async () => {
-  const base = makeTempDir("gsd-undo-task-force");
-  try {
-    setupTaskFixture(base);
-    const { notifications, ctx } = makeCtx();
-    await handleUndoTask("M001/S01/T01 --force", ctx, {} as any, base);
-
-    // DB status reset
-    const task = getTask("M001", "S01", "T01");
-    assert.equal(task?.status, "pending");
-
-    // Summary file deleted
-    const summaryPath = join(base, ".gsd", "milestones", "M001", "slices", "S01", "tasks", "T01-SUMMARY.md");
-    assert.equal(existsSync(summaryPath), false);
-
-    // Plan checkbox unchecked
-    const planContent = readFileSync(
-      join(base, ".gsd", "milestones", "M001", "slices", "S01", "S01-PLAN.md"),
-      "utf-8",
-    );
-    assert.match(planContent, /\[ \] \*\*T01:/);
-
-    // Success notification
-    assert.equal(notifications[0]?.level, "success");
-    assert.match(notifications[0]?.message ?? "", /Reset task M001\/S01\/T01/);
-  } finally {
-    closeDatabase();
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("handleUndoTask with non-existent task returns error", async () => {
-  const base = makeTempDir("gsd-undo-task-notfound");
-  try {
-    openDatabase(":memory:");
-    insertMilestone({ id: "M001", title: "Test", status: "active" });
-    insertSlice({ id: "S01", milestoneId: "M001", title: "Test", status: "active", risk: "low", depends: [] });
-
-    const { notifications, ctx } = makeCtx();
-    await handleUndoTask("M001/S01/T99 --force", ctx, {} as any, base);
-    assert.equal(notifications[0]?.level, "error");
-    assert.match(notifications[0]?.message ?? "", /not found/);
-  } finally {
-    closeDatabase();
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("handleUndoTask accepts partial ID (T01) and resolves from state", async () => {
-  const base = makeTempDir("gsd-undo-task-partial");
-  try {
-    setupTaskFixture(base);
-
-    // Create STATE.md so deriveState can resolve the active milestone/slice
-    mkdirSync(join(base, ".gsd"), { recursive: true });
-    writeFileSync(
-      join(base, ".gsd", "STATE.md"),
-      [
-        "# GSD State",
-        "",
-        "- Phase: executing",
-        "- Active Milestone: M001",
-        "- Active Slice: S01",
-        "- Active Task: T01",
-      ].join("\n"),
-      "utf-8",
-    );
-
-    const { notifications, ctx } = makeCtx();
-    await handleUndoTask("T01 --force", ctx, {} as any, base);
-
-    const task = getTask("M001", "S01", "T01");
-    assert.equal(task?.status, "pending");
-    assert.equal(notifications[0]?.level, "success");
-  } finally {
-    closeDatabase();
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-// ─── handleResetSlice tests ──────────────────────────────────────────────────
-
-function setupSliceFixture(base: string): void {
-  const mDir = join(base, ".gsd", "milestones", "M001");
-  const sliceDir = join(mDir, "slices", "S01");
-  const tasksDir = join(sliceDir, "tasks");
-  mkdirSync(tasksDir, { recursive: true });
-
-  // Write roadmap file
-  writeFileSync(
-    join(mDir, "M001-ROADMAP.md"),
-    [
-      "# Roadmap",
-      "",
-      "## Slices",
-      "",
-      "- [x] **S01: Test Slice** `risk:low` `depends:[]`",
-      "- [ ] **S02: Next Slice** `risk:low` `depends:[S01]`",
-    ].join("\n"),
-    "utf-8",
-  );
-
-  // Write plan file
-  writeFileSync(
-    join(sliceDir, "S01-PLAN.md"),
-    [
-      "# S01: Test Slice",
-      "",
-      "## Tasks",
-      "",
-      "- [x] **T01: First task** `est:30m`",
-      "- [x] **T02: Second task** `est:30m`",
-    ].join("\n"),
-    "utf-8",
-  );
-
-  // Write task summaries
-  writeFileSync(join(tasksDir, "T01-SUMMARY.md"), "# T01 Summary\nDone.", "utf-8");
-  writeFileSync(join(tasksDir, "T02-SUMMARY.md"), "# T02 Summary\nDone.", "utf-8");
-
-  // Write slice summary and UAT
-  writeFileSync(join(sliceDir, "S01-SUMMARY.md"), "# Slice Summary\nDone.", "utf-8");
-  writeFileSync(join(sliceDir, "S01-UAT.md"), "# UAT\nPassed.", "utf-8");
-
-  // Set up DB
-  openDatabase(":memory:");
-  insertMilestone({ id: "M001", title: "Test Milestone", status: "active" });
-  insertSlice({ id: "S01", milestoneId: "M001", title: "Test Slice", status: "complete", risk: "low", depends: [] });
-  insertSlice({ id: "S02", milestoneId: "M001", title: "Next Slice", status: "pending", risk: "low", depends: ["S01"] });
-  insertTask({ id: "T01", sliceId: "S01", milestoneId: "M001", title: "First task", status: "complete" });
-  insertTask({ id: "T02", sliceId: "S01", milestoneId: "M001", title: "Second task", status: "complete" });
-  invalidateAllCaches();
-}
-
-test("handleResetSlice without args shows usage", async () => {
-  const { notifications, ctx } = makeCtx();
-  const base = makeTempDir("gsd-reset-slice-usage");
-  try {
-    await handleResetSlice("", ctx, {} as any, base);
-    assert.equal(notifications.length, 1);
-    assert.equal(notifications[0]?.level, "warning");
-    assert.match(notifications[0]?.message ?? "", /Usage:/);
-  } finally {
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("handleResetSlice without --force shows confirmation", async () => {
-  const base = makeTempDir("gsd-reset-slice-confirm");
-  try {
-    setupSliceFixture(base);
-    const { notifications, ctx } = makeCtx();
-    await handleResetSlice("M001/S01", ctx, {} as any, base);
-    assert.equal(notifications[0]?.level, "warning");
-    assert.match(notifications[0]?.message ?? "", /--force to confirm/);
-    // State not modified
-    const slice = getSlice("M001", "S01");
-    assert.equal(slice?.status, "complete");
-  } finally {
-    closeDatabase();
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("handleResetSlice with --force resets slice and all tasks", async () => {
-  const base = makeTempDir("gsd-reset-slice-force");
-  try {
-    setupSliceFixture(base);
-    const { notifications, ctx } = makeCtx();
-    await handleResetSlice("M001/S01 --force", ctx, {} as any, base);
-
-    // DB status reset
-    const slice = getSlice("M001", "S01");
-    assert.equal(slice?.status, "active");
-    const t1 = getTask("M001", "S01", "T01");
-    assert.equal(t1?.status, "pending");
-    const t2 = getTask("M001", "S01", "T02");
-    assert.equal(t2?.status, "pending");
-
-    // Task summaries deleted
-    const tasksDir = join(base, ".gsd", "milestones", "M001", "slices", "S01", "tasks");
-    assert.equal(existsSync(join(tasksDir, "T01-SUMMARY.md")), false);
-    assert.equal(existsSync(join(tasksDir, "T02-SUMMARY.md")), false);
-
-    // Slice summary and UAT deleted
-    const sliceDir = join(base, ".gsd", "milestones", "M001", "slices", "S01");
-    assert.equal(existsSync(join(sliceDir, "S01-SUMMARY.md")), false);
-    assert.equal(existsSync(join(sliceDir, "S01-UAT.md")), false);
-
-    // Plan checkboxes unchecked
-    const planContent = readFileSync(join(sliceDir, "S01-PLAN.md"), "utf-8");
-    assert.match(planContent, /\[ \] \*\*T01:/);
-    assert.match(planContent, /\[ \] \*\*T02:/);
-
-    // Roadmap checkbox unchecked
-    const roadmapContent = readFileSync(
-      join(base, ".gsd", "milestones", "M001", "M001-ROADMAP.md"),
-      "utf-8",
-    );
-    assert.match(roadmapContent, /\[ \] \*\*S01:/);
-
-    // Success notification
-    assert.equal(notifications[0]?.level, "success");
-    assert.match(notifications[0]?.message ?? "", /Reset slice M001\/S01/);
-  } finally {
-    closeDatabase();
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("handleResetSlice with non-existent slice returns error", async () => {
-  const base = makeTempDir("gsd-reset-slice-notfound");
-  try {
-    openDatabase(":memory:");
-    insertMilestone({ id: "M001", title: "Test", status: "active" });
-
-    const { notifications, ctx } = makeCtx();
-    await handleResetSlice("M001/S99 --force", ctx, {} as any, base);
-    assert.equal(notifications[0]?.level, "error");
-    assert.match(notifications[0]?.message ?? "", /not found/);
-  } finally {
-    closeDatabase();
-    rmSync(base, { recursive: true, force: true });
-  }
-});

package/src/resources/extensions/gsd/tests/unique-milestone-ids.test.ts

@@ -1,203 +0,0 @@
-// Tests for unique milestone ID exports from T01/S01 — covers the S01→S02 boundary contract.
-//
-// Sections:
-//   (a) MILESTONE_ID_RE: regex matching/rejection
-//   (b) extractMilestoneSeq: old/new/invalid → number
-//   (c) parseMilestoneId: old/new/invalid → structured result
-//   (d) milestoneIdSort: ordering of mixed arrays
-//   (e) generateMilestoneSuffix: format, length, uniqueness
-//   (f) nextMilestoneId: uniqueEnabled true/false, mixed arrays
-//   (g) maxMilestoneNum: empty, old, new, mixed, non-matching
-//   (h) Preferences round-trip: validate, merge behavior via renderPreferencesForSystemPrompt
-
-import {
-  MILESTONE_ID_RE,
-  extractMilestoneSeq,
-  parseMilestoneId,
-  milestoneIdSort,
-  generateMilestoneSuffix,
-  nextMilestoneId,
-  maxMilestoneNum,
-} from '../guided-flow.ts';
-
-import { renderPreferencesForSystemPrompt } from '../preferences.ts';
-import type { GSDPreferences } from '../preferences.ts';
-import { describe, test } from 'node:test';
-import assert from 'node:assert/strict';
-
-
-// ─── Tests ─────────────────────────────────────────────────────────────────
-
-describe('unique-milestone-ids', async () => {
-  console.log('unique-milestone-ids tests');
-
-  // (a) MILESTONE_ID_RE
-  {
-    console.log('  (a) MILESTONE_ID_RE');
-    // Should match
-    assert.ok(MILESTONE_ID_RE.test('M001'), 'matches M001');
-    assert.ok(MILESTONE_ID_RE.test('M999'), 'matches M999');
-    assert.ok(MILESTONE_ID_RE.test('M001-abc123'), 'matches M001-abc123');
-    assert.ok(MILESTONE_ID_RE.test('M042-z9a8b7'), 'matches M042-z9a8b7');
-
-    // Should reject
-    assert.ok(!MILESTONE_ID_RE.test('M1'), 'rejects M1 (too few digits)');
-    assert.ok(!MILESTONE_ID_RE.test('M0001'), 'rejects M0001 (too many digits)');
-    assert.ok(!MILESTONE_ID_RE.test('M001-ABCDEF'), 'rejects M001-ABCDEF (uppercase prefix)');
-    assert.ok(!MILESTONE_ID_RE.test('M001-short'), 'rejects M001-short (5-char prefix)');
-    assert.ok(!MILESTONE_ID_RE.test('M001-toolong1'), 'rejects M001-toolong1 (>6-char prefix)');
-    assert.ok(!MILESTONE_ID_RE.test('IM001'), 'rejects IM001 (prefix before M)');
-    assert.ok(!MILESTONE_ID_RE.test(''), 'rejects empty string');
-    assert.ok(!MILESTONE_ID_RE.test('M001extra'), 'rejects M001extra (trailing chars)');
-    assert.ok(!MILESTONE_ID_RE.test('notes'), 'rejects non-milestone string');
-  }
-
-  // (b) extractMilestoneSeq
-  {
-    console.log('  (b) extractMilestoneSeq');
-    // Old format
-    assert.deepStrictEqual(extractMilestoneSeq('M001'), 1, 'M001 → 1');
-    assert.deepStrictEqual(extractMilestoneSeq('M042'), 42, 'M042 → 42');
-    assert.deepStrictEqual(extractMilestoneSeq('M999'), 999, 'M999 → 999');
-
-    // Unique format
-    assert.deepStrictEqual(extractMilestoneSeq('M001-abc123'), 1, 'M001-abc123 → 1');
-    assert.deepStrictEqual(extractMilestoneSeq('M042-z9a8b7'), 42, 'M042-z9a8b7 → 42');
-
-    // Invalid → 0
-    assert.deepStrictEqual(extractMilestoneSeq(''), 0, 'empty → 0');
-    assert.deepStrictEqual(extractMilestoneSeq('notes'), 0, 'notes → 0');
-    assert.deepStrictEqual(extractMilestoneSeq('M1'), 0, 'M1 → 0');
-    assert.deepStrictEqual(extractMilestoneSeq('.DS_Store'), 0, '.DS_Store → 0');
-    assert.deepStrictEqual(extractMilestoneSeq('M-ABC-001'), 0, 'M-ABC-001 (old format) → 0');
-  }
-
-  // (c) parseMilestoneId
-  {
-    console.log('  (c) parseMilestoneId');
-    // Old format — no suffix
-    assert.deepStrictEqual(parseMilestoneId('M001'), { num: 1 }, 'M001 → { num: 1 }');
-    assert.deepStrictEqual(parseMilestoneId('M042'), { num: 42 }, 'M042 → { num: 42 }');
-
-    // Unique format — with suffix
-    assert.deepStrictEqual(parseMilestoneId('M001-abc123'), { suffix: 'abc123', num: 1 }, 'M001-abc123 → { suffix, num }');
-    assert.deepStrictEqual(parseMilestoneId('M042-z9a8b7'), { suffix: 'z9a8b7', num: 42 }, 'M042-z9a8b7 → { suffix, num }');
-
-    // Invalid → { num: 0 }
-    assert.deepStrictEqual(parseMilestoneId(''), { num: 0 }, 'empty → { num: 0 }');
-    assert.deepStrictEqual(parseMilestoneId('notes'), { num: 0 }, 'notes → { num: 0 }');
-    assert.deepStrictEqual(parseMilestoneId('M001-ABCDEF'), { num: 0 }, 'uppercase suffix → { num: 0 }');
-    assert.deepStrictEqual(parseMilestoneId('M1'), { num: 0 }, 'M1 → { num: 0 }');
-  }
-
-  // (d) milestoneIdSort
-  {
-    console.log('  (d) milestoneIdSort');
-    const mixed = ['M003-abc123', 'M001', 'M002-z9a8b7'];
-    const sorted = [...mixed].sort(milestoneIdSort);
-    assert.deepStrictEqual(sorted, ['M001', 'M002-z9a8b7', 'M003-abc123'], 'sorts mixed IDs by sequence number');
-
-    // All old format
-    const oldOnly = ['M003', 'M001', 'M002'];
-    assert.deepStrictEqual([...oldOnly].sort(milestoneIdSort), ['M001', 'M002', 'M003'], 'sorts old-format IDs');
-
-    // Invalid entries sort to front (seq 0)
-    const withInvalid = ['M002', 'notes', 'M001'];
-    assert.deepStrictEqual([...withInvalid].sort(milestoneIdSort), ['notes', 'M001', 'M002'], 'invalid entries (seq 0) sort first');
-  }
-
-  // (e) generateMilestoneSuffix
-  {
-    console.log('  (e) generateMilestoneSuffix');
-    const suffix1 = generateMilestoneSuffix();
-    assert.deepStrictEqual(suffix1.length, 6, 'suffix length is 6');
-    assert.match(suffix1, /^[a-z0-9]{6}$/, 'suffix matches [a-z0-9]{6}');
-
-    const suffix2 = generateMilestoneSuffix();
-    assert.deepStrictEqual(suffix2.length, 6, 'second suffix length is 6');
-    assert.match(suffix2, /^[a-z0-9]{6}$/, 'second suffix matches [a-z0-9]{6}');
-
-    // Two calls should produce different results (36^6 = ~2.2B possibilities)
-    assert.ok(suffix1 !== suffix2, 'two calls produce different suffixes');
-  }
-
-  // (f) nextMilestoneId
-  {
-    console.log('  (f) nextMilestoneId');
-    // uniqueEnabled=false (default) → old format
-    assert.deepStrictEqual(nextMilestoneId([]), 'M001', 'empty + uniqueEnabled=false → M001');
-    assert.deepStrictEqual(nextMilestoneId(['M001', 'M002']), 'M003', 'sequential + uniqueEnabled=false → M003');
-    assert.deepStrictEqual(nextMilestoneId(['M001', 'M002'], false), 'M003', 'explicit false → M003');
-
-    // uniqueEnabled=true → unique format
-    const newId = nextMilestoneId([], true);
-    assert.match(newId, MILESTONE_ID_RE, 'uniqueEnabled=true produces valid ID');
-    assert.ok(newId.startsWith('M001-'), 'uniqueEnabled=true starts with M001-');
-    assert.match(newId, /^M001-[a-z0-9]{6}$/, 'empty + uniqueEnabled=true → M001-{rand6}');
-
-    // Mixed array with uniqueEnabled=true
-    const mixedIds = ['M001', 'M003-abc123', 'M002'];
-    const nextNew = nextMilestoneId(mixedIds, true);
-    assert.match(nextNew, MILESTONE_ID_RE, 'mixed array + uniqueEnabled=true → valid ID');
-    assert.match(nextNew, /^M004-[a-z0-9]{6}$/, 'mixed array max=3 → M004-{rand6}');
-
-    // Mixed array with uniqueEnabled=false
-    assert.deepStrictEqual(nextMilestoneId(mixedIds, false), 'M004', 'mixed array + uniqueEnabled=false → M004');
-
-    // Correct sequential number from mixed arrays
-    const mixedIds2 = ['M005-xyz999', 'M002'];
-    assert.deepStrictEqual(nextMilestoneId(mixedIds2, false), 'M006', 'mixed max=5 → M006');
-    const nextNew2 = nextMilestoneId(mixedIds2, true);
-    assert.match(nextNew2, /^M006-[a-z0-9]{6}$/, 'mixed max=5 + unique → M006-{rand6}');
-  }
-
-  // (g) maxMilestoneNum
-  {
-    console.log('  (g) maxMilestoneNum');
-    // Empty
-    assert.deepStrictEqual(maxMilestoneNum([]), 0, 'empty → 0');
-
-    // Old format only
-    assert.deepStrictEqual(maxMilestoneNum(['M001', 'M002', 'M003']), 3, 'old format only → 3');
-
-    // Unique format only — must not return NaN
-    assert.deepStrictEqual(maxMilestoneNum(['M001-abc123', 'M002-def456']), 2, 'unique format only → 2');
-    assert.ok(!Number.isNaN(maxMilestoneNum(['M001-abc123'])), 'unique format does not return NaN');
-
-    // Mixed formats
-    assert.deepStrictEqual(maxMilestoneNum(['M001', 'M003-abc123', 'M002']), 3, 'mixed → 3');
-
-    // Non-matching entries ignored
-    assert.deepStrictEqual(maxMilestoneNum(['M001', 'notes', '.DS_Store', 'M003']), 3, 'non-matching ignored → 3');
-    assert.deepStrictEqual(maxMilestoneNum(['notes', '.DS_Store']), 0, 'all non-matching → 0');
-  }
-
-  // (h) Preferences round-trip via renderPreferencesForSystemPrompt
-  {
-    console.log('  (h) Preferences round-trip');
-
-    // validate { unique_milestone_ids: true } → field preserved (no validation error)
-    const prefsTrue: GSDPreferences = { unique_milestone_ids: true };
-    const renderedTrue = renderPreferencesForSystemPrompt(prefsTrue);
-    assert.ok(!renderedTrue.includes('some preference values were ignored'), 'unique_milestone_ids: true validates without error');
-
-    // validate { unique_milestone_ids: undefined } → field absent (no error)
-    const prefsUndefined: GSDPreferences = {};
-    const renderedUndefined = renderPreferencesForSystemPrompt(prefsUndefined);
-    assert.ok(!renderedUndefined.includes('some preference values were ignored'), 'undefined unique_milestone_ids validates without error');
-
-    // validate { unique_milestone_ids: false } → also valid
-    const prefsFalse: GSDPreferences = { unique_milestone_ids: false };
-    const renderedFalse = renderPreferencesForSystemPrompt(prefsFalse);
-    assert.ok(!renderedFalse.includes('some preference values were ignored'), 'unique_milestone_ids: false validates without error');
-
-    // validate coercion: truthy non-boolean → coerced to boolean (no crash)
-    const prefsCoerced: GSDPreferences = { unique_milestone_ids: 1 as unknown as boolean };
-    const renderedCoerced = renderPreferencesForSystemPrompt(prefsCoerced);
-    assert.ok(!renderedCoerced.includes('some preference values were ignored'), 'truthy non-boolean coerces without validation error');
-
-    // GSDPreferences interface accepts the field (compile-time check — if this compiles, it works)
-    const prefs: GSDPreferences = { unique_milestone_ids: true, version: 1 };
-    assert.ok(prefs.unique_milestone_ids === true, 'GSDPreferences interface accepts unique_milestone_ids');
-  }
-});