lsd-pi 1.0.0 → 1.1.0

package/src/resources/extensions/gsd/tests/double-merge-guard.test.ts

@@ -1,97 +0,0 @@
-import { describe, test } from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-import { AutoSession } from "../auto/session.ts";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-describe("double mergeAndExit guard (#2645)", () => {
-  test("phases.ts sets milestoneMergedInPhases after mergeAndExit in milestone-complete path", () => {
-    // Source audit: the "complete" phase path must set the guard flag
-    // after calling mergeAndExit so that stopAuto skips the second merge.
-    const phasesSrc = readFileSync(
-      join(__dirname, "..", "auto", "phases.ts"),
-      "utf-8",
-    );
-
-    // Find the "complete" phase block
-    const completeIdx = phasesSrc.indexOf('state.phase === "complete"');
-    assert.ok(completeIdx > 0, "phases.ts should have a 'complete' phase check");
-
-    const afterComplete = phasesSrc.slice(completeIdx, completeIdx + 600);
-    const mergeIdx = afterComplete.indexOf("deps.resolver.mergeAndExit");
-    const flagIdx = afterComplete.indexOf("s.milestoneMergedInPhases = true");
-
-    assert.ok(mergeIdx > 0, "complete path should call mergeAndExit");
-    assert.ok(flagIdx > 0, "complete path should set milestoneMergedInPhases");
-    assert.ok(
-      flagIdx > mergeIdx,
-      "milestoneMergedInPhases must be set AFTER mergeAndExit (not before)",
-    );
-  });
-
-  test("phases.ts sets milestoneMergedInPhases after mergeAndExit in all-milestones-complete path", () => {
-    const phasesSrc = readFileSync(
-      join(__dirname, "..", "auto", "phases.ts"),
-      "utf-8",
-    );
-
-    // The "all milestones complete" block checks incomplete.length === 0
-    const allCompleteIdx = phasesSrc.indexOf("incomplete.length === 0");
-    assert.ok(allCompleteIdx > 0, "phases.ts should have an all-milestones-complete check");
-
-    const afterAllComplete = phasesSrc.slice(allCompleteIdx, allCompleteIdx + 600);
-    const mergeIdx = afterAllComplete.indexOf("deps.resolver.mergeAndExit");
-    const flagIdx = afterAllComplete.indexOf("s.milestoneMergedInPhases = true");
-
-    assert.ok(mergeIdx > 0, "all-complete path should call mergeAndExit");
-    assert.ok(flagIdx > 0, "all-complete path should set milestoneMergedInPhases");
-    assert.ok(
-      flagIdx > mergeIdx,
-      "milestoneMergedInPhases must be set AFTER mergeAndExit (not before)",
-    );
-  });
-
-  test("stopAuto checks milestoneMergedInPhases before calling mergeAndExit", () => {
-    const autoSrc = readFileSync(
-      join(__dirname, "..", "auto.ts"),
-      "utf-8",
-    );
-
-    // The Step 4 worktree exit block must check the guard flag
-    const step4Idx = autoSrc.indexOf("Step 4: Auto-worktree exit");
-    assert.ok(step4Idx > 0, "auto.ts should have Step 4 worktree exit");
-
-    const step4Block = autoSrc.slice(step4Idx, step4Idx + 600);
-    assert.ok(
-      step4Block.includes("milestoneMergedInPhases"),
-      "stopAuto Step 4 must check milestoneMergedInPhases before merging",
-    );
-    assert.ok(
-      step4Block.includes("!s.milestoneMergedInPhases"),
-      "stopAuto should skip merge when milestoneMergedInPhases is true",
-    );
-  });
-
-  test("AutoSession.milestoneMergedInPhases defaults to false", () => {
-    const session = new AutoSession();
-    assert.equal(
-      session.milestoneMergedInPhases,
-      false,
-      "new session should have milestoneMergedInPhases = false",
-    );
-  });
-
-  test("AutoSession.reset() clears milestoneMergedInPhases", () => {
-    const session = new AutoSession();
-    session.milestoneMergedInPhases = true;
-    session.reset();
-    assert.equal(
-      session.milestoneMergedInPhases,
-      false,
-      "reset() should clear milestoneMergedInPhases back to false",
-    );
-  });
-});

package/src/resources/extensions/gsd/tests/draft-promotion.test.ts

@@ -1,169 +0,0 @@
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, existsSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { deriveState } from "../state.js";
-import { resolveMilestoneFile } from "../paths.js";
-import { invalidateAllCaches } from "../cache.js";
-
-let passed = 0;
-let failed = 0;
-
-function assert(condition: boolean, message: string): void {
-  if (condition) {
-    passed++;
-  } else {
-    failed++;
-    console.error(`  FAIL: ${message}`);
-  }
-}
-
-// ─── Full state transition: needs-discussion → pre-planning ─────────────
-
-console.log("=== Draft promotion: full state transition ===");
-
-const tmpBase = mkdtempSync(join(tmpdir(), "gsd-draft-promotion-test-"));
-const gsd = join(tmpBase, ".gsd");
-
-mkdirSync(join(gsd, "milestones", "M001"), { recursive: true });
-
-// Step 1: Create CONTEXT-DRAFT.md only → needs-discussion
-const draftPath = join(gsd, "milestones", "M001", "M001-CONTEXT-DRAFT.md");
-writeFileSync(draftPath, "# M001: Draft\n\nSeed material.\n");
-
-const state1 = await deriveState(tmpBase);
-assert(
-  state1.phase === "needs-discussion",
-  `draft-only should be 'needs-discussion', got: "${state1.phase}"`,
-);
-
-// Step 2: Write CONTEXT.md (simulating discussion output) → pre-planning
-const contextPath = join(gsd, "milestones", "M001", "M001-CONTEXT.md");
-writeFileSync(contextPath, "# M001: Full Context\n\nDeep discussion output.\n");
-
-invalidateAllCaches();
-const state2 = await deriveState(tmpBase);
-assert(
-  state2.phase === "pre-planning",
-  `after CONTEXT.md written, should be 'pre-planning', got: "${state2.phase}"`,
-);
-
-// Step 3: Simulate draft cleanup (what checkAutoStartAfterDiscuss does)
-const resolvedDraft = resolveMilestoneFile(tmpBase, "M001", "CONTEXT-DRAFT");
-assert(
-  resolvedDraft !== null && resolvedDraft !== undefined,
-  "CONTEXT-DRAFT.md should still exist before cleanup",
-);
-
-// Delete the draft (simulating the cleanup in checkAutoStartAfterDiscuss)
-const { unlinkSync } = await import("node:fs");
-try {
-  if (resolvedDraft) unlinkSync(resolvedDraft);
-} catch { /* non-fatal */ }
-
-assert(
-  !existsSync(draftPath),
-  "CONTEXT-DRAFT.md should be deleted after promotion cleanup",
-);
-
-// Step 4: After cleanup, state is still pre-planning (CONTEXT.md exists)
-invalidateAllCaches();
-const state3 = await deriveState(tmpBase);
-assert(
-  state3.phase === "pre-planning",
-  `after cleanup, should still be 'pre-planning', got: "${state3.phase}"`,
-);
-
-// ─── No-draft case: cleanup is a no-op ──────────────────────────────────
-
-console.log("=== No-draft cleanup: no-op ===");
-
-const tmpBase2 = mkdtempSync(join(tmpdir(), "gsd-draft-promotion-noop-"));
-const gsd2 = join(tmpBase2, ".gsd");
-
-mkdirSync(join(gsd2, "milestones", "M001"), { recursive: true });
-writeFileSync(
-  join(gsd2, "milestones", "M001", "M001-CONTEXT.md"),
-  "# M001: Normal\n\nStandard discussion output.\n",
-);
-
-// No CONTEXT-DRAFT.md exists — cleanup should be a no-op
-const noDraft = resolveMilestoneFile(tmpBase2, "M001", "CONTEXT-DRAFT");
-assert(
-  noDraft === null || noDraft === undefined,
-  "no CONTEXT-DRAFT.md should exist for standard discussion milestone",
-);
-
-// deriveState should return pre-planning normally
-const state4 = await deriveState(tmpBase2);
-assert(
-  state4.phase === "pre-planning",
-  `standard discussion milestone should be 'pre-planning', got: "${state4.phase}"`,
-);
-
-// ─── Both files exist → CONTEXT.md wins, draft cleanup works ───────────
-
-console.log("=== Both files: CONTEXT wins, draft cleanable ===");
-
-const tmpBase3 = mkdtempSync(join(tmpdir(), "gsd-draft-promotion-both-"));
-const gsd3 = join(tmpBase3, ".gsd");
-
-mkdirSync(join(gsd3, "milestones", "M001"), { recursive: true });
-writeFileSync(
-  join(gsd3, "milestones", "M001", "M001-CONTEXT.md"),
-  "# M001: Full\n\nFull context.\n",
-);
-const bothDraftPath = join(gsd3, "milestones", "M001", "M001-CONTEXT-DRAFT.md");
-writeFileSync(bothDraftPath, "# M001: Draft\n\nStale draft.\n");
-
-const state5 = await deriveState(tmpBase3);
-assert(
-  state5.phase === "pre-planning",
-  `both files: CONTEXT.md wins, should be 'pre-planning', got: "${state5.phase}"`,
-);
-
-// Cleanup the stale draft
-const bothDraft = resolveMilestoneFile(tmpBase3, "M001", "CONTEXT-DRAFT");
-try {
-  if (bothDraft) unlinkSync(bothDraft);
-} catch { /* non-fatal */ }
-
-assert(
-  !existsSync(bothDraftPath),
-  "stale CONTEXT-DRAFT.md should be deleted in both-files case",
-);
-
-// ─── Static: guided-flow.ts has cleanup code ───────────────────────────
-
-console.log("=== Static: cleanup code in guided-flow.ts ===");
-
-const { readFileSync } = await import("node:fs");
-const guidedFlowSource = readFileSync(
-  join(import.meta.dirname, "..", "guided-flow.ts"),
-  "utf-8",
-);
-
-const checkFnIdx = guidedFlowSource.indexOf("checkAutoStartAfterDiscuss");
-const checkFnEnd = guidedFlowSource.indexOf("\nexport ", checkFnIdx + 1);
-const checkFnChunk = guidedFlowSource.slice(checkFnIdx, checkFnEnd > checkFnIdx ? checkFnEnd : checkFnIdx + 5000);
-
-assert(
-  checkFnChunk.includes("CONTEXT-DRAFT"),
-  "checkAutoStartAfterDiscuss should reference CONTEXT-DRAFT for cleanup",
-);
-
-assert(
-  checkFnChunk.includes("unlinkSync"),
-  "checkAutoStartAfterDiscuss should use unlinkSync to delete the draft",
-);
-
-// ─── Cleanup ──────────────────────────────────────────────────────────
-
-rmSync(tmpBase, { recursive: true, force: true });
-rmSync(tmpBase2, { recursive: true, force: true });
-rmSync(tmpBase3, { recursive: true, force: true });
-
-// ─── Results ──────────────────────────────────────────────────────────
-
-console.log(`\ndraft-promotion: ${passed} passed, ${failed} failed`);
-if (failed > 0) process.exit(1);

package/src/resources/extensions/gsd/tests/dynamic-routing-default.test.ts

@@ -1,20 +0,0 @@
-/**
- * Dynamic routing default — verifies routing is enabled by default.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { defaultRoutingConfig } from "../model-router.js";
-
-test("defaultRoutingConfig returns enabled: true", () => {
-  const config = defaultRoutingConfig();
-  assert.equal(config.enabled, true, "dynamic routing should be enabled by default");
-});
-
-test("defaultRoutingConfig enables all routing features", () => {
-  const config = defaultRoutingConfig();
-  assert.equal(config.escalate_on_failure, true);
-  assert.equal(config.budget_pressure, true);
-  assert.equal(config.cross_provider, true);
-  assert.equal(config.hooks, true);
-});

package/src/resources/extensions/gsd/tests/empty-content-abort-loop.test.ts

@@ -1,74 +0,0 @@
-/**
- * empty-content-abort-loop.test.ts — Regression test for #2695.
- *
- * When the LLM sends an assistant message with empty `content: []` and
- * `stopReason: "aborted"`, this is NOT a fatal abort — it is a non-fatal
- * end-of-turn. The abort handler in agent-end-recovery.ts must distinguish
- * this case and NOT pause auto-mode, allowing the loop to continue via
- * resolveAgentEnd instead of entering a stuck re-dispatch loop.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const RECOVERY_PATH = join(__dirname, "..", "bootstrap", "agent-end-recovery.ts");
-
-function getRecoverySource(): string {
-  return readFileSync(RECOVERY_PATH, "utf-8");
-}
-
-test("agent-end-recovery.ts does not pause on aborted messages with empty content (#2695)", () => {
-  const source = getRecoverySource();
-
-  // The abort handler at `stopReason === "aborted"` must check for empty content
-  // before deciding to pause. An empty content array is a non-fatal agent stop.
-  const abortIdx = source.indexOf('stopReason === "aborted"');
-  assert.ok(abortIdx > -1, "abort handler must exist in agent-end-recovery.ts");
-
-  // Extract the region around the abort handler (enough to see the guard logic)
-  const abortRegion = source.slice(Math.max(0, abortIdx - 200), abortIdx + 600);
-
-  // Must check for empty content before pausing
-  assert.ok(
-    abortRegion.includes("content") && (abortRegion.includes("length") || abortRegion.includes("?.length")),
-    "abort handler must inspect content array length to distinguish empty-content aborts from fatal aborts (#2695)",
-  );
-});
-
-test("agent-end-recovery.ts routes empty-content aborted messages to resolveAgentEnd (#2695)", () => {
-  const source = getRecoverySource();
-
-  // The abort block must have a path that calls resolveAgentEnd for empty-content messages
-  // instead of unconditionally calling pauseAuto
-  const abortIdx = source.indexOf('stopReason === "aborted"');
-  assert.ok(abortIdx > -1, "abort handler must exist");
-
-  // Get the full abort handling block (from the if to the next stopReason check or success path)
-  const afterAbort = source.slice(abortIdx, abortIdx + 800);
-
-  // The abort block must have a code path that calls resolveAgentEnd (for empty-content case)
-  assert.ok(
-    afterAbort.includes("resolveAgentEnd"),
-    "abort handler must route empty-content aborted messages to resolveAgentEnd instead of always pausing (#2695)",
-  );
-});
-
-test("agent-end-recovery.ts checks for errorMessage presence in abort handler (#2695)", () => {
-  const source = getRecoverySource();
-
-  const abortIdx = source.indexOf('stopReason === "aborted"');
-  assert.ok(abortIdx > -1, "abort handler must exist");
-
-  const abortRegion = source.slice(abortIdx, abortIdx + 600);
-
-  // Fatal aborts should have error context (errorMessage field).
-  // The handler should check for this to distinguish fatal from non-fatal aborts.
-  assert.ok(
-    abortRegion.includes("errorMessage"),
-    "abort handler must check for errorMessage to distinguish fatal aborts from empty-content non-fatal stops (#2695)",
-  );
-});

package/src/resources/extensions/gsd/tests/engine-interfaces-contract.test.ts

@@ -1,271 +0,0 @@
-/**
- * engine-interfaces-contract.test.ts — Source-level contract tests for the
- * engine abstraction layer (S01).
- *
- * TypeScript interfaces are erased by --experimental-strip-types, so these
- * tests use source-level regex assertions on the .ts files to verify shapes.
- * Runtime assertions cover AutoSession.activeEngineId and resolveEngine().
- *
- * Follows the same conventions as auto-session-encapsulation.test.ts.
- */
-
-import test, { describe } from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const ENGINE_TYPES_PATH = join(__dirname, "..", "engine-types.ts");
-const WORKFLOW_ENGINE_PATH = join(__dirname, "..", "workflow-engine.ts");
-const EXECUTION_POLICY_PATH = join(__dirname, "..", "execution-policy.ts");
-const ENGINE_RESOLVER_PATH = join(__dirname, "..", "engine-resolver.ts");
-
-function readSource(path: string): string {
-  return readFileSync(path, "utf-8");
-}
-
-// ── Import smoke tests ──────────────────────────────────────────────────────
-
-describe("Import smoke tests", () => {
-  test("engine-types.ts can be dynamically imported", async () => {
-    const mod = await import("../engine-types.ts");
-    assert.ok(mod, "engine-types.ts should import without error");
-  });
-
-  test("workflow-engine.ts can be dynamically imported", async () => {
-    const mod = await import("../workflow-engine.ts");
-    assert.ok(mod, "workflow-engine.ts should import without error");
-  });
-
-  test("execution-policy.ts can be dynamically imported", async () => {
-    const mod = await import("../execution-policy.ts");
-    assert.ok(mod, "execution-policy.ts should import without error");
-  });
-
-  test("engine-resolver.ts can be dynamically imported", async () => {
-    const mod = await import("../engine-resolver.ts");
-    assert.ok(mod, "engine-resolver.ts should import without error");
-    assert.ok(
-      typeof mod.resolveEngine === "function",
-      "engine-resolver.ts should export resolveEngine function",
-    );
-  });
-});
-
-// ── Leaf-node constraint ────────────────────────────────────────────────────
-
-describe("Leaf-node constraint", () => {
-  test("engine-types.ts has zero imports from GSD modules (only node: allowed)", () => {
-    const source = readSource(ENGINE_TYPES_PATH);
-    const lines = source.split("\n");
-    const violations: string[] = [];
-
-    for (let i = 0; i < lines.length; i++) {
-      const line = lines[i]!;
-      // Match import lines that reference relative paths (../ or ./)
-      if (/^import\s/.test(line) && /['"]\.\.?\// .test(line)) {
-        violations.push(`line ${i + 1}: ${line.trim()}`);
-      }
-    }
-
-    assert.equal(
-      violations.length,
-      0,
-      `engine-types.ts must be a leaf node with zero GSD imports. ` +
-      `Only node: imports are allowed.\nViolations:\n${violations.join("\n")}`,
-    );
-  });
-});
-
-// ── EngineState shape ───────────────────────────────────────────────────────
-
-describe("EngineState shape", () => {
-  test("EngineState has all required fields with correct types", () => {
-    const source = readSource(ENGINE_TYPES_PATH);
-
-    const requiredFields = [
-      "phase",
-      "currentMilestoneId",
-      "activeSliceId",
-      "activeTaskId",
-      "isComplete",
-      "raw",
-    ];
-
-    for (const field of requiredFields) {
-      assert.ok(
-        source.includes(field),
-        `EngineState must contain field: ${field}`,
-      );
-    }
-
-    // raw must be typed unknown — not a GSD-specific type
-    assert.ok(
-      /raw:\s*unknown/.test(source),
-      "EngineState.raw must be typed 'unknown', not a GSD-specific type",
-    );
-  });
-});
-
-// ── EngineDispatchAction shape ──────────────────────────────────────────────
-
-describe("EngineDispatchAction shape", () => {
-  test("EngineDispatchAction has dispatch, stop, and skip variants", () => {
-    const source = readSource(ENGINE_TYPES_PATH);
-
-    assert.ok(
-      /action:\s*"dispatch"/.test(source),
-      'EngineDispatchAction must have action: "dispatch" variant',
-    );
-    assert.ok(
-      /action:\s*"stop"/.test(source),
-      'EngineDispatchAction must have action: "stop" variant',
-    );
-    assert.ok(
-      /action:\s*"skip"/.test(source),
-      'EngineDispatchAction must have action: "skip" variant',
-    );
-  });
-});
-
-// ── WorkflowEngine interface shape ──────────────────────────────────────────
-
-describe("WorkflowEngine interface shape", () => {
-  test("WorkflowEngine has engineId and all required methods", () => {
-    const source = readSource(WORKFLOW_ENGINE_PATH);
-
-    const requiredMembers = [
-      "engineId",
-      "deriveState",
-      "resolveDispatch",
-      "reconcile",
-      "getDisplayMetadata",
-    ];
-
-    for (const member of requiredMembers) {
-      assert.ok(
-        source.includes(member),
-        `WorkflowEngine must contain member: ${member}`,
-      );
-    }
-  });
-});
-
-// ── ExecutionPolicy interface shape ─────────────────────────────────────────
-
-describe("ExecutionPolicy interface shape", () => {
-  test("ExecutionPolicy has all required methods", () => {
-    const source = readSource(EXECUTION_POLICY_PATH);
-
-    const requiredMethods = [
-      "prepareWorkspace",
-      "selectModel",
-      "verify",
-      "recover",
-      "closeout",
-    ];
-
-    for (const method of requiredMethods) {
-      assert.ok(
-        source.includes(method),
-        `ExecutionPolicy must contain method: ${method}`,
-      );
-    }
-  });
-});
-
-// ── Resolver stub behavior ──────────────────────────────────────────────────
-
-describe("Resolver stub behavior", () => {
-  test("resolveEngine returns dev engine for null activeEngineId", async () => {
-    const { resolveEngine } = await import("../engine-resolver.ts");
-    const result = resolveEngine({ activeEngineId: null });
-    assert.ok(result.engine, "should return engine for null");
-    assert.equal(
-      result.engine.engineId,
-      "dev",
-      "engine.engineId should be 'dev' for null activeEngineId",
-    );
-  });
-
-  test("resolveEngine returns dev engine for 'dev' activeEngineId", async () => {
-    const { resolveEngine } = await import("../engine-resolver.ts");
-    const result = resolveEngine({ activeEngineId: "dev" });
-    assert.ok(result.engine, "should return engine for 'dev'");
-    assert.equal(
-      result.engine.engineId,
-      "dev",
-      "engine.engineId should be 'dev'",
-    );
-  });
-
-  test("resolveEngine throws for unknown activeEngineId without activeRunDir", async () => {
-    const { resolveEngine } = await import("../engine-resolver.ts");
-    assert.throws(
-      () => resolveEngine({ activeEngineId: "custom-xyz" }),
-      /activeRunDir/,
-      "resolveEngine should throw when custom engine has no activeRunDir",
-    );
-  });
-
-  test("resolveEngine returns custom engine for non-dev activeEngineId with activeRunDir", async () => {
-    const { resolveEngine } = await import("../engine-resolver.ts");
-    const result = resolveEngine({ activeEngineId: "custom-xyz", activeRunDir: "/tmp/test-run" });
-    assert.ok(result.engine, "should return engine for custom ID");
-    assert.equal(
-      result.engine.engineId,
-      "custom",
-      "engine.engineId should be 'custom' for non-dev activeEngineId",
-    );
-  });
-
-  test("ResolvedEngine type is exported (source check)", () => {
-    const source = readSource(ENGINE_RESOLVER_PATH);
-    assert.ok(
-      /export\s+(interface|type)\s+ResolvedEngine/.test(source),
-      "engine-resolver.ts must export ResolvedEngine type",
-    );
-  });
-});
-
-// ── AutoSession.activeEngineId ──────────────────────────────────────────────
-
-describe("AutoSession.activeEngineId", () => {
-  test("defaults to null on a fresh AutoSession", async () => {
-    const { AutoSession } = await import("../auto/session.ts");
-    const session = new AutoSession();
-    assert.equal(
-      session.activeEngineId,
-      null,
-      "activeEngineId should default to null",
-    );
-  });
-
-  test("is null after reset()", async () => {
-    const { AutoSession } = await import("../auto/session.ts");
-    const session = new AutoSession();
-    session.activeEngineId = "dev";
-    session.reset();
-    assert.equal(
-      session.activeEngineId,
-      null,
-      "activeEngineId should be null after reset()",
-    );
-  });
-
-  test("appears in toJSON() output", async () => {
-    const { AutoSession } = await import("../auto/session.ts");
-    const session = new AutoSession();
-    const json = session.toJSON();
-    assert.ok(
-      "activeEngineId" in json,
-      "toJSON() must include activeEngineId",
-    );
-    assert.equal(
-      json.activeEngineId,
-      null,
-      "toJSON().activeEngineId should be null by default",
-    );
-  });
-});