lsd-pi 1.0.0 → 1.1.0

package/src/resources/extensions/gsd/tests/slice-disk-reconcile.test.ts

@@ -1,233 +0,0 @@
-/**
- * slice-disk-reconcile.test.ts — #2533
- *
- * Slices that exist on disk (in ROADMAP.md) but are missing from the SQLite
- * database cause permanent "No slice eligible — check dependency ordering"
- * blocks. deriveStateFromDb must reconcile disk slices into the DB, just as
- * it already does for milestones (#2416).
- *
- * Scenario: M001 has a ROADMAP with S01-S04. S01 and S02 have SUMMARY files
- * (complete on disk). S03 depends on S01. Only S04 is in the DB (depends on
- * S03). Without slice reconciliation, S01-S03 are invisible and S04 is
- * permanently blocked.
- */
-
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { deriveStateFromDb, invalidateStateCache } from "../state.ts";
-import {
-  openDatabase,
-  closeDatabase,
-  insertMilestone,
-  insertSlice,
-  getMilestoneSlices,
-} from "../gsd-db.ts";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertEq, assertTrue, report } = createTestContext();
-
-function createFixtureBase(): string {
-  const base = mkdtempSync(join(tmpdir(), "gsd-slice-reconcile-"));
-  mkdirSync(join(base, ".gsd", "milestones"), { recursive: true });
-  return base;
-}
-
-function writeFile(base: string, relativePath: string, content: string): void {
-  const full = join(base, ".gsd", relativePath);
-  mkdirSync(join(full, ".."), { recursive: true });
-  writeFileSync(full, content);
-}
-
-function cleanup(base: string): void {
-  rmSync(base, { recursive: true, force: true });
-}
-
-const CONTEXT_CONTENT = `# M001: Test Milestone
-
-This milestone tests slice reconciliation.
-
-## Must-Haves
-- Something important
-`;
-
-// Roadmap with 4 slices: S01 (no deps), S02 (no deps), S03 (depends S01), S04 (depends S03)
-const ROADMAP_CONTENT = `# M001: Test Milestone
-
-**Vision:** Test slice disk→DB reconciliation.
-
-## Slices
-
-- [x] **S01: Foundation** \`risk:low\` \`depends:[]\`
-  > Set up project structure.
-- [x] **S02: Core Utils** \`risk:low\` \`depends:[]\`
-  > Build utility functions.
-- [ ] **S03: Integration** \`risk:medium\` \`depends:[S01]\`
-  > Integrate components.
-- [ ] **S04: Final Assembly** \`risk:high\` \`depends:[S03]\`
-  > Assemble everything.
-`;
-
-async function testMissingSlicesCauseBlock(): Promise<void> {
-  console.log("\n--- Test: missing DB slices cause permanent block (pre-fix) ---");
-
-  const base = createFixtureBase();
-  const dbPath = join(base, ".gsd", "gsd.db");
-
-  try {
-    openDatabase(dbPath);
-
-    // M001 in DB
-    insertMilestone({ id: "M001", title: "M001: Test Milestone", status: "active", depends_on: [] });
-
-    // Only S04 is in the DB — S01-S03 are missing
-    insertSlice({ id: "S04", milestoneId: "M001", title: "S04: Final Assembly", status: "pending", risk: "high", depends: ["S03"] });
-
-    // Write disk files — S01 and S02 have SUMMARY (complete on disk)
-    writeFile(base, "milestones/M001/CONTEXT.md", CONTEXT_CONTENT);
-    writeFile(base, "milestones/M001/ROADMAP.md", ROADMAP_CONTENT);
-    writeFile(base, "milestones/M001/S01/PLAN.md", "# S01 Plan\n");
-    writeFile(base, "milestones/M001/S01/SUMMARY.md", "# S01 Summary\nDone.");
-    writeFile(base, "milestones/M001/S02/PLAN.md", "# S02 Plan\n");
-    writeFile(base, "milestones/M001/S02/SUMMARY.md", "# S02 Summary\nDone.");
-    writeFile(base, "milestones/M001/S03/PLAN.md", "# S03 Plan\n");
-
-    invalidateStateCache();
-    const state = await deriveStateFromDb(base);
-
-    // After the fix, slices S01-S03 should be reconciled into DB
-    const dbSlices = getMilestoneSlices("M001");
-    assertTrue(
-      dbSlices.length === 4,
-      `All 4 roadmap slices should be in DB after reconciliation, got ${dbSlices.length}`,
-    );
-
-    // S01 and S02 should be marked complete (have SUMMARY files)
-    const s01 = dbSlices.find(s => s.id === "S01");
-    assertTrue(s01 !== undefined, "S01 should exist in DB after reconciliation");
-    if (s01) {
-      assertEq(s01.status, "complete", "S01 should be 'complete' (has SUMMARY on disk)");
-    }
-
-    const s02 = dbSlices.find(s => s.id === "S02");
-    assertTrue(s02 !== undefined, "S02 should exist in DB after reconciliation");
-    if (s02) {
-      assertEq(s02.status, "complete", "S02 should be 'complete' (has SUMMARY on disk)");
-    }
-
-    // S03 should be pending (no SUMMARY)
-    const s03 = dbSlices.find(s => s.id === "S03");
-    assertTrue(s03 !== undefined, "S03 should exist in DB after reconciliation");
-    if (s03) {
-      assertEq(s03.status, "pending", "S03 should be 'pending' (no SUMMARY on disk)");
-    }
-
-    // The state should NOT be blocked — S03 should be eligible (S01 dep satisfied)
-    assertTrue(
-      state.phase !== "blocked",
-      `Phase should not be 'blocked' after reconciliation, got '${state.phase}'`,
-    );
-
-    // Active slice should be S03 (S01 dep met, S03 is first incomplete with satisfied deps)
-    assertTrue(
-      state.activeSlice !== null,
-      "There should be an active slice after reconciliation",
-    );
-    if (state.activeSlice) {
-      assertEq(
-        state.activeSlice.id,
-        "S03",
-        "Active slice should be S03 (its dependency S01 is complete) (#2533)",
-      );
-    }
-  } finally {
-    closeDatabase();
-    cleanup(base);
-  }
-}
-
-async function testSliceReconciliationIdempotent(): Promise<void> {
-  console.log("\n--- Test: slice reconciliation is idempotent ---");
-
-  const base = createFixtureBase();
-  const dbPath = join(base, ".gsd", "gsd.db");
-
-  try {
-    openDatabase(dbPath);
-
-    insertMilestone({ id: "M001", title: "M001: Test", status: "active", depends_on: [] });
-    // S01 already in DB with correct status
-    insertSlice({ id: "S01", milestoneId: "M001", title: "S01: Foundation", status: "complete", depends: [] });
-
-    writeFile(base, "milestones/M001/CONTEXT.md", CONTEXT_CONTENT);
-    writeFile(base, "milestones/M001/ROADMAP.md", ROADMAP_CONTENT);
-    writeFile(base, "milestones/M001/S01/PLAN.md", "# S01 Plan\n");
-    writeFile(base, "milestones/M001/S01/SUMMARY.md", "# S01 Summary\nDone.");
-    writeFile(base, "milestones/M001/S02/PLAN.md", "# S02 Plan\n");
-    writeFile(base, "milestones/M001/S02/SUMMARY.md", "# S02 Summary\nDone.");
-
-    invalidateStateCache();
-    await deriveStateFromDb(base);
-
-    // S01 should still be complete (not overwritten)
-    const dbSlices = getMilestoneSlices("M001");
-    const s01 = dbSlices.find(s => s.id === "S01");
-    assertTrue(s01 !== undefined, "S01 should still exist in DB");
-    if (s01) {
-      assertEq(s01.status, "complete", "S01 status should remain 'complete' (not overwritten)");
-    }
-
-    // S02-S04 should have been added
-    assertTrue(
-      dbSlices.length === 4,
-      `Should have 4 slices after reconciliation (existing + new), got ${dbSlices.length}`,
-    );
-  } finally {
-    closeDatabase();
-    cleanup(base);
-  }
-}
-
-async function testNoRoadmapSkipsReconciliation(): Promise<void> {
-  console.log("\n--- Test: no ROADMAP file skips slice reconciliation ---");
-
-  const base = createFixtureBase();
-  const dbPath = join(base, ".gsd", "gsd.db");
-
-  try {
-    openDatabase(dbPath);
-
-    insertMilestone({ id: "M001", title: "M001: No Roadmap", status: "active", depends_on: [] });
-
-    // Only a CONTEXT file, no ROADMAP
-    writeFile(base, "milestones/M001/CONTEXT.md", CONTEXT_CONTENT);
-
-    invalidateStateCache();
-    const state = await deriveStateFromDb(base);
-
-    const dbSlices = getMilestoneSlices("M001");
-    assertEq(dbSlices.length, 0, "No slices should be added when no ROADMAP exists");
-
-    // Should be in pre-planning (no roadmap)
-    assertEq(state.phase, "pre-planning", "Phase should be pre-planning with no roadmap");
-  } finally {
-    closeDatabase();
-    cleanup(base);
-  }
-}
-
-async function main(): Promise<void> {
-  console.log("\n=== #2533: deriveStateFromDb reconciles disk slices ===");
-
-  await testMissingSlicesCauseBlock();
-  await testSliceReconciliationIdempotent();
-  await testNoRoadmapSkipsReconciliation();
-
-  report();
-}
-
-main().catch((err) => {
-  console.error(err);
-  process.exit(1);
-});

package/src/resources/extensions/gsd/tests/smart-entry-complete.test.ts

@@ -1,53 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-const { deriveState } = await import("../state.js");
-
-test("deriveState reports complete when all milestone slices are done", async () => {
-  const base = mkdtempSync(join(tmpdir(), "gsd-smart-entry-complete-"));
-
-  try {
-    const milestoneDir = join(base, ".gsd", "milestones", "M001");
-    mkdirSync(milestoneDir, { recursive: true });
-
-    writeFileSync(
-      join(milestoneDir, "M001-ROADMAP.md"),
-      [
-        "# M001: Complete Milestone",
-        "",
-        "## Slices",
-        "- [x] **S01: Done slice** `risk:low` `depends:[]`",
-        "  > Done.",
-      ].join("\n"),
-    );
-
-    writeFileSync(
-      join(milestoneDir, "M001-SUMMARY.md"),
-      "# M001 Summary\n\nComplete.",
-    );
-
-    const state = await deriveState(base);
-    assert.equal(state.phase, "complete");
-    assert.equal(state.activeMilestone?.id, "M001");
-  } finally {
-    rmSync(base, { recursive: true, force: true });
-  }
-});
-
-test("guided-flow complete branch offers a chooser for next milestone or status", () => {
-  const guidedFlowSource = readFileSync(join(import.meta.dirname, "..", "guided-flow.ts"), "utf-8");
-  const branchIdx = guidedFlowSource.indexOf('state.phase === "complete"');
-
-  assert.ok(branchIdx > -1, "guided-flow.ts should have a complete-phase smart-entry branch");
-
-  const nextBranchIdx = guidedFlowSource.indexOf('state.phase === "needs-discussion"', branchIdx);
-  const branchChunk = guidedFlowSource.slice(branchIdx, nextBranchIdx === -1 ? branchIdx + 1600 : nextBranchIdx);
-
-  assert.match(branchChunk, /showNextAction\(/, "complete branch should present a chooser");
-  assert.match(branchChunk, /findMilestoneIds\(basePath\)/, "complete branch should compute the next milestone id");
-  assert.match(branchChunk, /nextMilestoneId(?:Reserved)?\(milestoneIds, uniqueMilestoneIds\)/, "complete branch should derive the next milestone id");
-  assert.match(branchChunk, /dispatchWorkflow\(pi, buildDiscussPrompt\(/, "complete branch should dispatch the discuss prompt");
-});

package/src/resources/extensions/gsd/tests/smart-entry-draft.test.ts

@@ -1,123 +0,0 @@
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { deriveState } from "../state.js";
-import { resolveMilestoneFile } from "../paths.js";
-
-let passed = 0;
-let failed = 0;
-
-function assert(condition: boolean, message: string): void {
-  if (condition) {
-    passed++;
-  } else {
-    failed++;
-    console.error(`  FAIL: ${message}`);
-  }
-}
-
-// ─── Fixture: milestone with only CONTEXT-DRAFT.md ──────────────────────
-
-const tmpBase = mkdtempSync(join(tmpdir(), "gsd-smart-entry-draft-test-"));
-const gsd = join(tmpBase, ".gsd");
-
-mkdirSync(join(gsd, "milestones", "M001"), { recursive: true });
-
-const draftContent = `# M001: Test Milestone — Context\n\n**Status:** Draft\n\nSeed material from a prior discussion.\n`;
-writeFileSync(
-  join(gsd, "milestones", "M001", "M001-CONTEXT-DRAFT.md"),
-  draftContent,
-);
-
-// ─── Test: deriveState returns 'needs-discussion' for draft-only milestone ───
-
-const state = await deriveState(tmpBase);
-
-assert(
-  state.phase === "needs-discussion",
-  `phase should be 'needs-discussion' for draft-only milestone, got: "${state.phase}"`,
-);
-
-assert(
-  state.activeMilestone?.id === "M001",
-  `active milestone should be M001, got: "${state.activeMilestone?.id}"`,
-);
-
-// ─── Test: resolveMilestoneFile resolves CONTEXT-DRAFT ─────────────────────
-
-const draftFile = resolveMilestoneFile(tmpBase, "M001", "CONTEXT-DRAFT");
-
-assert(
-  draftFile !== null && draftFile !== undefined,
-  `resolveMilestoneFile should resolve CONTEXT-DRAFT, got: ${draftFile}`,
-);
-
-assert(
-  draftFile!.endsWith("M001-CONTEXT-DRAFT.md"),
-  `resolved path should end with M001-CONTEXT-DRAFT.md, got: "${draftFile}"`,
-);
-
-// ─── Test: CONTEXT.md is NOT resolved (only draft exists) ──────────────────
-
-const contextFile = resolveMilestoneFile(tmpBase, "M001", "CONTEXT");
-
-assert(
-  contextFile === null || contextFile === undefined,
-  `resolveMilestoneFile should NOT resolve CONTEXT when only CONTEXT-DRAFT exists, got: "${contextFile}"`,
-);
-
-// ─── Static: guided-flow.ts has 'needs-discussion' branch ─────────────────
-
-const guidedFlowSource = readFileSync(
-  join(import.meta.dirname, "..", "guided-flow.ts"),
-  "utf-8",
-);
-
-assert(
-  guidedFlowSource.includes('state.phase === "needs-discussion"'),
-  "guided-flow.ts should have 'needs-discussion' phase check in showSmartEntry",
-);
-
-// Check the branch has draft-aware menu options
-const branchIdx = guidedFlowSource.indexOf('state.phase === "needs-discussion"');
-const branchChunk = guidedFlowSource.slice(branchIdx, branchIdx + 4000);
-
-assert(
-  branchChunk.includes("discuss_draft"),
-  "needs-discussion branch should have 'discuss_draft' option",
-);
-
-assert(
-  branchChunk.includes("discuss_fresh"),
-  "needs-discussion branch should have 'discuss_fresh' option",
-);
-
-assert(
-  branchChunk.includes("skip_milestone"),
-  "needs-discussion branch should have 'skip_milestone' option",
-);
-
-assert(
-  branchChunk.includes("CONTEXT-DRAFT"),
-  "needs-discussion branch should load CONTEXT-DRAFT via resolveMilestoneFile",
-);
-
-assert(
-  branchChunk.includes("Draft Seed") || branchChunk.includes("draftContent"),
-  "discuss_draft path should include draft content as seed in the dispatched prompt",
-);
-
-assert(
-  branchChunk.includes("return"),
-  "needs-discussion branch should return early (not fall through to generic no-roadmap menu)",
-);
-
-// ─── Cleanup ──────────────────────────────────────────────────────────────
-
-rmSync(tmpBase, { recursive: true, force: true });
-
-// ─── Results ──────────────────────────────────────────────────────────────
-
-console.log(`\nsmart-entry-draft: ${passed} passed, ${failed} failed`);
-if (failed > 0) process.exit(1);

package/src/resources/extensions/gsd/tests/sqlite-unavailable-gate.test.ts

@@ -1,65 +0,0 @@
-/**
- * sqlite-unavailable-gate.test.ts — #2419
- *
- * When the SQLite provider fails to open, bootstrapAutoSession must
- * refuse to start auto-mode. Otherwise gsd_task_complete returns
- * "db_unavailable", artifact retry re-dispatches the same task, and
- * the session loops forever.
- *
- * This test verifies the gate by reading auto-start.ts source and
- * confirming the pattern: after the DB lifecycle block, if the DB
- * file exists on disk but isDbAvailable() still returns false after
- * the open attempt, bootstrap must abort with an error notification.
- */
-
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-import { createTestContext } from "./test-helpers.ts";
-
-const { assertTrue, report } = createTestContext();
-
-const srcPath = join(import.meta.dirname, "..", "auto-start.ts");
-const src = readFileSync(srcPath, "utf-8");
-
-console.log("\n=== #2419: SQLite unavailable gate in auto-start.ts ===");
-
-// The DB lifecycle section tries to open the DB. After those try/catch
-// blocks, there must be a HARD GATE: if the DB file exists on disk but
-// isDbAvailable() is still false (open failed), bootstrap must abort
-// by calling releaseLockAndReturn() with an error notification.
-
-const dbLifecycleIdx = src.indexOf("DB lifecycle");
-assertTrue(dbLifecycleIdx > 0, "auto-start.ts has a DB lifecycle section");
-
-const afterDbLifecycle = src.slice(dbLifecycleIdx);
-
-// The DB lifecycle section may contain multiple isDbAvailable() checks now that
-// cold-start bootstrap can pre-open the DB earlier in the file. What matters
-// for #2419 is the explicit abort gate after the DB open attempts.
-assertTrue(
-  afterDbLifecycle.includes("!isDbAvailable()"),
-  "DB lifecycle section still checks for unavailable DB state (#2419)",
-);
-
-const gateMatch = afterDbLifecycle.match(
-  /if\s*\(existsSync\(gsdDbPath\)\s*&&\s*!isDbAvailable\(\)\)\s*\{[\s\S]*?releaseLockAndReturn\(\);[\s\S]*?\}/,
-);
-
-assertTrue(
-  !!gateMatch,
-  "auto-start.ts has a hard abort gate when gsd.db exists but SQLite is still unavailable (#2419)",
-);
-
-if (gateMatch) {
-  const gateRegion = gateMatch[0];
-  assertTrue(
-    gateRegion.includes("releaseLockAndReturn"),
-    "The DB availability gate calls releaseLockAndReturn() to abort bootstrap (#2419)",
-  );
-  assertTrue(
-    /database|sqlite|db.*unavailable/i.test(gateRegion),
-    "The DB availability gate includes a user-facing error message about the database (#2419)",
-  );
-}
-
-report();

package/src/resources/extensions/gsd/tests/stale-milestone-id-reservation.test.ts

@@ -1,79 +0,0 @@
-/**
- * Regression test for #2488: Stale milestone ID reservations inflate next ID
- * after cancelled /gsd sessions.
- *
- * The module-level `reservedMilestoneIds` Set persists across /gsd invocations
- * within the same Node process. Without clearReservedMilestoneIds() at session
- * start, each cancelled session permanently bumps the counter by 1.
- */
-import { describe, test, beforeEach } from "node:test";
-import assert from "node:assert/strict";
-
-import {
-  nextMilestoneId,
-  reserveMilestoneId,
-  getReservedMilestoneIds,
-  clearReservedMilestoneIds,
-} from "../milestone-ids.ts";
-
-describe("stale milestone ID reservation cleanup (#2488)", () => {
-  beforeEach(() => {
-    clearReservedMilestoneIds();
-  });
-
-  test("without cleanup, cancelled sessions inflate the next ID", () => {
-    const diskIds = ["M001", "M002", "M003"];
-
-    // Session 1: user starts /gsd, ID is previewed and reserved, then cancelled
-    const allIds1 = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
-    const preview1 = nextMilestoneId(allIds1);
-    reserveMilestoneId(preview1);
-    assert.equal(preview1, "M004");
-
-    // Session 2: user starts /gsd again — stale reservation still in Set
-    // WITHOUT clearing, the next ID skips M004 (reserved) and goes to M005
-    const allIds2 = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
-    const preview2 = nextMilestoneId(allIds2);
-    assert.equal(preview2, "M005", "without cleanup, ID inflates to M005");
-  });
-
-  test("with cleanup at session start, next ID is correct", () => {
-    const diskIds = ["M001", "M002", "M003"];
-
-    // Session 1: user starts /gsd, ID is previewed and reserved, then cancelled
-    const allIds1 = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
-    const preview1 = nextMilestoneId(allIds1);
-    reserveMilestoneId(preview1);
-    assert.equal(preview1, "M004");
-
-    // Session 2: clear stale reservations first (the fix)
-    clearReservedMilestoneIds();
-
-    // Now the next ID correctly returns M004 again
-    const allIds2 = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
-    const preview2 = nextMilestoneId(allIds2);
-    assert.equal(preview2, "M004", "after cleanup, ID is correctly M004");
-  });
-
-  test("multiple cancelled sessions compound the inflation without cleanup", () => {
-    const diskIds = ["M001", "M002", "M003"];
-
-    // 3 cancelled sessions without cleanup
-    for (let i = 0; i < 3; i++) {
-      const allIds = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
-      const preview = nextMilestoneId(allIds);
-      reserveMilestoneId(preview);
-    }
-
-    // Without cleanup, we're now at M007 instead of M004
-    const allIds = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
-    const next = nextMilestoneId(allIds);
-    assert.equal(next, "M007", "3 cancelled sessions inflate ID by 3");
-
-    // With cleanup, we're back to M004
-    clearReservedMilestoneIds();
-    const allIdsClean = [...new Set([...diskIds, ...getReservedMilestoneIds()])];
-    const nextClean = nextMilestoneId(allIdsClean);
-    assert.equal(nextClean, "M004", "cleanup restores correct next ID");
-  });
-});