lsd-pi 1.0.0 → 1.1.0

package/src/resources/extensions/gsd/tests/integration/doctor-completion-deferral.test.ts

@@ -1,88 +0,0 @@
-/**
- * Regression test for #1808: Completion-transition doctor fix deferral.
- *
- * Reconciliation codes are removed — doctor no longer creates summary/UAT
- * stubs or reports checkbox/file mismatch issues.
- */
-
-import { mkdirSync, writeFileSync, rmSync, existsSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import test from "node:test";
-import assert from "node:assert/strict";
-import { runGSDDoctor } from "../../doctor.ts";
-
-function makeTmp(name: string): string {
-  const dir = join(tmpdir(), `doctor-deferral-${name}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-  mkdirSync(dir, { recursive: true });
-  return dir;
-}
-
-function buildScaffold(base: string) {
-  const gsd = join(base, ".gsd");
-  const m = join(gsd, "milestones", "M001");
-  const s = join(m, "slices", "S01", "tasks");
-  mkdirSync(s, { recursive: true });
-
-  writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
-
-## Slices
-
-- [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
-  > Demo text
-`);
-
-  writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Test Slice
-
-**Goal:** test
-
-## Tasks
-
-- [x] **T01: Do stuff** \`est:5m\`
-`);
-
-  writeFileSync(join(s, "T01-SUMMARY.md"), `---
-id: T01
-parent: S01
-milestone: M001
-duration: 5m
-verification_result: passed
-completed_at: 2026-01-01
----
-
-# T01: Do stuff
-
-Done.
-`);
-}
-
-test("doctor does not report any reconciliation issue codes", async (t) => {
-  const tmp = makeTmp("no-reconciliation");
-  t.after(() => rmSync(tmp, { recursive: true, force: true }));
-
-  buildScaffold(tmp);
-
-  const report = await runGSDDoctor(tmp, { fix: true, fixLevel: "task" });
-
-  const REMOVED_CODES = [
-    "task_done_missing_summary",
-    "task_summary_without_done_checkbox",
-    "all_tasks_done_missing_slice_summary",
-    "all_tasks_done_missing_slice_uat",
-    "all_tasks_done_roadmap_not_checked",
-    "slice_checked_missing_summary",
-    "slice_checked_missing_uat",
-  ];
-
-  const codes = report.issues.map(i => i.code);
-  for (const removed of REMOVED_CODES) {
-    assert.ok(!codes.includes(removed as any), `should NOT report removed code: ${removed}`);
-  }
-
-  // No summary or UAT stubs should be created
-  const sliceSummaryPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-SUMMARY.md");
-  assert.ok(!existsSync(sliceSummaryPath), "should NOT have created summary stub");
-
-  const sliceUatPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-UAT.md");
-  assert.ok(!existsSync(sliceUatPath), "should NOT have created UAT stub");
-});

package/src/resources/extensions/gsd/tests/integration/doctor-delimiter-fix.test.ts

@@ -1,83 +0,0 @@
-/**
- * Test: Doctor auto-fix for delimiter_in_title
- *
- * Verifies that `runGSDDoctor({ fix: true })` sanitizes em/en dashes
- * in milestone H1 titles by replacing them with ASCII hyphens.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { runGSDDoctor } from "../../doctor.js";
-
-test("doctor fix=true sanitizes em-dash in milestone title", async (t) => {
-  const tmpBase = mkdtempSync(join(tmpdir(), "gsd-doctor-delim-"));
-  const gsd = join(tmpBase, ".gsd");
-  const mDir = join(gsd, "milestones", "M001");
-  const sDir = join(mDir, "slices", "S01");
-  const tDir = join(sDir, "tasks");
-  mkdirSync(tDir, { recursive: true });
-
-  const roadmapWithEmDash = `# M001: Cockpit Foundation \u2014 Daemon + State Bridge
-
-## Success Criteria
-- HTTP server runs
-
-## Slices
-- [ ] **S01: Initial Setup** \`risk:low\` \`depends:[]\`
-  > After this: setup works
-`;
-
-  writeFileSync(join(mDir, "M001-ROADMAP.md"), roadmapWithEmDash);
-  writeFileSync(join(sDir, "S01-PLAN.md"), `# S01: Initial Setup\n\n## Tasks\n- [ ] **T01: Scaffold** \`est:15m\`\n`);
-  writeFileSync(join(tDir, "T01-PLAN.md"), "# T01: Scaffold\n");
-
-  t.after(() => rmSync(tmpBase, { recursive: true, force: true }));
-
-  // Run doctor with fix=true
-  const report = await runGSDDoctor(tmpBase, { fix: true });
-
-  // The em-dash should have been replaced
-  const fixed = readFileSync(join(mDir, "M001-ROADMAP.md"), "utf-8");
-  const h1 = fixed.split("\n").find(l => l.startsWith("# "))!;
-  assert.ok(h1, "H1 line should exist");
-  assert.ok(!h1.includes("\u2014"), "em-dash should be replaced");
-  assert.ok(!h1.includes("\u2013"), "en-dash should be replaced");
-  assert.ok(h1.includes("-"), "should contain ASCII hyphen as replacement");
-
-  // Should have recorded the fix
-  assert.ok(
-    report.fixesApplied.some(f => f.includes("sanitized")),
-    `fixesApplied should mention sanitization, got: ${JSON.stringify(report.fixesApplied)}`,
-  );
-
-  // The issue should NOT appear in the report (it was fixed)
-  const delimIssues = report.issues.filter(i => i.code === "delimiter_in_title" && i.unitId === "M001");
-  assert.equal(delimIssues.length, 0, "fixed issue should not appear in issues list");
-});
-
-test("doctor fix=false still reports delimiter_in_title as warning", async (t) => {
-  const tmpBase = mkdtempSync(join(tmpdir(), "gsd-doctor-delim-nf-"));
-  const gsd = join(tmpBase, ".gsd");
-  const mDir = join(gsd, "milestones", "M001");
-  const sDir = join(mDir, "slices", "S01");
-  const tDir = join(sDir, "tasks");
-  mkdirSync(tDir, { recursive: true });
-
-  writeFileSync(join(mDir, "M001-ROADMAP.md"), `# M001: Foundation \u2014 Core\n\n## Slices\n- [ ] **S01: Setup** \`risk:low\` \`depends:[]\`\n  > After: done\n`);
-  writeFileSync(join(sDir, "S01-PLAN.md"), `# S01: Setup\n\n## Tasks\n- [ ] **T01: Init** \`est:10m\`\n`);
-  writeFileSync(join(tDir, "T01-PLAN.md"), "# T01: Init\n");
-
-  t.after(() => rmSync(tmpBase, { recursive: true, force: true }));
-
-  const report = await runGSDDoctor(tmpBase, { fix: false });
-  const delimIssues = report.issues.filter(i => i.code === "delimiter_in_title");
-  assert.ok(delimIssues.length > 0, "should report delimiter_in_title as issue when fix=false");
-  assert.equal(delimIssues[0].severity, "warning");
-
-  // File should be unchanged
-  const content = readFileSync(join(mDir, "M001-ROADMAP.md"), "utf-8");
-  assert.ok(content.includes("\u2014"), "file should not be modified when fix=false");
-});

package/src/resources/extensions/gsd/tests/integration/doctor-enhancements.test.ts

@@ -1,243 +0,0 @@
-import { describe, test } from 'node:test';
-import assert from 'node:assert/strict';
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, existsSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { runGSDDoctor } from "../../doctor.js";
-import { formatDoctorReportJson } from "../../doctor-format.js";
-// ── Helpers ─────────────────────────────────────────────────────────────────
-
-function makeBase(): { base: string; gsd: string; mDir: string } {
-  const base = mkdtempSync(join(tmpdir(), "gsd-doctor-enh-"));
-  const gsd = join(base, ".gsd");
-  const mDir = join(gsd, "milestones", "M001");
-  mkdirSync(join(mDir, "slices"), { recursive: true });
-  return { base, gsd, mDir };
-}
-
-function writeRoadmap(mDir: string, content: string): void {
-  writeFileSync(join(mDir, "M001-ROADMAP.md"), content);
-}
-
-function writeSlice(mDir: string, sliceId: string, planContent: string): string {
-  const sDir = join(mDir, "slices", sliceId);
-  const tDir = join(sDir, "tasks");
-  mkdirSync(tDir, { recursive: true });
-  writeFileSync(join(sDir, `${sliceId}-PLAN.md`), planContent);
-  return sDir;
-}
-
-describe('doctor-enhancements', async () => {
-  // ── 1. Circular dependency detection ──────────────────────────────────────
-  test('circular dependency detection', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Circular Test\n\n## Slices\n- [ ] **S01: Slice A** \`risk:low\` \`depends:[S02]\`\n  > After this: done\n- [ ] **S02: Slice B** \`risk:low\` \`depends:[S01]\`\n  > After this: done\n`);
-    writeSlice(mDir, "S01", "# S01: Slice A\n\n**Goal:** A\n**Demo:** A\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-    writeSlice(mDir, "S02", "# S02: Slice B\n\n**Goal:** B\n**Demo:** B\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(
-      result.issues.some(i => i.code === "circular_slice_dependency"),
-      "detects circular dependency S01 → S02 → S01",
-    );
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 2. Duplicate task IDs ──────────────────────────────────────────────────
-  test('duplicate task IDs', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Dup Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: First** `est:10m`\n  Task one.\n- [ ] **T01: Duplicate** `est:10m`\n  Task dup.\n");
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(
-      result.issues.some(i => i.code === "duplicate_task_id"),
-      "detects duplicate task ID T01",
-    );
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 3. Orphaned slice directory ──────────────────────────────────────────
-  test('orphaned slice directory', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Orphan Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-    // Create an extra slice directory not in roadmap
-    mkdirSync(join(mDir, "slices", "S99"), { recursive: true });
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(
-      result.issues.some(i => i.code === "orphaned_slice_directory" && i.message.includes("S99")),
-      "detects orphaned slice directory S99",
-    );
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 4. Task file not in plan ───────────────────────────────────────────────
-  test('task file not in plan', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Extra Task Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    const sDir = writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [x] **T01: Task** `est:10m`\n  Done.\n");
-    // T01 summary (matches plan)
-    writeFileSync(join(sDir, "tasks", "T01-SUMMARY.md"), "---\nstatus: done\n---\n# T01\nDone.\n");
-    // T99 summary (NOT in plan)
-    writeFileSync(join(sDir, "tasks", "T99-SUMMARY.md"), "---\nstatus: done\n---\n# T99\nExtra.\n");
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(
-      result.issues.some(i => i.code === "task_file_not_in_plan" && i.message.includes("T99")),
-      "detects task summary T99 not in plan",
-    );
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 5. Stale REPLAN file ────────────────────────────────────────────────────
-  test('stale REPLAN detection', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Replan Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    const sDir = writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [x] **T01: Task** `est:10m`\n  Done.\n");
-    writeFileSync(join(sDir, "tasks", "T01-SUMMARY.md"), "---\nstatus: done\ncompleted_at: 2026-01-01T00:00:00Z\n---\n# T01\nDone.\n");
-    // Add a REPLAN file even though all tasks are done
-    writeFileSync(join(sDir, "S01-REPLAN.md"), "# S01 REPLAN\nSomething changed.\n");
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(
-      result.issues.some(i => i.code === "stale_replan_file"),
-      "detects stale REPLAN when all tasks are done",
-    );
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 6. Metrics ledger corrupt ───────────────────────────────────────────────
-  test('metrics ledger corrupt', async () => {
-    const { base, gsd, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Metrics Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-    // Write invalid metrics.json
-    writeFileSync(join(gsd, "metrics.json"), '{"version":2,"data":[]}');
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(
-      result.issues.some(i => i.code === "metrics_ledger_corrupt"),
-      "detects corrupt metrics ledger (version != 1)",
-    );
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 7. Large planning file ──────────────────────────────────────────────────
-  test('large planning file', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Large File Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    const sDir = writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-    // Write a 101KB .md file
-    const bigContent = "# Big File\n" + "x".repeat(101 * 1024);
-    writeFileSync(join(sDir, "BIGFILE.md"), bigContent);
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(
-      result.issues.some(i => i.code === "large_planning_file"),
-      "detects large planning file over 100KB",
-    );
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 8. Future timestamp ─────────────────────────────────────────────────────
-  test('future timestamp', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Timestamp Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    const sDir = writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [x] **T01: Task** `est:10m`\n  Done.\n");
-    // completed_at is 2 days in the future
-    const futureDate = new Date(Date.now() + 2 * 24 * 60 * 60 * 1000).toISOString();
-    writeFileSync(
-      join(sDir, "tasks", "T01-SUMMARY.md"),
-      `---\nstatus: done\ncompleted_at: ${futureDate}\n---\n# T01\nDone.\n`,
-    );
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(
-      result.issues.some(i => i.code === "future_timestamp"),
-      "detects future completed_at timestamp",
-    );
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 9. JSON output format ───────────────────────────────────────────────────
-  test('JSON output format', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: JSON Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-
-    const result = await runGSDDoctor(base, { fix: false });
-    const json = formatDoctorReportJson(result);
-
-    let parsed: unknown;
-    try {
-      parsed = JSON.parse(json);
-    } catch {
-      parsed = null;
-    }
-
-    assert.ok(parsed !== null, "formatDoctorReportJson produces valid JSON");
-    assert.ok(typeof (parsed as Record<string, unknown>)?.ok === "boolean", "JSON has ok field");
-    assert.ok(Array.isArray((parsed as Record<string, unknown>)?.issues), "JSON has issues array");
-    assert.ok(Array.isArray((parsed as Record<string, unknown>)?.fixesApplied), "JSON has fixesApplied array");
-    assert.ok(typeof (parsed as Record<string, unknown>)?.generatedAt === "string", "JSON has generatedAt field");
-    assert.ok(typeof (parsed as Record<string, unknown>)?.summary === "object", "JSON has summary object");
-
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 10. Dry-run mode ────────────────────────────────────────────────────────
-  test('dry-run mode', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Dry Run Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-
-    const result = await runGSDDoctor(base, { fix: true, dryRun: true });
-    // dry-run with fix:true still runs the doctor; shouldFix() returns false
-    // so no reconciliation fixes are applied through that path
-    assert.ok(result.issues !== undefined, "dry-run still produces issue list");
-    assert.ok(Array.isArray(result.fixesApplied), "dry-run report has fixesApplied array");
-
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 11. Per-check timing ─────────────────────────────────────────────────────
-  test('per-check timing', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Timing Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-
-    const result = await runGSDDoctor(base, { fix: false });
-    assert.ok(result.timing !== undefined, "report includes timing");
-    assert.ok(typeof result.timing?.git === "number", "timing.git is a number");
-    assert.ok(typeof result.timing?.runtime === "number", "timing.runtime is a number");
-    assert.ok(typeof result.timing?.environment === "number", "timing.environment is a number");
-    assert.ok(typeof result.timing?.gsdState === "number", "timing.gsdState is a number");
-
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ── 12. Doctor history ───────────────────────────────────────────────────────
-  test('doctor history', async () => {
-    const { base, gsd, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: History Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    writeSlice(mDir, "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-
-    await runGSDDoctor(base, { fix: false });
-
-    const historyPath = join(gsd, "doctor-history.jsonl");
-    assert.ok(existsSync(historyPath), "doctor-history.jsonl is created after run");
-
-    const { readDoctorHistory } = await import("../../doctor.js");
-    const history = await readDoctorHistory(base);
-    assert.ok(history.length >= 1, "history has at least one entry");
-    assert.ok(typeof history[0]?.ts === "string", "history entry has ts field");
-    assert.ok(typeof history[0]?.ok === "boolean", "history entry has ok field");
-    assert.ok(typeof history[0]?.errors === "number", "history entry has errors count");
-    assert.ok(Array.isArray(history[0]?.codes), "history entry has codes array");
-
-    rmSync(base, { recursive: true, force: true });
-  });
-});

package/src/resources/extensions/gsd/tests/integration/doctor-environment-worktree.test.ts

@@ -1,164 +0,0 @@
-import { describe, test } from 'node:test';
-import assert from 'node:assert/strict';
-/**
- * doctor-environment-worktree.test.ts — Worktree-aware dependency checks (#2303).
- *
- * Reproduction: doctor-environment `checkDependenciesInstalled` falsely reports
- * `env_dependencies` error inside auto-worktrees because `node_modules` is
- * absent by design (worktrees symlink to the project root's node_modules and
- * the symlink may not yet exist at check time).
- *
- * Fix: when the basePath contains `.gsd/worktrees/`, resolve the project root
- * and check its node_modules instead.
- */
-
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync, symlinkSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { tmpdir } from "node:os";
-
-import {
-  runEnvironmentChecks,
-  environmentResultsToDoctorIssues,
-  checkEnvironmentHealth,
-} from "../../doctor-environment.ts";
-/** Create a directory tree with files. */
-function createDir(files: Record<string, string> = {}): string {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-wt-env-"));
-  for (const [name, content] of Object.entries(files)) {
-    const filePath = join(dir, name);
-    mkdirSync(dirname(filePath), { recursive: true });
-    writeFileSync(filePath, content);
-  }
-  return dir;
-}
-
-describe('doctor-environment-worktree', async () => {
-  const cleanups: string[] = [];
-
-  try {
-    // ── Reproduction: worktree path without node_modules ───────────────
-    test('worktree: missing node_modules should NOT error when project root has them', () => {
-      // Simulate project root with node_modules
-      const projectRoot = createDir({
-        "package.json": JSON.stringify({ name: "test-project" }),
-      });
-      mkdirSync(join(projectRoot, "node_modules"), { recursive: true });
-      cleanups.push(projectRoot);
-
-      // Simulate a worktree inside .gsd/worktrees/<name>/
-      const worktreeDir = join(projectRoot, ".gsd", "worktrees", "slice-abc");
-      mkdirSync(worktreeDir, { recursive: true });
-      writeFileSync(
-        join(worktreeDir, "package.json"),
-        JSON.stringify({ name: "test-project" }),
-      );
-      // node_modules intentionally absent — this is the bug scenario
-
-      const results = runEnvironmentChecks(worktreeDir);
-      const depsCheck = results.find(r => r.name === "dependencies");
-
-      // Before fix: this would return status "error" with "node_modules missing"
-      // After fix: should return "ok" because project root has node_modules
-      assert.ok(
-        depsCheck === undefined || depsCheck.status !== "error",
-        "worktree should not report env_dependencies error when project root has node_modules",
-      );
-    });
-
-    // ── Worktree with NO node_modules anywhere should still error ──────
-    test('worktree: missing node_modules everywhere should still error', () => {
-      const projectRoot = createDir({
-        "package.json": JSON.stringify({ name: "test-project" }),
-      });
-      cleanups.push(projectRoot);
-      // No node_modules at project root either
-
-      const worktreeDir = join(projectRoot, ".gsd", "worktrees", "slice-xyz");
-      mkdirSync(worktreeDir, { recursive: true });
-      writeFileSync(
-        join(worktreeDir, "package.json"),
-        JSON.stringify({ name: "test-project" }),
-      );
-
-      const results = runEnvironmentChecks(worktreeDir);
-      const depsCheck = results.find(r => r.name === "dependencies");
-      assert.ok(depsCheck !== undefined, "dependencies check still runs in worktree");
-      assert.deepStrictEqual(depsCheck!.status, "error", "reports error when node_modules missing everywhere");
-    });
-
-    // ── Worktree env_dependencies not in doctor issues ──────────────────
-    test('worktree: checkEnvironmentHealth should not add env_dependencies for valid worktree', async () => {
-      const projectRoot = createDir({
-        "package.json": JSON.stringify({ name: "test-project" }),
-      });
-      mkdirSync(join(projectRoot, "node_modules"), { recursive: true });
-      cleanups.push(projectRoot);
-
-      const worktreeDir = join(projectRoot, ".gsd", "worktrees", "slice-pr");
-      mkdirSync(worktreeDir, { recursive: true });
-      writeFileSync(
-        join(worktreeDir, "package.json"),
-        JSON.stringify({ name: "test-project" }),
-      );
-
-      const issues: any[] = [];
-      await checkEnvironmentHealth(worktreeDir, issues);
-      const depIssue = issues.find(i => i.code === "env_dependencies");
-      assert.deepStrictEqual(
-        depIssue,
-        undefined,
-        "no env_dependencies issue for worktree with project root node_modules",
-      );
-    });
-
-    // ── Non-worktree path still catches missing node_modules ───────────
-    test('non-worktree: missing node_modules still detected', () => {
-      const dir = createDir({
-        "package.json": JSON.stringify({ name: "test" }),
-      });
-      cleanups.push(dir);
-      const results = runEnvironmentChecks(dir);
-      const depsCheck = results.find(r => r.name === "dependencies");
-      assert.ok(depsCheck !== undefined, "dependencies check runs");
-      assert.deepStrictEqual(depsCheck!.status, "error", "missing node_modules is an error for non-worktree");
-    });
-
-    // ── GSD_WORKTREE env var detection ─────────────────────────────────
-    test('GSD_WORKTREE env: should resolve project root node_modules', () => {
-      const projectRoot = createDir({
-        "package.json": JSON.stringify({ name: "test-project" }),
-      });
-      mkdirSync(join(projectRoot, "node_modules"), { recursive: true });
-      cleanups.push(projectRoot);
-
-      // Create a directory that doesn't have .gsd/worktrees in path but
-      // has GSD_WORKTREE env pointing to project root
-      const someDir = createDir({
-        "package.json": JSON.stringify({ name: "test-project" }),
-      });
-      cleanups.push(someDir);
-
-      const origEnv = process.env.GSD_WORKTREE;
-      try {
-        process.env.GSD_WORKTREE = projectRoot;
-        const results = runEnvironmentChecks(someDir);
-        const depsCheck = results.find(r => r.name === "dependencies");
-        assert.ok(
-          depsCheck === undefined || depsCheck.status !== "error",
-          "GSD_WORKTREE env allows fallback to project root node_modules",
-        );
-      } finally {
-        if (origEnv === undefined) {
-          delete process.env.GSD_WORKTREE;
-        } else {
-          process.env.GSD_WORKTREE = origEnv;
-        }
-      }
-    });
-
-  } finally {
-    for (const dir of cleanups) {
-      try { rmSync(dir, { recursive: true, force: true }); } catch { /* ignore */ }
-    }
-  }
-});