livepilot 1.10.7 → 1.10.8

package/remote_script/LivePilot/browser.py

@@ -287,11 +287,20 @@ def load_browser_item(song, params):
     # and use the subcategory or the full fragment for matching
     if "FileId_" in device_name:
         # URI contains an internal file ID — name-based search won't work.
-        # Try one more URI pass with a much higher iteration limit.
+        # We fall back to one URI walk, but with a TIGHT iteration budget:
+        # this runs synchronously on Ableton's audio/main thread, and the
+        # previous 200 000-node walk could stall audio and GUI for several
+        # seconds on large libraries (documented in CLAUDE.md).
+        #
+        # If the item isn't found inside the budget, we return a clean
+        # STATE_ERROR pointing the caller at search_browser(), which does
+        # the same walk lazily from a cached Python-side index without
+        # hogging the audio thread.
         _iterations[0] = 0
-        DEEP_MAX = 200000
+        DEEP_MAX = 20000        # was 200_000 — 10x reduction
+        DEEP_DEPTH_MAX = 8       # was 12 — shallower depth is usually enough
         def find_by_uri_deep(parent, target_uri, depth=0):
-            if depth > 12 or _iterations[0] > DEEP_MAX:
+            if depth > DEEP_DEPTH_MAX or _iterations[0] > DEEP_MAX:
                 return None
             try:
                 children = list(parent.children)
@@ -326,9 +335,10 @@ def load_browser_item(song, params):
                 }
 
         raise ValueError(
-            "Item '%s' not found in browser (FileId URI — try "
-            "search_browser to find the item, then use find_and_load_device "
-            "with the exact name instead)" % uri
+            "Item '%s' not found inside deep-scan budget (FileId URI). "
+            "Use search_browser(query=...) to locate it without stalling "
+            "Ableton's audio thread, then call load_browser_item with the "
+            "returned URI." % uri
         )
 
     for sep in (":", "/"):

package/remote_script/LivePilot/devices.py

@@ -199,17 +199,22 @@ def toggle_device(song, params):
     track = get_track(song, track_index)
     device = get_device(track, device_index)
 
-    # Find the "Device On" parameter by name (safer than assuming index 0)
+    # Find the "Device On" parameter by name — the previous fallback
+    # blindly assumed parameters[0] was an on/off switch, which for many
+    # devices is actually "Filter Frequency", "Gain", or similar. The
+    # fallback silently mutated an arbitrary parameter while reporting
+    # is_active as if toggling had worked. Now refuse to guess.
     on_param = None
     for p in device.parameters:
         if p.name == "Device On":
             on_param = p
             break
     if on_param is None:
-        # Fallback to parameter 0 for devices that don't use "Device On"
-        if not list(device.parameters):
-            raise ValueError("Device '%s' has no parameters to toggle" % device.name)
-        on_param = device.parameters[0]
+        raise ValueError(
+            "Device '%s' exposes no 'Device On' parameter and cannot be "
+            "toggled programmatically. Use delete_device or disable it "
+            "through the UI." % device.name
+        )
 
     on_param.value = 1.0 if active else 0.0
     return {"name": device.name, "is_active": on_param.value > 0.5}

package/remote_script/LivePilot/notes.py

@@ -155,12 +155,23 @@ def modify_notes(song, params):
     for note in all_notes:
         note_map[note.note_id] = note
 
+    # Two-pass: validate every note_id BEFORE mutating any notes. The previous
+    # one-pass version raised ValueError mid-loop after some notes had already
+    # been mutated in place on the C++ NoteVector — yielding a half-modified
+    # state where the caller saw an error but earlier edits silently stuck
+    # (until apply_note_modifications was called, which it never was in the
+    # error path). Fail-all or apply-all is the safer contract.
+    missing = [int(mod["note_id"]) for mod in modifications
+               if int(mod["note_id"]) not in note_map]
+    if missing:
+        raise ValueError(
+            "Note IDs not found in clip: %s. No modifications applied." % missing
+        )
+
     # Apply modifications in-place on the original NoteVector's objects
     modified_count = 0
     for mod in modifications:
         note_id = int(mod["note_id"])
-        if note_id not in note_map:
-            raise ValueError("Note ID %d not found in clip" % note_id)
         note = note_map[note_id]
         if "pitch" in mod:
             note.pitch = int(mod["pitch"])

package/remote_script/LivePilot/server.py

@@ -197,21 +197,45 @@ class LivePilotServer(object):
             self._log("Client disconnected")
 
     def _handle_client(self, client):
-        """Read newline-delimited JSON from a connected client."""
+        """Read newline-delimited JSON from a connected client.
+
+        Accumulate raw bytes and only attempt UTF-8 decode on newline-framed
+        lines — the previous implementation decoded each recv chunk eagerly
+        with ``errors="replace"``, which silently corrupted JSON when a
+        multi-byte UTF-8 sequence (non-ASCII filename or rack name) straddled
+        the 4096-byte recv boundary. Trailing bytes of the split codepoint
+        were converted to U+FFFD, breaking JSON parsing.
+        """
         client.settimeout(1.0)
-        buf = ""
+        buf = bytearray()
+        MAX_BUF = 4 * 1024 * 1024  # 4 MB
         while self._running:
             try:
                 data = client.recv(4096)
                 if not data:
                     break
-                buf += data.decode("utf-8", errors="replace")
-                if len(buf) > 4 * 1024 * 1024:  # 4 MB
+                buf.extend(data)
+                if len(buf) > MAX_BUF:
                     self._log("Client buffer overflow — disconnecting")
                     break
-                while "\n" in buf:
-                    line, buf = buf.split("\n", 1)
-                    line = line.strip()
+                while True:
+                    nl = buf.find(b"\n")
+                    if nl < 0:
+                        break
+                    raw_line = bytes(buf[:nl])
+                    del buf[: nl + 1]
+                    try:
+                        line = raw_line.decode("utf-8").strip()
+                    except UnicodeDecodeError as exc:
+                        self._send(client, {
+                            "id": "unknown",
+                            "ok": False,
+                            "error": {
+                                "code": "INVALID_PARAM",
+                                "message": "Invalid UTF-8 in request: %s" % exc,
+                            },
+                        })
+                        continue
                     if line:
                         self._process_line(client, line)
             except socket.timeout:
@@ -253,12 +277,26 @@ class LivePilotServer(object):
         try:
             self._cs.schedule_message(0, self._process_next_command)
         except AssertionError:
-            # ControlSurface is disconnecting — return error instead of
-            # running LOM calls on the TCP thread (which would be unsafe)
-            try:
-                self._command_queue.get_nowait()
-            except queue.Empty:
-                pass
+            # ControlSurface is disconnecting — return an error instead of
+            # running LOM calls on the TCP thread (which would be unsafe).
+            #
+            # The previous version called get_nowait() unconditionally, which
+            # would happily drain a different item if one had been enqueued
+            # concurrently (e.g. if _drain_queue had just put another). Under
+            # the current single-client model the race is theoretical, but the
+            # filtered-rebuild below is correct regardless and defends against
+            # any future multi-path enqueue.
+            remaining = []
+            while True:
+                try:
+                    item = self._command_queue.get_nowait()
+                except queue.Empty:
+                    break
+                # Drop only OUR own pending item; preserve anything else
+                if item[1] is not response_queue:
+                    remaining.append(item)
+            for item in remaining:
+                self._command_queue.put(item)
             self._send(client, {
                 "id": request_id,
                 "ok": False,

package/remote_script/LivePilot/version_detect.py

@@ -33,7 +33,10 @@ def get_live_version():
     """Return (major, minor, patch) of the running Live instance.
 
     Uses Live.Application.get_application() to read version info.
-    Falls back to (12, 0, 0) if detection fails.
+    Returns a conservative (12, 0, 0) fallback on detection failure BUT
+    does NOT cache the fallback — earlier versions cached any failure,
+    which pinned the whole session to the oldest capability tier even
+    after Live finished initializing. Only successful reads are cached.
     """
     global _cached_version
     if _cached_version is not None:
@@ -49,10 +52,10 @@ def get_live_version():
         except AttributeError:
             patch = 0
         _cached_version = (int(major), int(minor), int(patch))
+        return _cached_version
     except Exception:
-        _cached_version = (12, 0, 0)
-
-    return _cached_version
+        # Don't cache failures — next call may succeed once Live is fully up.
+        return (12, 0, 0)
 
 
 def has_feature(feature_name):

package/server.json

@@ -0,0 +1,20 @@
+{
+  "$schema": "https://static.modelcontextprotocol.io/schemas/2025-12-11/server.schema.json",
+  "name": "io.github.dreamrec/livepilot",
+  "description": "323-tool agentic MCP production system for Ableton Live 12 — device atlas, sample engine, composer",
+  "repository": {
+    "url": "https://github.com/dreamrec/LivePilot",
+    "source": "github"
+  },
+  "version": "1.10.8",
+  "packages": [
+    {
+      "registryType": "npm",
+      "identifier": "livepilot",
+      "version": "1.10.8",
+      "transport": {
+        "type": "stdio"
+      }
+    }
+  ]
+}

package/.claude-plugin/marketplace.json

@@ -1,21 +0,0 @@
-{
-  "$schema": "https://anthropic.com/claude-code/marketplace.schema.json",
-  "name": "dreamrec-LivePilot",
-  "description": "Agentic MCP production system for Ableton Live 12 — 323 tools, 45 domains",
-  "owner": {
-    "name": "dreamrec",
-    "email": "dreamrec@users.noreply.github.com"
-  },
-  "plugins": [
-    {
-      "name": "livepilot",
-      "description": "Agentic production system for Ableton Live 12 — 323 tools, 45 domains, device atlas, spectral perception, technique memory, sample intelligence, auto-composition, neo-Riemannian harmony, Euclidean rhythm, species counterpoint, MIDI I/O",
-      "version": "1.10.7",
-      "author": {
-        "name": "Pilot Studio"
-      },
-      "source": "./livepilot",
-      "category": "integration"
-    }
-  ]
-}

package/.mcp.json.disabled

@@ -1,9 +0,0 @@
-{
-  "mcpServers": {
-    "livepilot": {
-      "command": "node",
-      "args": ["bin/livepilot.js"],
-      "cwd": "/Users/visansilviugeorge/Desktop/DREAM AI/LivePilot"
-    }
-  }
-}

package/.mcpbignore

@@ -1,60 +0,0 @@
-# Development files
-.git
-.git-backup-full
-.github
-.claude
-.playwright-mcp
-.pytest_cache
-.venv
-__pycache__
-
-# Test and CI
-tests/
-scripts/
-.github/
-
-# Build artifacts
-*.pyc
-.DS_Store
-*.egg-info
-.gitignore
-.mcpbignore
-package-lock.json
-
-# Untracked Ableton presets (saved by users into m4l_device/)
-m4l_device/*.adv
-
-# Local .amxd backups from re-freeze / rollback sessions
-m4l_device/*.pre-*-backup
-
-# Credentials and tokens
-.mcpregistry_*
-.env
-.npmrc
-
-# Docs and marketing (not needed at runtime)
-# Ship only docs/manual/, docs/assets/, docs/M4L_BRIDGE.md, docs/TOOL_REFERENCE.md
-docs/specs/
-docs/superpowers/
-docs/plans/
-docs/research/
-docs/v2-master-spec/
-docs/LivePilot-1.7-Perception/
-docs/2026-*
-docs/AGENT_OS_V1.md
-docs/COMPOSITION_ENGINE_V1.md
-docs/ableton-library-map.md
-docs/patreon-content.md
-docs/social-banner.*
-docs/screenshots/
-
-# Large binary already in User Library after install
-# m4l_device/LivePilot_Analyzer.amxd
-
-# Dev config (root-level only — keep livepilot/.mcp.json which the plugin needs)
-/.mcp.json
-.npmignore
-.editorconfig
-CODE_OF_CONDUCT.md
-CONTRIBUTING.md
-SECURITY.md

package/AGENTS.md

@@ -1,46 +0,0 @@
-# LivePilot v1.10.7 — Ableton Live 12
-
-## Project
-- **Repo:** This directory (LivePilot)
-- **Type:** Agentic MCP production system for Ableton Live 12
-- **Three layers:** Device Atlas (knowledge) + M4L Analyzer (perception) + Technique Memory (learning)
-- **Sister projects:** TDPilot (TouchDesigner), ComfyPilot (ComfyUI)
-- **Design spec:** `docs/specs/2026-03-17-livepilot-design.md`
-
-## Architecture
-- **Remote Script** (`remote_script/LivePilot/`): Runs inside Ableton's Python, ControlSurface base class, TCP socket on port 9878
-- **MCP Server** (`mcp_server/`): Python FastMCP server, validates inputs, sends commands to Remote Script
-- **M4L Bridge** (`m4l_device/`): Max for Live Audio Effect on master track, UDP/OSC bridge for deep LOM access
-  - UDP 9880: M4L -> Server (spectral data, responses)
-  - OSC 9881: Server -> M4L (commands)
-  - `livepilot_bridge.js`: 22 bridge commands for LiveAPI access
-  - `SpectralCache`: thread-safe, time-expiring data cache (5s max age)
-  - Bridge is optional — all core tools work without it
-- **Plugin** (`livepilot/`): Codex plugin (marketplace-compatible: `.Codex-plugin/plugin.json`)
-- **Installer** (`installer/`): Auto-detects Ableton path, copies Remote Script
-
-## Key Rules
-- ALL Live Object Model (LOM) calls must execute on Ableton's main thread via schedule_message queue
-- Live 12 minimum — use modern note API (add_new_notes, get_notes_extended, apply_note_modifications)
-- 323 tools across 45 domains: transport, tracks, clips, notes, devices, scenes, mixing, browser, arrangement, memory, analyzer, automation, theory, generative, harmony, midi_io, perception, agent_os, composition, motif, research, planner, project_brain, runtime, evaluation, mix_engine, sound_design, transition_engine, reference_engine, translation_engine, performance_engine, song_brain, preview_studio, hook_hunter, stuckness_detector, wonder_mode, session_continuity, creative_constraints, device_forge, sample_engine, atlas, composer, experiment, musical_intelligence, semantic_moves
-- JSON over TCP, newline-delimited, port 9878
-- Structured errors with codes: INDEX_ERROR, NOT_FOUND, INVALID_PARAM, STATE_ERROR, TIMEOUT, INTERNAL
-
-## M4L Bridge Notes
-- OSC addresses must be sent WITHOUT leading `/` — Max `udpreceive` passes `/` as part of messagename
-- `str_for_value` requires `call()` not `get()` (it's a function)
-- `get()` in Max JS LiveAPI always returns arrays
-- `warp_markers` is a dict property returning JSON string — use `JSON.parse()`
-- `SimplerDevice.slices` lives on the `sample` child, not the device
-- `replace_sample` only works on Simplers with existing samples
-- Max freezes JS from search path cache, not source directory — copy to `~/Documents/Max 8/`
-
-## Binary Patching Workflow (.amxd)
-When modifying .amxd attributes that Max editor won't persist (e.g., `openinpresentation`):
-1. Find the byte sequence in the .amxd binary
-2. Replace with same-byte-count alternative (file size must not change)
-3. Test by loading in Ableton
-4. Structure: 24-byte `ampf` header + `ptch` chunk + `mx@c` header + JSON patcher + frozen deps
-
-## Tool Count
-Currently 323 tools. If adding/removing tools, update: README.md, package.json description, livepilot/.Codex-plugin/plugin.json, livepilot/.claude-plugin/plugin.json, server.json, livepilot/skills/livepilot-core/SKILL.md, livepilot/skills/livepilot-core/references/overview.md, AGENTS.md, CLAUDE.md, CHANGELOG.md, tests/test_tools_contract.py, docs/manual/index.md, docs/manual/tool-reference.md