lighthouse 8.0.0-dev.20210709 → 8.0.0

package/lighthouse-core/lib/network-request.js

@@ -493,23 +493,7 @@ class NetworkRequest {
   static isSecureRequest(record) {
     return URL.isSecureScheme(record.parsedURL.scheme) ||
         URL.isSecureScheme(record.protocol) ||
-        URL.isLikeLocalhost(record.parsedURL.host) ||
-        NetworkRequest.isHstsRequest(record);
-  }
-
-  /**
-   * Returns whether the network request was an HSTS redirect request.
-   * @param {NetworkRequest} record
-   * @return {boolean}
-   */
-  static isHstsRequest(record) {
-    const destination = record.redirectDestination;
-    if (!destination) return false;
-
-    const reasonHeader = record.responseHeaders
-      .find(header => header.name === 'Non-Authoritative-Reason');
-    const reason = reasonHeader && reasonHeader.value;
-    return reason === 'HSTS' && NetworkRequest.isSecureRequest(destination);
+        URL.isLikeLocalhost(record.parsedURL.host);
   }
 }
 

package/lighthouse-core/lib/page-functions.js

@@ -378,9 +378,9 @@ function isPositionFixed(element) {
 /**
  * Generate a human-readable label for the given element, based on end-user facing
  * strings like the innerText or alt attribute.
- * Returns label string or null if no useful label is found.
+ * Falls back to the tagName if no useful label is found.
  * @param {Element} element
- * @return {string | null}
+ * @return {string}
  */
 function getNodeLabel(element) {
   // Inline so that audits that import getNodeLabel don't
@@ -415,7 +415,7 @@ function getNodeLabel(element) {
       }
     }
   }
-  return null;
+  return tagName;
 }
 
 /**
@@ -482,7 +482,6 @@ function getNodeDetails(element) {
   }
 
   element = element instanceof ShadowRoot ? element.host : element;
-  const selector = getNodeSelector(element);
 
   // Create an id that will be unique across all execution contexts.
   // The id could be any arbitrary string, the exact value is not important.
@@ -506,10 +505,10 @@ function getNodeDetails(element) {
   const details = {
     lhId,
     devtoolsNodePath: getNodePath(element),
-    selector: selector,
+    selector: getNodeSelector(element),
     boundingRect: getBoundingClientRect(element),
     snippet: getOuterHTMLSnippet(element),
-    nodeLabel: getNodeLabel(element) || selector,
+    nodeLabel: getNodeLabel(element),
   };
 
   return details;

package/lighthouse-core/lib/rect-helpers.js

@@ -32,7 +32,7 @@ function rectContains(rect1, rect2) {
 
 /**
  * @param {LH.Artifacts.Rect[]} rects
- * @return {LH.Artifacts.Rect[]}
+ * @returns {LH.Artifacts.Rect[]}
  */
 function filterOutTinyRects(rects) {
   return rects.filter(
@@ -42,7 +42,7 @@ function filterOutTinyRects(rects) {
 
 /**
  * @param {LH.Artifacts.Rect[]} rects
- * @return {LH.Artifacts.Rect[]}
+ * @returns {LH.Artifacts.Rect[]}
  */
 function filterOutRectsContainedByOthers(rects) {
   const rectsToKeep = new Set(rects);
@@ -76,7 +76,7 @@ function getRectCenterPoint(rect) {
 /**
  * @param {LH.Artifacts.Rect} rectA
  * @param {LH.Artifacts.Rect} rectB
- * @return {boolean}
+ * @returns {boolean}
  */
 function rectsTouchOrOverlap(rectA, rectB) {
   // https://stackoverflow.com/questions/2752349/fast-rectangle-to-rectangle-intersection