isaacscript-common 87.5.0 → 87.6.0

package/src/classes/features/callbackLogic/GameReorderedCallbacks.ts

@@ -60,18 +60,18 @@ export class GameReorderedCallbacks extends Feature {
       [ModCallback.POST_PLAYER_INIT, this.postPlayerInit],
 
       // 15
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_GAME_STARTED, this.postGameStarted],
 
       // 17
       [ModCallback.PRE_GAME_EXIT, this.preGameExit],
 
       // 18
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_NEW_LEVEL, this.postNewLevel],
 
       // 19
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_NEW_ROOM, this.postNewRoom],
     ];
 
@@ -93,9 +93,7 @@ export class GameReorderedCallbacks extends Feature {
 
   // ModCallback.POST_PLAYER_INIT (9)
   private readonly postPlayerInit = (_player: EntityPlayer): void => {
-    if (this.renderFrameRunStarted === null) {
-      this.renderFrameRunStarted = Isaac.GetFrameCount();
-    }
+    this.renderFrameRunStarted ??= Isaac.GetFrameCount();
   };
 
   // ModCallback.POST_GAME_STARTED (15)
@@ -164,11 +162,11 @@ export class GameReorderedCallbacks extends Feature {
     }
 
     if (
-      (onGameFrame(0) ||
-        onRenderFrame(this.renderFrameRunStarted) ||
-        this.currentStage !== stage ||
-        this.currentStageType !== stageType) &&
-      !this.forceNewRoom
+      (onGameFrame(0)
+        || onRenderFrame(this.renderFrameRunStarted)
+        || this.currentStage !== stage
+        || this.currentStageType !== stageType)
+      && !this.forceNewRoom
     ) {
       return;
     }

package/src/classes/features/callbackLogic/GridEntityUpdateDetection.ts

@@ -115,8 +115,8 @@ export class GridEntityUpdateDetection extends Feature {
       const [storedGridEntityType, storedGridEntityVariant] = gridEntityTuple;
       const gridEntity = gridEntitiesMap.get(gridIndex);
       if (
-        gridEntity === undefined ||
-        gridEntity.GetType() !== storedGridEntityType
+        gridEntity === undefined
+        || gridEntity.GetType() !== storedGridEntityType
       ) {
         v.room.initializedGridEntities.delete(gridIndex);
 
@@ -182,8 +182,8 @@ export class GridEntityUpdateDetection extends Feature {
     const gridEntityTuple = v.room.initializedGridEntities.get(gridIndex);
 
     if (
-      gridEntityTuple === undefined ||
-      gridEntityTuple[0] !== gridEntityType
+      gridEntityTuple === undefined
+      || gridEntityTuple[0] !== gridEntityType
     ) {
       this.updateTupleInMap(gridEntity);
 

package/src/classes/features/callbackLogic/ItemPickupDetection.ts

@@ -66,8 +66,8 @@ export class ItemPickupDetection extends Feature {
 
   private queueEmpty(player: EntityPlayer, pickingUpItem: PickingUpItem) {
     if (
-      pickingUpItem.itemType === ItemType.NULL ||
-      asNumber(pickingUpItem.subType) === 0
+      pickingUpItem.itemType === ItemType.NULL
+      || asNumber(pickingUpItem.subType) === 0
     ) {
       return;
     }
@@ -84,8 +84,8 @@ export class ItemPickupDetection extends Feature {
     }
 
     if (
-      queuedItem.Type !== pickingUpItem.itemType ||
-      queuedItem.ID !== pickingUpItem.subType
+      queuedItem.Type !== pickingUpItem.itemType
+      || queuedItem.ID !== pickingUpItem.subType
     ) {
       // Record which item we are picking up.
       pickingUpItem.itemType = queuedItem.Type;

package/src/classes/features/callbackLogic/PlayerCollectibleDetection.ts

@@ -200,8 +200,8 @@ export class PlayerCollectibleDetection extends Feature {
     pickingUpItem: PickingUpItem,
   ) => {
     if (
-      pickingUpItem.itemType === ItemType.TRINKET ||
-      pickingUpItem.itemType === ItemType.NULL
+      pickingUpItem.itemType === ItemType.TRINKET
+      || pickingUpItem.itemType === ItemType.NULL
     ) {
       return;
     }

package/src/classes/features/callbackLogic/PlayerReorderedCallbacks.ts

@@ -48,15 +48,15 @@ export class PlayerReorderedCallbacks extends Feature {
 
     this.callbacksUsed = [
       // 4
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_PEFFECT_UPDATE, this.postPEffectUpdate],
 
       // 31
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_PLAYER_UPDATE, this.postPlayerUpdate],
 
       // 32
-      // eslint-disable-next-line deprecation/deprecation
+      // eslint-disable-next-line @typescript-eslint/no-deprecated
       [ModCallback.POST_PLAYER_RENDER, this.postPlayerRender],
     ];
 
@@ -125,7 +125,7 @@ export class PlayerReorderedCallbacks extends Feature {
 }
 
 function dequeue(
-  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
+  // eslint-disable-next-line complete/prefer-readonly-parameter-types
   queue: QueueElement[],
   fireFunc: (player: EntityPlayer, renderOffset: Vector) => void,
 ) {

package/src/classes/features/other/CustomPickups.ts

@@ -96,6 +96,7 @@ export class CustomPickups extends Feature {
   // ModCallback.POST_EFFECT_RENDER (56)
   // PICKUP_EFFECT_VARIANT
   private readonly postEffectRenderPickupEffect = (effect: EntityEffect) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
     if (effect.SubType !== PICKUP_EFFECT_SUB_TYPE) {
       return;
     }

package/src/classes/features/other/CustomStages.ts

@@ -300,7 +300,7 @@ export class CustomStages extends Feature {
     const level = game.GetLevel();
     const stage = customStage.baseStage ?? DEFAULT_BASE_STAGE;
     const stageType = customStage.baseStageType ?? DEFAULT_BASE_STAGE_TYPE;
-    level.SetStage(stage, stageType); // eslint-disable-line isaacscript/strict-enums
+    level.SetStage(stage, stageType); // eslint-disable-line complete/strict-enums
 
     return undefined;
   };
@@ -523,7 +523,7 @@ export class CustomStages extends Feature {
         ? DEFAULT_BASE_STAGE
         : (customStage.baseStage as LevelStage);
     if (!firstFloor) {
-      baseStage++; // eslint-disable-line isaacscript/strict-enums
+      baseStage++; // eslint-disable-line complete/strict-enums
     }
 
     const baseStageType: StageType =

package/src/classes/features/other/CustomTrapdoors.ts

@@ -59,7 +59,10 @@ import { CUSTOM_FLOOR_STAGE } from "./customStages/constants";
 
 const DEBUG = false as boolean;
 
-/** This also applies to crawl spaces. The value was determined through trial and error. */
+/**
+ * This also applies to crawl spaces. The value was determined through trial and error to match
+ * vanilla behavior.
+ */
 const TRAPDOOR_OPEN_DISTANCE = 60;
 
 const TRAPDOOR_OPEN_DISTANCE_AFTER_BOSS = TRAPDOOR_OPEN_DISTANCE * 2.5;
@@ -217,8 +220,8 @@ export class CustomTrapdoors extends Feature {
 
   private checkPixelationToBlackComplete() {
     if (
-      v.run.state !== StageTravelState.PIXELATION_TO_BLACK ||
-      v.run.stateRenderFrame === null
+      v.run.state !== StageTravelState.PIXELATION_TO_BLACK
+      || v.run.stateRenderFrame === null
     ) {
       return;
     }
@@ -265,16 +268,14 @@ export class CustomTrapdoors extends Feature {
   }
 
   private goToCustomTrapdoorDestination() {
-    if (v.run.customTrapdoorActivated === null) {
-      // This should never happen; provide some sane default values.
-      v.run.customTrapdoorActivated = {
-        destinationName: undefined,
-        destinationStage: LevelStage.BASEMENT_1,
-        destinationStageType: StageType.ORIGINAL,
-        open: true,
-        firstSpawn: true,
-      };
-    }
+    // This should never be null. Regardless, we provide some sane default values.
+    v.run.customTrapdoorActivated ??= {
+      destinationName: undefined,
+      destinationStage: LevelStage.BASEMENT_1,
+      destinationStageType: StageType.ORIGINAL,
+      open: true,
+      firstSpawn: true,
+    };
 
     const destinationFunc = this.getDestinationFunc(
       v.run.customTrapdoorActivated,
@@ -309,9 +310,9 @@ export class CustomTrapdoors extends Feature {
 
   private checkSecondPixelationHalfWay() {
     if (
-      v.run.state !==
-        StageTravelState.WAITING_FOR_SECOND_PIXELATION_TO_GET_HALF_WAY ||
-      v.run.stateRenderFrame === null
+      v.run.state
+        !== StageTravelState.WAITING_FOR_SECOND_PIXELATION_TO_GET_HALF_WAY
+      || v.run.stateRenderFrame === null
     ) {
       return;
     }
@@ -377,9 +378,9 @@ export class CustomTrapdoors extends Feature {
 
   private drawBlackSprite(): void {
     if (
-      v.run.state !== StageTravelState.WAITING_FOR_FIRST_PIXELATION_TO_END &&
-      v.run.state !==
-        StageTravelState.WAITING_FOR_SECOND_PIXELATION_TO_GET_HALF_WAY
+      v.run.state !== StageTravelState.WAITING_FOR_FIRST_PIXELATION_TO_END
+      && v.run.state
+        !== StageTravelState.WAITING_FOR_SECOND_PIXELATION_TO_GET_HALF_WAY
     ) {
       return;
     }
@@ -417,6 +418,15 @@ export class CustomTrapdoors extends Feature {
   ): void {
     /** By default, trapdoors will never close if they are already open. */
     if (trapdoorDescription.open) {
+      // Sometimes, the `sprite.Play(TrapdoorAnimation.OPEN_ANIMATION, true)` function does not take
+      // effect. Check for this case.
+      const sprite = gridEntity.GetSprite();
+      const animation = sprite.GetAnimation();
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
+      if (animation === TrapdoorAnimation.CLOSED) {
+        // Try it again.
+        sprite.Play(TrapdoorAnimation.OPEN_ANIMATION, true);
+      }
       return;
     }
 
@@ -433,9 +443,9 @@ export class CustomTrapdoors extends Feature {
     const roomClear = room.IsClear();
 
     return (
-      !anyPlayerCloserThan(gridEntity.Position, TRAPDOOR_OPEN_DISTANCE) &&
-      !this.isPlayerCloseAfterBoss(gridEntity.Position) &&
-      !shouldBeClosedFromStartingInRoomWithEnemies(firstSpawn, roomClear)
+      !anyPlayerCloserThan(gridEntity.Position, TRAPDOOR_OPEN_DISTANCE)
+      && !this.isPlayerCloseAfterBoss(gridEntity.Position)
+      && !shouldBeClosedFromStartingInRoomWithEnemies(firstSpawn, roomClear)
     );
   }
 
@@ -447,9 +457,11 @@ export class CustomTrapdoors extends Feature {
     // In order to prevent a player from accidentally entering a freshly-spawned trapdoor after
     // killing the boss of the floor, we use a wider open distance for a short amount of frames.
     if (
-      roomType !== RoomType.BOSS ||
-      roomClearGameFrame === undefined ||
-      onOrAfterRenderFrame(roomClearGameFrame + TRAPDOOR_BOSS_REACTION_FRAMES)
+      roomType !== RoomType.BOSS
+      || roomClearGameFrame === undefined
+      || onOrAfterRenderFrame(
+        roomClearGameFrame + TRAPDOOR_BOSS_REACTION_FRAMES,
+      )
     ) {
       return false;
     }
@@ -482,9 +494,9 @@ export class CustomTrapdoors extends Feature {
 
       if (
         // We don't want a Pony dash to transition to a new floor or a crawl space.
-        !this.ponyDetection.isPlayerUsingPony(player) &&
-        !isChildPlayer(player) &&
-        canPlayerInteractWithTrapdoor(player)
+        !this.ponyDetection.isPlayerUsingPony(player)
+        && !isChildPlayer(player)
+        && canPlayerInteractWithTrapdoor(player)
       ) {
         this.playerTouchedCustomTrapdoor(
           gridEntity,
@@ -744,21 +756,16 @@ export class CustomTrapdoors extends Feature {
     spawnOpen?: boolean,
   ): GridEntity {
     if (
-      destinationName !== undefined &&
-      !this.destinationFuncMap.has(destinationName)
+      destinationName !== undefined
+      && !this.destinationFuncMap.has(destinationName)
     ) {
       error(
         `Failed to spawn a custom trapdoor with a destination of "${destinationName}" since a destination with that name has not been registered with the "registerCustomTrapdoorDestination" function. (If you are trying to go to a custom stage, the custom stage library should automatically do this for you when your mod first boots.)`,
       );
     }
 
-    if (destinationStage === undefined) {
-      destinationStage = this.stageHistory.getNextStageWithHistory();
-    }
-
-    if (destinationStageType === undefined) {
-      destinationStageType = this.stageHistory.getNextStageTypeWithHistory();
-    }
+    destinationStage ??= this.stageHistory.getNextStageWithHistory();
+    destinationStageType ??= this.stageHistory.getNextStageTypeWithHistory();
 
     const room = game.GetRoom();
     const roomListIndex = getRoomListIndex();
@@ -826,8 +833,8 @@ function canPlayerInteractWithTrapdoor(player: EntityPlayer) {
   const sprite = player.GetSprite();
   const animation = sprite.GetAnimation();
   return (
-    !player.IsHoldingItem() &&
-    !ANIMATIONS_THAT_PREVENT_STAGE_TRAVEL.has(animation)
+    !player.IsHoldingItem()
+    && !ANIMATIONS_THAT_PREVENT_STAGE_TRAVEL.has(animation)
   );
 }
 

package/src/classes/features/other/DeployJSONRoom.ts

@@ -161,8 +161,9 @@ export class DeployJSONRoom extends Feature {
 
     let entity: Entity;
     if (
-      entityType === EntityType.PICKUP &&
-      variant === PickupVariant.COLLECTIBLE
+      entityType === EntityType.PICKUP
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
+      && variant === PickupVariant.COLLECTIBLE
     ) {
       const collectibleType = asCollectibleType(subType);
       const options = roomType === RoomType.ANGEL;
@@ -173,8 +174,9 @@ export class DeployJSONRoom extends Feature {
 
     // For some reason, Pitfalls do not spawn with the correct collision classes.
     if (
-      entityType === EntityType.PITFALL &&
-      variant === PitfallVariant.PITFALL
+      entityType === EntityType.PITFALL
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
+      && variant === PitfallVariant.PITFALL
     ) {
       entity.EntityCollisionClass = EntityCollisionClass.ENEMIES;
       entity.GridCollisionClass = EntityGridCollisionClass.WALLS;

package/src/classes/features/other/DisableInputs.ts

@@ -122,9 +122,9 @@ export class DisableInputs extends Feature {
   @Exported
   public areInputsEnabled(): boolean {
     return (
-      v.run.disableInputs.size === 0 &&
-      v.run.enableAllInputsWithBlacklistMap.size === 0 &&
-      v.run.disableAllInputsWithWhitelistMap.size === 0
+      v.run.disableInputs.size === 0
+      && v.run.enableAllInputsWithBlacklistMap.size === 0
+      && v.run.disableAllInputsWithWhitelistMap.size === 0
     );
   }
 

package/src/classes/features/other/EdenStartingStatsHealth.ts

@@ -130,7 +130,9 @@ export class EdenStartingStatsHealth extends Feature {
    * @public
    */
   @Exported
-  public getEdenStartingCollectibles(player: EntityPlayer): CollectibleType[] {
+  public getEdenStartingCollectibles(
+    player: EntityPlayer,
+  ): readonly CollectibleType[] {
     const collectibleTypes: CollectibleType[] = [];
 
     const activeCollectibleType = mapGetPlayer(

package/src/classes/features/other/ExtraConsoleCommands.ts

@@ -24,7 +24,8 @@ declare let __ISAACSCRIPT_COMMON_EXTRA_CONSOLE_COMMANDS_FEATURE:
 
 /**
  * When you enable this feature, many custom commands will be added to the in-game console. See the
- * [dedicated command list](ExtraConsoleCommandsList) for more information about them.
+ * [dedicated command list](/isaacscript-common/features/ExtraConsoleCommandsList) for more
+ * information about them.
  *
  * Note that in order to avoid conflicts, if two or more mods enable this feature, then the first
  * loaded one will control all of the command logic. When this occurs, a global variable of
@@ -241,10 +242,11 @@ export class ExtraConsoleCommands extends Feature {
   /**
    * Helper function to add a custom console command.
    *
-   * The standard library comes with [many existing console commands](ExtraConsoleCommandsList) that
-   * are useful for debugging, but you can also add your own commands that are useful for your
-   * particular mod. It's easier to add commands to the existing command system than to add your own
-   * logic manually to the `EXECUTE_CMD` callback.
+   * The standard library comes with [many existing console
+   * commands](/isaacscript-common/features/ExtraConsoleCommandsList) that are useful for debugging,
+   * but you can also add your own commands that are useful for your particular mod. It's easier to
+   * add commands to the existing command system than to add your own logic manually to the
+   * `EXECUTE_CMD` callback.
    *
    * This function is intended to be called when your mod is first loading.
    *
@@ -290,8 +292,9 @@ export class ExtraConsoleCommands extends Feature {
   /**
    * Helper function to remove a custom console command.
    *
-   * The standard library comes with [many existing console commands](ExtraConsoleCommandsList) that
-   * are useful for debugging. If you want to disable one of them, use this function.
+   * The standard library comes with [many existing console
+   * commands](/isaacscript-common/features/ExtraConsoleCommandsList) that are useful for debugging.
+   * If you want to disable one of them, use this function.
    *
    * This function is intended to be called when your mod is first loading.
    *
@@ -325,9 +328,10 @@ export class ExtraConsoleCommands extends Feature {
   /**
    * Helper function to remove all custom console commands.
    *
-   * The standard library comes with [many existing console commands](ExtraConsoleCommandsList) that
-   * are useful for debugging. If you want to disable all of them after this feature has already
-   * been initialized, use this function.
+   * The standard library comes with [many existing console
+   * commands](/isaacscript-common/features/ExtraConsoleCommandsList) that are useful for debugging.
+   * If you want to disable all of them after this feature has already been initialized, use this
+   * function.
    *
    * In order to use this function, you must upgrade your mod with
    * `ISCFeature.EXTRA_CONSOLE_COMMANDS`.

package/src/classes/features/other/ModdedElementDetection.ts

@@ -19,17 +19,17 @@ import {
 import { Exported } from "../../../decorators";
 import { Feature } from "../../private/Feature";
 
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 const FIRST_MODDED_COLLECTIBLE_TYPE: CollectibleType =
   LAST_VANILLA_COLLECTIBLE_TYPE + 1;
 
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 const FIRST_MODDED_TRINKET_TYPE: TrinketType = LAST_VANILLA_TRINKET_TYPE + 1;
 
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 const FIRST_MODDED_CARD_TYPE: CardType = LAST_VANILLA_CARD_TYPE + 1;
 
-// eslint-disable-next-line isaacscript/strict-enums
+// eslint-disable-next-line complete/strict-enums
 const FIRST_MODDED_PILL_EFFECT: PillEffect = LAST_VANILLA_PILL_EFFECT + 1;
 
 /**

package/src/classes/features/other/ModdedElementSets.ts

@@ -411,8 +411,8 @@ export class ModdedElementSets extends Feature {
   private lazyInitEdenCollectibleTypesSet() {
     for (const collectibleType of this.getCollectibleTypes()) {
       if (
-        isHiddenCollectible(collectibleType) ||
-        collectibleHasTag(collectibleType, ItemConfigTag.NO_EDEN)
+        isHiddenCollectible(collectibleType)
+        || collectibleHasTag(collectibleType, ItemConfigTag.NO_EDEN)
       ) {
         continue;
       }
@@ -574,7 +574,7 @@ export class ModdedElementSets extends Feature {
   @Exported
   public getPlayerCollectibleMap(
     player: EntityPlayer,
-  ): Map<CollectibleType, int> {
+  ): ReadonlyMap<CollectibleType, int> {
     const collectibleArray = this.getCollectibleTypes();
 
     const collectibleMap = new Map<CollectibleType, int>();
@@ -603,7 +603,7 @@ export class ModdedElementSets extends Feature {
           }
         }
 
-        collectibleType--; // eslint-disable-line isaacscript/strict-enums
+        collectibleType--; // eslint-disable-line complete/strict-enums
       } while (itemConfigItem !== undefined);
     }
 
@@ -976,7 +976,7 @@ export class ModdedElementSets extends Feature {
   public getPlayerTrinketsWithCacheFlag(
     player: EntityPlayer,
     cacheFlag: CacheFlag,
-  ): Map<TrinketType, int> {
+  ): ReadonlyMap<TrinketType, int> {
     const trinketTypesWithCacheFlag =
       this.getTrinketsTypesWithCacheFlag(cacheFlag);
 

package/src/classes/features/other/NoSirenSteal.ts

@@ -59,16 +59,16 @@ export class NoSirenSteal extends Feature {
       const [familiarVariant, familiarSubType] = familiarTuple;
 
       if (
-        familiarVariant === incomingFamiliarVariant &&
-        familiarSubType === incomingFamiliarSubType
+        familiarVariant === incomingFamiliarVariant
+        && familiarSubType === incomingFamiliarSubType
       ) {
         // There is an entry that matches the variant and sub-type exactly.
         return true;
       }
 
       if (
-        familiarVariant === incomingFamiliarVariant &&
-        familiarSubType === undefined
+        familiarVariant === incomingFamiliarVariant
+        && familiarSubType === undefined
       ) {
         // There is an entry that matches all sub-types for this variant.
         return true;

package/src/classes/features/other/PickupIndexCreation.ts

@@ -95,9 +95,9 @@ export class PickupIndexCreation extends Feature {
     const room = game.GetRoom();
     const isFirstVisit = room.IsFirstVisit();
     if (
-      pickupIndexFromLevelData !== undefined &&
-      !isFirstVisit &&
-      onOrBeforeRoomFrame(0)
+      pickupIndexFromLevelData !== undefined
+      && !isFirstVisit
+      && onOrBeforeRoomFrame(0)
     ) {
       v.room.pickupIndexes.set(ptrHash, pickupIndexFromLevelData);
       return;
@@ -116,9 +116,7 @@ export class PickupIndexCreation extends Feature {
       v.level.pickupData.getAndSetDefault(roomListIndex);
 
     let pickupIndex = getStoredPickupIndex(pickup, pickupDescriptions);
-    if (pickupIndex === undefined) {
-      pickupIndex = this.getPostAscentPickupIndex(pickup);
-    }
+    pickupIndex ??= this.getPostAscentPickupIndex(pickup);
 
     return pickupIndex;
   }
@@ -186,6 +184,7 @@ export class PickupIndexCreation extends Feature {
    * pickup could re-appear during The Ascent. If this is the case, we store the metadata on a
    * separate map to reference later.
    */
+  // eslint-disable-next-line complete/no-mutable-return
   private getPickupDataMapForCurrentRoom():
     | Map<PickupIndex, PickupDescription>
     | undefined {
@@ -283,8 +282,8 @@ function getStoredPickupIndex(
 ): PickupIndex | undefined {
   for (const [pickupIndex, pickupDescription] of pickupDescriptions) {
     if (
-      vectorEquals(pickupDescription.position, pickup.Position) &&
-      pickupDescription.initSeed === pickup.InitSeed
+      vectorEquals(pickupDescription.position, pickup.Position)
+      && pickupDescription.initSeed === pickup.InitSeed
     ) {
       return pickupIndex;
     }

package/src/classes/features/other/PonyDetection.ts

@@ -44,8 +44,8 @@ export class PonyDetection extends Feature {
     const effects = player.GetEffects();
     const entityFlags = player.GetEntityFlags();
     const hasPonyCollectibleEffect =
-      effects.HasCollectibleEffect(CollectibleType.PONY) ||
-      effects.HasCollectibleEffect(CollectibleType.WHITE_PONY);
+      effects.HasCollectibleEffect(CollectibleType.PONY)
+      || effects.HasCollectibleEffect(CollectibleType.WHITE_PONY);
     const isPonyActiveOnPreviousFrame = setHasPlayer(
       v.run.playersIsPonyActive,
       player,

package/src/classes/features/other/PressInput.ts

@@ -55,8 +55,8 @@ export class PressInput extends Feature {
       const pair = v.run.buttonActionPairs[i]!;
 
       if (
-        pair.playerIndex === playerIndex &&
-        pair.buttonAction === buttonAction
+        pair.playerIndex === playerIndex
+        && pair.buttonAction === buttonAction
       ) {
         v.run.buttonActionPairs.splice(i);
         return true;

package/src/classes/features/other/PreventChildEntities.ts

@@ -25,12 +25,12 @@ export class PreventChildEntities extends Feature {
   // ModCallback.POST_NPC_INIT (27)
   private readonly postNPCInit = (npc: EntityNPC) => {
     const spawnerEntityMatch =
-      npc.SpawnerEntity !== undefined &&
-      v.room.preventingEntities.has(GetPtrHash(npc.SpawnerEntity));
+      npc.SpawnerEntity !== undefined
+      && v.room.preventingEntities.has(GetPtrHash(npc.SpawnerEntity));
 
     const parentMatch =
-      npc.Parent !== undefined &&
-      v.room.preventingEntities.has(GetPtrHash(npc.Parent));
+      npc.Parent !== undefined
+      && v.room.preventingEntities.has(GetPtrHash(npc.Parent));
 
     if (spawnerEntityMatch || parentMatch) {
       npc.Remove();

package/src/classes/features/other/RoomHistory.ts

@@ -192,11 +192,11 @@ export class RoomHistory extends Feature {
     }
 
     return (
-      startSeedString !== latestRoomDescription.startSeedString ||
-      stage !== latestRoomDescription.stage ||
-      stageType !== latestRoomDescription.stageType ||
-      roomListIndex !== latestRoomDescription.roomListIndex ||
-      roomVisitedCount !== latestRoomDescription.roomVisitedCount
+      startSeedString !== latestRoomDescription.startSeedString
+      || stage !== latestRoomDescription.stage
+      || stageType !== latestRoomDescription.stageType
+      || roomListIndex !== latestRoomDescription.roomListIndex
+      || roomVisitedCount !== latestRoomDescription.roomVisitedCount
     );
   }
 }

package/src/classes/features/other/RunInNFrames.ts

@@ -347,7 +347,7 @@ export class RunInNFrames extends Feature {
 }
 
 function checkExecuteQueuedFunctions(
-  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
+  // eslint-disable-next-line complete/prefer-readonly-parameter-types
   queuedFunctions: QueuedFunction[],
   frameCount: int,
   newNumRoomsEntered: int,
@@ -368,7 +368,7 @@ function checkExecuteQueuedFunctions(
 }
 
 function checkExecuteIntervalFunctions(
-  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
+  // eslint-disable-next-line complete/prefer-readonly-parameter-types
   intervalFunctions: IntervalFunction[],
   frameCount: int,
   newNumRoomsEntered: int,