gsd-pi 2.58.0-dev.778d6ac → 2.58.0-dev.d63175c

package/src/resources/extensions/gsd/tests/migrate-external-worktree.test.ts

@@ -1,105 +0,0 @@
-import { describe, test, before, after } from "node:test";
-import assert from "node:assert/strict";
-import {
-  mkdtempSync,
-  rmSync,
-  writeFileSync,
-  existsSync,
-  mkdirSync,
-  realpathSync,
-} from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { execSync } from "node:child_process";
-
-import { migrateToExternalState } from "../migrate-external.ts";
-
-function run(command: string, cwd: string): string {
-  return execSync(command, {
-    cwd,
-    stdio: ["ignore", "pipe", "pipe"],
-    encoding: "utf-8",
-  }).trim();
-}
-
-describe("migrate-external worktree guard (#2970)", () => {
-  let base: string;
-  let stateDir: string;
-  let worktreePath: string;
-
-  before(() => {
-    base = realpathSync(mkdtempSync(join(tmpdir(), "gsd-migrate-wt-")));
-    stateDir = realpathSync(mkdtempSync(join(tmpdir(), "gsd-state-")));
-    process.env.GSD_STATE_DIR = stateDir;
-
-    // Create a git repo with a remote
-    run("git init -b main", base);
-    run('git config user.name "Test"', base);
-    run('git config user.email "test@example.com"', base);
-    run('git remote add origin git@github.com:example/repo.git', base);
-    writeFileSync(join(base, "README.md"), "# Test\n", "utf-8");
-    run("git add README.md", base);
-    run('git commit -m "init"', base);
-
-    // Create a worktree
-    worktreePath = join(base, ".gsd", "worktrees", "M001");
-    run(`git worktree add -b milestone/M001 ${worktreePath}`, base);
-
-    // Populate worktree with a .gsd directory (simulating syncGsdStateToWorktree)
-    const worktreeGsd = join(worktreePath, ".gsd");
-    mkdirSync(worktreeGsd, { recursive: true });
-    writeFileSync(join(worktreeGsd, "PREFERENCES.md"), "# prefs\n", "utf-8");
-  });
-
-  after(() => {
-    delete process.env.GSD_STATE_DIR;
-    // Remove worktree before cleaning up
-    try { run(`git worktree remove --force ${worktreePath}`, base); } catch { /* ok */ }
-    rmSync(base, { recursive: true, force: true });
-    rmSync(stateDir, { recursive: true, force: true });
-  });
-
-  test("migrateToExternalState skips when basePath is a git worktree", () => {
-    // The worktree has a real .gsd directory — migration would normally run.
-    // But since this is a worktree, it should be skipped.
-    const result = migrateToExternalState(worktreePath);
-
-    assert.equal(result.migrated, false, "should not migrate inside a worktree");
-    assert.equal(result.error, undefined, "should not report an error");
-
-    // .gsd should still exist as a real directory (not renamed/removed)
-    assert.ok(
-      existsSync(join(worktreePath, ".gsd")),
-      ".gsd directory should still exist after skipped migration"
-    );
-
-    // .gsd.migrating should NOT exist
-    assert.ok(
-      !existsSync(join(worktreePath, ".gsd.migrating")),
-      ".gsd.migrating should not be created in a worktree"
-    );
-  });
-
-  test("migrateToExternalState still works on main repo", () => {
-    // Create a fresh temp repo to test main repo migration path
-    const mainBase = realpathSync(mkdtempSync(join(tmpdir(), "gsd-migrate-main-")));
-    try {
-      run("git init -b main", mainBase);
-      run('git config user.name "Test"', mainBase);
-      run('git config user.email "test@example.com"', mainBase);
-      run('git remote add origin git@github.com:example/main-repo.git', mainBase);
-      writeFileSync(join(mainBase, "README.md"), "# Test\n", "utf-8");
-      run("git add README.md", mainBase);
-      run('git commit -m "init"', mainBase);
-
-      // Create a .gsd directory with content
-      mkdirSync(join(mainBase, ".gsd"), { recursive: true });
-      writeFileSync(join(mainBase, ".gsd", "PREFERENCES.md"), "# prefs\n", "utf-8");
-
-      const result = migrateToExternalState(mainBase);
-      assert.equal(result.migrated, true, "should migrate on main repo");
-    } finally {
-      rmSync(mainBase, { recursive: true, force: true });
-    }
-  });
-});

package/src/resources/extensions/gsd/tests/milestone-status-authoritative.test.ts

@@ -1,116 +0,0 @@
-/**
- * Bug #2807: Web roadmap derives milestone status from slice heuristics
- * instead of authoritative GSD milestone state.
- *
- * getMilestoneStatus() should prefer the authoritative `status` field on
- * WorkspaceMilestoneTarget (populated from the engine registry) rather
- * than inferring status from slice completion flags.
- */
-import test from "node:test";
-import assert from "node:assert/strict";
-import { getMilestoneStatus } from "../../../../../web/lib/workspace-status.ts";
-
-// Inline type to avoid importing .tsx (not compiled to .js by test pipeline)
-interface TestMilestone {
-  id: string;
-  title: string;
-  roadmapPath?: string;
-  status?: "complete" | "active" | "pending" | "parked";
-  validationVerdict?: "pass" | "needs-attention" | "needs-remediation";
-  slices: Array<{ id: string; title: string; done: boolean; tasks: Array<{ id: string; title: string; done: boolean }> }>;
-}
-
-// ── Helpers ────────────────────────────────────────────────────────────────
-
-function makeMilestone(overrides: Partial<TestMilestone> & { id: string }): TestMilestone {
-  return {
-    title: overrides.id,
-    roadmapPath: undefined,
-    slices: [],
-    ...overrides,
-  };
-}
-
-// ── Tests ──────────────────────────────────────────────────────────────────
-
-test("getMilestoneStatus returns authoritative 'complete' even when slices are not all done", () => {
-  const milestone = makeMilestone({
-    id: "M001",
-    status: "complete",
-    slices: [
-      { id: "S01", title: "Slice 1", done: true, tasks: [] },
-      { id: "S02", title: "Slice 2", done: false, tasks: [] }, // not done
-    ],
-  });
-  // Before the fix, this would return "in-progress" because not all slices are done.
-  // After the fix, it should return "done" because authoritative status is "complete".
-  assert.equal(getMilestoneStatus(milestone, {}), "done");
-});
-
-test("getMilestoneStatus returns authoritative 'active' regardless of slice state", () => {
-  const milestone = makeMilestone({
-    id: "M002",
-    status: "active",
-    slices: [
-      { id: "S01", title: "Slice 1", done: true, tasks: [] },
-      { id: "S02", title: "Slice 2", done: true, tasks: [] },
-    ],
-  });
-  // Before the fix, this would return "done" because all slices are done.
-  // After the fix, it should return "in-progress" because authoritative status is "active".
-  assert.equal(getMilestoneStatus(milestone, {}), "in-progress");
-});
-
-test("getMilestoneStatus returns 'pending' for authoritative 'pending' even when some slices done", () => {
-  const milestone = makeMilestone({
-    id: "M003",
-    status: "pending",
-    slices: [
-      { id: "S01", title: "Slice 1", done: true, tasks: [] },
-      { id: "S02", title: "Slice 2", done: false, tasks: [] },
-    ],
-  });
-  // Before the fix, this would return "in-progress" because some slices are done.
-  // After the fix, it should return "pending".
-  assert.equal(getMilestoneStatus(milestone, {}), "pending");
-});
-
-test("getMilestoneStatus maps 'parked' to 'pending' item status", () => {
-  const milestone = makeMilestone({
-    id: "M004",
-    status: "parked",
-    slices: [
-      { id: "S01", title: "Slice 1", done: true, tasks: [] },
-    ],
-  });
-  // Parked milestones should render as pending in the UI
-  assert.equal(getMilestoneStatus(milestone, {}), "pending");
-});
-
-test("getMilestoneStatus falls back to heuristic when no authoritative status", () => {
-  // Backward compatibility: milestones without the status field should
-  // still work using the old slice-based heuristic.
-  const milestone = makeMilestone({
-    id: "M005",
-    slices: [
-      { id: "S01", title: "Slice 1", done: true, tasks: [] },
-      { id: "S02", title: "Slice 2", done: true, tasks: [] },
-    ],
-  });
-  assert.equal(getMilestoneStatus(milestone, {}), "done");
-});
-
-test("getMilestoneStatus exposes validationVerdict on milestone target", () => {
-  const milestone = makeMilestone({
-    id: "M006",
-    status: "complete",
-    validationVerdict: "needs-attention",
-    slices: [
-      { id: "S01", title: "Slice 1", done: true, tasks: [] },
-    ],
-  });
-  // The milestone should have the validationVerdict field available
-  assert.equal(milestone.validationVerdict, "needs-attention");
-  // And status should still be "done"
-  assert.equal(getMilestoneStatus(milestone, {}), "done");
-});

package/src/resources/extensions/gsd/tests/parallel-commit-scope.test.ts

@@ -1,159 +0,0 @@
-/**
- * parallel-commit-scope.test.ts — Regression test for #1991.
- *
- * Parallel workers must only commit files belonging to their locked milestone.
- * When GSD_MILESTONE_LOCK is set, smartStage() must exclude .gsd/milestones/<M>/
- * directories for milestones other than the locked one.
- *
- * Without the fix, a worker for M033 can stage and commit fabricated artifacts
- * under .gsd/milestones/M032/, causing cross-milestone pollution.
- */
-
-import { describe, test, beforeEach, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import {
-  mkdtempSync,
-  mkdirSync,
-  writeFileSync,
-  rmSync,
-} from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { execFileSync } from "node:child_process";
-
-import {
-  GitServiceImpl,
-} from "../git-service.ts";
-
-function run(command: string, cwd: string): string {
-  const [cmd, ...args] = command.split(" ");
-  return execFileSync(cmd, args, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-function gitRun(args: string[], cwd: string): string {
-  return execFileSync("git", args, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-function createFile(base: string, relPath: string, content: string): void {
-  const full = join(base, relPath);
-  mkdirSync(join(full, ".."), { recursive: true });
-  writeFileSync(full, content, "utf-8");
-}
-
-function initTempRepo(): string {
-  const dir = mkdtempSync(join(tmpdir(), "gsd-parallel-scope-"));
-  gitRun(["init", "-b", "main"], dir);
-  gitRun(["config", "user.name", "Test"], dir);
-  gitRun(["config", "user.email", "test@test.com"], dir);
-  createFile(dir, ".gitkeep", "");
-  gitRun(["add", "-A"], dir);
-  gitRun(["commit", "-m", "init"], dir);
-  return dir;
-}
-
-describe("parallel commit scope (#1991)", () => {
-  const savedEnv: Record<string, string | undefined> = {};
-
-  beforeEach(() => {
-    savedEnv.GSD_MILESTONE_LOCK = process.env.GSD_MILESTONE_LOCK;
-    savedEnv.GSD_PARALLEL_WORKER = process.env.GSD_PARALLEL_WORKER;
-  });
-
-  afterEach(() => {
-    for (const key of ["GSD_MILESTONE_LOCK", "GSD_PARALLEL_WORKER"] as const) {
-      if (savedEnv[key] === undefined) {
-        delete process.env[key];
-      } else {
-        process.env[key] = savedEnv[key];
-      }
-    }
-  });
-
-  test("autoCommit excludes other milestone directories when GSD_MILESTONE_LOCK is set", () => {
-    const repo = initTempRepo();
-
-    // Set up parallel worker environment for M033
-    process.env.GSD_MILESTONE_LOCK = "M033";
-    process.env.GSD_PARALLEL_WORKER = "1";
-
-    // Create dirty files in BOTH milestones (simulates cross-milestone pollution)
-    createFile(repo, ".gsd/milestones/M032/M032-SUMMARY.md", "# M032 Summary\nFabricated by M033 worker");
-    createFile(repo, ".gsd/milestones/M032/M032-VALIDATION.md", "# M032 Validation\nFabricated");
-    createFile(repo, ".gsd/milestones/M032/slices/S01/S01-SUMMARY.md", "Fabricated S01 summary");
-    createFile(repo, ".gsd/milestones/M033/slices/S01/tasks/T01-SUMMARY.md", "Legit T01 summary");
-    createFile(repo, "src/feature.ts", "export const x = 1;");
-
-    const svc = new GitServiceImpl(repo);
-    const msg = svc.autoCommit("complete-milestone", "M033/complete");
-    assert.ok(msg !== null, "autoCommit should produce a commit");
-
-    const committed = gitRun(["show", "--name-only", "HEAD"], repo);
-
-    // Source files and own milestone files SHOULD be committed
-    assert.ok(committed.includes("src/feature.ts"), "source files are committed");
-    assert.ok(committed.includes(".gsd/milestones/M033/"), "own milestone files are committed");
-
-    // Other milestone files MUST NOT be committed
-    assert.ok(!committed.includes(".gsd/milestones/M032/"),
-      "M032 files must NOT be committed by M033 worker — cross-milestone pollution (#1991)");
-
-    // Verify M032 files are still dirty (unstaged) in the working tree
-    const status = gitRun(["status", "--porcelain"], repo);
-    assert.ok(status.includes("M032"), "M032 files remain as untracked/dirty in working tree");
-
-    rmSync(repo, { recursive: true, force: true });
-  });
-
-  test("autoCommit stages all milestones when GSD_MILESTONE_LOCK is NOT set (solo mode)", () => {
-    const repo = initTempRepo();
-
-    // No milestone lock — solo worker mode
-    delete process.env.GSD_MILESTONE_LOCK;
-    delete process.env.GSD_PARALLEL_WORKER;
-
-    createFile(repo, ".gsd/milestones/M032/M032-SUMMARY.md", "# M032 Summary");
-    createFile(repo, ".gsd/milestones/M033/slices/S01/tasks/T01-SUMMARY.md", "T01 summary");
-    createFile(repo, "src/feature.ts", "export const x = 1;");
-
-    const svc = new GitServiceImpl(repo);
-    const msg = svc.autoCommit("complete-milestone", "M032/complete");
-    assert.ok(msg !== null, "autoCommit should produce a commit");
-
-    const committed = gitRun(["show", "--name-only", "HEAD"], repo);
-
-    // In solo mode, ALL milestone files should be committed
-    assert.ok(committed.includes(".gsd/milestones/M032/"), "M032 files committed in solo mode");
-    assert.ok(committed.includes(".gsd/milestones/M033/"), "M033 files committed in solo mode");
-    assert.ok(committed.includes("src/feature.ts"), "source files committed in solo mode");
-
-    rmSync(repo, { recursive: true, force: true });
-  });
-
-  test("autoCommit scopes to locked milestone even with multiple foreign milestones", () => {
-    const repo = initTempRepo();
-
-    process.env.GSD_MILESTONE_LOCK = "M035";
-    process.env.GSD_PARALLEL_WORKER = "1";
-
-    // Create files across many milestones
-    createFile(repo, ".gsd/milestones/M032/M032-SUMMARY.md", "foreign");
-    createFile(repo, ".gsd/milestones/M033/M033-SUMMARY.md", "foreign");
-    createFile(repo, ".gsd/milestones/M034/M034-SUMMARY.md", "foreign");
-    createFile(repo, ".gsd/milestones/M035/slices/S01/tasks/T01-SUMMARY.md", "own work");
-    createFile(repo, "src/app.ts", "export const app = {};");
-
-    const svc = new GitServiceImpl(repo);
-    const msg = svc.autoCommit("execute-task", "M035/S01/T01");
-    assert.ok(msg !== null, "autoCommit should produce a commit");
-
-    const committed = gitRun(["show", "--name-only", "HEAD"], repo);
-
-    assert.ok(committed.includes(".gsd/milestones/M035/"), "own milestone committed");
-    assert.ok(committed.includes("src/app.ts"), "source files committed");
-    assert.ok(!committed.includes(".gsd/milestones/M032/"), "M032 excluded");
-    assert.ok(!committed.includes(".gsd/milestones/M033/"), "M033 excluded");
-    assert.ok(!committed.includes(".gsd/milestones/M034/"), "M034 excluded");
-
-    rmSync(repo, { recursive: true, force: true });
-  });
-});

package/src/resources/extensions/gsd/tests/parallel-eligibility-ghost.test.ts

@@ -1,150 +0,0 @@
-/**
- * Tests for parallel eligibility edge cases:
- * - Ghost milestones (no registry entry) must NOT appear eligible (#2501 Bug 2)
- * - Milestones with failed worktree merge (SUMMARY only in worktree, DB still
- *   "active") must NOT appear eligible (#2501 Bug 1 context)
- */
-
-import { describe, test, beforeEach, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { analyzeParallelEligibility } from "../parallel-eligibility.ts";
-import { invalidateStateCache } from "../state.ts";
-import {
-  openDatabase,
-  closeDatabase,
-  insertMilestone,
-  insertSlice,
-  insertTask,
-  updateMilestoneStatus,
-} from "../gsd-db.ts";
-
-// ─── Fixture Helpers ───────────────────────────────────────────────────────
-
-function createFixtureBase(): string {
-  const base = mkdtempSync(join(tmpdir(), "gsd-parallel-elig-"));
-  mkdirSync(join(base, ".gsd", "milestones"), { recursive: true });
-  return base;
-}
-
-function writeMilestoneFile(
-  base: string,
-  milestoneId: string,
-  filename: string,
-  content: string,
-): void {
-  const filePath = join(base, ".gsd", "milestones", milestoneId, filename);
-  mkdirSync(join(filePath, ".."), { recursive: true });
-  writeFileSync(filePath, content);
-}
-
-function makeMilestoneDir(base: string, milestoneId: string): void {
-  mkdirSync(join(base, ".gsd", "milestones", milestoneId), { recursive: true });
-}
-
-function cleanup(base: string): void {
-  rmSync(base, { recursive: true, force: true });
-}
-
-// ─── Tests ─────────────────────────────────────────────────────────────────
-
-describe("parallel-eligibility: ghost milestone ineligibility (#2501)", () => {
-  let base: string;
-
-  beforeEach(() => {
-    base = createFixtureBase();
-    openDatabase(":memory:");
-  });
-
-  afterEach(() => {
-    closeDatabase();
-    cleanup(base);
-    invalidateStateCache();
-  });
-
-  test("ghost milestone (directory only, no planning files) is ineligible", async () => {
-    // Set up a real milestone M001 with proper planning data in DB
-    writeMilestoneFile(base, "M001", "M001-CONTEXT.md", "# M001: Real Milestone\n\nA real milestone.");
-    writeMilestoneFile(base, "M001", "M001-ROADMAP.md", "# M001: Real Milestone\n\n## Slices\n\n- [ ] **S01: First Slice** `risk:low` `depends:[]`\n  > Do something.\n");
-    writeMilestoneFile(base, "M001", "slices/S01/S01-PLAN.md", "# S01: First Slice\n\n**Goal:** Do it.\n**Demo:** Done.\n\n## Tasks\n\n- [ ] **T01: Task One** `est:10m`\n  Do the thing.\n");
-    insertMilestone({ id: "M001", title: "M001: Real Milestone", status: "active" });
-    insertSlice({ id: "S01", milestoneId: "M001", title: "First Slice", status: "active", risk: "low", depends: [] });
-    insertTask({ id: "T01", sliceId: "S01", milestoneId: "M001", title: "Task One", status: "pending" });
-
-    // Create ghost milestone M017 — directory with only slices/, no CONTEXT/ROADMAP/SUMMARY
-    makeMilestoneDir(base, "M017");
-    mkdirSync(join(base, ".gsd", "milestones", "M017", "slices"), { recursive: true });
-
-    invalidateStateCache();
-    const result = await analyzeParallelEligibility(base);
-
-    // M017 should NOT be in the eligible list
-    const ghostEligible = result.eligible.find(e => e.milestoneId === "M017");
-    assert.equal(
-      ghostEligible,
-      undefined,
-      "Ghost milestone M017 must NOT appear in eligible list — it has no planning data",
-    );
-
-    // M017 should be in the ineligible list with an appropriate reason
-    const ghostIneligible = result.ineligible.find(e => e.milestoneId === "M017");
-    assert.ok(
-      ghostIneligible,
-      "Ghost milestone M017 must appear in ineligible list",
-    );
-    assert.equal(ghostIneligible!.eligible, false);
-    assert.match(
-      ghostIneligible!.reason,
-      /no planning data|unknown|no registry/i,
-      "Reason should indicate the milestone has no planning data or is unknown",
-    );
-  });
-
-  test("milestone with DB status active and no SUMMARY on disk is not eligible when it has no slices", async () => {
-    // Simulate a milestone whose complete-milestone ran in a worktree, wrote
-    // SUMMARY there, but the squash-merge back to main failed.  The DB row
-    // was never updated (pre-fix scenario) and the SUMMARY file didn't reach
-    // the main project directory.
-    //
-    // In the current codebase, complete-milestone.ts already writes the DB
-    // status (Bug 1 was fixed). This test guards the fallback: even when the
-    // DB says "active" and the SUMMARY is missing from the main project dir,
-    // the milestone must NOT slip through as eligible.
-
-    // M012 — directory exists, CONTEXT exists (so it's not a ghost), but no
-    // SUMMARY on disk and DB says "active".  No slices in DB either (they
-    // lived only in the worktree DB copy).
-    writeMilestoneFile(base, "M012", "M012-CONTEXT.md", "# M012: Worktree Milestone\n\nThis ran in a worktree.");
-    insertMilestone({ id: "M012", title: "M012: Worktree Milestone", status: "active" });
-
-    // M001 — a normal pending milestone with proper planning
-    writeMilestoneFile(base, "M001", "M001-CONTEXT.md", "# M001: Normal Milestone\n\nNormal milestone.");
-    writeMilestoneFile(base, "M001", "M001-ROADMAP.md", "# M001: Normal Milestone\n\n## Slices\n\n- [ ] **S01: Slice** `risk:low` `depends:[]`\n  > Do it.\n");
-    writeMilestoneFile(base, "M001", "slices/S01/S01-PLAN.md", "# S01: Slice\n\n**Goal:** Do.\n**Demo:** Done.\n\n## Tasks\n\n- [ ] **T01: Task** `est:10m`\n  Do.\n");
-    insertMilestone({ id: "M001", title: "M001: Normal Milestone", status: "active" });
-    insertSlice({ id: "S01", milestoneId: "M001", title: "Slice", status: "active", risk: "low", depends: [] });
-    insertTask({ id: "T01", sliceId: "S01", milestoneId: "M001", title: "Task", status: "pending" });
-
-    invalidateStateCache();
-    const result = await analyzeParallelEligibility(base);
-
-    // M001 should be eligible (it has proper planning and active status)
-    const m001 = result.eligible.find(e => e.milestoneId === "M001");
-    assert.ok(m001, "M001 with proper planning should be eligible");
-
-    // M012 should appear somewhere but must NOT be eligible.  It has no
-    // slices in the DB, context exists so it's not a ghost, but state
-    // derivation should classify it as active with no work items.  Even if
-    // it appears in registry as "active", it is eligible only if deps are
-    // satisfied — which they are (no deps).  The critical check: it must
-    // NOT cause a re-dispatch of work that is already done in the worktree.
-    //
-    // NOTE: This test documents the current behavior.  If the DB status is
-    // "active" and the milestone is in the registry, it WILL appear eligible
-    // (this is a separate fix path — Bug 1 is about writing DB status).
-    // We verify the fix path through Bug 2's ghost handling above.
-  });
-});

package/src/resources/extensions/gsd/tests/plan-milestone-title.test.ts

@@ -1,70 +0,0 @@
-/**
- * Regression test for #2879: gsd_plan_milestone silently drops milestone title
- * when the DB row pre-exists from state reconciliation.
- *
- * Scenario: state reconciliation inserts a milestone row with an empty title
- * (INSERT OR IGNORE). When gsd_plan_milestone is called later with a title,
- * the title must be persisted — not silently dropped.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-
-import {
-  openDatabase,
-  closeDatabase,
-  insertMilestone,
-  getMilestone,
-  upsertMilestonePlanning,
-} from "../gsd-db.ts";
-
-test("upsertMilestonePlanning updates title when DB row pre-exists with empty title (#2879)", () => {
-  try {
-    openDatabase(":memory:");
-
-    // Step 1: Simulate state reconciliation — inserts milestone with empty title
-    insertMilestone({ id: "M099", status: "active" });
-    const before = getMilestone("M099");
-    assert.ok(before, "milestone row should exist after insertMilestone");
-    assert.equal(before.title, "", "title should be empty after reconciliation insert");
-
-    // Step 2: Simulate gsd_plan_milestone — insertMilestone is called again
-    // with a title, but INSERT OR IGNORE skips it since the row exists.
-    insertMilestone({ id: "M099", title: "My Important Milestone", status: "active" });
-    const afterInsert = getMilestone("M099");
-    assert.ok(afterInsert);
-    // The INSERT OR IGNORE means title is still empty — this is the known limitation
-    assert.equal(afterInsert.title, "", "INSERT OR IGNORE does not update existing row");
-
-    // Step 3: upsertMilestonePlanning should update the title
-    upsertMilestonePlanning("M099", {
-      vision: "Test vision",
-    }, "My Important Milestone");
-    const afterUpsert = getMilestone("M099");
-    assert.ok(afterUpsert);
-    assert.equal(
-      afterUpsert.title,
-      "My Important Milestone",
-      "title must be updated by upsertMilestonePlanning when row pre-exists",
-    );
-  } finally {
-    closeDatabase();
-  }
-});
-
-test("upsertMilestonePlanning preserves existing title when no title argument provided", () => {
-  try {
-    openDatabase(":memory:");
-
-    // Insert milestone with a title
-    insertMilestone({ id: "M100", title: "Original Title", status: "active" });
-
-    // Call upsertMilestonePlanning without a title — should preserve existing
-    upsertMilestonePlanning("M100", { vision: "Updated vision" });
-    const after = getMilestone("M100");
-    assert.ok(after);
-    assert.equal(after.title, "Original Title", "existing title must be preserved when no title argument given");
-  } finally {
-    closeDatabase();
-  }
-});