gsd-pi 2.58.0-dev.778d6ac → 2.58.0-dev.d63175c

package/src/resources/extensions/gsd/workflow-reconcile.ts

@@ -1,53 +1,19 @@
 import { join } from "node:path";
 import { mkdirSync, existsSync, readFileSync, unlinkSync } from "node:fs";
-import { logWarning, logError } from "./workflow-logger.js";
 import { readEvents, findForkPoint, appendEvent, getSessionId } from "./workflow-events.js";
 import type { WorkflowEvent } from "./workflow-events.js";
 import {
   transaction,
   updateTaskStatus,
   updateSliceStatus,
-  getSliceTasks,
   insertVerificationEvidence,
   upsertDecision,
   openDatabase,
 } from "./gsd-db.js";
-import { isClosedStatus } from "./status-guards.js";
 import { writeManifest } from "./workflow-manifest.js";
 import { atomicWriteSync } from "./atomic-write.js";
 import { acquireSyncLock, releaseSyncLock } from "./sync-lock.js";
 
-// ─── Replay Helpers ──────────────────────────────────────────────────────────
-
-/**
- * Replay a complete_slice event with task validation.
- *
- * #2945 Bug 2: The original replay blindly called updateSliceStatus("done")
- * without checking whether all tasks in the slice are actually complete.
- * During API overload or partial execution, a complete_slice event could
- * be logged even when tasks were skipped, causing the milestone completion
- * guard to see the slice as "done" and allow premature milestone completion.
- *
- * This function validates that every task in the slice has a closed status
- * before marking the slice as done. If any task is still pending, the slice
- * status is left unchanged.
- */
-export function replaySliceComplete(milestoneId: string, sliceId: string, ts: string): void {
-  const tasks = getSliceTasks(milestoneId, sliceId);
-  // If there are tasks and any are not closed, skip the status update
-  if (tasks.length > 0) {
-    const incompleteTasks = tasks.filter(t => !isClosedStatus(t.status));
-    if (incompleteTasks.length > 0) {
-      process.stderr.write(
-        `[gsd] reconcile: skipping complete_slice replay for ${sliceId} — ` +
-        `${incompleteTasks.length} task(s) still pending\n`,
-      );
-      return;
-    }
-  }
-  updateSliceStatus(milestoneId, sliceId, "done", ts);
-}
-
 // ─── Public Types ─────────────────────────────────────────────────────────────
 
 export interface ConflictEntry {
@@ -116,8 +82,7 @@ function replayEvents(events: WorkflowEvent[]): void {
       case "complete_slice": {
         const milestoneId = p["milestoneId"] as string;
         const sliceId = p["sliceId"] as string;
-        // #2945 Bug 2: validate tasks before marking slice done
-        replaySliceComplete(milestoneId, sliceId, event.ts);
+        updateSliceStatus(milestoneId, sliceId, "done", event.ts);
         break;
       }
       case "plan_slice": {
@@ -309,7 +274,9 @@ export function reconcileWorktreeLogs(
   // Acquire advisory lock to prevent concurrent reconcile + append races
   const lock = acquireSyncLock(mainBasePath);
   if (!lock.acquired) {
-    logWarning("reconcile", "could not acquire sync lock — another reconciliation may be in progress");
+    process.stderr.write(
+      `[gsd] reconcile: could not acquire sync lock — another reconciliation may be in progress\n`,
+    );
     return { autoMerged: 0, conflicts: [] };
   }
 
@@ -348,7 +315,9 @@ function _reconcileWorktreeLogsInner(
   if (conflicts.length > 0) {
     // D-04: atomic all-or-nothing — block entire merge
     writeConflictsFile(mainBasePath, conflicts, worktreeBasePath);
-    logError("reconcile", `${conflicts.length} conflict(s) detected`, { count: String(conflicts.length), path: join(mainBasePath, ".gsd", "CONFLICTS.md") });
+    process.stderr.write(
+      `[gsd] reconcile: ${conflicts.length} conflict(s) detected — see ${join(mainBasePath, ".gsd", "CONFLICTS.md")}\n`,
+    );
     return { autoMerged: 0, conflicts };
   }
 
@@ -372,7 +341,9 @@ function _reconcileWorktreeLogsInner(
   try {
     writeManifest(mainBasePath);
   } catch (err) {
-    logWarning("reconcile", "manifest write failed (non-fatal)", { error: (err as Error).message });
+    process.stderr.write(
+      `[gsd] reconcile: manifest write failed (non-fatal): ${(err as Error).message}\n`,
+    );
   }
 
   return { autoMerged: merged.length, conflicts: [] };

package/src/resources/extensions/gsd/workspace-index.ts

@@ -11,7 +11,6 @@ import {
   resolveTasksDir,
 } from "./paths.js";
 import { deriveState } from "./state.js";
-import { extractVerdict } from "./verdict-parser.js";
 import { milestoneIdSort, findMilestoneIds } from "./guided-flow.js";
 import type { RiskLevel } from "./types.js";
 import { getSliceBranchName, detectWorktreeName } from "./worktree.js";
@@ -43,10 +42,6 @@ export interface WorkspaceMilestoneTarget {
   id: string;
   title: string;
   roadmapPath?: string;
-  /** Authoritative milestone lifecycle status from the GSD state registry. */
-  status?: "complete" | "active" | "pending" | "parked";
-  /** Milestone validation verdict, when validation has been performed. */
-  validationVerdict?: "pass" | "needs-attention" | "needs-remediation";
   slices: WorkspaceSliceTarget[];
 }
 
@@ -197,31 +192,6 @@ export async function indexWorkspace(basePath: string, opts: IndexWorkspaceOptio
     phase: state.phase,
   };
 
-  // Enrich milestones with authoritative status from state registry (#2807)
-  if (state.registry) {
-    const registryMap = new Map(state.registry.map(e => [e.id, e]));
-    for (const milestone of milestones) {
-      const entry = registryMap.get(milestone.id);
-      if (entry) {
-        milestone.status = entry.status;
-      }
-    }
-  }
-
-  // Populate validationVerdict from VALIDATION files (#2807)
-  for (const milestone of milestones) {
-    const validationPath = resolveMilestoneFile(basePath, milestone.id, "VALIDATION");
-    if (validationPath) {
-      const validationContent = await loadFile(validationPath);
-      if (validationContent) {
-        const verdict = extractVerdict(validationContent);
-        if (verdict === "pass" || verdict === "needs-attention" || verdict === "needs-remediation") {
-          milestone.validationVerdict = verdict;
-        }
-      }
-    }
-  }
-
   const scopes: WorkspaceScopeTarget[] = [{ scope: "project", label: "project", kind: "project" }];
   for (const milestone of milestones) {
     scopes.push({ scope: milestone.id, label: `${milestone.id}: ${milestone.title}`, kind: "milestone" });

package/src/resources/extensions/gsd/worktree-manager.ts

@@ -15,7 +15,7 @@
  *   4. remove()  — git worktree remove + branch cleanup
  */
 
-import { existsSync, lstatSync, mkdirSync, readdirSync, readFileSync, realpathSync, rmSync } from "node:fs";
+import { existsSync, mkdirSync, readFileSync, realpathSync, rmSync } from "node:fs";
 import { execFileSync } from "node:child_process";
 import { join, resolve, sep } from "node:path";
 import { GSDError, GSD_PARSE_ERROR, GSD_STALE_STATE, GSD_LOCK_HELD, GSD_GIT_ERROR, GSD_MERGE_CONFLICT } from "./errors.js";
@@ -277,78 +277,6 @@ export function listWorktrees(basePath: string): WorktreeInfo[] {
   return worktrees;
 }
 
-// ─── Nested .git Detection (#2616) ──────────────────────────────────────
-//
-// Scaffolding tools (create-next-app, cargo init, etc.) create nested .git
-// directories inside worktrees. Git records these as gitlinks (mode 160000)
-// without a .gitmodules entry — so worktree cleanup destroys the only copy
-// of their object database, causing permanent silent data loss.
-
-/** Directories to skip when scanning for nested .git dirs. */
-const NESTED_GIT_SKIP_DIRS = new Set([
-  ".git", ".gsd", "node_modules", ".next", ".nuxt", "dist", "build",
-  "__pycache__", ".tox", ".venv", "venv", "target", "vendor",
-]);
-
-/**
- * Recursively find nested .git directories inside a worktree root.
- * Returns paths to directories that contain their own .git (directory, not file).
- * Skips node_modules, .gsd, and other non-project directories for performance.
- *
- * A nested .git *directory* (not a .git file — which is a legitimate worktree
- * pointer) indicates a scaffolded repo that will become an orphaned gitlink.
- */
-export function findNestedGitDirs(rootPath: string): string[] {
-  const results: string[] = [];
-
-  function walk(dir: string, depth: number): void {
-    // Cap recursion depth to avoid runaway scanning
-    if (depth > 10) return;
-
-    let entries: string[];
-    try {
-      entries = readdirSync(dir);
-    } catch {
-      return; // Permission denied, broken symlink, etc.
-    }
-
-    for (const entry of entries) {
-      if (NESTED_GIT_SKIP_DIRS.has(entry)) continue;
-
-      const fullPath = join(dir, entry);
-
-      // Only follow real directories, not symlinks
-      let stat;
-      try {
-        stat = lstatSync(fullPath);
-      } catch {
-        continue;
-      }
-      if (!stat.isDirectory()) continue;
-
-      // Check if this directory contains a .git *directory* (not a .git file).
-      // A .git file is a worktree pointer and is legitimate.
-      // A .git directory is a standalone repo created by scaffolding.
-      const innerGit = join(fullPath, ".git");
-      try {
-        const innerStat = lstatSync(innerGit);
-        if (innerStat.isDirectory()) {
-          results.push(fullPath);
-          // Don't recurse into the nested repo — we found what we need
-          continue;
-        }
-      } catch {
-        // No .git here — continue scanning
-      }
-
-      walk(fullPath, depth + 1);
-    }
-  }
-
-  walk(rootPath, 0);
-  return results;
-}
-
 /**
  * Remove a worktree and optionally delete its branch.
  * If the process is currently inside the worktree, chdir out first.
@@ -427,30 +355,6 @@ export function removeWorktree(
     }
   }
 
-  // Nested .git safety (#2616): detect nested .git directories created by
-  // scaffolding tools (create-next-app, cargo init, etc.). These produce
-  // gitlink entries (mode 160000) without .gitmodules — cleanup would destroy
-  // the only copy of the nested object database, causing permanent data loss.
-  // Fix: remove the nested .git dirs so git tracks the files as regular content.
-  const nestedGitDirs = findNestedGitDirs(resolvedWtPath);
-  if (nestedGitDirs.length > 0) {
-    for (const nestedDir of nestedGitDirs) {
-      const nestedGitPath = join(nestedDir, ".git");
-      try {
-        rmSync(nestedGitPath, { recursive: true, force: true });
-        logWarning("reconcile",
-          `Removed nested .git directory from scaffolded project to prevent data loss (#2616)`,
-          { worktree: name, nestedRepo: nestedDir },
-        );
-      } catch {
-        logWarning("reconcile",
-          `Failed to remove nested .git directory — files may be lost as orphaned gitlink`,
-          { worktree: name, nestedRepo: nestedDir },
-        );
-      }
-    }
-  }
-
   // Remove worktree: try non-force first when submodules have changes,
   // falling back to force only after submodule state has been preserved.
   const useForce = hasSubmoduleChanges ? false : force;
@@ -461,29 +365,6 @@ export function removeWorktree(
     try { nativeWorktreeRemove(basePath, resolvedWtPath, true); } catch { /* may fail */ }
   }
 
-  // (#2821) If the worktree directory STILL exists after both native removal
-  // attempts (e.g. untracked files like ASSESSMENT/UAT-RESULT prevent git
-  // worktree remove), force-remove the git internal worktree metadata first,
-  // then remove the filesystem directory. Without this, the .git/worktrees/<name>
-  // lock prevents rmSync from cleaning up, and the orphaned worktree directory
-  // causes every subsequent `/gsd auto` to re-enter the stale worktree.
-  if (existsSync(resolvedWtPath)) {
-    try {
-      const wtInternalDir = join(basePath, ".git", "worktrees", name);
-      if (existsSync(wtInternalDir)) {
-        rmSync(wtInternalDir, { recursive: true, force: true });
-      }
-      rmSync(resolvedWtPath, { recursive: true, force: true });
-    } catch {
-      logWarning(
-        "reconcile",
-        `Worktree directory could not be removed after git internal cleanup: ${resolvedWtPath}. ` +
-          `Manual cleanup: rm -rf "${resolvedWtPath.replaceAll("\\", "/")}"`,
-        { worktree: name },
-      );
-    }
-  }
-
   // Prune stale entries so git knows the worktree is gone
   nativeWorktreePrune(basePath);
 

package/src/resources/extensions/gsd/worktree-resolver.ts

@@ -350,13 +350,7 @@ export class WorktreeResolver {
       data: { milestoneId, mode },
     });
 
-    // #2625: If we are physically inside an auto-worktree, we MUST merge
-    // regardless of the current isolation config. This prevents data loss when
-    // the default isolation mode changes between versions (e.g., "worktree" ->
-    // "none"): the worktree branch still holds real commits that need merging.
-    const inWorktree = this.deps.isInAutoWorktree(this.s.basePath) && this.s.originalBasePath;
-
-    if (mode === "none" && !inWorktree) {
+    if (mode === "none") {
       debugLog("WorktreeResolver", {
         action: "mergeAndExit",
         milestoneId,
@@ -367,7 +361,8 @@ export class WorktreeResolver {
     }
 
     if (
-      mode === "worktree" || inWorktree
+      mode === "worktree" ||
+      (this.deps.isInAutoWorktree(this.s.basePath) && this.s.originalBasePath)
     ) {
       this._mergeWorktreeMode(milestoneId, ctx);
     } else if (mode === "branch") {
@@ -437,20 +432,6 @@ export class WorktreeResolver {
           milestoneId,
           roadmapContent,
         );
-
-        // #2945 Bug 3: mergeMilestoneToMain performs best-effort worktree
-        // cleanup internally (step 12), but it can silently fail on Windows
-        // or when the worktree directory is locked. Perform a secondary
-        // teardown here to ensure the worktree is properly cleaned up.
-        // This is idempotent — if the worktree was already removed,
-        // teardownAutoWorktree handles the no-op case gracefully.
-        try {
-          this.deps.teardownAutoWorktree(originalBase, milestoneId);
-        } catch {
-          // Best-effort — the primary cleanup in mergeMilestoneToMain may
-          // have already removed the worktree.
-        }
-
         if (mergeResult.codeFilesChanged) {
           ctx.notify(
             `Milestone ${milestoneId} merged to main.${mergeResult.pushed ? " Pushed to remote." : ""}`,

package/src/resources/extensions/mcp-client/index.ts

@@ -111,11 +111,7 @@ function readConfigs(): McpServerConfig[] {
 }
 
 function getServerConfig(name: string): McpServerConfig | undefined {
-	const trimmed = name.trim();
-	return readConfigs().find((s) =>
-		s.name === trimmed ||
-		s.name.toLowerCase() === trimmed.toLowerCase(),
-	);
+	return readConfigs().find((s) => s.name === name);
 }
 
 /** Resolve ${VAR} references in env values against process.env. */
@@ -135,14 +131,12 @@ function resolveEnv(env: Record<string, string>): Record<string, string> {
 }
 
 async function getOrConnect(name: string, signal?: AbortSignal): Promise<Client> {
+	const existing = connections.get(name);
+	if (existing) return existing.client;
+
 	const config = getServerConfig(name);
 	if (!config) throw new Error(`Unknown MCP server: "${name}". Use mcp_servers to list available servers.`);
 
-	// Always use config.name as the canonical cache key so that variant
-	// casing / whitespace still hits the same connection.
-	const existing = connections.get(config.name);
-	if (existing) return existing.client;
-
 	const client = new Client({ name: "gsd", version: "1.0.0" });
 	let transport: StdioClientTransport | StreamableHTTPClientTransport;
 
@@ -157,15 +151,15 @@ async function getOrConnect(name: string, signal?: AbortSignal): Promise<Client>
 	} else if (config.transport === "http" && config.url) {
 		const resolvedUrl = config.url.replace(
 			/\$\{([^}]+)\}/g,
-			(_, varName) => process.env[varName] ?? "",
+			(_, name) => process.env[name] ?? "",
 		);
 		transport = new StreamableHTTPClientTransport(new URL(resolvedUrl));
 	} else {
-		throw new Error(`Server "${config.name}" has unsupported transport: ${config.transport}`);
+		throw new Error(`Server "${name}" has unsupported transport: ${config.transport}`);
 	}
 
 	await client.connect(transport, { signal, timeout: 30000 });
-	connections.set(config.name, { client, transport });
+	connections.set(name, { client, transport });
 	return client;
 }
 

package/src/resources/extensions/search-the-web/extension-manifest.json

@@ -8,6 +8,6 @@
   "provides": {
     "tools": ["search-the-web", "fetch_page", "search_and_read", "web_search"],
     "commands": ["search-provider"],
-    "hooks": ["session_start", "model_select", "before_provider_request"]
+    "hooks": ["model_select", "before_provider_request"]
   }
 }

package/src/resources/extensions/shared/interview-ui.ts

@@ -105,7 +105,7 @@ export interface WrapUpOptions {
 // ─── Constants ────────────────────────────────────────────────────────────────
 
 const OTHER_OPTION_LABEL = "None of the above";
-const OTHER_OPTION_DESCRIPTION = "Select to type your own answer.";
+const OTHER_OPTION_DESCRIPTION = "Press TAB to add optional notes.";
 
 // ─── Wrap-up screen ───────────────────────────────────────────────────────────
 
@@ -295,17 +295,6 @@ export async function showInterviewRound(
 				states[currentIdx].committedIndex = states[currentIdx].cursorIndex;
 			}
 
-			// Auto-open the notes field when "None of the above" is selected
-			// so the user can immediately provide a free-text explanation
-			// instead of being trapped in a re-asking loop (bug #2715).
-			if (!isMultiSelect(currentIdx) && states[currentIdx].cursorIndex === noneOrDoneIdx(currentIdx)) {
-				states[currentIdx].notesVisible = true;
-				focusNotes = true;
-				loadStateToEditor();
-				refresh();
-				return;
-			}
-
 			if (isMultiQuestion && currentIdx < questions.length - 1) {
 				let next = currentIdx + 1;
 				for (let i = 0; i < questions.length; i++) {

package/src/resources/skills/create-gsd-extension/SKILL.md

@@ -7,11 +7,9 @@ description: Create, debug, and iterate on GSD extensions (TypeScript modules th
 
 **Extensions are TypeScript modules** that hook into GSD's runtime (built on pi). They export a default function receiving `ExtensionAPI` and use it to subscribe to events, register tools/commands/shortcuts, and interact with the session.
 
-**GSD extension paths (community/user-installed extensions):**
-- Global: `~/.pi/agent/extensions/*.ts` or `~/.pi/agent/extensions/*/index.ts`
-- Project-local: `.gsd/extensions/*.ts` or `.gsd/extensions/*/index.ts`
-
-Note: `~/.gsd/agent/extensions/` is reserved for bundled extensions synced from the gsd-pi package. Community extensions placed there are silently ignored by the loader.
+**GSD extension paths:**
+- Global extensions: `~/.gsd/agent/extensions/*.ts` or `~/.gsd/agent/extensions/*/index.ts`
+- Project-local extensions: `.gsd/extensions/*.ts` or `.gsd/extensions/*/index.ts`
 
 **The three primitives:**
 1. **Events** — Listen and react (`pi.on("event", handler)`). Can block tool calls, modify messages, inject context.

package/src/resources/skills/create-gsd-extension/references/key-rules-gotchas.md

@@ -26,12 +26,11 @@ Non-negotiable rules and common gotchas when building GSD extensions.
 </common_patterns>
 
 <gsd_paths>
-**GSD extension paths (community/user-installed extensions):**
-- Global: `~/.pi/agent/extensions/*.ts`
-- Global (subdir): `~/.pi/agent/extensions/*/index.ts`
+**GSD extension paths:**
+- Global: `~/.gsd/agent/extensions/*.ts`
+- Global (subdir): `~/.gsd/agent/extensions/*/index.ts`
 - Project-local: `.gsd/extensions/*.ts`
 - Project-local (subdir): `.gsd/extensions/*/index.ts`
 
-Note: `~/.gsd/agent/extensions/` is reserved for bundled extensions synced from the gsd-pi package.
-Community extensions placed there are silently ignored by the loader.
+The upstream pi docs reference `~/.pi` paths — GSD uses `~/.gsd` everywhere instead.
 </gsd_paths>

package/src/resources/skills/create-gsd-extension/workflows/add-capability.md

@@ -14,7 +14,7 @@ Read the reference file for the specific capability being added:
 ## Step 1: Identify the Extension
 
 Locate the existing extension file. Check:
-- `~/.pi/agent/extensions/` (global community extensions)
+- `~/.gsd/agent/extensions/` (global)
 - `.gsd/extensions/` (project-local)
 
 Read the current extension code to understand its structure.
@@ -28,7 +28,7 @@ If the extension needs new imports, add them at the top of the file.
 ## Step 3: Handle Structural Changes
 
 **Single file → Directory**: If the extension is outgrowing a single file:
-1. Create `~/.pi/agent/extensions/my-extension/`
+1. Create `~/.gsd/agent/extensions/my-extension/`
 2. Move the file to `index.ts`
 3. Extract helpers to separate files
 

package/src/resources/skills/create-gsd-extension/workflows/create-extension.md

@@ -12,7 +12,7 @@
 ## Step 1: Determine Scope and Placement
 
 Ask the user:
-- **Global** (`~/.pi/agent/extensions/`) — Available in all GSD sessions
+- **Global** (`~/.gsd/agent/extensions/`) — Available in all GSD sessions
 - **Project-local** (`.gsd/extensions/`) — Available only in this project
 
 ## Step 2: Determine Extension Capabilities
@@ -36,12 +36,12 @@ Identify what the extension needs from the user's description:
 
 **Single file** — for small extensions (1-2 tools/commands, simple hooks):
 ```
-~/.pi/agent/extensions/my-extension.ts
+~/.gsd/agent/extensions/my-extension.ts
 ```
 
 **Directory with index.ts** — for multi-file extensions:
 ```
-~/.pi/agent/extensions/my-extension/
+~/.gsd/agent/extensions/my-extension/
 ├── index.ts
 ├── tools.ts
 └── utils.ts
@@ -49,7 +49,7 @@ Identify what the extension needs from the user's description:
 
 **Package with dependencies** — when npm packages are needed:
 ```
-~/.pi/agent/extensions/my-extension/
+~/.gsd/agent/extensions/my-extension/
 ├── package.json
 ├── src/index.ts
 └── node_modules/

package/src/resources/skills/create-gsd-extension/workflows/debug-extension.md

@@ -32,14 +32,12 @@ gsd -e ./path/to/extension.ts
 
 ## Step 3: Verify File Location
 
-Community extensions must be in auto-discovery paths:
-- `~/.pi/agent/extensions/*.ts`
-- `~/.pi/agent/extensions/*/index.ts`
+Extensions must be in auto-discovery paths:
+- `~/.gsd/agent/extensions/*.ts`
+- `~/.gsd/agent/extensions/*/index.ts`
 - `.gsd/extensions/*.ts`
 - `.gsd/extensions/*/index.ts`
 
-Note: `~/.gsd/agent/extensions/` is reserved for bundled extensions synced from the gsd-pi package.
-
 The file must `export default function(pi: ExtensionAPI) { ... }`.
 
 ## Step 4: Check for Common Mistakes

package/dist/resources/extensions/gsd/milestone-validation-gates.js

@@ -1,45 +0,0 @@
-/**
- * Milestone validation quality gate persistence.
- *
- * #2945 Bug 4: validate-milestone was writing VALIDATION.md to disk and
- * inserting an assessment row, but never persisted structured quality_gates
- * records in the DB. This module inserts milestone-level validation gates
- * that correspond to the validation checks performed.
- *
- * Gate IDs for milestone validation:
- *   MV01 — Success criteria checklist
- *   MV02 — Slice delivery audit
- *   MV03 — Cross-slice integration
- *   MV04 — Requirement coverage
- *
- * These use the existing quality_gates table with scope "milestone".
- */
-import { _getAdapter } from "./gsd-db.js";
-/** Milestone validation gate IDs. */
-const MILESTONE_GATE_IDS = ["MV01", "MV02", "MV03", "MV04"];
-/**
- * Insert milestone-level quality_gates records for a validation run.
- *
- * Each gate is inserted with status "complete" and a verdict derived
- * from the overall milestone validation verdict. Individual gate-level
- * verdicts are not available (the handler receives a single verdict),
- * so all gates share the overall verdict.
- */
-export function insertMilestoneValidationGates(milestoneId, sliceId, verdict, evaluatedAt) {
-    const db = _getAdapter();
-    if (!db)
-        return;
-    const gateVerdict = verdict === "pass" ? "pass" : "flag";
-    for (const gateId of MILESTONE_GATE_IDS) {
-        db.prepare(`INSERT OR REPLACE INTO quality_gates
-       (milestone_id, slice_id, gate_id, scope, task_id, status, verdict, rationale, findings, evaluated_at)
-       VALUES (:mid, :sid, :gid, 'milestone', '', 'complete', :verdict, :rationale, '', :evaluated_at)`).run({
-            ":mid": milestoneId,
-            ":sid": sliceId,
-            ":gid": gateId,
-            ":verdict": gateVerdict,
-            ":rationale": `Milestone validation verdict: ${verdict}`,
-            ":evaluated_at": evaluatedAt,
-        });
-    }
-}