gsd-pi 2.58.0-dev.778d6ac → 2.58.0-dev.d63175c

package/src/resources/extensions/gsd/tests/workflow-logger.test.ts

@@ -317,54 +317,6 @@ describe("workflow-logger", () => {
     });
   });
 
-  describe("new log components (db, dispatch)", () => {
-    test("logError with 'db' component stores correct component", () => {
-      logError("db", "failed to copy DB to worktree", { error: "ENOENT" });
-      const entries = peekLogs();
-      assert.equal(entries.length, 1);
-      assert.equal(entries[0].severity, "error");
-      assert.equal(entries[0].component, "db");
-      assert.equal(entries[0].message, "failed to copy DB to worktree");
-      assert.deepEqual(entries[0].context, { error: "ENOENT" });
-    });
-
-    test("logError with 'dispatch' component stores correct component", () => {
-      logError("dispatch", "reactive graph derivation failed", { error: "timeout" });
-      const entries = peekLogs();
-      assert.equal(entries.length, 1);
-      assert.equal(entries[0].severity, "error");
-      assert.equal(entries[0].component, "dispatch");
-      assert.deepEqual(entries[0].context, { error: "timeout" });
-    });
-
-    test("logWarning with 'reconcile' component for centralized logging path", () => {
-      logWarning("reconcile", "could not acquire sync lock — another reconciliation may be in progress");
-      const entries = peekLogs();
-      assert.equal(entries.length, 1);
-      assert.equal(entries[0].severity, "warn");
-      assert.equal(entries[0].component, "reconcile");
-    });
-
-    test("summarizeLogs includes db and dispatch entries", () => {
-      logError("db", "worktree DB reconciliation failed: path contains unsafe characters");
-      logWarning("dispatch", "graph derivation timeout");
-      const summary = summarizeLogs()!;
-      assert.ok(summary.includes("1 error(s)"));
-      assert.ok(summary.includes("1 warning(s)"));
-      assert.ok(summary.includes("unsafe characters"));
-      assert.ok(summary.includes("graph derivation timeout"));
-    });
-
-    test("formatForNotification renders db and dispatch components", () => {
-      logError("db", "copy failed");
-      logWarning("dispatch", "slow derivation");
-      const entries = drainLogs();
-      const formatted = formatForNotification(entries);
-      assert.ok(formatted.includes("[db] copy failed"));
-      assert.ok(formatted.includes("[dispatch] slow derivation"));
-    });
-  });
-
   describe("stderr output", () => {
     test("writes WARN prefix to stderr for warnings", (t) => {
       const written: string[] = [];

package/src/resources/extensions/gsd/tests/workflow-manifest.test.ts

@@ -12,7 +12,6 @@ import {
   insertMilestone,
   insertSlice,
   insertTask,
-  _getAdapter,
 } from '../gsd-db.ts';
 import {
   writeManifest,
@@ -166,97 +165,6 @@ test('workflow-manifest: bootstrapFromManifest restores DB from manifest (round-
   }
 });
 
-// ─── snapshotState: numeric column coercion (#2962) ─────────────────────
-
-test('workflow-manifest: snapshotState coerces string placeholders in numeric columns to null (#2962)', () => {
-  const base = tempDir();
-  openDatabase(tempDbPath(base));
-  try {
-    // Set up prerequisite rows
-    insertMilestone({ id: 'M001' });
-    insertSlice({ id: 'S01', milestoneId: 'M001' });
-    insertTask({ id: 'T01', sliceId: 'S01', milestoneId: 'M001', title: 'Task', status: 'complete' });
-
-    // Insert verification_evidence with string placeholders in numeric columns
-    // This simulates what happens after schema migrations or manual inserts
-    const db = _getAdapter()!;
-    db.prepare(
-      `INSERT INTO verification_evidence (task_id, slice_id, milestone_id, command, exit_code, verdict, duration_ms, created_at)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?)`,
-    ).run('T01', 'S01', 'M001', 'npm test', '-', 'pass', '-', new Date().toISOString());
-
-    // snapshotState should coerce "-" to null for numeric columns
-    const snap = snapshotState();
-    const ev = snap.verification_evidence[0];
-    assert.strictEqual(ev.exit_code, null, 'exit_code "-" should be coerced to null');
-    assert.strictEqual(ev.duration_ms, null, 'duration_ms "-" should be coerced to null');
-
-    // Round-trip through JSON should not throw
-    const json = JSON.stringify(snap, null, 2);
-    const reparsed = JSON.parse(json);
-    assert.strictEqual(reparsed.verification_evidence[0].exit_code, null);
-    assert.strictEqual(reparsed.verification_evidence[0].duration_ms, null);
-  } finally {
-    closeDatabase();
-    cleanupDir(base);
-  }
-});
-
-test('workflow-manifest: snapshotState coerces empty string and N/A in numeric columns (#2962)', () => {
-  const base = tempDir();
-  openDatabase(tempDbPath(base));
-  try {
-    insertMilestone({ id: 'M001' });
-    insertSlice({ id: 'S01', milestoneId: 'M001' });
-    insertTask({ id: 'T01', sliceId: 'S01', milestoneId: 'M001', title: 'Task', status: 'complete' });
-
-    const db = _getAdapter()!;
-    db.prepare(
-      `INSERT INTO verification_evidence (task_id, slice_id, milestone_id, command, exit_code, verdict, duration_ms, created_at)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?)`,
-    ).run('T01', 'S01', 'M001', 'npm test', 'N/A', 'pass', '', new Date().toISOString());
-
-    const snap = snapshotState();
-    const ev = snap.verification_evidence[0];
-    assert.strictEqual(ev.exit_code, null, 'exit_code "N/A" should be coerced to null');
-    assert.strictEqual(ev.duration_ms, null, 'duration_ms "" should be coerced to null');
-  } finally {
-    closeDatabase();
-    cleanupDir(base);
-  }
-});
-
-test('workflow-manifest: snapshotState coerces string placeholders in sequence columns (#2962)', () => {
-  const base = tempDir();
-  openDatabase(tempDbPath(base));
-  try {
-    insertMilestone({ id: 'M001' });
-
-    // Insert a slice with a string sequence via raw SQL
-    const db = _getAdapter()!;
-    db.prepare(
-      `INSERT INTO slices (milestone_id, id, title, status, risk, depends, demo, created_at, sequence)
-       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)`,
-    ).run('M001', 'S01', 'Test Slice', 'planned', 'low', '[]', '', new Date().toISOString(), '-');
-
-    db.prepare(
-      `INSERT INTO tasks (milestone_id, slice_id, id, title, status, sequence)
-       VALUES (?, ?, ?, ?, ?, ?)`,
-    ).run('M001', 'S01', 'T01', 'Test Task', 'planned', 'N/A');
-
-    const snap = snapshotState();
-    assert.strictEqual(snap.slices[0].sequence, 0, 'slice sequence "-" should be coerced to 0');
-    assert.strictEqual(snap.tasks[0].sequence, 0, 'task sequence "N/A" should be coerced to 0');
-
-    // JSON round-trip must not throw
-    const json = JSON.stringify(snap, null, 2);
-    assert.doesNotThrow(() => JSON.parse(json));
-  } finally {
-    closeDatabase();
-    cleanupDir(base);
-  }
-});
-
 // ─── readManifest: version check ─────────────────────────────────────────
 
 test('workflow-manifest: readManifest throws on unsupported version', () => {

package/src/resources/extensions/gsd/tests/workflow-projections.test.ts

@@ -86,12 +86,10 @@ test('workflow-projections: renderPlanContent falls back to TBD when goal and fu
   assert.ok(content.includes('**Goal:** TBD'));
 });
 
-test('workflow-projections: renderPlanContent falls back to TBD when goal is empty (full_summary_md ignored #2945)', () => {
+test('workflow-projections: renderPlanContent falls back to full_summary_md when goal is empty', () => {
   const slice = makeSlice({ goal: '', full_summary_md: 'Fallback goal text' });
   const content = renderPlanContent(slice, []);
-  // #2945: full_summary_md is no longer used as a fallback — it contains
-  // multi-line rendered markdown that corrupts single-line fields.
-  assert.ok(content.includes('**Goal:** TBD'), `expected TBD fallback, got: ${content}`);
+  assert.ok(content.includes('**Goal:** Fallback goal text'));
 });
 
 test('workflow-projections: renderPlanContent includes ## Tasks section', () => {

package/src/resources/extensions/gsd/tests/worktree-resolver.test.ts

@@ -481,8 +481,7 @@ test("mergeAndExit resolves roadmap from worktree when missing at project root (
 
   // Should have called mergeMilestoneToMain, not bare teardown
   assert.equal(findCalls(deps.calls, "mergeMilestoneToMain").length, 1);
-  // #2945 Bug 3: secondary teardown is now called after merge for cleanup
-  assert.equal(findCalls(deps.calls, "teardownAutoWorktree").length, 1);
+  assert.equal(findCalls(deps.calls, "teardownAutoWorktree").length, 0);
   assert.equal(s.basePath, "/project"); // restored
   assert.ok(ctx.messages.some((m) => m.msg.includes("merged to main")));
 });
@@ -914,49 +913,3 @@ test("isolationDegraded is reset by session.reset() (#2483)", () => {
 
   assert.equal(s.isolationDegraded, false);
 });
-
-// ─── #2625 — Default isolation mode change must not orphan worktree commits ──
-
-test("mergeAndExit still merges when mode is 'none' but session is in a worktree (#2625)", () => {
-  // Scenario: user upgraded from a version where default was "worktree" to one
-  // where default is "none". They have an active worktree with committed work.
-  // mergeAndExit must detect the active worktree and merge regardless of config.
-  const s = makeSession({
-    basePath: "/project/.gsd/worktrees/M001",
-    originalBasePath: "/project",
-  });
-  const deps = makeDeps({
-    isInAutoWorktree: () => true,
-    getIsolationMode: () => "none", // config says "none" — but we ARE in a worktree
-  });
-  const ctx = makeNotifyCtx();
-  const resolver = new WorktreeResolver(s, deps);
-
-  resolver.mergeAndExit("M001", ctx);
-
-  // Must still merge — not skip silently
-  assert.equal(findCalls(deps.calls, "mergeMilestoneToMain").length, 1,
-    "must call mergeMilestoneToMain even when isolation mode is 'none' but we are in a worktree");
-  assert.equal(s.basePath, "/project", "basePath must be restored to project root");
-  assert.ok(ctx.messages.some((m) => m.msg.includes("merged to main")),
-    "must notify about the merge");
-});
-
-test("mergeAndExit in none mode remains a no-op when NOT in a worktree (#2625)", () => {
-  // When mode is "none" and we are genuinely not in a worktree, it should still be a no-op.
-  const s = makeSession({
-    basePath: "/project",
-    originalBasePath: "/project",
-  });
-  const deps = makeDeps({
-    isInAutoWorktree: () => false,
-    getIsolationMode: () => "none",
-  });
-  const ctx = makeNotifyCtx();
-  const resolver = new WorktreeResolver(s, deps);
-
-  resolver.mergeAndExit("M001", ctx);
-
-  assert.equal(findCalls(deps.calls, "mergeMilestoneToMain").length, 0,
-    "must NOT merge when not in a worktree and mode is none");
-});

package/src/resources/extensions/gsd/tests/worktree-sync-milestones.test.ts

@@ -100,8 +100,8 @@ describe('worktree-sync-milestones', async () => {
     }
   }
 
-  // ─── 3. empty gsd.db deleted in worktree after sync ────────────────────
-  console.log('\n=== 3. empty gsd.db deleted in worktree after sync ===');
+  // ─── 3. gsd.db deleted in worktree after sync ─────────────────────────
+  console.log('\n=== 3. gsd.db deleted in worktree after sync ===');
   {
     const mainBase = createBase('main');
     const wtBase = createBase('wt');
@@ -111,37 +111,13 @@ describe('worktree-sync-milestones', async () => {
       mkdirSync(m001Dir, { recursive: true });
       writeFileSync(join(m001Dir, 'M001-ROADMAP.md'), '# Roadmap');
 
-      // Worktree has an empty (0-byte) gsd.db — stale/corrupt
-      writeFileSync(join(wtBase, '.gsd', 'gsd.db'), '');
+      // Worktree has a stale gsd.db
+      writeFileSync(join(wtBase, '.gsd', 'gsd.db'), 'stale data');
       assert.ok(existsSync(join(wtBase, '.gsd', 'gsd.db')), 'gsd.db exists before sync');
 
       syncProjectRootToWorktree(mainBase, wtBase, 'M001');
 
-      assert.ok(!existsSync(join(wtBase, '.gsd', 'gsd.db')), '#853: empty gsd.db deleted after sync');
-    } finally {
-      cleanup(mainBase);
-      cleanup(wtBase);
-    }
-  }
-
-  // ─── 3b. non-empty gsd.db preserved in worktree after sync (#2815) ───
-  console.log('\n=== 3b. non-empty gsd.db preserved in worktree after sync (#2815) ===');
-  {
-    const mainBase = createBase('main');
-    const wtBase = createBase('wt');
-
-    try {
-      const m001Dir = join(mainBase, '.gsd', 'milestones', 'M001');
-      mkdirSync(m001Dir, { recursive: true });
-      writeFileSync(join(m001Dir, 'M001-ROADMAP.md'), '# Roadmap');
-
-      // Worktree has a populated gsd.db (e.g. from gsd-migrate on respawn)
-      writeFileSync(join(wtBase, '.gsd', 'gsd.db'), 'migrated-db-content');
-      assert.ok(existsSync(join(wtBase, '.gsd', 'gsd.db')), 'gsd.db exists before sync');
-
-      syncProjectRootToWorktree(mainBase, wtBase, 'M001');
-
-      assert.ok(existsSync(join(wtBase, '.gsd', 'gsd.db')), '#2815: non-empty gsd.db preserved after sync');
+      assert.ok(!existsSync(join(wtBase, '.gsd', 'gsd.db')), '#853: gsd.db deleted after sync');
     } finally {
       cleanup(mainBase);
       cleanup(wtBase);

package/src/resources/extensions/gsd/tools/complete-task.ts

@@ -30,7 +30,7 @@ import { checkOwnership, taskUnitKey } from "../unit-ownership.js";
 import { saveFile, clearParseCache } from "../files.js";
 import { invalidateStateCache } from "../state.js";
 import { renderPlanCheckboxes } from "../markdown-renderer.js";
-import { renderAllProjections, renderSummaryContent } from "../workflow-projections.js";
+import { renderAllProjections } from "../workflow-projections.js";
 import { writeManifest } from "../workflow-manifest.js";
 import { appendEvent } from "../workflow-events.js";
 
@@ -41,40 +41,79 @@ export interface CompleteTaskResult {
   summaryPath: string;
 }
 
-import type { TaskRow } from "../gsd-db.js";
-
 /**
- * Build a TaskRow-shaped object from CompleteTaskParams so the unified
- * renderSummaryContent() can be used at completion time (#2720).
+ * Render task summary markdown matching the template format.
+ * YAML frontmatter uses snake_case keys for parseSummary() compatibility.
  */
-function paramsToTaskRow(params: CompleteTaskParams, completedAt: string): TaskRow {
-  return {
-    milestone_id: params.milestoneId,
-    slice_id: params.sliceId,
-    id: params.taskId,
-    title: params.oneLiner || params.taskId,
-    status: "complete",
-    one_liner: params.oneLiner,
-    narrative: params.narrative,
-    verification_result: params.verification,
-    duration: "",
-    completed_at: completedAt,
-    blocker_discovered: params.blockerDiscovered,
-    deviations: params.deviations,
-    known_issues: params.knownIssues,
-    key_files: params.keyFiles,
-    key_decisions: params.keyDecisions,
-    full_summary_md: "",
-    description: "",
-    estimate: "",
-    files: [],
-    verify: "",
-    inputs: [],
-    expected_output: [],
-    observability_impact: "",
-    full_plan_md: "",
-    sequence: 0,
-  };
+function renderSummaryMarkdown(params: CompleteTaskParams): string {
+  const now = new Date().toISOString();
+  const keyFilesYaml = params.keyFiles.length > 0
+    ? params.keyFiles.map(f => `  - ${f}`).join("\n")
+    : "  - (none)";
+  const keyDecisionsYaml = params.keyDecisions.length > 0
+    ? params.keyDecisions.map(d => `  - ${d}`).join("\n")
+    : "  - (none)";
+
+  // Build verification evidence table rows
+  let evidenceTable = "| # | Command | Exit Code | Verdict | Duration |\n|---|---------|-----------|---------|----------|\n";
+  if (params.verificationEvidence.length > 0) {
+    params.verificationEvidence.forEach((e, i) => {
+      evidenceTable += `| ${i + 1} | \`${e.command}\` | ${e.exitCode} | ${e.verdict} | ${e.durationMs}ms |\n`;
+    });
+  } else {
+    evidenceTable += "| — | No verification commands discovered | — | — | — |\n";
+  }
+
+  // Determine verification_result from evidence
+  const allPassed = params.verificationEvidence.length > 0 &&
+    params.verificationEvidence.every(e => e.exitCode === 0 || e.verdict.includes("✅") || e.verdict.toLowerCase().includes("pass"));
+  const verificationResult = allPassed ? "passed" : (params.verificationEvidence.length === 0 ? "untested" : "mixed");
+
+  // Extract a title from the oneLiner or taskId
+  const title = params.oneLiner || params.taskId;
+
+  return `---
+id: ${params.taskId}
+parent: ${params.sliceId}
+milestone: ${params.milestoneId}
+key_files:
+${keyFilesYaml}
+key_decisions:
+${keyDecisionsYaml}
+duration: ""
+verification_result: ${verificationResult}
+completed_at: ${now}
+blocker_discovered: ${params.blockerDiscovered}
+---
+
+# ${params.taskId}: ${title}
+
+**${params.oneLiner}**
+
+## What Happened
+
+${params.narrative}
+
+## Verification
+
+${params.verification}
+
+## Verification Evidence
+
+${evidenceTable}
+
+## Deviations
+
+${params.deviations || "None."}
+
+## Known Issues
+
+${params.knownIssues || "None."}
+
+## Files Created/Modified
+
+${params.keyFiles.map(f => `- \`${f}\``).join("\n") || "None."}
+`;
 }
 
 /**
@@ -179,9 +218,8 @@ export async function handleCompleteTask(
   // If disk render fails, roll back the DB status so deriveState() and
   // verifyExpectedArtifact() stay consistent (both say "not done").
 
-  // Render summary markdown via the single source of truth (#2720)
-  const taskRow = paramsToTaskRow(params, completedAt);
-  const summaryMd = renderSummaryContent(taskRow, params.sliceId, params.milestoneId, params.verificationEvidence);
+  // Render summary markdown
+  const summaryMd = renderSummaryMarkdown(params);
 
   // Resolve and write summary to disk
   let summaryPath: string;

package/src/resources/extensions/gsd/tools/plan-milestone.ts

@@ -4,7 +4,6 @@ import { isNonEmptyString, validateStringArray } from "../validation.js";
 import {
   transaction,
   getMilestone,
-  getMilestoneSlices,
   insertMilestone,
   insertSlice,
   upsertMilestonePlanning,
@@ -190,17 +189,6 @@ export async function handlePlanMilestone(
         return;
       }
 
-      // Guard: refuse to re-plan a milestone that has completed slices (#2960).
-      // INSERT OR IGNORE on slices won't overwrite existing rows, but a full
-      // re-plan after worktree recreation or DB resync can create new slice rows
-      // that shadow completed work. Block early when any slice is already done.
-      const existingSlices = getMilestoneSlices(params.milestoneId);
-      const completedSlices = existingSlices.filter(s => isClosedStatus(s.status));
-      if (completedSlices.length > 0) {
-        guardError = `cannot re-plan milestone ${params.milestoneId}: ${completedSlices.length} slice(s) already completed (${completedSlices.map(s => s.id).join(", ")}). Use gsd_reassess_roadmap to modify the roadmap.`;
-        return;
-      }
-
       // Validate depends_on: all dependencies must exist and be complete
       if (params.dependsOn && params.dependsOn.length > 0) {
         for (const depId of params.dependsOn) {
@@ -235,7 +223,7 @@ export async function handlePlanMilestone(
         definitionOfDone: params.definitionOfDone,
         requirementCoverage: params.requirementCoverage,
         boundaryMapMarkdown: params.boundaryMapMarkdown,
-      }, params.title);
+      });
 
       for (const slice of params.slices) {
         insertSlice({

package/src/resources/extensions/gsd/tools/reassess-roadmap.ts

@@ -1,5 +1,4 @@
 import { join } from "node:path";
-import { existsSync, unlinkSync } from "node:fs";
 import { clearParseCache } from "../files.js";
 import { isClosedStatus } from "../status-guards.js";
 import { isNonEmptyString } from "../validation.js";
@@ -11,7 +10,6 @@ import {
   insertSlice,
   updateSliceFields,
   insertAssessment,
-  deleteAssessmentByScope,
   deleteSlice,
 } from "../gsd-db.js";
 import { invalidateStateCache } from "../state.js";
@@ -202,21 +200,6 @@ export async function handleReassessRoadmap(
       for (const removedId of params.sliceChanges.removed) {
         deleteSlice(params.milestoneId, removedId);
       }
-
-      // ── Invalidate stale milestone validation (#2957) ──────────────
-      // When roadmap structure changes (slices added/modified/removed),
-      // any prior milestone-validation verdict is stale. Delete the DB
-      // row so deriveState() returns phase: 'validating-milestone' once
-      // the new slices complete, rather than advancing directly to
-      // 'completing-milestone' with a stale needs-remediation verdict.
-      const hasStructuralChanges =
-        params.sliceChanges.added.length > 0 ||
-        params.sliceChanges.modified.length > 0 ||
-        params.sliceChanges.removed.length > 0;
-
-      if (hasStructuralChanges) {
-        deleteAssessmentByScope(params.milestoneId, "milestone-validation");
-      }
     });
   } catch (err) {
     return { error: `db write failed: ${(err as Error).message}` };
@@ -235,25 +218,6 @@ export async function handleReassessRoadmap(
       completedSliceId: params.completedSliceId,
     });
 
-    // ── Remove stale VALIDATION file from disk (#2957) ────────────
-    const hasStructuralChanges =
-      params.sliceChanges.added.length > 0 ||
-      params.sliceChanges.modified.length > 0 ||
-      params.sliceChanges.removed.length > 0;
-
-    if (hasStructuralChanges) {
-      const validationFile = join(
-        basePath, ".gsd", "milestones", params.milestoneId,
-        `${params.milestoneId}-VALIDATION.md`,
-      );
-      try {
-        if (existsSync(validationFile)) unlinkSync(validationFile);
-      } catch {
-        // Best-effort: DB row is already deleted, so state derivation
-        // will not see the file-based verdict as authoritative.
-      }
-    }
-
     // ── Invalidate caches ─────────────────────────────────────────
     invalidateStateCache();
     clearParseCache();

package/src/resources/extensions/gsd/tools/validate-milestone.ts

@@ -1,12 +1,8 @@
 /**
  * validate-milestone handler — the core operation behind gsd_validate_milestone.
  *
- * Persists milestone validation results to the assessments table and
- * quality_gates table, renders VALIDATION.md to disk, and invalidates caches.
- *
- * #2945 Bug 4: Previously only wrote to assessments — quality_gates records
- * were never persisted, causing M002+ milestones to have zero gate records
- * despite passing validation.
+ * Persists milestone validation results to the assessments table,
+ * renders VALIDATION.md to disk, and invalidates caches.
  */
 
 import { join } from "node:path";
@@ -15,13 +11,11 @@ import {
   transaction,
   insertAssessment,
   deleteAssessmentByScope,
-  getMilestoneSlices,
 } from "../gsd-db.js";
 import { resolveMilestonePath, clearPathCache } from "../paths.js";
 import { saveFile, clearParseCache } from "../files.js";
 import { invalidateStateCache } from "../state.js";
 import { VALIDATION_VERDICTS, isValidMilestoneVerdict } from "../verdict-parser.js";
-import { insertMilestoneValidationGates } from "../milestone-validation-gates.js";
 
 export interface ValidateMilestoneParams {
   milestoneId: string;
@@ -118,18 +112,6 @@ export async function handleValidateMilestone(
       scope: 'milestone-validation',
       fullContent: validationMd,
     });
-
-    // #2945 Bug 4: persist quality_gates records alongside the assessment.
-    // Previously only the assessment was written, leaving M002+ milestones
-    // with zero quality_gate records despite passing validation.
-    const slices = getMilestoneSlices(params.milestoneId);
-    const sliceId = slices.length > 0 ? slices[0].id : "_milestone";
-    insertMilestoneValidationGates(
-      params.milestoneId,
-      sliceId,
-      params.verdict,
-      validatedAt,
-    );
   });
 
   // ── Filesystem render (outside transaction) ────────────────────────────

package/src/resources/extensions/gsd/triage-resolution.ts

@@ -22,7 +22,6 @@ import {
   loadActionableCaptures,
   markCaptureResolved,
   markCaptureExecuted,
-  stampCaptureMilestone,
 } from "./captures.js";
 
 // ─── Resolution Executors ─────────────────────────────────────────────────────
@@ -272,15 +271,11 @@ export function buildQuickTaskPrompt(capture: CaptureEntry): string {
     ``,
     `## Instructions`,
     ``,
-    `1. **Verify the issue still exists.** Before making any changes, inspect the`,
-    `   relevant code to confirm the problem described above is actually present in`,
-    `   the current codebase. If the issue has already been fixed (e.g., by planned`,
-    `   milestone work), report "Already resolved — no changes needed." and stop.`,
-    `2. Execute this task as a small, self-contained change.`,
-    `3. Do NOT modify any \`.gsd/\` plan files — this is a one-off, not a planned task.`,
-    `4. Commit your changes with a descriptive message.`,
-    `5. Keep changes minimal and focused on the capture text.`,
-    `6. When done, say: "Quick task complete."`,
+    `1. Execute this task as a small, self-contained change.`,
+    `2. Do NOT modify any \`.gsd/\` plan files — this is a one-off, not a planned task.`,
+    `3. Commit your changes with a descriptive message.`,
+    `4. Keep changes minimal and focused on the capture text.`,
+    `5. When done, say: "Quick task complete."`,
   ].join("\n");
 }
 
@@ -329,19 +324,7 @@ export function executeTriageResolutions(
     actions: [],
   };
 
-  const actionable = loadActionableCaptures(basePath, mid || undefined);
-
-  // Reconciliation: stamp actionable captures that are missing the Milestone field
-  // with the current milestone ID.  This covers captures resolved by the triage LLM
-  // before the prompt included the Milestone instruction, and acts as a safety net
-  // when the LLM omits the field (#2872).
-  if (mid) {
-    for (const capture of actionable) {
-      if (!capture.resolvedInMilestone) {
-        stampCaptureMilestone(basePath, capture.id, mid);
-      }
-    }
-  }
+  const actionable = loadActionableCaptures(basePath);
 
   // Also process deferred captures that target milestone IDs — create
   // milestone directories so deriveState() discovers them.

package/src/resources/extensions/gsd/types.ts

@@ -249,8 +249,6 @@ export interface GSDState {
     slices?: { done: number; total: number };
     tasks?: { done: number; total: number };
   };
-  /** When phase=complete, holds the last completed milestone (instead of activeMilestone). */
-  lastCompletedMilestone?: ActiveRef | null;
 }
 
 // ─── Post-Unit Hook Types ─────────────────────────────────────────────────
@@ -565,8 +563,8 @@ export interface CompleteSliceParams {
 
 // ─── Quality Gates ───────────────────────────────────────────────────────
 
-export type GateId = "Q3" | "Q4" | "Q5" | "Q6" | "Q7" | "Q8" | "MV01" | "MV02" | "MV03" | "MV04";
-export type GateScope = "slice" | "task" | "milestone";
+export type GateId = "Q3" | "Q4" | "Q5" | "Q6" | "Q7" | "Q8";
+export type GateScope = "slice" | "task";
 export type GateStatus = "pending" | "complete" | "omitted";
 export type GateVerdict = "pass" | "flag" | "omitted" | "";
 

package/src/resources/extensions/gsd/undo.ts

@@ -5,7 +5,7 @@
 
 import type { ExtensionCommandContext, ExtensionAPI } from "@gsd/pi-coding-agent";
 import { existsSync, readFileSync, writeFileSync, unlinkSync, readdirSync } from "node:fs";
-import { join, basename } from "node:path";
+import { join } from "node:path";
 import { nativeRevertCommit, nativeRevertAbort } from "./native-git-bridge.js";
 import { parseUnitId } from "./unit-id.js";
 import { deriveState } from "./state.js";
@@ -133,7 +133,7 @@ export async function handleUndo(args: string, ctx: ExtensionCommandContext, _pi
   }
 
   ctx.ui.notify(results.join("\n"), "success");
-  sendDesktopNotification("GSD", `Undone: ${unitType} (${unitId})`, "info", "complete", basename(basePath));
+  sendDesktopNotification("GSD", `Undone: ${unitType} (${unitId})`, "info", "complete");
 }
 
 // ─── Targeted State Reset ────────────────────────────────────────────────────