gsd-pi 2.58.0-dev.778d6ac → 2.58.0-dev.d63175c

package/src/resources/extensions/gsd/tests/reassess-handler.test.ts

@@ -9,7 +9,6 @@ import {
   closeDatabase,
   insertMilestone,
   insertSlice,
-  insertAssessment,
   getSlice,
   getMilestoneSlices,
   getAssessment,
@@ -324,119 +323,3 @@ test('handleReassessRoadmap returns structured error payloads with actionable me
     cleanup(base);
   }
 });
-
-// ─── Bug #2957: Stale VALIDATION survives roadmap remediation ────────────
-
-test('handleReassessRoadmap invalidates stale milestone-validation when roadmap changes (#2957)', async () => {
-  const base = makeTmpBase();
-  openDatabase(join(base, '.gsd', 'gsd.db'));
-
-  try {
-    // Seed: M001 with S01-S04 all complete, plus a stale VALIDATION with needs-remediation
-    insertMilestone({ id: 'M001', title: 'Test Milestone', status: 'active' });
-    insertSlice({ id: 'S01', milestoneId: 'M001', title: 'Slice One', status: 'complete', demo: 'Demo' });
-    insertSlice({ id: 'S02', milestoneId: 'M001', title: 'Slice Two', status: 'complete', demo: 'Demo' });
-    insertSlice({ id: 'S03', milestoneId: 'M001', title: 'Slice Three', status: 'complete', demo: 'Demo' });
-    insertSlice({ id: 'S04', milestoneId: 'M001', title: 'Slice Four', status: 'complete', demo: 'Demo' });
-
-    // Insert milestone-validation assessment with needs-remediation verdict (stale)
-    const validationPath = join('.gsd', 'milestones', 'M001', 'M001-VALIDATION.md');
-    insertAssessment({
-      path: validationPath,
-      milestoneId: 'M001',
-      sliceId: null,
-      taskId: null,
-      status: 'needs-remediation',
-      scope: 'milestone-validation',
-      fullContent: '---\nverdict: needs-remediation\nremediation_round: 0\n---\n\n# Validation\nNeeds remediation.',
-    });
-
-    // Verify the validation row exists before reassess
-    const adapter = _getAdapter()!;
-    const before = adapter.prepare(
-      `SELECT * FROM assessments WHERE milestone_id = 'M001' AND scope = 'milestone-validation'`,
-    ).get() as Record<string, unknown> | undefined;
-    assert.ok(before, 'milestone-validation row should exist before reassess');
-
-    // Now reassess the roadmap: add remediation slice S05
-    // This simulates the scenario from #2957 where validation produced needs-remediation
-    // and then roadmap was reassessed to add a remediation slice
-    const result = await handleReassessRoadmap({
-      milestoneId: 'M001',
-      completedSliceId: 'S04',
-      verdict: 'on-track',
-      assessment: 'S04 completed. Adding remediation slice S05.',
-      sliceChanges: {
-        modified: [],
-        added: [
-          {
-            sliceId: 'S05',
-            title: 'Remediation Slice',
-            risk: 'low',
-            depends: ['S04'],
-            demo: 'Fix the issues found during validation.',
-          },
-        ],
-        removed: [],
-      },
-    }, base);
-
-    assert.ok(!('error' in result), `unexpected error: ${'error' in result ? result.error : ''}`);
-
-    // The stale milestone-validation row must be deleted after roadmap changes
-    const after = adapter.prepare(
-      `SELECT * FROM assessments WHERE milestone_id = 'M001' AND scope = 'milestone-validation'`,
-    ).get() as Record<string, unknown> | undefined;
-    assert.equal(after, undefined, 'milestone-validation row should be deleted after roadmap changes — stale validation must not survive remediation (#2957)');
-  } finally {
-    cleanup(base);
-  }
-});
-
-test('handleReassessRoadmap does NOT invalidate validation when no roadmap structural changes (#2957)', async () => {
-  const base = makeTmpBase();
-  openDatabase(join(base, '.gsd', 'gsd.db'));
-
-  try {
-    // Seed: M001 with slices, plus a validation with pass verdict
-    insertMilestone({ id: 'M001', title: 'Test Milestone', status: 'active' });
-    insertSlice({ id: 'S01', milestoneId: 'M001', title: 'Slice One', status: 'complete', demo: 'Demo' });
-    insertSlice({ id: 'S02', milestoneId: 'M001', title: 'Slice Two', status: 'pending', demo: 'Demo' });
-
-    // Insert milestone-validation assessment with pass verdict
-    const validationPath = join('.gsd', 'milestones', 'M001', 'M001-VALIDATION.md');
-    insertAssessment({
-      path: validationPath,
-      milestoneId: 'M001',
-      sliceId: null,
-      taskId: null,
-      status: 'pass',
-      scope: 'milestone-validation',
-      fullContent: '---\nverdict: pass\nremediation_round: 0\n---\n\n# Validation\nAll good.',
-    });
-
-    // Reassess with no structural changes (empty added/modified/removed)
-    const result = await handleReassessRoadmap({
-      milestoneId: 'M001',
-      completedSliceId: 'S01',
-      verdict: 'confirmed',
-      assessment: 'S01 completed. No changes needed.',
-      sliceChanges: {
-        modified: [],
-        added: [],
-        removed: [],
-      },
-    }, base);
-
-    assert.ok(!('error' in result), `unexpected error: ${'error' in result ? result.error : ''}`);
-
-    // Validation should still exist when no structural changes occurred
-    const adapter = _getAdapter()!;
-    const row = adapter.prepare(
-      `SELECT * FROM assessments WHERE milestone_id = 'M001' AND scope = 'milestone-validation'`,
-    ).get() as Record<string, unknown> | undefined;
-    assert.ok(row, 'milestone-validation row should survive when no structural changes occurred');
-  } finally {
-    cleanup(base);
-  }
-});

package/src/resources/extensions/gsd/tests/roadmap-slices.test.ts

@@ -296,100 +296,3 @@ Do the second thing.
   assert.equal(slices[0]?.id, "S01");
   assert.equal(slices[1]?.id, "S02");
 });
-
-// ── Regression tests for #2567 ─────────────────────────────────────────────
-// Prose H3 parser fails on common LLM-generated patterns: numbered prefixes,
-// parenthetical numbering, bracketed IDs, and indented headings.
-
-test("parseRoadmapSlices: numbered H3 headers under ## Slices (#2567)", () => {
-  const numberedContent = `# M002: My Milestone
-
-**Vision:** Ship the product.
-
-## Slices
-
-### 1. S01: Setup Environment
-Set up the dev environment and tooling.
-
-### 2. S02: Build Core
-Implement the core logic.
-**Depends on:** S01
-
-### 3. S03: Polish UI
-Final polish and theming.
-**Depends on:** S01, S02
-`;
-  const slices = parseRoadmapSlices(numberedContent);
-  assert.equal(slices.length, 3, "should parse 3 slices from numbered H3 headers");
-  assert.equal(slices[0]?.id, "S01");
-  assert.equal(slices[0]?.title, "Setup Environment");
-  assert.equal(slices[1]?.id, "S02");
-  assert.deepEqual(slices[1]?.depends, ["S01"]);
-  assert.equal(slices[2]?.id, "S03");
-  assert.deepEqual(slices[2]?.depends, ["S01", "S02"]);
-});
-
-test("parseRoadmapSlices: parenthetical-numbered H3 headers (#2567)", () => {
-  const parenContent = `# M002: Milestone
-
-**Vision:** Ship.
-
-## Slices
-
-### (1) S01: Setup
-Setup work.
-
-### (2) S02: Build
-Build work.
-**Depends on:** S01
-`;
-  const slices = parseRoadmapSlices(parenContent);
-  assert.equal(slices.length, 2, "should parse slices with parenthetical numbering");
-  assert.equal(slices[0]?.id, "S01");
-  assert.equal(slices[0]?.title, "Setup");
-  assert.equal(slices[1]?.id, "S02");
-  assert.deepEqual(slices[1]?.depends, ["S01"]);
-});
-
-test("parseRoadmapSlices: bracketed slice IDs in H3 headers (#2567)", () => {
-  const bracketContent = `# M002: Milestone
-
-**Vision:** Ship.
-
-## Slices
-
-### [S01] Setup Environment
-Setup work.
-
-### [S02] Build Core
-Build work.
-**Depends on:** S01
-`;
-  const slices = parseRoadmapSlices(bracketContent);
-  assert.equal(slices.length, 2, "should parse slices with bracketed IDs");
-  assert.equal(slices[0]?.id, "S01");
-  assert.equal(slices[0]?.title, "Setup Environment");
-  assert.equal(slices[1]?.id, "S02");
-  assert.deepEqual(slices[1]?.depends, ["S01"]);
-});
-
-test("parseRoadmapSlices: indented H3 headers under ## Slices (#2567)", () => {
-  const indentedContent = `# M002: Milestone
-
-**Vision:** Ship.
-
-## Slices
-
-  ### S01: Setup
-  Setup work.
-
-  ### S02: Build
-  Build work.
-`;
-  const slices = parseRoadmapSlices(indentedContent);
-  assert.equal(slices.length, 2, "should parse slices from indented H3 headers");
-  assert.equal(slices[0]?.id, "S01");
-  assert.equal(slices[0]?.title, "Setup");
-  assert.equal(slices[1]?.id, "S02");
-  assert.equal(slices[1]?.title, "Build");
-});

package/src/resources/extensions/gsd/tests/secure-env-collect.test.ts

@@ -183,137 +183,3 @@ test("secure_env_collect: detectDestination — convex file (not dir) does not t
 		rmSync(tmp, { recursive: true, force: true });
 	}
 });
-
-// ─── Bug #2997: undefined vs null handling ──────────────────────────────────
-
-/**
- * When ctx.ui.custom() returns undefined (e.g. noOpUIContext, component
- * disposal, abort), the strict null checks (=== null / !== null) let
- * undefined slip through as a "provided" value, crashing writeEnvKey
- * which calls .replace() on it.
- *
- * These tests verify the fix: loose equality (== null / != null) so that
- * both null AND undefined are treated as "skipped".
- */
-
-// Helper to dynamically load the orchestrator
-async function loadOrchestrator(): Promise<{
-	collectSecretsFromManifest: Function;
-}> {
-	const mod = await import("../../get-secrets-from-user.ts");
-	return { collectSecretsFromManifest: mod.collectSecretsFromManifest };
-}
-
-// Helper to dynamically load files.ts functions
-async function loadFilesExports(): Promise<{
-	formatSecretsManifest: (m: any) => string;
-}> {
-	const mod = await import("../files.ts");
-	return { formatSecretsManifest: mod.formatSecretsManifest };
-}
-
-function makeManifest(entries: Array<{ key: string; status?: string; formatHint?: string; guidance?: string[] }>): any {
-	return {
-		milestone: "M001",
-		generatedAt: "2026-03-12T00:00:00Z",
-		entries: entries.map((e) => ({
-			key: e.key,
-			service: "TestService",
-			dashboardUrl: "",
-			guidance: e.guidance ?? [],
-			formatHint: e.formatHint ?? "",
-			status: e.status ?? "pending",
-			destination: "dotenv",
-		})),
-	};
-}
-
-async function writeManifestFile(dir: string, manifest: any): Promise<string> {
-	const { formatSecretsManifest } = await loadFilesExports();
-	const milestoneDir = join(dir, ".gsd", "milestones", "M001");
-	mkdirSync(milestoneDir, { recursive: true });
-	const filePath = join(milestoneDir, "M001-SECRETS.md");
-	writeFileSync(filePath, formatSecretsManifest(manifest));
-	return filePath;
-}
-
-test("secure_env_collect #2997: undefined from ctx.ui.custom() is treated as skipped, not provided", async (t) => {
-	const { collectSecretsFromManifest } = await loadOrchestrator();
-
-	const tmp = makeTempDir("sec-undefined-test");
-	t.after(() => {
-		rmSync(tmp, { recursive: true, force: true });
-	});
-
-	const manifest = makeManifest([
-		{ key: "SECRET_THAT_RETURNS_UNDEFINED", status: "pending" },
-	]);
-	await writeManifestFile(tmp, manifest);
-
-	let callIndex = 0;
-	const mockCtx = {
-		cwd: tmp,
-		hasUI: true,
-		ui: {
-			// First call is summary screen, second is collect — return undefined
-			// to simulate noOpUIContext or component disposal
-			custom: async (_factory: any) => {
-				callIndex++;
-				if (callIndex <= 1) return null; // summary screen dismiss
-				return undefined; // BUG TRIGGER: should be treated as skipped
-			},
-		},
-	};
-
-	// Before the fix, this crashes with:
-	// "Cannot read properties of undefined (reading 'replace')"
-	const result = await collectSecretsFromManifest(tmp, "M001", mockCtx as any);
-
-	// The undefined-returning key must appear in skipped, not in applied
-	assert.ok(
-		result.skipped.includes("SECRET_THAT_RETURNS_UNDEFINED"),
-		"Key returning undefined should be in skipped list",
-	);
-	assert.ok(
-		!result.applied.includes("SECRET_THAT_RETURNS_UNDEFINED"),
-		"Key returning undefined must NOT be in applied list",
-	);
-});
-
-test("secure_env_collect #2997: null from ctx.ui.custom() is still treated as skipped (regression guard)", async (t) => {
-	const { collectSecretsFromManifest } = await loadOrchestrator();
-
-	const tmp = makeTempDir("sec-null-test");
-	t.after(() => {
-		rmSync(tmp, { recursive: true, force: true });
-	});
-
-	const manifest = makeManifest([
-		{ key: "SECRET_THAT_RETURNS_NULL", status: "pending" },
-	]);
-	await writeManifestFile(tmp, manifest);
-
-	let callIndex = 0;
-	const mockCtx = {
-		cwd: tmp,
-		hasUI: true,
-		ui: {
-			custom: async (_factory: any) => {
-				callIndex++;
-				if (callIndex <= 1) return null; // summary screen dismiss
-				return null; // explicit null skip
-			},
-		},
-	};
-
-	const result = await collectSecretsFromManifest(tmp, "M001", mockCtx as any);
-
-	assert.ok(
-		result.skipped.includes("SECRET_THAT_RETURNS_NULL"),
-		"Key returning null should be in skipped list",
-	);
-	assert.ok(
-		!result.applied.includes("SECRET_THAT_RETURNS_NULL"),
-		"Key returning null must NOT be in applied list",
-	);
-});

package/src/resources/extensions/gsd/tests/tool-naming.test.ts

@@ -24,7 +24,6 @@ function makeMockPi() {
 const RENAME_MAP: Array<{ canonical: string; alias: string }> = [
   { canonical: "gsd_decision_save", alias: "gsd_save_decision" },
   { canonical: "gsd_requirement_update", alias: "gsd_update_requirement" },
-  { canonical: "gsd_requirement_save", alias: "gsd_save_requirement" },
   { canonical: "gsd_summary_save", alias: "gsd_save_summary" },
   { canonical: "gsd_milestone_generate_id", alias: "gsd_generate_milestone_id" },
   { canonical: "gsd_task_complete", alias: "gsd_complete_task" },
@@ -45,7 +44,7 @@ console.log('\n── Tool naming: registration count ──');
 const pi = makeMockPi();
 registerDbTools(pi);
 
-assert.deepStrictEqual(pi.tools.length, 29, 'Should register exactly 29 tools (14 canonical + 14 aliases + 1 gate tool)');
+assert.deepStrictEqual(pi.tools.length, 27, 'Should register exactly 27 tools (13 canonical + 13 aliases + 1 gate tool)');
 
 // ─── Both names exist for each pair ──────────────────────────────────────────
 

package/src/resources/extensions/gsd/tests/triage-resolution.test.ts

@@ -212,14 +212,6 @@ test("resolution: buildQuickTaskPrompt includes capture text and ID", () => {
   assert.ok(prompt.includes("add retry logic to OAuth"), "should include capture text");
   assert.ok(prompt.includes("Quick Task"), "should have Quick Task header");
   assert.ok(prompt.includes("Do NOT modify"), "should warn about plan files");
-  assert.ok(
-    prompt.includes("Verify the issue still exists"),
-    "should instruct agent to verify issue still exists (#2872)",
-  );
-  assert.ok(
-    prompt.includes("Already resolved"),
-    "should instruct agent to report already resolved if fixed (#2872)",
-  );
 });
 
 // ─── markCaptureExecuted ─────────────────────────────────────────────────────

package/src/resources/extensions/gsd/tests/unit-ownership.test.ts

@@ -3,7 +3,7 @@
 
 import test from 'node:test';
 import assert from 'node:assert/strict';
-import { mkdtempSync, rmSync } from 'node:fs';
+import { mkdtempSync, rmSync, existsSync, readFileSync } from 'node:fs';
 import { join } from 'node:path';
 import { tmpdir } from 'node:os';
 
@@ -14,8 +14,6 @@ import {
   checkOwnership,
   taskUnitKey,
   sliceUnitKey,
-  initOwnershipTable,
-  closeOwnershipDb,
 } from '../unit-ownership.ts';
 
 function makeTmpBase(): string {
@@ -36,51 +34,28 @@ test('sliceUnitKey: builds correct key', () => {
   assert.equal(sliceUnitKey('M001', 'S01'), 'M001/S01');
 });
 
-// ─── Claim / get / release (SQLite-backed) ──────────────────────────────
+// ─── Claim / get / release ───────────────────────────────────────────────
 
-test('claimUnit: creates DB and records agent', () => {
+test('claimUnit: creates claim file and records agent', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
-    const claimed = claimUnit(base, 'M001/S01/T01', 'executor-01');
+    claimUnit(base, 'M001/S01/T01', 'executor-01');
 
-    assert.equal(claimed, true, 'first claim should succeed');
+    assert.ok(existsSync(join(base, '.gsd', 'unit-claims.json')), 'claim file should exist');
     assert.equal(getOwner(base, 'M001/S01/T01'), 'executor-01');
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
 
-test('claimUnit: rejects second claim on same unit (first-writer-wins)', () => {
+test('claimUnit: overwrites existing claim (last writer wins)', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
-    const first = claimUnit(base, 'M001/S01/T01', 'executor-01');
-    const second = claimUnit(base, 'M001/S01/T01', 'executor-02');
+    claimUnit(base, 'M001/S01/T01', 'executor-01');
+    claimUnit(base, 'M001/S01/T01', 'executor-02');
 
-    assert.equal(first, true, 'first claim should succeed');
-    assert.equal(second, false, 'second claim should fail (first-writer-wins)');
-    assert.equal(getOwner(base, 'M001/S01/T01'), 'executor-01',
-      'original owner must be preserved');
+    assert.equal(getOwner(base, 'M001/S01/T01'), 'executor-02');
   } finally {
-    closeOwnershipDb(base);
-    cleanup(base);
-  }
-});
-
-test('claimUnit: same agent re-claiming same unit succeeds', () => {
-  const base = makeTmpBase();
-  try {
-    initOwnershipTable(base);
-    const first = claimUnit(base, 'M001/S01/T01', 'agent-a');
-    const second = claimUnit(base, 'M001/S01/T01', 'agent-a');
-
-    assert.equal(first, true);
-    assert.equal(second, true, 're-claim by same agent should succeed');
-    assert.equal(getOwner(base, 'M001/S01/T01'), 'agent-a');
-  } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
@@ -88,25 +63,21 @@ test('claimUnit: same agent re-claiming same unit succeeds', () => {
 test('claimUnit: multiple units can be claimed independently', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     claimUnit(base, 'M001/S01/T01', 'agent-a');
     claimUnit(base, 'M001/S01/T02', 'agent-b');
 
     assert.equal(getOwner(base, 'M001/S01/T01'), 'agent-a');
     assert.equal(getOwner(base, 'M001/S01/T02'), 'agent-b');
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
 
-test('getOwner: returns null when no DB initialized', () => {
+test('getOwner: returns null when no claim file exists', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     assert.equal(getOwner(base, 'M001/S01/T01'), null);
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
@@ -114,11 +85,9 @@ test('getOwner: returns null when no DB initialized', () => {
 test('getOwner: returns null for unclaimed unit', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     claimUnit(base, 'M001/S01/T01', 'agent-a');
     assert.equal(getOwner(base, 'M001/S01/T99'), null);
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
@@ -126,13 +95,11 @@ test('getOwner: returns null for unclaimed unit', () => {
 test('releaseUnit: removes claim', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     claimUnit(base, 'M001/S01/T01', 'agent-a');
     releaseUnit(base, 'M001/S01/T01');
 
     assert.equal(getOwner(base, 'M001/S01/T01'), null);
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
@@ -140,43 +107,32 @@ test('releaseUnit: removes claim', () => {
 test('releaseUnit: no-op for non-existent claim', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     // Should not throw
     releaseUnit(base, 'M001/S01/T01');
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
 
-test('releaseUnit: allows reclaim after release', () => {
+// ─── checkOwnership ──────────────────────────────────────────────────────
+
+test('checkOwnership: returns null when no actorName provided (opt-in)', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     claimUnit(base, 'M001/S01/T01', 'agent-a');
-    releaseUnit(base, 'M001/S01/T01');
 
-    const reclaimed = claimUnit(base, 'M001/S01/T01', 'agent-b');
-    assert.equal(reclaimed, true, 'reclaim after release should succeed');
-    assert.equal(getOwner(base, 'M001/S01/T01'), 'agent-b');
+    // No actorName → ownership not enforced
+    assert.equal(checkOwnership(base, 'M001/S01/T01', undefined), null);
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
 
-// ─── checkOwnership ──────────────────────────────────────────────────────
-
-test('checkOwnership: returns null when no actorName provided (opt-in)', () => {
+test('checkOwnership: returns null when no claim file exists', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
-    claimUnit(base, 'M001/S01/T01', 'agent-a');
-
-    // No actorName → ownership not enforced
-    assert.equal(checkOwnership(base, 'M001/S01/T01', undefined), null);
+    assert.equal(checkOwnership(base, 'M001/S01/T01', 'agent-a'), null);
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
@@ -184,13 +140,11 @@ test('checkOwnership: returns null when no actorName provided (opt-in)', () => {
 test('checkOwnership: returns null when unit is unclaimed', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     claimUnit(base, 'M001/S01/T01', 'agent-a');
 
     // Different unit, unclaimed
     assert.equal(checkOwnership(base, 'M001/S01/T99', 'agent-b'), null);
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
@@ -198,12 +152,10 @@ test('checkOwnership: returns null when unit is unclaimed', () => {
 test('checkOwnership: returns null when actor matches owner', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     claimUnit(base, 'M001/S01/T01', 'agent-a');
 
     assert.equal(checkOwnership(base, 'M001/S01/T01', 'agent-a'), null);
   } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });
@@ -211,7 +163,6 @@ test('checkOwnership: returns null when actor matches owner', () => {
 test('checkOwnership: returns error string when actor does not match owner', () => {
   const base = makeTmpBase();
   try {
-    initOwnershipTable(base);
     claimUnit(base, 'M001/S01/T01', 'agent-a');
 
     const err = checkOwnership(base, 'M001/S01/T01', 'agent-b');
@@ -219,40 +170,6 @@ test('checkOwnership: returns error string when actor does not match owner', ()
     assert.match(err!, /owned by agent-a/);
     assert.match(err!, /not agent-b/);
   } finally {
-    closeOwnershipDb(base);
-    cleanup(base);
-  }
-});
-
-// ─── Race condition: first-writer-wins atomicity ─────────────────────────
-
-test('claimUnit: concurrent claims — only first writer wins (no lost update)', () => {
-  const base = makeTmpBase();
-  try {
-    initOwnershipTable(base);
-
-    // Simulate the race described in #2728:
-    // Two agents both try to claim the same unit.
-    // With SQLite INSERT OR IGNORE, only the first succeeds.
-    const results: boolean[] = [];
-    const agents = ['agent-alpha', 'agent-beta', 'agent-gamma'];
-    for (const agent of agents) {
-      results.push(claimUnit(base, 'M001/S01/T01', agent));
-    }
-
-    // Exactly one agent should have won
-    const wins = results.filter(r => r === true);
-    assert.equal(wins.length, 1, 'exactly one agent should win the claim');
-
-    // The winner is the first agent (deterministic in single-threaded)
-    assert.equal(results[0], true);
-    assert.equal(results[1], false);
-    assert.equal(results[2], false);
-
-    // The owner must be the first agent
-    assert.equal(getOwner(base, 'M001/S01/T01'), 'agent-alpha');
-  } finally {
-    closeOwnershipDb(base);
     cleanup(base);
   }
 });

package/src/resources/extensions/gsd/tests/validate-milestone-write-order.test.ts

@@ -6,7 +6,7 @@ import { tmpdir } from "node:os";
 import { randomUUID } from "node:crypto";
 
 import { handleValidateMilestone } from "../tools/validate-milestone.js";
-import { openDatabase, closeDatabase, _getAdapter, insertMilestone, insertSlice } from "../gsd-db.js";
+import { openDatabase, closeDatabase, _getAdapter, insertMilestone } from "../gsd-db.js";
 import { clearPathCache } from "../paths.js";
 import { clearParseCache } from "../files.js";
 
@@ -45,7 +45,6 @@ describe("handleValidateMilestone write ordering (#2725)", () => {
     const dbPath = join(base, ".gsd", "gsd.db");
     openDatabase(dbPath);
     insertMilestone({ id: "M001" });
-    insertSlice({ id: "S01", milestoneId: "M001" });
 
     const result = await handleValidateMilestone(VALID_PARAMS, base);
     assert.ok(!("error" in result), `unexpected error: ${"error" in result ? result.error : ""}`);
@@ -72,7 +71,6 @@ describe("handleValidateMilestone write ordering (#2725)", () => {
     const dbPath = join(base, ".gsd", "gsd.db");
     openDatabase(dbPath);
     insertMilestone({ id: "M001" });
-    insertSlice({ id: "S01", milestoneId: "M001" });
 
     const result = await handleValidateMilestone(
       { ...VALID_PARAMS, verificationClasses: undefined },
@@ -90,7 +88,6 @@ describe("handleValidateMilestone write ordering (#2725)", () => {
     const dbPath = join(base, ".gsd", "gsd.db");
     openDatabase(dbPath);
     insertMilestone({ id: "M001" });
-    insertSlice({ id: "S01", milestoneId: "M001" });
 
     // Force disk write failure by replacing the milestone directory with a
     // regular file. saveFile() will fail because it cannot write inside a