gsd-pi 2.58.0-dev.778d6ac → 2.58.0-dev.d63175c

package/packages/pi-coding-agent/dist/core/tools/spawn-shell-windows.test.js

@@ -1,80 +0,0 @@
-/**
- * spawn-shell-windows.test.ts — Regression test for Windows spawn ENOENT/EINVAL.
- *
- * On Windows, npm/npx/tsc and other tools are installed as .cmd batch scripts.
- * Node's `spawn()` without `shell: true` cannot execute .cmd files, resulting
- * in ENOENT or EINVAL errors. Every spawn site that may invoke a user-installed
- * binary (not `node` or a shell like `sh`/`bash`/`cmd`) must include
- * `shell: process.platform === "win32"` so the call is resolved through cmd.exe
- * on Windows while remaining a direct exec on POSIX.
- *
- * This test structurally scans all spawn sites and verifies the guard is present.
- *
- * Fixes: gsd-build/gsd-2#2854
- */
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname, relative } from "node:path";
-import { fileURLToPath } from "node:url";
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const coreDir = join(__dirname, "..");
-/**
- * Files that call `spawn()` with a user-facing binary (not `node`, `sh`, `bash`,
- * or `cmd`) and therefore need the Windows shell guard.
- *
- * If a file spawns only hardcoded system binaries (like `node` in rpc-client.ts),
- * it does not need the guard and should NOT appear here.
- */
-const SPAWN_FILES_NEEDING_SHELL_GUARD = [
-    // Extension's GSD client — spawns the `gsd` binary which is a .cmd on Windows
-    join(coreDir, "..", "..", "..", "vscode-extension", "src", "gsd-client.ts"),
-    // exec.ts — used by extensions to run arbitrary commands
-    join(coreDir, "exec.ts"),
-    // LSP index — spawns project-type commands (tsc, cargo, etc.)
-    join(coreDir, "lsp", "index.ts"),
-    // LSP client — spawns LSP server binaries (npx, etc.)
-    join(coreDir, "lsp", "client.ts"),
-    // LSP mux — spawns lspmux binary
-    join(coreDir, "lsp", "lspmux.ts"),
-    // Package manager — spawns npm/yarn/pnpm
-    join(coreDir, "package-manager.ts"),
-];
-test("all spawn sites that invoke user-facing binaries include shell: process.platform === 'win32'", () => {
-    const failures = [];
-    for (const file of SPAWN_FILES_NEEDING_SHELL_GUARD) {
-        let content;
-        try {
-            content = readFileSync(file, "utf-8");
-        }
-        catch {
-            // File may not exist in this checkout — skip
-            continue;
-        }
-        const lines = content.split("\n");
-        // Find all spawn(..., { ... }) call sites and check each one
-        // for the presence of `shell: process.platform === "win32"` within
-        // 5 lines after the spawn call.
-        for (let i = 0; i < lines.length; i++) {
-            const line = lines[i];
-            // Skip comments
-            if (line.trim().startsWith("//") || line.trim().startsWith("*"))
-                continue;
-            // Detect a spawn() call
-            if (/\bspawn\(/.test(line)) {
-                // Look ahead up to 8 lines for the shell guard
-                const lookahead = lines.slice(i, i + 8).join("\n");
-                const hasShellGuard = /shell:\s*process\.platform\s*===\s*["']win32["']/.test(lookahead);
-                if (!hasShellGuard) {
-                    const relPath = relative(join(coreDir, "..", ".."), file);
-                    failures.push(`${relPath}:${i + 1}`);
-                }
-            }
-        }
-    }
-    assert.deepEqual(failures, [], `The following spawn sites are missing 'shell: process.platform === "win32"':\n` +
-        failures.map(f => `  - ${f}`).join("\n") +
-        `\nOn Windows, .cmd wrapper scripts (npm, npx, tsc, gsd) require shell ` +
-        `resolution. Without this guard, spawn fails with ENOENT or EINVAL.`);
-});
-//# sourceMappingURL=spawn-shell-windows.test.js.map

package/packages/pi-coding-agent/dist/core/tools/spawn-shell-windows.test.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"spawn-shell-windows.test.js","sourceRoot":"","sources":["../../../src/core/tools/spawn-shell-windows.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG;AAEH,OAAO,IAAI,MAAM,WAAW,CAAC;AAC7B,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,WAAW,CAAC;AACpD,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;AAEtC;;;;;;GAMG;AACH,MAAM,+BAA+B,GAAG;IACvC,8EAA8E;IAC9E,IAAI,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,kBAAkB,EAAE,KAAK,EAAE,eAAe,CAAC;IAC3E,yDAAyD;IACzD,IAAI,CAAC,OAAO,EAAE,SAAS,CAAC;IACxB,8DAA8D;IAC9D,IAAI,CAAC,OAAO,EAAE,KAAK,EAAE,UAAU,CAAC;IAChC,sDAAsD;IACtD,IAAI,CAAC,OAAO,EAAE,KAAK,EAAE,WAAW,CAAC;IACjC,iCAAiC;IACjC,IAAI,CAAC,OAAO,EAAE,KAAK,EAAE,WAAW,CAAC;IACjC,yCAAyC;IACzC,IAAI,CAAC,OAAO,EAAE,oBAAoB,CAAC;CACnC,CAAC;AAEF,IAAI,CAAC,8FAA8F,EAAE,GAAG,EAAE;IACzG,MAAM,QAAQ,GAAa,EAAE,CAAC;IAE9B,KAAK,MAAM,IAAI,IAAI,+BAA+B,EAAE,CAAC;QACpD,IAAI,OAAe,CAAC;QACpB,IAAI,CAAC;YACJ,OAAO,GAAG,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;QACvC,CAAC;QAAC,MAAM,CAAC;YACR,6CAA6C;YAC7C,SAAS;QACV,CAAC;QAED,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAElC,6DAA6D;QAC7D,mEAAmE;QACnE,gCAAgC;QAChC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACvC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAE,CAAC;YACvB,gBAAgB;YAChB,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC;gBAAE,SAAS;YAE1E,wBAAwB;YACxB,IAAI,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC5B,+CAA+C;gBAC/C,MAAM,SAAS,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBACnD,MAAM,aAAa,GAClB,kDAAkD,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;gBAEpE,IAAI,CAAC,aAAa,EAAE,CAAC;oBACpB,MAAM,OAAO,GAAG,QAAQ,CAAC,IAAI,CAAC,OAAO,EAAE,IAAI,EAAE,IAAI,CAAC,EAAE,IAAI,CAAC,CAAC;oBAC1D,QAAQ,CAAC,IAAI,CAAC,GAAG,OAAO,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;gBACtC,CAAC;YACF,CAAC;QACF,CAAC;IACF,CAAC;IAED,MAAM,CAAC,SAAS,CACf,QAAQ,EACR,EAAE,EACF,gFAAgF;QAChF,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;QACxC,wEAAwE;QACxE,oEAAoE,CACpE,CAAC;AACH,CAAC,CAAC,CAAC","sourcesContent":["/**\n * spawn-shell-windows.test.ts — Regression test for Windows spawn ENOENT/EINVAL.\n *\n * On Windows, npm/npx/tsc and other tools are installed as .cmd batch scripts.\n * Node's `spawn()` without `shell: true` cannot execute .cmd files, resulting\n * in ENOENT or EINVAL errors. Every spawn site that may invoke a user-installed\n * binary (not `node` or a shell like `sh`/`bash`/`cmd`) must include\n * `shell: process.platform === \"win32\"` so the call is resolved through cmd.exe\n * on Windows while remaining a direct exec on POSIX.\n *\n * This test structurally scans all spawn sites and verifies the guard is present.\n *\n * Fixes: gsd-build/gsd-2#2854\n */\n\nimport test from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { readFileSync } from \"node:fs\";\nimport { join, dirname, relative } from \"node:path\";\nimport { fileURLToPath } from \"node:url\";\n\nconst __dirname = dirname(fileURLToPath(import.meta.url));\nconst coreDir = join(__dirname, \"..\");\n\n/**\n * Files that call `spawn()` with a user-facing binary (not `node`, `sh`, `bash`,\n * or `cmd`) and therefore need the Windows shell guard.\n *\n * If a file spawns only hardcoded system binaries (like `node` in rpc-client.ts),\n * it does not need the guard and should NOT appear here.\n */\nconst SPAWN_FILES_NEEDING_SHELL_GUARD = [\n\t// Extension's GSD client — spawns the `gsd` binary which is a .cmd on Windows\n\tjoin(coreDir, \"..\", \"..\", \"..\", \"vscode-extension\", \"src\", \"gsd-client.ts\"),\n\t// exec.ts — used by extensions to run arbitrary commands\n\tjoin(coreDir, \"exec.ts\"),\n\t// LSP index — spawns project-type commands (tsc, cargo, etc.)\n\tjoin(coreDir, \"lsp\", \"index.ts\"),\n\t// LSP client — spawns LSP server binaries (npx, etc.)\n\tjoin(coreDir, \"lsp\", \"client.ts\"),\n\t// LSP mux — spawns lspmux binary\n\tjoin(coreDir, \"lsp\", \"lspmux.ts\"),\n\t// Package manager — spawns npm/yarn/pnpm\n\tjoin(coreDir, \"package-manager.ts\"),\n];\n\ntest(\"all spawn sites that invoke user-facing binaries include shell: process.platform === 'win32'\", () => {\n\tconst failures: string[] = [];\n\n\tfor (const file of SPAWN_FILES_NEEDING_SHELL_GUARD) {\n\t\tlet content: string;\n\t\ttry {\n\t\t\tcontent = readFileSync(file, \"utf-8\");\n\t\t} catch {\n\t\t\t// File may not exist in this checkout — skip\n\t\t\tcontinue;\n\t\t}\n\n\t\tconst lines = content.split(\"\\n\");\n\n\t\t// Find all spawn(..., { ... }) call sites and check each one\n\t\t// for the presence of `shell: process.platform === \"win32\"` within\n\t\t// 5 lines after the spawn call.\n\t\tfor (let i = 0; i < lines.length; i++) {\n\t\t\tconst line = lines[i]!;\n\t\t\t// Skip comments\n\t\t\tif (line.trim().startsWith(\"//\") || line.trim().startsWith(\"*\")) continue;\n\n\t\t\t// Detect a spawn() call\n\t\t\tif (/\\bspawn\\(/.test(line)) {\n\t\t\t\t// Look ahead up to 8 lines for the shell guard\n\t\t\t\tconst lookahead = lines.slice(i, i + 8).join(\"\\n\");\n\t\t\t\tconst hasShellGuard =\n\t\t\t\t\t/shell:\\s*process\\.platform\\s*===\\s*[\"']win32[\"']/.test(lookahead);\n\n\t\t\t\tif (!hasShellGuard) {\n\t\t\t\t\tconst relPath = relative(join(coreDir, \"..\", \"..\"), file);\n\t\t\t\t\tfailures.push(`${relPath}:${i + 1}`);\n\t\t\t\t}\n\t\t\t}\n\t\t}\n\t}\n\n\tassert.deepEqual(\n\t\tfailures,\n\t\t[],\n\t\t`The following spawn sites are missing 'shell: process.platform === \"win32\"':\\n` +\n\t\tfailures.map(f => `  - ${f}`).join(\"\\n\") +\n\t\t`\\nOn Windows, .cmd wrapper scripts (npm, npx, tsc, gsd) require shell ` +\n\t\t`resolution. Without this guard, spawn fails with ENOENT or EINVAL.`,\n\t);\n});\n"]}

package/packages/pi-coding-agent/src/core/compaction/compaction.test.ts

@@ -1,236 +0,0 @@
-/**
- * Tests for chunked compaction fallback when messages exceed model context window.
- * Regression test for #2932.
- */
-
-import assert from "node:assert/strict";
-import { describe, it, mock } from "node:test";
-
-import type { AgentMessage } from "@gsd/pi-agent-core";
-import type { Model, AssistantMessage } from "@gsd/pi-ai";
-
-import { generateSummary, estimateTokens, chunkMessages } from "./compaction.js";
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-/** Create a user message with approximately `tokenCount` tokens (chars = tokens * 4). */
-function makeUserMessage(tokenCount: number): AgentMessage {
-	const text = "x".repeat(tokenCount * 4);
-	return { role: "user", content: text } as unknown as AgentMessage;
-}
-
-/** Create a mock model with a given context window. */
-function makeModel(contextWindow: number): Model<any> {
-	return {
-		id: "test-model",
-		name: "Test Model",
-		api: "anthropic-messages",
-		provider: "anthropic",
-		baseUrl: "https://api.test",
-		reasoning: false,
-		input: ["text"],
-		cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
-		contextWindow,
-		maxTokens: 4096,
-	} as Model<any>;
-}
-
-function makeFakeResponse(text: string): AssistantMessage {
-	return {
-		content: [{ type: "text", text }],
-		stopReason: "end_turn",
-	} as unknown as AssistantMessage;
-}
-
-// ---------------------------------------------------------------------------
-// chunkMessages tests
-// ---------------------------------------------------------------------------
-
-describe("chunkMessages", () => {
-	it("returns a single chunk when messages fit in budget", () => {
-		const messages: AgentMessage[] = [
-			makeUserMessage(1_000),
-			makeUserMessage(1_000),
-		];
-		const chunks = chunkMessages(messages, 100_000);
-		assert.equal(chunks.length, 1);
-		assert.equal(chunks[0].length, 2);
-	});
-
-	it("splits messages into multiple chunks when they exceed budget", () => {
-		const messages: AgentMessage[] = [
-			makeUserMessage(50_000),
-			makeUserMessage(50_000),
-			makeUserMessage(50_000),
-		];
-		// Budget of 80k tokens means each 50k message gets its own chunk
-		// (or two fit together if budget allows)
-		const chunks = chunkMessages(messages, 80_000);
-		assert.ok(chunks.length > 1, `Expected multiple chunks, got ${chunks.length}`);
-		// All messages should be present across chunks
-		const totalMessages = chunks.reduce((sum, c) => sum + c.length, 0);
-		assert.equal(totalMessages, 3);
-	});
-
-	it("puts a single oversized message in its own chunk", () => {
-		const messages: AgentMessage[] = [
-			makeUserMessage(200_000), // Way over any reasonable budget
-		];
-		const chunks = chunkMessages(messages, 80_000);
-		assert.equal(chunks.length, 1);
-		assert.equal(chunks[0].length, 1);
-	});
-
-	it("preserves message order across chunks", () => {
-		// Create messages with identifiable sizes
-		const messages: AgentMessage[] = [
-			makeUserMessage(30_000), // ~30k tokens
-			makeUserMessage(30_000),
-			makeUserMessage(30_000),
-			makeUserMessage(30_000),
-		];
-		const chunks = chunkMessages(messages, 50_000);
-		// Reconstruct original order
-		const flat = chunks.flat();
-		assert.equal(flat.length, 4);
-		for (let i = 0; i < flat.length; i++) {
-			assert.strictEqual(flat[i], messages[i], `Message ${i} should be in order`);
-		}
-	});
-});
-
-// ---------------------------------------------------------------------------
-// generateSummary chunked fallback tests
-// ---------------------------------------------------------------------------
-
-describe("generateSummary — chunked fallback (#2932)", () => {
-	it("calls _completeFn multiple times when messages exceed model context window", async () => {
-		// Arrange: 3 messages of ~80k tokens each = ~240k total, model has 200k window
-		const messages: AgentMessage[] = [
-			makeUserMessage(80_000),
-			makeUserMessage(80_000),
-			makeUserMessage(80_000),
-		];
-		const model = makeModel(200_000);
-		const reserveTokens = 16_384;
-
-		// Verify our test setup: messages really do exceed the model window
-		let totalTokens = 0;
-		for (const m of messages) totalTokens += estimateTokens(m);
-		assert.ok(
-			totalTokens > model.contextWindow,
-			`Test setup: ${totalTokens} tokens should exceed ${model.contextWindow} context window`,
-		);
-
-		// Track calls
-		const calls: string[] = [];
-		const mockComplete = mock.fn(async (_model: any, context: any, _options: any) => {
-			const userMsg = context.messages?.[0];
-			const text =
-				typeof userMsg?.content === "string"
-					? userMsg.content
-					: userMsg?.content?.[0]?.text ?? "";
-
-			if (text.includes("<previous-summary>")) {
-				calls.push("update");
-			} else {
-				calls.push("initial");
-			}
-			return makeFakeResponse("Summary of chunk");
-		});
-
-		const summary = await generateSummary(
-			messages,
-			model,
-			reserveTokens,
-			undefined, // apiKey
-			undefined, // signal
-			undefined, // customInstructions
-			undefined, // previousSummary
-			mockComplete, // _completeFn override for testing
-		);
-
-		// Assert: should have called completeSimple more than once (chunked)
-		assert.ok(
-			mockComplete.mock.callCount() > 1,
-			`Expected multiple calls for chunked summarization, got ${mockComplete.mock.callCount()}`,
-		);
-
-		// First call should be an initial summary, subsequent should be updates
-		assert.equal(calls[0], "initial", "First chunk should use initial summarization prompt");
-		for (let i = 1; i < calls.length; i++) {
-			assert.equal(calls[i], "update", `Chunk ${i + 1} should use update summarization prompt`);
-		}
-
-		// Should return a non-empty summary
-		assert.ok(summary.length > 0, "Summary should not be empty");
-	});
-
-	it("uses single-pass when messages fit within model context window", async () => {
-		const messages: AgentMessage[] = [
-			makeUserMessage(10_000),
-			makeUserMessage(10_000),
-		];
-		const model = makeModel(200_000);
-		const reserveTokens = 16_384;
-
-		// Verify test setup
-		let totalTokens = 0;
-		for (const m of messages) totalTokens += estimateTokens(m);
-		assert.ok(
-			totalTokens < model.contextWindow,
-			`Test setup: ${totalTokens} tokens should fit in ${model.contextWindow} context window`,
-		);
-
-		const mockComplete = mock.fn(async () => makeFakeResponse("Single pass summary"));
-
-		await generateSummary(messages, model, reserveTokens, undefined, undefined, undefined, undefined, mockComplete);
-
-		assert.equal(
-			mockComplete.mock.callCount(),
-			1,
-			"Should use single-pass summarization when messages fit in context window",
-		);
-	});
-
-	it("passes previousSummary through chunked summarization", async () => {
-		const messages: AgentMessage[] = [
-			makeUserMessage(80_000),
-			makeUserMessage(80_000),
-			makeUserMessage(80_000),
-		];
-		const model = makeModel(200_000);
-		const reserveTokens = 16_384;
-		const previousSummary = "Previous session summary content";
-
-		const prompts: string[] = [];
-		const mockComplete = mock.fn(async (_model: any, context: any) => {
-			const userMsg = context.messages?.[0];
-			const text =
-				typeof userMsg?.content === "string"
-					? userMsg.content
-					: userMsg?.content?.[0]?.text ?? "";
-			prompts.push(text);
-			return makeFakeResponse("Chunk summary");
-		});
-
-		await generateSummary(
-			messages,
-			model,
-			reserveTokens,
-			undefined,
-			undefined,
-			undefined,
-			previousSummary,
-			mockComplete,
-		);
-
-		// First chunk should include the previousSummary
-		assert.ok(
-			prompts[0].includes(previousSummary),
-			"First chunk should incorporate the previousSummary",
-		);
-	});
-});

package/packages/pi-coding-agent/src/core/extensions/extension-manifest.test.ts

@@ -1,77 +0,0 @@
-// GSD-2 — Extension Manifest Tests
-// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
-
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { readManifest, readManifestFromEntryPath } from "./extension-manifest.js";
-
-describe("readManifest", () => {
-	it("returns null for missing directory", () => {
-		assert.equal(readManifest("/nonexistent/path"), null);
-	});
-
-	it("returns null for directory without manifest", () => {
-		const dir = mkdtempSync(join(tmpdir(), "ext-manifest-"));
-		assert.equal(readManifest(dir), null);
-	});
-
-	it("returns null for invalid JSON", () => {
-		const dir = mkdtempSync(join(tmpdir(), "ext-manifest-"));
-		writeFileSync(join(dir, "extension-manifest.json"), "not json{{{", "utf-8");
-		assert.equal(readManifest(dir), null);
-	});
-
-	it("returns null for manifest missing required fields", () => {
-		const dir = mkdtempSync(join(tmpdir(), "ext-manifest-"));
-		writeFileSync(
-			join(dir, "extension-manifest.json"),
-			JSON.stringify({ id: "test", name: "test" }),
-		);
-		assert.equal(readManifest(dir), null);
-	});
-
-	it("returns valid manifest", () => {
-		const dir = mkdtempSync(join(tmpdir(), "ext-manifest-"));
-		const manifest = {
-			id: "test-ext",
-			name: "Test Extension",
-			version: "1.0.0",
-			tier: "bundled",
-			requires: { platform: ">=2.29.0" },
-		};
-		writeFileSync(join(dir, "extension-manifest.json"), JSON.stringify(manifest));
-		const result = readManifest(dir);
-		assert.equal(result?.id, "test-ext");
-		assert.equal(result?.tier, "bundled");
-	});
-});
-
-describe("readManifestFromEntryPath", () => {
-	it("reads manifest from parent of entry path", () => {
-		const dir = mkdtempSync(join(tmpdir(), "ext-manifest-"));
-		const extDir = join(dir, "my-ext");
-		mkdirSync(extDir);
-		writeFileSync(
-			join(extDir, "extension-manifest.json"),
-			JSON.stringify({
-				id: "my-ext",
-				name: "My Extension",
-				version: "1.0.0",
-				tier: "community",
-			}),
-		);
-		writeFileSync(join(extDir, "index.ts"), "");
-
-		const result = readManifestFromEntryPath(join(extDir, "index.ts"));
-		assert.equal(result?.id, "my-ext");
-		assert.equal(result?.tier, "community");
-	});
-
-	it("returns null when entry path parent has no manifest", () => {
-		const dir = mkdtempSync(join(tmpdir(), "ext-manifest-"));
-		assert.equal(readManifestFromEntryPath(join(dir, "index.ts")), null);
-	});
-});

package/packages/pi-coding-agent/src/core/extensions/extension-manifest.ts

@@ -1,62 +0,0 @@
-// GSD-2 — Extension Manifest: Types and reading for extension-manifest.json
-// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
-
-import { existsSync, readFileSync } from "node:fs";
-import { dirname, join } from "node:path";
-
-// ─── Types ──────────────────────────────────────────────────────────────────
-
-export interface ExtensionManifest {
-	id: string;
-	name: string;
-	version: string;
-	description: string;
-	tier: "core" | "bundled" | "community";
-	requires: { platform: string };
-	provides?: {
-		tools?: string[];
-		commands?: string[];
-		hooks?: string[];
-		shortcuts?: string[];
-	};
-	dependencies?: {
-		extensions?: string[];
-		runtime?: string[];
-	};
-}
-
-// ─── Validation ─────────────────────────────────────────────────────────────
-
-function isManifest(data: unknown): data is ExtensionManifest {
-	if (typeof data !== "object" || data === null) return false;
-	const obj = data as Record<string, unknown>;
-	return (
-		typeof obj.id === "string" &&
-		typeof obj.name === "string" &&
-		typeof obj.version === "string" &&
-		typeof obj.tier === "string"
-	);
-}
-
-// ─── Reading ────────────────────────────────────────────────────────────────
-
-/** Read extension-manifest.json from a directory. Returns null if missing or invalid. */
-export function readManifest(extensionDir: string): ExtensionManifest | null {
-	const manifestPath = join(extensionDir, "extension-manifest.json");
-	if (!existsSync(manifestPath)) return null;
-	try {
-		const raw = JSON.parse(readFileSync(manifestPath, "utf-8"));
-		return isManifest(raw) ? raw : null;
-	} catch {
-		return null;
-	}
-}
-
-/**
- * Given an entry path (e.g. `.../extensions/browser-tools/index.ts`),
- * resolve the parent directory and read its manifest.
- */
-export function readManifestFromEntryPath(entryPath: string): ExtensionManifest | null {
-	const dir = dirname(entryPath);
-	return readManifest(dir);
-}

package/packages/pi-coding-agent/src/core/extensions/extension-sort.test.ts

@@ -1,134 +0,0 @@
-// GSD-2 — Extension Sort Tests
-// Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
-
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { sortExtensionPaths } from "./extension-sort.js";
-
-function createExtDir(base: string, id: string, deps?: string[]): string {
-	const dir = join(base, id);
-	mkdirSync(dir, { recursive: true });
-	writeFileSync(
-		join(dir, "extension-manifest.json"),
-		JSON.stringify({
-			id,
-			name: id,
-			version: "1.0.0",
-			tier: "bundled",
-			requires: { platform: ">=2.29.0" },
-			...(deps ? { dependencies: { extensions: deps } } : {}),
-		}),
-	);
-	writeFileSync(join(dir, "index.ts"), `export default function() {}`);
-	return join(dir, "index.ts");
-}
-
-describe("sortExtensionPaths", () => {
-	it("returns empty for empty input", () => {
-		const result = sortExtensionPaths([]);
-		assert.deepEqual(result.sortedPaths, []);
-		assert.deepEqual(result.warnings, []);
-	});
-
-	it("sorts independent extensions alphabetically", () => {
-		const base = mkdtempSync(join(tmpdir(), "ext-sort-"));
-		const pathC = createExtDir(base, "charlie");
-		const pathA = createExtDir(base, "alpha");
-		const pathB = createExtDir(base, "bravo");
-
-		const result = sortExtensionPaths([pathC, pathA, pathB]);
-		assert.deepEqual(result.sortedPaths, [pathA, pathB, pathC]);
-		assert.equal(result.warnings.length, 0);
-	});
-
-	it("sorts dependencies before dependents", () => {
-		const base = mkdtempSync(join(tmpdir(), "ext-sort-"));
-		const pathBase = createExtDir(base, "base-ext");
-		const pathDependent = createExtDir(base, "dependent-ext", ["base-ext"]);
-
-		// Pass dependent first — sort should reorder
-		const result = sortExtensionPaths([pathDependent, pathBase]);
-		assert.deepEqual(result.sortedPaths, [pathBase, pathDependent]);
-		assert.equal(result.warnings.length, 0);
-	});
-
-	it("handles deep dependency chains", () => {
-		const base = mkdtempSync(join(tmpdir(), "ext-sort-"));
-		const pathA = createExtDir(base, "a");
-		const pathB = createExtDir(base, "b", ["a"]);
-		const pathC = createExtDir(base, "c", ["b"]);
-
-		const result = sortExtensionPaths([pathC, pathB, pathA]);
-		assert.deepEqual(result.sortedPaths, [pathA, pathB, pathC]);
-		assert.equal(result.warnings.length, 0);
-	});
-
-	it("warns about missing dependencies but still loads", () => {
-		const base = mkdtempSync(join(tmpdir(), "ext-sort-"));
-		const pathExt = createExtDir(base, "my-ext", ["nonexistent"]);
-
-		const result = sortExtensionPaths([pathExt]);
-		assert.equal(result.sortedPaths.length, 1);
-		assert.equal(result.sortedPaths[0], pathExt);
-		assert.equal(result.warnings.length, 1);
-		assert.match(result.warnings[0].message, /nonexistent.*not installed/);
-	});
-
-	it("warns about cycles but still loads both", () => {
-		const base = mkdtempSync(join(tmpdir(), "ext-sort-"));
-		const pathA = createExtDir(base, "cycle-a", ["cycle-b"]);
-		const pathB = createExtDir(base, "cycle-b", ["cycle-a"]);
-
-		const result = sortExtensionPaths([pathA, pathB]);
-		assert.equal(result.sortedPaths.length, 2);
-		assert.ok(result.warnings.length > 0);
-		assert.ok(result.warnings.some((w) => w.message.includes("cycle")));
-	});
-
-	it("silently ignores self-dependencies", () => {
-		const base = mkdtempSync(join(tmpdir(), "ext-sort-"));
-		const pathExt = createExtDir(base, "self-dep", ["self-dep"]);
-
-		const result = sortExtensionPaths([pathExt]);
-		assert.deepEqual(result.sortedPaths, [pathExt]);
-		assert.equal(result.warnings.length, 0);
-	});
-
-	it("prepends extensions without manifests", () => {
-		const base = mkdtempSync(join(tmpdir(), "ext-sort-"));
-		const noManifestDir = join(base, "no-manifest");
-		mkdirSync(noManifestDir, { recursive: true });
-		writeFileSync(join(noManifestDir, "index.ts"), `export default function() {}`);
-		const noManifestPath = join(noManifestDir, "index.ts");
-
-		const pathWithManifest = createExtDir(base, "with-manifest");
-
-		const result = sortExtensionPaths([pathWithManifest, noManifestPath]);
-		assert.equal(result.sortedPaths[0], noManifestPath);
-		assert.equal(result.sortedPaths[1], pathWithManifest);
-	});
-
-	it("handles non-array dependencies gracefully", () => {
-		const base = mkdtempSync(join(tmpdir(), "ext-sort-"));
-		const dir = join(base, "bad-deps");
-		mkdirSync(dir, { recursive: true });
-		writeFileSync(
-			join(dir, "extension-manifest.json"),
-			JSON.stringify({
-				id: "bad-deps",
-				name: "bad-deps",
-				version: "1.0.0",
-				tier: "bundled",
-				dependencies: { extensions: "not-an-array" },
-			}),
-		);
-		writeFileSync(join(dir, "index.ts"), `export default function() {}`);
-
-		const result = sortExtensionPaths([join(dir, "index.ts")]);
-		assert.equal(result.sortedPaths.length, 1);
-		assert.equal(result.warnings.length, 0);
-	});
-});