gloomberb 0.9.7 → 0.9.9

package/src/components/command-bar/pane-settings.ts

@@ -3,7 +3,7 @@ import type { PluginRegistry } from "../../plugins/registry";
 import { fuzzyFilter } from "../../utils/fuzzy-search";
 import type { ResultItem } from "./list/model";
 import type { CommandBarRoute, CommandBarWorkflowRoute } from "./workflow/types";
-import { summarizePaneSettingValue } from "./helpers";
+import { summarizePaneSettingValue } from "../pane-settings-dialog/value";
 
 type NotifyFn = (body: string, options?: { type?: "info" | "success" | "error" }) => void;
 

package/src/components/command-bar/pane-templates/items.ts

@@ -139,6 +139,14 @@ export function buildPaneTemplateItem(options: {
       .join(" ")
     : null;
   const arg = options.createOptions?.arg;
+  const searchText = [
+    options.template.keywords?.join(" ") || "",
+    displayLabel,
+    options.template.label,
+    options.template.paneId,
+    shortcutLabel || "",
+    pluginName || "",
+  ].filter(Boolean).join(" ");
 
   const action = () => {
     if (
@@ -163,7 +171,7 @@ export function buildPaneTemplateItem(options: {
     kind: "action",
     right: options.showShortcut ? options.template.shortcut?.prefix : undefined,
     shortcutQuery: options.template.shortcut?.prefix,
-    searchText: `${displayLabel} ${options.template.label} ${options.template.paneId} ${options.template.keywords?.join(" ") || ""} ${shortcutLabel || ""} ${pluginName || ""}`,
+    searchText,
     action,
   };
 }
@@ -187,7 +195,7 @@ export function buildPaneShortcutItems(options: {
     }));
 
   return options.filterQuery
-    ? fuzzyFilter(items, options.filterQuery, (item) => `${item.label} ${item.detail} ${item.searchText || ""} ${item.right || ""}`)
+    ? fuzzyFilter(items, options.filterQuery, (item) => `${item.label} ${item.searchText || ""} ${item.detail} ${item.right || ""}`)
     : items;
 }
 
@@ -201,6 +209,6 @@ export function buildNonShortcutPaneTemplateItems(options: {
     .map((template) => options.createItem(template, { category: "Panes" }));
 
   return options.filterQuery
-    ? fuzzyFilter(items, options.filterQuery, (item) => `${item.label} ${item.detail} ${item.searchText || ""} ${item.right || ""}`)
+    ? fuzzyFilter(items, options.filterQuery, (item) => `${item.label} ${item.searchText || ""} ${item.detail} ${item.right || ""}`)
     : items;
 }

package/src/components/command-bar/panel/runtime.ts

@@ -37,7 +37,6 @@ interface CommandBarPanelRuntimeOptions {
   applyThemePreview: (themeId: string | null) => void;
   cellHeightPx: number;
   cellWidthPx: number;
-  clearThemePreview: (themeId: string | null | undefined) => void;
   closeAll: (options?: { revertThemePreview?: boolean }) => void;
   commitTheme: (themeId: string) => void;
   committedThemeId: string;
@@ -92,7 +91,6 @@ export function useCommandBarPanelRuntime({
   applyThemePreview,
   cellHeightPx,
   cellWidthPx,
-  clearThemePreview,
   closeAll,
   commitTheme,
   committedThemeId,

package/src/components/command-bar/routes/root/results.ts

@@ -196,7 +196,7 @@ export function buildRootResultModel(options: RootResultModelOptions): RootResul
       ...tickerActionItems(),
       ...pluginCommandItems(),
     ];
-    items.push(...fuzzyFilter(allItems, rootQuery, (item) => `${item.label} ${item.detail} ${item.searchText || ""} ${item.right || ""}`));
+    items.push(...fuzzyFilter(allItems, rootQuery, (item) => `${item.label} ${item.searchText || ""} ${item.detail} ${item.right || ""}`));
   }
 
   return { items, initialIdx };

package/src/components/command-bar/routes/ticker-search/results.ts

@@ -24,17 +24,6 @@ export function normalizeCommandTickerSearchText(value: string): string {
   return value.trim().toUpperCase().replace(/[^A-Z0-9]+/g, "");
 }
 
-export function isLikelyPlainTickerSearch(query: string): boolean {
-  const trimmed = query.trim();
-  if (!trimmed || /\s/.test(trimmed)) return false;
-  if (!/^[A-Za-z0-9.^=\-/]+$/.test(trimmed)) return false;
-
-  const compact = normalizeCommandTickerSearchText(trimmed);
-  if (compact.length < 2) return false;
-  if (compact.length <= 6) return true;
-  return /[.^=\-/]/.test(trimmed) && compact.length <= 10;
-}
-
 function isExactTickerResultMatch(item: ResultItem, query: string): boolean {
   if (item.kind !== "ticker" && item.kind !== "search") return false;
   const normalizedQuery = normalizeCommandTickerSearchText(query);

package/src/components/command-bar/surface/index.test.tsx

@@ -6,6 +6,7 @@ import type { CommandDef, CommandShortcutArgContext, PaneTemplateCreateOptions,
 import {
   CommandBarHarness,
   createCommandBarTestControls,
+  emitKeypress,
   expectSingleBackControl,
   makeDataProvider,
   makeTicker,
@@ -26,6 +27,11 @@ type MutableCommandRegistry = {
   commands: ReadonlyMap<string, CommandDef>;
 };
 
+type MutablePaneRegistry = {
+  panes: ReadonlyMap<string, unknown>;
+  paneTemplates: ReadonlyMap<string, unknown>;
+};
+
 const DEFAULT_ALERT_OPTIONS = [
   { label: "Above", value: "above" },
   { label: "Below", value: "below" },
@@ -70,23 +76,11 @@ function registerAlertCommand(
   });
 }
 
-describe("CommandBar", () => {
-  test("renders the default layout with opencode-style chrome", async () => {
-    testSetup = await testRender(<CommandBarHarness query="" selectedTicker="AAPL" />, {
-      width: 80,
-      height: 24,
-    });
-
-    await testSetup.renderOnce();
-
-    const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("Commands");
-    expect(frame).not.toContain("Tickers");
-    expect(frame).toContain("Panes");
-    expect(frame).toContain("Portfolio");
-    expect(frame).toContain("Help");
-  });
+function mutablePaneRegistryMap(map: ReadonlyMap<string, unknown>): Map<string, unknown> {
+  return map as Map<string, unknown>;
+}
 
+describe("CommandBar", () => {
   test("keeps generic command filtering separate from ticker search", async () => {
     const searchQueries: string[] = [];
     testSetup = await testRender(<CommandBarHarness
@@ -129,6 +123,48 @@ describe("CommandBar", () => {
     expect(testSetup.captureCharFrame()).not.toContain("Commands");
   });
 
+  test("shows one account management result when searching profile", async () => {
+    const created: Array<{ templateId: string; options?: PaneTemplateCreateOptions }> = [];
+
+    testSetup = await testRender(<CommandBarHarness
+      query="profile"
+      live
+      configurePluginRegistry={(pluginRegistry) => {
+        const registry = pluginRegistry as MutablePaneRegistry;
+        mutablePaneRegistryMap(registry.panes).set("account-management", {
+          id: "account-management",
+          name: "Account Management",
+          component: () => null,
+          defaultPosition: "right",
+          defaultMode: "floating",
+        });
+        mutablePaneRegistryMap(registry.paneTemplates).set("account-management-pane", {
+          id: "account-management-pane",
+          paneId: "account-management",
+          label: "Account Management",
+          description: "Edit your Gloom Cloud profile, password, and public portfolio sharing settings",
+          keywords: ["account", "profile", "cloud", "acm", "password", "settings"],
+          shortcut: { prefix: "ACM" },
+        });
+        pluginRegistry.createPaneFromTemplateAsyncFn = async (templateId, options) => {
+          created.push({ templateId, options });
+        };
+      }}
+    />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+    const frame = await waitForFrameToContain("Account Management");
+    expect(frame).not.toMatch(/\n\s*Profile\s*(?:\n|$)/);
+    expect(frame.indexOf("Account Management")).toBeLessThan(frame.indexOf("Add Broker Account"));
+
+    await emitKeypress(testSetup, { name: "return", sequence: "\r" });
+
+    expect(created).toEqual([{ templateId: "account-management-pane", options: undefined }]);
+  });
+
   test("shows theme picker rows and commits a filtered light theme", async () => {
     testSetup = await testRender(<CommandBarHarness query="TH light" live />, {
       width: 80,

package/src/components/command-bar/surface/index.tsx

@@ -291,7 +291,6 @@ export function CommandBar({
     applyThemePreview,
     cellHeightPx,
     cellWidthPx,
-    clearThemePreview,
     closeAll,
     commitTheme,
     committedThemeId: state.config.theme,

package/src/components/command-bar/workflow/ops.ts

@@ -6,11 +6,22 @@ import { formatTickerListInput } from "../../../tickers/list";
 import { updatePaneInstance, setPaneSettings } from "../../../pane-settings";
 import { TICKER_RESEARCH_PANE_ID } from "../../../types/config";
 import { cleanPortfolioPaneSettings, resolvePortfolioPaneCollectionId } from "../../../plugins/builtin/portfolio-list/settings";
+import {
+  DEFAULT_RELATIONSHIP_SECOND_SYMBOL,
+  RELATIONSHIP_GRAPH_PANE_ID,
+  buildRelationshipGraphPaneTitle,
+} from "../../../plugins/builtin/correlation/relationship/model";
 import {
   buildComparisonChartPaneTitle,
   COMPARISON_CHART_PANE_ID,
   MIN_COMPARISON_CHART_SYMBOLS,
 } from "../../../plugins/builtin/comparison-chart";
+import {
+  FUNDAMENTAL_GRAPH_PANE_ID,
+  graphKindFromSettings,
+  graphShortcutForKind,
+  graphTemplateTitle,
+} from "../../../plugins/builtin/ticker-detail/data-panes/fundamental-graph/settings";
 import { buildQuoteMonitorPaneTitle } from "../../../plugins/builtin/ticker-detail/settings";
 import { getPaneTemplateDisplayLabel } from "../pane-templates/items";
 import {
@@ -54,6 +65,30 @@ interface ApplyPaneSettingDeps extends SharedWorkflowDeps {
   persistLayout: (layout: LayoutConfig, options?: { pushHistory?: boolean }) => void;
 }
 
+function updateTickerListPane(
+  layout: LayoutConfig,
+  targetId: string,
+  options: {
+    title: string;
+    symbols: readonly string[];
+    primarySymbol?: string;
+    settings?: Record<string, unknown>;
+  },
+): LayoutConfig {
+  const symbols = [...options.symbols];
+  return updatePaneInstance(layout, targetId, (instance) => ({
+    ...instance,
+    title: options.title,
+    ...(options.primarySymbol ? { binding: { kind: "fixed", symbol: options.primarySymbol } as PaneBinding } : {}),
+    settings: {
+      ...(instance.settings ?? {}),
+      symbols,
+      symbolsText: formatTickerListInput(symbols),
+      ...(options.settings ?? {}),
+    },
+  }));
+}
+
 async function resolvePaneTemplateOptions(
   template: PaneTemplateDef,
   options: PaneTemplateCreateOptions | undefined,
@@ -180,19 +215,50 @@ export async function applyPaneSettingFieldValue(
     const rawQuery = typeof value === "string" ? value.trim() : "";
     const symbols = await resolveTickerListInput(rawQuery, null, deps);
     const primarySymbol = symbols[0]!;
-    const symbolsText = formatTickerListInput(symbols);
-
-    const nextLayout = updatePaneInstance(state.config.layout, targetId, (instance) => ({
-      ...instance,
+    const nextLayout = updateTickerListPane(state.config.layout, targetId, {
       title: buildQuoteMonitorPaneTitle(symbols),
-      binding: { kind: "fixed", symbol: primarySymbol },
-      settings: {
-        ...(instance.settings ?? {}),
-        symbol: primarySymbol,
-        symbols,
-        symbolsText,
-      },
-    }));
+      symbols,
+      primarySymbol,
+      settings: { symbol: primarySymbol },
+    });
+    deps.persistLayout(nextLayout, { pushHistory: shouldPushHistory });
+    return;
+  }
+
+  if (descriptor.pane.paneId === FUNDAMENTAL_GRAPH_PANE_ID && field.key === "symbolsText") {
+    const rawInput = typeof value === "string" ? value : "";
+    const symbols = await resolveTickerListInput(
+      rawInput,
+      descriptor.context.activeCollectionId,
+      deps,
+    );
+    const primarySymbol = symbols[0]!;
+    const chartKind = graphKindFromSettings(descriptor.context.settings, "fundamental");
+    const nextLayout = updateTickerListPane(state.config.layout, targetId, {
+      title: graphTemplateTitle(graphShortcutForKind(chartKind), symbols),
+      symbols,
+      primarySymbol,
+    });
+    deps.persistLayout(nextLayout, { pushHistory: shouldPushHistory });
+    return;
+  }
+
+  if (descriptor.pane.paneId === RELATIONSHIP_GRAPH_PANE_ID && field.key === "symbolsText") {
+    const rawInput = typeof value === "string" ? value : "";
+    const symbols = await resolveTickerListInput(
+      rawInput,
+      descriptor.context.activeCollectionId,
+      deps,
+    );
+    if (symbols.length > 2) {
+      throw new Error("Enter one or two tickers.");
+    }
+    const pair: [string, string] = [symbols[0]!, symbols[1] ?? DEFAULT_RELATIONSHIP_SECOND_SYMBOL];
+    const nextLayout = updateTickerListPane(state.config.layout, targetId, {
+      title: buildRelationshipGraphPaneTitle(pair),
+      symbols: pair,
+      primarySymbol: pair[0],
+    });
     deps.persistLayout(nextLayout, { pushHistory: shouldPushHistory });
     return;
   }
@@ -207,15 +273,10 @@ export async function applyPaneSettingFieldValue(
     if (symbols.length < MIN_COMPARISON_CHART_SYMBOLS) {
       throw new Error(`Enter at least ${MIN_COMPARISON_CHART_SYMBOLS} tickers.`);
     }
-    const nextLayout = updatePaneInstance(state.config.layout, targetId, (instance) => ({
-      ...instance,
+    const nextLayout = updateTickerListPane(state.config.layout, targetId, {
       title: buildComparisonChartPaneTitle(symbols),
-      settings: {
-        ...(instance.settings ?? {}),
-        symbols,
-        symbolsText: formatTickerListInput(symbols),
-      },
-    }));
+      symbols,
+    });
     deps.persistLayout(nextLayout, { pushHistory: shouldPushHistory });
     return;
   }

package/src/components/feed-data-table/stack-view.test.tsx

@@ -1,148 +1,54 @@
-import { afterEach, describe, expect, test } from "bun:test";
-import { act, useState } from "react";
+import { afterEach, expect, test } from "bun:test";
+import { act } from "react";
 import { testRender } from "../../renderers/opentui/test-utils";
 import { AppContext, PaneInstanceProvider, createInitialState } from "../../state/app/context";
 import { createDefaultConfig } from "../../types/config";
-import {
-  FeedDataTableStackView,
-  type FeedDataTableItem,
-} from "./stack-view";
 import { Box, Text } from "../../ui";
+import { FeedDataTableStackView } from "./stack-view";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
-let rootKeyHits = 0;
-
-const items: FeedDataTableItem[] = [
-  {
-    id: "1",
-    eyebrow: "Reuters",
-    title:
-      "Long headline with enough words to prove the table truncates cleanly",
-    timestamp: new Date("2024-08-01T12:00:00Z"),
-    preview: "Preview text with a little more color.",
-    detailTitle: "Long headline with enough words",
-    detailMeta: ["Reuters", "Published Aug 1, 2024"],
-    detailBody:
-      "This body should stay readable when the pane opens the detail page.",
-    detailNote: "https://example.com/story",
-  },
-  {
-    id: "2",
-    eyebrow: "10-Q",
-    title: "10-Q filing",
-    timestamp: new Date("2024-08-02T12:00:00Z"),
-    preview: "Quarterly report",
-    detailTitle: "10-Q filing",
-    detailMeta: ["Filed Aug 2, 2024"],
-    detailBody: "Quarterly report details.",
-  },
-];
 
 afterEach(async () => {
-  if (testSetup) {
-    await act(async () => {
-      testSetup!.renderer.destroy();
-    });
-    testSetup = undefined;
-  }
-  rootKeyHits = 0;
+  await act(async () => testSetup?.renderer.destroy());
+  testSetup = undefined;
 });
 
-function Harness({
-  width,
-  height,
-  withRootControls = false,
-}: {
-  width: number;
-  height: number;
-  withRootControls?: boolean;
-}) {
-  const [selectedIdx, setSelectedIdx] = useState(0);
-
-  const state = createInitialState(
-    createDefaultConfig("/tmp/gloomberb-detail-data-table-test"),
-  );
-
-  return (
-    <AppContext value={{ state, dispatch: () => {} }}>
-      <PaneInstanceProvider paneId="portfolio-list:main">
-        <FeedDataTableStackView
-          width={width}
-          height={height}
-          focused
-          items={items}
-          selectedIdx={selectedIdx}
-          onSelect={setSelectedIdx}
-          rootBefore={withRootControls ? (
-            <Box height={1}>
-              <Text>Feed controls</Text>
-            </Box>
-          ) : undefined}
-          onRootKeyDown={withRootControls ? (event) => {
-            if (event.name !== "f") return false;
-            rootKeyHits += 1;
-            return true;
-          } : undefined}
-          sourceLabel="Source"
-          titleLabel="Headline"
-        />
-      </PaneInstanceProvider>
-    </AppContext>
-  );
-}
-
-async function renderSettled() {
+test("delegates root key handling", async () => {
+  let keyHits = 0;
+  const state = createInitialState(createDefaultConfig("/tmp/gloomberb-feed-table-test"));
   await act(async () => {
-    await testSetup!.renderOnce();
-    await testSetup!.renderOnce();
+    testSetup = await testRender(
+      <AppContext value={{ state, dispatch: () => {} }}>
+        <PaneInstanceProvider paneId="portfolio-list:main">
+          <FeedDataTableStackView
+            width={80}
+            height={12}
+            focused
+            items={[]}
+            selectedIdx={0}
+            onSelect={() => {}}
+            rootBefore={<Box height={1}><Text>Feed controls</Text></Box>}
+            onRootKeyDown={(event) => {
+              if (event.name !== "f") return false;
+              keyHits += 1;
+              return true;
+            }}
+          />
+        </PaneInstanceProvider>
+      </AppContext>,
+      { width: 80, height: 12 },
+    );
+    await testSetup.renderOnce();
   });
-}
 
-async function emitKeypress(event: { name?: string; sequence?: string }) {
   await act(async () => {
-    testSetup!.renderer.keyInput.emit("keypress", {
-      ctrl: false,
-      meta: false,
-      option: false,
-      shift: false,
-      eventType: "press",
-      repeated: false,
-      preventDefault: () => {},
-      stopPropagation: () => {},
-      ...event,
-    } as any);
-    await testSetup!.renderOnce();
-  });
-}
-
-describe("FeedDataTableStackView", () => {
-  test("renders a DataTable list by default", async () => {
-    testSetup = await testRender(<Harness width={90} height={16} />, {
-      width: 90,
-      height: 16,
+    (testSetup!.renderer.keyInput as any).emit("keypress", {
+      name: "f", sequence: "f", eventType: "press",
+      ctrl: false, meta: false, option: false, shift: false, repeated: false,
+      preventDefault() {}, stopPropagation() {},
     });
-
-    await renderSettled();
-    const frame = testSetup.captureCharFrame();
-
-    expect(frame).toContain("Time");
-    expect(frame).toContain("Source");
-    expect(frame).toContain("Headline");
-    expect(frame).toContain("10-Q filing");
-    expect(frame).not.toContain("j/k move");
-    expect(frame).not.toContain("Quarterly report details.");
+    await testSetup!.renderOnce();
   });
 
-  test("renders root controls and delegates root key handling", async () => {
-    testSetup = await testRender(<Harness width={90} height={16} withRootControls />, {
-      width: 90,
-      height: 16,
-    });
-
-    await renderSettled();
-    expect(testSetup.captureCharFrame()).toContain("Feed controls");
-
-    await emitKeypress({ name: "f", sequence: "f" });
-    expect(rootKeyHits).toBe(1);
-  });
+  expect(keyHits).toBe(1);
 });

package/src/components/feed-data-table/stack-view.tsx

@@ -21,7 +21,6 @@ export interface FeedDataTableItem {
   eyebrow?: string;
   title: string;
   timestamp?: Date | string | null;
-  preview?: string | null;
   detailTitle?: string;
   detailMeta?: string[];
   detailBody?: string | null;

package/src/components/index.ts

@@ -25,6 +25,7 @@ export { PaneFooterScope, usePaneFooter } from "./layout/pane/footer";
 export type { PaneFooterSegment, PaneHint } from "./layout/pane/footer";
 export { useExternalLinkFooter } from "./use-external-link-footer";
 export { Button } from "./ui/button";
+export { Checkbox } from "./ui/checkbox";
 export { ConfirmDialog } from "./ui/confirm-dialog";
 export { ChoiceDialog } from "./ui/choice-dialog";
 export type { ChoiceDialogChoice } from "./ui/choice-dialog";