gloomberb 0.9.7 → 0.9.9

package/src/market-data/quotes/resolution.test.ts

@@ -68,6 +68,191 @@ describe("quote-resolution", () => {
     expect(quote?.provenance?.session?.providerId).toBe("yahoo");
   });
 
+  test("uses provider previous close with the live broker price for daily change", () => {
+    const now = Date.parse("2026-07-06T14:05:00Z");
+    const contributions: QuoteContributionMap = {
+      ibkr: {
+        symbol: "VICR",
+        providerId: "ibkr",
+        dataSource: "live",
+        price: 299.8,
+        currency: "USD",
+        change: -80.3,
+        changePercent: -21.12,
+        previousClose: 380.1,
+        lastUpdated: Date.parse("2026-07-06T14:04:58Z"),
+        receivedAt: Date.parse("2026-07-06T14:04:59Z"),
+        listingExchangeName: "NASDAQ",
+        routingExchangeName: "SMART",
+        sessionConfidence: "unknown",
+      },
+      yahoo: {
+        symbol: "VICR",
+        providerId: "yahoo",
+        dataSource: "delayed",
+        price: 299.74,
+        currency: "USD",
+        change: 16.79,
+        changePercent: 5.93,
+        previousClose: 282.95,
+        lastUpdated: Date.parse("2026-07-06T14:04:00Z"),
+        listingExchangeName: "NMS",
+        marketState: "REGULAR",
+        sessionConfidence: "derived",
+      },
+    };
+
+    const quote = resolveCanonicalQuote(contributions, now).quote;
+
+    expect(quote?.providerId).toBe("ibkr");
+    expect(quote?.price).toBe(299.8);
+    expect(quote?.previousClose).toBe(282.95);
+    expect(quote?.change).toBeCloseTo(16.85, 10);
+    expect(quote?.changePercent).toBeCloseTo((16.85 / 282.95) * 100, 10);
+    expect(quote?.provenance?.price?.providerId).toBe("ibkr");
+    expect(quote?.provenance?.fields?.previousClose?.providerId).toBe("yahoo");
+  });
+
+  test("prefers fresher/provider-ranked non-live price candidates", () => {
+    const now = Date.parse("2026-07-07T11:25:00Z");
+    const cases: Array<{
+      contributions: QuoteContributionMap;
+      expectedPrice: number;
+      expectedProvider: string;
+      expectedChangePercent?: number;
+      expectedRoute?: string;
+    }> = [
+      {
+        contributions: {
+          ibkr: {
+            symbol: "LPK",
+            providerId: "ibkr",
+            dataSource: "delayed",
+            price: 17.75,
+            currency: "EUR",
+            change: -1.85,
+            changePercent: -9.44,
+            previousClose: 19.6,
+            lastUpdated: Date.parse("2026-07-07T11:02:00Z"),
+            receivedAt: Date.parse("2026-07-07T11:02:01Z"),
+            listingExchangeName: "IBIS",
+            routingExchangeName: "SMART",
+            sessionConfidence: "unknown",
+          },
+          yahoo: {
+            symbol: "LPK.DE",
+            providerId: "yahoo",
+            dataSource: "delayed",
+            price: 17.85,
+            currency: "EUR",
+            change: -1.75,
+            changePercent: -8.93,
+            previousClose: 19.6,
+            lastUpdated: Date.parse("2026-07-07T11:24:00Z"),
+            listingExchangeName: "GER",
+            marketState: "REGULAR",
+            sessionConfidence: "derived",
+          },
+        },
+        expectedProvider: "yahoo",
+        expectedPrice: 17.85,
+        expectedChangePercent: ((17.85 - 19.6) / 19.6) * 100,
+        expectedRoute: "SMART",
+      },
+      {
+        contributions: {
+          "gloomberb-cloud": {
+            symbol: "3HNX",
+            providerId: "gloomberb-cloud",
+            dataSource: "delayed",
+            price: 5.81,
+            currency: "GBP",
+            change: -1.58,
+            changePercent: -21.42,
+            previousClose: 7.39,
+            lastUpdated: Date.parse("2026-07-07T11:18:00Z"),
+            listingExchangeName: "LSE",
+            marketState: "REGULAR",
+            sessionConfidence: "derived",
+          },
+          yahoo: {
+            symbol: "3HNX.L",
+            providerId: "yahoo",
+            dataSource: "delayed",
+            price: 5.9775,
+            currency: "GBP",
+            change: -1.4125,
+            changePercent: -19.09,
+            previousClose: 7.39,
+            lastUpdated: Date.parse("2026-07-07T11:24:00Z"),
+            listingExchangeName: "LSE",
+            marketState: "REGULAR",
+            sessionConfidence: "derived",
+          },
+        },
+        expectedProvider: "yahoo",
+        expectedPrice: 5.9775,
+      },
+    ];
+
+    for (const scenario of cases) {
+      const quote = resolveCanonicalQuote(scenario.contributions, now).quote;
+      expect(quote?.providerId).toBe(scenario.expectedProvider);
+      expect(quote?.price).toBe(scenario.expectedPrice);
+      expect(quote?.provenance?.price?.providerId).toBe(scenario.expectedProvider);
+      if (scenario.expectedChangePercent != null) {
+        expect(quote?.changePercent).toBeCloseTo(scenario.expectedChangePercent, 10);
+      }
+      if (scenario.expectedRoute) {
+        expect(quote?.routingExchangeName).toBe(scenario.expectedRoute);
+      }
+    }
+  });
+
+  test("prefers yahoo day reference fields over stale cloud previous close data", () => {
+    const now = Date.parse("2026-07-06T15:45:00Z");
+    const contributions: QuoteContributionMap = {
+      "gloomberb-cloud": {
+        symbol: "VICR",
+        providerId: "gloomberb-cloud",
+        dataSource: "delayed",
+        price: 299.8,
+        currency: "USD",
+        change: -80.27,
+        changePercent: -21.12,
+        previousClose: 380.07,
+        lastUpdated: Date.parse("2026-07-06T15:44:00Z"),
+        listingExchangeName: "NASDAQ",
+        marketState: "REGULAR",
+        sessionConfidence: "derived",
+      },
+      yahoo: {
+        symbol: "VICR",
+        providerId: "yahoo",
+        dataSource: "delayed",
+        price: 297.9,
+        currency: "USD",
+        change: 14.95,
+        changePercent: 5.28,
+        previousClose: 282.95,
+        lastUpdated: Date.parse("2026-07-06T15:41:00Z"),
+        listingExchangeName: "NMS",
+        marketState: "REGULAR",
+        sessionConfidence: "derived",
+      },
+    };
+
+    const quote = resolveCanonicalQuote(contributions, now).quote;
+
+    expect(quote?.providerId).toBe("gloomberb-cloud");
+    expect(quote?.price).toBe(299.8);
+    expect(quote?.previousClose).toBe(282.95);
+    expect(quote?.change).toBeCloseTo(16.85, 10);
+    expect(quote?.changePercent).toBeCloseTo((16.85 / 282.95) * 100, 10);
+    expect(quote?.provenance?.price?.providerId).toBe("gloomberb-cloud");
+    expect(quote?.provenance?.fields?.previousClose?.providerId).toBe("yahoo");
+  });
+
   test("prefers cloud session data over yahoo when confidence is tied", () => {
     const now = Date.parse("2026-04-08T11:00:00Z");
     const contributions: QuoteContributionMap = {

package/src/market-data/quotes/resolution.ts

@@ -31,9 +31,6 @@ const PRICE_FIELD_KEYS = [
   "symbol",
   "price",
   "currency",
-  "change",
-  "changePercent",
-  "previousClose",
   "bid",
   "ask",
   "bidSize",
@@ -88,12 +85,39 @@ function providerKindRank(providerId?: string): number {
   }
 }
 
+function dailyReferenceRank(providerId?: string): number {
+  switch (providerId) {
+    case "yahoo":
+      return 0;
+    case "gloomberb-cloud":
+      return 1;
+    case "ibkr":
+      return 2;
+    default:
+      return 3;
+  }
+}
+
 function priceRank(quote: QuoteContribution): number {
   if (quote.providerId === "ibkr" && quote.dataSource === "live") return 0;
-  if (quote.providerId === "ibkr") return 1;
-  if (quote.providerId === "gloomberb-cloud") return 2;
-  if (quote.providerId === "yahoo") return 3;
-  return 4;
+  return 1;
+}
+
+function priceProviderTieRank(providerId?: string): number {
+  switch (providerId) {
+    case "gloomberb-cloud":
+      return 0;
+    case "yahoo":
+      return 1;
+    case "ibkr":
+      return 2;
+    default:
+      return 3;
+  }
+}
+
+function quoteUpdateTime(quote: QuoteContribution): number {
+  return quote.lastUpdated ?? quote.receivedAt ?? 0;
 }
 
 function sessionConfidenceRank(confidence?: SessionConfidence): number {
@@ -123,7 +147,7 @@ function assignField(
   quote: QuoteContribution | undefined,
 ): void {
   if (!quote) return;
-  const value = (quote as Record<string, unknown>)[field];
+  const value = (quote as unknown as Record<string, unknown>)[field];
   if (value === undefined) return;
   (target as Record<string, unknown>)[field] = value;
   provenance.fields ??= {};
@@ -137,13 +161,68 @@ function pickField(
   candidates: QuoteContribution[],
 ): QuoteContribution | undefined {
   for (const candidate of candidates) {
-    if ((candidate as Record<string, unknown>)[field] === undefined) continue;
+    if ((candidate as unknown as Record<string, unknown>)[field] === undefined) continue;
     assignField(target, provenance, field, candidate);
     return candidate;
   }
   return undefined;
 }
 
+function finitePositiveNumber(value: unknown): value is number {
+  return typeof value === "number" && Number.isFinite(value) && value > 0;
+}
+
+function buildDailyReferenceCandidates(
+  candidates: QuoteContribution[],
+  priceProvider: QuoteContribution | undefined,
+): QuoteContribution[] {
+  return [...candidates]
+    .filter((quote) => finitePositiveNumber(quote.previousClose))
+    .sort((left, right) => {
+      if (priceProvider) {
+        const leftMismatch = hasLikelyQuoteUnitMismatch(priceProvider, left) ? 1 : 0;
+        const rightMismatch = hasLikelyQuoteUnitMismatch(priceProvider, right) ? 1 : 0;
+        if (leftMismatch !== rightMismatch) return leftMismatch - rightMismatch;
+      }
+      const providerDelta = dailyReferenceRank(left.providerId) - dailyReferenceRank(right.providerId);
+      if (providerDelta !== 0) return providerDelta;
+      return (right.lastUpdated ?? 0) - (left.lastUpdated ?? 0);
+    });
+}
+
+function assignDailyChangeFields(
+  target: Partial<Quote>,
+  provenance: QuoteProvenance,
+  priceProvider: QuoteContribution | undefined,
+  candidates: QuoteContribution[],
+): void {
+  const referenceProvider = buildDailyReferenceCandidates(candidates, priceProvider)[0];
+  if (!referenceProvider) {
+    pickField(target, provenance, "previousClose", candidates);
+    pickField(target, provenance, "change", candidates);
+    pickField(target, provenance, "changePercent", candidates);
+    return;
+  }
+
+  assignField(target, provenance, "previousClose", referenceProvider);
+  const price = target.price;
+  const previousClose = target.previousClose;
+  if (!finitePositiveNumber(price) || !finitePositiveNumber(previousClose)) {
+    pickField(target, provenance, "change", candidates);
+    pickField(target, provenance, "changePercent", candidates);
+    return;
+  }
+
+  target.change = price - previousClose;
+  target.changePercent = (target.change / previousClose) * 100;
+  provenance.fields ??= {};
+  const referenceProvenance = toProvenance(referenceProvider);
+  if (referenceProvenance) {
+    provenance.fields.change = referenceProvenance;
+    provenance.fields.changePercent = referenceProvenance;
+  }
+}
+
 function buildAcceptedPriceCandidates(contributions: QuoteContribution[]): {
   accepted: QuoteContribution[];
   rejectedProviders: string[];
@@ -153,7 +232,13 @@ function buildAcceptedPriceCandidates(contributions: QuoteContribution[]): {
     .sort((left, right) => {
       const rankDelta = priceRank(left) - priceRank(right);
       if (rankDelta !== 0) return rankDelta;
-      return (right.lastUpdated ?? 0) - (left.lastUpdated ?? 0);
+      if (priceRank(left) > 0) {
+        const updateDelta = quoteUpdateTime(right) - quoteUpdateTime(left);
+        if (updateDelta !== 0) return updateDelta;
+      }
+      const providerDelta = priceProviderTieRank(left.providerId) - priceProviderTieRank(right.providerId);
+      if (providerDelta !== 0) return providerDelta;
+      return quoteUpdateTime(right) - quoteUpdateTime(left);
     });
 
   const accepted: QuoteContribution[] = [];
@@ -290,6 +375,7 @@ export function resolveCanonicalQuote(
     if (field === "price") continue;
     pickField(resolved, provenance, field, acceptedPriceCandidates);
   }
+  assignDailyChangeFields(resolved, provenance, priceProvider, acceptedPriceCandidates);
   provenance.price = toProvenance(priceProvider);
 
   const sessionProvider = sessionCandidates[0];

package/src/market-data/request-types.test.ts

@@ -1,6 +1,6 @@
 import { describe, expect, test } from "bun:test";
 import type { TickerRecord } from "../types/ticker";
-import { quoteSubscriptionTargetFromTicker } from "./request-types";
+import { instrumentFromTicker, quoteSubscriptionTargetFromTicker } from "./request-types";
 
 function makeTicker(overrides: Partial<TickerRecord["metadata"]> = {}): TickerRecord {
   return {
@@ -21,6 +21,66 @@ function makeTicker(overrides: Partial<TickerRecord["metadata"]> = {}): TickerRe
 }
 
 describe("quoteSubscriptionTargetFromTicker", () => {
+  test("selects the broker contract that belongs to the active portfolio", () => {
+    const ticker = makeTicker({
+      ticker: "VICR",
+      name: "Vicor",
+      portfolios: [
+        "broker:ibkr-live:DU111",
+        "broker:ibkr-coldstart:DU222",
+      ],
+      positions: [
+        {
+          portfolio: "broker:ibkr-live:DU111",
+          shares: 170,
+          avgCost: 198,
+          currency: "USD",
+          broker: "ibkr",
+          brokerInstanceId: "ibkr-live",
+          brokerContractId: 275759,
+        },
+        {
+          portfolio: "broker:ibkr-coldstart:DU222",
+          shares: 350,
+          avgCost: 290,
+          currency: "USD",
+          broker: "ibkr",
+          brokerInstanceId: "ibkr-coldstart",
+          brokerContractId: 275759,
+        },
+      ],
+      broker_contracts: [
+        {
+          brokerId: "ibkr",
+          brokerInstanceId: "ibkr-live",
+          conId: 275759,
+          symbol: "VICR",
+          localSymbol: "VICR",
+          exchange: "NASDAQ",
+          currency: "USD",
+          secType: "STK",
+        },
+        {
+          brokerId: "ibkr",
+          brokerInstanceId: "ibkr-coldstart",
+          conId: 275759,
+          symbol: "VICR",
+          localSymbol: "VICR",
+          exchange: "NASDAQ",
+          currency: "USD",
+          secType: "STK",
+        },
+      ],
+    });
+
+    expect(instrumentFromTicker(ticker, "VICR", { portfolioId: "broker:ibkr-coldstart:DU222" })).toMatchObject({
+      symbol: "VICR",
+      brokerId: "ibkr",
+      brokerInstanceId: "ibkr-coldstart",
+      instrument: ticker.metadata.broker_contracts?.[1],
+    });
+  });
+
   test("preserves broker contract context for streaming targets", () => {
     const ticker = makeTicker({
       broker_contracts: [{

package/src/market-data/request-types.ts

@@ -12,6 +12,10 @@ export interface InstrumentRef {
   instrument?: BrokerContractRef | null;
 }
 
+export interface TickerInstrumentOptions {
+  portfolioId?: string | null;
+}
+
 type ChartGranularity = "range" | "detail" | "resolution";
 
 export interface ChartRequest {
@@ -24,11 +28,6 @@ export interface ChartRequest {
   barSize?: string;
 }
 
-export interface NewsRequest {
-  instrument: InstrumentRef;
-  count?: number;
-}
-
 export interface OptionsRequest {
   instrument: InstrumentRef;
   expirationDate?: number;
@@ -39,10 +38,44 @@ export interface SecFilingsRequest {
   count?: number;
 }
 
-export function instrumentFromTicker(ticker: TickerRecord | null | undefined, fallbackSymbol?: string | null): InstrumentRef | null {
+function brokerContractForTicker(
+  ticker: TickerRecord | null | undefined,
+  options: TickerInstrumentOptions = {},
+): BrokerContractRef | null {
+  const contracts = ticker?.metadata.broker_contracts ?? [];
+  if (contracts.length === 0) return null;
+
+  const portfolioId = options.portfolioId;
+  if (portfolioId) {
+    const positions = ticker?.metadata.positions.filter((position) => position.portfolio === portfolioId) ?? [];
+    for (const position of positions) {
+      const matchingContract = contracts.find((contract) => (
+        (position.brokerContractId == null || contract.conId === position.brokerContractId)
+        && (!position.brokerInstanceId || contract.brokerInstanceId === position.brokerInstanceId)
+        && (!position.broker || contract.brokerId === position.broker)
+      ));
+      if (matchingContract) return matchingContract;
+    }
+    for (const position of positions) {
+      const matchingContract = contracts.find((contract) => (
+        (!position.brokerInstanceId || contract.brokerInstanceId === position.brokerInstanceId)
+        && (!position.broker || contract.brokerId === position.broker)
+      ));
+      if (matchingContract) return matchingContract;
+    }
+  }
+
+  return contracts[0] ?? null;
+}
+
+export function instrumentFromTicker(
+  ticker: TickerRecord | null | undefined,
+  fallbackSymbol?: string | null,
+  options: TickerInstrumentOptions = {},
+): InstrumentRef | null {
   const symbol = ticker?.metadata.ticker ?? fallbackSymbol ?? null;
   if (!symbol) return null;
-  const instrument = ticker?.metadata.broker_contracts?.[0] ?? null;
+  const instrument = brokerContractForTicker(ticker, options);
   return {
     symbol,
     exchange: ticker?.metadata.exchange ?? "",
@@ -56,8 +89,9 @@ export function quoteSubscriptionTargetFromTicker(
   ticker: TickerRecord | null | undefined,
   fallbackSymbol?: string | null,
   route: QuoteSubscriptionTarget["route"] = "auto",
+  options: TickerInstrumentOptions = {},
 ): QuoteSubscriptionTarget | null {
-  const instrument = instrumentFromTicker(ticker, fallbackSymbol);
+  const instrument = instrumentFromTicker(ticker, fallbackSymbol, options);
   return quoteSubscriptionTargetFromInstrument(instrument, route);
 }
 

package/src/market-data/result-types.ts

@@ -19,17 +19,6 @@ export interface ProviderAttempt {
   message?: string;
 }
 
-interface ProviderResult<T> {
-  status: ProviderStatus;
-  data: T | null;
-  providerId: string;
-  latencyMs: number;
-  completeness: "full" | "partial";
-  reasonCode?: ProviderReasonCode;
-  asOf?: number;
-  staleAt?: number;
-}
-
 type QueryPhase = "idle" | "loading" | "ready" | "refreshing" | "error";
 
 export interface QueryEntry<T> {

package/src/market-data/selectors.ts

@@ -1,6 +1,6 @@
 import type { MarketDataRequestContext } from "../types/data-provider";
 import type { Quote, TickerFinancials } from "../types/financials";
-import type { InstrumentRef, NewsRequest, OptionsRequest, SecFilingsRequest, ChartRequest } from "./request-types";
+import type { InstrumentRef, OptionsRequest, SecFilingsRequest, ChartRequest } from "./request-types";
 import type { QueryEntry } from "./result-types";
 import { hasLikelyQuoteUnitMismatch } from "../utils/currency-units";
 import { normalizePriceHistory } from "../utils/price-history";
@@ -61,10 +61,6 @@ export function buildChartKey(request: ChartRequest): string {
   ].join(":");
 }
 
-export function buildNewsKey(request: NewsRequest): string {
-  return `news:${buildInstrumentKey(request.instrument)}:${request.count ?? 50}`;
-}
-
 export function buildOptionsKey(request: OptionsRequest): string {
   return `options:${buildInstrumentKey(request.instrument)}:${request.expirationDate ?? "default"}`;
 }

package/src/news/aggregator.ts

@@ -58,7 +58,11 @@ export class NewsService {
     if (this.pollTimer !== null) {
       void this.pollActiveQueries();
     }
-    return () => this.unregister(source.id);
+    return () => {
+      if (this.sources.get(source.id) === source) {
+        this.unregister(source.id);
+      }
+    };
   }
 
   unregister(sourceId: string): void {

package/src/pane-settings.test.ts

@@ -3,24 +3,6 @@ import { cloneLayout, createDefaultConfig, createPaneInstance, DEFAULT_PORTFOLIO
 import { deletePaneSetting, getPaneSettingValue, setPaneSetting } from "./pane-settings";
 
 describe("pane settings helpers", () => {
-  test("seeds built-in default panes with persisted settings", () => {
-    const config = createDefaultConfig("/tmp/gloomberb-pane-settings");
-    const portfolioPane = config.layout.instances.find((instance) => instance.instanceId === "portfolio-list:main");
-    const detailPane = config.layout.instances.find((instance) => instance.instanceId === "ticker-detail:main");
-
-    expect(portfolioPane?.settings).toMatchObject({
-      collectionScope: "all",
-      viewMode: "table",
-    });
-    expect(portfolioPane?.settings?.columnIds).toEqual(DEFAULT_PORTFOLIO_COLUMN_IDS);
-    expect(detailPane?.settings).toEqual({
-      chartRangePreset: "5Y",
-      chartResolution: "auto",
-      hideTabs: false,
-      lockedTabId: "overview",
-    });
-  });
-
   test("cloneLayout deep-clones pane settings", () => {
     const layout = cloneLayout(createDefaultConfig("/tmp/gloomberb-pane-settings").layout);
     const cloned = cloneLayout(layout);

package/src/plugins/builtin/account-management/footer.ts

@@ -8,22 +8,19 @@ export function useAccountManagementFooter({
   draft,
   hasSession,
   message,
-  openPasswordDialog,
   profile,
   saveProfile,
 }: {
-  busy: "profile" | "password" | null;
+  busy: "profile" | "password" | "alerts" | "billing" | "delete" | null;
   draft: AccountDraft;
   hasSession: boolean;
   message: { tone: "info" | "success" | "error"; text: string } | null;
-  openPasswordDialog: () => void;
   profile: AccountProfile | null;
   saveProfile: () => Promise<void>;
 }) {
   const footerHints = useMemo<PaneHint[]>(() => [
     { id: "save", key: "Ctrl+S", label: "save", onPress: () => { void saveProfile(); }, disabled: !!busy || !hasSession },
-    { id: "password", key: "p", label: "assword", onPress: openPasswordDialog, disabled: !!busy || !hasSession },
-  ], [busy, hasSession, openPasswordDialog, saveProfile]);
+  ], [busy, hasSession, saveProfile]);
 
   usePaneFooter("account-management", () => ({
     info: [