gloomberb 0.9.7 → 0.9.9

package/src/plugins/builtin/help/index.tsx

@@ -31,7 +31,7 @@ const HELP_TABS = [
 type HelpTabId = typeof HELP_TABS[number]["value"];
 const GLOOMBERB_ISSUES_URL = "https://github.com/vincelwt/gloomberb/issues";
 
-export function HelpPane({ focused, width, height }: PaneProps) {
+function HelpPane({ focused, width, height }: PaneProps) {
   const registry = getSharedRegistry();
   const { openCommandBar, showPane } = usePluginAppActions();
   const [activeTabId, setActiveTabId] = useState<HelpTabId>("basics");
@@ -381,7 +381,7 @@ export function HelpPane({ focused, width, height }: PaneProps) {
     <Box flexDirection="column" width={width} height={height}>
       <Box width={width} height={1} flexShrink={0}>
         <Tabs
-          tabs={HELP_TABS}
+          tabs={[...HELP_TABS]}
           activeValue={activeTabId}
           onSelect={(value) => setActiveTabId(value as HelpTabId)}
           focused={focused}

package/src/plugins/builtin/holders/pane.tsx

@@ -127,11 +127,6 @@ export function HoldersView({ focused, width, height }: { focused: boolean; widt
     };
   }, [sortedRows]);
 
-  const selectIndex = useCallback((index: number) => {
-    const row = sortedRows[index];
-    if (row) setSelectedId(row.id);
-  }, [sortedRows]);
-
   const selectedRow = activeIdx >= 0 ? sortedRows[activeIdx] ?? null : null;
   const selectedFundMatch = selectedRow ? fundMatches.get(selectedRow.id) ?? null : null;
 

package/src/plugins/builtin/insider/index.tsx

@@ -14,6 +14,7 @@ import { FeedDataTableStackView, Spinner, useExternalLinkFooter, type FeedDataTa
 import { usePluginPaneState } from "../../runtime";
 import { isUsEquityTicker } from "../../../utils/sec";
 import { formatCompact, formatCurrency } from "../../../utils/format";
+import { truncateWithEllipsis as truncateText } from "../../../utils/text-wrap";
 import { parseForm4Xml, type InsiderTransaction } from "./insider-data";
 import { createTickerSurfacePaneTemplate } from "../shared/ticker-surface";
 import {
@@ -61,13 +62,6 @@ function buildSummary(parsed: ParsedFiling[]): string {
   return parts.join("  |  ");
 }
 
-function truncateText(text: string, width: number): string {
-  if (width <= 0) return "";
-  if (text.length <= width) return text;
-  if (width <= 3) return text.slice(0, width);
-  return `${text.slice(0, width - 3)}...`;
-}
-
 function toFeedItems(parsed: ParsedFiling[]): FeedDataTableItem[] {
   return parsed.map(({ filing, transaction, isLoading }) => {
     const filingMeta = [
@@ -95,7 +89,6 @@ function toFeedItems(parsed: ParsedFiling[]): FeedDataTableItem[] {
       eyebrow: transaction.reportedName,
       title: buildInsiderTransactionTitle(transaction),
       timestamp: transaction.filingDate,
-      preview: transaction.title || undefined,
       detailTitle: transaction.reportedName,
       detailMeta: [
         ...(transaction.title ? [transaction.title] : []),

package/src/plugins/builtin/kelly-sizer/index.test.tsx

@@ -2,7 +2,6 @@ import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { act } from "react";
 import { testRender } from "../../../renderers/opentui/test-utils";
 import { setSharedMarketDataCoordinator } from "../../../market-data/coordinator";
-import type { TickerRecord } from "../../../types/ticker";
 import { KellySizerHarness, createFinancials, createSizerConfig, createTicker } from "./test-support";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
@@ -36,31 +35,6 @@ afterEach(async () => {
 });
 
 describe("KellySizerPane", () => {
-  test("renders binary sizing context, result, and curve", async () => {
-    await renderPane();
-    await flushFrame();
-
-    const frame = testSetup!.captureCharFrame();
-    expect(frame).toContain("AAPL · Main Portfolio");
-    expect(frame).toContain("Bankroll");
-    expect(frame).toContain("100000");
-    expect(frame).toContain("Win p");
-    expect(frame).toContain("Full Kelly");
-    expect(frame).toContain("Clipped");
-    expect(frame).toContain("Target val");
-    expect(frame).toContain("Current %");
-    expect(frame).toContain("Kelly Curve");
-    expect(frame).toContain("4.0% -> 8.0%");
-    expect(frame).toContain("growth");
-    expect(frame).toContain("loss cap");
-    expect(frame).toContain("cap max loss, max name");
-    expect(frame).toContain("full");
-    expect(frame).toContain("159%");
-    expect(frame).toContain("636%");
-    expect(frame).not.toContain("Mode");
-    expect(frame).not.toContain("Sensitivity");
-  });
-
   test("prefills shared caps from plugin config", async () => {
     const config = {
       ...createSizerConfig(),

package/src/plugins/builtin/kelly-sizer/index.tsx

@@ -43,5 +43,3 @@ export const kellySizerPlugin: GloomPlugin = {
     },
   ],
 };
-
-export default kellySizerPlugin;

package/src/plugins/builtin/market-movers/index.tsx

@@ -51,8 +51,6 @@ function MarketMoversPane({ focused, width, height }: PaneProps) {
   const selectedIdx = selectedSymbol
     ? rows.findIndex((row) => row.symbol === selectedSymbol)
     : -1;
-  const activeIdx = selectedIdx >= 0 ? selectedIdx : (rows.length > 0 ? 0 : -1);
-
   useEffect(() => {
     if (selectedSymbol && selectedIdx >= 0) return;
     const firstRow = rows[0];

package/src/plugins/builtin/news/index.tsx

@@ -32,7 +32,6 @@ function getFeedItems(
       eyebrow: item.source,
       title: item.title,
       timestamp: item.publishedAt,
-      preview,
       detailTitle: item.title,
       detailMeta: [
         item.source,

package/src/plugins/builtin/news/wire/news/table.tsx

@@ -3,7 +3,6 @@ import { TextAttributes } from "../../../../../ui";
 import {
   DataTableStackView,
   TickerBadgeList,
-  activeStackIndex,
   sortStackItems,
   type DataTableCell,
   type DataTableColumn,
@@ -165,23 +164,13 @@ export function NewsArticleStackView({
     [articles, sortPreference],
   );
   const selectedIdx = sortedArticles.findIndex((article) => article.id === selectedArticleId);
-  const activeIdx = activeStackIndex(sortedArticles.length, selectedIdx);
   const columns = useMemo(() => buildColumns(width, columnIds), [columnIds, width]);
 
-  const selectIndex = useCallback((index: number) => {
-    setSelectedArticleId(sortedArticles[index]?.id ?? null);
-  }, [setSelectedArticleId, sortedArticles]);
-
   const openArticle = useCallback((article: MarketNewsItem) => {
     onArticleRead?.(article.id);
     onOpenArticle(article);
   }, [onArticleRead, onOpenArticle]);
 
-  const openIndex = useCallback((index: number) => {
-    const article = sortedArticles[index];
-    if (article) openArticle(article);
-  }, [openArticle, sortedArticles]);
-
   useEffect(() => {
     if (sortedArticles.length === 0) {
       if (selectedArticleId !== null) setSelectedArticleId(null);

package/src/plugins/builtin/options/view.test.tsx

@@ -123,8 +123,8 @@ function OptionsHarness({
 async function renderSettled() {
   for (let i = 0; i < 4; i += 1) {
     await act(async () => {
+      await new Promise((resolve) => setTimeout(resolve, 0));
       await testSetup!.renderOnce();
-      await Promise.resolve();
     });
   }
 }
@@ -139,43 +139,6 @@ afterEach(async () => {
   setSharedMarketDataCoordinator(null);
 });
 
-test("renders the options chain with the shared table columns", async () => {
-  const provider = createTestDataProvider({
-    getOptionsChain: async () => makeChain(),
-  });
-  setSharedMarketDataCoordinator(new MarketDataCoordinator(provider));
-
-  await act(async () => {
-    testSetup = await testRender(<OptionsHarness ticker={makeTicker("AAPL")} />, {
-      width: 124,
-      height: 16,
-    });
-  });
-
-  await renderSettled();
-
-  const frame = testSetup!.captureCharFrame();
-  expect(frame).toContain("C LAST");
-  expect(frame).toContain("C IV");
-  expect(frame).toContain("STRIKE");
-  expect(frame).toContain("P IV");
-  expect(frame).toContain("P LAST");
-  expect(frame).toContain("100");
-  expect(frame).toContain("101");
-
-  const headerLine = frame.split("\n").find((line) => line.includes("C OI") && line.includes("STRIKE")) ?? "";
-  expect(headerLine.indexOf("C OI")).toBeLessThan(headerLine.indexOf("C VOL"));
-  expect(headerLine.indexOf("C VOL")).toBeLessThan(headerLine.indexOf("C LAST"));
-  expect(headerLine.indexOf("C LAST")).toBeLessThan(headerLine.indexOf("C IV"));
-  expect(headerLine.indexOf("C IV")).toBeLessThan(headerLine.indexOf("C BID"));
-  expect(headerLine.indexOf("C BID")).toBeLessThan(headerLine.indexOf("C ASK"));
-  expect(headerLine.indexOf("P BID")).toBeLessThan(headerLine.indexOf("P ASK"));
-  expect(headerLine.indexOf("P ASK")).toBeLessThan(headerLine.indexOf("P IV"));
-  expect(headerLine.indexOf("P IV")).toBeLessThan(headerLine.indexOf("P LAST"));
-  expect(headerLine.indexOf("P LAST")).toBeLessThan(headerLine.indexOf("P VOL"));
-  expect(headerLine.indexOf("P VOL")).toBeLessThan(headerLine.indexOf("P OI"));
-});
-
 test("defaults the table around the nearest strike to the current quote", async () => {
   const strikes = Array.from({ length: 25 }, (_, index) => 50 + index * 5);
   const provider = createTestDataProvider({

package/src/plugins/builtin/plugin-groups.ts

@@ -29,6 +29,7 @@ type PluginGroupOptions = Pick<
 };
 
 function createPluginGroup(options: PluginGroupOptions): GloomPlugin {
+  let startedPlugins: GloomPlugin[] = [];
   return {
     id: options.id,
     name: options.name,
@@ -42,17 +43,30 @@ function createPluginGroup(options: PluginGroupOptions): GloomPlugin {
     capabilities: options.plugins.flatMap((plugin) => plugin.capabilities ?? []),
 
     async setup(ctx) {
+      startedPlugins = [];
       await options.setup?.(ctx);
       for (const plugin of options.plugins) {
+        startedPlugins.push(plugin);
         await plugin.setup?.(ctx);
       }
     },
 
     dispose() {
-      for (const plugin of [...options.plugins].reverse()) {
-        plugin.dispose?.();
+      let firstError: unknown;
+      for (const plugin of startedPlugins.reverse()) {
+        try {
+          plugin.dispose?.();
+        } catch (error) {
+          firstError ??= error;
+        }
       }
-      options.dispose?.();
+      startedPlugins = [];
+      try {
+        options.dispose?.();
+      } catch (error) {
+        firstError ??= error;
+      }
+      if (firstError) throw firstError;
     },
   };
 }

package/src/plugins/builtin/portfolio-list/column-values.ts

@@ -1,5 +1,5 @@
 import type { ColumnConfig } from "../../../types/config";
-import type { AnalystResearchData, CorporateActionsData, TickerFinancials } from "../../../types/financials";
+import type { AnalystResearchData, CorporateActionsData, MarketState, TickerFinancials } from "../../../types/financials";
 import type { EarningsEvent } from "../../../types/data-provider";
 import type { TickerRecord } from "../../../types/ticker";
 import { priceColor } from "../../../theme/colors";
@@ -13,7 +13,13 @@ import {
   formatSignedMarketPrice,
   type MarketFormatOptions,
 } from "../../../market-data/market/format";
-import { getActiveQuoteDisplay, marketStateDot, type ActiveQuoteDisplay } from "../../../market-data/market/status";
+import {
+  getActiveQuoteDisplay,
+  marketChangeColor,
+  marketPriceColor,
+  marketStateDot,
+  type ActiveQuoteDisplay,
+} from "../../../market-data/market/status";
 import { formatOptionTicker } from "../../../utils/options";
 import { PRICE_SPARKLINE_COLUMN_ID } from "../../../components/price-sparkline/view";
 import {
@@ -159,13 +165,14 @@ function getActiveMarketValue(
 export function resolvePortfolioPriceValue(
   activeQuote: ActiveQuoteDisplay | null,
   brokerMarkPrice: number | undefined,
-  formatOptions: MarketFormatOptions,
+  formatOptions: MarketFormatOptions = {},
   maxWidth?: number,
+  marketState?: MarketState,
 ): { text: string; color?: string } {
   if (activeQuote) {
     return {
       text: formatMarketPrice(activeQuote.price, { ...formatOptions, maxWidth }),
-      color: priceColor(activeQuote.change),
+      color: marketPriceColor(activeQuote.change, marketState),
     };
   }
   if (brokerMarkPrice != null) {
@@ -229,12 +236,12 @@ export function getColumnValue(
     case "tags":
       return { text: ticker.metadata.tags.length > 0 ? ticker.metadata.tags.join(",") : "—" };
     case "price":
-      return resolvePortfolioPriceValue(activeQuote, brokerMarkPrice, formatOptions, col.width);
+      return resolvePortfolioPriceValue(activeQuote, brokerMarkPrice, formatOptions, col.width, quote?.marketState);
     case "change":
       if (!activeQuote) return { text: "—" };
       return {
         text: formatSignedMarketPrice(activeQuote.change, { ...formatOptions, maxWidth: col.width }),
-        color: priceColor(activeQuote.change),
+        color: marketChangeColor(activeQuote.change, quote?.marketState),
       };
     case "bid":
       return { text: quote?.bid != null ? formatMarketPrice(quote.bid, { ...formatOptions, maxWidth: col.width }) : "—" };
@@ -258,8 +265,8 @@ export function getColumnValue(
     }
     case "change_pct":
       return activeQuote
-        ? { text: formatPercentRaw(activeQuote.changePercent), color: priceColor(activeQuote.changePercent) }
-        : { text: quote ? formatPercentRaw(quote.changePercent) : "—", color: quote ? priceColor(quote.changePercent) : undefined };
+        ? { text: formatPercentRaw(activeQuote.changePercent), color: marketChangeColor(activeQuote.changePercent, quote?.marketState) }
+        : { text: quote ? formatPercentRaw(quote.changePercent) : "—", color: quote ? marketChangeColor(quote.changePercent, quote.marketState) : undefined };
     case "volume":
       return { text: finiteNumber(quote?.volume) ? formatCompact(quote.volume) : "—" };
     case "dollar_volume": {

package/src/plugins/builtin/portfolio-list/index.test.ts

@@ -5,8 +5,8 @@ import type { BrokerAccount } from "../../../types/trading";
 import type { TickerRecord } from "../../../types/ticker";
 import type { PortfolioSummaryTotals } from "./metrics";
 import { buildPortfolioSummarySegments } from "./summary";
-import { portfolioListPlugin, shouldToggleCashMarginDrawer } from ".";
-import { needsVisibleQuoteWatchdogRefresh, selectStreamTickers } from "./pane/data";
+import { shouldToggleCashMarginDrawer } from ".";
+import { needsVisibleQuoteWatchdogRefresh, selectQuoteWarmupTickers, selectStreamTickers } from "./pane/data";
 import { buildPortfolioPaneSettingsDef, getPortfolioPaneSettings } from "./settings";
 
 function ticker(symbol: string): TickerRecord {
@@ -134,6 +134,56 @@ describe("selectStreamTickers", () => {
   });
 });
 
+describe("selectQuoteWarmupTickers", () => {
+  function financials(quoteValue: Quote | undefined): TickerFinancials {
+    return {
+      annualStatements: [],
+      quarterlyStatements: [],
+      priceHistory: [],
+      quote: quoteValue,
+    };
+  }
+
+  test("includes hidden quote-missing rows when sorting by quote-dependent columns", () => {
+    const tickers = Array.from({ length: 30 }, (_, index) => ticker(`T${index}`));
+    const financialsMap = new Map<string, TickerFinancials>(
+      tickers.slice(0, 29).map((entry, index) => [
+        entry.metadata.ticker,
+        financials({
+          symbol: entry.metadata.ticker,
+          price: index + 1,
+          currency: "USD",
+          change: index,
+          changePercent: index,
+          lastUpdated: 1_700_000_000_000,
+        }),
+      ]),
+    );
+
+    const selected = selectQuoteWarmupTickers(
+      tickers,
+      { start: 0, end: 24 },
+      financialsMap,
+      { columnId: "change_pct", direction: "asc" },
+      1_700_000_010_000,
+    ).map((entry) => entry.metadata.ticker);
+
+    expect(selected).toContain("T29");
+  });
+
+  test("does not add hidden rows for ticker-only sorting", () => {
+    const tickers = Array.from({ length: 30 }, (_, index) => ticker(`T${index}`));
+    expect(selectQuoteWarmupTickers(
+      tickers,
+      { start: 0, end: 24 },
+      new Map(),
+      { columnId: "ticker", direction: "asc" },
+    ).map((entry) => entry.metadata.ticker)).toEqual(
+      tickers.slice(0, 24).map((entry) => entry.metadata.ticker),
+    );
+  });
+});
+
 describe("visible quote refresh predicates", () => {
   function quote(overrides: Partial<Quote> = {}): Quote {
     return {
@@ -171,29 +221,6 @@ describe("visible quote refresh predicates", () => {
   });
 });
 
-describe("portfolio list pane templates", () => {
-  test("create panes with default all-collection settings", async () => {
-    const config = createDefaultConfig("/tmp/gloomberb-portfolio-list-template");
-    const context = {
-      config,
-      layout: config.layout,
-      focusedPaneId: "portfolio-list:main",
-      activeTicker: null,
-      activeCollectionId: "watchlist",
-    };
-
-    for (const templateId of ["new-collection-pane", "new-watchlist-pane"]) {
-      const template = portfolioListPlugin.paneTemplates?.find((entry) => entry.id === templateId);
-      const instance = await template?.createInstance?.(context);
-      expect(instance).toEqual({ params: { collectionId: "watchlist" } });
-    }
-
-    const portfolioTemplate = portfolioListPlugin.paneTemplates?.find((entry) => entry.id === "new-portfolio-pane");
-    const portfolioInstance = await portfolioTemplate?.createInstance?.(context);
-    expect(portfolioInstance).toEqual({ params: { collectionId: "main" } });
-  });
-});
-
 describe("portfolio list pane settings", () => {
   test("exposes view mode only for portfolio collections", () => {
     const config = createDefaultConfig("/tmp/gloomberb-portfolio-list-settings");

package/src/plugins/builtin/portfolio-list/metrics.test.ts

@@ -1,8 +1,9 @@
 import { describe, expect, test } from "bun:test";
 import type { CollectionSortPreference } from "../../../state/app/context";
 import type { ColumnConfig } from "../../../types/config";
-import type { TickerFinancials } from "../../../types/financials";
+import type { Quote, TickerFinancials } from "../../../types/financials";
 import type { TickerRecord } from "../../../types/ticker";
+import { blendHex, colors } from "../../../theme/colors";
 import {
   calculatePortfolioSummaryTotals,
   getColumnValue,
@@ -29,8 +30,15 @@ function createTicker(overrides: Partial<TickerRecord["metadata"]> = {}): Ticker
   };
 }
 
-function createFinancials(overrides: Partial<TickerFinancials> = {}): TickerFinancials {
+function createFinancials(
+  overrides: Omit<Partial<TickerFinancials>, "quote"> & { quote?: Partial<Quote> } = {},
+): TickerFinancials {
+  const { quote: quoteOverrides, ...financialOverrides } = overrides;
   return {
+    annualStatements: [],
+    quarterlyStatements: [],
+    priceHistory: [],
+    ...financialOverrides,
     quote: {
       symbol: "AAPL",
       price: 120,
@@ -39,12 +47,8 @@ function createFinancials(overrides: Partial<TickerFinancials> = {}): TickerFina
       changePercent: 4.35,
       previousClose: 115,
       lastUpdated: 1_700_000_000_000,
-      ...overrides.quote,
+      ...quoteOverrides,
     },
-    annualStatements: [],
-    quarterlyStatements: [],
-    priceHistory: [],
-    ...overrides,
   };
 }
 
@@ -82,6 +86,39 @@ describe("portfolio-metrics", () => {
     });
   });
 
+  test("mutes completed-session prices and changes without discarding their direction", () => {
+    const ticker = createTicker({
+      positions: [{ portfolio: "main", shares: 10, avgCost: 100, broker: "manual" }],
+    });
+    const priceColumn: ColumnConfig = { id: "price", label: "LAST", width: 10, align: "right" };
+    const changeColumn: ColumnConfig = { id: "change", label: "CHG", width: 8, align: "right" };
+    const changePctColumn: ColumnConfig = { id: "change_pct", label: "CHG%", width: 8, align: "right" };
+    const financials = createFinancials({ quote: { marketState: "CLOSED" } });
+    const mutedPositive = blendHex(colors.positive, colors.textDim, 0.55);
+
+    expect(getColumnValue(priceColumn, ticker, financials, defaultColumnContext)).toEqual({
+      text: "120",
+      color: colors.textDim,
+    });
+    expect(getColumnValue(changeColumn, ticker, financials, defaultColumnContext)).toEqual({
+      text: "+5",
+      color: mutedPositive,
+    });
+    expect(getColumnValue(changePctColumn, ticker, financials, defaultColumnContext)).toEqual({
+      text: "+4.35%",
+      color: mutedPositive,
+    });
+    const unchanged = createFinancials({ quote: { change: 0, changePercent: 0, previousClose: 120, marketState: "CLOSED" } });
+    expect(getColumnValue(changePctColumn, ticker, unchanged, defaultColumnContext)).toEqual({
+      text: "0.00%",
+      color: colors.neutral,
+    });
+
+    const open = createFinancials({ quote: { marketState: "REGULAR" } });
+    expect(getColumnValue(priceColumn, ticker, open, defaultColumnContext).color).toBe(colors.positive);
+    expect(getColumnValue(changePctColumn, ticker, open, defaultColumnContext).color).toBe(colors.positive);
+  });
+
   test("calculates portfolio totals from live quotes", () => {
     const ticker = createTicker({
       positions: [{ portfolio: "main", shares: 10, avgCost: 100, broker: "manual" }],

package/src/plugins/builtin/portfolio-list/pane/data.test.ts

@@ -0,0 +1,54 @@
+import { describe, expect, test } from "bun:test";
+import type { Quote, TickerFinancials } from "../../../../types/financials";
+import {
+  needsVisibleQuoteWarmup,
+  needsVisibleQuoteWatchdogRefresh,
+  VISIBLE_QUOTE_STREAM_MAX_AGE_MS,
+} from "./data";
+
+function quote(overrides: Partial<Quote> = {}): Quote {
+  return {
+    symbol: "AAPL",
+    price: 100,
+    currency: "USD",
+    change: 0,
+    changePercent: 0,
+    lastUpdated: Date.now(),
+    ...overrides,
+  };
+}
+
+function financials(quoteValue: Quote): TickerFinancials {
+  return {
+    annualStatements: [],
+    quarterlyStatements: [],
+    priceHistory: [],
+    quote: quoteValue,
+  };
+}
+
+describe("portfolio visible quote warmup", () => {
+  test("refreshes current-session quotes once the visible-row age window expires", () => {
+    const now = Date.now();
+    const data = financials(quote({
+      lastUpdated: now - VISIBLE_QUOTE_STREAM_MAX_AGE_MS,
+      listingExchangeName: "FWB2",
+      marketState: "REGULAR",
+    }));
+
+    expect(needsVisibleQuoteWarmup(data, now)).toBe(false);
+    expect(needsVisibleQuoteWatchdogRefresh(data, now)).toBe(true);
+  });
+
+  test("treats stale active-session quotes as visible warmup misses", () => {
+    const now = Date.parse("2026-07-07T12:10:30Z");
+    const data = financials(quote({
+      lastUpdated: Date.parse("2026-07-07T12:10:00Z"),
+      listingExchangeName: "NASDAQ",
+      marketState: "PRE",
+    }));
+
+    expect(needsVisibleQuoteWarmup(data, now)).toBe(true);
+    expect(needsVisibleQuoteWatchdogRefresh(data, now)).toBe(true);
+  });
+});

package/src/plugins/builtin/portfolio-list/pane/data.ts

@@ -10,14 +10,32 @@ import { compareSortValues } from "../../../../utils/sort-values";
 import { getSortValue, type ColumnContext } from "../metrics";
 import type { ResolvedPortfolioAccountState } from "../summary";
 
-export const VISIBLE_QUOTE_REFRESH_COOLDOWN_MS = 60_000;
-export const VISIBLE_QUOTE_STREAM_MAX_AGE_MS = 60_000;
-export const VISIBLE_QUOTE_STREAM_WATCHDOG_MS = 30_000;
+export const VISIBLE_QUOTE_REFRESH_COOLDOWN_MS = 15_000;
+export const VISIBLE_QUOTE_STREAM_MAX_AGE_MS = 15_000;
+export const VISIBLE_QUOTE_STREAM_WATCHDOG_MS = 5_000;
 export const VISIBLE_SNAPSHOT_REFRESH_COOLDOWN_MS = 5 * 60_000;
 export const VISIBLE_FINANCIAL_WARMUP_DELAY_MS = 350;
 export const VISIBLE_SNAPSHOT_WARMUP_BATCH_LIMIT = 3;
+export const SORT_QUOTE_WARMUP_BATCH_LIMIT = 64;
 
 const STREAM_OVERSCAN_ROWS = 6;
+const QUOTE_SORT_COLUMN_IDS = new Set([
+  "price",
+  "change",
+  "change_pct",
+  "volume",
+  "dollar_volume",
+  "range_52w",
+  "market_cap",
+  "latency",
+  "ext_hours",
+  "mkt_value",
+  "weight",
+  "day_pnl",
+  "pnl",
+  "pnl_pct",
+  "mark_delta",
+]);
 const FUNDAMENTAL_COLUMN_IDS = new Set(["pe", "forward_pe", "dividend_yield"]);
 const PROFILE_COLUMN_IDS = new Set(["sector", "industry"]);
 const sortValueCache = createRowValueCache<string, ReturnType<typeof getSortValue>>(5000);
@@ -81,6 +99,35 @@ export function selectStreamTickers(
   return selectedTicker ? [...visible, selectedTicker] : visible;
 }
 
+export function sortPreferenceUsesQuote(sortPreference: CollectionSortPreference): boolean {
+  return !!sortPreference.columnId && QUOTE_SORT_COLUMN_IDS.has(sortPreference.columnId);
+}
+
+export function selectQuoteWarmupTickers(
+  sortedTickers: TickerRecord[],
+  visibleRange: { start: number; end: number },
+  financialsMap: Map<string, TickerFinancials>,
+  sortPreference: CollectionSortPreference,
+  now = Date.now(),
+  hiddenLimit = SORT_QUOTE_WARMUP_BATCH_LIMIT,
+): TickerRecord[] {
+  const visible = sortedTickers.slice(visibleRange.start, visibleRange.end);
+  if (!sortPreferenceUsesQuote(sortPreference)) {
+    return visible;
+  }
+
+  const seen = new Set(visible.map((ticker) => ticker.metadata.ticker));
+  const hidden: TickerRecord[] = [];
+  for (const ticker of sortedTickers) {
+    if (seen.has(ticker.metadata.ticker)) continue;
+    if (!needsVisibleQuoteWarmup(financialsMap.get(ticker.metadata.ticker), now)) continue;
+    hidden.push(ticker);
+    seen.add(ticker.metadata.ticker);
+    if (hidden.length >= hiddenLimit) break;
+  }
+  return [...visible, ...hidden];
+}
+
 export function buildTrackedCurrencies(
   tickers: TickerRecord[],
   financialsMap: Map<string, TickerFinancials>,