gloomberb 0.9.7 → 0.9.9

package/src/plugins/builtin/chat/content/new-dm-dialog.tsx

@@ -0,0 +1,264 @@
+import { useEffect, useMemo, useRef, useState } from "react";
+import { ListView, TextField, type ListViewItem } from "../../../../components/ui";
+import { useShortcut } from "../../../../react/input";
+import { colors, hoverBg } from "../../../../theme/colors";
+import { Box, Text, TextAttributes, type InputRenderable } from "../../../../ui";
+import type { ChatUserSummary } from "../../../../api-client";
+import { isPlainKey } from "../../../../utils/keyboard";
+import {
+  hasOnlyDmUsernameArgs,
+  parseDmUsernames,
+  truncateChannelLabel,
+} from "../channels";
+
+const MAX_RECENT_USERS = 6;
+const MIN_DIALOG_WIDTH = 32;
+const MAX_DIALOG_WIDTH = 52;
+const DIALOG_HEIGHT = 10;
+
+interface DmUserCandidate {
+  username: string;
+  displayName: string;
+}
+
+function normalizeUsername(value: string | null | undefined): string {
+  return value?.trim().replace(/^@+/, "").toLowerCase() ?? "";
+}
+
+function currentTokenQuery(value: string): string {
+  const token = value.split(/[\s,]+/).at(-1) ?? "";
+  return normalizeUsername(token);
+}
+
+function candidateUsers(
+  userByUsername: Map<string, ChatUserSummary>,
+  currentUserId: string | null | undefined,
+): DmUserCandidate[] {
+  const candidates = new Map<string, DmUserCandidate>();
+  for (const [key, user] of userByUsername) {
+    if (currentUserId && user.id === currentUserId) continue;
+    const username = normalizeUsername(user.username ?? key);
+    if (!username) continue;
+    candidates.set(username, {
+      username,
+      displayName: user.displayName?.trim() || `@${username}`,
+    });
+  }
+  return [...candidates.values()].sort((left, right) => left.username.localeCompare(right.username));
+}
+
+function setUsernameSelected(value: string, username: string, selected: boolean): string {
+  const usernames = parseDmUsernames(value).filter((existing) => existing !== username);
+  if (selected) usernames.push(username);
+  return usernames.map((entry) => `@${entry}`).join(" ") + (usernames.length > 0 ? " " : "");
+}
+
+function usernamesLabel(usernames: string[], width: number): string {
+  return truncateChannelLabel(usernames.map((username) => `@${username}`).join(" "), width);
+}
+
+export function NewDmDialog({
+  width,
+  height,
+  userByUsername,
+  currentUserId,
+  onCancel,
+  onSubmit,
+}: {
+  width: number;
+  height: number;
+  userByUsername: Map<string, ChatUserSummary>;
+  currentUserId?: string | null;
+  onCancel: () => void;
+  onSubmit: (usernames: string[]) => Promise<void>;
+}) {
+  const inputRef = useRef<InputRenderable | null>(null);
+  const [value, setValue] = useState("");
+  const valueRef = useRef("");
+  const [selectedIndex, setSelectedIndex] = useState(0);
+  const [submitting, setSubmitting] = useState(false);
+  const [error, setError] = useState<string | null>(null);
+  const dialogWidth = Math.max(MIN_DIALOG_WIDTH, Math.min(MAX_DIALOG_WIDTH, width - 4));
+  const dialogHeight = Math.min(DIALOG_HEIGHT, Math.max(7, height - 2));
+  const left = Math.max(0, Math.floor((width - dialogWidth) / 2));
+  const top = Math.max(0, Math.floor((height - dialogHeight) / 2));
+  const contentWidth = Math.max(1, dialogWidth - 4);
+  const selectedUsernames = useMemo(() => parseDmUsernames(value), [value]);
+  const selectedUsernameSet = useMemo(() => new Set(selectedUsernames), [selectedUsernames]);
+  const allCandidates = useMemo(() => candidateUsers(userByUsername, currentUserId), [currentUserId, userByUsername]);
+  const query = currentTokenQuery(value);
+  const visibleCandidates = useMemo(() => {
+    const filtered = query
+      ? allCandidates.filter((candidate) => candidate.username.includes(query))
+      : allCandidates;
+    return filtered.slice(0, MAX_RECENT_USERS);
+  }, [allCandidates, query]);
+  const items = useMemo<ListViewItem[]>(() => visibleCandidates.map((candidate) => ({
+    id: candidate.username,
+    label: `@${candidate.username}`,
+    detail: candidate.displayName,
+    checked: selectedUsernameSet.has(candidate.username),
+  })), [selectedUsernameSet, visibleCandidates]);
+  const canSubmit = hasOnlyDmUsernameArgs(value) && selectedUsernames.length > 0 && !submitting;
+
+  useEffect(() => {
+    inputRef.current?.focus?.();
+  }, []);
+
+  useEffect(() => {
+    setSelectedIndex((current) => Math.max(0, Math.min(current, Math.max(items.length - 1, 0))));
+  }, [items.length]);
+
+  const updateValue = (nextValue: string) => {
+    valueRef.current = nextValue;
+    setValue(nextValue);
+  };
+
+  const toggleCandidate = (username: string) => {
+    updateValue(setUsernameSelected(valueRef.current, username, !parseDmUsernames(valueRef.current).includes(username)));
+    setError(null);
+    queueMicrotask(() => inputRef.current?.focus?.());
+  };
+
+  const submit = async () => {
+    const submittedValue = valueRef.current;
+    const submittedUsernames = parseDmUsernames(submittedValue);
+    if (!hasOnlyDmUsernameArgs(submittedValue) || submittedUsernames.length === 0 || submitting) {
+      setError("Enter at least one @username.");
+      return;
+    }
+    setSubmitting(true);
+    setError(null);
+    try {
+      await onSubmit(submittedUsernames);
+    } catch {
+      setError("Could not start conversation.");
+      setSubmitting(false);
+    }
+  };
+
+  useShortcut((event) => {
+    if (event.name === "escape") {
+      event.preventDefault?.();
+      event.stopPropagation?.();
+      onCancel();
+      return;
+    }
+    if (isPlainKey(event, "up", "down")) {
+      event.preventDefault?.();
+      event.stopPropagation?.();
+      setSelectedIndex((current) => {
+        if (items.length === 0) return 0;
+        return event.name === "up"
+          ? Math.max(0, current - 1)
+          : Math.min(items.length - 1, current + 1);
+      });
+      return;
+    }
+    if (event.name === "tab" && items[selectedIndex]) {
+      event.preventDefault?.();
+      event.stopPropagation?.();
+      toggleCandidate(items[selectedIndex]!.id);
+      return;
+    }
+    if (event.name === "enter" || event.name === "return") {
+      event.preventDefault?.();
+      event.stopPropagation?.();
+      void submit();
+    }
+  }, { allowEditable: true, phase: "before" });
+
+  return (
+    <Box
+      position="absolute"
+      left={left}
+      top={top}
+      width={dialogWidth}
+      height={dialogHeight}
+      flexDirection="column"
+      border
+      borderColor={colors.borderFocused}
+      backgroundColor={colors.bg}
+      paddingX={1}
+      onMouseDown={(event: any) => {
+        event?.preventDefault?.();
+        event?.stopPropagation?.();
+      }}
+      style={{ zIndex: 8 }}
+    >
+      <Box height={1} flexDirection="row">
+        <Text fg={colors.textBright} attributes={TextAttributes.BOLD}>New DM</Text>
+        <Box flexGrow={1} />
+        <Box width={3} height={1} backgroundColor={colors.panel} onMouseDown={onCancel} style={{ cursor: "pointer" }}>
+          <Text fg={colors.text}> x </Text>
+        </Box>
+      </Box>
+      <TextField
+        inputRef={inputRef}
+        value={value}
+        placeholder="@username, @second"
+        focused
+        width={contentWidth}
+        backgroundColor={colors.panel}
+        onChange={(nextValue) => {
+          updateValue(nextValue);
+          setError(null);
+        }}
+        onSubmit={() => { void submit(); }}
+      />
+      <Box height={1}>
+        <Text fg={selectedUsernames.length > 0 ? colors.textMuted : colors.textDim}>
+          {selectedUsernames.length > 0 ? usernamesLabel(selectedUsernames, contentWidth) : "Recent users"}
+        </Text>
+      </Box>
+      <ListView
+        items={items}
+        selectedIndex={items.length > 0 ? selectedIndex : -1}
+        height={Math.max(1, dialogHeight - 6)}
+        bgColor={colors.bg}
+        selectedBgColor={colors.selected}
+        hoverBgColor={hoverBg()}
+        emptyMessage="No recent users"
+        selectOnHover
+        onSelect={setSelectedIndex}
+        onActivate={(item) => toggleCandidate(item.id)}
+        renderRow={(item, state) => (
+          <Box flexDirection="row" width={contentWidth}>
+            <Text fg={state.selected ? colors.selectedText : colors.textDim}>
+              {item.checked ? "x " : "+ "}
+            </Text>
+            <Text
+              fg={state.selected ? colors.text : colors.textMuted}
+              attributes={state.selected ? TextAttributes.BOLD : 0}
+            >
+              {truncateChannelLabel(item.label, Math.max(1, contentWidth - 12))}
+            </Text>
+            <Box flexGrow={1} />
+            {item.detail ? (
+              <Text fg={colors.textDim}>{truncateChannelLabel(item.detail, 10)}</Text>
+            ) : null}
+          </Box>
+        )}
+      />
+      <Box height={1} flexDirection="row">
+        {error ? (
+          <Text fg={colors.negative}>{truncateChannelLabel(error, contentWidth)}</Text>
+        ) : (
+          <Text fg={colors.textDim}>{selectedUsernames.length > 1 ? "Group chat" : "Direct message"}</Text>
+        )}
+        <Box flexGrow={1} />
+        <Box
+          width={submitting ? 10 : 7}
+          height={1}
+          backgroundColor={canSubmit ? colors.selected : colors.panel}
+          onMouseDown={() => { void submit(); }}
+          style={{ cursor: canSubmit ? "pointer" : "default" }}
+        >
+          <Text fg={canSubmit ? colors.selectedText : colors.textDim}>
+            {submitting ? " Starting " : " Start "}
+          </Text>
+        </Box>
+      </Box>
+    </Box>
+  );
+}

package/src/plugins/builtin/chat/content/shortcuts.ts

@@ -11,6 +11,7 @@ export function useChatContentShortcuts({
   blurInput,
   canSend,
   cancelEditMessage,
+  commandBarOpen,
   clearReplyTarget,
   cycleChannel,
   focusChannelSidebar,
@@ -22,6 +23,10 @@ export function useChatContentShortcuts({
   inputValueRef,
   loadingOlderMessages,
   messages,
+  mentionMenuOpen,
+  moveMentionSelection,
+  dismissMentionSuggestions,
+  commitMentionSelection,
   moveMessageSelection,
   moveSidebarChannelSelection,
   nativePaneChrome,
@@ -43,6 +48,7 @@ export function useChatContentShortcuts({
   blurInput: () => void;
   canSend: boolean;
   cancelEditMessage: () => void;
+  commandBarOpen: boolean;
   clearReplyTarget: () => void;
   cycleChannel: (direction: 1 | -1) => boolean;
   focusChannelSidebar: () => boolean;
@@ -54,6 +60,10 @@ export function useChatContentShortcuts({
   inputValueRef: MutableRefObject<string>;
   loadingOlderMessages: boolean;
   messages: ChatMessage[];
+  mentionMenuOpen: boolean;
+  moveMentionSelection: (direction: "up" | "down") => boolean;
+  dismissMentionSuggestions: () => boolean;
+  commitMentionSelection: () => boolean;
   moveMessageSelection: (direction: "up" | "down") => boolean;
   moveSidebarChannelSelection: (direction: "up" | "down") => boolean;
   nativePaneChrome?: boolean;
@@ -71,7 +81,25 @@ export function useChatContentShortcuts({
   sidebarFocusedRef: MutableRefObject<boolean>;
 }) {
   useShortcut((event) => {
-    if (!focused) return;
+    if (!focused || commandBarOpen || !inputFocused || !mentionMenuOpen) return;
+    if (
+      event.name !== "tab"
+      || event.ctrl
+      || event.meta
+      || event.super
+      || event.alt
+      || event.option
+    ) {
+      return;
+    }
+
+    event.preventDefault?.();
+    event.stopPropagation?.();
+    commitMentionSelection();
+  }, { allowEditable: true, phase: "before" });
+
+  useShortcut((event) => {
+    if (!focused || commandBarOpen) return;
     const isEnterKey = event.name === "return" || event.name === "enter";
 
     if (sidebarFocusedRef.current && showChannelSidebar) {
@@ -117,6 +145,24 @@ export function useChatContentShortcuts({
     }
 
     if (inputFocused) {
+      if (mentionMenuOpen) {
+        if (event.name === "escape") {
+          event.preventDefault?.();
+          event.stopPropagation?.();
+          dismissMentionSuggestions();
+          return;
+        }
+
+        if (isPlainKey(event, "up", "down")) {
+          event.preventDefault?.();
+          event.stopPropagation?.();
+          if (event.name === "up" || event.name === "down") {
+            moveMentionSelection(event.name);
+          }
+          return;
+        }
+      }
+
       if (event.name === "escape") {
         event.preventDefault?.();
         event.stopPropagation?.();

package/src/plugins/builtin/chat/content/snapshot.ts

@@ -17,6 +17,7 @@ interface ChatSnapshotStateArgs {
   initialSnapshot: ChatSnapshot;
   inputRef: MutableRef<TextareaRenderable | null>;
   inputValueRef: MutableRef<string>;
+  onComposerStateChange?: (draft: string, cursorOffset: number) => void;
   prependAnchorRef: MutableRef<ChatPrependAnchor | null>;
   setFollowMessages: Dispatch<SetStateAction<boolean>>;
   setSelectedIdx: Dispatch<SetStateAction<number>>;
@@ -28,18 +29,21 @@ function syncDraftFromSnapshot({
   applyingExternalDraftRef,
   inputRef,
   inputValueRef,
+  onComposerStateChange,
   snapshot,
   updateComposerRows,
 }: {
   applyingExternalDraftRef: MutableRef<boolean>;
   inputRef: MutableRef<TextareaRenderable | null>;
   inputValueRef: MutableRef<string>;
+  onComposerStateChange?: (draft: string, cursorOffset: number) => void;
   snapshot: ChatSnapshot;
   updateComposerRows: (draft: string) => void;
 }) {
   if (inputValueRef.current !== snapshot.draft) {
     inputValueRef.current = snapshot.draft;
     updateComposerRows(snapshot.draft);
+    onComposerStateChange?.(snapshot.draft, snapshot.draft.length);
   }
   const textarea = inputRef.current;
   if (textarea && textarea.editBuffer.getText() !== snapshot.draft) {
@@ -62,6 +66,7 @@ export function useChatSnapshotState({
   initialSnapshot,
   inputRef,
   inputValueRef,
+  onComposerStateChange,
   prependAnchorRef,
   setFollowMessages,
   setSelectedIdx,
@@ -110,6 +115,7 @@ export function useChatSnapshotState({
         applyingExternalDraftRef,
         inputRef,
         inputValueRef,
+        onComposerStateChange,
         snapshot,
         updateComposerRows,
       });
@@ -130,6 +136,7 @@ export function useChatSnapshotState({
     controller,
     inputRef,
     inputValueRef,
+    onComposerStateChange,
     prependAnchorRef,
     setFollowMessages,
     setSelectedIdx,

package/src/plugins/builtin/chat/content/transcript.tsx

@@ -29,7 +29,6 @@ interface ChatTranscriptProps {
   messages: ChatMessage[];
   nativePaneChrome: boolean | undefined;
   latestEditableMessageId: string | null;
-  openDirectMessage: (target: ChatUserSummary) => void;
   openTicker: (symbol: string) => void;
   profilePopoverUser: ChatUserSummary | null;
   registerMessageElement: (messageId: string, node: unknown | null) => void;
@@ -61,7 +60,6 @@ export function ChatTranscript({
   messages,
   nativePaneChrome,
   latestEditableMessageId,
-  openDirectMessage,
   openTicker,
   profilePopoverUser,
   registerMessageElement,
@@ -71,7 +69,6 @@ export function ChatTranscript({
   setHoveredIdx,
   showProfilePopover,
   stickyTranscript,
-  user,
   userByUsername,
 }: ChatTranscriptProps) {
   return (
@@ -152,8 +149,6 @@ export function ChatTranscript({
         <UserProfilePopover
           user={profilePopoverUser}
           width={chatWidth}
-          currentUserId={user?.id}
-          onDirectMessage={openDirectMessage}
           onClose={scheduleProfilePopoverClose}
           onKeepOpen={cancelProfilePopoverClose}
         />

package/src/plugins/builtin/chat/controller/index.ts

@@ -30,7 +30,6 @@ import {
   disposeChatControllerRuntime,
   resetChatControllerRuntime,
 } from "./lifecycle";
-import type { ChatSessionUser } from "./persistence";
 import {
   closeAllChannelConnections,
   closeInactiveChannelConnections,
@@ -69,15 +68,6 @@ export class ChatController {
   private notifyFn: (notification: AppNotificationRequest) => void = () => {};
   private notifiedMessageIds = new Set<string>();
 
-  private get hydrated(): boolean { return this.session.hydrated; }
-  private set hydrated(value: boolean) { this.session.hydrated = value; }
-  private get sessionToken(): string | null { return this.session.sessionToken; }
-  private set sessionToken(value: string | null) { this.session.sessionToken = value; }
-  private get sessionChecked(): boolean { return this.session.sessionChecked; }
-  private set sessionChecked(value: boolean) { this.session.sessionChecked = value; }
-  private get user(): ChatSessionUser | null { return this.session.user; }
-  private set user(value: ChatSessionUser | null) { this.session.user = value; }
-
   private readonly storage = new ChatControllerStorage({
     emit: (channelId) => this.emit(channelId),
     getSessionToken: () => this.session.sessionToken,

package/src/plugins/builtin/chat/controller.test.ts

@@ -245,8 +245,8 @@ describe("ChatController", () => {
     const controller = new ChatController();
 
     apiClient.setSessionToken("token-123");
-    (controller as any).sessionToken = "token-123";
-    (controller as any).user = { id: "u1", username: "vince", emailVerified: false };
+    (controller as any).session.sessionToken = "token-123";
+    (controller as any).session.user = { id: "u1", username: "vince", emailVerified: false };
 
     controller.setAppActive(false);
     (controller as any).realtime.syncVerificationPolling();
@@ -263,12 +263,12 @@ describe("ChatController", () => {
     let closed = false;
 
     apiClient.setSessionToken("token-123");
-    (controller as any).sessionToken = "token-123";
-    (controller as any).user = { id: "u1", username: "vince", emailVerified: false };
+    (controller as any).session.sessionToken = "token-123";
+    (controller as any).session.user = { id: "u1", username: "vince", emailVerified: false };
     (controller as any).realtime.syncVerificationPolling();
     expect((controller as any).realtime.verificationPollTimer).not.toBeNull();
 
-    (controller as any).user = { id: "u1", username: "vince", emailVerified: true };
+    (controller as any).session.user = { id: "u1", username: "vince", emailVerified: true };
     apiClient.connectChannel = () => ({
       send: async () => {
         throw new Error("not implemented");

package/src/plugins/builtin/chat/message/profile-popover.test.tsx

@@ -0,0 +1,36 @@
+import { describe, expect, test } from "bun:test";
+import type { ChatUserSummary } from "../../../../api-client";
+import { hasPublicChatProfileInfo } from "./profile-popover";
+
+function makeUser(overrides: Partial<ChatUserSummary>): ChatUserSummary {
+  return {
+    id: "u1",
+    username: "vince",
+    displayName: "Vince",
+    profilePublic: true,
+    ...overrides,
+  };
+}
+
+describe("profile popover", () => {
+  test("treats public portfolio analytics as hover profile information", () => {
+    expect(hasPublicChatProfileInfo(makeUser({
+      bio: null,
+      company: null,
+      title: null,
+      portfolioAnalytics: {
+        oneYearReturn: 0.14,
+        spyBeta: 1.05,
+      },
+    }))).toBe(true);
+  });
+
+  test("hides analytics when the chat profile is private", () => {
+    expect(hasPublicChatProfileInfo(makeUser({
+      profilePublic: false,
+      portfolioAnalytics: {
+        oneYearReturn: 0.14,
+      },
+    }))).toBe(false);
+  });
+});