gloomberb 0.9.7 → 0.9.9

package/src/plugins/builtin/ticker-detail/data-panes.test.ts

@@ -1,9 +1,10 @@
 import { describe, expect, test } from "bun:test";
 import { buildRelationshipAnalysis, createRelationshipPaneTemplate } from "../correlation/relationship/pane";
 import { buildFundamentalGraphRows, buildValuationGraphRows } from "./data-panes/fundamental-graph";
+import { allMetricDefs, buildGraphBarSeries, graphRowsForFinancials } from "./data-panes/fundamental-graph/model";
 import { buildHistoricalPriceRows } from "./data-panes/historical-prices";
 import { createDefaultConfig } from "../../../types/config";
-import type { FinancialStatement, PricePoint } from "../../../types/financials";
+import type { FinancialStatement, PricePoint, TickerFinancials } from "../../../types/financials";
 
 describe("ticker data panes", () => {
   test("builds historical price rows with close-to-close changes", () => {
@@ -65,6 +66,55 @@ describe("ticker data panes", () => {
     ]);
   });
 
+  test("orders multi-symbol chart categories by statement date", () => {
+    const series = buildGraphBarSeries([
+      { key: "NVDA:2025-01-31", symbol: "NVDA", date: "2025-01-31", category: "2025 Q1", value: 1, growth: null, barWidth: 1 },
+      { key: "NVDA:2026-04-30", symbol: "NVDA", date: "2026-04-30", category: "2026 Q2", value: 2, growth: null, barWidth: 1 },
+      { key: "AMD:2024-12-31", symbol: "AMD", date: "2024-12-31", category: "2024 Q4", value: 3, growth: null, barWidth: 1 },
+    ]);
+
+    expect(series[0]?.points.map((point) => point.category)).toEqual(["2024 Q4", "2025 Q1", "2026 Q2"]);
+    expect(series[1]?.points.map((point) => point.category)).toEqual(["2024 Q4", "2025 Q1", "2026 Q2"]);
+  });
+
+  test("derives free cash flow and margins for graph metrics", () => {
+    const fcfRows = buildFundamentalGraphRows([
+      { date: "2025-03-31", operatingCashFlow: 100, capitalExpenditure: -25 },
+      { date: "2025-06-30", freeCashFlow: 90, operatingCashFlow: 120, capitalExpenditure: -30 },
+    ] satisfies FinancialStatement[], "freeCashFlow", "NVDA", "quarterly");
+    const marginRows = buildFundamentalGraphRows([
+      { date: "2025-03-31", totalRevenue: 200, grossProfit: 100 },
+    ] satisfies FinancialStatement[], "grossMargin", "AMD", "quarterly");
+
+    expect(fcfRows.map((row) => row.value)).toEqual([75, 90]);
+    expect(marginRows[0]?.value).toBe(0.5);
+    expect(allMetricDefs().map(({ definition }) => definition.key)).toContain("freeCashFlowMargin");
+  });
+
+  test("fills missing Q4 margin rows from annual totals and preceding quarters", () => {
+    const financials = {
+      annualStatements: [
+        { date: "2025-12-31", totalRevenue: 1_000, grossProfit: 500 },
+      ],
+      quarterlyStatements: [
+        { date: "2025-03-31", totalRevenue: 100, grossProfit: 40 },
+        { date: "2025-06-30", totalRevenue: 200, grossProfit: 90 },
+        { date: "2025-09-30", totalRevenue: 300, grossProfit: 150 },
+        { date: "2025-12-31" },
+      ],
+      priceHistory: [],
+    } satisfies TickerFinancials;
+
+    const rows = graphRowsForFinancials(financials, "fundamental", "grossMargin", "quarterly", "AMD");
+
+    expect(rows.map((row) => [row.category, row.value])).toEqual([
+      ["2025 Q1", 0.4],
+      ["2025 Q2", 0.45],
+      ["2025 Q3", 0.5],
+      ["2025 Q4", 220 / 400],
+    ]);
+  });
+
   test("builds valuation graph rows from available multiples", () => {
     const rows = buildValuationGraphRows({
       quote: { symbol: "AMD", price: 100, currency: "USD", change: 0, changePercent: 0, lastUpdated: 1, marketCap: 1_000 },
@@ -83,6 +133,50 @@ describe("ticker data panes", () => {
     ]);
   });
 
+  test("builds historical trailing and forward P/E rows from prices and EPS", () => {
+    const financials = {
+      quote: { symbol: "META", price: 320, currency: "USD", change: 0, changePercent: 0, lastUpdated: 1 },
+      fundamentals: { forwardPE: 16 },
+      annualStatements: [
+        { date: "2024-12-31", eps: 5 },
+        { date: "2025-12-31", eps: 10 },
+        { date: "2026-12-31", eps: 20 },
+      ],
+      quarterlyStatements: [
+        { date: "2025-03-31", eps: 1 },
+        { date: "2025-06-30", eps: 2 },
+        { date: "2025-09-30", eps: 3 },
+        { date: "2025-12-31", eps: 4 },
+        { date: "2026-03-31", eps: 5 },
+      ],
+      priceHistory: [
+        { date: new Date("2024-12-31T00:00:00Z"), close: 100 },
+        { date: new Date("2025-12-31T00:00:00Z"), close: 150 },
+        { date: new Date("2026-03-31T00:00:00Z"), close: 180 },
+        { date: new Date("2026-12-31T00:00:00Z"), close: 300 },
+      ],
+    } satisfies TickerFinancials;
+
+    const trailingAnnual = buildValuationGraphRows(financials, "trailingPE", "META", "annual");
+    const forwardAnnual = buildValuationGraphRows(financials, "forwardPE", "META", "annual");
+    const trailingQuarterly = buildValuationGraphRows(financials, "trailingPE", "META", "quarterly");
+
+    expect(trailingAnnual.map((row) => [row.category, row.value])).toEqual([
+      ["FY2024", 20],
+      ["FY2025", 15],
+      ["FY2026", 15],
+    ]);
+    expect(forwardAnnual.map((row) => [row.category, row.value])).toEqual([
+      ["FY2024", 10],
+      ["FY2025", 7.5],
+      ["Current", 16],
+    ]);
+    expect(trailingQuarterly.map((row) => [row.category, row.value])).toEqual([
+      ["2025 Q4", 15],
+      ["2026 Q1", 180 / 14],
+    ]);
+  });
+
   test("builds relationship analysis from overlapping price history", () => {
     const dates = ["2026-01-01", "2026-01-02", "2026-01-03", "2026-01-04", "2026-01-05", "2026-01-06"];
     const makeHistory = (closes: number[]) => dates.map((date, index) => ({

package/src/plugins/builtin/ticker-detail/financials/tab.tsx

@@ -274,13 +274,6 @@ export function ResolvedFinancialsTab({
     })),
   ];
   const rows = buildFinancialRows(subTab.rows, displayStatements, collapsedGroups);
-  const selectedIndex = selectedRowId
-    ? rows.findIndex((row) => row.id === selectedRowId)
-    : rows.length > 0 ? 0 : -1;
-  const effectiveSelectedIndex = selectedIndex >= 0
-    ? selectedIndex
-    : rows.length > 0 ? 0 : -1;
-
   useEffect(() => {
     if (rows.length === 0) {
       if (selectedRowId !== null) setSelectedRowId(null);

package/src/plugins/builtin/ticker-detail/index.tsx

@@ -5,6 +5,7 @@ import { normalizeTickerInput } from "../../../tickers/search";
 import { createTickerSurfacePaneTemplate } from "../shared/ticker-surface";
 import { TickerChartPane, ChartResearchTab } from "./chart-pane";
 import {
+  buildGraphPaneSettingsDef,
   createGraphPaneTemplate,
   FundamentalGraphPane,
   FundamentalGraphsResearchTab,
@@ -128,6 +129,7 @@ export const tickerDetailPlugin: GloomPlugin = {
       defaultPosition: "right",
       defaultMode: "floating",
       defaultFloatingSize: { width: 82, height: 22 },
+      settings: buildGraphPaneSettingsDef(),
     },
     {
       id: "provider-search-results",

package/src/plugins/builtin/ticker-detail/quote-monitor/index.test.tsx

@@ -13,10 +13,12 @@ import type { PinTickerOptions } from "../../../../types/plugin";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
 
-afterEach(() => {
+afterEach(async () => {
   setSharedMarketDataCoordinator(null);
   if (testSetup) {
-    testSetup.renderer.destroy();
+    await act(async () => {
+      testSetup!.renderer.destroy();
+    });
     testSetup = undefined;
   }
 });
@@ -181,44 +183,13 @@ async function renderOnce() {
 async function flushFrames(count: number) {
   for (let index = 0; index < count; index += 1) {
     await act(async () => {
-      await Promise.resolve();
+      await new Promise((resolve) => setTimeout(resolve, 0));
       await testSetup!.renderOnce();
     });
   }
 }
 
 describe("QuoteMonitorPane", () => {
-  test("renders a compact quote card for the bound ticker", async () => {
-    await renderHarness(createQuoteMonitorHarness(), {
-      width: 72,
-      height: 7,
-    });
-
-    await renderOnce();
-
-    const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("MSFT");
-    expect(frame).toContain("$356.15");
-    expect(frame).toContain("-2.68%");
-    expect(frame).toContain("-9.82");
-    expect(frame).toMatch(/[⠁-⣿]/);
-  });
-
-  test("renders multiple configured tickers", async () => {
-    await renderHarness(createQuoteMonitorHarness({ symbols: ["MSFT", "AAPL"] }), {
-      width: 72,
-      height: 8,
-    });
-
-    await renderOnce();
-
-    const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("MSFT");
-    expect(frame).toContain("AAPL");
-    expect(frame).toContain("$356.15");
-    expect(frame).toContain("$202.12");
-  });
-
   test("opens a Ticker Research pane on the second card click", async () => {
     const pinCalls: PinTickerCall[] = [];
     await renderHarness(createQuoteMonitorHarness({ pinCalls }), {

package/src/plugins/builtin/world-indices/index.tsx

@@ -9,7 +9,6 @@ import {
   buildFlatRows,
   DEFAULT_SORT_PREFERENCE,
   nextSortPreference,
-  rowIndicesOf,
   type IndexQuoteState,
   type QuoteMap,
   type WorldIndexSortPreference,
@@ -36,12 +35,9 @@ function WorldIndicesPane({ focused, width, height }: PaneProps) {
     () => buildFlatRows(indicesByRegion, sortPreference, quotes),
     [indicesByRegion, quotes, sortPreference],
   );
-  const navigableIndices = useMemo(() => rowIndicesOf(flatRows), [flatRows]);
   const selectedFlatIdx = selectedSymbol
     ? flatRows.findIndex((row) => row.type === "row" && row.entry.symbol === selectedSymbol)
     : -1;
-  const activeFlatIdx = selectedFlatIdx >= 0 ? selectedFlatIdx : (navigableIndices[0] ?? -1);
-
   useEffect(() => {
     if (selectedSymbol && selectedFlatIdx >= 0) return;
     const firstRow = flatRows.find((row) => row.type === "row");

package/src/plugins/builtin/world-indices/model.ts

@@ -87,13 +87,6 @@ export function buildFlatRows(
   return rows;
 }
 
-export function rowIndicesOf(flatRows: WorldIndexTableRow[]): number[] {
-  return flatRows.reduce<number[]>((acc, row, i) => {
-    if (row.type === "row") acc.push(i);
-    return acc;
-  }, []);
-}
-
 export function nextSortPreference(
   current: WorldIndexSortPreference,
   columnId: string,

package/src/plugins/ibkr/account-cache.ts

@@ -1,7 +1,7 @@
 import type { BrokerInstanceConfig } from "../../types/config";
 import type { CachePolicy } from "../../types/persistence";
 import { normalizeIbkrConfig } from "./config";
-import { fnv1aHashString } from "./hash";
+import { fnv1aHashString } from "../../utils/hash";
 
 const FLEX_ACCOUNT_CACHE_POLICY = {
   staleMs: 6 * 60 * 60 * 1000,

package/src/plugins/ibkr/gateway/market-data.ts

@@ -6,7 +6,7 @@ import {
 } from "@stoqey/ib";
 import type { QuoteSubscriptionTarget } from "../../../types/data-provider";
 import type { Quote } from "../../../types/financials";
-import { canonicalExchange, normalizeSymbol } from "../../../utils/exchanges";
+import { normalizeSymbol } from "../../../utils/exchanges";
 import type { IbkrGatewayConfig } from "./types";
 import { getIbkrPriceDivisor, normalizeIbkrPriceValue } from "./price-normalization";
 
@@ -35,7 +35,7 @@ export function normalizeQuoteStreamTarget(target: QuoteSubscriptionTarget): Quo
   return {
     ...target,
     symbol,
-    exchange: canonicalExchange(target.exchange),
+    exchange: target.exchange?.trim().toUpperCase() ?? "",
   };
 }
 
@@ -136,15 +136,22 @@ export function applyTickByTickAllLastToQuote(
   const nextPrice = normalizeIbkrPriceValue(tick.price, priceDivisor);
   if (nextPrice == null || nextPrice <= 0) return null;
 
-  const previousClose = current?.previousClose ?? current?.price ?? nextPrice;
-  const change = nextPrice - previousClose;
+  const canInferPreviousClose = current?.price != null
+    && current.change != null
+    && (current.change !== 0 || current.changePercent !== 0);
+  const inferredPreviousClose = current?.previousClose
+    ?? (canInferPreviousClose ? current.price - current.change : undefined);
+  const previousClose = inferredPreviousClose != null && Number.isFinite(inferredPreviousClose) && inferredPreviousClose > 0
+    ? inferredPreviousClose
+    : undefined;
+  const change = previousClose != null ? nextPrice - previousClose : current?.change ?? 0;
   return {
     symbol: current?.symbol ?? contract.localSymbol ?? contract.symbol ?? "",
     providerId: "ibkr",
     price: nextPrice,
     currency: current?.currency ?? contract.currency ?? "USD",
     change,
-    changePercent: previousClose ? (change / previousClose) * 100 : 0,
+    changePercent: previousClose ? (change / previousClose) * 100 : current?.changePercent ?? 0,
     previousClose,
     high52w: current?.high52w,
     low52w: current?.low52w,

package/src/plugins/ibkr/gateway/service/index.test.ts

@@ -312,6 +312,37 @@ describe("tick-by-tick quote updates", () => {
     expect(next?.lastUpdated).toBe(1_700_000_000_000);
   });
 
+  test("does not use the previous tick as the daily close when no close is known", () => {
+    const current = {
+      symbol: "AAPL",
+      providerId: "ibkr" as const,
+      price: 249,
+      currency: "USD",
+      change: 0,
+      changePercent: 0,
+      name: "Apple Inc.",
+      lastUpdated: 1000,
+      dataSource: "live" as const,
+    };
+    const tick: TickByTickAllLast = {
+      time: 1_700_000_000,
+      price: 250.5,
+      size: 100,
+      tickType: 1,
+      tickAttribLast: {},
+      exchange: "NASDAQ",
+      specialConditions: "",
+      contract: contract as any,
+    };
+
+    const next = applyTickByTickAllLastToQuote(current, contract as any, details, tick, 1, "live");
+
+    expect(next?.price).toBe(250.5);
+    expect(next?.previousClose).toBeUndefined();
+    expect(next?.change).toBe(0);
+    expect(next?.changePercent).toBe(0);
+  });
+
   test("applies bid/ask ticks without disturbing the current trade price", () => {
     const current = {
       symbol: "AAPL",

package/src/plugins/ibkr/portfolio-performance.ts

@@ -5,7 +5,7 @@ import type { BrokerPortfolioPerformance } from "../../types/trading";
 import { debugLog } from "../../utils/debug-log";
 import { loadFlexStatement, parseFlexPortfolioPerformance } from "./flex";
 import { normalizeIbkrConfig } from "./config";
-import { fnv1aHashString } from "./hash";
+import { fnv1aHashString } from "../../utils/hash";
 
 const PERFORMANCE_LOG = debugLog.createLogger("ibkr-performance");
 const PERFORMANCE_CACHE_KIND = "portfolio-performance";

package/src/plugins/ibkr/trade/utils.ts

@@ -5,6 +5,7 @@ import type { TickerRecord } from "../../../types/ticker";
 import type { BrokerAccount, BrokerOrderPreview, BrokerOrderType } from "../../../types/trading";
 import { colors } from "../../../theme/colors";
 import { formatCompact, formatCurrency } from "../../../utils/format";
+export { truncateWithEllipsis as truncateTradeText } from "../../../utils/text-wrap";
 import { formatMarketPrice, formatMarketPriceWithCurrency, formatSignedMarketPrice, type AssetDisplayContext } from "../../../market-data/market/format";
 import { getConfiguredIbkrGatewayInstances } from "../instance-selection";
 
@@ -108,13 +109,6 @@ export function formatPreviewMetric(before?: number, after?: number): string {
   return `${formatCompact(before || 0)} → ${formatCompact(after || 0)}`;
 }
 
-export function truncateTradeText(value: string, maxWidth: number): string {
-  if (maxWidth <= 0) return "";
-  if (value.length <= maxWidth) return value;
-  if (maxWidth <= 3) return value.slice(0, maxWidth);
-  return `${value.slice(0, maxWidth - 3)}...`;
-}
-
 export function findTickerForOrder(
   order: { contract: BrokerContractRef },
   tickers: Map<string, TickerRecord>,

package/src/plugins/loader.ts

@@ -1,12 +1,13 @@
 import { readdir } from "fs/promises";
 import { join } from "path";
 import { existsSync } from "fs";
+import { homedir } from "os";
 import type { GloomPlugin } from "../types/plugin";
 import { debugLog } from "../utils/debug-log";
 
 const loaderLog = debugLog.createLogger("plugin-loader");
 
-const PLUGINS_DIR = join(process.env.HOME || "~", ".gloomberb", "plugins");
+const PLUGINS_DIR = join(process.env.HOME || homedir(), ".gloomberb", "plugins");
 
 export interface LoadedExternalPlugin {
   plugin: GloomPlugin;

package/src/plugins/prediction-markets/detail.test.tsx

@@ -64,38 +64,4 @@ describe("prediction markets detail views", () => {
     expect(frame).not.toContain("Loading market detail...");
   });
 
-  test("renders book levels in the shared data table", async () => {
-    testSetup = await testRender(<GroupedDetailHarness detailTab="book" />, {
-      width: 64,
-      height: 24,
-    });
-    await flushFrames(testSetup);
-
-    const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("OUT");
-    expect(frame).toContain("SIDE");
-    expect(frame).toContain("PRICE");
-    expect(frame).toContain("SIZE");
-    expect(frame).toContain("YES");
-    expect(frame).toContain("BID");
-    expect(frame).toContain("47c");
-  });
-
-  test("renders recent trades in the shared data table", async () => {
-    testSetup = await testRender(<GroupedDetailHarness detailTab="trades" />, {
-      width: 64,
-      height: 24,
-    });
-    await flushFrames(testSetup);
-
-    const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("TIME");
-    expect(frame).toContain("SIDE");
-    expect(frame).toContain("OUT");
-    expect(frame).toContain("PRICE");
-    expect(frame).toContain("SIZE");
-    expect(frame).toContain("BUY");
-    expect(frame).toContain("YES");
-    expect(frame).toContain("48c");
-  });
 });

package/src/plugins/registry/context.ts

@@ -14,6 +14,7 @@ import type {
 } from "../../types/plugin";
 import type { PaneRuntimeState } from "../../core/state/app/state";
 import type { NewsQuery, NewsQueryState } from "../../types/news-source";
+import type { SyncContributor, SyncTransport } from "../../sync/types";
 import { debugLog } from "../../utils/debug-log";
 import { createPluginPersistence } from "../plugin-persistence";
 import type { PluginEvents } from "../event-bus";
@@ -35,6 +36,8 @@ export interface RegistryPluginContextOptions {
   updateLayout: (layout: LayoutConfig) => void;
   resolvePaneTarget: (paneId: string) => string | undefined;
   registerCapabilityForPlugin: (pluginId: string, capability: PluginCapability, items: PluginItems) => void;
+  registerSyncContributorForPlugin: (pluginId: string, contributor: SyncContributor) => () => void;
+  registerSyncTransportForPlugin: (pluginId: string, transport: SyncTransport) => () => void;
   watchNewsQuery: (query: NewsQuery, listener: (state: NewsQueryState) => void) => () => void;
   getData: (ticker: string) => TickerFinancials | null;
   getTicker: (symbol: string) => TickerRecord | null;
@@ -82,6 +85,8 @@ export function createRegistryPluginContext({
   updateLayout,
   resolvePaneTarget,
   registerCapabilityForPlugin,
+  registerSyncContributorForPlugin,
+  registerSyncTransportForPlugin,
   watchNewsQuery,
   getData,
   getTicker,
@@ -143,6 +148,16 @@ export function createRegistryPluginContext({
     registerShortcut: (shortcut) => contributions.registerShortcut(pluginId, shortcut, items),
     registerTickerAction: (action) => contributions.registerTickerAction(pluginId, action, items),
     registerContextMenuProvider: (provider) => contributions.registerContextMenuProvider(pluginId, provider, items),
+    registerSyncContributor: (contributor) => {
+      const dispose = registerSyncContributorForPlugin(pluginId, contributor);
+      items.eventDisposers.push(dispose);
+      return dispose;
+    },
+    registerSyncTransport: (transport) => {
+      const dispose = registerSyncTransportForPlugin(pluginId, transport);
+      items.eventDisposers.push(dispose);
+      return dispose;
+    },
     watchNewsQuery: (query, listener) => {
       const dispose = watchNewsQuery(query, listener);
       items.newsQueryWatchDisposers.push(dispose);

package/src/plugins/registry/contributions.ts

@@ -37,6 +37,11 @@ interface RegistryContributionsOptions {
   wrapBrokerAdapter?: (broker: BrokerAdapter, pluginId: string) => BrokerAdapter;
 }
 
+function setUnique<T>(map: Map<string, T>, id: string, value: T): void {
+  if (map.has(id)) throw new Error(`Duplicate plugin contribution id: ${id}`);
+  map.set(id, value);
+}
+
 export class RegistryContributions {
   readonly pluginItems = new Map<string, PluginItems>();
   readonly commandOwners = new Map<string, string>();
@@ -82,30 +87,30 @@ export class RegistryContributions {
   }
 
   registerPane(pluginId: string, pane: PaneDef, items = this.getOrCreatePluginItems(pluginId)): void {
-    this.panesMap.set(pane.id, this.options.wrapPaneDef(pluginId, pane));
+    setUnique(this.panesMap, pane.id, this.options.wrapPaneDef(pluginId, pane));
     this.paneOwners.set(pane.id, pluginId);
     items.panes.push(pane.id);
   }
 
   registerPaneTemplate(pluginId: string, template: PaneTemplateDef, items = this.getOrCreatePluginItems(pluginId)): void {
-    this.paneTemplatesMap.set(template.id, template);
+    setUnique(this.paneTemplatesMap, template.id, template);
     this.paneTemplateOwners.set(template.id, pluginId);
     items.paneTemplates.push(template.id);
   }
 
   registerCommand(pluginId: string, command: CommandDef, items = this.getOrCreatePluginItems(pluginId)): void {
-    this.commandsMap.set(command.id, command);
+    setUnique(this.commandsMap, command.id, command);
     this.commandOwners.set(command.id, pluginId);
     items.commands.push(command.id);
   }
 
   registerColumn(_pluginId: string, column: CustomColumnDef, items: PluginItems): void {
-    this.columnsMap.set(column.id, column);
+    setUnique(this.columnsMap, column.id, column);
     items.columns.push(column.id);
   }
 
   registerBroker(pluginId: string, broker: BrokerAdapter, items = this.getOrCreatePluginItems(pluginId)): void {
-    this.brokersMap.set(broker.id, this.options.wrapBrokerAdapter?.(broker, pluginId) ?? broker);
+    setUnique(this.brokersMap, broker.id, this.options.wrapBrokerAdapter?.(broker, pluginId) ?? broker);
     items.brokers.push(broker.id);
   }
 
@@ -115,19 +120,19 @@ export class RegistryContributions {
   }
 
   registerTickerResearchTab(pluginId: string, tab: TickerResearchTabDef, items = this.getOrCreatePluginItems(pluginId)): void {
-    this.tickerResearchTabsMap.set(tab.id, this.options.wrapTickerResearchTabDef(pluginId, tab));
+    setUnique(this.tickerResearchTabsMap, tab.id, this.options.wrapTickerResearchTabDef(pluginId, tab));
     this.tickerResearchTabOwners.set(tab.id, pluginId);
     items.tickerResearchTabs.push(tab.id);
   }
 
   registerShortcut(pluginId: string, shortcut: KeyboardShortcut, items = this.getOrCreatePluginItems(pluginId)): void {
-    this.shortcutsMap.set(shortcut.id, shortcut);
+    setUnique(this.shortcutsMap, shortcut.id, shortcut);
     this.shortcutOwners.set(shortcut.id, pluginId);
     items.shortcuts.push(shortcut.id);
   }
 
   registerTickerAction(_pluginId: string, action: TickerAction, items: PluginItems): void {
-    this.tickerActionsMap.set(action.id, action);
+    setUnique(this.tickerActionsMap, action.id, action);
     items.tickerActions.push(action.id);
   }
 
@@ -166,9 +171,15 @@ export class RegistryContributions {
     }
     for (const actionId of items.tickerActions) this.tickerActionsMap.delete(actionId);
     for (const providerKey of items.contextMenuProviders) this.contextMenuProvidersMap.delete(providerKey);
-    for (const dispose of items.eventDisposers) dispose();
-    for (const dispose of items.capabilityDisposers) dispose();
-    for (const dispose of items.newsQueryWatchDisposers) dispose();
+    let disposeError: unknown;
+    for (const dispose of [...items.eventDisposers, ...items.capabilityDisposers, ...items.newsQueryWatchDisposers]) {
+      try {
+        dispose();
+      } catch (error) {
+        disposeError ??= error;
+      }
+    }
     this.pluginItems.delete(pluginId);
+    if (disposeError) throw disposeError;
   }
 }

package/src/plugins/registry/index.test.ts

@@ -70,6 +70,49 @@ afterEach(() => {
   currentPersistence = null;
 });
 
+describe("PluginRegistry lifecycle", () => {
+  test("rolls back rejected registrations and always removes owned contributions", async () => {
+    const registry = createRegistry();
+    const pane = {
+      id: "shared-pane",
+      name: "Shared",
+      component: () => null,
+      defaultPosition: "right" as const,
+    };
+
+    await expect(registry.register({
+      id: "setup-failure",
+      name: "Setup failure",
+      version: "1.0.0",
+      panes: [pane],
+      setup: () => { throw new Error("setup failed"); },
+    })).rejects.toThrow("setup failed");
+    expect(registry.allPlugins.has("setup-failure")).toBe(false);
+    expect(registry.panes.has("shared-pane")).toBe(false);
+
+    await registry.register({ id: "owner", name: "Owner", version: "1.0.0", panes: [pane] });
+    await expect(registry.register({ id: "collision", name: "Collision", version: "1.0.0", panes: [pane] }))
+      .rejects.toThrow("Duplicate plugin contribution id");
+    expect(registry.panes.get("shared-pane")?.name).toBe("Shared");
+
+    await registry.register({
+      id: "throwing-dispose",
+      name: "Throwing dispose",
+      version: "1.0.0",
+      panes: [{
+        id: "disposable-pane",
+        name: "Disposable",
+        component: () => null,
+        defaultPosition: "right",
+      }],
+      dispose: () => { throw new Error("dispose failed"); },
+    });
+    expect(() => registry.unregister("throwing-dispose")).toThrow("dispose failed");
+    expect(registry.allPlugins.has("throwing-dispose")).toBe(false);
+    expect(registry.panes.has("disposable-pane")).toBe(false);
+  });
+});
+
 describe("PluginRegistry context menu providers", () => {
   test("registers and unregisters context menu providers", async () => {
     const registry = createRegistry();
@@ -234,6 +277,7 @@ describe("PluginRegistry pane settings", () => {
         settings: {},
       }],
       floating: [],
+      detached: [],
     };
     registry.getConfigFn = () => config;
     registry.getLayoutFn = () => config.layout;