eslint 8.0.0-beta.0 → 8.0.0

package/lib/rules/object-shorthand.js

@@ -28,7 +28,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow method and property shorthand syntax for object literals",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/object-shorthand"
         },
@@ -149,7 +148,6 @@ module.exports = {
          * @param {ASTNode} property Property AST node
          * @returns {boolean} True if the property can have a shorthand form
          * @private
-         *
          */
         function canHaveShorthand(property) {
             return (property.kind !== "set" && property.kind !== "get" && property.type !== "SpreadElement" && property.type !== "SpreadProperty" && property.type !== "ExperimentalSpreadProperty");
@@ -157,7 +155,7 @@ module.exports = {
 
         /**
          * Checks whether a node is a string literal.
-         * @param   {ASTNode} node Any AST node.
+         * @param {ASTNode} node Any AST node.
          * @returns {boolean} `true` if it is a string literal.
          */
         function isStringLiteral(node) {
@@ -169,7 +167,6 @@ module.exports = {
          * @param {ASTNode} property Property AST node
          * @returns {boolean} True if the property is considered shorthand, false if not.
          * @private
-         *
          */
         function isShorthand(property) {
 
@@ -182,7 +179,6 @@ module.exports = {
          * @param {ASTNode} property Property AST node
          * @returns {boolean} True if the key and value are named equally, false if not.
          * @private
-         *
          */
         function isRedundant(property) {
             const value = property.value;
@@ -199,10 +195,9 @@ module.exports = {
 
         /**
          * Ensures that an object's properties are consistently shorthand, or not shorthand at all.
-         * @param   {ASTNode} node Property AST node
-         * @param   {boolean} checkRedundancy Whether to check longform redundancy
+         * @param {ASTNode} node Property AST node
+         * @param {boolean} checkRedundancy Whether to check longform redundancy
          * @returns {void}
-         *
          */
         function checkConsistency(node, checkRedundancy) {
 

package/lib/rules/one-var-declaration-per-line.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow newlines around variable declarations",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/one-var-declaration-per-line"
         },

package/lib/rules/one-var.js

@@ -34,7 +34,6 @@ module.exports = {
 
         docs: {
             description: "enforce variables to be declared either together or separately in functions",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/one-var"
         },
@@ -209,7 +208,7 @@ module.exports = {
 
         /**
          * Determines the current scope (function or block)
-         * @param  {string} statementType node.kind, one of: "var", "let", or "const"
+         * @param {string} statementType node.kind, one of: "var", "let", or "const"
          * @returns {Object} The scope associated with statementType
          */
         function getCurrentScope(statementType) {

package/lib/rules/operator-assignment.js

@@ -17,8 +17,8 @@ const astUtils = require("./utils/ast-utils");
 /**
  * Checks whether an operator is commutative and has an operator assignment
  * shorthand form.
- * @param   {string}  operator Operator to check.
- * @returns {boolean}          True if the operator is commutative and has a
+ * @param {string} operator Operator to check.
+ * @returns {boolean} True if the operator is commutative and has a
  *     shorthand form.
  */
 function isCommutativeOperatorWithShorthand(operator) {
@@ -28,8 +28,8 @@ function isCommutativeOperatorWithShorthand(operator) {
 /**
  * Checks whether an operator is not commutative and has an operator assignment
  * shorthand form.
- * @param   {string}  operator Operator to check.
- * @returns {boolean}          True if the operator is not commutative and has
+ * @param {string} operator Operator to check.
+ * @returns {boolean} True if the operator is not commutative and has
  *     a shorthand form.
  */
 function isNonCommutativeOperatorWithShorthand(operator) {
@@ -63,7 +63,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow assignment operator shorthand where possible",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/operator-assignment"
         },
@@ -96,7 +95,7 @@ module.exports = {
 
         /**
          * Ensures that an assignment uses the shorthand form where possible.
-         * @param   {ASTNode} node An AssignmentExpression node.
+         * @param {ASTNode} node An AssignmentExpression node.
          * @returns {void}
          */
         function verify(node) {
@@ -149,7 +148,7 @@ module.exports = {
 
         /**
          * Warns if an assignment expression uses operator assignment shorthand.
-         * @param   {ASTNode} node An AssignmentExpression node.
+         * @param {ASTNode} node An AssignmentExpression node.
          * @returns {void}
          */
         function prohibit(node) {

package/lib/rules/operator-linebreak.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent linebreak style for operators",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/operator-linebreak"
         },

package/lib/rules/padded-blocks.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow padding within blocks",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/padded-blocks"
         },
@@ -167,6 +166,7 @@ module.exports = {
         /**
          * Checks if a node should be padded, according to the rule config.
          * @param {ASTNode} node The AST node to check.
+         * @throws {Error} (Unreachable)
          * @returns {boolean} True if the node should be padded, false otherwise.
          */
         function requirePaddingFor(node) {

package/lib/rules/padding-line-between-statements.js

@@ -431,7 +431,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow padding lines between statements",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/padding-line-between-statements"
         },

package/lib/rules/prefer-arrow-callback.js

@@ -60,6 +60,7 @@ function getVariableOfArguments(scope) {
 /**
  * Checks whether or not a given node is a callback.
  * @param {ASTNode} node A node to check.
+ * @throws {Error} (Unreachable.)
  * @returns {Object}
  *   {boolean} retv.isCallback - `true` if the node is a callback.
  *   {boolean} retv.isLexicalThis - `true` if the node is with `.bind(this)`.
@@ -150,7 +151,6 @@ module.exports = {
 
         docs: {
             description: "require using arrow functions for callbacks",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-arrow-callback"
         },

package/lib/rules/prefer-const.js

@@ -332,7 +332,6 @@ module.exports = {
 
         docs: {
             description: "require `const` declarations for variables that are never reassigned after declared",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-const"
         },

package/lib/rules/prefer-destructuring.js

@@ -26,7 +26,6 @@ module.exports = {
 
         docs: {
             description: "require destructuring from arrays and/or objects",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-destructuring"
         },
@@ -119,8 +118,8 @@ module.exports = {
         // Helpers
         //--------------------------------------------------------------------------
 
-        // eslint-disable-next-line jsdoc/require-description
         /**
+         * Checks if destructuring type should be checked.
          * @param {string} nodeType "AssignmentExpression" or "VariableDeclarator"
          * @param {string} destructuringType "array" or "object"
          * @returns {boolean} `true` if the destructuring type should be checked for the given node

package/lib/rules/prefer-exponentiation-operator.js

@@ -90,7 +90,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of `Math.pow` in favor of the `**` operator",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-exponentiation-operator"
         },

package/lib/rules/prefer-named-capture-group.js

@@ -33,7 +33,6 @@ module.exports = {
 
         docs: {
             description: "enforce using named capture group in regular expression",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-named-capture-group"
         },

package/lib/rules/prefer-numeric-literals.js

@@ -45,7 +45,6 @@ module.exports = {
 
         docs: {
             description: "disallow `parseInt()` and `Number.parseInt()` in favor of binary, octal, and hexadecimal literals",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-numeric-literals"
         },

package/lib/rules/prefer-object-spread.js

@@ -247,7 +247,6 @@ module.exports = {
         docs: {
             description:
                 "disallow using Object.assign with an object literal as the first argument and prefer the use of object spread instead.",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-object-spread"
         },

package/lib/rules/prefer-promise-reject-errors.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "require using Error objects as Promise rejection reasons",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-promise-reject-errors"
         },

package/lib/rules/prefer-reflect.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "require `Reflect` methods where applicable",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-reflect"
         },

package/lib/rules/prefer-regex-literals.js

@@ -54,7 +54,6 @@ module.exports = {
 
         docs: {
             description: "disallow use of the `RegExp` constructor in favor of regular expression literals",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-regex-literals"
         },

package/lib/rules/prefer-rest-params.js

@@ -65,7 +65,6 @@ module.exports = {
 
         docs: {
             description: "require rest parameters instead of `arguments`",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-rest-params"
         },

package/lib/rules/prefer-spread.js

@@ -49,7 +49,6 @@ module.exports = {
 
         docs: {
             description: "require spread operators instead of `.apply()`",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-spread"
         },

package/lib/rules/prefer-template.js

@@ -128,7 +128,6 @@ module.exports = {
 
         docs: {
             description: "require template literals instead of string concatenation",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/prefer-template"
         },

package/lib/rules/quote-props.js

@@ -22,7 +22,6 @@ module.exports = {
 
         docs: {
             description: "require quotes around object literal property names",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/quote-props"
         },
@@ -91,7 +90,7 @@ module.exports = {
 
         /**
          * Checks whether a certain string constitutes an ES3 token
-         * @param   {string} tokenStr The string to be checked.
+         * @param {string} tokenStr The string to be checked.
          * @returns {boolean} `true` if it is an ES3 token.
          */
         function isKeyword(tokenStr) {
@@ -100,9 +99,9 @@ module.exports = {
 
         /**
          * Checks if an espree-tokenized key has redundant quotes (i.e. whether quotes are unnecessary)
-         * @param   {string} rawKey The raw key value from the source
-         * @param   {espreeTokens} tokens The espree-tokenized node key
-         * @param   {boolean} [skipNumberLiterals=false] Indicates whether number literals should be checked
+         * @param {string} rawKey The raw key value from the source
+         * @param {espreeTokens} tokens The espree-tokenized node key
+         * @param {boolean} [skipNumberLiterals=false] Indicates whether number literals should be checked
          * @returns {boolean} Whether or not a key has redundant quotes.
          * @private
          */
@@ -139,7 +138,7 @@ module.exports = {
 
         /**
          * Ensures that a property's key is quoted only when necessary
-         * @param   {ASTNode} node Property AST node
+         * @param {ASTNode} node Property AST node
          * @returns {void}
          */
         function checkUnnecessaryQuotes(node) {
@@ -195,7 +194,7 @@ module.exports = {
 
         /**
          * Ensures that a property's key is quoted
-         * @param   {ASTNode} node Property AST node
+         * @param {ASTNode} node Property AST node
          * @returns {void}
          */
         function checkOmittedQuotes(node) {
@@ -213,8 +212,8 @@ module.exports = {
 
         /**
          * Ensures that an object's keys are consistently quoted, optionally checks for redundancy of quotes
-         * @param   {ASTNode} node Property AST node
-         * @param   {boolean} checkQuotesRedundancy Whether to check quotes' redundancy
+         * @param {ASTNode} node Property AST node
+         * @param {boolean} checkQuotesRedundancy Whether to check quotes' redundancy
          * @returns {void}
          */
         function checkConsistency(node, checkQuotesRedundancy) {

package/lib/rules/quotes.js

@@ -80,7 +80,6 @@ module.exports = {
 
         docs: {
             description: "enforce the consistent use of either backticks, double, or single quotes",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/quotes"
         },

package/lib/rules/radix.js

@@ -80,7 +80,6 @@ module.exports = {
 
         docs: {
             description: "enforce the consistent use of the radix argument when using `parseInt()`",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/radix"
         },

package/lib/rules/require-atomic-updates.js

@@ -79,6 +79,9 @@ function isLocalVariableWithoutEscape(variable, isMemberAccess) {
         reference.from.variableScope === functionScope);
 }
 
+/**
+ * Represents segment information.
+ */
 class SegmentInfo {
     constructor() {
         this.info = new WeakMap();
@@ -168,7 +171,6 @@ module.exports = {
 
         docs: {
             description: "disallow assignments that can lead to race conditions due to usage of `await` or `yield`",
-            category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/require-atomic-updates"
         },
@@ -177,7 +179,8 @@ module.exports = {
         schema: [],
 
         messages: {
-            nonAtomicUpdate: "Possible race condition: `{{value}}` might be reassigned based on an outdated value of `{{value}}`."
+            nonAtomicUpdate: "Possible race condition: `{{value}}` might be reassigned based on an outdated value of `{{value}}`.",
+            nonAtomicObjectUpdate: "Possible race condition: `{{value}}` might be assigned based on an outdated state of `{{object}}`."
         }
     },
 
@@ -273,13 +276,25 @@ module.exports = {
                         const variable = reference.resolved;
 
                         if (segmentInfo.isOutdated(codePath.currentSegments, variable)) {
-                            context.report({
-                                node: node.parent,
-                                messageId: "nonAtomicUpdate",
-                                data: {
-                                    value: sourceCode.getText(node.parent.left)
-                                }
-                            });
+                            if (node.parent.left === reference.identifier) {
+                                context.report({
+                                    node: node.parent,
+                                    messageId: "nonAtomicUpdate",
+                                    data: {
+                                        value: variable.name
+                                    }
+                                });
+                            } else {
+                                context.report({
+                                    node: node.parent,
+                                    messageId: "nonAtomicObjectUpdate",
+                                    data: {
+                                        value: sourceCode.getText(node.parent.left),
+                                        object: variable.name
+                                    }
+                                });
+                            }
+
                         }
                     }
                 }

package/lib/rules/require-await.js

@@ -34,7 +34,6 @@ module.exports = {
 
         docs: {
             description: "disallow async functions which have no `await` expression",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/require-await"
         },

package/lib/rules/require-jsdoc.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Rule to check for jsdoc presence.
  * @author Gyandeep Singh
+ * @deprecated in ESLint v5.10.0
  */
 "use strict";
 
@@ -10,7 +11,6 @@ module.exports = {
 
         docs: {
             description: "require JSDoc comments",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/require-jsdoc"
         },

package/lib/rules/require-unicode-regexp.js

@@ -26,7 +26,6 @@ module.exports = {
 
         docs: {
             description: "enforce the use of `u` flag on RegExp",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/require-unicode-regexp"
         },

package/lib/rules/require-yield.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "require generator functions to contain `yield`",
-            category: "ECMAScript 6",
             recommended: true,
             url: "https://eslint.org/docs/rules/require-yield"
         },

package/lib/rules/rest-spread-spacing.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce spacing between rest and spread operators and their expressions",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/rest-spread-spacing"
         },

package/lib/rules/semi-spacing.js

@@ -17,7 +17,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent spacing before and after semicolons",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/semi-spacing"
         },

package/lib/rules/semi-style.js

@@ -67,7 +67,6 @@ module.exports = {
 
         docs: {
             description: "enforce location of semicolons",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/semi-style"
         },

package/lib/rules/semi.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow semicolons instead of ASI",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/semi"
         },
@@ -78,6 +77,8 @@ module.exports = {
     create(context) {
 
         const OPT_OUT_PATTERN = /^[-[(/+`]/u; // One of [(/+-`
+        const unsafeClassFieldNames = new Set(["get", "set", "static"]);
+        const unsafeClassFieldFollowers = new Set(["*", "in", "instanceof"]);
         const options = context.options[1];
         const never = context.options[0] === "never";
         const exceptOneLine = Boolean(options && options.omitLastInOneLineBlock);
@@ -166,6 +167,55 @@ module.exports = {
             );
         }
 
+        /**
+         * Checks if a given PropertyDefinition node followed by a semicolon
+         * can safely remove that semicolon. It is not to safe to remove if
+         * the class field name is "get", "set", or "static", or if
+         * followed by a generator method.
+         * @param {ASTNode} node The node to check.
+         * @returns {boolean} `true` if the node cannot have the semicolon
+         *      removed.
+         */
+        function maybeClassFieldAsiHazard(node) {
+
+            if (node.type !== "PropertyDefinition") {
+                return false;
+            }
+
+            /*
+             * Computed property names and non-identifiers are always safe
+             * as they can be distinguished from keywords easily.
+             */
+            const needsNameCheck = !node.computed && node.key.type === "Identifier";
+
+            /*
+             * Certain names are problematic unless they also have a
+             * a way to distinguish between keywords and property
+             * names.
+             */
+            if (needsNameCheck && unsafeClassFieldNames.has(node.key.name)) {
+
+                /*
+                 * Special case: If the field name is `static`,
+                 * it is only valid if the field is marked as static,
+                 * so "static static" is okay but "static" is not.
+                 */
+                const isStaticStatic = node.static && node.key.name === "static";
+
+                /*
+                 * For other unsafe names, we only care if there is no
+                 * initializer. No initializer = hazard.
+                 */
+                if (!isStaticStatic && !node.value) {
+                    return true;
+                }
+            }
+
+            const followingToken = sourceCode.getTokenAfter(node);
+
+            return unsafeClassFieldFollowers.has(followingToken.value);
+        }
+
         /**
          * Check whether a given node is on the same line with the next token.
          * @param {Node} node A statement node to check.
@@ -204,9 +254,6 @@ module.exports = {
             if (isEndOfArrowBlock(sourceCode.getLastToken(node, 1))) {
                 return false;
             }
-            if (t === "PropertyDefinition") {
-                return Boolean(t.value);
-            }
 
             return true;
         }
@@ -236,10 +283,19 @@ module.exports = {
             if (isRedundantSemi(sourceCode.getLastToken(node))) {
                 return true; // `;;` or `;}`
             }
+            if (maybeClassFieldAsiHazard(node)) {
+                return false;
+            }
             if (isOnSameLineWithNextToken(node)) {
                 return false; // One liner.
             }
-            if (beforeStatementContinuationChars === "never" && !maybeAsiHazardAfter(node)) {
+
+            // continuation characters should not apply to class fields
+            if (
+                node.type !== "PropertyDefinition" &&
+                beforeStatementContinuationChars === "never" &&
+                !maybeAsiHazardAfter(node)
+            ) {
                 return true; // ASI works. This statement doesn't connect to the next.
             }
             if (!maybeAsiHazardBefore(sourceCode.getTokenAfter(node))) {
@@ -279,7 +335,11 @@ module.exports = {
             if (never) {
                 if (isSemi && canRemoveSemicolon(node)) {
                     report(node, true);
-                } else if (!isSemi && beforeStatementContinuationChars === "always" && maybeAsiHazardBefore(sourceCode.getTokenAfter(node))) {
+                } else if (
+                    !isSemi && beforeStatementContinuationChars === "always" &&
+                    node.type !== "PropertyDefinition" &&
+                    maybeAsiHazardBefore(sourceCode.getTokenAfter(node))
+                ) {
                     report(node);
                 }
             } else {

package/lib/rules/sort-imports.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce sorted import declarations within modules",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/sort-imports"
         },

package/lib/rules/sort-keys.js

@@ -81,7 +81,6 @@ module.exports = {
 
         docs: {
             description: "require object keys to be sorted",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/sort-keys"
         },

package/lib/rules/sort-vars.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "require variables within the same declaration block to be sorted",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/sort-vars"
         },