eslint 8.0.0-beta.0 → 8.0.0

package/lib/rules/no-new-func.js

@@ -5,6 +5,18 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const astUtils = require("./utils/ast-utils");
+
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+const callMethods = new Set(["apply", "bind", "call"]);
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -15,7 +27,6 @@ module.exports = {
 
         docs: {
             description: "disallow `new` operators with the `Function` object",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-new-func"
         },
@@ -38,14 +49,30 @@ module.exports = {
                     variable.references.forEach(ref => {
                         const node = ref.identifier;
                         const { parent } = node;
+                        let evalNode;
+
+                        if (parent) {
+                            if (node === parent.callee && (
+                                parent.type === "NewExpression" ||
+                                parent.type === "CallExpression"
+                            )) {
+                                evalNode = parent;
+                            } else if (
+                                parent.type === "MemberExpression" &&
+                                node === parent.object &&
+                                callMethods.has(astUtils.getStaticPropertyName(parent))
+                            ) {
+                                const maybeCallee = parent.parent.type === "ChainExpression" ? parent.parent : parent;
+
+                                if (maybeCallee.parent.type === "CallExpression" && maybeCallee.parent.callee === maybeCallee) {
+                                    evalNode = maybeCallee.parent;
+                                }
+                            }
+                        }
 
-                        if (
-                            parent &&
-                            (parent.type === "NewExpression" || parent.type === "CallExpression") &&
-                            node === parent.callee
-                        ) {
+                        if (evalNode) {
                             context.report({
-                                node: parent,
+                                node: evalNode,
                                 messageId: "noFunctionConstructor"
                             });
                         }

package/lib/rules/no-new-object.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "disallow `Object` constructors",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-new-object"
         },

package/lib/rules/no-new-require.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Rule to disallow use of new operator with the `require` function
  * @author Wil Moore III
+ * @deprecated in ESLint v7.0.0
  */
 
 "use strict";
@@ -19,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "disallow `new` operators with calls to `require`",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-new-require"
         },

package/lib/rules/no-new-symbol.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow `new` operators with the `Symbol` object",
-            category: "ECMAScript 6",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-new-symbol"
         },

package/lib/rules/no-new-wrappers.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow `new` operators with the `String`, `Number`, and `Boolean` objects",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-new-wrappers"
         },

package/lib/rules/no-new.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "disallow `new` operators outside of assignments or comparisons",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-new"
         },

package/lib/rules/no-nonoctal-decimal-escape.js

@@ -30,7 +30,6 @@ module.exports = {
 
         docs: {
             description: "disallow `\\8` and `\\9` escape sequences in string literals",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-nonoctal-decimal-escape"
         },

package/lib/rules/no-obj-calls.js

@@ -43,7 +43,6 @@ module.exports = {
 
         docs: {
             description: "disallow calling global object properties as functions",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-obj-calls"
         },

package/lib/rules/no-octal-escape.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow octal escape sequences in string literals",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-octal-escape"
         },

package/lib/rules/no-octal.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow octal literals",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-octal"
         },

package/lib/rules/no-param-reassign.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "disallow reassigning `function` parameters",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-param-reassign"
         },

package/lib/rules/no-path-concat.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Disallow string concatenation when using __dirname and __filename
  * @author Nicholas C. Zakas
+ * @deprecated in ESLint v7.0.0
  */
 "use strict";
 
@@ -18,7 +19,6 @@ module.exports = {
 
         docs: {
             description: "disallow string concatenation with `__dirname` and `__filename`",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-path-concat"
         },

package/lib/rules/no-plusplus.js

@@ -51,7 +51,6 @@ module.exports = {
 
         docs: {
             description: "disallow the unary operators `++` and `--`",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-plusplus"
         },

package/lib/rules/no-process-env.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Disallow the use of process.env()
  * @author Vignesh Anand
+ * @deprecated in ESLint v7.0.0
  */
 "use strict";
 
@@ -18,7 +19,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of `process.env`",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-process-env"
         },

package/lib/rules/no-process-exit.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Disallow the use of process.exit()
  * @author Nicholas C. Zakas
+ * @deprecated in ESLint v7.0.0
  */
 "use strict";
 
@@ -18,7 +19,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of `process.exit()`",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-process-exit"
         },

package/lib/rules/no-promise-executor-return.js

@@ -69,7 +69,6 @@ module.exports = {
 
         docs: {
             description: "disallow returning values from Promise executor functions",
-            category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-promise-executor-return"
         },

package/lib/rules/no-proto.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of the `__proto__` property",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-proto"
         },

package/lib/rules/no-prototype-builtins.js

@@ -20,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "disallow calling some `Object.prototype` methods directly on objects",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-prototype-builtins"
         },

package/lib/rules/no-redeclare.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "disallow variable redeclaration",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-redeclare"
         },

package/lib/rules/no-regex-spaces.js

@@ -39,7 +39,6 @@ module.exports = {
 
         docs: {
             description: "disallow multiple spaces in regular expressions",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-regex-spaces"
         },

package/lib/rules/no-restricted-exports.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow specified names in exports",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-restricted-exports"
         },

package/lib/rules/no-restricted-globals.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow specified global variables",
-            category: "Variables",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-restricted-globals"
         },
@@ -43,7 +42,7 @@ module.exports = {
 
         messages: {
             defaultMessage: "Unexpected use of '{{name}}'.",
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             customMessage: "Unexpected use of '{{name}}'. {{customMessage}}"
         }
     },

package/lib/rules/no-restricted-imports.js

@@ -79,26 +79,25 @@ module.exports = {
 
         docs: {
             description: "disallow specified modules when loaded by `import`",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-restricted-imports"
         },
 
         messages: {
             path: "'{{importSource}}' import is restricted from being used.",
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             pathWithCustomMessage: "'{{importSource}}' import is restricted from being used. {{customMessage}}",
 
             patterns: "'{{importSource}}' import is restricted from being used by a pattern.",
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             patternWithCustomMessage: "'{{importSource}}' import is restricted from being used by a pattern. {{customMessage}}",
 
             everything: "* import is invalid because '{{importNames}}' from '{{importSource}}' is restricted.",
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             everythingWithCustomMessage: "* import is invalid because '{{importNames}}' from '{{importSource}}' is restricted. {{customMessage}}",
 
             importName: "'{{importName}}' import from '{{importSource}}' is restricted.",
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             importNameWithCustomMessage: "'{{importName}}' import from '{{importSource}}' is restricted. {{customMessage}}"
         },
 
@@ -147,7 +146,7 @@ module.exports = {
             ? [{ matcher: ignore().add(restrictedPatterns) }]
             : restrictedPatterns.map(({ group, message }) => ({ matcher: ignore().add(group), customMessage: message }));
 
-        // if no imports are restricted we don"t need to check
+        // if no imports are restricted we don't need to check
         if (Object.keys(restrictedPaths).length === 0 && restrictedPatternGroups.length === 0) {
             return {};
         }

package/lib/rules/no-restricted-modules.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Restrict usage of specified node modules.
  * @author Christian Schulz
+ * @deprecated in ESLint v7.0.0
  */
 "use strict";
 
@@ -48,7 +49,6 @@ module.exports = {
 
         docs: {
             description: "disallow specified modules when loaded by `require`",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-restricted-modules"
         },
@@ -73,7 +73,7 @@ module.exports = {
 
         messages: {
             defaultMessage: "'{{name}}' module is restricted from being used.",
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             customMessage: "'{{name}}' module is restricted from being used. {{customMessage}}",
             patternMessage: "'{{name}}' module is restricted from being used by a pattern."
         }
@@ -97,7 +97,7 @@ module.exports = {
             return memo;
         }, {});
 
-        // if no imports are restricted we don"t need to check
+        // if no imports are restricted we don't need to check
         if (Object.keys(restrictedPaths).length === 0 && restrictedPatterns.length === 0) {
             return {};
         }

package/lib/rules/no-restricted-properties.js

@@ -17,7 +17,6 @@ module.exports = {
 
         docs: {
             description: "disallow certain properties on certain objects",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-restricted-properties"
         },
@@ -64,9 +63,9 @@ module.exports = {
         },
 
         messages: {
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             restrictedObjectProperty: "'{{objectName}}.{{propertyName}}' is restricted from being used.{{message}}",
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             restrictedProperty: "'{{propertyName}}' is restricted from being used.{{message}}"
         }
     },

package/lib/rules/no-restricted-syntax.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow specified syntax",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-restricted-syntax"
         },
@@ -42,7 +41,7 @@ module.exports = {
         },
 
         messages: {
-            // eslint-disable-next-line eslint-plugin/report-message-format
+            // eslint-disable-next-line eslint-plugin/report-message-format -- Custom message might not end in a period
             restrictedSyntax: "{{message}}"
         }
     },

package/lib/rules/no-return-assign.js

@@ -26,7 +26,6 @@ module.exports = {
 
         docs: {
             description: "disallow assignment operators in `return` statements",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-return-assign"
         },

package/lib/rules/no-return-await.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "disallow unnecessary `return await`",
-            category: "Best Practices",
 
             recommended: false,
 

package/lib/rules/no-script-url.js

@@ -2,8 +2,7 @@
  * @fileoverview Rule to flag when using javascript: urls
  * @author Ilya Volodin
  */
-/* jshint scripturl: true */
-/* eslint no-script-url: 0 */
+/* eslint no-script-url: 0 -- Code is checking to report such URLs */
 
 "use strict";
 
@@ -19,7 +18,6 @@ module.exports = {
 
         docs: {
             description: "disallow `javascript:` urls",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-script-url"
         },

package/lib/rules/no-self-assign.js

@@ -130,7 +130,6 @@ module.exports = {
 
         docs: {
             description: "disallow assignments where both sides are exactly the same",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-self-assign"
         },

package/lib/rules/no-self-compare.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "disallow comparisons where both sides are exactly the same",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-self-compare"
         },

package/lib/rules/no-sequences.js

@@ -29,7 +29,6 @@ module.exports = {
 
         docs: {
             description: "disallow comma operators",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-sequences"
         },

package/lib/rules/no-setter-return.js

@@ -142,7 +142,6 @@ module.exports = {
 
         docs: {
             description: "disallow returning values from setters",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-setter-return"
         },

package/lib/rules/no-shadow-restricted-names.js

@@ -27,7 +27,6 @@ module.exports = {
 
         docs: {
             description: "disallow identifiers from shadowing restricted names",
-            category: "Variables",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-shadow-restricted-names"
         },

package/lib/rules/no-shadow.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "disallow variable declarations from shadowing variables declared in the outer scope",
-            category: "Variables",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-shadow"
         },
@@ -59,7 +58,7 @@ module.exports = {
 
         /**
          * Check if variable name is allowed.
-         * @param  {ASTNode} variable The variable to check.
+         * @param {ASTNode} variable The variable to check.
          * @returns {boolean} Whether or not the variable name is allowed.
          */
         function isAllowed(variable) {

package/lib/rules/no-spaced-func.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "disallow spacing between function identifiers and their applications (deprecated)",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-spaced-func"
         },

package/lib/rules/no-sparse-arrays.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow sparse arrays",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-sparse-arrays"
         },

package/lib/rules/no-sync.js

@@ -1,10 +1,9 @@
 /**
  * @fileoverview Rule to check for properties whose identifier ends with the string Sync
  * @author Matt DuVall<http://mattduvall.com/>
+ * @deprecated in ESLint v7.0.0
  */
 
-/* jshint node:true */
-
 "use strict";
 
 //------------------------------------------------------------------------------
@@ -21,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "disallow synchronous methods",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-sync"
         },

package/lib/rules/no-tabs.js

@@ -22,7 +22,6 @@ module.exports = {
 
         docs: {
             description: "disallow all tabs",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-tabs"
         },

package/lib/rules/no-template-curly-in-string.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow template literal placeholder syntax in regular strings",
-            category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-template-curly-in-string"
         },

package/lib/rules/no-ternary.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow ternary operators",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-ternary"
         },

package/lib/rules/no-this-before-super.js

@@ -40,7 +40,6 @@ module.exports = {
 
         docs: {
             description: "disallow `this`/`super` before calling `super()` in constructors",
-            category: "ECMAScript 6",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-this-before-super"
         },

package/lib/rules/no-throw-literal.js

@@ -17,7 +17,6 @@ module.exports = {
 
         docs: {
             description: "disallow throwing literals as exceptions",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-throw-literal"
         },

package/lib/rules/no-trailing-spaces.js

@@ -20,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "disallow trailing whitespace at the end of lines",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-trailing-spaces"
         },