eslint 8.0.0-beta.0 → 8.0.0

package/lib/rules/no-undef-init.js

@@ -17,7 +17,6 @@ module.exports = {
 
         docs: {
             description: "disallow initializing variables to `undefined`",
-            category: "Variables",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-undef-init"
         },
@@ -34,88 +33,37 @@ module.exports = {
 
         const sourceCode = context.getSourceCode();
 
-        /**
-         * Get the node of init target.
-         * @param {ASTNode} node The node to get.
-         * @returns {ASTNode} The node of init target.
-         */
-        function getIdNode(node) {
-            switch (node.type) {
-                case "VariableDeclarator":
-                    return node.id;
-                case "PropertyDefinition":
-                    return node.key;
-                default:
-                    throw new Error("unreachable");
-            }
-        }
-
-        /**
-         * Get the node of init value.
-         * @param {ASTNode} node The node to get.
-         * @returns {ASTNode} The node of init value.
-         */
-        function getInitNode(node) {
-            switch (node.type) {
-                case "VariableDeclarator":
-                    return node.init;
-                case "PropertyDefinition":
-                    return node.value;
-                default:
-                    throw new Error("unreachable");
-            }
-        }
-
-        /**
-         * Get the parent kind of the node.
-         * @param {ASTNode} node The node to get.
-         * @returns {string} The parent kind.
-         */
-        function getParentKind(node) {
-            switch (node.type) {
-                case "VariableDeclarator":
-                    return node.parent.kind;
-                case "PropertyDefinition":
-                    return "field";
-                default:
-                    throw new Error("unreachable");
-            }
-        }
-
         return {
 
-            "VariableDeclarator, PropertyDefinition"(node) {
-                const idNode = getIdNode(node),
-                    name = sourceCode.getText(idNode),
-                    initNode = getInitNode(node),
-                    initIsUndefined = initNode && initNode.type === "Identifier" && initNode.name === "undefined",
-                    parentKind = getParentKind(node),
+            VariableDeclarator(node) {
+                const name = sourceCode.getText(node.id),
+                    init = node.init && node.init.name,
                     scope = context.getScope(),
                     undefinedVar = astUtils.getVariableByName(scope, "undefined"),
                     shadowed = undefinedVar && undefinedVar.defs.length > 0,
-                    lastToken = sourceCode.getLastToken(node, astUtils.isNotSemicolonToken);
+                    lastToken = sourceCode.getLastToken(node);
 
-                if (initIsUndefined && parentKind !== "const" && !shadowed) {
+                if (init === "undefined" && node.parent.kind !== "const" && !shadowed) {
                     context.report({
                         node,
                         messageId: "unnecessaryUndefinedInit",
                         data: { name },
                         fix(fixer) {
-                            if (parentKind === "var") {
+                            if (node.parent.kind === "var") {
                                 return null;
                             }
 
-                            if (idNode.type === "ArrayPattern" || idNode.type === "ObjectPattern") {
+                            if (node.id.type === "ArrayPattern" || node.id.type === "ObjectPattern") {
 
                                 // Don't fix destructuring assignment to `undefined`.
                                 return null;
                             }
 
-                            if (sourceCode.commentsExistBetween(idNode, lastToken)) {
+                            if (sourceCode.commentsExistBetween(node.id, lastToken)) {
                                 return null;
                             }
 
-                            return fixer.removeRange([idNode.range[1], lastToken.range[1]]);
+                            return fixer.removeRange([node.id.range[1], node.range[1]]);
                         }
                     });
                 }

package/lib/rules/no-undef.js

@@ -29,7 +29,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of undeclared variables unless mentioned in `/*global */` comments",
-            category: "Variables",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-undef"
         },

package/lib/rules/no-undefined.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of `undefined` as an identifier",
-            category: "Variables",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-undefined"
         },

package/lib/rules/no-underscore-dangle.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow dangling underscores in identifiers",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-underscore-dangle"
         },

package/lib/rules/no-unexpected-multiline.js

@@ -20,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "disallow confusing multiline expressions",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-unexpected-multiline"
         },

package/lib/rules/no-unmodified-loop-condition.js

@@ -162,7 +162,6 @@ module.exports = {
 
         docs: {
             description: "disallow unmodified loop conditions",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-unmodified-loop-condition"
         },

package/lib/rules/no-unneeded-ternary.js

@@ -29,7 +29,6 @@ module.exports = {
 
         docs: {
             description: "disallow ternary operators when simpler alternatives exist",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-unneeded-ternary"
         },

package/lib/rules/no-unreachable-loop.js

@@ -59,7 +59,6 @@ module.exports = {
 
         docs: {
             description: "disallow loops with a body that allows only one iteration",
-            category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-unreachable-loop"
         },

package/lib/rules/no-unreachable.js

@@ -9,9 +9,8 @@
 //------------------------------------------------------------------------------
 
 /**
- * @typedef {Object} ClassInfo
- * @property {ClassInfo | null} upper The class info that encloses this class.
- * @property {boolean} hasConstructor The flag about having user-defined constructor.
+ * @typedef {Object} ConstructorInfo
+ * @property {ConstructorInfo | null} upper Info about the constructor that encloses this constructor.
  * @property {boolean} hasSuperCall The flag about having `super()` expressions.
  */
 
@@ -112,7 +111,6 @@ module.exports = {
 
         docs: {
             description: "disallow unreachable code after `return`, `throw`, `continue`, and `break` statements",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-unreachable"
         },
@@ -127,8 +125,8 @@ module.exports = {
     create(context) {
         let currentCodePath = null;
 
-        /** @type {ClassInfo | null} */
-        let classInfo = null;
+        /** @type {ConstructorInfo | null} */
+        let constructorInfo = null;
 
         /** @type {ConsecutiveRange} */
         const range = new ConsecutiveRange(context.getSourceCode());
@@ -225,36 +223,39 @@ module.exports = {
                 reportIfUnreachable();
             },
 
-            // Address class fields.
-            "ClassDeclaration, ClassExpression"() {
-                classInfo = {
-                    upper: classInfo,
-                    hasConstructor: false,
+            /*
+             * Instance fields defined in a subclass are never created if the constructor of the subclass
+             * doesn't call `super()`, so their definitions are unreachable code.
+             */
+            "MethodDefinition[kind='constructor']"() {
+                constructorInfo = {
+                    upper: constructorInfo,
                     hasSuperCall: false
                 };
             },
-            "ClassDeclaration, ClassExpression:exit"(node) {
-                const { hasConstructor, hasSuperCall } = classInfo;
-                const hasExtends = Boolean(node.superClass);
+            "MethodDefinition[kind='constructor']:exit"(node) {
+                const { hasSuperCall } = constructorInfo;
+
+                constructorInfo = constructorInfo.upper;
+
+                // skip typescript constructors without the body
+                if (!node.value.body) {
+                    return;
+                }
 
-                classInfo = classInfo.upper;
+                const classDefinition = node.parent.parent;
 
-                if (hasConstructor && hasExtends && !hasSuperCall) {
-                    for (const element of node.body.body) {
-                        if (element.type === "PropertyDefinition") {
+                if (classDefinition.superClass && !hasSuperCall) {
+                    for (const element of classDefinition.body.body) {
+                        if (element.type === "PropertyDefinition" && !element.static) {
                             reportIfUnreachable(element);
                         }
                     }
                 }
             },
-            "MethodDefinition[kind='constructor']"() {
-                if (classInfo) {
-                    classInfo.hasConstructor = true;
-                }
-            },
             "CallExpression > Super.callee"() {
-                if (classInfo) {
-                    classInfo.hasSuperCall = true;
+                if (constructorInfo) {
+                    constructorInfo.hasSuperCall = true;
                 }
             }
         };

package/lib/rules/no-unsafe-finally.js

@@ -24,7 +24,6 @@ module.exports = {
 
         docs: {
             description: "disallow control flow statements in `finally` blocks",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-unsafe-finally"
         },

package/lib/rules/no-unsafe-negation.js

@@ -52,7 +52,6 @@ module.exports = {
 
         docs: {
             description: "disallow negating the left operand of relational operators",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-unsafe-negation"
         },

package/lib/rules/no-unsafe-optional-chaining.js

@@ -24,7 +24,6 @@ module.exports = {
 
         docs: {
             description: "disallow use of optional chaining in contexts where the `undefined` value is not allowed",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-unsafe-optional-chaining"
         },

package/lib/rules/no-unused-expressions.js

@@ -30,7 +30,6 @@ module.exports = {
 
         docs: {
             description: "disallow unused expressions",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-unused-expressions"
         },
@@ -72,8 +71,8 @@ module.exports = {
             allowTaggedTemplates = config.allowTaggedTemplates || false,
             enforceForJSX = config.enforceForJSX || false;
 
-        // eslint-disable-next-line jsdoc/require-description
         /**
+         * Has AST suggesting a directive.
          * @param {ASTNode} node any node
          * @returns {boolean} whether the given node structurally represents a directive
          */
@@ -82,8 +81,8 @@ module.exports = {
                 node.expression.type === "Literal" && typeof node.expression.value === "string";
         }
 
-        // eslint-disable-next-line jsdoc/require-description
         /**
+         * Gets the leading sequence of members in a list that pass the predicate.
          * @param {Function} predicate ([a] -> Boolean) the function used to make the determination
          * @param {a[]} list the input list
          * @returns {a[]} the leading sequence of members in the given list that pass the given predicate
@@ -97,8 +96,8 @@ module.exports = {
             return list.slice();
         }
 
-        // eslint-disable-next-line jsdoc/require-description
         /**
+         * Gets leading directives nodes in a Node body.
          * @param {ASTNode} node a Program or BlockStatement node
          * @returns {ASTNode[]} the leading sequence of directive nodes in the given node's body
          */
@@ -106,8 +105,8 @@ module.exports = {
             return takeWhile(looksLikeDirective, node.body);
         }
 
-        // eslint-disable-next-line jsdoc/require-description
         /**
+         * Detect if a Node is a directive.
          * @param {ASTNode} node any node
          * @param {ASTNode[]} ancestors the given node's ancestors
          * @returns {boolean} whether the given node is considered a directive in its current position

package/lib/rules/no-unused-labels.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow unused labels",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-unused-labels"
         },

package/lib/rules/no-unused-vars.js

@@ -33,7 +33,6 @@ module.exports = {
 
         docs: {
             description: "disallow unused variables",
-            category: "Variables",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-unused-vars"
         },
@@ -295,6 +294,31 @@ module.exports = {
             );
         }
 
+        /**
+         * Checks whether a given node is unused expression or not.
+         * @param {ASTNode} node The node itself
+         * @returns {boolean} The node is an unused expression.
+         * @private
+         */
+        function isUnusedExpression(node) {
+            const parent = node.parent;
+
+            if (parent.type === "ExpressionStatement") {
+                return true;
+            }
+
+            if (parent.type === "SequenceExpression") {
+                const isLastExpression = parent.expressions[parent.expressions.length - 1] === node;
+
+                if (!isLastExpression) {
+                    return true;
+                }
+                return isUnusedExpression(parent);
+            }
+
+            return false;
+        }
+
         /**
          * If a given reference is left-hand side of an assignment, this gets
          * the right-hand side node of the assignment.
@@ -313,7 +337,6 @@ module.exports = {
         function getRhsNode(ref, prevRhsNode) {
             const id = ref.identifier;
             const parent = id.parent;
-            const grandparent = parent.parent;
             const refScope = ref.from.variableScope;
             const varScope = ref.resolved.scope.variableScope;
             const canBeUsedLater = refScope !== varScope || astUtils.isInLoop(id);
@@ -327,7 +350,7 @@ module.exports = {
             }
 
             if (parent.type === "AssignmentExpression" &&
-                grandparent.type === "ExpressionStatement" &&
+                isUnusedExpression(parent) &&
                 id === parent.left &&
                 !canBeUsedLater
             ) {
@@ -410,31 +433,6 @@ module.exports = {
             );
         }
 
-        /**
-         * Checks whether a given node is unused expression or not.
-         * @param {ASTNode} node The node itself
-         * @returns {boolean} The node is an unused expression.
-         * @private
-         */
-        function isUnusedExpression(node) {
-            const parent = node.parent;
-
-            if (parent.type === "ExpressionStatement") {
-                return true;
-            }
-
-            if (parent.type === "SequenceExpression") {
-                const isLastExpression = parent.expressions[parent.expressions.length - 1] === node;
-
-                if (!isLastExpression) {
-                    return true;
-                }
-                return isUnusedExpression(parent);
-            }
-
-            return false;
-        }
-
         /**
          * Checks whether a given reference is a read to update itself or not.
          * @param {eslint-scope.Reference} ref A reference to check.

package/lib/rules/no-use-before-define.js

@@ -135,7 +135,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of variables before they are defined",
-            category: "Variables",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-use-before-define"
         },

package/lib/rules/no-useless-backreference.js

@@ -64,7 +64,6 @@ module.exports = {
 
         docs: {
             description: "disallow useless backreferences in regular expressions",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-useless-backreference"
         },

package/lib/rules/no-useless-call.js

@@ -55,7 +55,6 @@ module.exports = {
 
         docs: {
             description: "disallow unnecessary calls to `.call()` and `.apply()`",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-useless-call"
         },

package/lib/rules/no-useless-catch.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow unnecessary `catch` clauses",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-useless-catch"
         },

package/lib/rules/no-useless-computed-key.js

@@ -36,6 +36,7 @@ const astUtils = require("./utils/ast-utils");
  *   - class C { static ["prototype"]() {} } produces a runtime error (doesn't break the whole script)
  *     class C { static "prototype"() {} } produces a parsing error (breaks the whole script)
  * @param {ASTNode} node The node to check. It can be `Property`, `PropertyDefinition` or `MethodDefinition`.
+ * @throws {Error} (Unreachable.)
  * @returns {void} `true` if the node has useless computed key.
  */
 function hasUselessComputedKey(node) {
@@ -90,7 +91,6 @@ module.exports = {
 
         docs: {
             description: "disallow unnecessary computed property keys in objects and classes",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-useless-computed-key"
         },

package/lib/rules/no-useless-concat.js

@@ -70,7 +70,6 @@ module.exports = {
 
         docs: {
             description: "disallow unnecessary concatenation of literals or template literals",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-useless-concat"
         },

package/lib/rules/no-useless-constructor.js

@@ -138,7 +138,6 @@ module.exports = {
 
         docs: {
             description: "disallow unnecessary constructors",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-useless-constructor"
         },

package/lib/rules/no-useless-escape.js

@@ -34,16 +34,17 @@ const REGEX_NON_CHARCLASS_ESCAPES = union(REGEX_GENERAL_ESCAPES, new Set("^/.$*+
  * @returns {Object[]} A list of characters, each with info on escaping and whether they're in a character class.
  * @example
  *
- * parseRegExp('a\\b[cd-]')
+ * parseRegExp("a\\b[cd-]");
  *
- * returns:
+ * // returns:
  * [
- *   {text: 'a', index: 0, escaped: false, inCharClass: false, startsCharClass: false, endsCharClass: false},
- *   {text: 'b', index: 2, escaped: true, inCharClass: false, startsCharClass: false, endsCharClass: false},
- *   {text: 'c', index: 4, escaped: false, inCharClass: true, startsCharClass: true, endsCharClass: false},
- *   {text: 'd', index: 5, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false},
- *   {text: '-', index: 6, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false}
- * ]
+ *     { text: "a", index: 0, escaped: false, inCharClass: false, startsCharClass: false, endsCharClass: false },
+ *     { text: "b", index: 2, escaped: true, inCharClass: false, startsCharClass: false, endsCharClass: false },
+ *     { text: "c", index: 4, escaped: false, inCharClass: true, startsCharClass: true, endsCharClass: false },
+ *     { text: "d", index: 5, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false },
+ *     { text: "-", index: 6, escaped: false, inCharClass: true, startsCharClass: false, endsCharClass: false }
+ * ];
+ *
  */
 function parseRegExp(regExpText) {
     const charList = [];
@@ -83,7 +84,6 @@ module.exports = {
 
         docs: {
             description: "disallow unnecessary escape characters",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-useless-escape"
         },

package/lib/rules/no-useless-rename.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "disallow renaming import, export, and destructured assignments to the same name",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-useless-rename"
         },

package/lib/rules/no-useless-return.js

@@ -67,7 +67,6 @@ module.exports = {
 
         docs: {
             description: "disallow redundant return statements",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-useless-return"
         },

package/lib/rules/no-var.js

@@ -185,7 +185,6 @@ module.exports = {
 
         docs: {
             description: "require `let` or `const` instead of `var`",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-var"
         },

package/lib/rules/no-void.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow `void` operators",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-void"
         },

package/lib/rules/no-warning-comments.js

@@ -20,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "disallow specified warning terms in comments",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-warning-comments"
         },

package/lib/rules/no-whitespace-before-property.js

@@ -20,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "disallow whitespace before properties",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-whitespace-before-property"
         },

package/lib/rules/no-with.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow `with` statements",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-with"
         },

package/lib/rules/nonblock-statement-body-position.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "enforce the location of single-line statements",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/nonblock-statement-body-position"
         },

package/lib/rules/object-curly-newline.js

@@ -150,7 +150,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent line breaks after opening and before closing braces",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/object-curly-newline"
         },

package/lib/rules/object-curly-spacing.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent spacing inside braces",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/object-curly-spacing"
         },

package/lib/rules/object-property-newline.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce placing object properties on separate lines",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/object-property-newline"
         },