eslint 8.0.0-beta.0 → 8.0.0

package/lib/rules/comma-spacing.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent spacing before and after commas",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/comma-spacing"
         },

package/lib/rules/comma-style.js

@@ -17,7 +17,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent comma style",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/comma-style"
         },

package/lib/rules/complexity.js

@@ -23,7 +23,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum cyclomatic complexity allowed in a program",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/complexity"
         },
@@ -75,60 +74,16 @@ module.exports = {
         // Helpers
         //--------------------------------------------------------------------------
 
-        // Using a stack to store complexity (handling nested functions)
-        const fns = [];
+        // Using a stack to store complexity per code path
+        const complexities = [];
 
         /**
-         * When parsing a new function, store it in our function stack
-         * @returns {void}
-         * @private
-         */
-        function startFunction() {
-            fns.push(1);
-        }
-
-        /**
-         * Evaluate the node at the end of function
-         * @param {ASTNode} node node to evaluate
-         * @returns {void}
-         * @private
-         */
-        function endFunction(node) {
-            const name = upperCaseFirst(astUtils.getFunctionNameWithKind(node));
-            const complexity = fns.pop();
-
-            if (complexity > THRESHOLD) {
-                context.report({
-                    node,
-                    messageId: "complex",
-                    data: { name, complexity, max: THRESHOLD }
-                });
-            }
-        }
-
-        /**
-         * Increase the complexity of the function in context
+         * Increase the complexity of the code path in context
          * @returns {void}
          * @private
          */
         function increaseComplexity() {
-            if (fns.length) {
-                fns[fns.length - 1]++;
-            }
-        }
-
-        /**
-         * Increase the switch complexity in context
-         * @param {ASTNode} node node to evaluate
-         * @returns {void}
-         * @private
-         */
-        function increaseSwitchComplexity(node) {
-
-            // Avoiding `default`
-            if (node.test) {
-                increaseComplexity();
-            }
+            complexities[complexities.length - 1]++;
         }
 
         //--------------------------------------------------------------------------
@@ -136,13 +91,14 @@ module.exports = {
         //--------------------------------------------------------------------------
 
         return {
-            FunctionDeclaration: startFunction,
-            FunctionExpression: startFunction,
-            ArrowFunctionExpression: startFunction,
-            "FunctionDeclaration:exit": endFunction,
-            "FunctionExpression:exit": endFunction,
-            "ArrowFunctionExpression:exit": endFunction,
 
+            onCodePathStart() {
+
+                // The initial complexity is 1, representing one execution path in the CodePath
+                complexities.push(1);
+            },
+
+            // Each branching in the code adds 1 to the complexity
             CatchClause: increaseComplexity,
             ConditionalExpression: increaseComplexity,
             LogicalExpression: increaseComplexity,
@@ -150,14 +106,49 @@ module.exports = {
             ForInStatement: increaseComplexity,
             ForOfStatement: increaseComplexity,
             IfStatement: increaseComplexity,
-            SwitchCase: increaseSwitchComplexity,
             WhileStatement: increaseComplexity,
             DoWhileStatement: increaseComplexity,
 
+            // Avoid `default`
+            "SwitchCase[test]": increaseComplexity,
+
+            // Logical assignment operators have short-circuiting behavior
             AssignmentExpression(node) {
                 if (astUtils.isLogicalAssignmentOperator(node.operator)) {
                     increaseComplexity();
                 }
+            },
+
+            onCodePathEnd(codePath, node) {
+                const complexity = complexities.pop();
+
+                /*
+                 * This rule only evaluates complexity of functions, so "program" is excluded.
+                 * Class field initializers are implicit functions. Therefore, they shouldn't contribute
+                 * to the enclosing function's complexity, but their own complexity should be evaluated.
+                 */
+                if (
+                    codePath.origin !== "function" &&
+                    codePath.origin !== "class-field-initializer"
+                ) {
+                    return;
+                }
+
+                if (complexity > THRESHOLD) {
+                    const name = codePath.origin === "class-field-initializer"
+                        ? "class field initializer"
+                        : astUtils.getFunctionNameWithKind(node);
+
+                    context.report({
+                        node,
+                        messageId: "complex",
+                        data: {
+                            name: upperCaseFirst(name),
+                            complexity,
+                            max: THRESHOLD
+                        }
+                    });
+                }
             }
         };
 

package/lib/rules/computed-property-spacing.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent spacing inside computed property brackets",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/computed-property-spacing"
         },

package/lib/rules/consistent-return.js

@@ -46,7 +46,6 @@ module.exports = {
 
         docs: {
             description: "require `return` statements to either always or never specify values",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/consistent-return"
         },

package/lib/rules/consistent-this.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent naming when capturing the current execution context",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/consistent-this"
         },
@@ -47,7 +46,7 @@ module.exports = {
          * Reports that a variable declarator or assignment expression is assigning
          * a non-'this' value to the specified alias.
          * @param {ASTNode} node The assigning node.
-         * @param {string}  name the name of the alias that was incorrectly used.
+         * @param {string} name the name of the alias that was incorrectly used.
          * @returns {void}
          */
         function reportBadAssignment(node, name) {

package/lib/rules/constructor-super.js

@@ -122,7 +122,6 @@ module.exports = {
 
         docs: {
             description: "require `super()` calls in constructors",
-            category: "ECMAScript 6",
             recommended: true,
             url: "https://eslint.org/docs/rules/constructor-super"
         },

package/lib/rules/curly.js

@@ -20,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent brace style for all control statements",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/curly"
         },

package/lib/rules/default-case-last.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce default clauses in switch statements to be last",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/default-case-last"
         },

package/lib/rules/default-case.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "require `default` cases in `switch` statements",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/default-case"
         },
@@ -50,8 +49,8 @@ module.exports = {
 
         /**
          * Shortcut to get last element of array
-         * @param  {*[]} collection Array
-         * @returns {*} Last element
+         * @param {*[]} collection Array
+         * @returns {any} Last element
          */
         function last(collection) {
             return collection[collection.length - 1];

package/lib/rules/default-param-last.js

@@ -11,7 +11,6 @@ module.exports = {
 
         docs: {
             description: "enforce default parameters to be last",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/default-param-last"
         },
@@ -25,8 +24,8 @@ module.exports = {
 
     create(context) {
 
-        // eslint-disable-next-line jsdoc/require-description
         /**
+         * Handler for function contexts.
          * @param {ASTNode} node function node
          * @returns {void}
          */

package/lib/rules/dot-location.js

@@ -17,7 +17,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent newlines before and after dots",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/dot-location"
         },

package/lib/rules/dot-notation.js

@@ -26,7 +26,6 @@ module.exports = {
 
         docs: {
             description: "enforce dot notation whenever possible",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/dot-notation"
         },

package/lib/rules/eol-last.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow newline at the end of files",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/eol-last"
         },
@@ -86,10 +85,15 @@ module.exports = {
                     });
                 } else if (mode === "never" && endsWithNewline) {
 
+                    const secondLastLine = sourceCode.lines[sourceCode.lines.length - 2];
+
                     // File is newline-terminated, but shouldn't be
                     context.report({
                         node,
-                        loc: location,
+                        loc: {
+                            start: { line: sourceCode.lines.length - 1, column: secondLastLine.length },
+                            end: { line: sourceCode.lines.length, column: 0 }
+                        },
                         messageId: "unexpected",
                         fix(fixer) {
                             const finalEOLs = /(?:\r?\n)+$/u,

package/lib/rules/eqeqeq.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "require the use of `===` and `!==`",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/eqeqeq"
         },
@@ -78,7 +77,7 @@ module.exports = {
 
         /**
          * Checks if an expression is a typeof expression
-         * @param  {ASTNode} node The node to check
+         * @param {ASTNode} node The node to check
          * @returns {boolean} if the node is a typeof expression
          */
         function isTypeOf(node) {

package/lib/rules/for-direction.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce \"for\" loop update clause moving the counter in the right direction.",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/for-direction"
         },

package/lib/rules/func-call-spacing.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow spacing between function identifiers and their invocations",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/func-call-spacing"
         },

package/lib/rules/func-name-matching.js

@@ -74,7 +74,6 @@ module.exports = {
 
         docs: {
             description: "require function names to match the name of the variable or property to which they are assigned",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/func-name-matching"
         },
@@ -196,21 +195,25 @@ module.exports = {
                 const isProp = node.left.type === "MemberExpression";
                 const name = isProp ? astUtils.getStaticPropertyName(node.left) : node.left.name;
 
-                if (node.right.id && isIdentifier(name) && shouldWarn(name, node.right.id.name)) {
+                if (node.right.id && name && isIdentifier(name) && shouldWarn(name, node.right.id.name)) {
                     report(node, name, node.right.id.name, isProp);
                 }
             },
 
-            Property(node) {
-                if (node.value.type !== "FunctionExpression" || !node.value.id || node.computed && !isStringLiteral(node.key)) {
+            "Property, PropertyDefinition[value]"(node) {
+                if (!(node.value.type === "FunctionExpression" && node.value.id)) {
                     return;
                 }
 
-                if (node.key.type === "Identifier") {
+                if (node.key.type === "Identifier" && !node.computed) {
                     const functionName = node.value.id.name;
                     let propertyName = node.key.name;
 
-                    if (considerPropertyDescriptor && propertyName === "value") {
+                    if (
+                        considerPropertyDescriptor &&
+                        propertyName === "value" &&
+                        node.parent.type === "ObjectExpression"
+                    ) {
                         if (isPropertyCall("Object", "defineProperty", node.parent.parent) || isPropertyCall("Reflect", "defineProperty", node.parent.parent)) {
                             const property = node.parent.parent.arguments[1];
 

package/lib/rules/func-names.js

@@ -30,7 +30,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow named `function` expressions",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/func-names"
         },

package/lib/rules/func-style.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "enforce the consistent use of either `function` declarations or expressions",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/func-style"
         },

package/lib/rules/function-call-argument-newline.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce line breaks between arguments of a function call",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/function-call-argument-newline"
         },

package/lib/rules/function-paren-newline.js

@@ -20,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent line breaks inside function parentheses",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/function-paren-newline"
         },
@@ -183,6 +182,7 @@ module.exports = {
         /**
          * Gets the left paren and right paren tokens of a node.
          * @param {ASTNode} node The node with parens
+         * @throws {TypeError} Unexecpted node type.
          * @returns {Object} An object with keys `leftParen` for the left paren token, and `rightParen` for the right paren token.
          * Can also return `null` if an expression has no parens (e.g. a NewExpression with no arguments, or an ArrowFunctionExpression
          * with a single parameter)

package/lib/rules/generator-star-spacing.js

@@ -31,7 +31,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent spacing around `*` operators in generator functions",
-            category: "ECMAScript 6",
             recommended: false,
             url: "https://eslint.org/docs/rules/generator-star-spacing"
         },

package/lib/rules/getter-return.js

@@ -35,7 +35,6 @@ module.exports = {
 
         docs: {
             description: "enforce `return` statements in getters",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/getter-return"
         },

package/lib/rules/global-require.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Rule for disallowing require() outside of the top-level module context
  * @author Jamund Ferguson
+ * @deprecated in ESLint v7.0.0
  */
 
 "use strict";
@@ -57,7 +58,6 @@ module.exports = {
 
         docs: {
             description: "require `require()` calls to be placed at top-level module scope",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/global-require"
         },

package/lib/rules/grouped-accessor-pairs.js

@@ -96,7 +96,6 @@ module.exports = {
 
         docs: {
             description: "require grouped accessor pairs in object literals and classes",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/grouped-accessor-pairs"
         },

package/lib/rules/guard-for-in.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "require `for-in` loops to include an `if` statement",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/guard-for-in"
         },

package/lib/rules/handle-callback-err.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview Ensure handling of errors when we know they exist.
  * @author Jamund Ferguson
+ * @deprecated in ESLint v7.0.0
  */
 
 "use strict";
@@ -19,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "require error handling in callbacks",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/handle-callback-err"
         },

package/lib/rules/id-blacklist.js

@@ -2,6 +2,7 @@
  * @fileoverview Rule that warns when identifier names that are
  * specified in the configuration are used.
  * @author Keith Cirkel (http://keithcirkel.co.uk)
+ * @deprecated in ESLint v7.5.0
  */
 
 "use strict";
@@ -118,7 +119,6 @@ module.exports = {
 
         docs: {
             description: "disallow specified identifiers",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/id-blacklist"
         },

package/lib/rules/id-denylist.js

@@ -99,7 +99,6 @@ module.exports = {
 
         docs: {
             description: "disallow specified identifiers",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/id-denylist"
         },

package/lib/rules/id-length.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "enforce minimum and maximum identifier lengths",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/id-length"
         },

package/lib/rules/id-match.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "require identifiers to match a specified regular expression",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/id-match"
         },

package/lib/rules/implicit-arrow-linebreak.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce the location of arrow function bodies",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/implicit-arrow-linebreak"
         },

package/lib/rules/indent-legacy.js

@@ -4,6 +4,7 @@
  * This rule has been ported and modified from nodeca.
  * @author Vitaly Puzrin
  * @author Gyandeep Singh
+ * @deprecated in ESLint v4.0.0
  */
 
 "use strict";
@@ -25,7 +26,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent indentation",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/indent-legacy"
         },

package/lib/rules/indent.js

@@ -140,7 +140,7 @@ class BinarySearchTree {
     /**
      * Inserts an entry into the tree.
      * @param {number} key The entry's key
-     * @param {*} value The entry's value
+     * @param {any} value The entry's value
      * @returns {void}
      */
     insert(key, value) {
@@ -190,7 +190,6 @@ class BinarySearchTree {
  */
 class TokenInfo {
 
-    // eslint-disable-next-line jsdoc/require-description
     /**
      * @param {SourceCode} sourceCode A SourceCode object
      */
@@ -240,7 +239,6 @@ class TokenInfo {
  */
 class OffsetStorage {
 
-    // eslint-disable-next-line jsdoc/require-description
     /**
      * @param {TokenInfo} tokenInfo a TokenInfo instance
      * @param {number} indentSize The desired size of each indentation level
@@ -265,7 +263,7 @@ class OffsetStorage {
 
     /**
      * Sets the offset column of token B to match the offset column of token A.
-     * **WARNING**: This matches a *column*, even if baseToken is not the first token on its line. In
+     * - **WARNING**: This matches a *column*, even if baseToken is not the first token on its line. In
      * most cases, `setDesiredOffset` should be used instead.
      * @param {Token} baseToken The first token
      * @param {Token} offsetToken The second token, whose offset should be matched to the first token
@@ -354,11 +352,11 @@ class OffsetStorage {
      * Instead, the offset tree is represented as a collection of contiguous offset ranges in a file. For example, the following
      * list could represent the state of the offset tree at a given point:
      *
-     * * Tokens starting in the interval [0, 15) are aligned with the beginning of the file
-     * * Tokens starting in the interval [15, 30) are offset by 1 indent level from the `bar` token
-     * * Tokens starting in the interval [30, 43) are offset by 1 indent level from the `foo` token
-     * * Tokens starting in the interval [43, 820) are offset by 2 indent levels from the `bar` token
-     * * Tokens starting in the interval [820, ∞) are offset by 1 indent level from the `baz` token
+     * - Tokens starting in the interval [0, 15) are aligned with the beginning of the file
+     * - Tokens starting in the interval [15, 30) are offset by 1 indent level from the `bar` token
+     * - Tokens starting in the interval [30, 43) are offset by 1 indent level from the `foo` token
+     * - Tokens starting in the interval [43, 820) are offset by 2 indent levels from the `bar` token
+     * - Tokens starting in the interval [820, ∞) are offset by 1 indent level from the `baz` token
      *
      * The `setDesiredOffsets` methods inserts ranges like the ones above. The third line above would be inserted by using:
      * `setDesiredOffsets([30, 43], fooToken, 1);`
@@ -501,7 +499,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent indentation",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/indent"
         },

package/lib/rules/index.js

@@ -6,7 +6,7 @@
 
 "use strict";
 
-/* eslint sort-keys: ["error", "asc"] */
+/* eslint sort-keys: ["error", "asc"] -- More readable for long list */
 
 const { LazyLoadingRuleMap } = require("./utils/lazy-loading-rule-map");
 

package/lib/rules/init-declarations.js

@@ -48,7 +48,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow initialization in variable declarations",
-            category: "Variables",
             recommended: false,
             url: "https://eslint.org/docs/rules/init-declarations"
         },

package/lib/rules/jsx-quotes.js

@@ -42,7 +42,6 @@ module.exports = {
 
         docs: {
             description: "enforce the consistent use of either double or single quotes in JSX attributes",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/jsx-quotes"
         },