eslint 8.0.0-beta.0 → 8.0.0

package/lib/rules/key-spacing.js

@@ -139,7 +139,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent spacing between keys and values in object literal properties",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/key-spacing"
         },
@@ -531,8 +530,8 @@ module.exports = {
 
         /**
          * Creates groups of properties.
-         * @param  {ASTNode} node ObjectExpression node being evaluated.
-         * @returns {Array.<ASTNode[]>} Groups of property AST node lists.
+         * @param {ASTNode} node ObjectExpression node being evaluated.
+         * @returns {Array<ASTNode[]>} Groups of property AST node lists.
          */
         function createGroups(node) {
             if (node.properties.length === 1) {
@@ -600,7 +599,7 @@ module.exports = {
 
         /**
          * Verifies spacing of property conforms to specified options.
-         * @param  {ASTNode} node Property node being evaluated.
+         * @param {ASTNode} node Property node being evaluated.
          * @param {Object} lineOptions Configured singleLine or multiLine options
          * @returns {void}
          */
@@ -629,7 +628,7 @@ module.exports = {
 
         /**
          * Verifies vertical alignment, taking into account groups of properties.
-         * @param  {ASTNode} node ObjectExpression node being evaluated.
+         * @param {ASTNode} node ObjectExpression node being evaluated.
          * @returns {void}
          */
         function verifyAlignment(node) {

package/lib/rules/keyword-spacing.js

@@ -67,7 +67,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent spacing before and after keywords",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/keyword-spacing"
         },
@@ -403,7 +402,15 @@ module.exports = {
          */
         function checkSpacingForForInStatement(node) {
             checkSpacingAroundFirstToken(node);
-            checkSpacingAroundTokenBefore(node.right);
+
+            const inToken = sourceCode.getTokenBefore(node.right, astUtils.isNotOpeningParenToken);
+            const previousToken = sourceCode.getTokenBefore(inToken);
+
+            if (previousToken.type !== "PrivateIdentifier") {
+                checkSpacingBefore(inToken);
+            }
+
+            checkSpacingAfter(inToken);
         }
 
         /**
@@ -419,7 +426,15 @@ module.exports = {
             } else {
                 checkSpacingAroundFirstToken(node);
             }
-            checkSpacingAround(sourceCode.getTokenBefore(node.right, astUtils.isNotOpeningParenToken));
+
+            const ofToken = sourceCode.getTokenBefore(node.right, astUtils.isNotOpeningParenToken);
+            const previousToken = sourceCode.getTokenBefore(ofToken);
+
+            if (previousToken.type !== "PrivateIdentifier") {
+                checkSpacingBefore(ofToken);
+            }
+
+            checkSpacingAfter(ofToken);
         }
 
         /**
@@ -473,6 +488,7 @@ module.exports = {
          * Reports `static`, `get`, and `set` keywords of a given node if usage of
          * spacing around those keywords is invalid.
          * @param {ASTNode} node A node to report.
+         * @throws {Error} If unable to find token get, set, or async beside method name.
          * @returns {void}
          */
         function checkSpacingForProperty(node) {

package/lib/rules/line-comment-position.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "enforce position of line comments",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/line-comment-position"
         },

package/lib/rules/linebreak-style.js

@@ -21,7 +21,6 @@ module.exports = {
 
         docs: {
             description: "enforce consistent linebreak style",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/linebreak-style"
         },

package/lib/rules/lines-around-comment.js

@@ -55,7 +55,6 @@ module.exports = {
 
         docs: {
             description: "require empty lines around comments",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/lines-around-comment"
         },

package/lib/rules/lines-around-directive.js

@@ -1,7 +1,7 @@
 /**
  * @fileoverview Require or disallow newlines around directives.
  * @author Kai Cataldo
- * @deprecated
+ * @deprecated in ESLint v4.0.0
  */
 
 "use strict";
@@ -18,7 +18,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow newlines around directives",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/lines-around-directive"
         },

package/lib/rules/lines-between-class-members.js

@@ -4,6 +4,10 @@
  */
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
 const astUtils = require("./utils/ast-utils");
 
 //------------------------------------------------------------------------------
@@ -16,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow an empty line between class members",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/lines-between-class-members"
         },
@@ -53,6 +56,51 @@ module.exports = {
 
         const sourceCode = context.getSourceCode();
 
+        /**
+         * Gets a pair of tokens that should be used to check lines between two class member nodes.
+         *
+         * In most cases, this returns the very last token of the current node and
+         * the very first token of the next node.
+         * For example:
+         *
+         *     class C {
+         *         x = 1;   // curLast: `;` nextFirst: `in`
+         *         in = 2
+         *     }
+         *
+         * There is only one exception. If the given node ends with a semicolon, and it looks like
+         * a semicolon-less style's semicolon - one that is not on the same line as the preceding
+         * token, but is on the line where the next class member starts - this returns the preceding
+         * token and the semicolon as boundary tokens.
+         * For example:
+         *
+         *     class C {
+         *         x = 1    // curLast: `1` nextFirst: `;`
+         *         ;in = 2
+         *     }
+         * When determining the desired layout of the code, we should treat this semicolon as
+         * a part of the next class member node instead of the one it technically belongs to.
+         * @param {ASTNode} curNode Current class member node.
+         * @param {ASTNode} nextNode Next class member node.
+         * @returns {Token} The actual last token of `node`.
+         * @private
+         */
+        function getBoundaryTokens(curNode, nextNode) {
+            const lastToken = sourceCode.getLastToken(curNode);
+            const prevToken = sourceCode.getTokenBefore(lastToken);
+            const nextToken = sourceCode.getFirstToken(nextNode); // skip possible lone `;` between nodes
+
+            const isSemicolonLessStyle = (
+                astUtils.isSemicolonToken(lastToken) &&
+                !astUtils.isTokenOnSameLine(prevToken, lastToken) &&
+                astUtils.isTokenOnSameLine(lastToken, nextToken)
+            );
+
+            return isSemicolonLessStyle
+                ? { curLast: prevToken, nextFirst: lastToken }
+                : { curLast: lastToken, nextFirst: nextToken };
+        }
+
         /**
          * Return the last token among the consecutive tokens that have no exceed max line difference in between, before the first token in the next member.
          * @param {Token} prevLastToken The last token in the previous member node.
@@ -101,8 +149,7 @@ module.exports = {
 
                 for (let i = 0; i < body.length - 1; i++) {
                     const curFirst = sourceCode.getFirstToken(body[i]);
-                    const curLast = sourceCode.getLastToken(body[i]);
-                    const nextFirst = sourceCode.getFirstToken(body[i + 1]);
+                    const { curLast, nextFirst } = getBoundaryTokens(body[i], body[i + 1]);
                     const isMulti = !astUtils.isTokenOnSameLine(curFirst, curLast);
                     const skip = !isMulti && options[1].exceptAfterSingleLine;
                     const beforePadding = findLastConsecutiveTokenAfter(curLast, nextFirst, 1);

package/lib/rules/max-classes-per-file.js

@@ -19,15 +19,31 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum number of classes per file",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-classes-per-file"
         },
 
         schema: [
             {
-                type: "integer",
-                minimum: 1
+                oneOf: [
+                    {
+                        type: "integer",
+                        minimum: 1
+                    },
+                    {
+                        type: "object",
+                        properties: {
+                            ignoreExpressions: {
+                                type: "boolean"
+                            },
+                            max: {
+                                type: "integer",
+                                minimum: 1
+                            }
+                        },
+                        additionalProperties: false
+                    }
+                ]
             }
         ],
 
@@ -36,8 +52,10 @@ module.exports = {
         }
     },
     create(context) {
-
-        const maxClasses = context.options[0] || 1;
+        const [option = {}] = context.options;
+        const [ignoreExpressions, max] = typeof option === "number"
+            ? [false, option || 1]
+            : [option.ignoreExpressions, option.max || 1];
 
         let classCount = 0;
 
@@ -46,19 +64,24 @@ module.exports = {
                 classCount = 0;
             },
             "Program:exit"(node) {
-                if (classCount > maxClasses) {
+                if (classCount > max) {
                     context.report({
                         node,
                         messageId: "maximumExceeded",
                         data: {
                             classCount,
-                            max: maxClasses
+                            max
                         }
                     });
                 }
             },
-            "ClassDeclaration, ClassExpression"() {
+            "ClassDeclaration"() {
                 classCount++;
+            },
+            "ClassExpression"() {
+                if (!ignoreExpressions) {
+                    classCount++;
+                }
             }
         };
     }

package/lib/rules/max-depth.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum depth that blocks can be nested",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-depth"
         },

package/lib/rules/max-len.js

@@ -69,7 +69,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum line length",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-len"
         },
@@ -215,7 +214,7 @@ module.exports = {
          * Ensure that an array exists at [key] on `object`, and add `value` to it.
          * @param {Object} object the object to mutate
          * @param {string} key the object's key
-         * @param {*} value the value to add
+         * @param {any} value the value to add
          * @returns {void}
          * @private
          */

package/lib/rules/max-lines-per-function.js

@@ -48,7 +48,7 @@ const OPTIONS_OR_INTEGER_SCHEMA = {
 /**
  * Given a list of comment nodes, return a map with numeric keys (source code line numbers) and comment token values.
  * @param {Array} comments An array of comment nodes.
- * @returns {Map.<string,Node>} A map with numeric keys (source code line numbers) and comment token values.
+ * @returns {Map<string, Node>} A map with numeric keys (source code line numbers) and comment token values.
  */
 function getCommentLineNumbers(comments) {
     const map = new Map();
@@ -71,7 +71,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum number of lines of code in a function",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-lines-per-function"
         },

package/lib/rules/max-lines.js

@@ -34,7 +34,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum number of lines per file",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-lines"
         },

package/lib/rules/max-nested-callbacks.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum depth that callbacks can be nested",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-nested-callbacks"
         },

package/lib/rules/max-params.js

@@ -22,7 +22,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum number of parameters in function definitions",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-params"
         },

package/lib/rules/max-statements-per-line.js

@@ -20,7 +20,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum number of statements allowed per line",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-statements-per-line"
         },

package/lib/rules/max-statements.js

@@ -22,7 +22,6 @@ module.exports = {
 
         docs: {
             description: "enforce a maximum number of statements allowed in function blocks",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/max-statements"
         },

package/lib/rules/multiline-comment-style.js

@@ -16,7 +16,6 @@ module.exports = {
 
         docs: {
             description: "enforce a particular style for multiline comments",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/multiline-comment-style"
         },

package/lib/rules/multiline-ternary.js

@@ -17,7 +17,6 @@ module.exports = {
 
         docs: {
             description: "enforce newlines between operands of ternary expressions",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/multiline-ternary"
         },

package/lib/rules/new-cap.js

@@ -33,7 +33,8 @@ const CAPS_ALLOWED = [
  * Ensure that if the key is provided, it must be an array.
  * @param {Object} obj Object to check with `key`.
  * @param {string} key Object key to check on `obj`.
- * @param {*} fallback If obj[key] is not present, this will be returned.
+ * @param {any} fallback If obj[key] is not present, this will be returned.
+ * @throws {TypeError} If key is not an own array type property of `obj`.
  * @returns {string[]} Returns obj[key] if it's an Array, otherwise `fallback`
  */
 function checkArray(obj, key, fallback) {
@@ -81,7 +82,6 @@ module.exports = {
 
         docs: {
             description: "require constructor names to begin with a capital letter",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/new-cap"
         },

package/lib/rules/new-parens.js

@@ -25,7 +25,6 @@ module.exports = {
 
         docs: {
             description: "enforce or disallow parentheses when invoking a constructor with no arguments",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/new-parens"
         },

package/lib/rules/newline-after-var.js

@@ -1,7 +1,7 @@
 /**
  * @fileoverview Rule to check empty newline after "var" statement
  * @author Gopal Venkatesan
- * @deprecated
+ * @deprecated in ESLint v4.0.0
  */
 
 "use strict";
@@ -22,7 +22,6 @@ module.exports = {
 
         docs: {
             description: "require or disallow an empty line after variable declarations",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/newline-after-var"
         },
@@ -145,9 +144,9 @@ module.exports = {
 
         /**
          * Determine if a token starts more than one line after a comment ends
-         * @param  {token}   token            The token being checked
-         * @param {integer}  commentStartLine The line number on which the comment starts
-         * @returns {boolean}                 True if `token` does not start immediately after a comment
+         * @param {token} token The token being checked
+         * @param {integer} commentStartLine The line number on which the comment starts
+         * @returns {boolean} True if `token` does not start immediately after a comment
          */
         function hasBlankLineAfterComment(token, commentStartLine) {
             return token.loc.start.line > getLastCommentLineOfBlock(commentStartLine) + 1;

package/lib/rules/newline-before-return.js

@@ -1,7 +1,7 @@
 /**
  * @fileoverview Rule to require newlines before `return` statement
  * @author Kai Cataldo
- * @deprecated
+ * @deprecated in ESLint v4.0.0
  */
 "use strict";
 
@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "require an empty line before `return` statements",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/newline-before-return"
         },
@@ -134,7 +133,7 @@ module.exports = {
             if (tokenBefore) {
                 lineNumTokenBefore = tokenBefore.loc.end.line;
             } else {
-                lineNumTokenBefore = 0; // Global return at beginning of script
+                lineNumTokenBefore = 0; // global return at beginning of script
             }
 
             return lineNumTokenBefore;

package/lib/rules/newline-per-chained-call.js

@@ -18,7 +18,6 @@ module.exports = {
 
         docs: {
             description: "require a newline after each call in a method chain",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/newline-per-chained-call"
         },
@@ -53,7 +52,7 @@ module.exports = {
          * Get the prefix of a given MemberExpression node.
          * If the MemberExpression node is a computed value it returns a
          * left bracket. If not it returns a period.
-         * @param  {ASTNode} node A MemberExpression node to get
+         * @param {ASTNode} node A MemberExpression node to get
          * @returns {string} The prefix of the node.
          */
         function getPrefix(node) {

package/lib/rules/no-alert.js

@@ -88,7 +88,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of `alert`, `confirm`, and `prompt`",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-alert"
         },

package/lib/rules/no-array-constructor.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow `Array` constructors",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-array-constructor"
         },

package/lib/rules/no-async-promise-executor.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow using an async function as a Promise executor",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-async-promise-executor"
         },

package/lib/rules/no-await-in-loop.js

@@ -59,7 +59,6 @@ module.exports = {
 
         docs: {
             description: "disallow `await` inside of loops",
-            category: "Possible Errors",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-await-in-loop"
         },

package/lib/rules/no-bitwise.js

@@ -26,7 +26,6 @@ module.exports = {
 
         docs: {
             description: "disallow bitwise operators",
-            category: "Stylistic Issues",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-bitwise"
         },
@@ -63,7 +62,7 @@ module.exports = {
 
         /**
          * Reports an unexpected use of a bitwise operator.
-         * @param   {ASTNode} node Node which contains the bitwise operator.
+         * @param {ASTNode} node Node which contains the bitwise operator.
          * @returns {void}
          */
         function report(node) {
@@ -72,7 +71,7 @@ module.exports = {
 
         /**
          * Checks if the given node has a bitwise operator.
-         * @param   {ASTNode} node The node to check.
+         * @param {ASTNode} node The node to check.
          * @returns {boolean} Whether or not the node has a bitwise operator.
          */
         function hasBitwiseOperator(node) {
@@ -81,7 +80,7 @@ module.exports = {
 
         /**
          * Checks if exceptions were provided, e.g. `{ allow: ['~', '|'] }`.
-         * @param   {ASTNode} node The node to check.
+         * @param {ASTNode} node The node to check.
          * @returns {boolean} Whether or not the node has a bitwise operator.
          */
         function allowedOperator(node) {
@@ -90,7 +89,7 @@ module.exports = {
 
         /**
          * Checks if the given bitwise operator is used for integer typecasting, i.e. "|0"
-         * @param   {ASTNode} node The node to check.
+         * @param {ASTNode} node The node to check.
          * @returns {boolean} whether the node is used in integer typecasting.
          */
         function isInt32Hint(node) {
@@ -100,7 +99,7 @@ module.exports = {
 
         /**
          * Report if the given node contains a bitwise operator.
-         * @param   {ASTNode} node The node to check.
+         * @param {ASTNode} node The node to check.
          * @returns {void}
          */
         function checkNodeForBitwiseOperator(node) {

package/lib/rules/no-buffer-constructor.js

@@ -1,6 +1,7 @@
 /**
  * @fileoverview disallow use of the Buffer() constructor
  * @author Teddy Katz
+ * @deprecated in ESLint v7.0.0
  */
 "use strict";
 
@@ -18,7 +19,6 @@ module.exports = {
 
         docs: {
             description: "disallow use of the `Buffer()` constructor",
-            category: "Node.js and CommonJS",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-buffer-constructor"
         },

package/lib/rules/no-caller.js

@@ -15,7 +15,6 @@ module.exports = {
 
         docs: {
             description: "disallow the use of `arguments.caller` or `arguments.callee`",
-            category: "Best Practices",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-caller"
         },

package/lib/rules/no-case-declarations.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow lexical declarations in case clauses",
-            category: "Best Practices",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-case-declarations"
         },

package/lib/rules/no-catch-shadow.js

@@ -22,7 +22,6 @@ module.exports = {
 
         docs: {
             description: "disallow `catch` clause parameters from shadowing variables in the outer scope",
-            category: "Variables",
             recommended: false,
             url: "https://eslint.org/docs/rules/no-catch-shadow"
         },

package/lib/rules/no-class-assign.js

@@ -17,7 +17,6 @@ module.exports = {
 
         docs: {
             description: "disallow reassigning class members",
-            category: "ECMAScript 6",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-class-assign"
         },

package/lib/rules/no-compare-neg-zero.js

@@ -14,7 +14,6 @@ module.exports = {
 
         docs: {
             description: "disallow comparing against -0",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-compare-neg-zero"
         },

package/lib/rules/no-cond-assign.js

@@ -34,7 +34,6 @@ module.exports = {
 
         docs: {
             description: "disallow assignment operators in conditional expressions",
-            category: "Possible Errors",
             recommended: true,
             url: "https://eslint.org/docs/rules/no-cond-assign"
         },