devflow-kit 1.8.3 → 2.0.1

package/shared/skills/python/references/violations.md

@@ -1,204 +0,0 @@
-# Python Violation Examples
-
-Extended violation patterns for Python reviews. Reference from main SKILL.md.
-
-## Type Safety Violations
-
-### Missing Type Hints
-
-```python
-# VIOLATION: No type annotations
-def process(data, config):
-    result = transform(data)
-    return result
-
-# VIOLATION: Partial annotations (inconsistent)
-def save(user: User, db):  # db missing type
-    return db.insert(user)
-
-# VIOLATION: Missing return type
-def calculate_total(items: list[Item]):
-    return sum(item.price for item in items)
-```
-
-### Bare Except Clauses
-
-```python
-# VIOLATION: Catches everything including SystemExit and KeyboardInterrupt
-try:
-    process_data()
-except:
-    pass
-
-# VIOLATION: Catches too broadly and silences
-try:
-    user = fetch_user(user_id)
-except Exception:
-    user = None  # Hides real errors (network, auth, parsing)
-
-# VIOLATION: Bare except with logging but no re-raise
-try:
-    critical_operation()
-except:
-    logger.error("Something failed")
-    # Swallows the error — caller never knows
-```
-
-## Data Modeling Violations
-
-### Raw Dicts Instead of Dataclasses
-
-```python
-# VIOLATION: Untyped dict — no IDE support, no validation
-user = {
-    "name": "Alice",
-    "email": "alice@example.com",
-    "age": 30,
-}
-
-# VIOLATION: Accessing dict keys without safety
-def get_display_name(user: dict) -> str:
-    return f"{user['first_name']} {user['last_name']}"  # KeyError risk
-
-# VIOLATION: Nested untyped dicts
-config = {
-    "database": {
-        "host": "localhost",
-        "port": 5432,
-    },
-    "cache": {
-        "ttl": 300,
-    },
-}
-```
-
-### Mutable Default Arguments
-
-```python
-# VIOLATION: Mutable default shared across calls
-def add_item(item: str, items: list[str] = []) -> list[str]:
-    items.append(item)
-    return items
-
-# VIOLATION: Dict default mutated in place
-def register(name: str, registry: dict[str, bool] = {}) -> None:
-    registry[name] = True
-
-# VIOLATION: Set default
-def collect(value: int, seen: set[int] = set()) -> set[int]:
-    seen.add(value)
-    return seen
-```
-
-## String Formatting Violations
-
-### Percent Formatting
-
-```python
-# VIOLATION: Old-style % formatting
-message = "Hello %s, you have %d messages" % (name, count)
-
-# VIOLATION: % formatting with dict — hard to read, error-prone
-log = "%(timestamp)s - %(level)s - %(message)s" % log_data
-```
-
-### String Concatenation in Loops
-
-```python
-# VIOLATION: O(n^2) string building
-result = ""
-for line in lines:
-    result += line + "\n"
-
-# CORRECT: Use join
-result = "\n".join(lines)
-```
-
-## Global State Violations
-
-### Module-Level Mutable State
-
-```python
-# VIOLATION: Global mutable state
-_cache = {}
-_connections = []
-
-def get_cached(key: str) -> Any:
-    return _cache.get(key)
-
-def add_connection(conn: Connection) -> None:
-    _connections.append(conn)
-
-# VIOLATION: Global variable modified by functions
-current_user = None
-
-def login(username: str) -> None:
-    global current_user
-    current_user = authenticate(username)
-```
-
-### Singleton via Module Import
-
-```python
-# VIOLATION: Hard-to-test singleton
-# db.py
-connection = create_connection(os.environ["DATABASE_URL"])
-
-# service.py
-from db import connection  # Cannot mock or swap for tests
-```
-
-## Import Violations
-
-### Wildcard Imports
-
-```python
-# VIOLATION: Pollutes namespace, hides dependencies
-from os.path import *
-from utils import *
-
-# VIOLATION: Star import in __init__.py
-# mypackage/__init__.py
-from .models import *
-from .services import *
-```
-
-### Circular Imports
-
-```python
-# VIOLATION: Circular dependency
-# models.py
-from services import UserService  # services imports models too
-
-# services.py
-from models import User  # Circular!
-```
-
-## Testing Violations
-
-### Assert in Production Code
-
-```python
-# VIOLATION: assert is stripped with -O flag
-def withdraw(account: Account, amount: float) -> None:
-    assert amount > 0, "Amount must be positive"  # Disabled in production!
-    assert account.balance >= amount, "Insufficient funds"
-    account.balance -= amount
-```
-
-### No pytest Fixtures
-
-```python
-# VIOLATION: Repeated setup in every test
-def test_create_user():
-    db = Database(":memory:")
-    db.create_tables()
-    service = UserService(db)
-    # ... test logic
-
-def test_update_user():
-    db = Database(":memory:")  # Duplicated setup
-    db.create_tables()
-    service = UserService(db)
-    # ... test logic
-```

package/shared/skills/react/SKILL.md

@@ -1,276 +0,0 @@
----
-name: react
-description: This skill should be used when the user works with React components (.tsx/.jsx), asks about "hooks", "state management", "context providers", "memo optimization", "useEffect", or discusses component composition and rendering performance. Provides patterns for hooks, state, effects, memoization, and React-specific architecture.
-user-invocable: false
-allowed-tools: Read, Grep, Glob
-activation:
-  file-patterns:
-    - "**/*.tsx"
-    - "**/*.jsx"
-  exclude:
-    - "node_modules/**"
-    - "**/*.test.*"
-    - "**/*.spec.*"
----
-
-# React Patterns
-
-Reference for React-specific patterns, component design, hooks, and performance optimization.
-
-## Iron Law
-
-> **COMPOSITION OVER PROPS**
->
-> Use children and compound components, not prop drilling. If a component has >5 props,
-> it's doing too much. Split it. If you're passing data through 3+ levels, use context
-> or composition. Props are for configuration, not data plumbing.
-
-## When This Skill Activates
-
-- Working with React codebases
-- Creating components and hooks
-- Managing state and side effects
-- Optimizing render performance
-
----
-
-## Component Patterns
-
-### Functional Component Structure
-
-```tsx
-export function UserCard({ user, className }: UserCardProps) {
-  const [isExpanded, setIsExpanded] = useState(false); // 1. Hooks first
-  const displayName = user.firstName + ' ' + user.lastName; // 2. Derived state
-  const handleToggle = () => setIsExpanded((prev) => !prev); // 3. Handlers
-  return ( // 4. Render
-    <div className={cn('user-card', className)}>
-      <h3>{displayName}</h3>
-      {isExpanded && <UserDetails user={user} />}
-      <button onClick={handleToggle}>{isExpanded ? 'Collapse' : 'Expand'}</button>
-    </div>
-  );
-}
-```
-
-### Composition Over Props
-
-```tsx
-function Card({ children }: { children: React.ReactNode }) {
-  return <div className="card">{children}</div>;
-}
-Card.Header = ({ children }) => <div className="card-header">{children}</div>;
-Card.Body = ({ children }) => <div className="card-body">{children}</div>;
-
-// Usage - flexible, not rigid props
-<Card>
-  <Card.Header><h2>Title</h2></Card.Header>
-  <Card.Body><p>Content</p></Card.Body>
-</Card>
-```
-
----
-
-## Hook Patterns
-
-```tsx
-function useLocalStorage<T>(key: string, initialValue: T) {
-  const [value, setValue] = useState<T>(() => {
-    const stored = localStorage.getItem(key);
-    return stored ? JSON.parse(stored) : initialValue;
-  });
-  useEffect(() => localStorage.setItem(key, JSON.stringify(value)), [key, value]);
-  return [value, setValue] as const;
-}
-```
-
----
-
-## State Management
-
-```tsx
-const AuthContext = createContext<AuthContextValue | null>(null);
-
-export function AuthProvider({ children }: { children: React.ReactNode }) {
-  const [user, setUser] = useState<User | null>(null);
-  const login = async (creds: Credentials) => setUser(await authApi.login(creds));
-  const logout = () => { authApi.logout(); setUser(null); };
-  return <AuthContext value={{ user, login, logout }}>{children}</AuthContext>;
-}
-
-export function useAuth() {
-  const ctx = useContext(AuthContext);
-  if (!ctx) throw new Error('useAuth must be used within AuthProvider');
-  return ctx;
-}
-```
-
----
-
-## Performance
-
-```tsx
-function UserList({ users, filter }: { users: User[]; filter: string }) {
-  const filtered = useMemo(() => users.filter((u) => u.name.includes(filter)), [users, filter]);
-  const onClick = useCallback(() => console.log('Clicked'), []);
-  return <ul>{filtered.map((u) => <MemoItem key={u.id} user={u} onClick={onClick} />)}</ul>;
-}
-const MemoItem = memo(({ user }: { user: User }) => <li>{user.name}</li>);
-```
-
----
-
-## Async Parallelization
-
-```tsx
-// CORRECT: Independent fetches run in parallel
-async function loadDashboard(userId: string) {
-  const [user, orders, preferences] = await Promise.all([
-    fetchUser(userId),
-    fetchOrders(userId),
-    fetchPreferences(userId),
-  ]);
-  return { user, orders, preferences };
-}
-
-// VIOLATION: Sequential fetches (3x slower)
-async function loadDashboardSlow(userId: string) {
-  const user = await fetchUser(userId);
-  const orders = await fetchOrders(userId);
-  const preferences = await fetchPreferences(userId);
-  return { user, orders, preferences };
-}
-```
-
----
-
-## Bundle Size
-
-```tsx
-// CORRECT: Direct imports (tree-shakable)
-import { Button } from '@/components/Button';
-import { Card } from '@/components/Card';
-
-// VIOLATION: Barrel imports (imports entire library)
-import { Button, Card } from '@/components';
-
-// CORRECT: Dynamic import for heavy components
-const Chart = lazy(() => import('./Chart'));
-const Editor = lazy(() => import('./Editor'));
-
-function Dashboard() {
-  return (
-    <Suspense fallback={<Skeleton />}>
-      {showChart && <Chart data={data} />}
-    </Suspense>
-  );
-}
-```
-
----
-
-## Re-render Optimization
-
-```tsx
-// CORRECT: Primitive deps (stable references)
-useEffect(() => {
-  fetchData(userId, isActive);
-}, [userId, isActive]); // primitives don't cause unnecessary runs
-
-// VIOLATION: Object/array deps (new reference every render)
-useEffect(() => {
-  fetchData(options);
-}, [options]); // { page: 1 } !== { page: 1 }
-
-// CORRECT: Stable callback with useCallback
-const handleClick = useCallback((id: string) => {
-  setSelected(id);
-}, []); // no deps = stable reference
-
-// VIOLATION: Inline function (new reference every render)
-<List onItemClick={(id) => setSelected(id)} />
-```
-
----
-
-## Image Optimization
-
-```tsx
-// CORRECT: Optimized image with all attributes
-<img
-  src={url}
-  alt={description}
-  width={400}
-  height={300}
-  loading="lazy"
-  decoding="async"
-  style={{ aspectRatio: '4/3' }}
-/>
-
-// VIOLATION: Unoptimized image
-<img src={url} />  // No dimensions, no lazy loading, layout shift
-```
-
----
-
-## Data Structure Performance
-
-```tsx
-// CORRECT: Set for O(1) membership checks
-const selectedIds = new Set(selected);
-const isSelected = (id: string) => selectedIds.has(id);
-
-// VIOLATION: Array.includes is O(n)
-const isSelected = (id: string) => selected.includes(id);
-
-// CORRECT: Map for key-value lookups
-const usersById = new Map(users.map(u => [u.id, u]));
-const getUser = (id: string) => usersById.get(id);
-
-// VIOLATION: Array.find is O(n)
-const getUser = (id: string) => users.find(u => u.id === id);
-```
-
----
-
-## Anti-Patterns
-
-```tsx
-// BAD: Derived state in useState | GOOD: useMemo
-const filtered = useMemo(() => items.filter(i => i.active), [items]);
-
-// BAD: Missing dependency | GOOD: Include all deps
-useEffect(() => { fetchData(userId); }, [userId]);
-
-// BAD: State update in render | GOOD: Use effect
-useEffect(() => { setState(value); }, [value]);
-```
-
----
-
-## Extended References
-
-- `references/patterns.md` - Render props, reducers, virtualization, lazy loading
-- `references/hooks.md` - useQuery, useDebouncedValue, usePrevious, useClickOutside
-- `references/forms.md` - Controlled forms, validation hooks, multi-step forms
-- `references/error-handling.md` - Error boundaries, async error handling
-
----
-
-## Checklist
-
-- [ ] Hooks at top level only
-- [ ] All useEffect deps included
-- [ ] useCallback for handlers passed to children
-- [ ] useMemo for expensive computations
-- [ ] Context at appropriate level
-- [ ] Error boundaries around risky components
-- [ ] Keys on list items (not index)
-- [ ] Loading/error states handled
-- [ ] Accessibility (aria-*, role)
-- [ ] Independent fetches parallelized with Promise.all
-- [ ] No barrel imports (direct imports for tree-shaking)
-- [ ] Large components lazy-loaded
-- [ ] Object/array deps avoided in useEffect (use primitives)
-- [ ] Set/Map used for lookups instead of Array.includes/find
-- [ ] Images have dimensions, lazy loading, and aspect-ratio