devflow-kit 1.8.3 → 2.0.1

package/plugins/devflow-resolve/commands/resolve-teams.md

@@ -1,307 +0,0 @@
----
-description: Process review issues using agent teams with cross-validation debate
----
-
-# Resolve Command
-
-Process issues from code review reports: validate them (false positive check), assess risk for FIX vs TECH_DEBT decision, and implement fixes for low-risk issues.
-
-## Usage
-
-```
-/resolve           (resolve issues on current branch)
-/resolve #42       (resolve issues for specific PR)
-```
-
-## Phases
-
-### Phase 0: Pre-Flight (Git Agent)
-
-Spawn Git agent to validate branch state:
-
-```
-Task(subagent_type="Git", run_in_background=false):
-"OPERATION: validate-branch
-Check feature branch, clean working directory, reviews exist.
-Return: branch, branch-slug, PR#, review count"
-```
-
-**If BLOCKED:** Stop and report the blocker to user. If no reviews found, suggest `/code-review` first.
-
-**Extract from response:** `branch`, `branch_slug`, `pr_number`, `review_count` for use in subsequent phases.
-
-### Phase 1: Parse Issues
-
-Read all review reports from `.docs/reviews/{branch-slug}/*.md` and extract:
-
-**Include only:**
-- Blocking issues (CRITICAL, HIGH)
-- Should-Fix issues (HIGH, MEDIUM)
-
-**Skip:**
-- Pre-existing issues (belong in tech debt, not resolution)
-- LOW severity (informational only)
-
-**Extract per issue:**
-- `id`: Generated from file:line:type
-- `file`: Full path
-- `line`: Line number
-- `severity`: CRITICAL/HIGH/MEDIUM
-- `type`: Issue type from review
-- `description`: Problem statement
-- `suggested_fix`: From review report
-
-### Phase 2: Analyze Dependencies
-
-Group issues by relationship:
-
-1. **Same file** - Issues in same file go in same batch
-2. **Same function** - Issues affecting same function go together
-3. **Independent** - No relationship, can run in parallel
-
-Build dependency graph to determine execution order.
-
-### Phase 3: Plan Batches
-
-Create execution plan:
-- **Independent batches** - Mark for PARALLEL execution
-- **Dependent batches** - Mark for SEQUENTIAL execution
-- **Max 5 issues per batch** - Keep batches manageable
-
-### Phase 4: Resolve (Agent Teams with cross-validation)
-
-**With Agent Teams:**
-
-Create a resolution team for cross-validated fixes:
-
-```
-Create a team named "resolve-{branch-slug}" to resolve review issues.
-
-Spawn resolver teammates with self-contained prompts (one per independent batch):
-
-- Name: "resolver-batch-1"
-  Prompt: |
-    You are resolving review issues on branch {branch} (PR #{pr_number}).
-    1. Read your skill: `Read ~/.claude/skills/implementation-patterns/SKILL.md`
-    2. Your issues to resolve:
-       {batch 1 issues — full structured list with id, file, line, severity, type, description, suggested_fix}
-    3. For each issue:
-       a. Read the code context around file:line
-       b. Validate: is this a real issue or false positive?
-       c. If real: assess risk (LOW → FIX now, HIGH → defer to TECH_DEBT)
-       d. If FIX: implement the fix, commit with descriptive message
-       e. If TECH_DEBT: document why it's deferred
-    4. Report completion:
-       SendMessage(type: "message", recipient: "team-lead",
-         summary: "Batch 1: {n} fixed, {n} deferred, {n} false positive")
-
-- Name: "resolver-batch-2"
-  Prompt: |
-    You are resolving review issues on branch {branch} (PR #{pr_number}).
-    1. Read your skill: `Read ~/.claude/skills/implementation-patterns/SKILL.md`
-    2. Your issues to resolve:
-       {batch 2 issues — full structured list with id, file, line, severity, type, description, suggested_fix}
-    3. For each issue:
-       a. Read the code context around file:line
-       b. Validate: is this a real issue or false positive?
-       c. If real: assess risk (LOW → FIX now, HIGH → defer to TECH_DEBT)
-       d. If FIX: implement the fix, commit with descriptive message
-       e. If TECH_DEBT: document why it's deferred
-    4. Report completion:
-       SendMessage(type: "message", recipient: "team-lead",
-         summary: "Batch 2: {n} fixed, {n} deferred, {n} false positive")
-
-(Additional resolvers for additional batches — same pattern)
-
-After initial fixes complete, lead initiates cross-validation debate:
-SendMessage(type: "broadcast", summary: "Cross-validate: check for conflicts between fixes"):
-"Review each other's fixes. Does my fix in file-a conflict with your fix in file-b?
-Did either of us introduce a regression?"
-
-Resolvers cross-validate using direct messages:
-- SendMessage(type: "message", recipient: "resolver-batch-2", summary: "Conflict: interface change in file-a")
-  "My fix changes the interface used by your files — check imports"
-- SendMessage(type: "message", recipient: "resolver-batch-1", summary: "Confirmed: updating import")
-  "Confirmed — updating my import after your change"
-- SendMessage(type: "message", recipient: "team-lead", summary: "Escalation: conflicting fixes")
-  for unresolvable conflicts
-
-Max 2 debate rounds, then submit consensus resolution.
-```
-
-Shut down resolution team explicitly:
-
-```
-For each teammate in [resolver-batch-1, resolver-batch-2, ...]:
-  SendMessage(type: "shutdown_request", recipient: "{name}", content: "Resolution complete")
-  Wait for shutdown_response (approve: true)
-
-TeamDelete
-Verify TeamDelete succeeded. If failed, retry once after 5s. If retry fails, HALT.
-```
-
-For dependent batches that cannot run in parallel, spawn sequentially within the team and wait for completion before spawning dependents.
-
-### Phase 5: Collect Results
-
-Aggregate from all Resolvers:
-- **Fixed**: Issues resolved with commits
-- **False positives**: Issues that don't exist or were misunderstood
-- **Deferred**: High-risk issues marked for tech debt
-- **Blocked**: Issues that couldn't be fixed
-
-### Phase 6: Record Pitfalls (from tech debt deferrals)
-
-For each issue deferred as TECH_DEBT:
-1. Read `~/.claude/skills/knowledge-persistence/SKILL.md` and follow its extraction procedure to record pitfalls to `.memory/knowledge/pitfalls.md`
-2. Source field: `/resolve {branch}`
-3. Skip entirely if no TECH_DEBT deferrals
-
-### Phase 7: Simplify
-
-If any fixes were made, spawn Simplifier agent to refine the changed code:
-
-```
-Task(subagent_type="Simplifier", run_in_background=false):
-"TASK_DESCRIPTION: Issue resolution fixes
-FILES_CHANGED: {list of files modified by Resolvers}
-Simplify and refine the fixes for clarity and consistency"
-```
-
-### Phase 8: Manage Tech Debt
-
-If any issues were deferred, spawn Git agent:
-
-```
-Task(subagent_type="Git"):
-"OPERATION: manage-debt
-REVIEW_DIR: .docs/reviews/{branch-slug}/
-TIMESTAMP: {timestamp}
-Note: Deferred issues from resolution are already in resolution-summary.{timestamp}.md"
-```
-
-### Phase 9: Report
-
-**Write the resolution summary** to `.docs/reviews/{branch-slug}/resolution-summary.{timestamp}.md` using Write tool, then display:
-
-```
-## Resolution Summary
-
-**Branch**: {branch}
-**Reviews Processed**: {n} reports
-**Total Issues**: {n}
-
-### Results
-| Outcome | Count |
-|---------|-------|
-| Fixed | {n} |
-| False Positive | {n} |
-| Tech Debt | {n} |
-| Blocked | {n} |
-
-### Commits Created
-- {sha} {message}
-
-### Tech Debt Added
-- {n} items added to backlog
-
-### Artifacts
-- Resolution report: .docs/reviews/{branch}/resolution-summary.{timestamp}.md
-```
-
-## Architecture
-
-```
-/resolve (orchestrator - spawns teams and agents)
-│
-├─ Phase 0: Pre-flight
-│  └─ Git agent (validate-branch)
-│
-├─ Phase 1: Parse issues
-│  └─ Extract Blocking + Should-Fix (skip Pre-existing)
-│
-├─ Phase 2: Analyze dependencies
-│  └─ Build dependency graph
-│
-├─ Phase 3: Plan batches
-│  └─ Group issues, determine parallel vs sequential
-│
-├─ Phase 4: Resolve (Agent Teams with cross-validation)
-│  ├─ Resolver: Batch 1 (teammate)
-│  ├─ Resolver: Batch 2 (teammate)
-│  ├─ Resolver: Batch 3 (teammate, waits if depends on 1 or 2)
-│  └─ Cross-validation debate → consensus on conflicts
-│
-├─ Phase 5: Collect results
-│  └─ Aggregate fixed, false positives, deferred, blocked
-│
-├─ Phase 6: Record Pitfalls (inline, from tech debt deferrals)
-│
-├─ Phase 7: Simplify
-│  └─ Simplifier agent (refine fixes)
-│
-├─ Phase 8: Git agent (manage-debt)
-│  └─ Add deferred items to Tech Debt Backlog
-│
-└─ Phase 9: Display resolution summary
-```
-
-## Edge Cases
-
-| Case | Handling |
-|------|----------|
-| No reviews exist | Error message, suggest `/code-review` first |
-| All false positives | Normal completion, report shows 0 fixes |
-| Fix attempt fails | Revert changes, mark BLOCKED, continue others |
-| Issue dependencies | Sequential chain, skip dependents if predecessor blocked |
-| No actionable issues | Report "No issues to resolve" (all were pre-existing or LOW) |
-
-## Principles
-
-1. **Orchestration only** - Command spawns agents, doesn't do git/resolve work itself
-2. **Git agent for git work** - All git operations go through Git agent
-3. **Parallel execution** - Run independent batches in parallel
-4. **Conservative risk** - When Resolvers are unsure, defer to tech debt
-5. **Honest reporting** - Display agent outputs directly
-6. **Complete tracking** - Every issue gets a decision recorded
-
-## Output Artifact
-
-Written by orchestrator in Phase 9 to `.docs/reviews/{branch-slug}/resolution-summary.{timestamp}.md`:
-
-```markdown
-# Resolution Summary
-
-**Branch**: {branch} -> {base}
-**Date**: {timestamp}
-**Command**: /resolve
-
-## Statistics
-| Metric | Value |
-|--------|-------|
-| Total Issues | {n} |
-| Fixed | {n} |
-| False Positive | {n} |
-| Deferred | {n} |
-| Blocked | {n} |
-
-## Fixed Issues
-| Issue | File:Line | Commit |
-|-------|-----------|--------|
-| {description} | {file}:{line} | {sha} |
-
-## False Positives
-| Issue | File:Line | Reasoning |
-|-------|-----------|-----------|
-| {description} | {file}:{line} | {why} |
-
-## Deferred to Tech Debt
-| Issue | File:Line | Risk Factor |
-|-------|-----------|-------------|
-| {description} | {file}:{line} | {criteria} |
-
-## Blocked
-| Issue | File:Line | Blocker |
-|-------|-----------|---------|
-| {description} | {file}:{line} | {why} |
-```

package/plugins/devflow-resolve/commands/resolve.md

@@ -1,246 +0,0 @@
----
-description: Process review issues - validate, assess risk, fix low-risk issues, defer high-risk to tech debt
----
-
-# Resolve Command
-
-Process issues from code review reports: validate them (false positive check), assess risk for FIX vs TECH_DEBT decision, and implement fixes for low-risk issues.
-
-## Usage
-
-```
-/resolve           (resolve issues on current branch)
-/resolve #42       (resolve issues for specific PR)
-```
-
-## Phases
-
-### Phase 0: Pre-Flight (Git Agent)
-
-Spawn Git agent to validate branch state:
-
-```
-Task(subagent_type="Git", run_in_background=false):
-"OPERATION: validate-branch
-Check feature branch, clean working directory, reviews exist.
-Return: branch, branch-slug, PR#, review count"
-```
-
-**If BLOCKED:** Stop and report the blocker to user. If no reviews found, suggest `/code-review` first.
-
-**Extract from response:** `branch`, `branch_slug`, `pr_number`, `review_count` for use in subsequent phases.
-
-### Phase 1: Parse Issues
-
-Read all review reports from `.docs/reviews/{branch-slug}/*.md` and extract:
-
-**Include only:**
-- Blocking issues (CRITICAL, HIGH)
-- Should-Fix issues (HIGH, MEDIUM)
-
-**Skip:**
-- Pre-existing issues (belong in tech debt, not resolution)
-- LOW severity (informational only)
-
-**Extract per issue:**
-- `id`: Generated from file:line:type
-- `file`: Full path
-- `line`: Line number
-- `severity`: CRITICAL/HIGH/MEDIUM
-- `type`: Issue type from review
-- `description`: Problem statement
-- `suggested_fix`: From review report
-
-### Phase 2: Analyze Dependencies
-
-Group issues by relationship:
-
-1. **Same file** - Issues in same file go in same batch
-2. **Same function** - Issues affecting same function go together
-3. **Independent** - No relationship, can run in parallel
-
-Build dependency graph to determine execution order.
-
-### Phase 3: Plan Batches
-
-Create execution plan:
-- **Independent batches** - Mark for PARALLEL execution
-- **Dependent batches** - Mark for SEQUENTIAL execution
-- **Max 5 issues per batch** - Keep batches manageable
-
-### Phase 4: Resolve (Parallel where possible)
-
-Spawn Resolver agents based on dependency analysis. For independent batches, spawn **in a single message**:
-
-```
-Task(subagent_type="Resolver"):
-"ISSUES: [{issue1}, {issue2}, ...]
-BRANCH: {branch-slug}
-BATCH_ID: batch-{n}
-Validate, decide FIX vs TECH_DEBT, implement fixes"
-```
-
-For dependent batches, spawn sequentially and wait for completion before spawning dependents.
-
-### Phase 5: Collect Results
-
-Aggregate from all Resolvers:
-- **Fixed**: Issues resolved with commits
-- **False positives**: Issues that don't exist or were misunderstood
-- **Deferred**: High-risk issues marked for tech debt
-- **Blocked**: Issues that couldn't be fixed
-
-### Phase 6: Record Pitfalls (from tech debt deferrals)
-
-For each issue deferred as TECH_DEBT:
-1. Read `~/.claude/skills/knowledge-persistence/SKILL.md` and follow its extraction procedure to record pitfalls to `.memory/knowledge/pitfalls.md`
-2. Source field: `/resolve {branch}`
-3. Skip entirely if no TECH_DEBT deferrals
-
-### Phase 7: Simplify
-
-If any fixes were made, spawn Simplifier agent to refine the changed code:
-
-```
-Task(subagent_type="Simplifier", run_in_background=false):
-"TASK_DESCRIPTION: Issue resolution fixes
-FILES_CHANGED: {list of files modified by Resolvers}
-Simplify and refine the fixes for clarity and consistency"
-```
-
-### Phase 8: Manage Tech Debt
-
-If any issues were deferred, spawn Git agent:
-
-```
-Task(subagent_type="Git"):
-"OPERATION: manage-debt
-REVIEW_DIR: .docs/reviews/{branch-slug}/
-TIMESTAMP: {timestamp}
-Note: Deferred issues from resolution are already in resolution-summary.{timestamp}.md"
-```
-
-### Phase 9: Report
-
-**Write the resolution summary** to `.docs/reviews/{branch-slug}/resolution-summary.{timestamp}.md` using Write tool, then display:
-
-```
-## Resolution Summary
-
-**Branch**: {branch}
-**Reviews Processed**: {n} reports
-**Total Issues**: {n}
-
-### Results
-| Outcome | Count |
-|---------|-------|
-| Fixed | {n} |
-| False Positive | {n} |
-| Tech Debt | {n} |
-| Blocked | {n} |
-
-### Commits Created
-- {sha} {message}
-
-### Tech Debt Added
-- {n} items added to backlog
-
-### Artifacts
-- Resolution report: .docs/reviews/{branch}/resolution-summary.{timestamp}.md
-```
-
-## Architecture
-
-```
-/resolve (orchestrator - spawns agents only)
-│
-├─ Phase 0: Pre-flight
-│  └─ Git agent (validate-branch)
-│
-├─ Phase 1: Parse issues
-│  └─ Extract Blocking + Should-Fix (skip Pre-existing)
-│
-├─ Phase 2: Analyze dependencies
-│  └─ Build dependency graph
-│
-├─ Phase 3: Plan batches
-│  └─ Group issues, determine parallel vs sequential
-│
-├─ Phase 4: Resolve (PARALLEL where independent)
-│  ├─ Resolver: Batch 1 (file-a issues)
-│  ├─ Resolver: Batch 2 (file-b issues)
-│  └─ Resolver: Batch 3 (waits if depends on 1 or 2)
-│
-├─ Phase 5: Collect results
-│  └─ Aggregate fixed, false positives, deferred, blocked
-│
-├─ Phase 6: Record Pitfalls (inline, from tech debt deferrals)
-│
-├─ Phase 7: Simplify
-│  └─ Simplifier agent (refine fixes)
-│
-├─ Phase 8: Git agent (manage-debt)
-│  └─ Add deferred items to Tech Debt Backlog
-│
-└─ Phase 9: Display resolution summary
-```
-
-## Edge Cases
-
-| Case | Handling |
-|------|----------|
-| No reviews exist | Error message, suggest `/code-review` first |
-| All false positives | Normal completion, report shows 0 fixes |
-| Fix attempt fails | Revert changes, mark BLOCKED, continue others |
-| Issue dependencies | Sequential chain, skip dependents if predecessor blocked |
-| No actionable issues | Report "No issues to resolve" (all were pre-existing or LOW) |
-
-## Principles
-
-1. **Orchestration only** - Command spawns agents, doesn't do git/resolve work itself
-2. **Git agent for git work** - All git operations go through Git agent
-3. **Parallel execution** - Run independent batches in parallel
-4. **Conservative risk** - When Resolvers are unsure, defer to tech debt
-5. **Honest reporting** - Display agent outputs directly
-6. **Complete tracking** - Every issue gets a decision recorded
-
-## Output Artifact
-
-Written by orchestrator in Phase 9 to `.docs/reviews/{branch-slug}/resolution-summary.{timestamp}.md`:
-
-```markdown
-# Resolution Summary
-
-**Branch**: {branch} -> {base}
-**Date**: {timestamp}
-**Command**: /resolve
-
-## Statistics
-| Metric | Value |
-|--------|-------|
-| Total Issues | {n} |
-| Fixed | {n} |
-| False Positive | {n} |
-| Deferred | {n} |
-| Blocked | {n} |
-
-## Fixed Issues
-| Issue | File:Line | Commit |
-|-------|-----------|--------|
-| {description} | {file}:{line} | {sha} |
-
-## False Positives
-| Issue | File:Line | Reasoning |
-|-------|-----------|-----------|
-| {description} | {file}:{line} | {why} |
-
-## Deferred to Tech Debt
-| Issue | File:Line | Risk Factor |
-|-------|-----------|-------------|
-| {description} | {file}:{line} | {criteria} |
-
-## Blocked
-| Issue | File:Line | Blocker |
-|-------|-----------|---------|
-| {description} | {file}:{line} | {why} |
-```

package/plugins/devflow-resolve/skills/agent-teams/SKILL.md

@@ -1,124 +0,0 @@
----
-name: agent-teams
-description: This skill should be used when the user asks to "create an agent team", "spawn teammates", "set up debate protocol", "coordinate agents", or discusses peer-to-peer agent collaboration, consensus formation, or team-based workflows. Provides patterns for team spawning, message passing, adversarial debate, and quality gates driven by multi-agent consensus.
-user-invocable: false
-allowed-tools: Read, Grep, Glob
----
-
-# Agent Teams Patterns
-
-Patterns for collaborative multi-agent workflows using Claude Code's Agent Teams feature. Teams enable peer-to-peer communication between agents, replacing one-way subagent reporting with adversarial debate and consensus.
-
-## Iron Law
-
-> **TEAMMATES CHALLENGE EACH OTHER**
->
-> Every finding must survive peer scrutiny. No unchallenged claims reach the final
-> report. A single agent's opinion is a hypothesis; consensus from debate is a finding.
-
----
-
-## When This Activates
-
-- Creating agent teams for review, implementation, or debugging
-- Spawning teammates with distinct perspectives
-- Coordinating multi-agent debate rounds
-- Forming consensus from conflicting findings
-
-## Core Patterns
-
-### Team Spawning
-
-Size team to task complexity. Assign distinct, non-overlapping perspectives.
-
-| Task Complexity | Team Size | Rationale |
-|----------------|-----------|-----------|
-| Simple review | 2-3 | Security + architecture sufficient |
-| Full review | 4-5 | Core perspectives covered |
-| Debug investigation | 3-5 | One per hypothesis |
-| Implementation | 2-4 | Domain-separated work units |
-| Specification | 3-4 | Debate requirements before user gates |
-| Resolution | 2-4 | Cross-validate fixes across batches |
-
-**Model guidance**: Explorers/Reviewers inherit parent model. Validators use `model: haiku`.
-
-### Detection and Fallback
-
-Attempt `TeamCreate`. If it fails or the tool is unavailable, fall back to parallel subagents:
-
-```
-try TeamCreate → success → proceed with team workflow
-                → failure → fall back to parallel Task() calls
-```
-
-Always document which mode was used in the final report.
-
-### Task List Coordination
-
-Use `TaskCreate` to give each teammate a trackable work unit. Lead checks `TaskList` for structured progress visibility beyond ad-hoc messages:
-
-```
-1. Lead creates tasks for each teammate's work unit
-2. Teammates claim tasks via TaskUpdate (owner: self)
-3. Teammates mark tasks completed when done
-4. Lead checks TaskList before proceeding to next phase
-```
-
-### Challenge Protocol
-
-1. **Initial work**: Each teammate completes independent analysis
-2. **Exchange**: Lead broadcasts "Share findings and challenge others"
-3. **Direct debate**: Teammates message each other with evidence
-4. **Resolution**: Contradictions resolved through 1-2 exchanges
-5. **Escalation**: Unresolved after 2 exchanges → report disagreement to lead
-
-### Consensus Formation
-
-| Agreement Level | Confidence | Report As |
-|----------------|------------|-----------|
-| Unanimous | HIGH | Confirmed finding |
-| Majority (>50%) | MEDIUM | Finding with noted dissent |
-| Split (50/50) | LOW | Disagreement with both perspectives |
-
-### Team Cleanup
-
-Lead MUST always handle cleanup:
-1. Ensure all teammates have completed or been shut down
-2. Call `TeamDelete` to release resources
-3. Verify no orphaned sessions remain
-4. **CRITICAL**: Confirm cleanup completed before creating next team
-
----
-
-## Limitations
-
-| Limitation | Impact | Guidance |
-|-----------|--------|----------|
-| One team per session | Cannot run two teams concurrently | Shut down and verify cleanup before creating next team |
-| No nested teams | Teammates cannot spawn sub-teams | Keep hierarchy flat; only lead creates teams |
-| No session resumption | Teammate state lost if interrupted | Start fresh; don't rely on teammate state persistence |
-| Shutdown can be slow | Cleanup may take several seconds | Wait for confirmation; don't race to create next team |
-| Task status may lag | Task list updates aren't instant | Use direct messages for time-sensitive coordination |
-| Permissions inherited | Teammates get lead's permissions at spawn | Cannot escalate permissions mid-session |
-
----
-
-## Anti-Patterns
-
-| Anti-Pattern | Correct Approach |
-|-------------|-----------------|
-| Overlapping perspectives | Assign distinct, non-overlapping focus areas |
-| Skipping debate round | Always require peer challenge before synthesis |
-| Unlimited debate | Cap at 2 exchanges per topic, then escalate |
-| Lead does analysis work | Lead coordinates only; teammates do analysis |
-| Ignoring minority opinion | Report dissent with evidence in final output |
-| Creating team before prior cleanup | Wait for TeamDelete confirmation, then create |
-| Messaging-only coordination | Use task list for structured progress tracking |
-
----
-
-## Extended References
-
-- `references/team-patterns.md` - Team structures for review, implement, debug, specify, resolve workflows
-- `references/communication.md` - Message protocols, broadcast patterns, debate formats
-- `references/cleanup.md` - Session management, orphan detection, resource cleanup