devflow-kit 1.8.3 → 2.0.1

package/plugins/devflow-code-review/skills/performance-patterns/references/violations.md

@@ -1,354 +0,0 @@
-# Performance Violation Examples
-
-Extended violation patterns for performance reviews. Reference from main SKILL.md.
-
-## Algorithmic Violations
-
-### N+1 Query Variants
-
-**ORM Eager Loading Missing**
-```typescript
-// VIOLATION: Lazy loading triggers N queries
-const posts = await Post.findAll();
-for (const post of posts) {
-  console.log(post.author.name);  // N additional queries
-}
-```
-
-**GraphQL Resolver N+1**
-```typescript
-// VIOLATION: Resolver called per item
-const resolvers = {
-  Post: {
-    author: async (post) => {
-      return db.users.findById(post.authorId);  // N queries
-    }
-  }
-};
-```
-
-**Nested Loop Queries**
-```typescript
-// VIOLATION: Query inside nested loop
-for (const category of categories) {
-  for (const product of category.products) {
-    const reviews = await db.reviews.findByProductId(product.id);  // N*M queries
-  }
-}
-```
-
-### O(n^2) or Worse Patterns
-
-**Array.includes in Loop**
-```typescript
-// VIOLATION: O(n^2) - includes is O(n)
-function removeDuplicates(items: Item[]) {
-  const unique: Item[] = [];
-  for (const item of items) {
-    if (!unique.some(u => u.id === item.id)) {  // O(n) check each time
-      unique.push(item);
-    }
-  }
-  return unique;
-}
-```
-
-**Nested Array Methods**
-```typescript
-// VIOLATION: O(n*m) - filter inside map
-function matchItems(list1: Item[], list2: Item[]) {
-  return list1.map(item => ({
-    ...item,
-    matches: list2.filter(i => i.category === item.category)  // O(m) per item
-  }));
-}
-```
-
-**String Concatenation in Loop**
-```typescript
-// VIOLATION: O(n^2) string copies
-function buildCsv(rows: string[][]): string {
-  let csv = '';
-  for (const row of rows) {
-    csv += row.join(',') + '\n';  // Creates new string each time
-  }
-  return csv;
-}
-```
-
-### Inefficient Data Structure Usage
-
-**Object.keys/values/entries in Hot Path**
-```typescript
-// VIOLATION: Creates new array on each call
-function findInObject(obj: Record<string, Item>, predicate: (item: Item) => boolean) {
-  for (const key of Object.keys(obj)) {  // Allocates array
-    if (predicate(obj[key])) {
-      return obj[key];
-    }
-  }
-}
-```
-
-**Array as Queue/Stack**
-```typescript
-// VIOLATION: shift() is O(n)
-class Queue<T> {
-  private items: T[] = [];
-
-  dequeue(): T | undefined {
-    return this.items.shift();  // O(n) - reindexes entire array
-  }
-}
-```
-
----
-
-## Database Violations
-
-### Missing Index Patterns
-
-**Unindexed Foreign Key**
-```sql
--- VIOLATION: Joins without index
-SELECT * FROM orders o
-JOIN order_items oi ON o.id = oi.order_id  -- order_id likely unindexed
-WHERE o.customer_id = 123;
-```
-
-**Unindexed Filter Column**
-```typescript
-// VIOLATION: Filters on unindexed column
-const activeUsers = await db.query(
-  'SELECT * FROM users WHERE last_login > ?',  // last_login probably unindexed
-  [thirtyDaysAgo]
-);
-```
-
-**Composite Index Order Wrong**
-```sql
--- Index exists: (customer_id, status)
--- VIOLATION: Query doesn't use index efficiently
-SELECT * FROM orders WHERE status = 'pending';  -- Can't use composite index
-```
-
-### Inefficient Queries
-
-**LIKE with Leading Wildcard**
-```typescript
-// VIOLATION: Can't use index
-const results = await db.query(
-  'SELECT * FROM products WHERE name LIKE ?',
-  ['%laptop%']  // Leading % prevents index usage
-);
-```
-
-**OR Instead of IN**
-```typescript
-// VIOLATION: OR conditions often slower
-const users = await db.query(
-  'SELECT * FROM users WHERE status = ? OR status = ? OR status = ?',
-  ['active', 'pending', 'trial']
-);
-
-// Better: Use IN clause
-const users = await db.query(
-  'SELECT * FROM users WHERE status IN (?, ?, ?)',
-  ['active', 'pending', 'trial']
-);
-```
-
-**Sorting Without Index**
-```typescript
-// VIOLATION: ORDER BY on unindexed column causes filesort
-const recent = await db.query(
-  'SELECT * FROM logs ORDER BY created_at DESC LIMIT 100'  // No index on created_at
-);
-```
-
----
-
-## Memory Violations
-
-### Memory Leak Patterns
-
-**Closure Retaining Large Object**
-```typescript
-// VIOLATION: Closure keeps entire large object alive
-function processLargeData(data: LargeObject) {
-  return () => {
-    console.log(data.id);  // Only needs id, but retains entire data object
-  };
-}
-```
-
-**Timer Without Cleanup**
-```typescript
-// VIOLATION: Interval never cleared
-class Poller {
-  start() {
-    setInterval(() => this.poll(), 1000);  // Runs forever
-  }
-}
-```
-
-**Observable Without Unsubscribe**
-```typescript
-// VIOLATION: Subscription never cleaned up
-class Component {
-  init() {
-    eventBus.subscribe('update', this.handleUpdate);  // Memory leak
-  }
-  // Missing cleanup method
-}
-```
-
-### Large Allocation Patterns
-
-**Spreading in Reduce**
-```typescript
-// VIOLATION: Creates new object on each iteration
-const merged = items.reduce((acc, item) => ({
-  ...acc,  // Copies entire accumulator each time
-  [item.id]: item
-}), {});
-```
-
-**Array.concat in Loop**
-```typescript
-// VIOLATION: Creates new array each iteration
-let all: Item[] = [];
-for (const batch of batches) {
-  all = all.concat(batch);  // O(n^2) total allocations
-}
-```
-
-**JSON Clone in Hot Path**
-```typescript
-// VIOLATION: Full serialization/parsing
-function processItem(item: Item) {
-  const copy = JSON.parse(JSON.stringify(item));  // Expensive!
-  // ... modify copy
-}
-```
-
----
-
-## I/O Violations
-
-### Blocking Operations
-
-**Sync File Operations in Request Handler**
-```typescript
-// VIOLATION: Blocks event loop
-app.get('/config', (req, res) => {
-  const config = fs.readFileSync('./config.json');  // Blocks!
-  res.json(JSON.parse(config));
-});
-```
-
-**Sync Crypto Operations**
-```typescript
-// VIOLATION: CPU-intensive sync operation
-function hashPassword(password: string): string {
-  return crypto.pbkdf2Sync(password, salt, 100000, 64, 'sha512');  // Blocks!
-}
-```
-
-### Sequential vs Parallel
-
-**await in forEach (No Parallelism)**
-```typescript
-// VIOLATION: forEach doesn't wait, unpredictable behavior
-ids.forEach(async (id) => {
-  await processItem(id);  // Fire and forget!
-});
-```
-
-**Sequential Processing When Order Doesn't Matter**
-```typescript
-// VIOLATION: Could be parallel
-async function validateAll(items: Item[]) {
-  const results = [];
-  for (const item of items) {
-    results.push(await validate(item));  // Sequential but independent
-  }
-  return results;
-}
-```
-
-### Redundant Operations
-
-**Same Data Fetched Multiple Times**
-```typescript
-// VIOLATION: Duplicate API calls
-async function buildReport(userId: string) {
-  const user = await getUser(userId);
-  const profile = await getUserProfile(userId);  // Probably same data
-  const permissions = await getUserPermissions(userId);  // Another call
-}
-```
-
-**Cache Miss on Every Request**
-```typescript
-// VIOLATION: No caching strategy
-async function getConfig() {
-  return await fetchFromRemote('/config');  // Network call every time
-}
-```
-
----
-
-## Frontend Violations
-
-### Re-render Patterns
-
-**Inline Object/Array in JSX**
-```tsx
-// VIOLATION: New reference every render
-<Component
-  options={{ show: true, animate: false }}  // New object each render
-  items={[1, 2, 3]}  // New array each render
-/>
-```
-
-**Inline Arrow in JSX**
-```tsx
-// VIOLATION: New function every render
-<Button onClick={() => handleClick(item.id)} />  // New function each render
-```
-
-**Missing Key or Index as Key**
-```tsx
-// VIOLATION: Index as key breaks reconciliation
-{items.map((item, index) => (
-  <Item key={index} {...item} />  // Index key causes issues on reorder
-))}
-```
-
-### Missing Optimization
-
-**Expensive Computation Every Render**
-```tsx
-// VIOLATION: Recalculates on every render
-function Dashboard({ data }) {
-  const stats = computeExpensiveStats(data);  // Runs every render
-  return <Stats data={stats} />;
-}
-```
-
-**Unthrottled Event Handler**
-```tsx
-// VIOLATION: Fires on every scroll pixel
-window.addEventListener('scroll', () => {
-  updateParallax();  // 60+ calls per second
-});
-```
-
-**Large Component Tree Without Code Splitting**
-```tsx
-// VIOLATION: Loads everything upfront
-import HugeChartLibrary from 'huge-chart-lib';
-import RarelyUsedFeature from './RarelyUsedFeature';
-// All loaded even if not used
-```

package/plugins/devflow-code-review/skills/regression-patterns/SKILL.md

@@ -1,146 +0,0 @@
----
-name: regression-patterns
-description: This skill should be used when reviewing changes that may remove exports, change signatures, or alter behavior.
-user-invocable: false
-allowed-tools: Read, Grep, Glob
----
-
-# Regression Patterns
-
-Domain expertise for detecting functionality regressions and validating implementation intent. Use alongside `review-methodology` for complete regression reviews.
-
-## Iron Law
-
-> **WHAT WORKED BEFORE MUST WORK AFTER**
->
-> Every change carries regression risk. Removed exports break consumers. Changed signatures
-> break callers. Modified behavior breaks expectations. The burden of proof is on the change:
-> demonstrate no regression, or document the intentional breaking change.
-
----
-
-## Regression Categories
-
-### 1. Lost Functionality
-
-Features, exports, or capabilities that existed before but are missing after.
-
-| Type | Risk | Detection |
-|------|------|-----------|
-| Removed exports | Breaks consumers | Compare `export` statements |
-| Removed CLI options | Breaks scripts | Compare option definitions |
-| Removed API endpoints | Breaks clients | Compare route handlers |
-| Removed event handlers | Breaks integrations | Compare `.on()` calls |
-
-```typescript
-// VIOLATION: Export removed without deprecation
-// BEFORE: export function deleteUser(id: string): void { }
-// AFTER: (removed) - consumers will break!
-```
-
-### 2. Broken Behavior
-
-Code still exists but behaves differently in breaking ways.
-
-| Type | Risk | Detection |
-|------|------|-----------|
-| Changed return types | Null dereference | Compare function signatures |
-| Changed defaults | Unexpected behavior | Compare default values |
-| Removed side effects | Missing events/logs | Compare emit/log calls |
-| Changed error handling | Uncaught errors | Compare throw/return patterns |
-
-```typescript
-// VIOLATION: Return type widened without migration
-// BEFORE: function getUser(id: string): User { }
-// AFTER: function getUser(id: string): User | null { }
-// Callers assuming non-null will break!
-```
-
-### 3. Intent vs Reality Mismatch
-
-Commit message promises one thing, code does another.
-
-| Type | Risk | Detection |
-|------|------|-----------|
-| Commit says X, code does Y | False confidence | Compare message to diff |
-| Partial implementation | Incomplete feature | Check all stated changes |
-| Missing edge cases | Fragile code | Verify claimed coverage |
-
-```typescript
-// VIOLATION: Commit says "Add retry logic" but no retry implemented
-async function fetchData(): Promise<Data> {
-  return api.get('/data');  // No retry!
-}
-```
-
-### 4. Incomplete Migrations
-
-Old API deprecated but not all consumers updated.
-
-| Type | Risk | Detection |
-|------|------|-----------|
-| Some call sites updated | Mixed behavior | Search for old API usage |
-| Consumers not updated | Type errors | Check all importers |
-| Tests not updated | False passes | Compare test coverage |
-
-```typescript
-// VIOLATION: Migration incomplete
-// file1.ts: newFunction({ a, b })  // Updated
-// file2.ts: oldFunction(a, b)      // NOT updated!
-```
-
----
-
-## Quick Detection Commands
-
-```bash
-# Find removed exports
-git diff main...HEAD | grep "^-export"
-
-# Find removed files
-git diff main...HEAD --name-status | grep "^D"
-
-# Find incomplete migration (old API still used)
-grep -r "oldFunction" src/ --include="*.ts"
-
-# Find new TODOs (incomplete work)
-git diff main...HEAD | grep "^\+.*TODO"
-```
-
----
-
-## Extended References
-
-For extended examples and detection techniques:
-
-- **[violations.md](references/violations.md)** - Detailed violation examples for each category
-- **[patterns.md](references/patterns.md)** - Correct patterns for regression-safe changes
-- **[detection.md](references/detection.md)** - Comprehensive bash commands for detection
-
----
-
-## Severity Guidelines
-
-| Severity | Criteria | Examples |
-|----------|----------|----------|
-| **CRITICAL** | Breaking changes without migration | Public exports removed, return types incompatible, required params added |
-| **HIGH** | Significant behavior changes | Defaults changed, error handling changed, side effects removed |
-| **MEDIUM** | Moderate regression risk | Internal APIs changed, logging reduced, performance changed |
-| **LOW** | Minor concerns | Documentation drift, internal refactoring |
-
----
-
-## Regression Checklist
-
-Before approving changes:
-
-- [ ] No exports removed without deprecation
-- [ ] Return types backward compatible
-- [ ] Default values unchanged (or documented)
-- [ ] Side effects preserved (events, logging)
-- [ ] All consumers of changed code updated
-- [ ] Migration complete across codebase
-- [ ] CLI options preserved or deprecated
-- [ ] API endpoints preserved or versioned
-- [ ] Commit message matches implementation
-- [ ] Breaking changes documented in CHANGELOG

package/plugins/devflow-code-review/skills/review-methodology/SKILL.md

@@ -1,119 +0,0 @@
----
-name: review-methodology
-description: This skill should be used when performing a code review to apply the standard 6-step review process.
-user-invocable: false
-allowed-tools: Read, Grep, Glob, Bash
----
-
-# Review Methodology
-
-The canonical review process for all DevFlow review agents. Ensures consistent, fair, and actionable code reviews.
-
-## Iron Law
-
-> **NEVER BLOCK FOR PRE-EXISTING ISSUES**
->
-> Only issues in YOUR CHANGES can block a PR. Pre-existing issues are informational only.
-> If you didn't add it, you don't own it. Fair reviews focus on the diff, not the codebase.
-
-## Core Philosophy
-
-1. **Focus on changed lines first** - Developer introduced these
-2. **Context matters** - Issues near changes should be fixed together
-3. **Be fair** - Don't block PRs for legacy code
-4. **Be specific** - Exact file:line with examples
-5. **Be actionable** - Clear fixes, not vague complaints
-
----
-
-## 6-Step Review Process
-
-### Step 1: Identify Changed Lines
-
-Get the diff to understand what changed. Identify base branch and extract changed files/lines.
-
-### Step 2: Categorize Issues
-
-| Category | Scope | Priority | Action |
-|----------|-------|----------|--------|
-| **1. Issues in Your Changes** | Lines ADDED/MODIFIED in this branch | BLOCKING | Must fix before merge |
-| **2. Issues in Code You Touched** | Same file/function, but not your line | HIGH | Should fix while here |
-| **3. Pre-existing Issues** | Lines you didn't touch at all | INFORMATIONAL | Fix in separate PR |
-
-### Step 3: Analyze with Domain Expertise
-
-Apply your specialized lens (security, performance, tests, etc.) to each category:
-
-- **Category 1** - Maximum scrutiny, any issue blocks PR
-- **Category 2** - Should fix together with your changes
-- **Category 3** - Note but don't block, suggest separate issues
-
-### Step 4: Prioritize by Severity
-
-| Severity | Description | Examples |
-|----------|-------------|----------|
-| **CRITICAL** | Immediate risk, must fix | Security vulnerabilities, data loss risks, breaking API changes |
-| **HIGH** | Significant risk, should fix | Performance degradation, missing error handling |
-| **MEDIUM** | Moderate risk, consider fixing | Style inconsistencies, missing documentation |
-| **LOW** | Minor improvements | Naming suggestions, optional optimizations |
-
-### Step 5: Create Actionable Comments
-
-For each issue, provide:
-1. **Location** - Exact file:line reference
-2. **Problem** - Clear description
-3. **Impact** - Why this matters
-4. **Fix** - Specific code solution
-5. **Category** - Which of the 3 categories
-
-### Step 6: Generate Report
-
-Create report with all three issue sections, summary counts, and merge recommendation.
-
----
-
-## Key Principles Summary
-
-| Principle | Description |
-|-----------|-------------|
-| **Diff-Aware** | Focus on actual changes, not pre-existing issues |
-| **Fair** | Don't block PRs for legacy problems |
-| **Specific** | Exact file:line, not vague complaints |
-| **Actionable** | Show the fix, not just the problem |
-| **Categorized** | Clear distinction between blocking and informational |
-| **Prioritized** | Critical > High > Medium > Low |
-| **Documented** | Reports saved for future reference |
-
----
-
-## Extended References
-
-For detailed implementation:
-
-| Reference | Content |
-|-----------|---------|
-| `references/report-template.md` | Full report template with all sections |
-| `references/pr-comments.md` | PR comment API integration details |
-| `references/commands.md` | Bash commands for getting diffs and saving reports |
-
----
-
-## Integration
-
-This methodology is used by the **Reviewer** agent with different focus areas:
-
-| Focus | Pattern Skill |
-|-------|---------------|
-| `security` | security-patterns |
-| `performance` | performance-patterns |
-| `architecture` | architecture-patterns |
-| `tests` | test-patterns |
-| `consistency` | consistency-patterns |
-| `complexity` | complexity-patterns |
-| `regression` | regression-patterns |
-| `dependencies` | dependencies-patterns |
-| `documentation` | documentation-patterns |
-| `typescript` | typescript |
-| `database` | database-patterns |
-
-The Reviewer agent loads all pattern skills and applies the relevant one based on the focus area specified in its invocation prompt.