devflow-kit 1.8.3 → 2.0.1

package/plugins/devflow-accessibility/skills/accessibility/references/violations.md

@@ -1,419 +0,0 @@
-# Accessibility Violations
-
-Extended violation patterns for accessibility reviews. Reference from main SKILL.md.
-
-## Keyboard Navigation Violations
-
-### No Keyboard Access
-
-```tsx
-// VIOLATION: onClick without keyboard equivalent
-<div onClick={handleClick} className="card">
-  Click me
-</div>
-
-// VIOLATION: Custom element not focusable
-<span className="link" onClick={() => navigate('/page')}>
-  Go to page
-</span>
-
-// VIOLATION: Drag-only interaction
-<div
-  draggable
-  onDragStart={handleDrag}
-  onDragEnd={handleDrop}
->
-  Drag me (no keyboard alternative)
-</div>
-```
-
-### Missing Focus Management
-
-```tsx
-// VIOLATION: Modal doesn't trap focus
-function Modal({ isOpen, children }) {
-  return isOpen ? (
-    <div className="modal-overlay">
-      <div className="modal-content">
-        {children}
-        <button onClick={onClose}>Close</button>
-      </div>
-    </div>
-  ) : null;
-}
-
-// VIOLATION: Dropdown doesn't return focus on close
-function Dropdown() {
-  const [isOpen, setIsOpen] = useState(false);
-
-  return (
-    <div>
-      <button onClick={() => setIsOpen(true)}>Open</button>
-      {isOpen && (
-        <ul>
-          <li onClick={() => setIsOpen(false)}>Option 1</li>
-          {/* Focus lost when dropdown closes */}
-        </ul>
-      )}
-    </div>
-  );
-}
-```
-
-### Poor Focus Visibility
-
-```css
-/* VIOLATION: Focus removed entirely */
-*:focus {
-  outline: none;
-}
-
-/* VIOLATION: Focus invisible on dark backgrounds */
-button:focus {
-  outline: 1px solid #333;
-}
-
-/* VIOLATION: Focus style same as hover */
-button:hover,
-button:focus {
-  background: #eee;
-}
-```
-
-### Illogical Tab Order
-
-```tsx
-// VIOLATION: tabIndex breaks natural order
-<div>
-  <input tabIndex={3} placeholder="Third" />
-  <input tabIndex={1} placeholder="First" />
-  <input tabIndex={2} placeholder="Second" />
-</div>
-
-// VIOLATION: Positive tabIndex on many elements
-<nav>
-  <a href="/" tabIndex={1}>Home</a>
-  <a href="/about" tabIndex={2}>About</a>
-  <a href="/contact" tabIndex={3}>Contact</a>
-</nav>
-```
-
----
-
-## ARIA Violations
-
-### Missing Labels
-
-```tsx
-// VIOLATION: Icon button without accessible name
-<button onClick={handleClose}>
-  <CloseIcon />
-</button>
-
-// VIOLATION: Input without label
-<input type="text" placeholder="Search" />
-
-// VIOLATION: Image without alt
-<img src="/logo.png" />
-
-// VIOLATION: Link without text
-<a href="/profile">
-  <Avatar src={user.avatar} />
-</a>
-```
-
-### Incorrect ARIA Usage
-
-```tsx
-// VIOLATION: role="button" on already-button element
-<button role="button" onClick={handleClick}>Submit</button>
-
-// VIOLATION: aria-hidden on focusable element
-<button aria-hidden="true" onClick={handleClick}>
-  Hidden but focusable
-</button>
-
-// VIOLATION: Missing required ARIA attributes
-<div role="slider">
-  {/* Missing aria-valuenow, aria-valuemin, aria-valuemax */}
-</div>
-
-// VIOLATION: aria-label duplicating visible text
-<button aria-label="Submit form">Submit form</button>
-```
-
-### Overuse of ARIA
-
-```tsx
-// VIOLATION: ARIA where semantic HTML suffices
-<div role="navigation" aria-label="Main navigation">
-  <div role="list">
-    <div role="listitem">
-      <div role="link" onClick={() => navigate('/')}>Home</div>
-    </div>
-  </div>
-</div>
-
-// Should be:
-<nav aria-label="Main">
-  <ul>
-    <li><a href="/">Home</a></li>
-  </ul>
-</nav>
-```
-
----
-
-## Color and Contrast Violations
-
-### Insufficient Contrast
-
-```css
-/* VIOLATION: Light gray on white (1.5:1 ratio) */
-.muted-text {
-  color: #aaa;
-  background: #fff;
-}
-
-/* VIOLATION: Placeholder text too light */
-input::placeholder {
-  color: #ccc;
-}
-
-/* VIOLATION: Disabled state invisible */
-button:disabled {
-  color: #eee;
-  background: #f5f5f5;
-}
-```
-
-### Color-Only Information
-
-```tsx
-// VIOLATION: Status only indicated by color
-<span style={{ color: status === 'error' ? 'red' : 'green' }}>
-  {status}
-</span>
-
-// VIOLATION: Required fields only marked red
-<label style={{ color: required ? 'red' : 'inherit' }}>
-  {label}
-</label>
-
-// VIOLATION: Chart using only color to differentiate data
-<LineChart>
-  <Line stroke="red" data={series1} />
-  <Line stroke="blue" data={series2} />
-  {/* No pattern, icon, or label differentiation */}
-</LineChart>
-```
-
----
-
-## Form Violations
-
-### Missing Error Association
-
-```tsx
-// VIOLATION: Error not associated with input
-<div>
-  <input id="email" type="email" />
-  {error && <span className="error">{error}</span>}
-</div>
-
-// VIOLATION: Error not announced to screen readers
-<div>
-  <input aria-invalid={!!error} />
-  {error && <div className="error-message">{error}</div>}
-</div>
-```
-
-### Placeholder as Label
-
-```tsx
-// VIOLATION: Placeholder disappears, no persistent label
-<input placeholder="Email address" />
-
-// VIOLATION: Floating label without visible label initially
-function FloatingInput({ label }) {
-  const [value, setValue] = useState('');
-  return (
-    <div>
-      <input
-        value={value}
-        onChange={(e) => setValue(e.target.value)}
-      />
-      <label className={value ? 'floating' : 'hidden'}>{label}</label>
-    </div>
-  );
-}
-```
-
-### Form Not Keyboard Navigable
-
-```tsx
-// VIOLATION: Custom select not keyboard accessible
-function CustomSelect({ options, value, onChange }) {
-  const [isOpen, setIsOpen] = useState(false);
-
-  return (
-    <div className="select" onClick={() => setIsOpen(!isOpen)}>
-      <span>{value}</span>
-      {isOpen && (
-        <ul className="options">
-          {options.map(opt => (
-            <li onClick={() => onChange(opt)}>{opt}</li>
-          ))}
-        </ul>
-      )}
-    </div>
-  );
-}
-```
-
----
-
-## Motion and Animation Violations
-
-### No Reduced Motion Support
-
-```css
-/* VIOLATION: Animation ignores user preference */
-.hero {
-  animation: slideIn 1s ease-in-out;
-}
-
-@keyframes slideIn {
-  from { transform: translateY(100%); }
-  to { transform: translateY(0); }
-}
-```
-
-### Autoplay Without Pause
-
-```tsx
-// VIOLATION: Video autoplays without pause control
-<video autoPlay loop muted>
-  <source src="/background.mp4" />
-</video>
-
-// VIOLATION: Carousel auto-advances without pause
-function Carousel({ slides }) {
-  useEffect(() => {
-    const interval = setInterval(nextSlide, 3000);
-    return () => clearInterval(interval);
-  }, []);
-  // No pause on hover or focus
-}
-```
-
-### Flashing Content
-
-```css
-/* VIOLATION: Flash rate > 3 per second */
-@keyframes flash {
-  0%, 100% { opacity: 1; }
-  50% { opacity: 0; }
-}
-.alert {
-  animation: flash 0.2s infinite;
-}
-```
-
----
-
-## Touch Target Violations
-
-### Small Touch Targets
-
-```css
-/* VIOLATION: Icon buttons too small */
-.icon-btn {
-  width: 24px;
-  height: 24px;
-  padding: 4px;
-}
-
-/* VIOLATION: Inline links with no padding */
-.inline-link {
-  /* Natural text height only */
-}
-
-/* VIOLATION: Close button in corner */
-.modal-close {
-  position: absolute;
-  top: 4px;
-  right: 4px;
-  width: 16px;
-  height: 16px;
-}
-```
-
-### Targets Too Close Together
-
-```tsx
-// VIOLATION: Adjacent small targets
-<div className="button-group">
-  <button className="icon-btn">A</button>
-  <button className="icon-btn">B</button>
-  <button className="icon-btn">C</button>
-  {/* No spacing between 24px buttons */}
-</div>
-```
-
----
-
-## Screen Reader Violations
-
-### Hidden Important Content
-
-```tsx
-// VIOLATION: Visually hidden but important content
-<span className="sr-only">
-  Loading... {/* Never announced because sr-only wrong implementation */}
-</span>
-
-// VIOLATION: aria-hidden on important element
-<main aria-hidden="true">
-  {/* Page content hidden from AT */}
-</main>
-```
-
-### Meaningless Link Text
-
-```tsx
-// VIOLATION: Generic link text
-<p>
-  To learn more about our services, <a href="/services">click here</a>.
-</p>
-
-// VIOLATION: Repeated "Read more" links
-{posts.map(post => (
-  <article>
-    <h2>{post.title}</h2>
-    <p>{post.excerpt}</p>
-    <a href={post.url}>Read more</a>
-  </article>
-))}
-```
-
-### Missing Page Structure
-
-```tsx
-// VIOLATION: No landmark regions
-function App() {
-  return (
-    <div>
-      <div className="header">...</div>
-      <div className="sidebar">...</div>
-      <div className="content">...</div>
-      <div className="footer">...</div>
-    </div>
-  );
-}
-
-// VIOLATION: Skipped heading levels
-<h1>Page Title</h1>
-<h3>Section</h3>  {/* h2 skipped */}
-<h5>Subsection</h5>  {/* h4 skipped */}
-```

package/plugins/devflow-ambient/.claude-plugin/plugin.json

@@ -1,33 +0,0 @@
-{
-  "name": "devflow-ambient",
-  "description": "Ambient mode — intent classification with proportional agent orchestration",
-  "author": {
-    "name": "Dean0x"
-  },
-  "version": "1.8.3",
-  "homepage": "https://github.com/dean0x/devflow",
-  "repository": "https://github.com/dean0x/devflow",
-  "license": "MIT",
-  "keywords": [
-    "ambient",
-    "intent",
-    "classification",
-    "orchestration",
-    "agents"
-  ],
-  "agents": [
-    "coder",
-    "validator",
-    "simplifier",
-    "scrutinizer",
-    "shepherd",
-    "skimmer",
-    "reviewer"
-  ],
-  "skills": [
-    "ambient-router",
-    "implementation-orchestration",
-    "debug-orchestration",
-    "plan-orchestration"
-  ]
-}

package/plugins/devflow-ambient/README.md

@@ -1,68 +0,0 @@
-# devflow-ambient
-
-Ambient mode — classifies intent and applies proportional effort via a `UserPromptSubmit` hook. No slash command — ambient mode activates automatically on every prompt when enabled.
-
-## Activation
-
-```bash
-devflow ambient --enable    # Register UserPromptSubmit hook
-devflow ambient --disable   # Remove hook
-devflow ambient --status    # Check if enabled
-```
-
-When enabled, the hook injects a classification preamble before every prompt. Slash commands (`/implement`, `/code-review`, etc.) and short confirmations ("yes", "ok") are skipped automatically. Git operations (`commit`, `push`, `merge`, etc.) are fast-pathed to zero overhead.
-
-## How It Works
-
-1. **Classify intent** — IMPLEMENT, DEBUG, REVIEW, PLAN, EXPLORE, or CHAT
-2. **Classify depth** — QUICK, GUIDED, or ORCHESTRATED (scope-based)
-3. **Apply proportionally**:
-   - QUICK: respond normally (zero overhead)
-   - GUIDED: load skills, implement in main session, spawn Simplifier after code changes
-   - ORCHESTRATED: load skills, orchestrate full agent pipeline
-
-## Three-Tier Classification
-
-| Depth | When | What Happens |
-|-------|------|-------------|
-| QUICK | Chat, exploration, git ops, config, trivial edits | Zero overhead — respond normally |
-| GUIDED | Small-scope IMPLEMENT (≤2 files), clear DEBUG, focused PLAN, REVIEW | Load skills → main session works → Simplifier cleanup |
-| ORCHESTRATED | Large-scope IMPLEMENT (>2 files), vague DEBUG, system-level PLAN | Load skills → spawn agent pipeline |
-
-### Intent × Depth Matrix
-
-| Intent | GUIDED | ORCHESTRATED |
-|--------|--------|-------------|
-| IMPLEMENT | ≤2 files, single module | >2 files, multi-module |
-| DEBUG | Clear error with stack trace/location | Vague/cross-cutting bug |
-| PLAN | Focused design question | System-level architecture |
-| REVIEW | Always GUIDED | — |
-
-## GUIDED Behavior
-
-Skills are loaded via the Skill tool and work happens in the main session:
-
-| Intent | Skills | Main Session Work | Post-Work |
-|--------|--------|-------------------|-----------|
-| IMPLEMENT | test-driven-development, implementation-patterns, search-first | Implement with TDD | `Task(subagent_type="Simplifier")` |
-| DEBUG | core-patterns, test-patterns | Investigate, diagnose, fix | `Task(subagent_type="Simplifier")` |
-| PLAN | implementation-patterns, core-patterns | Explore and design | — |
-| REVIEW | self-review, core-patterns | Review directly | — |
-
-## ORCHESTRATED Pipelines
-
-| Intent | Pipeline |
-|--------|----------|
-| IMPLEMENT | Pre-flight → Coder → Validator → Simplifier → Scrutinizer → Shepherd |
-| DEBUG | Hypotheses → parallel Explores → convergence → report → offer fix |
-| PLAN | Skimmer → Explores → Plan agent → gap validation |
-
-These are lightweight variants of `/implement`, `/debug`, and the Plan phase of `/implement` — focused on the immediate task without full lifecycle features (PR creation, knowledge persistence, retry loops).
-
-## Skills
-
-- `ambient-router` — Intent + depth classification, skill selection matrix
-- `test-driven-development` — TDD enforcement for IMPLEMENT (GUIDED + ORCHESTRATED)
-- `implementation-orchestration` — Agent pipeline for IMPLEMENT/ORCHESTRATED
-- `debug-orchestration` — Agent pipeline for DEBUG/ORCHESTRATED
-- `plan-orchestration` — Agent pipeline for PLAN/ORCHESTRATED

package/plugins/devflow-ambient/agents/coder.md

@@ -1,135 +0,0 @@
----
-name: Coder
-description: Autonomous task implementation on feature branch. Implements, tests, and commits.
-model: inherit
-skills: core-patterns, git-safety, implementation-patterns, git-workflow, test-patterns, test-driven-development, search-first, input-validation
----
-
-# Coder Agent
-
-You are an autonomous implementation specialist working on a feature branch. You receive a task with an execution plan from the orchestrator and implement it completely, including testing and committing. You operate independently, making implementation decisions without requiring approval for each step.
-
-## Input Context
-
-You receive from orchestrator:
-- **TASK_ID**: Unique identifier (e.g., "task-2025-01-15_1430")
-- **TASK_DESCRIPTION**: What to implement
-- **BASE_BRANCH**: Branch this feature branch was created from (PR target)
-- **EXECUTION_PLAN**: Synthesized plan with steps, files, tests
-- **PATTERNS**: Codebase patterns to follow
-- **CREATE_PR**: Whether to create PR when done (true/false)
-
-**Domain hint** (optional):
-- **DOMAIN**: `backend` | `frontend` | `tests` | `fullstack` - Load/apply relevant domain skills
-
-**Sequential execution context** (when part of multi-Coder chain):
-- **PRIOR_PHASE_SUMMARY**: Implementation summary from previous Coder (see format below)
-- **FILES_FROM_PRIOR_PHASE**: Files created that must be read and understood
-- **HANDOFF_REQUIRED**: true if another Coder follows this one
-
-## Responsibilities
-
-1. **Orient on branch state** (always, before any implementation):
-   - Run `git log --oneline --stat -n 10` to scan recent commit history on this branch
-   - Run `git status` and `git diff --stat` and `git diff --cached --stat` to see uncommitted/unstaged work
-   - Cross-reference changed files against EXECUTION_PLAN to identify what's relevant to your task
-   - Read those relevant files to understand interfaces, types, naming conventions, error handling, and testing patterns established by prior work
-   - If PRIOR_PHASE_SUMMARY is provided, use it to validate your understanding — actual code is authoritative, summaries are supplementary
-   - If `.memory/knowledge/decisions.md` exists, read it. Apply prior architectural decisions relevant to this task. Avoid contradicting accepted decisions without documenting a new ADR.
-   - If `.memory/knowledge/pitfalls.md` exists, scan for pitfalls in files you're about to modify.
-
-2. **Load domain skills**: Based on DOMAIN hint and files in scope, dynamically load relevant language/ecosystem skills by reading their SKILL.md. Only load skills that are installed:
-   - `backend` (TypeScript): Read `~/.claude/skills/typescript/SKILL.md`, `~/.claude/skills/input-validation/SKILL.md`
-   - `backend` (Go): Read `~/.claude/skills/go/SKILL.md`
-   - `backend` (Java): Read `~/.claude/skills/java/SKILL.md`
-   - `backend` (Python): Read `~/.claude/skills/python/SKILL.md`
-   - `backend` (Rust): Read `~/.claude/skills/rust/SKILL.md`
-   - `frontend`: Read `~/.claude/skills/react/SKILL.md`, `~/.claude/skills/typescript/SKILL.md`, `~/.claude/skills/accessibility/SKILL.md`, `~/.claude/skills/frontend-design/SKILL.md`
-   - `tests`: Read `~/.claude/skills/test-patterns/SKILL.md`, `~/.claude/skills/typescript/SKILL.md`
-   - `fullstack`: Combine backend + frontend skills
-   - If a Read fails (skill not installed), skip it silently and continue.
-
-3. **Implement the plan**: Work through execution steps systematically, creating and modifying files. Follow existing patterns. Type everything. Use Result types if codebase uses them.
-
-4. **Write tests**: Add tests for new functionality. Cover happy path, error cases, and edge cases. Follow existing test patterns.
-
-5. **Run tests**: Execute the test suite. Fix any failures. All tests must pass before proceeding.
-
-6. **Commit and push**: Create atomic commits with clear messages. Reference TASK_ID. Push to remote.
-
-7. **Create PR** (if CREATE_PR=true): Create pull request against BASE_BRANCH with summary and testing notes.
-
-8. **Generate handoff** (if HANDOFF_REQUIRED=true): Include implementation summary for next Coder (see Output section).
-
-## Principles
-
-1. **Work on feature branch** - All operations happen on the current feature branch
-2. **Branch orientation first** - Always orient on branch state before writing code; actual code is authoritative over summaries
-3. **Pattern discovery first** - Before writing code, find similar implementations and match their conventions
-4. **Be decisive** - Make confident implementation choices. Don't present alternatives or ask permission for tactical decisions
-5. **Follow existing patterns** - Match codebase style, don't invent new conventions
-6. **Small, focused changes** - Don't scope creep beyond the plan
-7. **Fail honestly** - If blocked, report clearly with what was completed
-
-## Output
-
-Return structured completion status:
-
-```markdown
-## Coder Report: {TASK_ID}
-
-### Status: COMPLETE | FAILED | BLOCKED
-
-### Implementation
-- Files created: {n}
-- Files modified: {n}
-- Tests added: {n}
-
-### Commits
-- {sha} {message}
-
-### PR (if created)
-- URL: {pr_url}
-
-### Key Decisions (if any)
-- {Decision}: {rationale}
-
-### Blockers (if any)
-{Description of blocker or failure with recommendation}
-```
-
-**If HANDOFF_REQUIRED=true**, append implementation summary for next Coder:
-
-```markdown
-## Phase {N} Implementation Summary
-
-### Files Created/Modified
-- `path/file.ts` - {purpose, key exports}
-
-### Patterns Established
-- Naming: {e.g., "UserRepository pattern for data access"}
-- Error handling: {e.g., "Result types with DomainError"}
-- Testing: {e.g., "Integration tests in tests/integration/"}
-
-### Key Decisions
-- {Decision with rationale}
-
-### Integration Points for Next Phase
-- {Interfaces to implement against}
-- {Functions to call}
-- {Types to import}
-```
-
-## Boundaries
-
-**Escalate to orchestrator:**
-- Discovered dependency on another task
-- Scope significantly larger than planned
-- Breaking changes to shared interfaces
-- Prior phase code is broken or incomplete (in sequential execution)
-
-**Never:**
-- Switch branches during implementation
-- Push to branches other than your feature branch
-- Merge PRs (orchestrator handles this)
-- Trust handoff summaries without reading actual code