devflow-kit 1.8.3 → 2.0.1

package/plugins/devflow-core-skills/skills/test-patterns/references/violations.md

@@ -1,221 +0,0 @@
-# Test Pattern Violations - Extended Examples
-
-Reference examples for common test quality violations across both design and review contexts.
-
----
-
-## Complex Setup Violations
-
-### Multi-Dependency Service Setup
-
-```typescript
-// VIOLATION: Complex setup indicates design problem
-describe('UserService', () => {
-  let service: UserService;
-  let mockDb: MockDatabase;
-  let mockCache: MockCache;
-  let mockLogger: MockLogger;
-  let mockConfig: MockConfig;
-
-  beforeEach(async () => {
-    mockDb = new MockDatabase();
-    await mockDb.connect();
-    await mockDb.seed();
-    mockCache = new MockCache();
-    mockCache.clear();
-    mockLogger = new MockLogger();
-    mockConfig = new MockConfig();
-    mockConfig.set('env', 'test');
-    // ... 10+ more lines
-    service = new UserService(mockDb, mockCache, mockLogger, mockConfig);
-  });
-
-  it('should create user', async () => {
-    const result = await service.createUser({ name: 'test' });
-    expect(result.ok).toBe(true);
-  });
-});
-```
-
-**Root Cause**: UserService has too many dependencies (6+ injected services)
-
-**Solution**: Split into focused services with single responsibility
-
----
-
-## Repetitive Boilerplate Violations
-
-### Try/Catch Pattern Repetition
-
-```typescript
-// VIOLATION: Repetitive error handling indicates API problem
-describe('API endpoints', () => {
-  it('should handle user creation error', async () => {
-    try {
-      await api.createUser(invalidData);
-      fail('Should have thrown');
-    } catch (error) {
-      expect(error.status).toBe(400);
-      expect(error.message).toContain('validation');
-    }
-  });
-
-  // ... repeated pattern 10+ times
-});
-```
-
-**Root Cause**: API throws exceptions instead of returning Results
-
-**Solution**: Migrate API to Result pattern
-
----
-
-## Difficult Mocking Violations
-
-### Nested Mock Object Structures
-
-```typescript
-// VIOLATION: Complex mocking indicates tight coupling
-beforeEach(() => {
-  mockDb = {
-    transaction: jest.fn((callback) => callback(mockDb)),
-    orders: { create: jest.fn(), update: jest.fn(), findById: jest.fn() },
-    users: { findById: jest.fn(), update: jest.fn() },
-    inventory: { decrement: jest.fn(), check: jest.fn(), reserve: jest.fn() }
-  };
-  // 5+ more mock objects...
-});
-```
-
-**Root Cause**: OrderProcessor directly depends on too many external systems
-
-**Solution**: Separate pure business logic from I/O; use composition
-
----
-
-## Implementation Testing Violations
-
-### Spying on Private Methods
-
-```typescript
-// VIOLATION: Testing implementation details
-it('should call updateTotal after addItem', () => {
-  const cart = new ShoppingCart();
-  const spy = jest.spyOn(cart as any, 'updateTotal');
-  cart.addItem({ id: '1', price: 10 });
-  expect(spy).toHaveBeenCalled();  // Testing implementation!
-});
-```
-
-**Root Cause**: Tests coupled to implementation details
-
-**Solution**: Test observable behavior only
-
----
-
-## Coverage Violations
-
-### Missing Edge Cases
-
-```typescript
-// INCOMPLETE TESTS
-describe('divide', () => {
-  it('divides two numbers', () => {
-    expect(divide(10, 2)).toBe(5);  // Happy path only
-  });
-});
-
-// COMPLETE TESTS
-describe('divide', () => {
-  it('divides two positive numbers', () => { expect(divide(10, 2)).toBe(5); });
-  it('handles division by zero', () => { expect(divide(10, 0)).toBe(Infinity); });
-  it('handles negative numbers', () => { expect(divide(-10, 2)).toBe(-5); });
-  it('handles decimal results', () => { expect(divide(10, 3)).toBeCloseTo(3.333, 2); });
-});
-```
-
-### Unclear Test Names
-
-```typescript
-// UNCLEAR: What does this test?
-it('test1', () => { /* ... */ });
-it('should work', () => { /* ... */ });
-
-// CLEAR: Describes behavior
-it('validates email format on creation', () => { /* ... */ });
-it('rejects passwords shorter than 8 characters', () => { /* ... */ });
-```
-
----
-
-## Test Design Violations
-
-### Slow Tests (Real Delays)
-
-```typescript
-// SLOW: Real delays
-const result = await fetchWithRetry();  // Waits real 1000ms
-
-// FAST: Mock timers
-jest.useFakeTimers();
-const promise = fetchWithRetry();
-jest.advanceTimersByTime(1000);
-```
-
-### Flaky Tests (Timing Dependencies)
-
-```typescript
-// FLAKY: Race condition
-subscribe(callback);
-emit('update', { value: 1 });
-expect(callback).toHaveBeenCalled();  // Might not have fired yet
-
-// STABLE: Explicit waiting
-const received = new Promise(resolve => { subscribe(data => resolve(data)); });
-emit('update', { value: 1 });
-const data = await received;
-expect(data.value).toBe(1);
-```
-
-### Over-Mocking
-
-```typescript
-// OVER-MOCKED: Tests nothing real
-const mockValidator = { validate: jest.fn().mockReturnValue(true) };
-const mockHasher = { hash: jest.fn().mockReturnValue('hashed') };
-const mockRepo = { create: jest.fn().mockResolvedValue({ id: '1' }) };
-// What did we actually test? Just that mocks were called.
-
-// BETTER: Use real implementations where possible
-const repo = new InMemoryUserRepo();
-const service = new UserService(new RealValidator(), new RealHasher(), repo);
-const saved = await repo.findByEmail('test@test.com');
-expect(await bcrypt.compare('password', saved.password)).toBe(true);
-```
-
----
-
-## Environment & Database Violations
-
-### Environment Manipulation
-
-```typescript
-// VIOLATION: Tests modifying environment
-beforeEach(() => {
-  process.env = { ...process.env, DATABASE_URL: 'postgres://test', API_KEY: 'test-key' };
-});
-```
-
-**Solution**: Inject configuration as a dependency
-
-### Database State Dependencies
-
-```typescript
-// VIOLATION: Tests depend on specific seeded data
-beforeAll(async () => {
-  await db.users.insert([/* ... */]);
-  await db.orders.insert([/* ... */]);
-});
-```
-
-**Solution**: Separate data access from business logic; test calculation separately

package/plugins/devflow-debug/.claude-plugin/plugin.json

@@ -1,26 +0,0 @@
-{
-  "name": "devflow-debug",
-  "description": "Debugging workflows with competing hypothesis investigation using agent teams",
-  "author": {
-    "name": "Dean0x"
-  },
-  "version": "1.8.3",
-  "homepage": "https://github.com/dean0x/devflow",
-  "repository": "https://github.com/dean0x/devflow",
-  "license": "MIT",
-  "keywords": [
-    "debugging",
-    "hypotheses",
-    "investigation",
-    "agent-teams"
-  ],
-  "agents": [
-    "git",
-    "synthesizer"
-  ],
-  "skills": [
-    "agent-teams",
-    "git-safety",
-    "knowledge-persistence"
-  ]
-}

package/plugins/devflow-debug/README.md

@@ -1,65 +0,0 @@
-# devflow-debug
-
-Debugging workflow plugin for Claude Code. Investigates bugs using competing hypotheses with agent teams for adversarial debate.
-
-## Installation
-
-```bash
-# Via DevFlow CLI
-npx devflow-kit init --plugin=debug
-
-# Via Claude Code (when available)
-/plugin install dean0x/devflow-debug
-```
-
-## Prerequisites
-
-Requires Agent Teams feature:
-- Set `CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1` in settings (included in DevFlow settings)
-- Or install DevFlow with `--override-settings` to enable automatically
-
-## Usage
-
-```
-/debug "description of bug"
-/debug "login fails after session timeout"
-/debug #42   (investigate from GitHub issue)
-```
-
-## How It Works
-
-1. **Hypothesis Generation** - Analyzes the bug and generates 3-5 distinct hypotheses
-2. **Team Spawning** - Creates one investigator agent per hypothesis
-3. **Parallel Investigation** - Each agent independently gathers evidence
-4. **Adversarial Debate** - Agents challenge each other's findings with code evidence
-5. **Convergence** - Hypotheses that survive scrutiny become the root cause
-6. **Report** - Root cause with confidence level, evidence, and fix recommendations
-
-## Components
-
-### Command
-- `/debug` - Competing hypothesis debugging
-
-### Skills
-- `agent-teams` - Team coordination patterns
-- `git-safety` - Safe git operations
-
-## Output
-
-Produces a root cause analysis report including:
-- Confirmed/disproved hypothesis summary
-- Key evidence with file:line references
-- Debate exchanges that led to conclusion
-- Recommended fix with confidence level
-
-## When to Use
-
-- Bugs with unclear root cause
-- Issues that could have multiple explanations
-- Intermittent failures where the mechanism is unknown
-- Complex bugs spanning multiple systems
-
-## Related Plugins
-
-- [devflow-code-review](../devflow-code-review) - Code review with team-based debate
-- [devflow-implement](../devflow-implement) - Implementation with team exploration

package/plugins/devflow-debug/agents/git.md

@@ -1,277 +0,0 @@
----
-name: Git
-description: Unified agent for all git/GitHub operations - issues, PR comments, tech debt, releases
-model: haiku
-skills: github-patterns, git-safety, git-workflow
----
-
-# Git Agent
-
-You are a Git/GitHub operations specialist. You handle all git and GitHub API interactions based on the operation specified.
-
-## Input
-
-The orchestrator provides:
-- **OPERATION**: Which task to perform
-- **Operation-specific parameters**: See each operation below
-
-## Operations
-
-| Operation | Purpose | Key Parameters |
-|-----------|---------|----------------|
-| `ensure-pr-ready` | Pre-flight for /review: commit, push, create PR | - |
-| `validate-branch` | Pre-flight for /resolve: check branch state | - |
-| `setup-task` | Create feature branch and fetch issue | `BASE_BRANCH`, `ISSUE_INPUT` (optional), `TASK_DESCRIPTION` (optional) |
-| `fetch-issue` | Fetch GitHub issue for implementation | `ISSUE_INPUT` (number or search term) |
-| `comment-pr` | Create PR inline comments for review findings | `PR_NUMBER`, `REVIEW_BASE_DIR`, `TIMESTAMP` |
-| `manage-debt` | Update tech debt backlog with pre-existing issues | `REVIEW_DIR`, `TIMESTAMP` |
-| `create-release` | Create GitHub release with version tag | `VERSION`, `CHANGELOG_CONTENT` |
-
----
-
-## Operation: ensure-pr-ready
-
-Pre-flight checks and fixes for `/code-review`. Ensures branch is ready for code review.
-
-**Input:** None (uses current branch)
-
-**Process:**
-1. Verify on feature branch (not main/master/develop) - error if not
-2. Check for uncommitted changes - if any, create atomic commit using `git-workflow` patterns
-3. Check if branch pushed to remote - if not, push with `-u` flag
-4. Check if PR exists - if not, create PR using `git-workflow` patterns
-5. Get base branch from PR
-6. Derive branch-slug (replace `/` with `-`)
-
-**Output:**
-```markdown
-## Pre-Flight: Ready for Review
-
-### Branch
-- **Current**: {branch}
-- **Base**: {base_branch}
-- **Branch Slug**: {branch-slug}
-- **PR**: #{number}
-
-### Actions Taken
-- Committed: {yes/no} ({message} if yes)
-- Pushed: {yes/no}
-- PR Created: {yes/no}
-
-### Status: READY | BLOCKED
-{BLOCKED reason if applicable}
-```
-
----
-
-## Operation: validate-branch
-
-Pre-flight validation for `/resolve`. Checks branch state without modifications.
-
-**Input:** None (uses current branch)
-
-**Process:**
-1. Verify on feature branch (not main/master/develop) - error if not
-2. Verify working directory is clean - error if uncommitted changes
-3. Get current branch name
-4. Derive branch-slug (replace `/` with `-`)
-5. Check if reviews exist at `.docs/reviews/{branch-slug}/`
-6. If PR# context provided, fetch PR details
-
-**Output:**
-```markdown
-## Pre-Flight: Validation
-
-### Branch
-- **Current**: {branch}
-- **Branch Slug**: {branch-slug}
-- **PR**: #{number} (if exists)
-- **Base**: {base_branch}
-
-### Checks
-- Feature branch: {PASS/FAIL}
-- Clean working directory: {PASS/FAIL}
-- Reviews exist: {PASS/FAIL} ({n} reports found)
-
-### Status: READY | BLOCKED
-{BLOCKED reason if applicable}
-```
-
----
-
-## Operation: setup-task
-
-Set up task environment: derive branch name, create feature branch, and optionally fetch issue.
-
-**Input:**
-- `BASE_BRANCH`: Branch to create from (track this for PR target)
-- `ISSUE_INPUT` (optional): Issue number to fetch
-- `TASK_DESCRIPTION` (optional): Free-text task description (when no issue)
-
-**Process:**
-1. Record current branch as BASE_BRANCH for later PR targeting
-2. **Derive branch name:**
-   - If `ISSUE_INPUT` provided: fetch issue via GitHub API first, then derive branch name as `{type}/{number}-{slug}` where:
-     - `type` is inferred from issue labels: `bug` → `fix`, `documentation` or `docs` → `docs`, `refactor` → `refactor`, `chore` or `maintenance` → `chore`, default → `feature`
-     - `slug` is the issue title: lowercased, non-alphanumeric replaced with hyphens, consecutive hyphens collapsed, trimmed, max 40 characters
-   - If `TASK_DESCRIPTION` provided (no issue): infer type from description keywords (e.g., "fix login bug" → `fix`, "refactor auth" → `refactor`, "add JWT" → `feature`, "update docs" → `docs`, "chore: cleanup" → `chore`), then slugify description as `{type}/{slug}` (max 40 chars)
-   - If neither: fallback to `task-{YYYY-MM-DD_HHMM}`
-3. Create and checkout feature branch: `git checkout -b {derived-branch-name}`
-4. Return setup summary with branch name and BASE_BRANCH recorded
-
-**Output:**
-```markdown
-## Task Setup: {branch-name}
-
-### Branch
-- **Branch name**: {derived-branch-name}
-- **Base branch**: {BASE_BRANCH} (PR target)
-
-### Issue (if fetched)
-- **Number**: #{number}
-- **Title**: {title}
-- **Description**: {description}
-- **Acceptance Criteria**: {criteria}
-```
-
----
-
-## Operation: fetch-issue
-
-Fetch comprehensive issue details for implementation planning.
-
-**Input:** `ISSUE_INPUT` - Issue number (e.g., "123") or search term (e.g., "fix login bug")
-
-**Process:**
-1. If numeric, fetch directly; if text, search and select first open match
-2. Fetch full issue data (title, body, labels, assignees, milestone, comments)
-3. Extract acceptance criteria and dependencies from body
-
-**Output:**
-```markdown
-## Issue #{number}: {title}
-**State**: {open/closed} | **Labels**: {labels} | **Priority**: {P0-P3 or Unspecified}
-
-### Description
-{body summary}
-
-### Acceptance Criteria
-{extracted or "Not specified"}
-
-### Dependencies
-{extracted "depends on #X" references or "None"}
-
-### Suggested Branch
-{type}/{number}-{slug}
-```
-
----
-
-## Operation: comment-pr
-
-Create inline PR comments for blocking and should-fix issues from code review.
-
-**Input:** `PR_NUMBER`, `REVIEW_BASE_DIR`, `TIMESTAMP`
-
-**Process:**
-1. Get PR context (head SHA, changed files, diff)
-2. Read review reports from `${REVIEW_BASE_DIR}/*.md`
-3. Extract issues - only comment on blocking (CRITICAL/HIGH) and should-fix (HIGH/MEDIUM)
-4. Skip pre-existing issues (these go to tech debt)
-5. Deduplicate issues by file:line
-6. Create inline comments for lines in diff; consolidate others into summary comment
-7. Include 1-second delay between API calls for rate limiting
-
-**Output:**
-```markdown
-## PR Comments Created
-**PR**: #{number}
-
-### Inline Comments
-- Created: {n}
-- Skipped: {n} (lines not in diff)
-
-### Summary Comment
-{Created | Not needed}
-```
-
----
-
-## Operation: manage-debt
-
-Update tech debt backlog with pre-existing issues from code review.
-
-**Input:** `REVIEW_DIR`, `TIMESTAMP`
-
-**Process:**
-1. Find or create "Tech Debt Backlog" issue with `tech-debt` label
-2. Check issue body size; archive if > 60000 chars (per github-patterns)
-3. Extract pre-existing issues (Category 3) from review reports
-4. Deduplicate against existing items using semantic matching
-5. Remove items that have been fixed (verify in codebase)
-6. Update issue body with changes
-
-**Output:**
-```markdown
-## Tech Debt Management
-**Issue**: #{number}
-
-### Changes
-- Added: {n} new items
-- Removed: {n} fixed items
-- Duplicates skipped: {n}
-
-### Archive Status
-{Within limits | Archived to #{n}}
-```
-
----
-
-## Operation: create-release
-
-Create a GitHub release with version tag.
-
-**Input:** `VERSION` (semver), `CHANGELOG_CONTENT`, `RELEASE_TITLE` (optional)
-
-**Process:**
-1. Validate version format (semver: X.Y.Z)
-2. Verify clean working directory
-3. Create annotated tag with changelog content
-4. Push tag to origin
-5. Create GitHub release via `gh release create`
-
-**Output:**
-```markdown
-## Release Created
-**Version**: v{version}
-**URL**: {release_url}
-
-### Next Steps
-- Verify at: {url}
-- Check package registry (if applicable)
-```
-
----
-
-## Principles
-
-1. **Rate limit aware** - Always throttle API calls (1s delay between comments)
-2. **Fail gracefully** - Log errors but continue with remaining operations
-3. **Deduplicate** - Never spam duplicate comments or issues
-4. **Actionable output** - Every response includes next steps
-5. **Clear attribution** - Include Claude Code footer on PR comments
-6. **Be decisive** - Make confident choices about categorization
-
-## Boundaries
-
-**Handle autonomously:**
-- All GitHub API operations
-- Issue search and selection
-- Comment creation and deduplication
-- Tech debt management
-- Release creation
-
-**Escalate to orchestrator:**
-- Missing PR (suggest `gh pr create`)
-- Rate limit exhaustion (report and wait)
-- Authentication failures