claude-code-workflow 7.2.23 → 7.2.25

package/.codex/skills/team-perf-opt/roles/benchmarker/role.md

@@ -1,89 +1,89 @@
----
-role: benchmarker
-prefix: BENCH
-inner_loop: false
-message_types:
-  success: bench_complete
-  error: error
-  fix: fix_required
----
-
-# Performance Benchmarker
-
-Run benchmarks comparing before/after optimization metrics. Validate that improvements meet plan success criteria and detect any regressions.
-
-## Phase 2: Environment & Baseline Loading
-
-| Input | Source | Required |
-|-------|--------|----------|
-| Baseline metrics | <session>/artifacts/baseline-metrics.json (shared) | Yes |
-| Optimization plan / detail | Varies by mode (see below) | Yes |
-| .msg/meta.json | <session>/.msg/meta.json | Yes |
-
-1. Extract session path from task description
-2. **Detect branch/pipeline context** from task description:
-
-| Task Description Field | Value | Context |
-|----------------------|-------|---------|
-| `BranchId: B{NN}` | Present | Fan-out branch -- benchmark only this branch's metrics |
-| `PipelineId: {P}` | Present | Independent pipeline -- use pipeline-scoped baseline |
-| Neither present | - | Single mode -- full benchmark |
-
-3. **Load baseline metrics**:
-   - Single / Fan-out: Read `<session>/artifacts/baseline-metrics.json` (shared baseline)
-   - Independent: Read `<session>/artifacts/pipelines/{P}/baseline-metrics.json`
-
-4. **Load optimization context**:
-   - Single: Read `<session>/artifacts/optimization-plan.md`
-   - Fan-out branch: Read `<session>/artifacts/branches/B{NN}/optimization-detail.md`
-   - Independent: Read `<session>/artifacts/pipelines/{P}/optimization-plan.md`
-
-5. Load .msg/meta.json for project type and optimization scope
-6. Detect available benchmark tools from project:
-
-| Signal | Benchmark Tool | Method |
-|--------|---------------|--------|
-| package.json + vitest/jest | Test runner benchmarks | Run existing perf tests |
-| package.json + webpack/vite | Bundle analysis | Compare build output sizes |
-| Cargo.toml + criterion | Rust benchmarks | cargo bench |
-| go.mod | Go benchmarks | go test -bench |
-| Makefile with bench target | Custom benchmarks | make bench |
-| No tooling detected | Manual measurement | Timed execution via Bash |
-
-7. Get changed files scope from shared-memory (optimizer namespace, scoped by branch/pipeline)
-
-## Phase 3: Benchmark Execution
-
-Run benchmarks matching detected project type:
-
-**Frontend benchmarks**: Compare bundle size, render performance, dependency weight changes.
-
-**Backend benchmarks**: Measure endpoint response times, memory usage under load, database query improvements.
-
-**CLI / Library benchmarks**: Execution time, memory peak, throughput under sustained load.
-
-**All project types**:
-- Run existing test suite to verify no regressions
-- Collect post-optimization metrics matching baseline format
-- Calculate improvement percentages per metric
-
-**Branch-scoped benchmarking** (fan-out mode):
-- Only benchmark metrics relevant to this branch's optimization
-- Still check for regressions across all metrics
-
-## Phase 4: Result Analysis
-
-Compare against baseline and plan criteria:
-
-| Metric | Threshold | Verdict |
-|--------|-----------|---------|
-| Target improvement vs baseline | Meets plan success criteria | PASS |
-| No regression in unrelated metrics | < 5% degradation allowed | PASS |
-| All plan success criteria met | Every criterion satisfied | PASS |
-| Improvement below target | > 50% of target achieved | WARN |
-| Regression detected | Any unrelated metric degrades > 5% | FAIL -> fix_required |
-| Plan criteria not met | Any criterion not satisfied | FAIL -> fix_required |
-
-1. Write benchmark results to output path (scoped by branch/pipeline/single)
-2. Update `<session>/.msg/meta.json` under scoped namespace
-3. If verdict is FAIL, include detailed feedback in message for FIX task creation
+---
+role: benchmarker
+prefix: BENCH
+inner_loop: false
+message_types:
+  success: bench_complete
+  error: error
+  fix: fix_required
+---
+
+# Performance Benchmarker
+
+Run benchmarks comparing before/after optimization metrics. Validate that improvements meet plan success criteria and detect any regressions.
+
+## Phase 2: Environment & Baseline Loading
+
+| Input | Source | Required |
+|-------|--------|----------|
+| Baseline metrics | <session>/artifacts/baseline-metrics.json (shared) | Yes |
+| Optimization plan / detail | Varies by mode (see below) | Yes |
+| .msg/meta.json | <session>/.msg/meta.json | Yes |
+
+1. Extract session path from task description
+2. **Detect branch/pipeline context** from task description:
+
+| Task Description Field | Value | Context |
+|----------------------|-------|---------|
+| `BranchId: B{NN}` | Present | Fan-out branch -- benchmark only this branch's metrics |
+| `PipelineId: {P}` | Present | Independent pipeline -- use pipeline-scoped baseline |
+| Neither present | - | Single mode -- full benchmark |
+
+3. **Load baseline metrics**:
+   - Single / Fan-out: Read `<session>/artifacts/baseline-metrics.json` (shared baseline)
+   - Independent: Read `<session>/artifacts/pipelines/{P}/baseline-metrics.json`
+
+4. **Load optimization context**:
+   - Single: Read `<session>/artifacts/optimization-plan.md`
+   - Fan-out branch: Read `<session>/artifacts/branches/B{NN}/optimization-detail.md`
+   - Independent: Read `<session>/artifacts/pipelines/{P}/optimization-plan.md`
+
+5. Load .msg/meta.json for project type and optimization scope
+6. Detect available benchmark tools from project:
+
+| Signal | Benchmark Tool | Method |
+|--------|---------------|--------|
+| package.json + vitest/jest | Test runner benchmarks | Run existing perf tests |
+| package.json + webpack/vite | Bundle analysis | Compare build output sizes |
+| Cargo.toml + criterion | Rust benchmarks | cargo bench |
+| go.mod | Go benchmarks | go test -bench |
+| Makefile with bench target | Custom benchmarks | make bench |
+| No tooling detected | Manual measurement | Timed execution via Bash |
+
+7. Get changed files scope from shared-memory (optimizer namespace, scoped by branch/pipeline)
+
+## Phase 3: Benchmark Execution
+
+Run benchmarks matching detected project type:
+
+**Frontend benchmarks**: Compare bundle size, render performance, dependency weight changes.
+
+**Backend benchmarks**: Measure endpoint response times, memory usage under load, database query improvements.
+
+**CLI / Library benchmarks**: Execution time, memory peak, throughput under sustained load.
+
+**All project types**:
+- Run existing test suite to verify no regressions
+- Collect post-optimization metrics matching baseline format
+- Calculate improvement percentages per metric
+
+**Branch-scoped benchmarking** (fan-out mode):
+- Only benchmark metrics relevant to this branch's optimization
+- Still check for regressions across all metrics
+
+## Phase 4: Result Analysis
+
+Compare against baseline and plan criteria:
+
+| Metric | Threshold | Verdict |
+|--------|-----------|---------|
+| Target improvement vs baseline | Meets plan success criteria | PASS |
+| No regression in unrelated metrics | < 5% degradation allowed | PASS |
+| All plan success criteria met | Every criterion satisfied | PASS |
+| Improvement below target | > 50% of target achieved | WARN |
+| Regression detected | Any unrelated metric degrades > 5% | FAIL -> fix_required |
+| Plan criteria not met | Any criterion not satisfied | FAIL -> fix_required |
+
+1. Write benchmark results to output path (scoped by branch/pipeline/single)
+2. Update `<session>/.msg/meta.json` under scoped namespace
+3. If verdict is FAIL, include detailed feedback in message for FIX task creation

package/.codex/skills/team-perf-opt/roles/coordinator/commands/analyze.md

@@ -1,61 +1,61 @@
-# Analyze Task - Performance Optimization
-
-Parse optimization request -> detect parallel mode -> determine scope -> design pipeline structure.
-
-**CONSTRAINT**: Text-level analysis only. NO source code reading, NO codebase exploration.
-
-## Signal Detection
-
-### Parallel Mode Detection
-
-| Flag | Value | Pipeline Shape |
-|------|-------|----------------|
-| `--parallel-mode=single` | explicit | Single linear pipeline |
-| `--parallel-mode=fan-out` | explicit | Shared profile+strategy, N parallel IMPL branches |
-| `--parallel-mode=independent` | explicit | M fully independent pipelines |
-| `--parallel-mode=auto` or absent | default | Auto-detect from bottleneck count at CP-2.5 |
-| `auto` with count <= 2 | auto-resolved | single mode |
-| `auto` with count >= 3 | auto-resolved | fan-out mode |
-
-### Scope Detection
-
-| Signal | Target |
-|--------|--------|
-| Specific file/module mentioned | Scoped optimization |
-| "slow", "performance", generic | Full application profiling |
-| Specific metric mentioned (FCP, memory, startup) | Targeted metric optimization |
-| Multiple quoted targets (independent mode) | Per-target scoped optimization |
-
-### Optimization Keywords
-
-| Keywords | Capability |
-|----------|------------|
-| profile, bottleneck, slow, benchmark | profiler |
-| optimize, improve, reduce, speed | optimizer |
-| strategy, plan, prioritize | strategist |
-| verify, test, validate | benchmarker |
-| review, audit, quality | reviewer |
-
-## Output
-
-Coordinator state from this command (used by dispatch.md):
-
-```json
-{
-  "parallel_mode": "<auto|single|fan-out|independent>",
-  "max_branches": 5,
-  "optimization_targets": ["<target1>", "<target2>"],
-  "independent_targets": [],
-  "scope": "<specific|full-app|targeted>",
-  "target_metrics": ["<metric1>", "<metric2>"]
-}
-```
-
-## Pipeline Structure by Mode
-
-| Mode | Stages |
-|------|--------|
-| single | PROFILE-001 -> STRATEGY-001 -> IMPL-001 -> BENCH-001 + REVIEW-001 |
-| fan-out | PROFILE-001 -> STRATEGY-001 -> [IMPL-B01..N in parallel] -> BENCH+REVIEW per branch |
-| independent | N complete pipelines (PROFILE+STRATEGY+IMPL+BENCH+REVIEW) in parallel |
-| auto | Decided at CP-2.5 after STRATEGY-001 completes based on bottleneck count |
+# Analyze Task - Performance Optimization
+
+Parse optimization request -> detect parallel mode -> determine scope -> design pipeline structure.
+
+**CONSTRAINT**: Text-level analysis only. NO source code reading, NO codebase exploration.
+
+## Signal Detection
+
+### Parallel Mode Detection
+
+| Flag | Value | Pipeline Shape |
+|------|-------|----------------|
+| `--parallel-mode=single` | explicit | Single linear pipeline |
+| `--parallel-mode=fan-out` | explicit | Shared profile+strategy, N parallel IMPL branches |
+| `--parallel-mode=independent` | explicit | M fully independent pipelines |
+| `--parallel-mode=auto` or absent | default | Auto-detect from bottleneck count at CP-2.5 |
+| `auto` with count <= 2 | auto-resolved | single mode |
+| `auto` with count >= 3 | auto-resolved | fan-out mode |
+
+### Scope Detection
+
+| Signal | Target |
+|--------|--------|
+| Specific file/module mentioned | Scoped optimization |
+| "slow", "performance", generic | Full application profiling |
+| Specific metric mentioned (FCP, memory, startup) | Targeted metric optimization |
+| Multiple quoted targets (independent mode) | Per-target scoped optimization |
+
+### Optimization Keywords
+
+| Keywords | Capability |
+|----------|------------|
+| profile, bottleneck, slow, benchmark | profiler |
+| optimize, improve, reduce, speed | optimizer |
+| strategy, plan, prioritize | strategist |
+| verify, test, validate | benchmarker |
+| review, audit, quality | reviewer |
+
+## Output
+
+Coordinator state from this command (used by dispatch.md):
+
+```json
+{
+  "parallel_mode": "<auto|single|fan-out|independent>",
+  "max_branches": 5,
+  "optimization_targets": ["<target1>", "<target2>"],
+  "independent_targets": [],
+  "scope": "<specific|full-app|targeted>",
+  "target_metrics": ["<metric1>", "<metric2>"]
+}
+```
+
+## Pipeline Structure by Mode
+
+| Mode | Stages |
+|------|--------|
+| single | PROFILE-001 -> STRATEGY-001 -> IMPL-001 -> BENCH-001 + REVIEW-001 |
+| fan-out | PROFILE-001 -> STRATEGY-001 -> [IMPL-B01..N in parallel] -> BENCH+REVIEW per branch |
+| independent | N complete pipelines (PROFILE+STRATEGY+IMPL+BENCH+REVIEW) in parallel |
+| auto | Decided at CP-2.5 after STRATEGY-001 completes based on bottleneck count |

package/.codex/skills/team-perf-opt/roles/coordinator/commands/monitor.md

@@ -65,6 +65,7 @@ Find and spawn the next ready tasks.
 ```
 spawn_agent({
   agent_type: "team_worker",
+  task_name: taskId,  // e.g., "IMPL-001" — enables named targeting
   items: [{
     description: "Spawn <role> worker for <task-id>",
     team_name: "perf-opt",
@@ -93,7 +94,22 @@ Execute built-in Phase 1 -> role-spec Phase 2-4 -> built-in Phase 5.`
 | Fan-out (IMPL-B{NN} done) | BENCH-B{NN} + REVIEW-B{NN} ready | Spawn both for that branch in parallel |
 | Independent | Any unblocked task | Spawn all ready tasks across all pipelines in parallel |
 
-4. STOP after spawning -- use `wait_agent({ ids: [<spawned-agent-ids>] })` to wait for next callback
+4. STOP after spawning -- use `wait_agent({ targets: [<spawned-task-names>], timeout_ms: 900000 })` to wait for next callback. If `result.timed_out`, mark tasks as `timed_out` and close agents. Use `close_agent({ target: taskId })` with task_name for cleanup.
+
+**Cross-Agent Supplementary Context** (v4):
+
+When spawning workers in a later pipeline phase, send upstream results as supplementary context to already-running workers:
+
+```
+// Example: Send profiling results to running optimizers
+send_message({
+  target: "<running-agent-task-name>",
+  items: [{ type: "text", text: `## Supplementary Context\n${upstreamFindings}` }]
+})
+// Note: send_message queues info without interrupting the agent's current work
+```
+
+Use `send_message` (not `assign_task`) for supplementary info that enriches but doesn't redirect the agent's current task.
 
 ### Review-Fix Cycle (CP-3)
 
@@ -242,6 +258,16 @@ Output status -- do NOT advance pipeline.
 
 ### handleResume
 
+**Agent Health Check** (v4):
+```
+// Verify actual running agents match session state
+const runningAgents = list_agents({})
+// For each active_agent in tasks.json:
+//   - If agent NOT in runningAgents -> agent crashed
+//   - Reset that task to pending, remove from active_agents
+// This prevents stale agent references from blocking the pipeline
+```
+
 Resume pipeline after user pause or interruption.
 
 1. Audit tasks.json for inconsistencies:
@@ -262,6 +288,14 @@ Handle consensus_blocked signals from discuss rounds.
 
 ### handleComplete
 
+**Cleanup Verification** (v4):
+```
+// Verify all agents are properly closed
+const remaining = list_agents({})
+// If any team agents still running -> close_agent each
+// Ensures clean session shutdown
+```
+
 Triggered when all pipeline tasks are completed and no fix cycles remain.
 
 **Completion check varies by mode**: