chrome-devtools-frontend 1.0.957495 → 1.0.959543

package/scripts/build/generate_css_js_files.js

@@ -4,6 +4,7 @@
 const fs = require('fs');
 const path = require('path');
 const CleanCSS = require('clean-css');
+const {writeIfChanged} = require('./ninja/write-if-changed.js');
 const [, , buildTimestamp, isDebugString, legacyString, targetName, srcDir, targetGenDir, files] = process.argv;
 
 const filenames = files.split(',');
@@ -34,21 +35,22 @@ export default styles;`;
   }
 
   const generatedFileName = `${fileName}${isLegacy ? '.legacy' : ''}.js`;
-
-  fs.writeFileSync(
-      path.join(targetGenDir, generatedFileName),
-      `// Copyright ${new Date(Number(buildTimestamp) * 1000).getFullYear()} The Chromium Authors. All rights reserved.
+  const generatedFileLocation = path.join(targetGenDir, generatedFileName);
+  const newContents = `// Copyright ${
+      new Date(Number(buildTimestamp) * 1000).getUTCFullYear()} The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 // IMPORTANT: this file is auto generated. Please do not edit this file.
 /* istanbul ignore file */
 ${exportStatement}
-`);
+`;
+
+  writeIfChanged(generatedFileLocation, newContents);
 
   configFiles.push(`\"${generatedFileName}\"`);
 }
 
-fs.writeFileSync(path.join(targetGenDir, `${targetName}-tsconfig.json`), `{
+writeIfChanged(path.join(targetGenDir, `${targetName}-tsconfig.json`), `{
     "compilerOptions": {
         "composite": true,
         "outDir": "."

package/scripts/build/generate_html_entrypoint.js

@@ -5,6 +5,7 @@
 const fs = require('fs');
 const path = require('path');
 const {argv} = require('yargs');
+const {writeIfChanged} = require('./ninja/write-if-changed.js');
 
 const {template} = argv;
 
@@ -32,5 +33,5 @@ const templateContent = fs.readFileSync(template, 'utf-8');
 
 for (const entrypoint of entrypoints) {
   const rewrittenTemplateContent = templateContent.replace(new RegExp('%ENTRYPOINT_NAME%', 'g'), entrypoint);
-  fs.writeFileSync(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
+  writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
 }

package/scripts/build/ninja/copy-file.js

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 const fs = require('fs');
 const path = require('path');
+const {writeIfChanged} = require('./write-if-changed.js');
 const [, , src, dest] = process.argv;
 
 const srcPath = path.join(process.cwd(), src);
@@ -23,7 +24,7 @@ if (fileExists(destPath)) {
 // Force a write to the target filesystem, since by default the ninja
 // toolchain will create a hardlink, which in turn reflects changes in
 // gen and resources/inspector back to //front_end.
-fs.writeFileSync(destPath, srcContents);
+writeIfChanged(destPath, srcContents);
 
 /**
  * Case sensitive implementation of a file look up.

package/scripts/build/ninja/copy-files.js

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 const fs = require('fs');
 const path = require('path');
+const {writeIfChanged} = require('./write-if-changed.js');
 const [, , src, dest, files] = process.argv;
 
 for (const file of files.split(',')) {
@@ -24,7 +25,7 @@ for (const file of files.split(',')) {
   // Force a write to the target filesystem, since by default the ninja
   // toolchain will create a hardlink, which in turn reflects changes in
   // gen and resources/inspector back to //front_end.
-  fs.writeFileSync(destPath, srcContents);
+  writeIfChanged(destPath, srcContents);
 }
 
 /**

package/scripts/build/ninja/generate-declaration.js

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 const fs = require('fs');
 const path = require('path');
+const {writeIfChanged} = require('./write-if-changed.js');
 
 const [, , outputDirectory, entrypointName] = process.argv;
 
@@ -13,4 +14,4 @@ const outputLocation = path.join(outputDirectory, `${rawFileName}.d.ts`);
 // We can't use copy here, as that would maintain the original file timestamps.
 // This can throw off Ninja, which verifies that timestamps of generated files
 // are the same as the timestamp it ran the action on.
-fs.writeFileSync(outputLocation, fs.readFileSync(inputLocation));
+writeIfChanged(outputLocation, fs.readFileSync(inputLocation));

package/scripts/build/ninja/node.gni

@@ -20,7 +20,10 @@ template("node_action") {
 
     _full_script_location = devtools_location_prepend + invoker.script
 
-    inputs += [ _full_script_location ]
+    inputs += [
+      _full_script_location,
+      devtools_location_prepend + "scripts/build/ninja/write-if-changed.js",
+    ]
 
     args = [ rebase_path(_full_script_location, root_build_dir) ] + invoker.args
   }

package/scripts/build/ninja/write-if-changed.js

@@ -0,0 +1,27 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const fs = require('fs');
+
+/**
+ * Only write content to a file if the content is different that what it previously contained.
+ * The reason for only writing when necessary is that GN uses file timestamps to determine freshness.
+ * Therefore, if the file contents hasn't changed, but the timestamp has, GN thinks the file is new.
+ *
+ * Instead, we can only write when the content is changed, meaning we don't touch a file when it is
+ * unchanged. This would preserve the original file timestamps and hence GN can correctly conclude
+ * the file output hasn't changed.
+ *
+ * @param {string} generatedFileLocation Location to write to
+ * @param {string} newContents The contents to write (or noop if unchanged with previous content)
+ */
+module.exports.writeIfChanged = (generatedFileLocation, newContents) => {
+  if (fs.existsSync(generatedFileLocation)) {
+    if (fs.readFileSync(generatedFileLocation, {encoding: 'utf8', flag: 'r'}) === newContents) {
+      return;
+    }
+  }
+
+  fs.writeFileSync(generatedFileLocation, newContents, {encoding: 'utf-8'});
+};