chrome-devtools-frontend 1.0.957495 → 1.0.959543

package/.eslintignore

@@ -5,7 +5,6 @@
 // clang-format check also ignores that file
 front_end/.eslintrc.js
 front_end/diff/diff_match_patch.js
-front_end/protocol_externs.js
 front_end/javascript_metadata/NativeFunctions.js
 front_end/third_party/
 test/e2e/**/*.js

package/AUTHORS

@@ -25,6 +25,7 @@ Derek Li <the.derekli@gmail.com>
 Edward Trist <edwardtrist@gmail.com>
 Ergün Erdoğmuş <erdogmusergun@gmail.com>
 Eric Rannaud <eric.rannaud@gmail.com>
+Feng Lu <lufengd3@gmail.com>
 Gabriel Luong <gabriel.luong@gmail.com>
 Gautham Banasandra <gautham.bangalore@gmail.com>
 Jake Mulhern <mulherje@gmail.com>

package/config/owner/COMMON_OWNERS

@@ -1,6 +1,5 @@
 file://config/owner/ENG_REVIEW_OWNERS
 
-aerotwist@chromium.org
 alexrudenko@chromium.org
 andoli@chromium.org
 bmeurer@chromium.org

package/config/owner/INFRA_OWNERS

@@ -1,4 +1,3 @@
-aerotwist@chromium.org
 jacktfranklin@chromium.org
 liviurau@chromium.org
 machenbach@chromium.org

package/extension-api/ExtensionAPI.d.ts

@@ -69,6 +69,13 @@ export namespace Chrome {
 
       create(title: string, iconPath: string, pagePath: string, callback?: (panel: ExtensionPanel) => unknown): void;
       openResource(url: string, lineNumber: number, columnNumber?: number, callback?: () => unknown): void;
+
+      /**
+       * Fired when the theme changes in DevTools.
+       *
+       * @param callback The handler callback to register and be invoked on theme changes.
+       */
+      setThemeChangeHandler(callback?: (themeName: string) => unknown): void;
     }
 
     export interface Request {

package/front_end/Images/generate-css-vars.js

@@ -1,8 +1,8 @@
 // Copyright 2020 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-const fs = require('fs');
 const path = require('path');
+const {writeIfChanged} = require('../../scripts/build/ninja/write-if-changed.js');
 const [, , buildTimestamp, targetGenDir, targetName, ...imageSources] = process.argv;
 
 /**
@@ -18,8 +18,8 @@ function generateCSSVariableDefinition(fileName) {
       fileName}', import.meta.url).toString() + '\\")');`;
 }
 
-const CURRENT_YEAR = new Date(Number(buildTimestamp) * 1000).getFullYear();
-const fileContent = `
+const CURRENT_YEAR = new Date(Number(buildTimestamp) * 1000).getUTCFullYear();
+const newContents = `
 // Copyright ${CURRENT_YEAR} The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
@@ -32,17 +32,16 @@ ${imageSources.map(generateCSSVariableDefinition).join('\n')}
 document.adoptedStyleSheets = [...document.adoptedStyleSheets, sheet];
 `;
 
-fs.writeFileSync(path.join(targetGenDir, 'Images.prebundle.js'), fileContent, {encoding: 'utf-8'});
+writeIfChanged(path.join(targetGenDir, 'Images.prebundle.js'), newContents);
 
-const tsconfigContent = `
-{
-    "compilerOptions": {
-        "composite": true
-    },
-    "files": [
-        "Images.js"
-    ]
+const tsconfigContent = `{
+  "compilerOptions": {
+      "composite": true
+  },
+  "files": [
+      "Images.js"
+  ]
 }
 `;
 
-fs.writeFileSync(path.join(targetGenDir, `${targetName}-tsconfig.json`), tsconfigContent, {encoding: 'utf-8'});
+writeIfChanged(path.join(targetGenDir, `${targetName}-tsconfig.json`), tsconfigContent);

package/front_end/Tests.js

@@ -1572,6 +1572,20 @@
         `console.log(1) //# sourceMappingURL=chrome-extension://${extensionId}/source.map`, () => {});
   };
 
+  TestSuite.prototype.testSourceMapsFromDevtools = function() {
+    this.takeControl();
+    const debuggerModel = self.SDK.targetManager.mainTarget().model(SDK.DebuggerModel);
+    debuggerModel.sourceMapManager().addEventListener(
+        SDK.SourceMapManager.Events.SourceMapWillAttach, this.releaseControl.bind(this));
+
+    this.evaluateInConsole_(
+        'console.log(1) //# sourceMappingURL=devtools://devtools/bundled/devtools_compatibility.js', () => {});
+  };
+
+  TestSuite.prototype.testDoesNotCrashOnSourceMapsFromUnknownScheme = function() {
+    this.evaluateInConsole_('console.log(1) //# sourceMappingURL=invalid-scheme://source.map', () => {});
+  };
+
   /**
    * Returns all loaded non anonymous uiSourceCodes.
    * @return {!Array.<!Workspace.UISourceCode>}

package/front_end/core/common/Debouncer.ts

@@ -9,7 +9,7 @@ export const debounce = function(func: Function, delay: number): Function {
   let timer = 0;
   const debounced = (): void => {
     clearTimeout(timer);
-    timer = setTimeout(() => func(), delay);
+    timer = window.setTimeout(() => func(), delay);
   };
   return debounced;
 };

package/front_end/core/common/Settings.ts

@@ -197,6 +197,7 @@ export class Settings {
 
 export interface SettingsBackingStore {
   register(setting: string): void;
+  get(setting: string): Promise<string>;
   set(setting: string, value: string): void;
   remove(setting: string): void;
   clear(): void;
@@ -205,6 +206,7 @@ export interface SettingsBackingStore {
 export const NOOP_STORAGE: SettingsBackingStore = {
   register: () => {},
   set: () => {},
+  get: () => Promise.resolve(''),
   remove: () => {},
   clear: () => {},
 };
@@ -236,6 +238,17 @@ export class SettingsStorage {
     return this.object[name];
   }
 
+  async forceGet(originalName: string): Promise<string> {
+    const name = this.storagePrefix + originalName;
+    const value = await this.backingStore.get(name);
+    if (value && value !== this.object[name]) {
+      this.set(originalName, value);
+    } else if (!value) {
+      this.remove(originalName);
+    }
+    return value;
+  }
+
   remove(name: string): void {
     name = this.storagePrefix + name;
     delete this.object[name];
@@ -363,6 +376,26 @@ export class Setting<V> {
     return this.#value;
   }
 
+  async forceGet(): Promise<V> {
+    const name = this.name;
+    const oldValue = this.storage.get(name);
+    const value = await this.storage.forceGet(name);
+    this.#value = this.defaultValue;
+    if (value) {
+      try {
+        this.#value = this.#serializer.parse(value);
+      } catch (e) {
+        this.storage.remove(this.name);
+      }
+    }
+
+    if (oldValue !== value) {
+      this.eventSupport.dispatchEventToListeners(this.name, this.#value);
+    }
+
+    return this.#value;
+  }
+
   set(value: V): void {
     this.#hadUserAction = true;
     this.#value = value;

package/front_end/core/host/InspectorFrontendHost.ts

@@ -94,15 +94,15 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   }
 
   setIsDocked(isDocked: boolean, callback: () => void): void {
-    setTimeout(callback, 0);
+    window.setTimeout(callback, 0);
   }
 
   showSurvey(trigger: string, callback: (arg0: ShowSurveyResult) => void): void {
-    setTimeout(() => callback({surveyShown: false}), 0);
+    window.setTimeout(() => callback({surveyShown: false}), 0);
   }
 
   canShowSurvey(trigger: string, callback: (arg0: CanShowSurveyResult) => void): void {
-    setTimeout(() => callback({canShowSurvey: false}), 0);
+    window.setTimeout(() => callback({canShowSurvey: false}), 0);
   }
 
   /**
@@ -260,6 +260,10 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     callback(prefs);
   }
 
+  getPreference(name: string, callback: (arg0: string) => void): void {
+    callback(window.localStorage[name]);
+  }
+
   setPreference(name: string, value: string): void {
     window.localStorage[name] = value;
   }

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -234,6 +234,8 @@ export interface InspectorFrontendHostAPI {
                    [x: string]: string,
                  }) => void): void;
 
+  getPreference(name: string, callback: (arg0: string) => void): void;
+
   setPreference(name: string, value: string): void;
 
   removePreference(name: string): void;

package/front_end/core/host/UserMetrics.ts

@@ -78,10 +78,10 @@ export class UserMetrics {
     }
 
     this.#firedLaunchHistogram = true;
-    // Use rAF and setTimeout to ensure the marker is fired after layout and rendering.
+    // Use rAF and window.setTimeout to ensure the marker is fired after layout and rendering.
     // This will give the most accurate representation of the tool being ready for a user.
     requestAnimationFrame(() => {
-      setTimeout(() => {
+      window.setTimeout(() => {
         // Mark the load time so that we can pinpoint it more easily in a trace.
         performance.mark(histogramName);
         // If the user has switched panel before we finished loading, ignore the histogram,

package/front_end/core/i18n/i18nImpl.ts

@@ -58,7 +58,7 @@ function getLocaleFetchUrl(locale: Intl.UnicodeBCP47LocaleIdentifier): string {
 export async function fetchAndRegisterLocaleData(locale: Intl.UnicodeBCP47LocaleIdentifier): Promise<void> {
   const localeDataTextPromise = fetch(getLocaleFetchUrl(locale)).then(result => result.json());
   const timeoutPromise =
-      new Promise((resolve, reject) => setTimeout(() => reject(new Error('timed out fetching locale')), 5000));
+      new Promise((resolve, reject) => window.setTimeout(() => reject(new Error('timed out fetching locale')), 5000));
   const localeData = await Promise.race([timeoutPromise, localeDataTextPromise]);
   i18nInstance.registerLocaleData(locale, localeData);
 }