chrome-devtools-frontend 1.0.1587905 → 1.0.1589336

package/front_end/panels/sources/AiCodeCompletionPlugin.ts

@@ -5,6 +5,7 @@
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as AiCodeCompletion from '../../models/ai_code_completion/ai_code_completion.js';
+import * as AiCodeGeneration from '../../models/ai_code_generation/ai_code_generation.js';
 import type * as Workspace from '../../models/workspace/workspace.js';
 import type * as CodeMirror from '../../third_party/codemirror.next/codemirror.next.js';
 import * as TextEditor from '../../ui/components/text_editor/text_editor.js';
@@ -46,6 +47,11 @@ export class AiCodeCompletionPlugin extends Plugin {
                                                                             undefined,
         inferenceLanguage: this.#getInferenceLanguage()
       },
+      generationContext: {
+        additionalPreambleContext: this.uiSourceCode.url().startsWith('snippet://') ?
+            AiCodeGeneration.AiCodeGeneration.additionalContextForConsole :
+            undefined,
+      },
       onFeatureEnabled: () => {
         this.#setupAiCodeCompletion();
       },

package/front_end/panels/sources/CSSPlugin.ts

@@ -163,7 +163,7 @@ class ColorSwatchWidget extends CodeMirror.WidgetType {
 
   toDOM(view: CodeMirror.EditorView): HTMLElement {
     const swatch = new InlineEditor.ColorSwatch.ColorSwatch(i18nString(UIStrings.openColorPicker));
-    swatch.color = this.#color;
+    swatch.renderColor(this.#color);
     const value = swatch.createChild('span');
     value.textContent = this.#text;
     value.setAttribute('hidden', 'true');

package/front_end/panels/sources/DebuggerPlugin.ts

@@ -212,7 +212,7 @@ export class DebuggerPlugin extends Plugin {
   // locations, so breakpoint manipulation is permanently disabled.
   private initializedMuted: boolean;
   private ignoreListInfobar: UI.Infobar.Infobar|null;
-  private refreshBreakpointsTimeout: undefined|number = undefined;
+  private refreshBreakpointsTimeout?: number;
   private activeBreakpointDialog: BreakpointEditDialog|null = null;
   #activeBreakpointEditRequest?: BreakpointEditRequest = undefined;
   #scheduledFinishingActiveDialog = false;
@@ -719,10 +719,6 @@ export class DebuggerPlugin extends Plugin {
           returnByValue: false,
           generatePreview: false,
           throwOnSideEffect,
-          timeout: undefined,
-          disableBreaks: undefined,
-          replMode: undefined,
-          allowUnsafeEvalBlockedByCSP: undefined,
         });
         if (!result || 'error' in result || !result.object ||
             (result.object.type === 'object' && result.object.subtype === 'error')) {

package/front_end/panels/sources/sources-meta.ts

@@ -1848,7 +1848,6 @@ UI.ContextMenu.registerProvider({
     const Sources = await loadSourcesModule();
     return Sources.SourcesPanel.SourcesPanel.instance();
   },
-  experiment: undefined,
 });
 
 UI.ContextMenu.registerProvider({
@@ -1862,7 +1861,6 @@ UI.ContextMenu.registerProvider({
       ...maybeRetrieveContextTypes(Sources => [Sources.UISourceCodeFrame.UISourceCodeFrame]),
     ];
   },
-  experiment: undefined,
 });
 
 Common.Revealer.registerRevealer({
@@ -1947,7 +1945,6 @@ Common.Revealer.registerRevealer({
   contextTypes() {
     return maybeRetrieveContextTypes(Sources => [Sources.SearchSourcesView.SearchSources]);
   },
-  destination: undefined,
   async loadRevealer() {
     const Sources = await loadSourcesModule();
     return new Sources.SearchSourcesView.Revealer();
@@ -1958,9 +1955,6 @@ UI.Toolbar.registerToolbarItem({
   actionId: 'sources.add-folder-to-workspace',
   location: UI.Toolbar.ToolbarItemLocation.FILES_NAVIGATION_TOOLBAR,
   label: i18nLazyString(UIStrings.addFolderManually),
-  loadItem: undefined,
-  order: undefined,
-  separator: undefined,
 });
 
 UI.Context.registerListener({
@@ -1996,13 +1990,11 @@ UI.Context.registerListener({
 UI.ContextMenu.registerItem({
   location: UI.ContextMenu.ItemLocation.NAVIGATOR_MENU_DEFAULT,
   actionId: 'quick-open.show',
-  order: undefined,
 });
 
 UI.ContextMenu.registerItem({
   location: UI.ContextMenu.ItemLocation.MAIN_MENU_DEFAULT,
   actionId: 'sources.search',
-  order: undefined,
 });
 
 QuickOpen.FilteredListWidget.registerProvider({
@@ -2056,5 +2048,4 @@ UI.ContextMenu.registerProvider({
     const Sources = await loadSourcesModule();
     return new Sources.PersistenceActions.ContextMenuProvider();
   },
-  experiment: undefined,
 });

package/front_end/panels/timeline/CompatibilityTracksAppender.ts

@@ -234,7 +234,7 @@ export class CompatibilityTracksAppender {
     this.#entityMapper = entityMapper;
     this.#entryData = entryData;
     this.#colorGenerator = new Common.Color.Generator(
-        /* hueSpace= */ {min: 30, max: 55, count: undefined},
+        /* hueSpace= */ {min: 30, max: 55},
         /* satSpace= */ {min: 70, max: 100, count: 6},
         /* lightnessSpace= */ 50,
         /* alphaSpace= */ 0.7);

package/front_end/panels/timeline/ThirdPartyTreeView.ts

@@ -217,7 +217,7 @@ export class ThirdPartyTreeViewWidget extends TimelineTreeView.TimelineTreeView
   displayInfoForGroupNode(node: Trace.Extras.TraceTree.Node): {
     name: string,
     color: string,
-    icon: (Element|undefined),
+    icon?: Element,
   } {
     const color = 'gray';
     const unattributed = i18nString(UIStrings.unattributed);
@@ -225,7 +225,10 @@ export class ThirdPartyTreeViewWidget extends TimelineTreeView.TimelineTreeView
     // This `undefined` is [unattributed]
     // TODO(paulirish): Improve attribution to reduce amount of items in [unattributed].
     const domainName = id ? this.entityMapper()?.entityForEvent(node.event)?.name || id : undefined;
-    return {name: domainName || unattributed, color, icon: undefined};
+    return {
+      name: domainName || unattributed,
+      color,
+    };
   }
 
   nodeIsFirstParty(node: Trace.Extras.TraceTree.Node): boolean {

package/front_end/panels/timeline/TimelinePanel.ts

@@ -1995,8 +1995,6 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
           description: error,
           buttonText: i18nString(UIStrings.close),
           hideStopButton: false,
-          showProgress: undefined,
-          showTimer: undefined,
         },
         // When recording failed, we should load null to go back to the landing page.
         async () => {
@@ -2475,10 +2473,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
     this.statusDialog = new StatusDialog(
         {
           showProgress: true,
-          showTimer: undefined,
           hideStopButton: true,
-          buttonText: undefined,
-          description: undefined,
         },
         () => this.cancelLoading());
     this.statusDialog.showPane(this.statusPaneContainer);
@@ -2864,8 +2859,6 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
           showTimer: true,
           showProgress: true,
           hideStopButton: false,
-          description: undefined,
-          buttonText: undefined,
         },
         () => this.stopRecording());
     this.statusDialog.showPane(this.statusPaneContainer);

package/front_end/panels/timeline/TimelineTreeView.ts

@@ -268,8 +268,6 @@ export class TimelineTreeView extends
     this.dataGrid = new DataGrid.SortableDataGrid.SortableDataGrid({
       displayName: i18nString(UIStrings.performance),
       columns,
-      refreshCallback: undefined,
-      deleteCallback: undefined,
     });
     this.dataGrid.addEventListener(DataGrid.DataGrid.Events.SORTING_CHANGED, this.sortingChanged, this);
     this.dataGrid.element.addEventListener('mousemove', this.onMouseMove.bind(this), true);
@@ -984,7 +982,7 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
   displayInfoForGroupNode(node: Trace.Extras.TraceTree.Node): {
     name: string,
     color: string,
-    icon: (Element|undefined),
+    icon?: Element,
   } {
     const categories = Trace.Styles.getCategoryStyles();
     const color = TimelineUIUtils.eventColor(node.event);
@@ -1000,7 +998,7 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
         const color = category instanceof Trace.Styles.TimelineCategory ?
             ThemeSupport.ThemeSupport.instance().getComputedValue(category.cssVariable) :
             category.color;
-        return {name: category.title, color, icon: undefined};
+        return {name: category.title, color};
       }
 
       case AggregatedTimelineTreeView.GroupBy.Domain:
@@ -1009,7 +1007,7 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
         // This `undefined` is [unattributed]
         // TODO(paulirish): Improve attribution to reduce amount of items in [unattributed].
         const domainName = id ? this.beautifyDomainName(id, node) : undefined;
-        return {name: domainName || unattributed, color, icon: undefined};
+        return {name: domainName || unattributed, color};
       }
 
       case AggregatedTimelineTreeView.GroupBy.EventName: {
@@ -1020,7 +1018,6 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
         return {
           name,
           color,
-          icon: undefined,
         };
       }
 
@@ -1030,13 +1027,16 @@ export class AggregatedTimelineTreeView extends TimelineTreeView {
       case AggregatedTimelineTreeView.GroupBy.Frame: {
         const frame = id ? this.parsedTrace()?.data.PageFrames.frames.get(id) : undefined;
         const frameName = frame ? TimelineUIUtils.displayNameForFrame(frame) : i18nString(UIStrings.page);
-        return {name: frameName, color, icon: undefined};
+        return {name: frameName, color};
       }
 
       default:
         console.assert(false, 'Unexpected grouping type');
     }
-    return {name: id || unattributed, color, icon: undefined};
+    return {
+      name: id || unattributed,
+      color,
+    };
   }
 
   override populateToolbar(toolbar: UI.Toolbar.Toolbar): void {
@@ -1293,8 +1293,6 @@ export class TimelineStackView extends
     this.dataGrid = new DataGrid.ViewportDataGrid.ViewportDataGrid({
       displayName: i18nString(UIStrings.timelineStack),
       columns,
-      deleteCallback: undefined,
-      refreshCallback: undefined,
     });
 
     this.dataGrid.setResizeMethod(DataGrid.DataGrid.ResizeMethod.LAST);

package/front_end/panels/timeline/TimelineUIUtils.ts

@@ -930,7 +930,6 @@ export class TimelineUIUtils {
         if (url) {
           previewElement = await LegacyComponents.ImagePreview.ImagePreview.build(url, false, {
             imageAltText: LegacyComponents.ImagePreview.ImagePreview.defaultAltTextForImageURL(url),
-            precomputedFeatures: undefined,
             align: LegacyComponents.ImagePreview.Align.START,
           });
         } else if (Trace.Types.Events.isPaint(event)) {
@@ -2293,8 +2292,17 @@ export class TimelineUIUtils {
 
   static colorForId(id: string): string {
     if (!colorGenerator) {
-      colorGenerator =
-          new Common.Color.Generator({min: 30, max: 330, count: undefined}, {min: 50, max: 80, count: 3}, 85);
+      colorGenerator = new Common.Color.Generator(
+          {
+            min: 30,
+            max: 330,
+          },
+          {
+            min: 50,
+            max: 80,
+            count: 3,
+          },
+          85);
       colorGenerator.setColorForID('', '#f2ecdc');
     }
     return colorGenerator.colorForID(id);

package/front_end/panels/timeline/components/IgnoreListSetting.ts

@@ -202,7 +202,7 @@ export class IgnoreListSetting extends UI.Widget.Widget {
 
   #onNewRegexInputFocus(value: string): void {
     // Do not need to trim here because this is a temporary one, we will trim the input when finish editing,
-    this.#editingRegexSetting = {pattern: value, disabled: false, disabledForUrl: undefined};
+    this.#editingRegexSetting = {pattern: value, disabled: false};
     // We need to push the temp regex here to update the flame chart.
     // We are using the "skip-stack-frames-pattern" setting to determine which is rendered on flame chart. And the push
     // here will update the setting's value.

package/front_end/panels/timeline/components/NetworkRequestDetails.ts

@@ -308,7 +308,6 @@ async function renderPreviewElement(
     const previewOpts = {
       imageAltText:
           LegacyComponents.ImagePreview.ImagePreview.defaultAltTextForImageURL(url as Platform.DevToolsPath.UrlString),
-      precomputedFeatures: undefined,
       align: LegacyComponents.ImagePreview.Align.START,
       hideFileData: true,
     };

package/front_end/panels/timeline/utils/Treemap.ts

@@ -77,7 +77,6 @@ export function makeScriptNode(src: string, sourceRoot: string, sourcesData: Rec
     return {
       name,
       resourceBytes: 0,
-      encodedBytes: undefined,
     };
   }
 
@@ -215,7 +214,6 @@ export function createTreemapData(
       for (const [source, resourceBytes] of Object.entries(sizes.files)) {
         const sourceData: SourceData = {
           resourceBytes,
-          encodedBytes: undefined,
         };
 
         const key = Trace.Extras.ScriptDuplication.normalizeSource(source);
@@ -239,7 +237,6 @@ export function createTreemapData(
       node = {
         name,
         resourceBytes: script.content?.length ?? 0,
-        encodedBytes: undefined,
       };
     }
 
@@ -252,7 +249,6 @@ export function createTreemapData(
         htmlNode = {
           name,
           resourceBytes: 0,
-          encodedBytes: undefined,
           children: [],
         };
         htmlNodesByFrameId.set(script.frame, htmlNode);

package/front_end/panels/whats_new/whats_new-meta.ts

@@ -58,12 +58,10 @@ Common.Settings.maybeRemoveSettingExtension('help.show-release-note');
 UI.ContextMenu.maybeRemoveItem({
   location: UI.ContextMenu.ItemLocation.MAIN_MENU_HELP_DEFAULT,
   actionId: 'help.release-notes',
-  order: undefined,
 });
 UI.ContextMenu.maybeRemoveItem({
   location: UI.ContextMenu.ItemLocation.MAIN_MENU_HELP_DEFAULT,
   actionId: 'help.report-issue',
-  order: undefined,
 });
 
 Common.Runnable.maybeRemoveLateInitializationRunnable('whats-new');

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: https://chromium.googlesource.com/chromium/src
 Version: N/A
-Revision: e991bb058bdc3021ea1576fee0a80a7ecd0ef566
+Revision: 38fcac45e10d0cf6f8cf7007d4891f7c2038fc22
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/ui/components/highlighting/HighlightManager.ts

@@ -85,7 +85,7 @@ export const CURRENT_HIGHLIGHT_REGISTRY = 'current-search-result';
 interface HighlightState {
   activeRanges: Range[];
   ranges: TextUtils.TextRange.SourceRange[];
-  currentRange: TextUtils.TextRange.SourceRange|undefined;
+  currentRange?: TextUtils.TextRange.SourceRange;
 }
 
 let highlightManagerInstance: HighlightManager;
@@ -153,7 +153,6 @@ export class HighlightManager {
       state = {
         activeRanges: [],
         ranges: [],
-        currentRange: undefined,
       };
       this.#stateByNode.set(node, state);
     }

package/front_end/ui/components/highlighting/MarkupHighlight.ts

@@ -71,8 +71,6 @@ export function highlightRangesWithStyleClass(
       type: 'changed',
       oldText: lastText,
       newText: lastTextNode.textContent,
-      nextSibling: undefined,
-      parent: undefined,
     });
 
     if (startIndex === endIndex && lastTextNode.parentElement) {
@@ -82,8 +80,6 @@ export function highlightRangesWithStyleClass(
         type: 'added',
         nextSibling: lastTextNode,
         parent: lastTextNode.parentElement,
-        oldText: undefined,
-        newText: undefined,
       });
       highlightNodes.push(highlightNode);
 
@@ -95,8 +91,6 @@ export function highlightRangesWithStyleClass(
         type: 'added',
         nextSibling: highlightNode,
         parent: lastTextNode.parentElement,
-        oldText: undefined,
-        newText: undefined,
       });
     } else {
       const firstTextNode = textNodes[startIndex];
@@ -110,8 +104,7 @@ export function highlightRangesWithStyleClass(
           type: 'added',
           nextSibling: anchorElement || undefined,
           parent: firstTextNode.parentElement,
-          oldText: undefined,
-          newText: undefined,
+
         });
         highlightNodes.push(highlightNode);
       }
@@ -122,8 +115,6 @@ export function highlightRangesWithStyleClass(
         type: 'changed',
         oldText: firstText,
         newText: firstTextNode.textContent,
-        nextSibling: undefined,
-        parent: undefined,
       });
 
       for (let j = startIndex + 1; j < endIndex; j++) {
@@ -135,8 +126,6 @@ export function highlightRangesWithStyleClass(
           type: 'changed',
           oldText: text || undefined,
           newText: textNode.textContent,
-          nextSibling: undefined,
-          parent: undefined,
         });
       }
     }

package/front_end/ui/components/icon_button/IconButton.ts

@@ -30,12 +30,12 @@ export interface IconButtonData {
 
 export class IconButton extends HTMLElement {
   readonly #shadow = this.attachShadow({mode: 'open'});
-  #clickHandler: undefined|(() => void) = undefined;
+  #clickHandler?: () => void;
   #groups: IconWithTextData[] = [];
   #compact = false;
   #leadingText = '';
   #trailingText = '';
-  #accessibleName: string|undefined;
+  #accessibleName?: string;
 
   set data(data: IconButtonData) {
     this.#groups = data.groups.map(group => ({...group}));  // Ensure we make a deep copy.

package/front_end/ui/components/issue_counter/IssueCounter.ts

@@ -97,15 +97,15 @@ export function getIssueCountsEnumeration(
 
 export class IssueCounter extends HTMLElement {
   readonly #shadow = this.attachShadow({mode: 'open'});
-  #clickHandler: undefined|(() => void) = undefined;
-  #tooltipCallback: undefined|(() => void) = undefined;
+  #clickHandler?: () => void;
+  #tooltipCallback?: () => void;
   #leadingText = '';
-  #throttler: undefined|Common.Throttler.Throttler;
+  #throttler?: Common.Throttler.Throttler;
   #counts: [number, number, number] = [0, 0, 0];
   #displayMode: DisplayMode = DisplayMode.OMIT_EMPTY;
-  #issuesManager: IssuesManager.IssuesManager.IssuesManager|undefined = undefined;
-  #accessibleName: string|undefined = undefined;
-  #throttlerTimeout: number|undefined;
+  #issuesManager?: IssuesManager.IssuesManager.IssuesManager;
+  #accessibleName?: string;
+  #throttlerTimeout?: number;
   #compact = false;
 
   scheduleUpdate(): void {

package/front_end/ui/components/text_editor/AiCodeCompletionProvider.ts

@@ -47,6 +47,9 @@ export interface AiCodeCompletionConfig {
     getPrefix?: () => string,
     stopSequences?: string[],
   };
+  generationContext: {
+    additionalPreambleContext?: string,
+  };
   onFeatureEnabled: () => void;
   onFeatureDisabled: () => void;
   onSuggestionAccepted: (citations: Host.AidaClient.Citation[]) => void;
@@ -86,6 +89,7 @@ export class AiCodeCompletionProvider {
       this.#aiCodeGenerationConfig = {
         generationContext: {
           inferenceLanguage: this.#aiCodeCompletionConfig.completionContext.inferenceLanguage,
+          additionalPreambleContext: this.#aiCodeCompletionConfig.generationContext.additionalPreambleContext,
         },
         onSuggestionAccepted: this.#aiCodeCompletionConfig.onSuggestionAccepted.bind(this),
         onRequestTriggered: this.#aiCodeCompletionConfig.onRequestTriggered.bind(this),

package/front_end/ui/components/text_editor/AiCodeGenerationProvider.ts

@@ -41,6 +41,7 @@ const aiCodeGenerationTeaserModeState = CodeMirror.StateField.define<AiCodeGener
 
 export interface AiCodeGenerationConfig {
   generationContext: {
+    additionalPreambleContext?: string,
     inferenceLanguage?: Host.AidaClient.AidaInferenceLanguage,
   };
   onSuggestionAccepted: (citations: Host.AidaClient.Citation[]) => void;
@@ -58,6 +59,7 @@ export class AiCodeGenerationProvider {
   #aiCodeGenerationSettingEnabled = this.#aiCodeGenerationEnabledSetting.get();
   #aiCodeGenerationOnboardingCompletedSetting =
       Common.Settings.Settings.instance().createSetting('ai-code-generation-onboarding-completed', false);
+  #aiCodeGenerationUsedSetting = Common.Settings.Settings.instance().createSetting('ai-code-generation-used', false);
   #generationTeaserCompartment = new CodeMirror.Compartment();
   #generationTeaser: PanelCommon.AiCodeGenerationTeaser.AiCodeGenerationTeaser;
   #editor?: TextEditor;
@@ -302,6 +304,8 @@ export class AiCodeGenerationProvider {
       return;
     }
 
+    this.#aiCodeGenerationUsedSetting.set(true);
+
     this.#aiCodeGenerationCitations = [];
     const cursor = this.#editor.state.selection.main.head;
     const commentNodeInfo = AiCodeGenerationParser.extractCommentNodeInfo(this.#editor.state, cursor);
@@ -319,19 +323,20 @@ export class AiCodeGenerationProvider {
     this.#generationTeaser.displayState = PanelCommon.AiCodeGenerationTeaser.AiCodeGenerationTeaserDisplayState.LOADING;
     try {
       const startTime = performance.now();
-      this.#aiCodeGenerationConfig?.onRequestTriggered();
+      this.#aiCodeGenerationConfig.onRequestTriggered();
       Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeGenerationRequestTriggered);
 
+      const preamble = AiCodeGeneration.AiCodeGeneration.basePreamble +
+          this.#aiCodeGenerationConfig.generationContext.additionalPreambleContext;
       const generationResponse = await this.#aiCodeGeneration.generateCode(
-          query, AiCodeGeneration.AiCodeGeneration.basePreamble,
-          this.#aiCodeGenerationConfig?.generationContext.inferenceLanguage, options);
+          query, preamble, this.#aiCodeGenerationConfig.generationContext.inferenceLanguage, options);
 
       if (this.#generationTeaser) {
         this.#dismissTeaserAndSuggestion();
       }
 
       if (!generationResponse || generationResponse.samples.length === 0) {
-        this.#aiCodeGenerationConfig?.onResponseReceived();
+        this.#aiCodeGenerationConfig.onResponseReceived();
         return;
       }
       const topSample = generationResponse.samples[0];
@@ -365,7 +370,7 @@ export class AiCodeGenerationProvider {
       AiCodeGeneration.debugLog('Suggestion dispatched to the editor', suggestionText);
       const citations = topSample.attributionMetadata?.citations ?? [];
       this.#aiCodeGenerationCitations = citations;
-      this.#aiCodeGenerationConfig?.onResponseReceived();
+      this.#aiCodeGenerationConfig.onResponseReceived();
       return;
     } catch (e) {
       if (e instanceof Host.DispatchHttpRequestClient.DispatchHttpRequestError &&
@@ -373,7 +378,7 @@ export class AiCodeGenerationProvider {
         return;
       }
       AiCodeGeneration.debugLog('Error while fetching code generation suggestions from AIDA', e);
-      this.#aiCodeGenerationConfig?.onResponseReceived();
+      this.#aiCodeGenerationConfig.onResponseReceived();
       Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeGenerationError);
     }
 

package/front_end/ui/legacy/ContextMenu.ts

@@ -122,8 +122,6 @@ export class Item {
           label: this.label,
           isExperimentalFeature: this.previewFeature,
           enabled: !this.disabled,
-          checked: undefined,
-          subItems: undefined,
           tooltip: this.#tooltip,
           jslogContext: this.jslogContext,
           featureName: this.featureName,
@@ -145,11 +143,6 @@ export class Item {
       case 'separator': {
         return {
           type: 'separator',
-          id: undefined,
-          label: undefined,
-          enabled: undefined,
-          checked: undefined,
-          subItems: undefined,
         };
       }
       case 'checkbox': {
@@ -160,7 +153,6 @@ export class Item {
           checked: Boolean(this.checked),
           isExperimentalFeature: this.previewFeature,
           enabled: !this.disabled,
-          subItems: undefined,
           tooltip: this.#tooltip,
           jslogContext: this.jslogContext,
         };
@@ -512,8 +504,6 @@ export class SubMenu extends Item {
       isExperimentalFeature: this.previewFeature,
       enabled: !this.disabled,
       subItems: [],
-      id: undefined,
-      checked: undefined,
       jslogContext: this.jslogContext,
       featureName: this.featureName,
     };
@@ -532,11 +522,6 @@ export class SubMenu extends Item {
         }
         result.subItems.push({
           type: 'separator',
-          id: undefined,
-          subItems: undefined,
-          checked: undefined,
-          enabled: undefined,
-          label: undefined,
         });
       }
     }
@@ -1157,8 +1142,7 @@ export function registerProvider<T>(registration: ProviderRegistration<T>): void
 async function loadApplicableRegisteredProviders(target: unknown): Promise<Array<Provider<unknown>>> {
   const providers: Array<Provider<unknown>> = [];
   for (const providerRegistration of registeredProviders) {
-    if (!Root.Runtime.Runtime.isDescriptorEnabled(
-            {experiment: providerRegistration.experiment, condition: undefined})) {
+    if (!Root.Runtime.Runtime.isDescriptorEnabled({experiment: providerRegistration.experiment})) {
       continue;
     }
     if (providerRegistration.contextTypes) {

package/front_end/ui/legacy/EmptyWidget.ts

@@ -26,12 +26,12 @@ const {ref} = Directives;
 interface EmptyWidgetInput {
   header: string;
   text: string;
-  link?: Platform.DevToolsPath.UrlString|undefined|null;
+  link?: Platform.DevToolsPath.UrlString|null;
   extraElements?: Element[];
 }
 
 interface EmptyWidgetOutput {
-  contentElement: Element|undefined;
+  contentElement?: Element;
 }
 
 type View = (input: EmptyWidgetInput, output: EmptyWidgetOutput, target: HTMLElement) => void;
@@ -100,12 +100,12 @@ export class EmptyWidget extends VBox {
       this.#extraElements = [...this.element.children];
       this.#firstUpdate = false;
     }
-    const output = {contentElement: undefined};
+    const output: EmptyWidgetOutput = {};
     this.#view(
         {header: this.#header, text: this.#text, link: this.#link, extraElements: this.#extraElements}, output,
         this.element);
     if (output.contentElement) {
-      this.contentElement = output.contentElement;
+      this.contentElement = output.contentElement as HTMLElement;
     }
   }
 }

package/front_end/ui/legacy/Fragment.ts

@@ -74,7 +74,7 @@ export class Fragment {
       if (node.nodeType === Node.ELEMENT_NODE && node.hasAttributes()) {
         if (node.hasAttribute('$')) {
           nodesToMark.push(node);
-          binds.push({replaceNodeIndex: undefined, attr: undefined, elementId: node.getAttribute('$') || ''});
+          binds.push({elementId: node.getAttribute('$') || ''});
           node.removeAttribute('$');
         }
 
@@ -97,8 +97,6 @@ export class Fragment {
           valueIndex += attr.names.length - 1;
           valueIndex += attr.values.length - 1;
           const bind: Bind = {
-            elementId: undefined,
-            replaceNodeIndex: undefined,
             attr,
           };
           binds.push(bind);
@@ -118,7 +116,7 @@ export class Fragment {
           }
           const nodeToReplace = document.createElement('span');
           nodesToMark.push(nodeToReplace);
-          binds.push({attr: undefined, elementId: undefined, replaceNodeIndex: valueIndex++});
+          binds.push({replaceNodeIndex: valueIndex++});
           parentNode.insertBefore(nodeToReplace, node);
         }
       }