chrome-devtools-frontend 1.0.1587905 → 1.0.1589336

package/front_end/panels/lighthouse/LighthouseController.ts

@@ -760,7 +760,6 @@ export const RuntimeSettings: RuntimeSetting[] = [
         value: 'desktop'
       },
     ],
-    learnMore: undefined,
   },
   {
     setting: Common.Settings.Settings.instance().createSetting(
@@ -820,8 +819,6 @@ export const RuntimeSettings: RuntimeSetting[] = [
     setFlags: (flags: Flags, value: string|boolean) => {
       flags.disableStorageReset = !value;
     },
-    options: undefined,
-    learnMore: undefined,
   },
   {
     setting: Common.Settings.Settings.instance().createSetting(
@@ -835,8 +832,6 @@ export const RuntimeSettings: RuntimeSetting[] = [
         flags.additionalTraceCategories = '';
       }
     },
-    options: undefined,
-    learnMore: undefined,
   },
 ];
 

package/front_end/panels/linear_memory_inspector/linear_memory_inspector-meta.ts

@@ -20,8 +20,7 @@ const UIStrings = {
    */
   showMemoryInspector: 'Show Memory inspector',
 } as const;
-const str_ =
-    i18n.i18n.registerUIStrings('panels/linear_memory_inspector/linear_memory_inspector-meta.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('panels/linear_memory_inspector/linear_memory_inspector-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 let loadedLinearMemoryInspectorModule: (typeof LinearMemoryInspector|undefined);
@@ -51,7 +50,6 @@ UI.ContextMenu.registerProvider({
     const LinearMemoryInspector = await loadLinearMemoryInspectorModule();
     return LinearMemoryInspector.LinearMemoryInspectorController.LinearMemoryInspectorController.instance();
   },
-  experiment: undefined,
   contextTypes() {
     return [
       ObjectUI.ObjectPropertiesSection.ObjectPropertyTreeElement,

package/front_end/panels/media/EventDisplayTable.ts

@@ -116,8 +116,6 @@ export class PlayerEventsView extends UI.Widget.VBox {
     const datagrid = new DataGrid.DataGrid.DataGridImpl({
       displayName: i18nString(UIStrings.eventDisplay),
       columns: gridColumnDescs,
-      deleteCallback: undefined,
-      refreshCallback: undefined,
     });
     datagrid.asWidget().contentElement.classList.add('no-border-top-datagrid');
     return datagrid;

package/front_end/panels/media/PlayerMessagesView.ts

@@ -134,7 +134,7 @@ class MessageLevelSelector implements UI.SoftDropDown.Delegate<SelectableLevel>
       overwrite: true,
       stringValue: '',
       value: MessageLevelBitfield.DEFAULT,
-      selectable: undefined,
+
     });
 
     this.items.insert(this.items.length, {
@@ -142,7 +142,7 @@ class MessageLevelSelector implements UI.SoftDropDown.Delegate<SelectableLevel>
       overwrite: true,
       stringValue: '',
       value: MessageLevelBitfield.ALL,
-      selectable: undefined,
+
     });
 
     this.items.insert(this.items.length, {
@@ -150,7 +150,7 @@ class MessageLevelSelector implements UI.SoftDropDown.Delegate<SelectableLevel>
       overwrite: false,
       stringValue: 'error',
       value: MessageLevelBitfield.ERROR,
-      selectable: undefined,
+
     });
 
     this.items.insert(this.items.length, {
@@ -158,7 +158,6 @@ class MessageLevelSelector implements UI.SoftDropDown.Delegate<SelectableLevel>
       overwrite: false,
       stringValue: 'warning',
       value: MessageLevelBitfield.WARNING,
-      selectable: undefined,
     });
 
     this.items.insert(this.items.length, {
@@ -166,7 +165,6 @@ class MessageLevelSelector implements UI.SoftDropDown.Delegate<SelectableLevel>
       overwrite: false,
       stringValue: 'info',
       value: MessageLevelBitfield.INFO,
-      selectable: undefined,
     });
 
     this.items.insert(this.items.length, {
@@ -174,7 +172,7 @@ class MessageLevelSelector implements UI.SoftDropDown.Delegate<SelectableLevel>
       overwrite: false,
       stringValue: 'debug',
       value: MessageLevelBitfield.DEBUG,
-      selectable: undefined,
+
     });
   }
 

package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts

@@ -735,7 +735,9 @@ export class ThrottlingSettingsTab extends UI.Widget.VBox implements
         const errorMessage = i18nString(UIStrings.profileNameCharactersLengthMust, {PH1: maxLength});
         return {valid, errorMessage};
       }
-      return {valid, errorMessage: undefined};
+      return {
+        valid,
+      };
     }
 
     function throughputValidator(
@@ -753,7 +755,9 @@ export class ThrottlingSettingsTab extends UI.Widget.VBox implements
             {PH1: String(throughput), PH2: minThroughput, PH3: maxThroughput});
         return {valid, errorMessage};
       }
-      return {valid, errorMessage: undefined};
+      return {
+        valid,
+      };
     }
 
     function latencyValidator(_item: SDK.NetworkManager.Conditions, _index: number, input: UI.ListWidget.EditorControl):
@@ -767,7 +771,9 @@ export class ThrottlingSettingsTab extends UI.Widget.VBox implements
         const errorMessage = i18nString(UIStrings.latencyMustBeAnIntegerBetweenSms, {PH1: minLatency, PH2: maxLatency});
         return {valid, errorMessage};
       }
-      return {valid, errorMessage: undefined};
+      return {
+        valid,
+      };
     }
 
     function packetLossValidator(
@@ -783,7 +789,9 @@ export class ThrottlingSettingsTab extends UI.Widget.VBox implements
             i18nString(UIStrings.packetLossMustBeAnIntegerBetweenSpct, {PH1: minPacketLoss, PH2: maxPacketLoss});
         return {valid, errorMessage};
       }
-      return {valid, errorMessage: undefined};
+      return {
+        valid,
+      };
     }
 
     function packetQueueLengthValidator(
@@ -797,13 +805,17 @@ export class ThrottlingSettingsTab extends UI.Widget.VBox implements
         const errorMessage = i18nString(UIStrings.packetQueueLengthMustBeAnIntegerGreaterOrEqualToZero);
         return {valid, errorMessage};
       }
-      return {valid, errorMessage: undefined};
+      return {
+        valid,
+      };
     }
 
     function packetReorderingValidator(
         _item: SDK.NetworkManager.Conditions, _index: number,
         _input: UI.ListWidget.EditorControl): UI.ListWidget.ValidatorResult {
-      return {valid: true, errorMessage: undefined};
+      return {
+        valid: true,
+      };
     }
   }
 }

package/front_end/panels/network/EventSourceMessagesView.ts

@@ -96,8 +96,6 @@ export class EventSourceMessagesView extends UI.Widget.VBox {
     this.dataGrid = new DataGrid.SortableDataGrid.SortableDataGrid({
       displayName: i18nString(UIStrings.eventSource),
       columns,
-      deleteCallback: undefined,
-      refreshCallback: undefined,
     });
     this.dataGrid.setStriped(true);
     this.dataGrid.setEnableAutoScrollToBottom(true);

package/front_end/panels/network/NetworkLogViewColumns.ts

@@ -281,8 +281,6 @@ export class NetworkLogViewColumns {
     this.#dataGrid = new DataGrid.SortableDataGrid.SortableDataGrid<NetworkNode>(({
       displayName: (i18nString(UIStrings.networkLog) as string),
       columns: this.columns.map(NetworkLogViewColumns.convertToDataGridDescriptor),
-      deleteCallback: undefined,
-      refreshCallback: undefined,
     }));
     this.dataGridScroller = (this.#dataGrid.scrollContainer as HTMLDivElement);
 

package/front_end/panels/network/NetworkManageCustomHeadersView.ts

@@ -162,7 +162,9 @@ export class NetworkManageCustomHeadersView extends UI.Widget.VBox implements UI
       if (this.columnConfigs.has(headerId) && item.header !== headerId) {
         valid = false;
       }
-      return {valid, errorMessage: undefined};
+      return {
+        valid,
+      };
     }
   }
 }

package/front_end/panels/network/NetworkWaterfallColumn.ts

@@ -91,7 +91,7 @@ export class NetworkWaterfallColumn extends UI.Widget.VBox {
     this.styleForDownloadingResourceType = resourceStyleTuple[1];
 
     const baseLineColor = ThemeSupport.ThemeSupport.instance().getComputedValue('--sys-color-state-disabled');
-    this.wiskerStyle = {borderColor: baseLineColor, lineWidth: 1, fillStyle: undefined};
+    this.wiskerStyle = {borderColor: baseLineColor, lineWidth: 1};
     this.hoverDetailsStyle = {fillStyle: baseLineColor, lineWidth: 1, borderColor: baseLineColor};
 
     this.pathForStyle = new Map();
@@ -293,7 +293,6 @@ export class NetworkWaterfallColumn extends UI.Widget.VBox {
         content.show(popover.contentElement);
         return true;
       },
-      hide: undefined,
     };
   }
 

package/front_end/panels/network/RequestConditionsDrawer.ts

@@ -524,7 +524,7 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
     const validator =
         (_item: SDK.NetworkManager.RequestCondition, _index: number, input: UI.ListWidget.EditorControl): {
           valid: boolean,
-          errorMessage: Common.UIString.LocalizedString|undefined,
+          errorMessage?: Common.UIString.LocalizedString,
         } => {
           if (!input.value) {
             return {errorMessage: i18nString(UIStrings.patternInputCannotBeEmpty), valid: false};
@@ -539,7 +539,7 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
             case SDK.NetworkManager.RequestURLPatternValidity.HAS_REGEXP_GROUPS:
               return {errorMessage: i18nString(UIStrings.patternFailedWithRegExpGroups), valid: false};
           }
-          return {valid: true, errorMessage: undefined};
+          return {valid: true};
         };
     const urlInput = editor.createInput('url', 'text', '', validator);
     label.htmlFor = urlInput.id = 'editor-url-input';

package/front_end/panels/network/RequestHeadersView.ts

@@ -106,15 +106,118 @@ interface ViewInput {
 }
 type View = (input: ViewInput, output: object, target: HTMLElement) => void;
 export const DEFAULT_VIEW: View = (input, output, target) => {
+  const requestHeadersText = input.request.requestHeadersText();
+  const statusClasses = ['status'];
+  if (input.request.statusCode < 300 || input.request.statusCode === 304) {
+    statusClasses.push('green-circle');
+  } else if (input.request.statusCode < 400) {
+    statusClasses.push('yellow-circle');
+  } else {
+    statusClasses.push('red-circle');
+  }
+
+  let comment = '';
+  if (input.request.cachedInMemory()) {
+    comment = i18nString(UIStrings.fromMemoryCache);
+  } else if (input.request.fromEarlyHints()) {
+    comment = i18nString(UIStrings.fromEarlyHints);
+  } else if (input.request.fetchedViaServiceWorker) {
+    comment = i18nString(UIStrings.fromServiceWorker);
+  } else if (input.request.redirectSourceSignedExchangeInfoHasNoErrors()) {
+    comment = i18nString(UIStrings.fromSignedexchange);
+  } else if (input.request.fromPrefetchCache()) {
+    comment = i18nString(UIStrings.fromPrefetchCache);
+  } else if (input.request.cached()) {
+    comment = i18nString(UIStrings.fromDiskCache);
+  }
+
+  if (comment) {
+    statusClasses.push('status-with-comment');
+  }
+
+  const statusText = [input.request.statusCode, input.request.getInferredStatusText(), comment].join(' ');
+  // clang-format off
   render(
       html`
         <style>${NetworkComponents.RequestHeaderSection.requestHeadersViewStyles}</style>
         <style>${Input.checkboxStyles}</style>
-        ${renderGeneralSection(input)}
-        ${renderEarlyHintsHeaders(input)}
-        ${renderResponseHeaders(input)}
-        ${renderRequestHeaders(input)}
+        ${renderCategory({
+          name: 'general',
+          title: i18nString(UIStrings.general),
+          forceOpen: input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.GENERAL,
+          loggingContext: 'general',
+          contents: html`<div jslog=${VisualLogging.section('general')}>
+            ${renderGeneralRow(input, i18nString(UIStrings.requestUrl), input.request.url(), 'request-url')}
+            ${input.request.statusCode? renderGeneralRow(input, i18nString(UIStrings.requestMethod),
+                input.request.requestMethod, 'request-method') : Lit.nothing}
+            ${input.request.statusCode? renderGeneralRow(input, i18nString(UIStrings.statusCode),
+                statusText, 'status-code', statusClasses) : Lit.nothing}
+            ${input.request.remoteAddress()? renderGeneralRow(input, i18nString(UIStrings.remoteAddress),
+                input.request.remoteAddress(), 'remote-address') : Lit.nothing}
+            ${input.request.referrerPolicy()? renderGeneralRow(input, i18nString(UIStrings.referrerPolicy),
+              String(input.request.referrerPolicy()), 'referrer-policy') : Lit.nothing}
+            </div>`
+        })}
+        ${!input.request?.earlyHintsHeaders || input.request.earlyHintsHeaders.length === 0
+          ? Lit.nothing
+          : renderCategory({
+            name: 'early-hints-headers',
+            onToggleRawHeaders: input.toggleShowRawResponseHeaders,
+            title: i18nString(UIStrings.earlyHintsHeaders),
+            headerCount: input.request.earlyHintsHeaders.length,
+            checked: undefined,
+            additionalContent: undefined,
+            forceOpen: input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.EARLY_HINTS,
+            loggingContext: 'early-hints-headers',
+            contents: input.showResponseHeadersText ?
+              renderRawHeaders(input.request.responseHeadersText) :
+              html`
+            <devtools-early-hints-header-section .data=${
+              {
+                request: input.request,
+                toReveal: input.toReveal,
+              } as NetworkComponents.ResponseHeaderSection
+              .ResponseHeaderSectionData}></devtools-early-hints-header-section>
+              `
+          })}
+        ${renderCategory({
+          name: 'response-headers',
+          onToggleRawHeaders: input.toggleShowRawResponseHeaders,
+          title: i18nString(UIStrings.responseHeaders),
+          headerCount: input.request.sortedResponseHeaders.length,
+          checked: input.request.responseHeadersText ? input.showResponseHeadersText : undefined,
+          additionalContent: renderHeaderOverridesLink(input),
+          forceOpen: input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.RESPONSE,
+          loggingContext: 'response-headers',
+          contents: input.showResponseHeadersText ?
+            renderRawHeaders(input.request.responseHeadersText) :
+            html`
+          <devtools-response-header-section .data=${{
+            request: input.request,
+            toReveal: input.toReveal,
+          } as NetworkComponents.ResponseHeaderSection.ResponseHeaderSectionData} jslog=${
+            VisualLogging.section('response-headers')}></devtools-response-header-section>
+            `
+        })}
+        ${renderCategory({
+          name: 'request-headers',
+          onToggleRawHeaders: input.toggleShowRawRequestHeaders,
+          title: i18nString(UIStrings.requestHeaders),
+          headerCount: input.request.requestHeaders().length,
+          checked: requestHeadersText ? input.showRequestHeadersText : undefined,
+          forceOpen: input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.REQUEST,
+          loggingContext: 'request-headers',
+          contents: (input.showRequestHeadersText && requestHeadersText) ?
+            renderRawHeaders(requestHeadersText) :
+            html`
+          <devtools-widget .widgetConfig=${
+            UI.Widget.widgetConfig(NetworkComponents.RequestHeaderSection.RequestHeaderSection, {
+              request: input.request,
+              toReveal: input.toReveal,
+            })} jslog=${VisualLogging.section('request-headers')}></devtools-widget>`
+        })}
       `,
+      // clang-format on
       target);
 };
 
@@ -247,52 +350,6 @@ export class RequestHeadersView extends UI.Widget.Widget {
   }
 }
 
-function renderEarlyHintsHeaders(input: ViewInput): Lit.LitTemplate {
-  if (!input.request?.earlyHintsHeaders || input.request.earlyHintsHeaders.length === 0) {
-    return Lit.nothing;
-  }
-
-  // Disabled until https://crbug.com/1079231 is fixed.
-  return renderCategory({
-    onToggleRawHeaders: input.toggleShowRawResponseHeaders,
-    name: 'early-hints-headers',
-    title: i18nString(UIStrings.earlyHintsHeaders),
-    headerCount: input.request.earlyHintsHeaders.length,
-    checked: undefined,
-    additionalContent: undefined,
-    forceOpen: input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.EARLY_HINTS,
-    loggingContext: 'early-hints-headers',
-    contents: input.showResponseHeadersText ? renderRawHeaders(input.request.responseHeadersText) : html`
-          <devtools-early-hints-header-section .data=${{
-      request: input.request,
-      toReveal: input.toReveal,
-    } as NetworkComponents.ResponseHeaderSection.ResponseHeaderSectionData}></devtools-early-hints-header-section>
-        `
-  });
-}
-
-function renderResponseHeaders(input: ViewInput): Lit.LitTemplate {
-  return renderCategory({
-    onToggleRawHeaders: input.toggleShowRawResponseHeaders,
-    name: 'response-headers',
-    title: i18nString(UIStrings.responseHeaders),
-    headerCount: input.request.sortedResponseHeaders.length,
-    checked: input.request.responseHeadersText ? input.showResponseHeadersText : undefined,
-    additionalContent: renderHeaderOverridesLink(input),
-    forceOpen: input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.RESPONSE,
-    loggingContext: 'response-headers',
-    contents: input.showResponseHeadersText ?
-        renderRawHeaders(input.request.responseHeadersText) :
-        html`
-          <devtools-response-header-section .data=${{
-          request: input.request,
-          toReveal: input.toReveal,
-        } as NetworkComponents.ResponseHeaderSection.ResponseHeaderSectionData} jslog=${
-            VisualLogging.section('response-headers')}></devtools-response-header-section>
-        `
-  });
-}
-
 function renderHeaderOverridesLink(input: ViewInput): Lit.LitTemplate {
   if (!input.revealHeadersFile) {
     return Lit.nothing;
@@ -334,88 +391,17 @@ function renderHeaderOverridesLink(input: ViewInput): Lit.LitTemplate {
   // clang-format on
 }
 
-function renderRequestHeaders(input: ViewInput): Lit.LitTemplate {
-  const requestHeadersText = input.request.requestHeadersText();
-
-  return renderCategory({
-    onToggleRawHeaders: input.toggleShowRawRequestHeaders,
-    name: 'request-headers',
-    title: i18nString(UIStrings.requestHeaders),
-    headerCount: input.request.requestHeaders().length,
-    checked: requestHeadersText ? input.showRequestHeadersText : undefined,
-    forceOpen: input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.REQUEST,
-    loggingContext: 'request-headers',
-    contents: (input.showRequestHeadersText && requestHeadersText) ?
-        renderRawHeaders(requestHeadersText) :
-        html`
-          <devtools-widget .widgetConfig=${
-            UI.Widget.widgetConfig(NetworkComponents.RequestHeaderSection.RequestHeaderSection, {
-              request: input.request,
-              toReveal: input.toReveal,
-            })} jslog=${VisualLogging.section('request-headers')}></devtools-widget>`
-  });
-}
-
 function renderRawHeaders(text: string): Lit.TemplateResult {
   return html`<div class="row raw-headers-row"><devtools-widget  class=raw-headers .widgetConfig=${
       UI.Widget.widgetConfig(ShowMoreDetailsWidget, {text})}></devtools-widget></div>`;
 }
 
-function renderGeneralSection(input: ViewInput): Lit.LitTemplate {
-  const statusClasses = ['status'];
-  if (input.request.statusCode < 300 || input.request.statusCode === 304) {
-    statusClasses.push('green-circle');
-  } else if (input.request.statusCode < 400) {
-    statusClasses.push('yellow-circle');
-  } else {
-    statusClasses.push('red-circle');
-  }
-
-  let comment = '';
-  if (input.request.cachedInMemory()) {
-    comment = i18nString(UIStrings.fromMemoryCache);
-  } else if (input.request.fromEarlyHints()) {
-    comment = i18nString(UIStrings.fromEarlyHints);
-  } else if (input.request.fetchedViaServiceWorker) {
-    comment = i18nString(UIStrings.fromServiceWorker);
-  } else if (input.request.redirectSourceSignedExchangeInfoHasNoErrors()) {
-    comment = i18nString(UIStrings.fromSignedexchange);
-  } else if (input.request.fromPrefetchCache()) {
-    comment = i18nString(UIStrings.fromPrefetchCache);
-  } else if (input.request.cached()) {
-    comment = i18nString(UIStrings.fromDiskCache);
-  }
-
-  if (comment) {
-    statusClasses.push('status-with-comment');
-  }
-
-  const statusText = [input.request.statusCode, input.request.getInferredStatusText(), comment].join(' ');
-
-  return renderCategory({
-    name: 'general',
-    title: i18nString(UIStrings.general),
-    forceOpen: input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.GENERAL,
-    loggingContext: 'general',
-    // clang-format off
-          contents: html`<div jslog=${VisualLogging.section('general')}>
-        ${renderGeneralRow(i18nString(UIStrings.requestUrl), input.request.url(), 'request-url')}
-        ${input.request.statusCode? renderGeneralRow(i18nString(UIStrings.requestMethod),
-            input.request.requestMethod, 'request-method') : Lit.nothing}
-        ${input.request.statusCode? renderGeneralRow(i18nString(UIStrings.statusCode),
-            statusText, 'status-code', statusClasses) : Lit.nothing}
-        ${input.request.remoteAddress()? renderGeneralRow(i18nString(UIStrings.remoteAddress),
-            input.request.remoteAddress(), 'remote-address') : Lit.nothing}
-        ${input.request.referrerPolicy()? renderGeneralRow(i18nString(UIStrings.referrerPolicy),
-            String(input.request.referrerPolicy()), 'referrer-policy') : Lit.nothing}
-      </div>`});
-  // clang-format on
-
-  function renderGeneralRow(
-      name: Common.UIString.LocalizedString, value: string, id: string, classNames?: string[]): Lit.LitTemplate {
-    const isHighlighted = input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.GENERAL &&
-        name.toLowerCase() === input.toReveal?.header?.toLowerCase();
-    return html`
+function renderGeneralRow(
+    input: ViewInput, name: Common.UIString.LocalizedString, value: string, id: string,
+    classNames?: string[]): Lit.LitTemplate {
+  const isHighlighted = input.toReveal?.section === NetworkForward.UIRequestLocation.UIHeaderSection.GENERAL &&
+      name.toLowerCase() === input.toReveal?.header?.toLowerCase();
+  return html`
       <div class="row ${isHighlighted ? 'header-highlight' : ''}">
         <div class="header-name">${name}</div>
         <div
@@ -425,7 +411,6 @@ function renderGeneralSection(input: ViewInput): Lit.LitTemplate {
         >${value}</div>
       </div>
     `;
-  }
 }
 
 export function renderCategory(data: {