chrome-devtools-frontend 1.0.1587905 → 1.0.1589336

package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts

@@ -191,23 +191,27 @@ export class ContextSelectionAgent extends AiAgent<never> {
       displayInfoFromArgs: () => {
         return {
           title: lockedString('Listing source requests…'),
-          action: 'listSourceFile()',
+          action: 'listSourceFiles()',
         };
       },
       handler: async () => {
-        const files = [];
+        // We get multiple of the same file name
+        // so we create a set and the pick based
+        // on heuristics in the select function
+        const files = new Set();
         for (const file of this.#getUISourceCodes()) {
-          files.push(file.fullDisplayName());
+          files.add(file.fullDisplayName());
         }
 
         return {
-          result: files,
+          result: [...files],
         };
       },
     });
 
     this.declareFunction<{name: string}>('selectSourceFile', {
-      description: `Selects a source file. Use this when asked about files on the page.`,
+      description:
+          `Selects a source file. Use this when asked about files on the page. Use listSourceFiles if you don't know the full path name.`,
       parameters: {
         type: Host.AidaClient.ParametersTypes.OBJECT,
         description: '',
@@ -216,7 +220,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
         properties: {
           name: {
             type: Host.AidaClient.ParametersTypes.STRING,
-            description: 'The name of the file you want to select.',
+            description: 'The full path name of the file you want to select.',
             nullable: false,
           },
         },
@@ -228,17 +232,21 @@ export class ContextSelectionAgent extends AiAgent<never> {
         };
       },
       handler: async params => {
-        for (const file of this.#getUISourceCodes()) {
-          if (file.fullDisplayName() === params.name) {
-            return {
-              context: new FileContext(file),
-              description: 'User selected a source file',
-            };
-          }
+        // In some cases we get multiple files
+        // use the heuristics bellow to pick the better one
+        const files = this.#getUISourceCodes().filter(file => file.fullDisplayName() === params.name);
+
+        if (files.length === 0) {
+          return {
+            error: 'Unable to find file.',
+          };
         }
 
+        // This help us pick the file that is resolved source map.
+        const file = files.find(f => f.contentType().isFromSourceMap()) ?? files[0];
         return {
-          error: 'Unable to find file.',
+          context: new FileContext(file),
+          description: 'User selected a source file',
         };
       },
     });
@@ -307,22 +315,16 @@ export class ContextSelectionAgent extends AiAgent<never> {
     });
   }
 
-  #getUISourceCodes = (): Iterable<Workspace.UISourceCode.UISourceCode> => {
+  #getUISourceCodes = (): Workspace.UISourceCode.UISourceCode[] => {
     const workspace = Workspace.Workspace.WorkspaceImpl.instance();
-    const projects = workspace.projects().filter(project => {
-      switch (project.type()) {
-        case Workspace.Workspace.projectTypes.Network:
-        case Workspace.Workspace.projectTypes.FileSystem:
-        case Workspace.Workspace.projectTypes.ConnectableFileSystem:
-          return true;
-
-        default:
-          return false;
-      }
-    });
+    const projects =
+        workspace.projects().filter(project => project.type() === Workspace.Workspace.projectTypes.Network);
     const uiSourceCodes = [];
     for (const project of projects) {
       for (const uiSourceCode of project.uiSourceCodes()) {
+        if (uiSourceCode.isIgnoreListed()) {
+          continue;
+        }
         uiSourceCodes.push(uiSourceCode);
       }
     }

package/front_end/models/bindings/DebuggerLanguagePlugins.ts

@@ -434,7 +434,7 @@ export class DebuggerLanguagePluginManager implements
   private async evaluateOnCallFrame(
       callFrame: SDK.DebuggerModel.CallFrame, options: SDK.RuntimeModel.EvaluationOptions): Promise<{
     object: SDK.RemoteObject.RemoteObject,
-    exceptionDetails: Protocol.Runtime.ExceptionDetails|undefined,
+    exceptionDetails?: Protocol.Runtime.ExceptionDetails,
   }|{
     error: string,
   }|null> {
@@ -460,9 +460,9 @@ export class DebuggerLanguagePluginManager implements
     try {
       const object = await plugin.evaluate(expression, location, this.stopIdForCallFrame(callFrame));
       if (object) {
-        return {object: await wrapRemoteObject(callFrame, object, plugin), exceptionDetails: undefined};
+        return {object: await wrapRemoteObject(callFrame, object, plugin)};
       }
-      return {object: new SDK.RemoteObject.LocalJSONObject(undefined), exceptionDetails: undefined};
+      return {object: new SDK.RemoteObject.LocalJSONObject(undefined)};
     } catch (error) {
       if (error instanceof FormattingError) {
         const {exception: object, exceptionDetails} = error;
@@ -794,14 +794,12 @@ export class DebuggerLanguagePluginManager implements
       if (uiLocation) {
         return {
           uiSourceCode: uiLocation.uiSourceCode,
-          url: undefined,
           name,
           line: uiLocation.lineNumber,
           column: uiLocation.columnNumber ?? -1,
         };
       }
       return {
-        uiSourceCode: undefined,
         url: fallback.url,
         name: fallback.functionName,
         line: fallback.lineNumber,

package/front_end/models/computed_style/ComputedStyleModel.ts

@@ -176,7 +176,8 @@ export const enum Events {
 }
 
 export type CSSModelChangedEvent = SDK.CSSStyleSheetHeader.CSSStyleSheetHeader|SDK.CSSModel.StyleSheetChangedEvent|
-                                   SDK.CSSModel.PseudoStateForcedEvent|SDK.DOMModel.DOMNode|null|void;
+                                   SDK.CSSModel.PseudoStateForcedEvent|SDK.DOMModel.DOMNode|
+                                   SDK.CSSModel.ComputedStyleUpdatedEvent|null|void;
 
 export interface EventTypes {
   [Events.CSS_MODEL_CHANGED]: CSSModelChangedEvent;

package/front_end/models/emulation/DeviceModeModel.ts

@@ -700,9 +700,6 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
         positionX,
         positionY,
         dontSetVisibleSize: true,
-        displayFeature: undefined,
-        devicePosture: undefined,
-        screenOrientation: undefined,
       };
       if (displayFeature) {
         metrics.displayFeature = displayFeature;

package/front_end/models/emulation/EmulatedDevices.ts

@@ -394,8 +394,6 @@ export class EmulatedDevice {
         height: orientation.hinge.height,
         x: orientation.hinge.x,
         y: orientation.hinge.y,
-        contentColor: undefined,
-        outlineColor: undefined,
       } as {
         width: number,
         height: number,

package/front_end/models/extensions/ExtensionAPI.ts

@@ -385,7 +385,7 @@ declare global {
          injectedScriptId: number, targetWindow?: Window) => void;
     buildExtensionAPIInjectedScript(
         extensionInfo: ExtensionDescriptor, inspectedTabId: string, themeName: string, keysToForward: number[],
-        testHook: undefined|((extensionServer: unknown, extensionAPI: unknown) => unknown)): string;
+        testHook?: (extensionServer: unknown, extensionAPI: unknown) => unknown): string;
     chrome: PublicAPI.Chrome.DevTools.Chrome;
     webInspector?: APIImpl.InspectorExtensionAPI;
   }
@@ -432,7 +432,7 @@ namespace APIImpl {
   export interface EventSink<ListenerT extends Callable> extends PublicAPI.Chrome.DevTools.EventSink<ListenerT> {
     _type: string;
     _listeners: ListenerT[];
-    _customDispatch: undefined|((this: EventSink<ListenerT>, request: {arguments: unknown[]}) => unknown);
+    _customDispatch?: (this: EventSink<ListenerT>, request: {arguments: unknown[]}) => unknown;
 
     _fire(..._vararg: Parameters<ListenerT>): void;
     _dispatch(request: {arguments: unknown[]}): void;

package/front_end/models/har/Importer.ts

@@ -162,7 +162,6 @@ export class Importer {
     const includedRequestCookies = entry.request.cookies.map(
         cookie => ({
           cookie: this.fillCookieFromHARCookie(SDK.Cookie.Type.REQUEST, cookie),
-          exemptionReason: undefined,
         }),
     );
     request.setIncludedRequestCookies(includedRequestCookies);

package/front_end/models/har/Log.ts

@@ -120,15 +120,11 @@ export class Entry {
     }
 
     const entry: EntryDTO = {
-      _connectionId: undefined,
-      _fromCache: undefined,
       _initiator: exportedInitiator,
       _priority: harEntry.request.priority(),
       _resourceType: harEntry.request.resourceType().name(),
-      _webSocketMessages: undefined,
       cache: {},
       connection,
-      pageref: undefined,
       request: await harEntry.buildRequest(),
       response: harEntry.buildResponse(),
       // IPv6 address should not have square brackets per (https://tools.ietf.org/html/rfc2373#section-2.2).
@@ -195,7 +191,6 @@ export class Entry {
           this.request.includedRequestCookies().map(includedRequestCookie => includedRequestCookie.cookie)),
       headersSize: headersText ? headersText.length : -1,
       bodySize: await this.requestBodySize(),
-      postData: undefined,
     };
     const postData = await this.buildPostData();
     if (postData) {
@@ -232,11 +227,10 @@ export class Entry {
   }
 
   private buildContent(): Content {
-    const content = ({
+    const content: Content = {
       size: this.request.resourceSize,
       mimeType: this.request.mimeType || 'x-unknown',
-      compression: undefined,
-    } as Content);
+    };
     const compression = this.responseCompression;
     if (typeof compression === 'number') {
       content.compression = compression;
@@ -261,7 +255,6 @@ export class Entry {
       wait: 0,
       receive: 0,
       _blocked_queueing: -1,
-      _blocked_proxy: undefined,
     };
 
     const queuedTime = (issueTime < startTime) ? startTime - issueTime : -1;
@@ -373,8 +366,6 @@ export class Entry {
       expires: cookie.expiresDate(Log.pseudoWallTime(this.request, this.request.startTime)),
       httpOnly: cookie.httpOnly(),
       secure: cookie.secure(),
-      sameSite: undefined,
-      partitionKey: undefined,
     };
     if (cookie.sameSite()) {
       c.sameSite = cookie.sameSite();

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -6551,14 +6551,6 @@ export const NativeFunctions = [
     name: "timeout",
     signatures: [["milliseconds"]]
   },
-  {
-    name: "AttributePart",
-    signatures: [["root","element","localName","?init"]]
-  },
-  {
-    name: "ChildNodePart",
-    signatures: [["root","previousSibling","nextSibling","?init"]]
-  },
   {
     name: "Comment",
     signatures: [["?data"]]
@@ -6623,10 +6615,6 @@ export const NativeFunctions = [
     name: "Event",
     signatures: [["type","?eventInitDict"]]
   },
-  {
-    name: "getValueRange",
-    signatures: [["start","end"]]
-  },
   {
     name: "getBoxQuads",
     signatures: [["?options"]]
@@ -6647,10 +6635,6 @@ export const NativeFunctions = [
     name: "MutationObserver",
     signatures: [["callback"]]
   },
-  {
-    name: "NodePart",
-    signatures: [["root","node","?init"]]
-  },
   {
     name: "Observable",
     signatures: [["callback"]]
@@ -6683,6 +6667,10 @@ export const NativeFunctions = [
     name: "last",
     signatures: [["?options"]]
   },
+  {
+    name: "getValueRange",
+    signatures: [["start","end"]]
+  },
   {
     name: "moveBefore",
     signatures: [["node","child"]]
@@ -6801,10 +6789,6 @@ export const NativeFunctions = [
     name: "MouseEvent",
     signatures: [["type","?eventInitDict"]]
   },
-  {
-    name: "OverscrollEvent",
-    signatures: [["type","bubbles","?eventInitDict"]]
-  },
   {
     name: "PageTransitionEvent",
     signatures: [["type","?eventInitDict"]]
@@ -8948,7 +8932,7 @@ export const NativeFunctions = [
   },
   {
     name: "framebufferTexturePixelLocalStorageWEBGL",
-    signatures: [["plane","texture","level","layer"]]
+    signatures: [["plane","texture","level","layer","usage"]]
   },
   {
     name: "framebufferPixelLocalClearValuefvWEBGL",

package/front_end/models/logs/NetworkLog.ts

@@ -159,7 +159,6 @@ export class NetworkLog extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
     initiatorInfo = {
       info: null,
       chain: null,
-      request: undefined,
     };
     this.#initiatorData.set(request, initiatorInfo);
     return initiatorInfo;
@@ -170,7 +169,6 @@ export class NetworkLog extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
     const initiatorInfo: InitiatorData = existingInitiatorData || {
       info: null,
       chain: null,
-      request: undefined,
     };
 
     let type = SDK.NetworkRequest.InitiatorType.OTHER;

package/front_end/models/network_time_calculator/NetworkTimeCalculator.ts

@@ -212,7 +212,10 @@ export class NetworkTimeCalculator extends Common.ObjectWrapper.ObjectWrapper<Ev
     const leftLabel = hasLatency ? i18n.TimeUtilities.secondsToString(request.latency) : rightLabel;
 
     if (request.timing) {
-      return {left: leftLabel, right: rightLabel, tooltip: undefined};
+      return {
+        left: leftLabel,
+        right: rightLabel,
+      };
     }
 
     let tooltip;

package/front_end/models/text_utils/TextUtils.ts

@@ -107,14 +107,11 @@ export class FilterParser {
         if (this.keys.indexOf((parsedKey as string)) !== -1) {
           parsedFilters.push({
             key: parsedKey,
-            regex: undefined,
             text: parsedValue,
             negative: Boolean(startsWithMinus),
           });
         } else {
           parsedFilters.push({
-            key: undefined,
-            regex: undefined,
             text: `${parsedKey}:${parsedValue}`,
             negative: Boolean(startsWithMinus),
           });
@@ -124,15 +121,11 @@ export class FilterParser {
         const parsedRegex = captureGroups[1];
         try {
           parsedFilters.push({
-            key: undefined,
             regex: new RegExp((parsedRegex as string), 'im'),
-            text: undefined,
             negative: Boolean(startsWithMinus),
           });
         } catch {
           parsedFilters.push({
-            key: undefined,
-            regex: undefined,
             text: `/${parsedRegex}/`,
             negative: Boolean(startsWithMinus),
           });
@@ -141,8 +134,6 @@ export class FilterParser {
         const startsWithMinus = captureGroups[0];
         const parsedText = captureGroups[1];
         parsedFilters.push({
-          key: undefined,
-          regex: undefined,
           text: parsedText,
           negative: Boolean(startsWithMinus),
         });

package/front_end/models/trace/LanternComputationData.ts

@@ -193,12 +193,7 @@ function createLanternRequest(
     priority: request.args.data.priority,
     frameId: request.args.data.frame,
     fromWorker,
-    serverResponseTime: request.args.data.lrServerResponseTime ?? undefined,
-    // Set later.
-    redirects: undefined,
-    redirectSource: undefined,
-    redirectDestination: undefined,
-    initiatorRequest: undefined,
+    serverResponseTime: request.args.data.lrServerResponseTime,
   };
 }
 

package/front_end/models/trace/helpers/Trace.ts

@@ -615,10 +615,7 @@ function getRawLineAndColumnNumbersForEvent(event: Types.Events.Event): {
   columnNumber?: number,
 } {
   if (!event.args?.data) {
-    return {
-      lineNumber: undefined,
-      columnNumber: undefined,
-    };
+    return {};
   }
   let lineNumber: number|undefined = undefined;
   let columnNumber: number|undefined = undefined;

package/front_end/models/trace/lantern/types/Lantern.ts

@@ -115,20 +115,20 @@ export interface NetworkRequest<T = AnyNetworkObject> {
   failed: boolean;
   statusCode: number;
   /** The network request that redirected to this one */
-  redirectSource: NetworkRequest<T>|undefined;
+  redirectSource?: NetworkRequest<T>;
   /** The network request that this one redirected to */
-  redirectDestination: NetworkRequest<T>|undefined;
+  redirectDestination?: NetworkRequest<T>;
   // TODO: can't use Protocol.Network.Initiator because of type mismatch in Lighthouse initiator.
   initiator: {
     type: InitiatorType,
     url?: string,
     stack?: CallStack,
   };
-  initiatorRequest: NetworkRequest<T>|undefined;
+  initiatorRequest?: NetworkRequest<T>;
   /** The chain of network requests that redirected to this one */
-  redirects: NetworkRequest[]|undefined;
-  timing: Protocol.Network.ResourceTiming|undefined;
-  resourceType: ResourceType|undefined;
+  redirects?: NetworkRequest[]|undefined;
+  timing?: Protocol.Network.ResourceTiming;
+  resourceType?: ResourceType;
   mimeType: string;
   priority: ResourcePriority;
   frameId: string|undefined;

package/front_end/panels/accessibility/AccessibilityNodeView.ts

@@ -315,14 +315,14 @@ export class AXNodePropertyTreeElement extends UI.TreeOutline.TreeElement {
   appendRelatedNode(relatedNode: Protocol.Accessibility.AXRelatedNode, _index: number): void {
     const deferredNode =
         new SDK.DOMModel.DeferredDOMNode(this.axNode.accessibilityModel().target(), relatedNode.backendDOMNodeId);
-    const nodeTreeElement = new AXRelatedNodeSourceTreeElement({deferredNode, idref: undefined}, relatedNode);
+    const nodeTreeElement = new AXRelatedNodeSourceTreeElement({deferredNode}, relatedNode);
     this.appendChild(nodeTreeElement);
   }
 
   appendRelatedNodeInline(relatedNode: Protocol.Accessibility.AXRelatedNode): void {
     const deferredNode =
         new SDK.DOMModel.DeferredDOMNode(this.axNode.accessibilityModel().target(), relatedNode.backendDOMNodeId);
-    const linkedNode = new AXRelatedNodeElement({deferredNode, idref: undefined});
+    const linkedNode = new AXRelatedNodeElement({deferredNode});
     this.listItemElement.appendChild(linkedNode.render());
   }
 
@@ -440,9 +440,9 @@ export class AXValueSourceTreeElement extends AXNodePropertyTreeElement {
       if (matchingNode) {
         this.appendRelatedNodeWithIdref(matchingNode, idref);
       } else if (idrefs.length === 1) {
-        this.listItemElement.appendChild(new AXRelatedNodeElement({deferredNode: undefined, idref}).render());
+        this.listItemElement.appendChild(new AXRelatedNodeElement({idref}).render());
       } else {
-        this.appendChild(new AXRelatedNodeSourceTreeElement({deferredNode: undefined, idref}));
+        this.appendChild(new AXRelatedNodeSourceTreeElement({idref}));
       }
     }
   }
@@ -591,8 +591,9 @@ export class AXRelatedNodeElement {
         if (!node) {
           return;
         }
-        valueElement.appendChild(PanelsCommon.DOMLinkifier.Linkifier.instance().linkify(
-            node, {tooltip: undefined, preventKeyboardFocus: true}));
+        valueElement.appendChild(PanelsCommon.DOMLinkifier.Linkifier.instance().linkify(node, {
+          preventKeyboardFocus: true,
+        }));
       });
     } else if (this.idref) {
       element.classList.add('invalid');

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -275,9 +275,9 @@ async function getEmptyStateSuggestions(conversation?: AiAssistanceModel.AiConve
 
     case AiAssistanceModel.AiHistoryStorage.ConversationType.NONE: {
       return [
-        {title: 'How can I use DevTools to debug?', jslogContext: 'empty'},
-        {title: 'What performance issues exist with my page?', jslogContext: 'empty'},
-        {title: 'What are the slowest requests on this page?', jslogContext: 'empty'},
+        {title: 'What can you help me with?', jslogContext: 'empty'},
+        {title: 'What performance issues exist on the page?', jslogContext: 'empty'},
+        {title: 'What are the slowest network requests on this page?', jslogContext: 'empty'},
       ];
     }
 
@@ -503,7 +503,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   #selectedRequest: AiAssistanceModel.NetworkAgent.RequestContext|null = null;
   // Messages displayed in the `ChatView` component.
   #messages: Message[] = [];
-  #isContextAutoSelectionSuspended = false;
 
   // Whether the UI should show loading or not.
   #isLoading = false;
@@ -703,13 +702,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     // If there already is an agent and if it is not empty,
     // we don't automatically change the agent.
     if (this.#conversation && !this.#conversation.isEmpty) {
-      // If the context selection agent is enabled,
-      // we update the context of the current agent.
-      const context = this.#getConversationContext(this.#getDefaultConversationType());
-      if (context && isAiAssistanceContextSelectionAgentEnabled()) {
-        this.#conversation?.setContext(context);
-        this.requestUpdate();
-      }
       return;
     }
 
@@ -758,13 +750,20 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       }
 
       this.#conversation = conversation;
-      this.#isContextAutoSelectionSuspended = false;
     }
 
-    if (!this.#isContextAutoSelectionSuspended) {
-      this.#conversation?.setContext(this.#getConversationContext(
-          isAiAssistanceContextSelectionAgentEnabled() ? this.#getDefaultConversationType() :
-                                                         (this.#conversation?.type ?? null)));
+    if (this.#conversation) {
+      if (this.#conversation.isEmpty && isAiAssistanceContextSelectionAgentEnabled()) {
+        this.#conversation.setContext(this.#getConversationContext(this.#getDefaultConversationType()));
+      } else {
+        const context = this.#getConversationContext(this.#conversation.type);
+        // Don't reset to the context selection agent if
+        // we remove context automatically.
+        // Require explicit user action.
+        if (context || !isAiAssistanceContextSelectionAgentEnabled()) {
+          this.#conversation.setContext(context);
+        }
+      }
     }
 
     this.requestUpdate();
@@ -1132,12 +1131,10 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
   #handleContextRemoved(): void {
     this.#conversation?.setContext(null);
-    this.#isContextAutoSelectionSuspended = true;
     this.requestUpdate();
   }
 
   #handleContextAdd(): void {
-    this.#isContextAutoSelectionSuspended = false;
     this.#conversation?.setContext(this.#getConversationContext(this.#getDefaultConversationType()));
     this.requestUpdate();
   }
@@ -1159,7 +1156,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       return;
     }
 
-    this.#isContextAutoSelectionSuspended = false;
     let targetConversationType: AiAssistanceModel.AiHistoryStorage.ConversationType|undefined;
     switch (actionId) {
       case 'freestyler.elements-floating-button': {
@@ -1354,8 +1350,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       this.#selectedPerformanceTrace = data;
     }
 
-    this.#isContextAutoSelectionSuspended = false;
-
     void VisualLogging.logFunctionCall(`context-change-${this.#conversation?.type}`);
 
     this.requestUpdate();
@@ -1428,11 +1422,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     const signal = this.#runAbortController.signal;
 
     // If a different context is provided, it must be from the same origin.
-    if (this.#conversation.isBlockedByOrigin) {
-      // This error should not be reached. If it happens, some
-      // invariants do not hold anymore.
-      throw new Error('cross-origin context data should not be included');
-    }
     if (this.#conversation.isEmpty) {
       Badges.UserBadges.instance().recordAction(Badges.BadgeAction.STARTED_AI_CONVERSATION);
     }

package/front_end/panels/application/BackgroundServiceView.ts

@@ -396,8 +396,6 @@ export class BackgroundServiceView extends UI.Widget.VBox {
     const dataGrid = new DataGrid.DataGrid.DataGridImpl({
       displayName: i18nString(UIStrings.backgroundServices),
       columns,
-      refreshCallback: undefined,
-      deleteCallback: undefined,
     });
     dataGrid.setStriped(true);
 

package/front_end/panels/application/DeviceBoundSessionsModel.ts

@@ -146,7 +146,6 @@ export class DeviceBoundSessionsModel extends Common.ObjectWrapper.ObjectWrapper
     let sessionAndEvent = sessionIdToSessionMap.get(sessionId);
     if (!sessionAndEvent) {
       sessionAndEvent = {
-        session: undefined,
         isSessionTerminated: false,
         hasErrors: false,
         eventsById: new Map<string, EventWithTimestamp>()