chrome-devtools-frontend 1.0.1587905 → 1.0.1589336

package/docs/ui_engineering.md

@@ -1370,9 +1370,9 @@ export const DEFAULT_VIEW = (input, _output, target) => {
       <devtools-tree .template=${html`
         <ul role="tree">
           <li role="treeitem">Node 1</li>
-          <li role="treeitem">
+          <li role="treeitem" open>
             Node 2
-            <ul role="group" hidden>
+            <ul role="group">
               <li role="treeitem">Child 1</li>
             </ul>
           </li>

package/front_end/core/common/AppProvider.ts

@@ -17,8 +17,7 @@ export function registerAppProvider(registration: AppProviderRegistration): void
 }
 export function getRegisteredAppProviders(): AppProviderRegistration[] {
   return registeredAppProvider
-      .filter(
-          provider => Root.Runtime.Runtime.isDescriptorEnabled({experiment: undefined, condition: provider.condition}))
+      .filter(provider => Root.Runtime.Runtime.isDescriptorEnabled({condition: provider.condition}))
       .sort((firstProvider, secondProvider) => {
         const order1 = firstProvider.order || 0;
         const order2 = secondProvider.order || 0;

package/front_end/core/common/Color.ts

@@ -792,7 +792,7 @@ export class Lab implements Color {
     return params;
   }
 
-  constructor(l: number, a: number, b: number, alpha: number|null, authoredText?: string|undefined) {
+  constructor(l: number, a: number, b: number, alpha: number|null, authoredText?: string) {
     this.#rawParams = [l, a, b];
     this.l = clamp(l, {min: 0, max: 100});
     if (equals(this.l, 0, WIDE_RANGE_EPSILON) || equals(this.l, 100, WIDE_RANGE_EPSILON)) {
@@ -931,7 +931,7 @@ export class LCH implements Color {
     return params;
   }
 
-  constructor(l: number, c: number, h: number, alpha: number|null, authoredText?: string|undefined) {
+  constructor(l: number, c: number, h: number, alpha: number|null, authoredText?: string) {
     this.#rawParams = [l, c, h];
     this.l = clamp(l, {min: 0, max: 100});
     c = equals(this.l, 0, WIDE_RANGE_EPSILON) || equals(this.l, 100, WIDE_RANGE_EPSILON) ? 0 : c;
@@ -1073,7 +1073,7 @@ export class Oklab implements Color {
     return params;
   }
 
-  constructor(l: number, a: number, b: number, alpha: number|null, authoredText?: string|undefined) {
+  constructor(l: number, a: number, b: number, alpha: number|null, authoredText?: string) {
     this.#rawParams = [l, a, b];
     this.l = clamp(l, {min: 0, max: 1});
     if (equals(this.l, 0) || equals(this.l, 1)) {
@@ -1212,7 +1212,7 @@ export class Oklch implements Color {
     return params;
   }
 
-  constructor(l: number, c: number, h: number, alpha: number|null, authoredText?: string|undefined) {
+  constructor(l: number, c: number, h: number, alpha: number|null, authoredText?: string) {
     this.#rawParams = [l, c, h];
     this.l = clamp(l, {min: 0, max: 1});
     c = equals(this.l, 0) || equals(this.l, 1) ? 0 : c;
@@ -1379,8 +1379,7 @@ export class ColorFunction implements Color {
     return params;
   }
 
-  constructor(
-      colorSpace: ColorSpace, p0: number, p1: number, p2: number, alpha: number|null, authoredText?: string|undefined) {
+  constructor(colorSpace: ColorSpace, p0: number, p1: number, p2: number, alpha: number|null, authoredText?: string) {
     this.#rawParams = [p0, p1, p2];
     this.colorSpace = colorSpace;
     this.#authoredText = authoredText;
@@ -1534,7 +1533,7 @@ export class HSL implements Color {
   readonly l: number;
   readonly alpha: number|null;
   readonly #rawParams: Color3D;
-  #authoredText: string|undefined;
+  #authoredText?: string;
   readonly channels: [ColorChannel, ColorChannel, ColorChannel, ColorChannel] =
       [ColorChannel.H, ColorChannel.S, ColorChannel.L, ColorChannel.ALPHA];
 
@@ -1588,7 +1587,7 @@ export class HSL implements Color {
     return ColorConverter.srgbToXyzd50(rgb[0], rgb[1], rgb[2]);
   }
 
-  constructor(h: number, s: number, l: number, alpha: number|null|undefined, authoredText?: string) {
+  constructor(h: number, s: number, l: number, alpha?: number|null, authoredText?: string) {
     this.#rawParams = [h, s, l];
     this.l = clamp(l, {min: 0, max: 1});
     s = equals(this.l, 0) || equals(this.l, 1) ? 0 : s;
@@ -1603,7 +1602,7 @@ export class HSL implements Color {
     const hsl = color.as(Format.HSL);
     return equals(this.h, hsl.h) && equals(this.s, hsl.s) && equals(this.l, hsl.l) && equals(this.alpha, hsl.alpha);
   }
-  asString(format?: Format|undefined): string {
+  asString(format?: Format): string {
     if (format) {
       return this.as(format).asString();
     }
@@ -1688,7 +1687,7 @@ export class HWB implements Color {
   readonly b: number;
   readonly alpha: number|null;
   readonly #rawParams: Color3D;
-  #authoredText: string|undefined;
+  #authoredText?: string;
   readonly channels: [ColorChannel, ColorChannel, ColorChannel, ColorChannel] =
       [ColorChannel.H, ColorChannel.W, ColorChannel.B, ColorChannel.ALPHA];
 
@@ -1760,7 +1759,7 @@ export class HWB implements Color {
     const hwb = color.as(Format.HWB);
     return equals(this.h, hwb.h) && equals(this.w, hwb.w) && equals(this.b, hwb.b) && equals(this.alpha, hwb.alpha);
   }
-  asString(format?: Format|undefined): string {
+  asString(format?: Format): string {
     if (format) {
       return this.as(format).asString();
     }
@@ -1886,7 +1885,7 @@ abstract class ShortFormatColorBase implements Color {
   isGamutClipped(): boolean {
     return this.color.isGamutClipped();
   }
-  asString(format?: Format|undefined): string {
+  asString(format?: Format): string {
     if (format) {
       return this.as(format).asString();
     }
@@ -1909,7 +1908,7 @@ export class ShortHex extends ShortFormatColorBase {
     return new ShortHex(this.color.setAlpha(alpha));
   }
 
-  override asString(format?: Format|undefined): string {
+  override asString(format?: Format): string {
     return format && format !== this.format() ? super.as(format).asString() : super.asString();
   }
 
@@ -1949,7 +1948,7 @@ export class Nickname extends ShortFormatColorBase {
     return this.nickname;
   }
 
-  override getAsRawString(format?: Format|undefined): string {
+  override getAsRawString(format?: Format): string {
     return this.color.getAsRawString(format);
   }
 }
@@ -2065,7 +2064,7 @@ export class Legacy implements Color {
     return isShort ? new ShortHex(color) : color;
   }
 
-  static fromRGBAFunction(r: string, g: string, b: string, alpha: string|undefined, text: string): Legacy|null {
+  static fromRGBAFunction(r: string, g: string, b: string, alpha: string, text: string): Legacy|null {
     const rgba = [
       parseRgbNumeric(r),
       parseRgbNumeric(g),
@@ -2183,15 +2182,15 @@ export class Legacy implements Color {
     r: number,
     g: number,
     b: number,
-    a: (number|undefined),
+    a?: number,
   } {
     const rgba = this.canonicalRGBA();
     const result: {
       r: number,
       g: number,
       b: number,
-      a: number|undefined,
-    } = {r: rgba[0], g: rgba[1], b: rgba[2], a: undefined};
+      a?: number,
+    } = {r: rgba[0], g: rgba[1], b: rgba[2]};
     if (rgba[3] !== 1) {
       result.a = rgba[3];
     }
@@ -2453,7 +2452,7 @@ export const IsolationModeHighlight = {
 type Space = number|{
   min: number,
   max: number,
-  count: (number|undefined),
+  count?: number,
 };
 
 export class Generator {
@@ -2463,7 +2462,7 @@ export class Generator {
   readonly #alphaSpace: Space;
   readonly #colors = new Map<string, string>();
   constructor(hueSpace?: Space, satSpace?: Space, lightnessSpace?: Space, alphaSpace?: Space) {
-    this.#hueSpace = hueSpace || {min: 0, max: 360, count: undefined};
+    this.#hueSpace = hueSpace || {min: 0, max: 360};
     this.#satSpace = satSpace || 67;
     this.#lightnessSpace = lightnessSpace || 80;
     this.#alphaSpace = alphaSpace || 1;

package/front_end/core/common/ParsedURL.ts

@@ -392,8 +392,8 @@ export class ParsedURL {
 
   static splitLineAndColumn(string: string): {
     url: Platform.DevToolsPath.UrlString,
-    lineNumber: (number|undefined),
-    columnNumber: (number|undefined),
+    lineNumber?: number,
+    columnNumber?: number,
   } {
     // Only look for line and column numbers in the path to avoid matching port numbers.
     const beforePathMatch = string.match(ParsedURL.urlRegex());
@@ -504,7 +504,7 @@ export class ParsedURL {
     return this.scheme === 'data';
   }
 
-  extractDataUrlMimeType(): {type: string|undefined, subtype: string|undefined} {
+  extractDataUrlMimeType(): {type?: string, subtype?: string|undefined} {
     const regexp = /^data:((?<type>\w+)\/(?<subtype>\w+))?(;base64)?,/;
     const match = this.url.match(regexp);
     return {

package/front_end/core/common/Progress.ts

@@ -5,7 +5,7 @@
 export interface Progress {
   totalWork: number;
   worked: number;
-  title: string|undefined;
+  title?: string;
   canceled: boolean;
   done: boolean;
 }
@@ -13,7 +13,7 @@ export interface Progress {
 export class Progress implements Progress {
   totalWork = 0;
   worked = 0;
-  title: string|undefined = undefined;
+  title?: string;
   canceled = false;
   done = false;
 }
@@ -112,9 +112,9 @@ export class SubProgress implements Progress {
 }
 
 export class ProgressProxy implements Progress {
-  readonly #delegate: Progress|null|undefined;
-  readonly #doneCallback: (() => void)|undefined;
-  readonly #updateCallback: (() => void)|undefined;
+  readonly #delegate?: Progress|null;
+  readonly #doneCallback?: (() => void);
+  readonly #updateCallback?: (() => void);
 
   constructor(delegate?: Progress|null, doneCallback?: (() => void), updateCallback?: (() => void)) {
     this.#delegate = delegate;

package/front_end/core/common/Settings.ts

@@ -401,7 +401,7 @@ export class Setting<V> {
     return '' as Platform.UIString.LocalizedString;
   }
 
-  setTitleFunction(titleFunction: (() => Platform.UIString.LocalizedString)|undefined): void {
+  setTitleFunction(titleFunction?: (() => Platform.UIString.LocalizedString)): void {
     if (titleFunction) {
       this.#titleFunction = titleFunction;
     }
@@ -625,7 +625,7 @@ export class Setting<V> {
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export class RegExpSetting extends Setting<any> {
-  #regexFlags: string|undefined;
+  #regexFlags?: string;
   #regex?: RegExp|null;
 
   constructor(

package/front_end/core/dom_extension/DOMExtension.ts

@@ -52,7 +52,7 @@ Node.prototype.traverseNextTextNode = function(stayWithin?: Node): Node|null {
   return node;
 };
 
-Element.prototype.positionAt = function(x: number|undefined, y: number|undefined, relativeTo?: Element): void {
+Element.prototype.positionAt = function(x?: number, y?: number, relativeTo?: Element): void {
   let shift: AnchorBox|{
     x: number,
     y: number,

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -353,7 +353,7 @@ export interface InspectorFrontendHostAPI {
   /**
    * If you need to alert to the user after copying use {@link UIUtils.copyTextToClipboard}.
    */
-  copyText(text: string|null|undefined): void;
+  copyText(text?: string|null): void;
 
   inspectedURLChanged(url: Platform.DevToolsPath.UrlString): void;
 

package/front_end/core/host/InspectorFrontendHostStub.ts

@@ -153,7 +153,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
     document.title = i18nString(UIStrings.devtoolsS, {PH1: url.replace(/^https?:\/\//, '')});
   }
 
-  copyText(text: string|null|undefined): void {
+  copyText(text?: string|null): void {
     if (text === undefined || text === null) {
       return;
     }
@@ -333,21 +333,11 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
           resourceLoaderStreamWrite(streamId, text);
           callback({
             statusCode: 200,
-            headers: undefined,
-            messageOverride: undefined,
-            netError: undefined,
-            netErrorName: undefined,
-            urlValid: undefined,
           });
         })
         .catch(function() {
           callback({
             statusCode: 404,
-            headers: undefined,
-            messageOverride: undefined,
-            netError: undefined,
-            netErrorName: undefined,
-            urlValid: undefined,
           });
         });
   }

package/front_end/core/host/UserMetrics.ts

@@ -101,7 +101,7 @@ export class UserMetrics {
         EnumeratedHistogram.IssuesPanelOpenedFrom, issueOpener, IssueOpener.MAX_VALUE);
   }
 
-  issuesPanelIssueExpanded(issueExpandedCategory: string|undefined): void {
+  issuesPanelIssueExpanded(issueExpandedCategory?: string): void {
     if (issueExpandedCategory === undefined) {
       return;
     }

package/front_end/core/protocol_client/DevToolsCDPConnection.ts

@@ -20,7 +20,7 @@ interface CallbackWithDebugInfo {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   resolve: (response: {result: CommandResult<any>}|{error: CDPError}) => void;
   method: string;
-  sessionId: string|undefined;
+  sessionId?: string;
 }
 
 type Callback = (error: MessageError|null, arg1: Object|null) => void;
@@ -56,7 +56,7 @@ export class DevToolsCDPConnection implements CDPConnection {
     this.#observers.delete(observer);
   }
 
-  send<T extends Command>(method: T, params: CommandParams<T>, sessionId: string|undefined):
+  send<T extends Command>(method: T, params: CommandParams<T>, sessionId?: string):
       Promise<{result: CommandResult<T>}|{error: CDPError}> {
     const messageId = ++this.#lastMessageId;
     const messageObject: Partial<CDPCommandRequest<T>> = {

package/front_end/core/sdk/CSSMatchedStyles.ts

@@ -225,7 +225,7 @@ export interface CSSType {
 export class CSSRegisteredProperty {
   #registration: Protocol.CSS.CSSPropertyRegistration|CSSPropertyRule;
   #cssModel: CSSModel;
-  #style: CSSStyleDeclaration|undefined;
+  #style?: CSSStyleDeclaration;
   constructor(cssModel: CSSModel, registration: CSSPropertyRule|Protocol.CSS.CSSPropertyRegistration) {
     this.#cssModel = cssModel;
     this.#registration = registration;

package/front_end/core/sdk/CSSProperty.ts

@@ -378,4 +378,42 @@ export class CSSProperty extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
   getLonghandProperties(): CSSProperty[] {
     return this.#longhandProperties;
   }
+
+  ignoreErrors(): boolean {
+    function hasUnknownVendorPrefix(string: string): boolean {
+      return !string.startsWith('-webkit-') && /^[-_][\w\d]+-\w/.test(string);
+    }
+
+    const name = this.name.toLowerCase();
+
+    // IE hack.
+    if (name.charAt(0) === '_') {
+      return true;
+    }
+
+    // IE has a different format for this.
+    if (name === 'filter') {
+      return true;
+    }
+
+    // Common IE-specific property prefix.
+    if (name.startsWith('scrollbar-')) {
+      return true;
+    }
+    if (hasUnknownVendorPrefix(name)) {
+      return true;
+    }
+
+    const value = this.value.toLowerCase();
+
+    // IE hack.
+    if (value.endsWith('\\9')) {
+      return true;
+    }
+    if (hasUnknownVendorPrefix(value)) {
+      return true;
+    }
+
+    return false;
+  }
 }

package/front_end/core/sdk/CSSRule.ts

@@ -31,8 +31,8 @@ export class CSSRule {
   constructor(cssModel: CSSModel, payload: {
     style: Protocol.CSS.CSSStyle,
     origin: Protocol.CSS.StyleSheetOrigin,
-    originTreeScopeNodeId: Protocol.DOM.BackendNodeId|undefined,
     header: CSSStyleSheetHeader|null,
+    originTreeScopeNodeId?: Protocol.DOM.BackendNodeId,
   }) {
     this.header = payload.header;
     this.cssModelInternal = cssModel;
@@ -137,10 +137,10 @@ export class CSSStyleRule extends CSSRule {
   }
 
   static createDummyRule(cssModel: CSSModel, selectorText: string): CSSStyleRule {
-    const dummyPayload = {
+    const dummyPayload: Protocol.CSS.CSSRule = {
       selectorList: {
         text: '',
-        selectors: [{text: selectorText, value: undefined}],
+        selectors: [{text: selectorText}],
       },
       style: {
         styleSheetId: '0' as Protocol.DOM.StyleSheetId,
@@ -150,7 +150,7 @@ export class CSSStyleRule extends CSSRule {
       },
       origin: Protocol.CSS.StyleSheetOrigin.Inspector,
     };
-    return new CSSStyleRule(cssModel, (dummyPayload as Protocol.CSS.CSSRule));
+    return new CSSStyleRule(cssModel, dummyPayload);
   }
 
   private reinitializeSelectors(selectorList: Protocol.CSS.SelectorList): void {
@@ -236,7 +236,6 @@ export class CSSPropertyRule extends CSSRule {
       origin: payload.origin,
       style: payload.style,
       header: styleSheetHeaderForRule(cssModel, payload),
-      originTreeScopeNodeId: undefined,
     });
     this.#name = new CSSValue(payload.propertyName);
   }
@@ -277,7 +276,6 @@ export class CSSAtRule extends CSSRule {
       origin: payload.origin,
       style: payload.style,
       header: styleSheetHeaderForRule(cssModel, payload),
-      originTreeScopeNodeId: undefined
     });
     this.#name = payload.name ? new CSSValue(payload.name) : null;
     this.#type = payload.type;
@@ -323,7 +321,6 @@ export class CSSKeyframeRule extends CSSRule {
       origin: payload.origin,
       style: payload.style,
       header: styleSheetHeaderForRule(cssModel, payload),
-      originTreeScopeNodeId: undefined
     });
     this.reinitializeKey(payload.keyText);
     this.#parentRuleName = parentRuleName;
@@ -379,7 +376,6 @@ export class CSSPositionTryRule extends CSSRule {
       origin: payload.origin,
       style: payload.style,
       header: styleSheetHeaderForRule(cssModel, payload),
-      originTreeScopeNodeId: undefined
     });
     this.#name = new CSSValue(payload.name);
     this.#active = payload.active;
@@ -413,7 +409,6 @@ export class CSSFunctionRule extends CSSRule {
       origin: payload.origin,
       style: {cssProperties: [], shorthandEntries: []},
       header: styleSheetHeaderForRule(cssModel, payload),
-      originTreeScopeNodeId: undefined
     });
     this.#name = new CSSValue(payload.name);
     this.#parameters = payload.parameters.map(({name}) => name);

package/front_end/core/sdk/ChildTargetManager.ts

@@ -82,7 +82,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
 
   override dispose(): void {
     for (const sessionId of this.#childTargetsBySessionId.keys()) {
-      this.detachedFromTarget({sessionId, targetId: undefined});
+      this.detachedFromTarget({sessionId});
     }
   }
 

package/front_end/core/sdk/CookieModel.ts

@@ -144,7 +144,6 @@ export class CookieModel extends SDKModel<EventTypes> {
     this.#cookieToBlockedReasons.clear();
     await Promise.all(cookies.map(cookie => networkAgent.invoke_deleteCookies({
       name: cookie.name(),
-      url: undefined,
       domain: cookie.domain(),
       path: cookie.path(),
       partitionKey: cookie.partitionKey(),

package/front_end/core/sdk/DOMModel.ts

@@ -111,6 +111,7 @@ export const ARIA_ATTRIBUTES = new Set<string>([
 export enum DOMNodeEvents {
   TOP_LAYER_INDEX_CHANGED = 'TopLayerIndexChanged',
   SCROLLABLE_FLAG_UPDATED = 'ScrollableFlagUpdated',
+  AD_RELATED_STATE_UPDATED = 'AdRelatedStateUpdated',
   GRID_OVERLAY_STATE_CHANGED = 'GridOverlayStateChanged',
   FLEX_CONTAINER_OVERLAY_STATE_CHANGED = 'FlexContainerOverlayStateChanged',
   SCROLL_SNAP_OVERLAY_STATE_CHANGED = 'ScrollSnapOverlayStateChanged',
@@ -120,6 +121,7 @@ export enum DOMNodeEvents {
 export interface DOMNodeEventTypes {
   [DOMNodeEvents.TOP_LAYER_INDEX_CHANGED]: void;
   [DOMNodeEvents.SCROLLABLE_FLAG_UPDATED]: void;
+  [DOMNodeEvents.AD_RELATED_STATE_UPDATED]: void;
   [DOMNodeEvents.GRID_OVERLAY_STATE_CHANGED]: {enabled: boolean};
   [DOMNodeEvents.FLEX_CONTAINER_OVERLAY_STATE_CHANGED]: {enabled: boolean};
   [DOMNodeEvents.SCROLL_SNAP_OVERLAY_STATE_CHANGED]: {enabled: boolean};
@@ -185,6 +187,10 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
    * for non-backdrop nodes.
    */
   #topLayerIndex = -1;
+  /**
+   * Set if a DOMNode is ad related.
+   */
+  #isAdRelatedInternal = false;
 
   constructor(domModel: DOMModel) {
     super();
@@ -285,6 +291,10 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
 
     this.setPseudoElements(payload.pseudoElements);
 
+    if (payload.isAdRelated) {
+      this.#isAdRelatedInternal = true;
+    }
+
     if (this.#nodeType === Node.ELEMENT_NODE) {
       // HTML and BODY from internal iframes should not overwrite top-level ones.
       if (this.ownerDocument && !this.ownerDocument.documentElement && this.#nodeName === 'HTML') {
@@ -321,7 +331,12 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
     return this.#topLayerIndex;
   }
 
-  isAdFrameNode(): boolean {
+  isAdRelatedNode(): boolean {
+    // For iframes, we rely on `AdFrameType` to preserve legacy behavior and
+    // prevent regressions.
+    //
+    // TODO(yaoxia): Deprecate the iframe-specific logic and consolidate
+    // everything to use `#isAdRelatedInternal`.
     if (this.isIframe() && this.#frameOwnerFrameId) {
       const frame = FrameManager.instance().getFrame(this.#frameOwnerFrameId);
       if (!frame) {
@@ -329,7 +344,8 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
       }
       return frame.adFrameType() !== Protocol.Page.AdFrameType.None;
     }
-    return false;
+
+    return this.#isAdRelatedInternal;
   }
 
   isRootNode(): boolean {
@@ -409,6 +425,11 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
     }
   }
 
+  setIsAdRelated(isAdRelated: boolean): void {
+    this.#isAdRelatedInternal = isAdRelated;
+    this.dispatchEventToListeners(DOMNodeEvents.AD_RELATED_STATE_UPDATED);
+  }
+
   setAffectedByStartingStyles(affectedByStartingStyles: boolean): void {
     this.#affectedByStartingStyles = affectedByStartingStyles;
   }
@@ -1054,17 +1075,20 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
   }
 
   highlight(mode?: string): void {
-    this.#domModel.overlayModel().highlightInOverlay({node: this, selectorList: undefined}, mode);
+    this.#domModel.overlayModel().highlightInOverlay({node: this}, mode);
   }
 
   highlightForTwoSeconds(): void {
-    this.#domModel.overlayModel().highlightInOverlayForTwoSeconds({node: this, selectorList: undefined});
+    this.#domModel.overlayModel().highlightInOverlayForTwoSeconds({node: this});
   }
 
   async resolveToObject(objectGroup?: string, executionContextId?: Protocol.Runtime.ExecutionContextId):
       Promise<RemoteObject|null> {
-    const {object} = await this.#agent.invoke_resolveNode(
-        {nodeId: this.id, backendNodeId: undefined, executionContextId, objectGroup});
+    const {object} = await this.#agent.invoke_resolveNode({
+      nodeId: this.id,
+      executionContextId,
+      objectGroup,
+    });
     return object && this.#domModel.runtimeModelInternal.createRemoteObject(object) || null;
   }
 
@@ -1691,6 +1715,14 @@ export class DOMModel extends SDKModel<EventTypes> {
     node.setIsScrollable(isScrollable);
   }
 
+  adRelatedStateUpdated(nodeId: Protocol.DOM.NodeId, isAdRelated: boolean): void {
+    const node = this.nodeForId(nodeId);
+    if (!node || node.isAdRelatedNode() === isAdRelated) {
+      return;
+    }
+    node.setIsAdRelated(isAdRelated);
+  }
+
   affectedByStartingStylesFlagUpdated(nodeId: Protocol.DOM.NodeId, affectedByStartingStyles: boolean): void {
     const node = this.nodeForId(nodeId);
     if (!node || node.affectedByStartingStyles() === affectedByStartingStyles) {
@@ -2054,6 +2086,10 @@ class DOMDispatcher implements ProtocolProxyApi.DOMDispatcher {
                                           Protocol.DOM.AffectedByStartingStylesFlagUpdatedEvent): void {
     this.#domModel.affectedByStartingStylesFlagUpdated(nodeId, affectedByStartingStyles);
   }
+
+  adRelatedStateUpdated({nodeId, isAdRelated}: Protocol.DOM.AdRelatedStateUpdatedEvent): void {
+    this.#domModel.adRelatedStateUpdated(nodeId, isAdRelated);
+  }
 }
 
 let domModelUndoStackInstance: DOMModelUndoStack|null = null;

package/front_end/core/sdk/EmulationModel.ts

@@ -558,14 +558,14 @@ export class Location {
 
   static accuracyValidator(value: string): {
     valid: boolean,
-    errorMessage: (string|undefined),
+    errorMessage?: string,
   } {
     if (!value) {
-      return {valid: true, errorMessage: undefined};
+      return {valid: true};
     }
     const numValue = parseFloat(value);
     const valid = /^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && numValue >= 0;
-    return {valid, errorMessage: undefined};
+    return {valid};
   }
 
   toSetting(): string {

package/front_end/core/sdk/NetworkRequest.ts

@@ -2137,7 +2137,7 @@ export interface BlockedCookieWithReason {
 
 export interface IncludedCookieWithReason {
   cookie: Cookie;
-  exemptionReason: Protocol.Network.CookieExemptionReason|undefined;
+  exemptionReason?: Protocol.Network.CookieExemptionReason;
 }
 
 export interface ExemptedSetCookieWithReason {

package/front_end/core/sdk/PageResourceLoader.ts

@@ -278,8 +278,13 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
       throw new Error('Invalid initiator');
     }
     const key = PageResourceLoader.makeKey(url, initiator);
-    const pageResource:
-        PageResource = {success: null, size: null, duration: null, errorMessage: undefined, url, initiator};
+    const pageResource: PageResource = {
+      success: null,
+      size: null,
+      duration: null,
+      url,
+      initiator,
+    };
     this.#pageResources.set(key, pageResource);
     this.dispatchEventToListeners(Events.UPDATE);
     const startTime = performance.now();
@@ -340,8 +345,10 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
             return {
               success: false,
               content: '',
-              errorDescription:
-                  {statusCode: 0, netError: undefined, netErrorName: undefined, message: e.message, urlValid: undefined}
+              errorDescription: {
+                statusCode: 0,
+                message: e.message,
+              }
             };
           }
         }
@@ -399,7 +406,6 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
       netError: number|undefined,
       netErrorName: string|undefined,
       message: string,
-      urlValid: undefined,
     },
   }> {
     const networkManager = (target.model(NetworkManager) as NetworkManager);
@@ -420,7 +426,6 @@ export class PageResourceLoader extends Common.ObjectWrapper.ObjectWrapper<Event
           message: Host.ResourceLoader.netErrorToMessage(
                        resource.netError, resource.httpStatusCode, resource.netErrorName) ||
               '',
-          urlValid: undefined,
         },
       };
     } finally {