chrome-devtools-frontend 1.0.1587905 → 1.0.1589336

package/front_end/panels/network/RequestInitiatorView.ts

@@ -10,13 +10,12 @@ import * as Logs from '../../models/logs/logs.js';
 import type * as StackTrace from '../../models/stack_trace/stack_trace.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
-import * as Lit from '../../ui/lit/lit.js';
+import {html, type LitTemplate, nothing, render, type TemplateResult} from '../../ui/lit/lit.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 import requestInitiatorViewStyles from './requestInitiatorView.css.js';
 import requestInitiatorViewTreeStyles from './requestInitiatorViewTree.css.js';
 
-const {html, render, nothing} = Lit;
 const {widgetConfig} = UI.Widget;
 
 const UIStrings = {
@@ -56,12 +55,12 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
     return;
   }
 
-  const renderStackTraceSection = (): Lit.TemplateResult => {
+  const renderStackTraceSection = (): TemplateResult => {
     if (!input.stackTrace) {
       return html`${nothing}`;
     }
     return html`
-      <li role="treeitem" class="request-initiator-view-section-title" aria-expanded="true">
+      <li role="treeitem" class="request-initiator-view-section-title" aria-expanded="true" open>
         ${i18nString(UIStrings.requestCallStack)}
         <ul role="group">
           <li role="treeitem">
@@ -75,87 +74,93 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
     `;
   };
 
-  const renderInitiatorNodes = (initiators: SDK.NetworkRequest.NetworkRequest[], index: number,
-                                initiated: Map<SDK.NetworkRequest.NetworkRequest, SDK.NetworkRequest.NetworkRequest>,
-                                visited: Set<SDK.NetworkRequest.NetworkRequest>): Lit.TemplateResult => {
-    if (index >= initiators.length) {
-      return html`${nothing}`;
-    }
-    const request = initiators[index];
-    const isCurrentRequest = (index === initiators.length - 1);
-
-    return html`
-      <li role="treeitem" ?selected=${isCurrentRequest} aria-expanded="true">
-        <span style=${isCurrentRequest ? 'font-weight: bold' : ''}>${request.url()}</span>
-        <ul role="group">
-          ${renderInitiatorNodes(initiators, index + 1, initiated, visited)}
-          ${isCurrentRequest ? renderInitiatedNodes(initiated, request, visited) : nothing}
-        </ul>
-      </li>
-    `;
-  };
-
-  const renderInitiatedNodes = (initiated: Map<SDK.NetworkRequest.NetworkRequest, SDK.NetworkRequest.NetworkRequest>,
-                                parentRequest: SDK.NetworkRequest.NetworkRequest,
-                                visited: Set<SDK.NetworkRequest.NetworkRequest>): Lit.TemplateResult => {
-    const children = [];
-    for (const [request, initiator] of initiated) {
-      if (initiator === parentRequest) {
-        children.push(request);
-      }
-    }
-    if (children.length === 0) {
-      return html`${nothing}`;
-    }
-    return html`
+  const renderInitiatorNodes =
+      (initiators: SDK.NetworkRequest.NetworkRequest[], index: number,
+       initiated: Map<SDK.NetworkRequest.NetworkRequest, SDK.NetworkRequest.NetworkRequest>,
+       visited: Set<SDK.NetworkRequest.NetworkRequest>): TemplateResult => {
+        if (index >= initiators.length) {
+          return html`${nothing}`;
+        }
+        const request = initiators[index];
+        const isCurrentRequest = (index === initiators.length - 1);
+        const hasFurtherInitiatedNodes = index + 1 < initiators.length;
+
+        // clang-format off
+        return html`
+          <li role="treeitem" ?selected=${isCurrentRequest} aria-expanded="true" open>
+            <span style=${isCurrentRequest ? 'font-weight: bold' : ''}>${request.url()}</span>
+            ${hasFurtherInitiatedNodes || isCurrentRequest ? html`
+              <ul role="group">
+                ${renderInitiatorNodes(initiators, index + 1, initiated, visited)}
+                ${isCurrentRequest ? renderInitiatedNodes(initiated, request, visited) : nothing}
+              </ul>` : nothing}
+          </li>`;
+        // clang-format on
+      };
+
+  const renderInitiatedNodes =
+      (initiated: Map<SDK.NetworkRequest.NetworkRequest, SDK.NetworkRequest.NetworkRequest>,
+       parentRequest: SDK.NetworkRequest.NetworkRequest,
+       visited: Set<SDK.NetworkRequest.NetworkRequest>): LitTemplate => {
+        const children = [];
+        for (const [request, initiator] of initiated) {
+          if (initiator === parentRequest) {
+            children.push(request);
+          }
+        }
+        if (children.length === 0) {
+          return nothing;
+        }
+        return html`
       ${children.map(child => {
-      const shouldRecurse = !visited.has(child);
-      if (shouldRecurse) {
-        visited.add(child);
-      }
-      return html`
-        <li role="treeitem" aria-expanded="true">
+          const shouldRecurse = !visited.has(child);
+          if (shouldRecurse) {
+            visited.add(child);
+          }
+          const renderedChildren = shouldRecurse ? renderInitiatedNodes(initiated, child, visited) : nothing;
+          return html`
+        <li role="treeitem" aria-expanded="true" open>
           <span>${child.url()}</span>
-          ${shouldRecurse ? html`<ul>${renderInitiatedNodes(initiated, child, visited)}</ul>` : nothing}
+          ${renderedChildren !== nothing ? html`<ul role="group">${renderedChildren}</ul>` : nothing}
         </li>
       `;
-    })}
+        })}
     `;
-  };
+      };
 
-  const renderInitiatorChain = (initiatorGraph: Logs.NetworkLog.InitiatorGraph): Lit.TemplateResult => {
+  const renderInitiatorChain = (initiatorGraph: Logs.NetworkLog.InitiatorGraph): TemplateResult => {
     const initiators = Array.from(initiatorGraph.initiators).reverse();
     const visited = new Set<SDK.NetworkRequest.NetworkRequest>();
     visited.add(input.request);
+    const hasInitiatorChain = initiators.length > 0;
+    // clang-format off
     return html`
-      <li role="treeitem" class="request-initiator-view-section-title" aria-expanded="true">
+      <li role="treeitem" class="request-initiator-view-section-title" aria-expanded="true" open>
         ${i18nString(UIStrings.requestInitiatorChain)}
-        <ul role="group">
-          ${renderInitiatorNodes(initiators, 0, initiatorGraph.initiated, visited)}
-        </ul>
-      </li>
-    `;
+        ${hasInitiatorChain ? html`
+          <ul role="group">
+            ${renderInitiatorNodes(initiators, 0, initiatorGraph.initiated, visited)}
+          </ul>` : nothing}
+      </li>`;
+    // clang-format on
   };
 
-  render(
-      html`
+  const hasInitiatorChain = input.initiatorGraph.initiators.size > 1 || input.initiatorGraph.initiated.size > 1;
+
+  // clang-format off
+  render(html`
     <div class="request-initiator-view-tree" jslog=${VisualLogging.tree('initiator-tree')}>
-      <devtools-tree .template=${
-          html`
-        <style>
-          ${requestInitiatorViewTreeStyles}
-        </style>
-        <ul role="tree">
-           ${renderStackTraceSection()}
-           ${
-              (input.initiatorGraph.initiators.size > 1 || input.initiatorGraph.initiated.size > 1) ?
-                  renderInitiatorChain(input.initiatorGraph) :
-                  Lit.nothing}
-        </ul>
+      <devtools-tree .template=${html`
+        <style>${requestInitiatorViewTreeStyles}</style>
+        ${input.stackTrace || hasInitiatorChain ? html`
+          <ul role="tree">
+            ${renderStackTraceSection()}
+            ${hasInitiatorChain ? renderInitiatorChain(input.initiatorGraph) : nothing}
+          </ul>` : nothing}
       `}></devtools-tree>
     </div>
-  `,
-      target);
+  `, target);
+  // clang-format on
 };
 
 type View = typeof DEFAULT_VIEW;

package/front_end/panels/network/RequestPayloadView.ts

@@ -225,6 +225,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
           @contextmenu=${onContextMenu(input.viewQueryParamSource, input.setViewQueryParamSource)}
           @expanded=${(e: UI.TreeOutline.TreeViewElement.ExpandEvent) =>
             queryStringExpandedSetting.set(e.detail.expanded)}
+          ?open=${queryStringExpandedSetting.get()}
         >
         <div class="selection fill"></div>${i18nString(UIStrings.queryStringParameters)}<span
           class=payload-count>${`\xA0(${input.queryParameters?.length ?? 0})`}</span>${
@@ -237,7 +238,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
             @click=${toggleURLDecoding}>
           ${input.decodeRequestParameters ? i18nString(UIStrings.viewUrlEncoded) : i18nString(UIStrings.viewDecoded)}
         </devtools-button>
-        <ul role=group ?hidden=${!queryStringExpandedSetting.get()}>
+        <ul role=group>
           ${input.viewQueryParamSource ? createSourceText(input.queryString ?? '')
                                        : createParsedParams(input.queryParameters ?? [])}
         </ul>
@@ -248,6 +249,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
           jslog=${VisualLogging.section().context('form-data')}
           @contextmenu=${onContextMenu(input.viewFormParamSource, input.setViewFormParamSource)}
           @expanded=${(e: UI.TreeOutline.TreeViewElement.ExpandEvent) => formDataExpandedSetting.set(e.detail.expanded)}
+          ?open=${formDataExpandedSetting.get()}
         >
         <div class="selection fill"></div>${i18nString(UIStrings.formData)}<span
           class=payload-count>${`\xA0(${input.formParameters?.length ?? 0})`}</span>${
@@ -260,7 +262,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
             @click=${toggleURLDecoding}>
           ${input.decodeRequestParameters ? i18nString(UIStrings.viewUrlEncoded) : i18nString(UIStrings.viewDecoded)}
         </devtools-button>
-        <ul role=group ?hidden=${!formDataExpandedSetting.get()}>>
+        <ul role=group>
           ${input.viewFormParamSource ? createSourceText(input.formData ?? '')
                                       : createParsedParams(input.formParameters ?? [])}
         </ul>
@@ -273,10 +275,11 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
                                        /* includeURLDecodingOption*/ false)}
           @expanded=${(e: UI.TreeOutline.TreeViewElement.ExpandEvent) =>
             requestPayloadExpandedSetting.set(e.detail.expanded)}
+          ?open=${requestPayloadExpandedSetting.get()}
         >
         <div class="selection fill"></div>${i18nString(UIStrings.requestPayload)}${
             createViewSourceToggle(input.viewJSONPayloadSource, input.setViewJSONPayloadSource)}
-        <ul role=group ?hidden=${!requestPayloadExpandedSetting.get()}>
+        <ul role=group>
           ${!parsedFormData || input.viewJSONPayloadSource ? createSourceText(input.formData ?? '')
                                                            : createPayload(parsedFormData)}
         </ul>

package/front_end/panels/network/ResourceChunkView.ts

@@ -113,8 +113,6 @@ export abstract class ResourceChunkView<Chunk> extends UI.Widget.VBox {
     this.dataGrid = new DataGrid.SortableDataGrid.SortableDataGrid({
       displayName: dataGridDisplayName,
       columns,
-      deleteCallback: undefined,
-      refreshCallback: undefined,
     });
     this.dataGrid.setRowContextMenuCallback(onRowContextMenu.bind(this));
     this.dataGrid.setEnableAutoScrollToBottom(true);

package/front_end/panels/network/components/ResponseHeaderSection.ts

@@ -592,7 +592,9 @@ const BlockedReasonDetails = new Map<Protocol.Network.BlockedReason, HeaderDetai
       value: null,
       blockedDetails: {
         explanation: i18nLazyString(UIStrings.toEmbedThisFrameInYourDocument),
-        examples: [{codeSnippet: 'Cross-Origin-Embedder-Policy: require-corp', comment: undefined}],
+        examples: [{
+          codeSnippet: 'Cross-Origin-Embedder-Policy: require-corp',
+        }],
         link: {url: 'https://web.dev/coop-coep/'},
       },
     },

package/front_end/panels/network/network-meta.ts

@@ -450,7 +450,6 @@ UI.ContextMenu.registerProvider({
     const Network = await loadNetworkModule();
     return Network.NetworkPanel.NetworkPanel.instance();
   },
-  experiment: undefined,
 });
 
 Common.Revealer.registerRevealer({
@@ -470,7 +469,6 @@ Common.Revealer.registerRevealer({
   contextTypes() {
     return [NetworkForward.UIRequestLocation.UIRequestLocation];
   },
-  destination: undefined,
   async loadRevealer() {
     const Network = await loadNetworkModule();
     return new Network.NetworkPanel.RequestLocationRevealer();

package/front_end/panels/performance_monitor/PerformanceMonitor.ts

@@ -506,14 +506,7 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
     const themeSupport = ThemeSupport.ThemeSupport.instance();
     const elementForStyles = this.contentElement;
 
-    const defaults = {
-      color: undefined,
-      format: undefined,
-      currentMax: undefined,
-      max: undefined,
-      smooth: undefined,
-      stacked: undefined,
-    };
+    const defaults: Partial<ChartInfo> = {};
 
     return [
       {
@@ -543,7 +536,6 @@ export class PerformanceMonitorImpl extends UI.Widget.HBox implements
         stacked: true,
         color: themeSupport.getComputedValue('--override-color-perf-monitor-cpu', elementForStyles),
         max: 1,
-        currentMax: undefined,
       },
       {
         ...defaults,

package/front_end/panels/profiler/HeapDetachedElementsDataGrid.ts

@@ -45,8 +45,6 @@ export class HeapDetachedElementsDataGrid extends DataGrid.DataGrid.DataGridImpl
     super({
       displayName: i18nString(UIStrings.detachedElementsList),
       columns,
-      deleteCallback: undefined,
-      refreshCallback: undefined,
     });
 
     this.setStriped(true);

package/front_end/panels/profiler/LiveHeapProfileView.ts

@@ -106,20 +106,10 @@ export class LiveHeapProfileView extends UI.Widget.VBox {
     const defaultColumnConfig: DataGrid.DataGrid.ColumnDescriptor = {
       id: '',
       title: Common.UIString.LocalizedEmptyString,
-      width: undefined,
       fixedWidth: true,
       sortable: true,
       align: DataGrid.DataGrid.Align.RIGHT,
       sort: DataGrid.DataGrid.Order.Descending,
-      titleDOMFragment: undefined,
-      editable: undefined,
-      nonSelectable: undefined,
-      longText: undefined,
-      disclosure: undefined,
-      weight: undefined,
-      allowInSortByEvenWhenHidden: undefined,
-      dataType: undefined,
-      defaultWeight: undefined,
     };
     const columns = [
       {
@@ -154,8 +144,6 @@ export class LiveHeapProfileView extends UI.Widget.VBox {
     const dataGrid = new DataGrid.SortableDataGrid.SortableDataGrid({
       displayName: i18nString(UIStrings.heapProfile),
       columns,
-      deleteCallback: undefined,
-      refreshCallback: undefined,
     });
     dataGrid.setResizeMethod(DataGrid.DataGrid.ResizeMethod.LAST);
     dataGrid.element.classList.add('flex-auto');

package/front_end/panels/profiler/ProfileFlameChartDataProvider.ts

@@ -32,7 +32,20 @@ export class ProfileFlameChartDataProvider implements PerfUI.FlameChart.FlameCha
   static colorGenerator(): Common.Color.Generator {
     if (!colorGeneratorInstance) {
       colorGeneratorInstance = new Common.Color.Generator(
-          {min: 30, max: 330, count: undefined}, {min: 50, max: 80, count: 5}, {min: 80, max: 90, count: 3});
+          {
+            min: 30,
+            max: 330,
+          },
+          {
+            min: 50,
+            max: 80,
+            count: 5,
+          },
+          {
+            min: 80,
+            max: 90,
+            count: 3,
+          });
 
       colorGeneratorInstance.setColorForID('(idle)', 'hsl(0, 0%, 94%)');
       colorGeneratorInstance.setColorForID('(program)', 'hsl(0, 0%, 80%)');

package/front_end/panels/profiler/ProfileView.ts

@@ -146,16 +146,6 @@ export class ProfileView extends UI.View.SimpleView implements UI.SearchableView
       fixedWidth: true,
       sortable: true,
       sort: DataGrid.DataGrid.Order.Descending,
-      titleDOMFragment: undefined,
-      align: undefined,
-      editable: undefined,
-      nonSelectable: undefined,
-      longText: undefined,
-      disclosure: undefined,
-      weight: undefined,
-      allowInSortByEvenWhenHidden: undefined,
-      dataType: undefined,
-      defaultWeight: undefined,
     });
     columns.push({
       id: 'total',
@@ -163,42 +153,17 @@ export class ProfileView extends UI.View.SimpleView implements UI.SearchableView
       width: '120px',
       fixedWidth: true,
       sortable: true,
-      sort: undefined,
-      titleDOMFragment: undefined,
-      align: undefined,
-      editable: undefined,
-      nonSelectable: undefined,
-      longText: undefined,
-      disclosure: undefined,
-      weight: undefined,
-      allowInSortByEvenWhenHidden: undefined,
-      dataType: undefined,
-      defaultWeight: undefined,
     });
     columns.push({
       id: 'function',
       title: i18nString(UIStrings.function),
       disclosure: true,
       sortable: true,
-      sort: undefined,
-      titleDOMFragment: undefined,
-      align: undefined,
-      editable: undefined,
-      nonSelectable: undefined,
-      longText: undefined,
-      weight: undefined,
-      allowInSortByEvenWhenHidden: undefined,
-      dataType: undefined,
-      defaultWeight: undefined,
-      width: undefined,
-      fixedWidth: undefined,
     });
 
     this.dataGrid = new DataGrid.DataGrid.DataGridImpl({
       displayName: i18nString(UIStrings.profiler),
       columns,
-      deleteCallback: undefined,
-      refreshCallback: undefined,
     });
     this.dataGrid.addEventListener(DataGrid.DataGrid.Events.SORTING_CHANGED, this.sortProfile, this);
     this.dataGrid.addEventListener(DataGrid.DataGrid.Events.SELECTED_NODE, this.nodeSelected.bind(this, true));

package/front_end/panels/profiler/profiler-meta.ts

@@ -253,7 +253,6 @@ UI.ContextMenu.registerProvider({
     const Profiler = await loadProfilerModule();
     return Profiler.HeapProfilerPanel.HeapProfilerPanel.instance();
   },
-  experiment: undefined,
 });
 
 UI.ContextMenu.registerItem({

package/front_end/panels/recorder/components/StepView.ts

@@ -519,7 +519,6 @@ export class StepView extends UI.Widget.Widget {
     builtInConverters: [],
     extensionConverters: [],
     isSelected: false,
-    recorderSettings: undefined,
     actions: [],
 
     stepEdited: this.#stepEdited.bind(this),

package/front_end/panels/screencast/ScreencastView.ts

@@ -244,7 +244,7 @@ export class ScreencastView extends UI.Widget.VBox implements SDK.OverlayModel.H
       this.viewportElement.style.width = metadata.deviceWidth * this.screenZoom + bordersSize + 'px';
       this.viewportElement.style.height = metadata.deviceHeight * this.screenZoom + bordersSize + 'px';
 
-      const data = this.highlightNode ? {node: this.highlightNode, selectorList: undefined} : {clear: true};
+      const data = this.highlightNode ? {node: this.highlightNode} : {clear: true};
       void this.updateHighlightInOverlayAndRepaint(data, this.highlightConfig);
     };
     this.imageElement.src = 'data:image/jpg;base64,' + base64Data;
@@ -309,7 +309,7 @@ export class ScreencastView extends UI.Widget.VBox implements SDK.OverlayModel.H
     }
 
     if (event.type === 'mousemove') {
-      void this.updateHighlightInOverlayAndRepaint({node, selectorList: undefined}, this.inspectModeConfig);
+      void this.updateHighlightInOverlayAndRepaint({node}, this.inspectModeConfig);
       this.domModel.overlayModel().nodeHighlightRequested({nodeId: node.id});
     } else if (event.type === 'click') {
       this.domModel.overlayModel().inspectNodeRequested({backendNodeId: node.backendNodeId()});

package/front_end/panels/search/SearchResultsPane.ts

@@ -69,10 +69,11 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
         ${results.map(searchResult => html`
           <li @expand=${(e: UI.TreeOutline.TreeViewElement.ExpandEvent) => onExpand(searchResult, e)}
               role="treeitem"
-              class="search-result">
+              class="search-result"
+              ?open=${expandedResults.has(searchResult)}>
             <style>${searchResultsPaneStyles}</style>
             ${renderSearchResult(searchResult)}
-            <ul role="group" ?hidden=${!expandedResults.has(searchResult)}>
+            <ul role="group">
               ${renderSearchMatches(searchResult, matches, onSelectMatch, onShowMoreMatches)}
             </ul>
           </li>`)}

package/front_end/panels/security/SecurityPanel.ts

@@ -733,7 +733,6 @@ export class SecurityPanel extends UI.Panel.Panel implements SDK.TargetManager.S
         securityState,
         securityDetails: request.securityDetails(),
         loadedFromCache: request.cached(),
-        originView: undefined,
       };
       this.origins.set(origin, newOriginState);
 

package/front_end/panels/sensors/LocationsSettingsTab.ts

@@ -339,7 +339,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       if (errorMessage) {
         return {valid: false, errorMessage};
       }
-      return {valid: true, errorMessage: undefined};
+      return {
+        valid: true,
+      };
     }
 
     function latValidator(
@@ -350,7 +352,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       const parsedValue = Number(value);
 
       if (!value) {
-        return {valid: true, errorMessage: undefined};
+        return {
+          valid: true,
+        };
       }
 
       let errorMessage;
@@ -365,7 +369,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       if (errorMessage) {
         return {valid: false, errorMessage};
       }
-      return {valid: true, errorMessage: undefined};
+      return {
+        valid: true,
+      };
     }
 
     function longValidator(
@@ -376,7 +382,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       const parsedValue = Number(value);
 
       if (!value) {
-        return {valid: true, errorMessage: undefined};
+        return {
+          valid: true,
+        };
       }
 
       let errorMessage;
@@ -391,7 +399,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       if (errorMessage) {
         return {valid: false, errorMessage};
       }
-      return {valid: true, errorMessage: undefined};
+      return {
+        valid: true,
+      };
     }
 
     function timezoneIdValidator(
@@ -405,7 +415,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       // alphabetic character. The empty string resets the override,
       // and is accepted as well.
       if (value === '' || /[a-zA-Z]/.test(value)) {
-        return {valid: true, errorMessage: undefined};
+        return {
+          valid: true,
+        };
       }
       const errorMessage = i18nString(UIStrings.timezoneIdMustContainAlphabetic);
       return {valid: false, errorMessage};
@@ -421,7 +433,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       // The empty string resets the override, and is accepted as
       // well.
       if (value === '' || /[a-zA-Z]{2}/.test(value)) {
-        return {valid: true, errorMessage: undefined};
+        return {
+          valid: true,
+        };
       }
       const errorMessage = i18nString(UIStrings.localeMustContainAlphabetic);
       return {valid: false, errorMessage};
@@ -434,7 +448,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       const parsedValue = Number(value);
 
       if (!value) {
-        return {valid: true, errorMessage: undefined};
+        return {
+          valid: true,
+        };
       }
 
       let errorMessage;
@@ -447,7 +463,9 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
       if (errorMessage) {
         return {valid: false, errorMessage};
       }
-      return {valid: true, errorMessage: undefined};
+      return {
+        valid: true,
+      };
     }
   }
 }

package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts

@@ -316,7 +316,7 @@ export class FrameworkIgnoreListSettingsTab extends UI.Widget.VBox implements
       if (!regex) {
         return {valid: false, errorMessage: i18nString(UIStrings.patternMustBeAValidRegular)};
       }
-      return {valid: true, errorMessage: undefined};
+      return {valid: true};
     }
   }
 }

package/front_end/panels/settings/SettingsScreen.ts

@@ -166,8 +166,7 @@ export class SettingsScreen extends UI.Widget.VBox implements UI.View.ViewLocati
     return settingsScreen;
   }
 
-  static async showSettingsScreen(
-      options: ShowSettingsScreenOptions|undefined = {name: undefined, focusTabHeader: undefined}): Promise<void> {
+  static async showSettingsScreen(options: ShowSettingsScreenOptions = {}): Promise<void> {
     const {name, focusTabHeader} = options;
     const settingsScreen = SettingsScreen.revealSettingsScreen();
 

package/front_end/panels/settings/emulation/DevicesSettingsTab.ts

@@ -311,7 +311,7 @@ export class DevicesSettingsTab extends UI.Widget.VBox implements
 
     const ua = uaStringFields.createChild('div', 'hbox');
     ua.appendChild(editor.createInput('user-agent', 'text', i18nString(UIStrings.userAgentString), () => {
-      return {valid: true, errorMessage: undefined};
+      return {valid: true};
     }));
     const uaTypeOptions = [
       EmulationModel.DeviceModeModel.UA.MOBILE,
@@ -320,7 +320,7 @@ export class DevicesSettingsTab extends UI.Widget.VBox implements
       EmulationModel.DeviceModeModel.UA.DESKTOP_TOUCH,
     ];
     const uaType = editor.createSelect('ua-type', uaTypeOptions, () => {
-      return {valid: true, errorMessage: undefined};
+      return {valid: true};
     }, i18nString(UIStrings.userAgentType));
     uaType.classList.add('device-edit-fixed');
     ua.appendChild(uaType);

package/front_end/panels/settings/emulation/utils/UserAgentMetadata.ts

@@ -90,5 +90,5 @@ export function validateAsStructuredHeadersString(value: string, errorString: st
   if (parsedResult.kind === ResultKind.ERROR) {
     return {valid: false, errorMessage: errorString};
   }
-  return {valid: true, errorMessage: undefined};
+  return {valid: true};
 }

package/front_end/panels/settings/settings-meta.ts

@@ -280,7 +280,6 @@ Common.Revealer.registerRevealer({
       Root.Runtime.HostExperiment,
     ];
   },
-  destination: undefined,
   async loadRevealer() {
     const Settings = await loadSettingsModule();
     return new Settings.SettingsScreen.Revealer();
@@ -290,11 +289,9 @@ Common.Revealer.registerRevealer({
 UI.ContextMenu.registerItem({
   location: UI.ContextMenu.ItemLocation.MAIN_MENU_FOOTER,
   actionId: 'settings.shortcuts',
-  order: undefined,
 });
 
 UI.ContextMenu.registerItem({
   location: UI.ContextMenu.ItemLocation.MAIN_MENU_HELP_DEFAULT,
   actionId: 'settings.documentation',
-  order: undefined,
 });