chrome-devtools-frontend 1.0.1526203 → 1.0.1528866

package/front_end/models/live-metrics/web-vitals-injected/web-vitals-injected.ts

@@ -5,12 +5,10 @@
 import * as WebVitals from '../../../third_party/web-vitals/web-vitals.js';
 import type * as Trace from '../../trace/trace.js';
 
-import * as OnEachInteraction from './OnEachInteraction.js';
 import * as OnEachLayoutShift from './OnEachLayoutShift.js';
 import * as Spec from './spec/spec.js';
 
 const {onLCP, onCLS, onINP} = WebVitals.Attribution;
-const {onEachInteraction} = OnEachInteraction;
 const {onEachLayoutShift} = OnEachLayoutShift;
 
 declare const window: Window&{
@@ -184,30 +182,7 @@ function initialize(): void {
     sendEventToDevTools(event);
   }, {reportAllChanges: true});
 
-  onINP(metric => {
-    // TODO(b/376777343): Remove this line when `interactionTargetElement` is removed from web-vitals.js
-    // The `metric` emitted in this callback is stored within web-vitals.js closures.
-    // This can lead to `interactionTargetElement` persisting in memory after it has been removed.
-    // We don't use `interactionTargetElement` here, and `onEachInteraction` will interaction
-    // elements separately so it is safe to remove here and prevent memory leaks.
-    metric.attribution.interactionTargetElement = undefined;
-
-    const event: Spec.InpChangeEvent = {
-      name: 'INP',
-      value: metric.value as Trace.Types.Timing.Milli,
-      phases: {
-        inputDelay: metric.attribution.inputDelay as Trace.Types.Timing.Milli,
-        processingDuration: metric.attribution.processingDuration as Trace.Types.Timing.Milli,
-        presentationDelay: metric.attribution.presentationDelay as Trace.Types.Timing.Milli,
-      },
-      startTime: metric.entries[0].startTime,
-      entryGroupId: metric.entries[0].interactionId as Spec.InteractionEntryGroupId,
-      interactionType: metric.attribution.interactionType,
-    };
-    sendEventToDevTools(event);
-  }, {reportAllChanges: true, durationThreshold: 0});
-
-  onEachInteraction(interaction => {
+  function onEachInteraction(interaction: WebVitals.INPMetricWithAttribution): void {
     // Multiple `InteractionEntry` events can be emitted for the same `uniqueInteractionId`
     // However, it is easier to combine these entries in the DevTools client rather than in
     // this injected code.
@@ -228,11 +203,38 @@ function initialize(): void {
       longAnimationFrameEntries: limitScripts(
           interaction.attribution.longAnimationFrameEntries.slice(-Spec.LOAF_LIMIT).map(loaf => loaf.toJSON())),
     };
-    const node = interaction.attribution.interactionTargetElement;
-    if (node) {
-      event.nodeIndex = establishNodeIndex(node);
+    const target = interaction.attribution.interactionTarget;
+    if (target) {
+      event.nodeIndex = Number(target);
     }
     sendEventToDevTools(event);
+  }
+
+  onINP(metric => {
+    const event: Spec.InpChangeEvent = {
+      name: 'INP',
+      value: metric.value as Trace.Types.Timing.Milli,
+      phases: {
+        inputDelay: metric.attribution.inputDelay as Trace.Types.Timing.Milli,
+        processingDuration: metric.attribution.processingDuration as Trace.Types.Timing.Milli,
+        presentationDelay: metric.attribution.presentationDelay as Trace.Types.Timing.Milli,
+      },
+      startTime: metric.entries[0].startTime,
+      entryGroupId: metric.entries[0].interactionId as Spec.InteractionEntryGroupId,
+      interactionType: metric.attribution.interactionType,
+    };
+    sendEventToDevTools(event);
+  }, {
+    reportAllChanges: true,
+    durationThreshold: 0,
+    onEachInteraction,
+    generateTarget(el) {
+      if (el) {
+        return String(establishNodeIndex(el));
+      }
+
+      return undefined;
+    },
   });
 
   onEachLayoutShift(layoutShift => {

package/front_end/models/persistence/EditFileSystemView.ts

@@ -125,6 +125,7 @@ export class EditFileSystemView extends UI.Widget.VBox {
   }
 
   override wasShown(): void {
+    super.wasShown();
     this.#resyncExcludedFolderPaths();
     this.requestUpdate();
   }

package/front_end/models/source_map_scopes/NamesResolver.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
+import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
 import * as Bindings from '../bindings/bindings.js';
@@ -48,16 +49,7 @@ scopeTree:
     return null;
   }
 
-  const text = await getTextFor(script);
-  if (!text) {
-    return null;
-  }
-
-  const scopeTree = await SDK.ScopeTreeCache.scopeTreeForScript(script);
-  if (!scopeTree) {
-    return null;
-  }
-  return {scopeTree, text};
+  return await SDK.ScopeTreeCache.scopeTreeForScript(script);
 };
 
 /**
@@ -379,7 +371,9 @@ export const resolveScopeChain =
     return scopeChain;
   }
 
-  scopeChain = callFrame.script.sourceMap()?.resolveScopeChain(callFrame);
+  scopeChain = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.USE_SOURCE_MAP_SCOPES) ?
+      callFrame.script.sourceMap()?.resolveScopeChain(callFrame) :
+      null;
   if (scopeChain) {
     return scopeChain;
   }

package/front_end/models/stack_trace/Trie.ts

@@ -17,6 +17,15 @@ export interface RawFrame {
   readonly columnNumber: number;
 }
 
+/**
+ * @returns whether the frame is a V8 builtin frame e.g. Array.map. Builtin frames
+ * have neither source position nor script or URL. They only have a name.
+ */
+export function isBuiltinFrame(rawFrame: RawFrame): boolean {
+  return rawFrame.lineNumber === -1 && rawFrame.columnNumber === -1 && !Boolean(rawFrame.scriptId) &&
+      !Boolean(rawFrame.url);
+}
+
 interface FrameNodeBase<ChildT, ParentT> {
   readonly parent: ParentT;
   readonly children: ChildT[];

package/front_end/models/trace/lantern/types/Lantern.ts

@@ -50,7 +50,7 @@ export interface Trace {
 }
 export type ResourcePriority = ('VeryLow'|'Low'|'Medium'|'High'|'VeryHigh');
 export type ResourceType = keyof typeof NetworkRequestTypes;
-type InitiatorType = ('parser'|'script'|'preload'|'SignedExchange'|'preflight'|'other');
+type InitiatorType = ('parser'|'script'|'preload'|'SignedExchange'|'preflight'|'FedCM'|'other');
 export type ResourceTiming = Protocol.Network.ResourceTiming;
 export interface CallStack {
   callFrames: Array<{

package/front_end/panels/accessibility/AXBreadcrumbsPane.ts

@@ -188,6 +188,7 @@ export class AXBreadcrumbsPane extends AccessibilitySubPane {
   }
 
   override willHide(): void {
+    super.willHide();
     this.setPreselectedBreadcrumb(null);
   }
 

package/front_end/panels/accessibility/AccessibilitySidebarView.ts

@@ -122,6 +122,7 @@ export class AccessibilitySidebarView extends UI.ThrottledWidget.ThrottledWidget
   }
 
   override willHide(): void {
+    super.willHide();
     SDK.TargetManager.TargetManager.instance().removeModelListener(
         SDK.DOMModel.DOMModel, SDK.DOMModel.Events.AttrModified, this.onNodeChange, this);
     SDK.TargetManager.TargetManager.instance().removeModelListener(