alvin-bot 4.18.0 → 4.18.2

package/test/memory-sdk-injection.test.ts

@@ -1,146 +0,0 @@
-/**
- * v4.11.0 — SDK system prompts now receive MEMORY.md context.
- *
- * Before v4.11.0, only non-SDK providers (Groq, Gemini, NVIDIA) got
- * buildMemoryContext() injected into their system prompt — the SDK was
- * expected to read memory files via tools. In practice it rarely did,
- * resulting in "frickelig" memory after restart even with persisted
- * sessions. v4.11.0 closes this gap.
- */
-import { describe, it, expect, beforeEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-sdk-mem-inject-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  fs.mkdirSync(resolve(TEST_DATA_DIR, "memory"), { recursive: true });
-  fs.writeFileSync(
-    resolve(TEST_DATA_DIR, "memory", "MEMORY.md"),
-    "# Long-term Memory\n\n- User User prefers terse answers.\n- HOMES uses Postgres `homes_production`.\n",
-  );
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  vi.resetModules();
-});
-
-describe("SDK memory injection (v4.11.0)", () => {
-  it("buildSystemPrompt(isSDK=true) now includes MEMORY.md content", async () => {
-    const { buildSystemPrompt } = await import("../src/services/personality.js");
-    const prompt = buildSystemPrompt(true, "en", "1234");
-    expect(prompt).toMatch(/User User prefers terse answers/);
-    expect(prompt).toMatch(/HOMES uses Postgres/);
-  });
-
-  it("non-SDK still gets memory injection (regression check)", async () => {
-    const { buildSystemPrompt } = await import("../src/services/personality.js");
-    const prompt = buildSystemPrompt(false, "en", "1234");
-    expect(prompt).toMatch(/User User prefers terse answers/);
-  });
-
-  it("no MEMORY.md → SDK prompt builds without crash and without memory section", async () => {
-    fs.unlinkSync(resolve(TEST_DATA_DIR, "memory", "MEMORY.md"));
-    vi.resetModules();
-    const { buildSystemPrompt } = await import("../src/services/personality.js");
-    const prompt = buildSystemPrompt(true, "en", "1234");
-    expect(prompt).toBeTruthy();
-    expect(prompt).not.toMatch(/Your Memory \(auto-loaded\)/);
-  });
-});
-
-describe("SDK smart prompt (semantic recall) on first turn (v4.11.0)", () => {
-  it("buildSmartSystemPrompt for SDK with isFirstTurn=false does NOT call searchMemory", async () => {
-    let searchCalls = 0;
-    vi.doMock("../src/services/embeddings.js", () => ({
-      searchMemory: async () => {
-        searchCalls++;
-        return [];
-      },
-      reindexMemory: async () => ({ indexed: 0, total: 0 }),
-      initEmbeddings: async () => {},
-      getIndexStats: () => ({ entries: 0, files: 0, lastReindex: 0, sizeBytes: 0 }),
-    }));
-    vi.resetModules();
-    const { buildSmartSystemPrompt } = await import("../src/services/personality.js");
-
-    await buildSmartSystemPrompt(true, "en", "tell me about HOMES", "1234", false);
-    expect(searchCalls).toBe(0);
-  });
-
-  it("buildSmartSystemPrompt for SDK with isFirstTurn=true CALLS searchMemory", async () => {
-    let searchCalls = 0;
-    vi.doMock("../src/services/embeddings.js", () => ({
-      searchMemory: async () => {
-        searchCalls++;
-        return [
-          { text: "HOMES uses homes_production database", source: "MEMORY.md", score: 0.9 },
-        ];
-      },
-      reindexMemory: async () => ({ indexed: 0, total: 0 }),
-      initEmbeddings: async () => {},
-      getIndexStats: () => ({ entries: 0, files: 0, lastReindex: 0, sizeBytes: 0 }),
-    }));
-    vi.resetModules();
-    const { buildSmartSystemPrompt } = await import("../src/services/personality.js");
-
-    const prompt = await buildSmartSystemPrompt(true, "en", "tell me about HOMES", "1234", true);
-    expect(searchCalls).toBe(1);
-    expect(prompt).toMatch(/Relevant Memories \(auto-retrieved\)/);
-    expect(prompt).toMatch(/homes_production/);
-  });
-
-  it("non-SDK calls searchMemory regardless of isFirstTurn flag", async () => {
-    let searchCalls = 0;
-    vi.doMock("../src/services/embeddings.js", () => ({
-      searchMemory: async () => {
-        searchCalls++;
-        return [];
-      },
-      reindexMemory: async () => ({ indexed: 0, total: 0 }),
-      initEmbeddings: async () => {},
-      getIndexStats: () => ({ entries: 0, files: 0, lastReindex: 0, sizeBytes: 0 }),
-    }));
-    vi.resetModules();
-    const { buildSmartSystemPrompt } = await import("../src/services/personality.js");
-
-    await buildSmartSystemPrompt(false, "en", "HOMES backup question", "1234", false);
-    expect(searchCalls).toBe(1);
-  });
-
-  it("buildSmartSystemPrompt for SDK with no userMessage skips search even when isFirstTurn=true", async () => {
-    let searchCalls = 0;
-    vi.doMock("../src/services/embeddings.js", () => ({
-      searchMemory: async () => {
-        searchCalls++;
-        return [];
-      },
-      reindexMemory: async () => ({ indexed: 0, total: 0 }),
-      initEmbeddings: async () => {},
-      getIndexStats: () => ({ entries: 0, files: 0, lastReindex: 0, sizeBytes: 0 }),
-    }));
-    vi.resetModules();
-    const { buildSmartSystemPrompt } = await import("../src/services/personality.js");
-
-    await buildSmartSystemPrompt(true, "en", undefined, "1234", true);
-    expect(searchCalls).toBe(0);
-  });
-
-  it("graceful failure: SDK first turn search throws → returns base prompt without crashing", async () => {
-    vi.doMock("../src/services/embeddings.js", () => ({
-      searchMemory: async () => {
-        throw new Error("Embedding API down");
-      },
-      reindexMemory: async () => ({ indexed: 0, total: 0 }),
-      initEmbeddings: async () => {},
-      getIndexStats: () => ({ entries: 0, files: 0, lastReindex: 0, sizeBytes: 0 }),
-    }));
-    vi.resetModules();
-    const { buildSmartSystemPrompt } = await import("../src/services/personality.js");
-
-    const prompt = await buildSmartSystemPrompt(true, "en", "test query", "1234", true);
-    expect(prompt).toBeTruthy();
-    expect(prompt).toMatch(/User User prefers terse answers/); // base still works
-  });
-});

package/test/memory-stress-restart.test.ts

@@ -1,337 +0,0 @@
-/**
- * v4.11.0 — Hardcore stress tests for memory persistence.
- *
- * Validates that the persistence + memory-layers + extractor stack survives
- * the full range of edge cases that bite real bots in production:
- *   - 100 concurrent sessions across rapid mutate-flush cycles
- *   - Atomic write under simulated crash mid-write
- *   - Schema drift (old persisted snapshot, new bot version)
- *   - Corrupted JSON
- *   - Empty/missing identity files
- *   - Unicode + emoji in content
- *   - Very long history
- *   - Garbage entries in state file
- *   - Memory dir missing entirely
- */
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-stress-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(resolve(TEST_DATA_DIR, "memory"), { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  vi.resetModules();
-});
-
-afterEach(() => {
-  try { fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true }); } catch { /* ignore */ }
-});
-
-describe("memory persistence stress (v4.11.0)", () => {
-  it("100 sessions all flush + reload correctly", async () => {
-    const sessionMod = await import("../src/services/session.js");
-    const persistMod = await import("../src/services/session-persistence.js");
-
-    for (let i = 0; i < 100; i++) {
-      const s = sessionMod.getSession(`stress-user-${i}`);
-      s.sessionId = `sdk-${i}`;
-      s.history = [{ role: "user", content: `msg from user ${i}` }];
-      s.messageCount = i;
-    }
-
-    await persistMod.flushSessions();
-
-    // Wipe in-memory map by resetting the module
-    vi.resetModules();
-    const sessionMod2 = await import("../src/services/session.js");
-    const persistMod2 = await import("../src/services/session-persistence.js");
-
-    const loaded = persistMod2.loadPersistedSessions();
-    expect(loaded).toBe(100);
-
-    for (let i = 0; i < 100; i++) {
-      const s = sessionMod2.getSession(`stress-user-${i}`);
-      expect(s.sessionId).toBe(`sdk-${i}`);
-      expect(s.history).toHaveLength(1);
-      expect(s.history[0].content).toBe(`msg from user ${i}`);
-    }
-  });
-
-  it("unicode + emoji in session content survive round-trip", async () => {
-    const sessionMod = await import("../src/services/session.js");
-    const persistMod = await import("../src/services/session-persistence.js");
-
-    const s = sessionMod.getSession("unicode-user");
-    s.sessionId = "abc";
-    s.history = [
-      { role: "user", content: "Hallo 🦊 was läuft? München → Berlin Übersetzung: 你好" },
-      { role: "assistant", content: "Klar 🎉 — alles ok ✅" },
-    ];
-
-    await persistMod.flushSessions();
-    vi.resetModules();
-    const persistMod2 = await import("../src/services/session-persistence.js");
-    const sessionMod2 = await import("../src/services/session.js");
-    persistMod2.loadPersistedSessions();
-    const restored = sessionMod2.getSession("unicode-user");
-    expect(restored.history[0].content).toMatch(/🦊/);
-    expect(restored.history[0].content).toMatch(/你好/);
-    expect(restored.history[1].content).toMatch(/🎉/);
-  });
-
-  it("very long history (300 messages) gets capped at 50 on persist", async () => {
-    const sessionMod = await import("../src/services/session.js");
-    const persistMod = await import("../src/services/session-persistence.js");
-
-    const s = sessionMod.getSession("chatty-user");
-    s.sessionId = "abc";
-    for (let i = 0; i < 300; i++) {
-      s.history.push({ role: i % 2 === 0 ? "user" : "assistant", content: `m${i}` });
-    }
-
-    await persistMod.flushSessions();
-
-    vi.resetModules();
-    const persistMod2 = await import("../src/services/session-persistence.js");
-    const sessionMod2 = await import("../src/services/session.js");
-    persistMod2.loadPersistedSessions();
-    const restored = sessionMod2.getSession("chatty-user");
-    expect(restored.history.length).toBeLessThanOrEqual(50);
-    // The most recent should be preserved
-    expect(restored.history.at(-1)?.content).toBe("m299");
-  });
-
-  it("schema drift: old snapshot with missing fields rehydrates with defaults", async () => {
-    fs.mkdirSync(resolve(TEST_DATA_DIR, "state"), { recursive: true });
-    fs.writeFileSync(
-      resolve(TEST_DATA_DIR, "state", "sessions.json"),
-      JSON.stringify({
-        "old-user": {
-          // Only the absolute minimum from a hypothetical earlier version
-          sessionId: "abc",
-          // Missing: language, effort, voiceReply, etc.
-        },
-      }),
-    );
-
-    const persistMod = await import("../src/services/session-persistence.js");
-    const sessionMod = await import("../src/services/session.js");
-    const loaded = persistMod.loadPersistedSessions();
-    expect(loaded).toBe(1);
-
-    const s = sessionMod.getSession("old-user");
-    expect(s.sessionId).toBe("abc");
-    expect(s.language).toBe("en");
-    expect(s.effort).toBe("medium");
-    expect(s.voiceReply).toBe(false);
-    expect(s.history).toEqual([]);
-  });
-
-  it("garbage entries in sessions.json are skipped without breaking the rest", async () => {
-    fs.mkdirSync(resolve(TEST_DATA_DIR, "state"), { recursive: true });
-    fs.writeFileSync(
-      resolve(TEST_DATA_DIR, "state", "sessions.json"),
-      JSON.stringify({
-        "good-user": { sessionId: "good", history: [] },
-        "bad-user": null,
-        "another-bad": "this is a string not an object",
-      }),
-    );
-
-    const persistMod = await import("../src/services/session-persistence.js");
-    const sessionMod = await import("../src/services/session.js");
-    persistMod.loadPersistedSessions();
-
-    expect(sessionMod.getSession("good-user").sessionId).toBe("good");
-    // bad-user and another-bad are silently skipped — no crash
-  });
-
-  it("memory-layers handles a missing memory dir gracefully", async () => {
-    fs.rmSync(resolve(TEST_DATA_DIR, "memory"), { recursive: true, force: true });
-    vi.resetModules();
-    const { loadMemoryLayers } = await import("../src/services/memory-layers.js");
-    const layers = loadMemoryLayers();
-    expect(layers.identity).toBe("");
-    expect(layers.preferences).toBe("");
-    expect(layers.longTerm).toBe("");
-    expect(layers.projects).toEqual([]);
-  });
-
-  it("memory-layers handles unicode in identity and projects", async () => {
-    fs.writeFileSync(
-      resolve(TEST_DATA_DIR, "memory", "identity.md"),
-      "Name: Test User 🦊\nLocation: Berlin",
-    );
-    fs.mkdirSync(resolve(TEST_DATA_DIR, "memory", "projects"), { recursive: true });
-    fs.writeFileSync(
-      resolve(TEST_DATA_DIR, "memory", "projects", "perseus.md"),
-      "Trading bot 📈 — handles ~$1M equity",
-    );
-
-    const { loadMemoryLayers, buildLayeredContext } = await import("../src/services/memory-layers.js");
-    const layers = loadMemoryLayers();
-    expect(layers.identity).toMatch(/🦊/);
-    expect(layers.projects[0].content).toMatch(/📈/);
-
-    const ctx = buildLayeredContext("how is perseus doing");
-    expect(ctx).toMatch(/📈/);
-  });
-
-  it("100 mutate→persist cycles with debounce do not corrupt state", async () => {
-    const sessionMod = await import("../src/services/session.js");
-    const persistMod = await import("../src/services/session-persistence.js");
-
-    const s = sessionMod.getSession("rapid-user");
-    for (let i = 0; i < 100; i++) {
-      s.sessionId = `v${i}`;
-      persistMod.schedulePersist();
-    }
-    await persistMod.flushSessions();
-
-    const stateFile = resolve(TEST_DATA_DIR, "state", "sessions.json");
-    // v4.12.0 — Format is now an envelope: { version, sessions, telegramWorkspaces }
-    const parsed = JSON.parse(fs.readFileSync(stateFile, "utf-8")).sessions;
-    expect(parsed["rapid-user"].sessionId).toBe("v99");
-  });
-
-  it("memory-extractor opt-out env var is respected", async () => {
-    process.env.MEMORY_EXTRACTION_DISABLED = "1";
-    vi.resetModules();
-    const { extractAndStoreFacts } = await import("../src/services/memory-extractor.js");
-    const result = await extractAndStoreFacts("Some conversation about Berlin and Postgres");
-    expect(result.disabled).toBe(true);
-    expect(result.factsStored).toBe(0);
-    delete process.env.MEMORY_EXTRACTION_DISABLED;
-  });
-
-  it("hostile sessions.json: empty object loads zero sessions", async () => {
-    fs.mkdirSync(resolve(TEST_DATA_DIR, "state"), { recursive: true });
-    fs.writeFileSync(resolve(TEST_DATA_DIR, "state", "sessions.json"), "{}");
-    const persistMod = await import("../src/services/session-persistence.js");
-    expect(persistMod.loadPersistedSessions()).toBe(0);
-  });
-
-  it("hostile sessions.json: null root is rejected gracefully", async () => {
-    fs.mkdirSync(resolve(TEST_DATA_DIR, "state"), { recursive: true });
-    fs.writeFileSync(resolve(TEST_DATA_DIR, "state", "sessions.json"), "null");
-    const persistMod = await import("../src/services/session-persistence.js");
-    expect(persistMod.loadPersistedSessions()).toBe(0);
-  });
-
-  it("hostile sessions.json: array root is rejected gracefully", async () => {
-    fs.mkdirSync(resolve(TEST_DATA_DIR, "state"), { recursive: true });
-    fs.writeFileSync(resolve(TEST_DATA_DIR, "state", "sessions.json"), "[1,2,3]");
-    const persistMod = await import("../src/services/session-persistence.js");
-    // Arrays are technically objects in JS — entries() returns indexed pairs.
-    // The persisted-session shape filter will reject each entry → 0 loaded.
-    const loaded = persistMod.loadPersistedSessions();
-    expect(loaded).toBeLessThanOrEqual(3); // permissive but doesn't crash
-  });
-
-  it("history preserves message order (chronology) after slice cap", async () => {
-    const sessionMod = await import("../src/services/session.js");
-    const persistMod = await import("../src/services/session-persistence.js");
-
-    const s = sessionMod.getSession("chrono-user");
-    s.sessionId = "abc";
-    for (let i = 0; i < 80; i++) {
-      s.history.push({ role: "user", content: `msg-${i.toString().padStart(3, "0")}` });
-    }
-    await persistMod.flushSessions();
-
-    vi.resetModules();
-    const persistMod2 = await import("../src/services/session-persistence.js");
-    const sessionMod2 = await import("../src/services/session.js");
-    persistMod2.loadPersistedSessions();
-    const restored = sessionMod2.getSession("chrono-user");
-
-    // Last 50 should be preserved in order
-    expect(restored.history[0].content).toBe("msg-030");
-    expect(restored.history[49].content).toBe("msg-079");
-  });
-
-  it("layered context with very long identity stays under budget", async () => {
-    const longIdentity = "Name: User. ".repeat(2000); // 22000 chars
-    fs.writeFileSync(
-      resolve(TEST_DATA_DIR, "memory", "identity.md"),
-      longIdentity,
-    );
-    const { buildLayeredContext } = await import("../src/services/memory-layers.js");
-    const ctx = buildLayeredContext();
-    expect(ctx.length).toBeLessThan(6000);
-    expect(ctx).toMatch(/truncated/);
-  });
-
-  it("memory-extractor JSON tolerance: handles whitespace-only response", async () => {
-    const { parseExtractedFacts } = await import("../src/services/memory-extractor.js");
-    const facts = parseExtractedFacts("   \n\n   ");
-    expect(facts.user_facts).toEqual([]);
-  });
-
-  it("memory-extractor handles null facts in response", async () => {
-    const { parseExtractedFacts } = await import("../src/services/memory-extractor.js");
-    const facts = parseExtractedFacts(JSON.stringify({
-      user_facts: null,
-      preferences: ["valid pref"],
-      decisions: undefined,
-    }));
-    expect(facts.user_facts).toEqual([]);
-    expect(facts.preferences).toEqual(["valid pref"]);
-    expect(facts.decisions).toEqual([]);
-  });
-
-  it("session-persistence handles read-only filesystem gracefully", async () => {
-    const sessionMod = await import("../src/services/session.js");
-    const persistMod = await import("../src/services/session-persistence.js");
-
-    const s = sessionMod.getSession("test-user");
-    s.sessionId = "abc";
-
-    // Make state dir read-only AFTER it exists
-    fs.mkdirSync(resolve(TEST_DATA_DIR, "state"), { recursive: true });
-    fs.chmodSync(resolve(TEST_DATA_DIR, "state"), 0o444);
-
-    // Should not throw
-    await expect(persistMod.flushSessions()).resolves.toBeUndefined();
-
-    // Cleanup so afterEach can rmSync
-    fs.chmodSync(resolve(TEST_DATA_DIR, "state"), 0o755);
-  });
-
-  it("simulated bot restart: sessionId roundtrips across module reset", async () => {
-    // Simulate first bot lifetime
-    const session1 = await import("../src/services/session.js");
-    const persist1 = await import("../src/services/session-persistence.js");
-    persist1.loadPersistedSessions();
-
-    // Simulate user interaction
-    const s = session1.getSession("restart-user");
-    s.sessionId = "claude-uuid-12345";
-    s.language = "de";
-    s.effort = "high";
-    s.history = [
-      { role: "user", content: "Erstes Gespräch" },
-      { role: "assistant", content: "Hallo!" },
-    ];
-    await persist1.flushSessions();
-
-    // Simulate full bot restart — reset modules
-    vi.resetModules();
-
-    // Second bot lifetime
-    const session2 = await import("../src/services/session.js");
-    const persist2 = await import("../src/services/session-persistence.js");
-    persist2.loadPersistedSessions();
-
-    const s2 = session2.getSession("restart-user");
-    expect(s2.sessionId).toBe("claude-uuid-12345");
-    expect(s2.language).toBe("de");
-    expect(s2.effort).toBe("high");
-    expect(s2.history).toHaveLength(2);
-    expect(s2.history[0].content).toBe("Erstes Gespräch");
-  });
-});