alvin-bot 4.18.0 → 4.18.2

package/test/multi-session-stress.test.ts

@@ -1,255 +0,0 @@
-/**
- * v4.12.0 — Multi-session end-to-end stress tests.
- *
- * Covers the full stack: workspace registry + session key + resolver +
- * persistence + cost aggregation. Validates that parallel sessions
- * across different channels/workspaces stay isolated, survive bot
- * restart, and report correct aggregated metrics.
- */
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-multi-stress-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(resolve(TEST_DATA_DIR, "workspaces"), { recursive: true });
-  fs.mkdirSync(resolve(TEST_DATA_DIR, "memory"), { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  process.env.SESSION_MODE = "per-channel";
-  vi.resetModules();
-});
-
-afterEach(() => {
-  try { fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true }); } catch { /* ignore */ }
-});
-
-function writeWs(name: string, purpose: string, body: string, channels: string[] = []): void {
-  const fm = [
-    `purpose: ${JSON.stringify(purpose)}`,
-    `cwd: ${JSON.stringify("~/tmp/" + name)}`,
-    channels.length > 0 ? `channels: ${JSON.stringify(channels)}` : "",
-  ].filter(Boolean).join("\n");
-  fs.writeFileSync(
-    resolve(TEST_DATA_DIR, "workspaces", `${name}.md`),
-    `---\n${fm}\n---\n${body}`,
-  );
-}
-
-describe("multi-session stress (v4.12.0)", () => {
-  it("5 parallel Slack channels each get isolated sessions", async () => {
-    writeWs("my-project", "my-project dev", "my-project persona", ["C_ALEV"]);
-    writeWs("homes", "HOMES SaaS", "HOMES persona", ["C_HOMES"]);
-    writeWs("my-landing", "my-landing app", "my-landing persona", ["C_JOBS"]);
-    writeWs("perseus", "Trading bot", "Perseus persona", ["C_PERSEUS"]);
-    writeWs("alvin", "Bot development", "Alvin persona", ["C_ALVIN"]);
-
-    const { initWorkspaces, resolveWorkspaceOrDefault } = await import("../src/services/workspaces.js");
-    const { buildSessionKey, getSession } = await import("../src/services/session.js");
-    initWorkspaces();
-
-    const channels = [
-      { id: "C_ALEV", ws: "my-project" },
-      { id: "C_HOMES", ws: "homes" },
-      { id: "C_JOBS", ws: "my-landing" },
-      { id: "C_PERSEUS", ws: "perseus" },
-      { id: "C_ALVIN", ws: "alvin" },
-    ];
-
-    for (const { id, ws } of channels) {
-      const workspace = resolveWorkspaceOrDefault("slack", id, undefined);
-      expect(workspace.name).toBe(ws);
-      const sessionKey = buildSessionKey("slack", id, "U_ALI");
-      const session = getSession(sessionKey);
-      session.workspaceName = workspace.name;
-      session.workingDir = workspace.cwd;
-      session.history.push({ role: "user", content: `hello from ${ws}` });
-      session.sessionId = `sdk-${ws}`;
-      session.totalCost = Math.random() * 0.1;
-      session.messageCount = 1;
-    }
-
-    // Verify isolation: each session key is unique, each has its own workspace
-    const { getAllSessions } = await import("../src/services/session.js");
-    const allSessions = getAllSessions();
-    const slackSessions = Array.from(allSessions.entries()).filter(([k]) => k.startsWith("slack:"));
-    expect(slackSessions).toHaveLength(5);
-    const wsNames = new Set(slackSessions.map(([, s]) => s.workspaceName));
-    expect(wsNames.size).toBe(5);
-  });
-
-  it("survives full restart: 5 workspaces + 5 sessions persisted and rehydrated", async () => {
-    writeWs("my-project", "my-project", "persona", ["C_ALEV"]);
-    writeWs("homes", "HOMES", "persona", ["C_HOMES"]);
-    writeWs("my-landing", "my-landing", "persona", ["C_JOBS"]);
-    writeWs("perseus", "Perseus", "persona", ["C_PERSEUS"]);
-    writeWs("alvin", "Alvin", "persona", ["C_ALVIN"]);
-
-    const { initWorkspaces, resolveWorkspaceOrDefault } = await import("../src/services/workspaces.js");
-    const { buildSessionKey, getSession } = await import("../src/services/session.js");
-    const { flushSessions } = await import("../src/services/session-persistence.js");
-    initWorkspaces();
-
-    for (const id of ["C_ALEV", "C_HOMES", "C_JOBS", "C_PERSEUS", "C_ALVIN"]) {
-      const ws = resolveWorkspaceOrDefault("slack", id, undefined);
-      const key = buildSessionKey("slack", id, "U_ALI");
-      const s = getSession(key);
-      s.sessionId = `sdk-${ws.name}`;
-      s.workspaceName = ws.name;
-      s.workingDir = ws.cwd;
-      s.history = [
-        { role: "user", content: `persistent ${ws.name}` },
-        { role: "assistant", content: `ack ${ws.name}` },
-      ];
-    }
-    await flushSessions();
-
-    // Simulate restart
-    vi.resetModules();
-    const s2 = await import("../src/services/session.js");
-    const p2 = await import("../src/services/session-persistence.js");
-    const loaded = p2.loadPersistedSessions();
-    expect(loaded).toBe(5);
-
-    for (const id of ["C_ALEV", "C_HOMES", "C_JOBS", "C_PERSEUS", "C_ALVIN"]) {
-      const key = `slack:${id}`;
-      const s = s2.getSession(key);
-      expect(s.sessionId).toMatch(/^sdk-/);
-      expect(s.history).toHaveLength(2);
-      expect(s.workspaceName).not.toBeNull();
-    }
-  });
-
-  it("getCostByWorkspace aggregates across sessions correctly", async () => {
-    const { getSession, getCostByWorkspace } = await import("../src/services/session.js");
-
-    const a = getSession("slack:C_A");
-    a.workspaceName = "my-project";
-    a.totalCost = 0.10;
-    a.messageCount = 3;
-    a.toolUseCount = 5;
-
-    const b = getSession("slack:C_B");
-    b.workspaceName = "my-project";
-    b.totalCost = 0.05;
-    b.messageCount = 2;
-    b.toolUseCount = 1;
-
-    const c = getSession("slack:C_C");
-    c.workspaceName = "homes";
-    c.totalCost = 0.25;
-    c.messageCount = 10;
-    c.toolUseCount = 8;
-
-    const breakdown = getCostByWorkspace();
-    expect(breakdown["my-project"].sessionCount).toBe(2);
-    expect(breakdown["my-project"].messageCount).toBe(5);
-    expect(breakdown["my-project"].toolUseCount).toBe(6);
-    expect(breakdown["my-project"].totalCost).toBeCloseTo(0.15, 10);
-    expect(breakdown["homes"].sessionCount).toBe(1);
-    expect(breakdown["homes"].messageCount).toBe(10);
-    expect(breakdown["homes"].toolUseCount).toBe(8);
-    expect(breakdown["homes"].totalCost).toBeCloseTo(0.25, 10);
-  });
-
-  it("workspaces hot-reload picks up a new channel ID", async () => {
-    writeWs("my-project", "my-project", "persona");
-    const { initWorkspaces, resolveWorkspaceOrDefault, reloadWorkspaces } =
-      await import("../src/services/workspaces.js");
-    initWorkspaces();
-
-    // Initially no channel mapping → default
-    let ws = resolveWorkspaceOrDefault("slack", "C_NEW", undefined);
-    expect(ws.name).toBe("default");
-
-    // Add channel to config + reload
-    writeWs("my-project", "my-project", "persona", ["C_NEW"]);
-    reloadWorkspaces();
-
-    ws = resolveWorkspaceOrDefault("slack", "C_NEW", undefined);
-    expect(ws.name).toBe("my-project");
-  });
-
-  it("channel-name fallback finds workspace when no explicit ID mapping", async () => {
-    writeWs("my-project", "my-project", "persona");
-    const { initWorkspaces, resolveWorkspaceOrDefault } = await import("../src/services/workspaces.js");
-    initWorkspaces();
-
-    const ws = resolveWorkspaceOrDefault("slack", "C_UNMAPPED", "#my-project");
-    expect(ws.name).toBe("my-project");
-  });
-
-  it("malformed workspace doesn't break loading of other workspaces", async () => {
-    fs.writeFileSync(
-      resolve(TEST_DATA_DIR, "workspaces", "broken.md"),
-      "---\n{{{{ not yaml at all }}}}\n---\n",
-    );
-    writeWs("good", "good one", "body");
-    const { initWorkspaces, listWorkspaces } = await import("../src/services/workspaces.js");
-    initWorkspaces();
-    const names = listWorkspaces().map(w => w.name);
-    expect(names).toContain("good");
-  });
-
-  it("unicode in workspace filenames + bodies works", async () => {
-    writeWs("café-int", "Café International ☕️", "Emoji persona 🦊", ["C_CAFE"]);
-    const { initWorkspaces, resolveWorkspaceOrDefault } = await import("../src/services/workspaces.js");
-    initWorkspaces();
-    const ws = resolveWorkspaceOrDefault("slack", "C_CAFE", undefined);
-    expect(ws.name).toBe("café-int");
-    expect(ws.purpose).toContain("☕");
-    expect(ws.systemPromptOverride).toContain("🦊");
-  });
-
-  it("workspace with no cwd frontmatter falls back to config.defaultWorkingDir", async () => {
-    fs.writeFileSync(
-      resolve(TEST_DATA_DIR, "workspaces", "no-cwd.md"),
-      "---\npurpose: test\n---\nbody",
-    );
-    const { initWorkspaces, getWorkspace } = await import("../src/services/workspaces.js");
-    initWorkspaces();
-    const ws = getWorkspace("no-cwd");
-    expect(ws!.cwd).toBeTruthy();
-    expect(ws!.cwd.length).toBeGreaterThan(0);
-  });
-
-  it("session with workspaceName: null aggregates under 'default' in breakdown", async () => {
-    const { getSession, getCostByWorkspace } = await import("../src/services/session.js");
-    const s = getSession("slack:C_UNKNOWN");
-    s.workspaceName = null;
-    s.totalCost = 0.42;
-    s.messageCount = 7;
-
-    const breakdown = getCostByWorkspace();
-    expect(breakdown["default"]).toBeDefined();
-    expect(breakdown["default"].totalCost).toBeGreaterThanOrEqual(0.42);
-  });
-
-  it("simulated restart + workspace switch: workspaceName persists across flush cycles", async () => {
-    writeWs("my-project", "my-project", "persona", ["C_ALEV"]);
-    const { initWorkspaces, resolveWorkspaceOrDefault } = await import("../src/services/workspaces.js");
-    const { buildSessionKey, getSession } = await import("../src/services/session.js");
-    const { flushSessions } = await import("../src/services/session-persistence.js");
-    initWorkspaces();
-
-    const key = buildSessionKey("slack", "C_ALEV", "U_ALI");
-    const s = getSession(key);
-    const ws = resolveWorkspaceOrDefault("slack", "C_ALEV", undefined);
-    s.sessionId = "alev-resume";
-    s.workspaceName = ws.name;
-    s.workingDir = ws.cwd;
-    await flushSessions();
-
-    vi.resetModules();
-    const s2 = await import("../src/services/session.js");
-    const p2 = await import("../src/services/session-persistence.js");
-    p2.loadPersistedSessions();
-
-    const restored = s2.getSession("slack:C_ALEV");
-    expect(restored.sessionId).toBe("alev-resume");
-    expect(restored.workspaceName).toBe("my-project");
-    expect(restored.workingDir).toContain("my-project");
-  });
-});

package/test/platform-session-key.test.ts

@@ -1,69 +0,0 @@
-/**
- * v4.12.0 — Platform session key must honor channelId, not just userId.
- *
- * Before v4.12.0 platform-message.ts used hashUserId(msg.userId) which
- * collapsed all channels from the same user into one session. This broke
- * multi-session on Slack where different channels should be isolated.
- *
- * The fix: route through buildSessionKey(platform, channelId, userId).
- */
-import { describe, it, expect, beforeEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-platform-key-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  process.env.SESSION_MODE = "per-channel";
-  vi.resetModules();
-});
-
-describe("buildSessionKey with string userIds (v4.12.0)", () => {
-  it("per-channel mode returns platform:channelId", async () => {
-    const { buildSessionKey } = await import("../src/services/session.js");
-    const key = buildSessionKey("slack", "C01ABCDEF", "U01HIJKLM");
-    expect(key).toBe("slack:C01ABCDEF");
-  });
-
-  it("per-channel-peer mode returns platform:channelId:userId", async () => {
-    process.env.SESSION_MODE = "per-channel-peer";
-    vi.resetModules();
-    const { buildSessionKey } = await import("../src/services/session.js");
-    const key = buildSessionKey("slack", "C01ABC", "U01XYZ");
-    expect(key).toBe("slack:C01ABC:U01XYZ");
-  });
-
-  it("per-user mode returns just the userId as string", async () => {
-    process.env.SESSION_MODE = "per-user";
-    vi.resetModules();
-    const { buildSessionKey } = await import("../src/services/session.js");
-    const key = buildSessionKey("slack", "C01ABC", "U01XYZ");
-    expect(key).toBe("U01XYZ");
-  });
-
-  it("two different channels for the same Slack user produce different session keys", async () => {
-    const { buildSessionKey } = await import("../src/services/session.js");
-    const a = buildSessionKey("slack", "C_ALEV_B", "U01XYZ");
-    const b = buildSessionKey("slack", "C_HOMES", "U01XYZ");
-    expect(a).not.toBe(b);
-  });
-
-  it("two different platforms with the same channel id produce different session keys", async () => {
-    const { buildSessionKey } = await import("../src/services/session.js");
-    const slack = buildSessionKey("slack", "ABC123", "U01");
-    const discord = buildSessionKey("discord", "ABC123", "U01");
-    expect(slack).not.toBe(discord);
-  });
-
-  it("backwards compat: numeric Telegram userIds still work (per-user)", async () => {
-    process.env.SESSION_MODE = "per-user";
-    vi.resetModules();
-    const { buildSessionKey } = await import("../src/services/session.js");
-    const key = buildSessionKey("telegram", "123456", 1234567890);
-    expect(key).toBe("1234567890");
-  });
-});

package/test/process-manager.test.ts

@@ -1,186 +0,0 @@
-/**
- * v4.13.1 — process-manager abstraction tests.
- *
- * The maintenance section in the Web UI used to hard-wire PM2 commands
- * (`pm2 jlist`, `pm2 restart`, `pm2 stop`, `pm2 logs ...`). Since v4.8
- * the Mac install uses launchd (`com.alvinbot.app.plist`) — PM2 isn't
- * running, so those calls returned "PM2 not available" and the buttons
- * did nothing.
- *
- * This module abstracts the process manager and auto-detects which one
- * is actually managing the bot. Detection order:
- *
- *   1. launchd (macOS) — if `launchctl print gui/$UID/com.alvinbot.app`
- *      succeeds AND the bot's actual running pid matches
- *   2. PM2 — if `pm2 jlist` returns our process
- *   3. standalone — neither detected; only the in-process graceful
- *      restart works (scheduleGracefulRestart — since there's no
- *      supervisor to bring it back, "stop" is effectively "kill")
- *
- * Each manager implements: getStatus(), stop(), start(), getLogs().
- * Restart is intentionally NOT on the manager — it always routes through
- * scheduleGracefulRestart() (Grammy-safe) and the supervisor auto-brings-
- * back behaviour.
- */
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-
-interface ExecCall {
-  cmd: string;
-  opts?: unknown;
-}
-
-let execLog: ExecCall[] = [];
-let execReturn: Record<string, string | Error> = {};
-
-function stubExec() {
-  vi.doMock("node:child_process", () => ({
-    execSync: (cmd: string, opts?: unknown) => {
-      execLog.push({ cmd, opts });
-      // Find match by pattern — longest matching prefix wins
-      const matches = Object.keys(execReturn).filter((k) => cmd.includes(k));
-      matches.sort((a, b) => b.length - a.length);
-      const key = matches[0];
-      if (key) {
-        const v = execReturn[key];
-        if (v instanceof Error) throw v;
-        return v;
-      }
-      throw new Error(`execSync: no stub for ${cmd}`);
-    },
-  }));
-}
-
-beforeEach(() => {
-  execLog = [];
-  execReturn = {};
-  vi.resetModules();
-  stubExec();
-});
-
-afterEach(() => {
-  vi.doUnmock("node:child_process");
-});
-
-describe("detectProcessManager (v4.13.1)", () => {
-  it("detects 'launchd' when launchctl print succeeds on darwin", async () => {
-    execReturn["launchctl print"] = `gui/502/com.alvinbot.app = {
-      state = running
-      program = /opt/homebrew/bin/node
-    }`;
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.detectProcessManager({ platform: "darwin" });
-    expect(pm.kind).toBe("launchd");
-  });
-
-  it("falls through to 'pm2' when launchd is not detected", async () => {
-    execReturn["launchctl print"] = new Error("Could not find service");
-    execReturn["pm2 jlist"] = JSON.stringify([
-      { name: "alvin-bot", pid: 1234, pm2_env: { status: "online" } },
-    ]);
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.detectProcessManager({ platform: "linux" });
-    expect(pm.kind).toBe("pm2");
-  });
-
-  it("falls through to 'standalone' when neither is detected", async () => {
-    execReturn["launchctl print"] = new Error("not found");
-    execReturn["pm2 jlist"] = new Error("command not found");
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.detectProcessManager({ platform: "linux" });
-    expect(pm.kind).toBe("standalone");
-  });
-
-  it("skips launchd detection on non-darwin platforms", async () => {
-    // No launchctl command should be issued on Linux
-    execReturn["pm2 jlist"] = JSON.stringify([
-      { name: "alvin-bot", pid: 1234, pm2_env: { status: "online" } },
-    ]);
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.detectProcessManager({ platform: "linux" });
-    expect(pm.kind).toBe("pm2");
-    // Verify launchctl was NOT called
-    expect(execLog.some((e) => e.cmd.includes("launchctl"))).toBe(false);
-  });
-});
-
-describe("launchd process manager (v4.13.1)", () => {
-  it("getStatus parses launchctl print output for state + PID", async () => {
-    execReturn["launchctl print"] = `gui/502/com.alvinbot.app = {
-      active count = 1
-      state = running
-      program = /opt/homebrew/Cellar/node/25.9.0_1/bin/node
-      pid = 65432
-      program path = /usr/bin/node
-      working directory = /Users/alvin_de/Projects/alvin-bot
-      stdout path = /Users/alvin_de/.alvin-bot/logs/alvin-bot.out.log
-    }`;
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.createLaunchdManager(502);
-    const status = await pm.getStatus();
-    expect(status.status).toBe("running");
-    expect(status.pid).toBe(65432);
-    expect(status.kind).toBe("launchd");
-  });
-
-  it("getStatus returns 'not-loaded' when service is not registered", async () => {
-    execReturn["launchctl print"] = new Error("Could not find service");
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.createLaunchdManager(502);
-    const status = await pm.getStatus();
-    expect(status.status).toBe("not-loaded");
-  });
-
-  it("stop uses launchctl bootout", async () => {
-    execReturn["launchctl bootout"] = "";
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.createLaunchdManager(502);
-    await pm.stop();
-    const stopCall = execLog.find((e) => e.cmd.includes("bootout"));
-    expect(stopCall).toBeDefined();
-    expect(stopCall!.cmd).toContain("gui/502/com.alvinbot.app");
-  });
-
-  it("start uses launchctl bootstrap", async () => {
-    execReturn["launchctl bootstrap"] = "";
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.createLaunchdManager(502);
-    await pm.start();
-    const startCall = execLog.find((e) => e.cmd.includes("bootstrap"));
-    expect(startCall).toBeDefined();
-    expect(startCall!.cmd).toMatch(/com\.alvinbot\.app\.plist/);
-  });
-});
-
-describe("pm2 process manager (v4.13.1)", () => {
-  it("getStatus parses pm2 jlist for our process", async () => {
-    execReturn["pm2 jlist"] = JSON.stringify([
-      {
-        name: "alvin-bot",
-        pid: 9999,
-        pm2_env: {
-          status: "online",
-          pm_uptime: Date.now() - 60_000,
-          restart_time: 2,
-        },
-        monit: { memory: 123456, cpu: 1.5 },
-      },
-    ]);
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.createPm2Manager();
-    const status = await pm.getStatus();
-    expect(status.status).toBe("online");
-    expect(status.pid).toBe(9999);
-    expect(status.kind).toBe("pm2");
-    expect(status.restarts).toBe(2);
-  });
-
-  it("getStatus returns 'unknown' if pm2 jlist does not include our process", async () => {
-    execReturn["pm2 jlist"] = JSON.stringify([
-      { name: "other-service", pid: 1111, pm2_env: { status: "online" } },
-    ]);
-    const mod = await import("../src/services/process-manager.js");
-    const pm = mod.createPm2Manager();
-    const status = await pm.getStatus();
-    expect(status.status).toBe("unknown");
-  });
-});