alvin-bot 4.18.0 → 4.18.2

package/test/background-bypass-stress.test.ts

@@ -1,417 +0,0 @@
-/**
- * v4.12.3 — Stress + edge-case tests for the bypass path.
- *
- * These tests exercise scenarios that aren't part of the happy path
- * but should hold up in real-world use:
- *   - Many parallel sessions
- *   - Rapid churn (launch/deliver cycles)
- *   - Memory hygiene (no residual in-memory state after delivery)
- *   - Race conditions: delivery fires while counter is mid-update
- *   - Extreme counter drift (more deliveries than launches)
- *   - waitUntilProcessingFalse timeout paths
- */
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-
-const TEST_DATA_DIR = resolve(
-  os.tmpdir(),
-  `alvin-bypass-stress-${process.pid}-${Date.now()}`,
-);
-
-beforeEach(async () => {
-  if (fs.existsSync(TEST_DATA_DIR)) {
-    fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  }
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  vi.resetModules();
-  vi.doMock("../src/services/subagent-delivery.js", () => ({
-    deliverSubAgentResult: async () => {},
-    attachBotApi: () => {},
-    __setBotApiForTest: () => {},
-  }));
-});
-
-afterEach(async () => {
-  try {
-    const mod = await import("../src/services/async-agent-watcher.js");
-    mod.stopWatcher();
-    mod.__resetForTest();
-  } catch {
-    /* ignore */
-  }
-});
-
-function writeCompletedJsonl(path: string, text: string): void {
-  const lines =
-    [
-      JSON.stringify({
-        type: "assistant",
-        isSidechain: true,
-        agentId: "x",
-        message: {
-          role: "assistant",
-          content: [{ type: "text", text }],
-          stop_reason: "end_turn",
-          usage: { input_tokens: 1, output_tokens: 1 },
-        },
-      }),
-    ].join("\n") + "\n";
-  fs.mkdirSync(resolve(path, ".."), { recursive: true });
-  fs.writeFileSync(path, lines, "utf-8");
-}
-
-describe("v4.12.3 bypass — stress + edge cases", () => {
-  it("100 parallel sessions each launch and deliver one agent — counters isolated", async () => {
-    const { getSession } = await import("../src/services/session.js");
-    const { handleToolResultChunk } = await import(
-      "../src/handlers/async-agent-chunk-handler.js"
-    );
-    const watcher = await import("../src/services/async-agent-watcher.js");
-
-    const N = 100;
-    const sessionKeys: string[] = [];
-
-    // Launch phase
-    for (let i = 0; i < N; i++) {
-      const sk = `stress-parallel-${i}`;
-      sessionKeys.push(sk);
-      const s = getSession(sk);
-      s.pendingBackgroundCount = 0;
-
-      const outPath = `${TEST_DATA_DIR}/p-${i}.jsonl`;
-      handleToolResultChunk(
-        {
-          type: "tool_result",
-          toolUseId: `p_${i}`,
-          toolResultContent:
-            "Async agent launched successfully.\n" +
-            `agentId: p-${i}\n` +
-            `output_file: ${outPath}\n`,
-        },
-        {
-          chatId: i,
-          userId: i,
-          sessionKey: sk,
-          lastToolUseInput: { description: `task ${i}`, prompt: "p" },
-        },
-      );
-    }
-
-    // Verify all have count=1
-    for (const sk of sessionKeys) {
-      expect(getSession(sk).pendingBackgroundCount).toBe(1);
-    }
-
-    // Complete phase
-    for (let i = 0; i < N; i++) {
-      writeCompletedJsonl(`${TEST_DATA_DIR}/p-${i}.jsonl`, `done ${i}`);
-    }
-    await watcher.pollOnce();
-
-    // Verify all back to 0
-    for (const sk of sessionKeys) {
-      expect(getSession(sk).pendingBackgroundCount).toBe(0);
-    }
-
-    // Verify watcher in-memory state is empty
-    expect(watcher.listPendingAgents()).toHaveLength(0);
-  });
-
-  it("churn: 200 rapid launch/deliver cycles on one session — counter stays [0,1]", async () => {
-    const { getSession } = await import("../src/services/session.js");
-    const { handleToolResultChunk } = await import(
-      "../src/handlers/async-agent-chunk-handler.js"
-    );
-    const watcher = await import("../src/services/async-agent-watcher.js");
-
-    const sk = "churn-hot";
-    const s = getSession(sk);
-    s.pendingBackgroundCount = 0;
-
-    for (let i = 0; i < 200; i++) {
-      const outPath = `${TEST_DATA_DIR}/churn-${i}.jsonl`;
-      handleToolResultChunk(
-        {
-          type: "tool_result",
-          toolUseId: `c_${i}`,
-          toolResultContent:
-            "Async agent launched successfully.\n" +
-            `agentId: c-${i}\n` +
-            `output_file: ${outPath}\n`,
-        },
-        {
-          chatId: 1,
-          userId: 1,
-          sessionKey: sk,
-          lastToolUseInput: { description: `task ${i}`, prompt: "p" },
-        },
-      );
-      expect(s.pendingBackgroundCount).toBe(1);
-
-      writeCompletedJsonl(outPath, `done ${i}`);
-      await watcher.pollOnce();
-      expect(s.pendingBackgroundCount).toBe(0);
-    }
-
-    // Final sanity
-    expect(watcher.listPendingAgents()).toHaveLength(0);
-  });
-
-  it("extreme drift: 10 deliveries but only 1 launch — counter clamps at 0", async () => {
-    const { getSession } = await import("../src/services/session.js");
-    const watcher = await import("../src/services/async-agent-watcher.js");
-
-    const sk = "drift-extreme";
-    const s = getSession(sk);
-    s.pendingBackgroundCount = 1;
-
-    // Register 10 agents to the same session, but keep the counter at 1
-    // (simulating a scenario where the handler increment got lost on 9 of them)
-    for (let i = 0; i < 10; i++) {
-      const outPath = `${TEST_DATA_DIR}/drift-${i}.jsonl`;
-      watcher.registerPendingAgent({
-        agentId: `drift-${i}`,
-        outputFile: outPath,
-        description: `drift ${i}`,
-        prompt: "p",
-        chatId: 1,
-        userId: 1,
-        toolUseId: null,
-        sessionKey: sk,
-      });
-      writeCompletedJsonl(outPath, `done ${i}`);
-    }
-
-    await watcher.pollOnce();
-
-    // First delivery takes counter from 1 → 0.
-    // The next 9 deliveries try to decrement from 0 and clamp.
-    expect(s.pendingBackgroundCount).toBe(0);
-  });
-
-  it("user /new during pending — counter reset is safe", async () => {
-    const { getSession, resetSession } = await import("../src/services/session.js");
-    const { handleToolResultChunk } = await import(
-      "../src/handlers/async-agent-chunk-handler.js"
-    );
-    const watcher = await import("../src/services/async-agent-watcher.js");
-
-    const sk = "reset-during-pending";
-    const s = getSession(sk);
-    s.pendingBackgroundCount = 0;
-
-    // Launch 3 agents
-    for (let i = 0; i < 3; i++) {
-      const outPath = `${TEST_DATA_DIR}/reset-${i}.jsonl`;
-      handleToolResultChunk(
-        {
-          type: "tool_result",
-          toolUseId: `r_${i}`,
-          toolResultContent:
-            "Async agent launched successfully.\n" +
-            `agentId: reset-${i}\n` +
-            `output_file: ${outPath}\n`,
-        },
-        {
-          chatId: 1,
-          userId: 1,
-          sessionKey: sk,
-          lastToolUseInput: { description: `task ${i}`, prompt: "p" },
-        },
-      );
-    }
-    expect(s.pendingBackgroundCount).toBe(3);
-
-    // User issues /new while all 3 are running
-    resetSession(sk);
-    expect(s.pendingBackgroundCount).toBe(0);
-
-    // Watcher delivers all 3 afterwards
-    for (let i = 0; i < 3; i++) {
-      writeCompletedJsonl(`${TEST_DATA_DIR}/reset-${i}.jsonl`, `done ${i}`);
-    }
-    await watcher.pollOnce();
-
-    // Counter should remain 0 (clamped)
-    expect(s.pendingBackgroundCount).toBe(0);
-  });
-
-  it("session removed from Map before delivery — decrement is no-op, no crash", async () => {
-    const { getAllSessions } = await import("../src/services/session.js");
-    const { handleToolResultChunk } = await import(
-      "../src/handlers/async-agent-chunk-handler.js"
-    );
-    const watcher = await import("../src/services/async-agent-watcher.js");
-
-    const sk = "ephemeral-session";
-    const s = getAllSessions();
-    // Use the standard path to ensure getSession works first
-    const { getSession } = await import("../src/services/session.js");
-    const session = getSession(sk);
-    session.pendingBackgroundCount = 0;
-
-    const outPath = `${TEST_DATA_DIR}/eph.jsonl`;
-    handleToolResultChunk(
-      {
-        type: "tool_result",
-        toolUseId: "eph_1",
-        toolResultContent:
-          "Async agent launched successfully.\n" +
-          "agentId: eph-1\n" +
-          `output_file: ${outPath}\n`,
-      },
-      {
-        chatId: 1,
-        userId: 1,
-        sessionKey: sk,
-        lastToolUseInput: { description: "d", prompt: "p" },
-      },
-    );
-    expect(session.pendingBackgroundCount).toBe(1);
-
-    // Nuke the session from the map (simulates TTL cleanup)
-    s.delete(sk);
-
-    writeCompletedJsonl(outPath, "done");
-    await expect(watcher.pollOnce()).resolves.not.toThrow();
-  });
-
-  it("mixed rollout: pre-v4.12.3 persisted entries (no sessionKey) mixed with new entries", async () => {
-    const { getSession } = await import("../src/services/session.js");
-    const watcher = await import("../src/services/async-agent-watcher.js");
-
-    // v4.12.3 session with counter
-    const sk = "mixed-v412";
-    const s = getSession(sk);
-    s.pendingBackgroundCount = 1;
-
-    // New-style entry with sessionKey
-    const newPath = `${TEST_DATA_DIR}/new.jsonl`;
-    watcher.registerPendingAgent({
-      agentId: "new-agent",
-      outputFile: newPath,
-      description: "new",
-      prompt: "p",
-      chatId: 1,
-      userId: 1,
-      toolUseId: null,
-      sessionKey: sk,
-    });
-
-    // Old-style entry without sessionKey (pre-v4.12.3)
-    const oldPath = `${TEST_DATA_DIR}/old.jsonl`;
-    watcher.registerPendingAgent({
-      agentId: "old-agent",
-      outputFile: oldPath,
-      description: "old",
-      prompt: "p",
-      chatId: 2,
-      userId: 2,
-      toolUseId: null,
-      // sessionKey intentionally omitted
-    });
-
-    writeCompletedJsonl(newPath, "new done");
-    writeCompletedJsonl(oldPath, "old done");
-    await watcher.pollOnce();
-
-    // New agent decrements our counter; old agent is a no-op
-    expect(s.pendingBackgroundCount).toBe(0);
-    expect(watcher.listPendingAgents()).toHaveLength(0);
-  });
-
-  it("waitUntilProcessingFalse: flag flips right at the tick boundary", async () => {
-    const { waitUntilProcessingFalse } = await import(
-      "../src/handlers/background-bypass.js"
-    );
-    const session = { isProcessing: true };
-    // Start waiting, then flip asynchronously
-    const waitPromise = waitUntilProcessingFalse(session, 2000, 10);
-    setTimeout(() => { session.isProcessing = false; }, 15);
-    const result = await waitPromise;
-    expect(result).toBe(true);
-  });
-
-  it("waitUntilProcessingFalse: timeout respected", async () => {
-    const { waitUntilProcessingFalse } = await import(
-      "../src/handlers/background-bypass.js"
-    );
-    const session = { isProcessing: true };
-    const start = Date.now();
-    const result = await waitUntilProcessingFalse(session, 200, 25);
-    const elapsed = Date.now() - start;
-    expect(result).toBe(false);
-    expect(elapsed).toBeGreaterThanOrEqual(180); // allow small jitter
-    expect(elapsed).toBeLessThan(400);
-  });
-
-  it(
-    "high load: 50 sessions, each with 4 parallel agents (200 total) — " +
-      "all deliver, all counters return to 0",
-    async () => {
-      const { getSession } = await import("../src/services/session.js");
-      const { handleToolResultChunk } = await import(
-        "../src/handlers/async-agent-chunk-handler.js"
-      );
-      const watcher = await import("../src/services/async-agent-watcher.js");
-
-      const S = 50;
-      const A = 4;
-      const sessionKeys: string[] = [];
-      const allPaths: string[] = [];
-
-      for (let i = 0; i < S; i++) {
-        const sk = `load-s-${i}`;
-        sessionKeys.push(sk);
-        const s = getSession(sk);
-        s.pendingBackgroundCount = 0;
-
-        for (let j = 0; j < A; j++) {
-          const outPath = `${TEST_DATA_DIR}/load-${i}-${j}.jsonl`;
-          allPaths.push(outPath);
-          handleToolResultChunk(
-            {
-              type: "tool_result",
-              toolUseId: `load_${i}_${j}`,
-              toolResultContent:
-                "Async agent launched successfully.\n" +
-                `agentId: load-${i}-${j}\n` +
-                `output_file: ${outPath}\n`,
-            },
-            {
-              chatId: i,
-              userId: i,
-              sessionKey: sk,
-              lastToolUseInput: {
-                description: `task ${i}-${j}`,
-                prompt: "p",
-              },
-            },
-          );
-        }
-      }
-
-      // Every session has A agents pending
-      for (const sk of sessionKeys) {
-        expect(getSession(sk).pendingBackgroundCount).toBe(A);
-      }
-
-      // Deliver all
-      for (const p of allPaths) {
-        writeCompletedJsonl(p, "done");
-      }
-      await watcher.pollOnce();
-
-      // All counters back to 0
-      for (const sk of sessionKeys) {
-        expect(getSession(sk).pendingBackgroundCount).toBe(0);
-      }
-
-      // No residual state
-      expect(watcher.listPendingAgents()).toHaveLength(0);
-    },
-  );
-});

package/test/background-bypass.test.ts

@@ -1,127 +0,0 @@
-/**
- * v4.12.3 — background-bypass pure helpers.
- *
- * These helpers factor out the SDK-resume-bypass decision from the
- * message handler so it can be unit tested without grammy Context
- * mocks. The real handler composes these functions — they're only
- * state machines over session fields + time.
- */
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import {
-  shouldBypassQueue,
-  shouldBypassSdkResume,
-  waitUntilProcessingFalse,
-} from "../src/handlers/background-bypass.js";
-
-describe("shouldBypassQueue (v4.12.3)", () => {
-  it("returns false when session is not processing", () => {
-    expect(
-      shouldBypassQueue({
-        isProcessing: false,
-        pendingBackgroundCount: 5,
-        abortController: new AbortController(),
-      }),
-    ).toBe(false);
-  });
-
-  it("returns false when no background agent is pending", () => {
-    expect(
-      shouldBypassQueue({
-        isProcessing: true,
-        pendingBackgroundCount: 0,
-        abortController: new AbortController(),
-      }),
-    ).toBe(false);
-  });
-
-  it("returns false when no abortController exists (can't abort)", () => {
-    expect(
-      shouldBypassQueue({
-        isProcessing: true,
-        pendingBackgroundCount: 2,
-        abortController: null,
-      }),
-    ).toBe(false);
-  });
-
-  it("returns true when processing, background pending, and abortable", () => {
-    expect(
-      shouldBypassQueue({
-        isProcessing: true,
-        pendingBackgroundCount: 1,
-        abortController: new AbortController(),
-      }),
-    ).toBe(true);
-  });
-
-  it("returns true even with multiple pending agents", () => {
-    expect(
-      shouldBypassQueue({
-        isProcessing: true,
-        pendingBackgroundCount: 3,
-        abortController: new AbortController(),
-      }),
-    ).toBe(true);
-  });
-
-  it("returns false if abortController is already aborted — nothing left to abort", () => {
-    const ac = new AbortController();
-    ac.abort();
-    expect(
-      shouldBypassQueue({
-        isProcessing: true,
-        pendingBackgroundCount: 1,
-        abortController: ac,
-      }),
-    ).toBe(false);
-  });
-});
-
-describe("shouldBypassSdkResume (v4.12.3)", () => {
-  it("returns true when pendingBackgroundCount > 0 — old SDK session is blocked, need fresh", () => {
-    expect(shouldBypassSdkResume({ pendingBackgroundCount: 1 })).toBe(true);
-    expect(shouldBypassSdkResume({ pendingBackgroundCount: 5 })).toBe(true);
-  });
-
-  it("returns false when no background pending — safe to resume", () => {
-    expect(shouldBypassSdkResume({ pendingBackgroundCount: 0 })).toBe(false);
-  });
-});
-
-describe("waitUntilProcessingFalse (v4.12.3)", () => {
-  beforeEach(() => vi.useFakeTimers());
-  afterEach(() => vi.useRealTimers());
-
-  it("resolves immediately when already not processing", async () => {
-    const session = { isProcessing: false };
-    const p = waitUntilProcessingFalse(session, 5000);
-    await vi.advanceTimersByTimeAsync(0);
-    await expect(p).resolves.toBe(true);
-  });
-
-  it("waits until isProcessing flips, then resolves true", async () => {
-    const session = { isProcessing: true };
-    const p = waitUntilProcessingFalse(session, 5000);
-    await vi.advanceTimersByTimeAsync(200);
-    session.isProcessing = false;
-    await vi.advanceTimersByTimeAsync(100);
-    await expect(p).resolves.toBe(true);
-  });
-
-  it("gives up after timeout if still processing, resolves false", async () => {
-    const session = { isProcessing: true };
-    const p = waitUntilProcessingFalse(session, 1000);
-    await vi.advanceTimersByTimeAsync(1100);
-    await expect(p).resolves.toBe(false);
-  });
-
-  it("uses the provided tick interval (default 50ms)", async () => {
-    const session = { isProcessing: true };
-    const p = waitUntilProcessingFalse(session, 500, 25);
-    // Flip after 130ms of "waiting" — should detect on the next 25ms tick
-    await vi.advanceTimersByTimeAsync(130);
-    session.isProcessing = false;
-    await vi.advanceTimersByTimeAsync(30);
-    await expect(p).resolves.toBe(true);
-  });
-});

package/test/browser-webfetch.test.ts

@@ -1,121 +0,0 @@
-/**
- * Fix #11 (minimal) — webfetch Tier 0 for browser-manager.
- *
- * Background: the current browser fallback chain is
- *   gateway → cdp → hub-stealth → cli
- * Every tier spawns playwright (or talks to a CDP-controlled Chrome),
- * which is slow and occasionally impossible under load. Many scraping
- * tasks only need plain HTTP — an RSS feed, a JSON API, an OG meta-
- * tag sniff. For those, Node's native `fetch` is 100× faster and
- * doesn't need a browser at all.
- *
- * Contract: `webfetchNavigate(url)` returns `{ title, url }` for a
- * successful GET, or throws a distinct `WebfetchFailed` error that the
- * cascade can catch and fall through to the next tier. Title is the
- * first `<title>` tag content; if none, the URL is returned.
- *
- * Keep it small — this is a Tier 0 helper, not a full scraper.
- */
-import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
-import {
-  webfetchNavigate,
-  WebfetchFailed,
-  parseTitle,
-} from "../src/services/browser-webfetch.js";
-
-describe("parseTitle (Fix #11)", () => {
-  it("extracts a simple <title>", () => {
-    expect(parseTitle("<html><head><title>Hello World</title></head></html>")).toBe("Hello World");
-  });
-
-  it("handles whitespace and newlines", () => {
-    expect(parseTitle("<title>\n  Multi  line  \n</title>")).toBe("Multi line");
-  });
-
-  it("returns empty string when there's no title", () => {
-    expect(parseTitle("<html><body>no title</body></html>")).toBe("");
-  });
-
-  it("decodes basic HTML entities", () => {
-    expect(parseTitle("<title>A &amp; B</title>")).toBe("A & B");
-    expect(parseTitle("<title>&quot;quoted&quot;</title>")).toBe('"quoted"');
-  });
-
-  it("is case-insensitive for the tag name", () => {
-    expect(parseTitle("<HEAD><TITLE>Foo</TITLE></HEAD>")).toBe("Foo");
-  });
-});
-
-describe("webfetchNavigate (Fix #11)", () => {
-  let originalFetch: typeof fetch;
-
-  beforeEach(() => {
-    originalFetch = globalThis.fetch;
-  });
-  afterEach(() => {
-    globalThis.fetch = originalFetch;
-  });
-
-  it("returns title + url on a 200 response", async () => {
-    globalThis.fetch = vi.fn(async () =>
-      new Response(
-        "<html><head><title>GitHub · alvbln/alvin-bot</title></head></html>",
-        { status: 200, headers: { "content-type": "text/html" } },
-      ),
-    ) as unknown as typeof fetch;
-
-    const result = await webfetchNavigate("https://github.com/alvbln/alvin-bot");
-    expect(result.title).toBe("GitHub · alvbln/alvin-bot");
-    expect(result.url).toBe("https://github.com/alvbln/alvin-bot");
-  });
-
-  it("throws WebfetchFailed with the HTTP status on 4xx/5xx", async () => {
-    globalThis.fetch = vi.fn(async () =>
-      new Response("blocked", { status: 403 }),
-    ) as unknown as typeof fetch;
-
-    await expect(webfetchNavigate("https://example.com")).rejects.toThrow(WebfetchFailed);
-    try {
-      await webfetchNavigate("https://example.com");
-    } catch (err) {
-      expect((err as WebfetchFailed).status).toBe(403);
-    }
-  });
-
-  it("throws WebfetchFailed when the response is not HTML and forceHtml=true", async () => {
-    globalThis.fetch = vi.fn(async () =>
-      new Response('{"json":true}', {
-        status: 200,
-        headers: { "content-type": "application/json" },
-      }),
-    ) as unknown as typeof fetch;
-
-    await expect(
-      webfetchNavigate("https://api.example.com/data", { forceHtml: true }),
-    ).rejects.toThrow(WebfetchFailed);
-  });
-
-  it("accepts non-HTML responses when forceHtml is false (default)", async () => {
-    globalThis.fetch = vi.fn(async () =>
-      new Response("plain text", {
-        status: 200,
-        headers: { "content-type": "text/plain" },
-      }),
-    ) as unknown as typeof fetch;
-
-    const result = await webfetchNavigate("https://example.com/raw");
-    // No <title> in plain text → falls back to URL as display title
-    expect(result.url).toBe("https://example.com/raw");
-    expect(result.title).toBe("https://example.com/raw");
-  });
-
-  it("wraps network errors in WebfetchFailed so the cascade can catch a single type", async () => {
-    globalThis.fetch = vi.fn(async () => {
-      throw new Error("getaddrinfo ENOTFOUND nonexistent.invalid");
-    }) as unknown as typeof fetch;
-
-    await expect(
-      webfetchNavigate("https://nonexistent.invalid/"),
-    ).rejects.toThrow(WebfetchFailed);
-  });
-});