alvin-bot 4.18.0 → 4.18.2

package/test/subagent-delivery-markdown-fallback.test.ts

@@ -1,147 +0,0 @@
-/**
- * Fix #15 (A) — subagent-delivery must retry without parse_mode when
- * Telegram rejects the Markdown entities.
- *
- * Real regression: Daily Job Alert banners have been silently failing
- * with "Bad Request: can't parse entities: Can't find end of the entity"
- * every single day since the subagent-delivery module shipped. The
- * result text contains mixed `|`, `**`, `\|`, emoji, and asterisks that
- * Telegram's Markdown parser chokes on. The code currently logs the
- * error and drops the delivery, so the user never sees the banner.
- *
- * Contract: when `sendMessage(..., parse_mode: Markdown)` throws with
- * the "can't parse entities" pattern, retry the SAME text WITHOUT
- * `parse_mode`. Any other error still logs + bails.
- *
- * This file uses a minimal bot-api stub so we can drive both the happy
- * path and the parse-error path deterministically.
- */
-import { describe, it, expect, vi, beforeEach } from "vitest";
-import { deliverSubAgentResult, __setBotApiForTest } from "../src/services/subagent-delivery.js";
-import type { SubAgentInfo, SubAgentResult } from "../src/services/subagents.js";
-
-interface Sent {
-  chatId: number;
-  text: string;
-  parseMode?: string;
-}
-
-function makeInfo(overrides: Partial<SubAgentInfo> = {}): SubAgentInfo {
-  return {
-    id: "id-1",
-    name: "Daily Job Alert",
-    status: "completed",
-    startedAt: 0,
-    depth: 0,
-    source: "cron",
-    parentChatId: 42,
-    ...overrides,
-  };
-}
-
-function makeResult(output: string): SubAgentResult {
-  return {
-    id: "id-1",
-    name: "Daily Job Alert",
-    status: "completed",
-    output,
-    tokensUsed: { input: 1000, output: 200 },
-    duration: 60_000,
-  };
-}
-
-beforeEach(() => {
-  __setBotApiForTest(null);
-});
-
-describe("deliverSubAgentResult Markdown fallback (Fix #15)", () => {
-  it("retries without parse_mode when Telegram rejects entity parsing", async () => {
-    const sent: Sent[] = [];
-    let callCount = 0;
-
-    __setBotApiForTest({
-      sendMessage: async (chatId: number, text: string, opts?: Record<string, unknown>) => {
-        callCount++;
-        const parseMode = opts?.parse_mode as string | undefined;
-        // First call (Markdown) throws the real production error
-        if (callCount === 1 && parseMode === "Markdown") {
-          const err = Object.assign(
-            new Error("Call to 'sendMessage' failed! (400: Bad Request: can't parse entities: Can't find end of the entity starting at byte offset 2636)"),
-            {
-              description: "Bad Request: can't parse entities: Can't find end of the entity starting at byte offset 2636",
-              error_code: 400,
-            },
-          );
-          throw err;
-        }
-        sent.push({ chatId, text, parseMode });
-        return { message_id: 1 };
-      },
-      sendDocument: async () => ({}),
-    });
-
-    const info = makeInfo();
-    const result = makeResult("This **has** | broken markdown \\| entities that fail Markdown parsing");
-
-    await deliverSubAgentResult(info, result);
-
-    // Must have retried at least once WITHOUT parse_mode
-    const plainAttempt = sent.find((s) => s.parseMode === undefined);
-    expect(plainAttempt).toBeDefined();
-    expect(plainAttempt?.text).toContain("Daily Job Alert");
-    expect(plainAttempt?.text).toContain("broken markdown");
-  });
-
-  it("does NOT retry for non-parse errors (e.g. chat not found)", async () => {
-    let callCount = 0;
-    __setBotApiForTest({
-      sendMessage: async () => {
-        callCount++;
-        const err = Object.assign(new Error("Forbidden: bot was blocked by the user"), {
-          description: "Forbidden: bot was blocked by the user",
-          error_code: 403,
-        });
-        throw err;
-      },
-      sendDocument: async () => ({}),
-    });
-
-    await deliverSubAgentResult(makeInfo(), makeResult("some text"));
-
-    // Should have tried once and given up — no retry
-    expect(callCount).toBe(1);
-  });
-
-  it("chunked delivery also retries without parse_mode on parse errors", async () => {
-    const sent: Sent[] = [];
-    let callCount = 0;
-
-    __setBotApiForTest({
-      sendMessage: async (chatId: number, text: string, opts?: Record<string, unknown>) => {
-        callCount++;
-        const parseMode = opts?.parse_mode as string | undefined;
-        // First banner attempt fails — should retry without parse_mode
-        if (callCount === 1 && parseMode === "Markdown") {
-          const err = Object.assign(
-            new Error("400: Bad Request: can't parse entities"),
-            { description: "can't parse entities", error_code: 400 },
-          );
-          throw err;
-        }
-        sent.push({ chatId, text, parseMode });
-        return { message_id: callCount };
-      },
-      sendDocument: async () => ({}),
-    });
-
-    const info = makeInfo();
-    // Large body forces the chunked path
-    const result = makeResult("x".repeat(5000));
-
-    await deliverSubAgentResult(info, result);
-
-    // At least one plain-text delivery must have landed
-    expect(sent.length).toBeGreaterThan(0);
-    expect(sent.some((s) => s.parseMode === undefined)).toBe(true);
-  });
-});

package/test/subagent-delivery-platform-routing.test.ts

@@ -1,232 +0,0 @@
-/**
- * v4.14 — subagent-delivery platform routing tests.
- *
- * Covers the new v4.14 behavior: deliveries with `info.platform` other
- * than "telegram" go through the delivery-registry adapter instead of
- * the grammy bot API. Telegram path is unchanged and still uses the
- * injected grammy-compatible API.
- */
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-
-interface CapturedMsg {
-  chatId: string | number;
-  text: string;
-}
-
-beforeEach(() => vi.resetModules());
-
-async function loadModules() {
-  const delivery = await import("../src/services/subagent-delivery.js");
-  const registry = await import("../src/services/delivery-registry.js");
-  registry.__resetForTest();
-  return { delivery, registry };
-}
-
-describe("subagent-delivery platform routing (v4.14)", () => {
-  afterEach(async () => {
-    const { delivery, registry } = await loadModules();
-    delivery.__setBotApiForTest(null);
-    registry.__resetForTest();
-  });
-
-  it("info.platform='slack' routes via delivery-registry (NOT grammy api)", async () => {
-    const { delivery, registry } = await loadModules();
-
-    // Register fake Slack adapter
-    const sent: CapturedMsg[] = [];
-    registry.registerDeliveryAdapter({
-      platform: "slack",
-      sendText: async (chatId, text) => {
-        sent.push({ chatId, text });
-      },
-    });
-
-    // Set a grammy api that SHOULD NOT be called
-    const grammyCalls: CapturedMsg[] = [];
-    delivery.__setBotApiForTest({
-      sendMessage: async (chatId: number, text: string) => {
-        grammyCalls.push({ chatId, text });
-        return { message_id: 1 };
-      },
-      sendDocument: async () => ({ message_id: 1 }),
-    });
-
-    await delivery.deliverSubAgentResult(
-      {
-        id: "a1",
-        name: "Research task",
-        status: "completed",
-        startedAt: Date.now() - 5000,
-        source: "cron",
-        depth: 0,
-        parentChatId: "C012SLACKCH",
-        platform: "slack",
-      },
-      {
-        id: "a1",
-        name: "Research task",
-        status: "completed",
-        output: "Result body",
-        tokensUsed: { input: 100, output: 50 },
-        duration: 5000,
-      },
-    );
-
-    expect(sent).toHaveLength(1);
-    expect(sent[0].chatId).toBe("C012SLACKCH");
-    expect(sent[0].text).toContain("Research task");
-    expect(sent[0].text).toContain("Result body");
-    // grammy must NOT have been touched
-    expect(grammyCalls).toHaveLength(0);
-  });
-
-  it("info.platform='telegram' (default) still uses grammy api — behavior unchanged", async () => {
-    const { delivery, registry } = await loadModules();
-
-    // Register Slack adapter that SHOULD NOT be called
-    const slackCalls: CapturedMsg[] = [];
-    registry.registerDeliveryAdapter({
-      platform: "slack",
-      sendText: async (chatId, text) => slackCalls.push({ chatId, text }),
-    });
-
-    const grammyCalls: CapturedMsg[] = [];
-    delivery.__setBotApiForTest({
-      sendMessage: async (chatId: number, text: string) => {
-        grammyCalls.push({ chatId, text });
-        return { message_id: 1 };
-      },
-      sendDocument: async () => ({ message_id: 1 }),
-    });
-
-    await delivery.deliverSubAgentResult(
-      {
-        id: "a2",
-        name: "Telegram task",
-        status: "completed",
-        startedAt: Date.now() - 3000,
-        source: "cron",
-        depth: 0,
-        parentChatId: 1234567890,
-        // platform undefined → defaults to telegram
-      },
-      {
-        id: "a2",
-        name: "Telegram task",
-        status: "completed",
-        output: "Telegram body",
-        tokensUsed: { input: 10, output: 5 },
-        duration: 3000,
-      },
-    );
-
-    expect(grammyCalls).toHaveLength(1);
-    expect(grammyCalls[0].chatId).toBe(1234567890);
-    expect(grammyCalls[0].text).toContain("Telegram body");
-    // Slack adapter must NOT have been touched
-    expect(slackCalls).toHaveLength(0);
-  });
-
-  it("info.platform='discord' routes to discord adapter", async () => {
-    const { delivery, registry } = await loadModules();
-
-    const discordCalls: CapturedMsg[] = [];
-    registry.registerDeliveryAdapter({
-      platform: "discord",
-      sendText: async (chatId, text) =>
-        discordCalls.push({ chatId, text }),
-    });
-
-    await delivery.deliverSubAgentResult(
-      {
-        id: "a3",
-        name: "Discord task",
-        status: "completed",
-        startedAt: Date.now() - 1000,
-        source: "cron",
-        depth: 0,
-        parentChatId: "1234567890123456",
-        platform: "discord",
-      },
-      {
-        id: "a3",
-        name: "Discord task",
-        status: "completed",
-        output: "Discord body",
-        tokensUsed: { input: 1, output: 1 },
-        duration: 1000,
-      },
-    );
-
-    expect(discordCalls).toHaveLength(1);
-    expect(discordCalls[0].chatId).toBe("1234567890123456");
-  });
-
-  it("non-telegram platform with NO registered adapter skips delivery (no crash)", async () => {
-    const { delivery } = await loadModules();
-
-    await expect(
-      delivery.deliverSubAgentResult(
-        {
-          id: "a4",
-          name: "Orphan",
-          status: "completed",
-          startedAt: Date.now(),
-          source: "cron",
-          depth: 0,
-          parentChatId: "C999",
-          platform: "slack",
-        },
-        {
-          id: "a4",
-          name: "Orphan",
-          status: "completed",
-          output: "x",
-          tokensUsed: { input: 1, output: 1 },
-          duration: 100,
-        },
-      ),
-    ).resolves.not.toThrow();
-  });
-
-  it("long output triggers chunking on non-Telegram adapter", async () => {
-    const { delivery, registry } = await loadModules();
-
-    const sent: string[] = [];
-    registry.registerDeliveryAdapter({
-      platform: "slack",
-      sendText: async (_chatId, text) => {
-        sent.push(text);
-      },
-    });
-
-    // Build ~8000 chars of output (forces chunking at 3800)
-    const longBody = "x".repeat(8000);
-
-    await delivery.deliverSubAgentResult(
-      {
-        id: "a5",
-        name: "Long task",
-        status: "completed",
-        startedAt: Date.now(),
-        source: "cron",
-        depth: 0,
-        parentChatId: "C1",
-        platform: "slack",
-      },
-      {
-        id: "a5",
-        name: "Long task",
-        status: "completed",
-        output: longBody,
-        tokensUsed: { input: 1, output: 1 },
-        duration: 100,
-      },
-    );
-
-    // Expect: 1 banner + multiple body chunks
-    expect(sent.length).toBeGreaterThan(1);
-    const bodyBytes = sent.slice(1).join("").length;
-    expect(bodyBytes).toBe(longBody.length);
-  });
-});

package/test/subagent-delivery.test.ts

@@ -1,273 +0,0 @@
-import { describe, it, expect, beforeEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-import type { SubAgentInfo, SubAgentResult } from "../src/services/subagents.js";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-bot-delivery-${process.pid}-${Date.now()}`);
-
-const sentMessages: Array<{ chatId: number; text: string }> = [];
-const sentDocuments: Array<{ chatId: number }> = [];
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  sentMessages.length = 0;
-  sentDocuments.length = 0;
-  vi.resetModules();
-});
-
-async function wireFakeApi() {
-  const mod = await import("../src/services/subagent-delivery.js");
-  mod.__setBotApiForTest({
-    sendMessage: async (chatId: number, text: string) => {
-      sentMessages.push({ chatId, text });
-      return {};
-    },
-    sendDocument: async (chatId: number) => {
-      sentDocuments.push({ chatId });
-      return {};
-    },
-  });
-  return mod;
-}
-
-describe("subagent-delivery (I3)", () => {
-  it("does nothing for source='implicit' (parent-stream handles it)", async () => {
-    const mod = await wireFakeApi();
-
-    const info: SubAgentInfo = {
-      id: "x",
-      name: "impl",
-      status: "completed",
-      startedAt: Date.now() - 1000,
-      source: "implicit",
-      depth: 0,
-      parentChatId: 123,
-    };
-    const result: SubAgentResult = {
-      id: "x",
-      name: "impl",
-      status: "completed",
-      output: "anything",
-      tokensUsed: { input: 10, output: 5 },
-      duration: 1000,
-    };
-
-    await mod.deliverSubAgentResult(info, result);
-    expect(sentMessages).toHaveLength(0);
-    expect(sentDocuments).toHaveLength(0);
-  });
-
-  it("sends banner+final to parentChatId for source='user'", async () => {
-    const mod = await wireFakeApi();
-
-    const info: SubAgentInfo = {
-      id: "u",
-      name: "code-review",
-      status: "completed",
-      startedAt: Date.now() - 192000,
-      source: "user",
-      depth: 0,
-      parentChatId: 555,
-    };
-    const result: SubAgentResult = {
-      id: "u",
-      name: "code-review",
-      status: "completed",
-      output: "Found 2 issues:\n1. bug\n2. nit",
-      tokensUsed: { input: 4200, output: 2100 },
-      duration: 192000,
-    };
-
-    await mod.deliverSubAgentResult(info, result);
-    expect(sentMessages.length).toBeGreaterThanOrEqual(1);
-    const all = sentMessages.map((m) => m.text).join("\n");
-    expect(sentMessages[0].chatId).toBe(555);
-    expect(all).toContain("code-review");
-    expect(all).toContain("4.2k"); // token formatting
-    expect(all).toContain("2.1k");
-    expect(all).toContain("Found 2 issues");
-  });
-
-  it("splits long output into chunks (>3800 chars)", async () => {
-    const mod = await wireFakeApi();
-
-    const info: SubAgentInfo = {
-      id: "c",
-      name: "long",
-      status: "completed",
-      startedAt: Date.now() - 1000,
-      source: "user",
-      depth: 0,
-      parentChatId: 1,
-    };
-    const result: SubAgentResult = {
-      id: "c",
-      name: "long",
-      status: "completed",
-      output: "x".repeat(9000),
-      tokensUsed: { input: 0, output: 9000 },
-      duration: 1000,
-    };
-
-    await mod.deliverSubAgentResult(info, result);
-    // Expect: 1 banner + 3 content chunks (9000 / 3800 = 3 chunks)
-    expect(sentMessages.length).toBeGreaterThanOrEqual(3);
-  });
-
-  it("silent visibility produces no delivery", async () => {
-    const mod = await wireFakeApi();
-
-    const info: SubAgentInfo = {
-      id: "s",
-      name: "silent-job",
-      status: "completed",
-      startedAt: Date.now() - 1000,
-      source: "user",
-      depth: 0,
-      parentChatId: 1,
-    };
-    const result: SubAgentResult = {
-      id: "s",
-      name: "silent-job",
-      status: "completed",
-      output: "hello",
-      tokensUsed: { input: 1, output: 1 },
-      duration: 1000,
-    };
-
-    await mod.deliverSubAgentResult(info, result, { visibility: "silent" });
-    expect(sentMessages).toHaveLength(0);
-  });
-
-  it("missing parentChatId logs but does not throw", async () => {
-    const mod = await wireFakeApi();
-
-    const info: SubAgentInfo = {
-      id: "noparent",
-      name: "orphan",
-      status: "completed",
-      startedAt: Date.now() - 1000,
-      source: "user",
-      depth: 0,
-      // no parentChatId
-    };
-    const result: SubAgentResult = {
-      id: "noparent",
-      name: "orphan",
-      status: "completed",
-      output: "hi",
-      tokensUsed: { input: 0, output: 0 },
-      duration: 1000,
-    };
-
-    await expect(mod.deliverSubAgentResult(info, result)).resolves.toBeUndefined();
-    expect(sentMessages).toHaveLength(0);
-  });
-});
-
-describe("subagent-delivery LiveStream (A4)", () => {
-  const edits: Array<{ chatId: number; messageId: number; text: string }> = [];
-  let messageCounter = 100;
-
-  beforeEach(() => {
-    edits.length = 0;
-    messageCounter = 100;
-  });
-
-  async function wireLiveApi() {
-    const mod = await import("../src/services/subagent-delivery.js");
-    mod.__setBotApiForTest({
-      sendMessage: async (chatId: number, text: string) => {
-        sentMessages.push({ chatId, text });
-        return { message_id: messageCounter++ };
-      },
-      sendDocument: async (chatId: number) => {
-        sentDocuments.push({ chatId });
-        return {};
-      },
-      editMessageText: async (chatId: number, messageId: number, text: string) => {
-        edits.push({ chatId, messageId, text });
-        return {};
-      },
-    });
-    return mod;
-  }
-
-  it("start posts an initial 'thinking…' message and records messageId", async () => {
-    const mod = await wireLiveApi();
-    const stream = mod.createLiveStream(555, "code-review");
-    expect(stream).not.toBeNull();
-    await stream!.start();
-
-    expect(sentMessages).toHaveLength(1);
-    expect(sentMessages[0].chatId).toBe(555);
-    expect(sentMessages[0].text).toContain("thinking");
-    expect(stream!.failed).toBe(false);
-  });
-
-  it("update coalesces multiple rapid calls into a single throttled edit", async () => {
-    const mod = await wireLiveApi();
-    const stream = mod.createLiveStream(1, "fast");
-    await stream!.start();
-
-    stream!.update("hello");
-    stream!.update("hello world");
-    stream!.update("hello world and more");
-
-    // Wait for the throttle window to elapse
-    await new Promise((r) => setTimeout(r, 900));
-
-    // Should have produced exactly one edit with the LAST text
-    expect(edits.length).toBe(1);
-    expect(edits[0].text).toContain("hello world and more");
-  });
-
-  it("finalize posts a banner as a new message", async () => {
-    const mod = await wireLiveApi();
-    const stream = mod.createLiveStream(42, "done-agent");
-    await stream!.start();
-    stream!.update("final text");
-    await new Promise((r) => setTimeout(r, 900)); // let flush run
-
-    await stream!.finalize(
-      {
-        id: "x",
-        name: "done-agent",
-        status: "completed",
-        startedAt: Date.now() - 5000,
-        source: "user",
-        depth: 0,
-        parentChatId: 42,
-      },
-      {
-        id: "x",
-        name: "done-agent",
-        status: "completed",
-        output: "final text",
-        tokensUsed: { input: 100, output: 50 },
-        duration: 5000,
-      },
-    );
-
-    // Two sends total: initial "thinking…" + final banner
-    expect(sentMessages.length).toBe(2);
-    const banner = sentMessages[sentMessages.length - 1].text;
-    expect(banner).toContain("done-agent");
-    expect(banner).toContain("completed");
-  });
-
-  it("createLiveStream returns null when bot api lacks editMessageText", async () => {
-    const mod = await import("../src/services/subagent-delivery.js");
-    // Set an api that intentionally has no editMessageText
-    mod.__setBotApiForTest({
-      sendMessage: async () => ({ message_id: 1 }),
-      sendDocument: async () => ({}),
-      // no editMessageText
-    });
-    const stream = mod.createLiveStream(1, "no-edit");
-    expect(stream).toBeNull();
-  });
-});