alvin-bot 4.18.0 → 4.18.2

package/test/subagent-final-text.test.ts

@@ -1,132 +0,0 @@
-/**
- * Fix #5 — runSubAgent must preserve the full final text, even when the
- * stream ends on a tool_use or is aborted mid-stream.
- *
- * Regressions this closes:
- *
- *   (a) The SDK yields `text` chunks as accumulated strings, then tool
- *       calls, then more text, then finally a `done` chunk that ALSO
- *       carries the final accumulated text. The old runSubAgent read
- *       `text` from text-chunks only and ignored `done.text`. If the
- *       assistant's very last action was a tool call with no trailing
- *       text block, `finalText` kept the pre-tool text and the
- *       cron-jobs.json `lastResult` ended mid-sentence.
- *
- *   (b) When queryWithFallback threw mid-stream (provider aborted,
- *       network error, etc.), the catch block set `output: ""` —
- *       throwing away whatever text had already streamed in before the
- *       failure. Users saw an empty "(empty output)" delivery.
- *
- * Contract:
- *   - Output = last non-empty value observed from (text.text | done.text)
- *   - On error / abort: output = whatever we'd buffered so far (never "")
- */
-import { describe, it, expect, beforeEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-import type { StreamChunk } from "../src/providers/types.js";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-bot-finaltext-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  delete process.env.MAX_SUBAGENTS;
-  vi.resetModules();
-});
-
-function mockStream(chunks: StreamChunk[] | (() => AsyncIterable<StreamChunk>)) {
-  vi.doMock("../src/engine.js", () => ({
-    getRegistry: () => ({
-      queryWithFallback: typeof chunks === "function"
-        ? chunks
-        : async function* () { for (const c of chunks) yield c; },
-    }),
-  }));
-  vi.doMock("../src/services/subagent-delivery.js", () => ({
-    deliverSubAgentResult: async () => { /* no-op */ },
-    attachBotApi: () => {},
-    __setBotApiForTest: () => {},
-  }));
-}
-
-async function runAndGetResult(prompt = "test") {
-  const mod = await import("../src/services/subagents.js");
-  return new Promise<{ output: string; status: string; tokensUsed: { input: number; output: number } }>((resolveResult) => {
-    mod.spawnSubAgent({
-      name: "test-agent",
-      prompt,
-      source: "cron",
-      parentChatId: 1,
-      onComplete: (r) => resolveResult({
-        output: r.output,
-        status: r.status,
-        tokensUsed: r.tokensUsed,
-      }),
-    }).catch(() => { /* spawn errors handled elsewhere */ });
-  });
-}
-
-describe("runSubAgent finalText (Fix #5)", () => {
-  it("uses done.text as the authoritative final output", async () => {
-    mockStream([
-      { type: "text", text: "Working on it…" },
-      { type: "tool_use", toolName: "Bash" },
-      { type: "text", text: "Intermediate finding: 5 results." },
-      { type: "tool_use", toolName: "Write" },
-      // No trailing text chunk — the assistant ended on a tool call,
-      // then the done chunk carries the authoritative final text.
-      { type: "done", text: "Job complete. Report at /tmp/out.html", inputTokens: 100, outputTokens: 50 },
-    ]);
-    const r = await runAndGetResult();
-    expect(r.status).toBe("completed");
-    expect(r.output).toBe("Job complete. Report at /tmp/out.html");
-    expect(r.tokensUsed).toEqual({ input: 100, output: 50 });
-  });
-
-  it("falls back to last text chunk when done has no text", async () => {
-    mockStream([
-      { type: "text", text: "First sentence." },
-      { type: "text", text: "Second sentence." },
-      { type: "done", inputTokens: 10, outputTokens: 5 },
-    ]);
-    const r = await runAndGetResult();
-    expect(r.output).toBe("Second sentence.");
-  });
-
-  it("preserves buffered text when stream errors mid-way", async () => {
-    mockStream(async function* () {
-      yield { type: "text", text: "Partial progress so far…" };
-      yield { type: "tool_use", toolName: "Bash" };
-      throw new Error("network: socket hang up");
-    });
-    const r = await runAndGetResult();
-    // Status can legitimately be "error" or "cancelled" — but output
-    // must NOT be an empty string. That's the regression.
-    expect(r.output.length).toBeGreaterThan(0);
-    expect(r.output).toContain("Partial progress");
-  });
-
-  it("preserves buffered text when the provider yields an error chunk", async () => {
-    mockStream([
-      { type: "text", text: "Started the task." },
-      { type: "text", text: "Started the task. More detail here." },
-      { type: "error", error: "Provider 'claude-sdk' failed: Request aborted" },
-    ]);
-    const r = await runAndGetResult();
-    expect(r.output).toContain("More detail");
-  });
-
-  it("returns empty output gracefully when nothing was buffered", async () => {
-    mockStream(async function* () {
-      throw new Error("immediate failure");
-    });
-    const r = await runAndGetResult();
-    // No text at all → empty is acceptable (nothing to preserve), but
-    // status must reflect the failure.
-    expect(r.output).toBe("");
-    expect(["error", "cancelled", "timeout"]).toContain(r.status);
-  });
-});

package/test/subagent-stats.test.ts

@@ -1,119 +0,0 @@
-import { describe, it, expect, beforeEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-import type { SubAgentInfo, SubAgentResult } from "../src/services/subagents.js";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-bot-stats-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  vi.resetModules();
-});
-
-function makeInfo(overrides: Partial<SubAgentInfo> = {}): SubAgentInfo {
-  return {
-    id: "x",
-    name: "test",
-    status: "completed",
-    startedAt: Date.now() - 1000,
-    source: "user",
-    depth: 0,
-    ...overrides,
-  };
-}
-
-function makeResult(overrides: Partial<SubAgentResult> = {}): SubAgentResult {
-  return {
-    id: "x",
-    name: "test",
-    status: "completed",
-    output: "ok",
-    tokensUsed: { input: 100, output: 50 },
-    duration: 1000,
-    ...overrides,
-  };
-}
-
-describe("subagent-stats (H3)", () => {
-  it("getSubAgentStats returns zeros on a fresh install", async () => {
-    const mod = await import("../src/services/subagent-stats.js");
-    const stats = mod.getSubAgentStats();
-    expect(stats.total.runs).toBe(0);
-    expect(stats.bySource.user.runs).toBe(0);
-    expect(stats.byStatus.completed).toBe(0);
-  });
-
-  it("recordSubAgentRun appends and updates totals", async () => {
-    const mod = await import("../src/services/subagent-stats.js");
-    mod.recordSubAgentRun(makeInfo({ source: "user" }), makeResult({ tokensUsed: { input: 100, output: 50 } }));
-    mod.recordSubAgentRun(makeInfo({ source: "cron" }), makeResult({ tokensUsed: { input: 200, output: 75 } }));
-    mod.recordSubAgentRun(makeInfo({ source: "user" }), makeResult({ tokensUsed: { input: 50, output: 25 } }));
-
-    const stats = mod.getSubAgentStats();
-    expect(stats.total.runs).toBe(3);
-    expect(stats.total.inputTokens).toBe(350);
-    expect(stats.total.outputTokens).toBe(150);
-    expect(stats.bySource.user.runs).toBe(2);
-    expect(stats.bySource.user.inputTokens).toBe(150);
-    expect(stats.bySource.cron.runs).toBe(1);
-    expect(stats.bySource.cron.inputTokens).toBe(200);
-    expect(stats.byStatus.completed).toBe(3);
-  });
-
-  it("persists to disk and round-trips through reload", async () => {
-    let mod = await import("../src/services/subagent-stats.js");
-    mod.recordSubAgentRun(makeInfo({ source: "cron" }), makeResult());
-
-    // Force a reload by resetting modules
-    vi.resetModules();
-    mod = await import("../src/services/subagent-stats.js");
-
-    const stats = mod.getSubAgentStats();
-    expect(stats.total.runs).toBe(1);
-    expect(stats.bySource.cron.runs).toBe(1);
-  });
-
-  it("prunes entries older than 24h", async () => {
-    const mod = await import("../src/services/subagent-stats.js");
-    // Seed the file with an entry from 25 hours ago
-    const ancient = [
-      {
-        completedAt: Date.now() - 25 * 60 * 60 * 1000,
-        name: "ancient",
-        source: "user",
-        status: "completed",
-        durationMs: 100,
-        inputTokens: 999,
-        outputTokens: 999,
-      },
-    ];
-    fs.writeFileSync(
-      resolve(TEST_DATA_DIR, "subagent-stats.json"),
-      JSON.stringify(ancient),
-    );
-    mod.__resetStatsCacheForTest();
-
-    // Fresh read should exclude the ancient entry
-    const stats = mod.getSubAgentStats();
-    expect(stats.total.runs).toBe(0);
-    expect(stats.total.inputTokens).toBe(0);
-  });
-
-  it("tracks byStatus separately for cancelled/error/timeout", async () => {
-    const mod = await import("../src/services/subagent-stats.js");
-    mod.recordSubAgentRun(makeInfo(), makeResult({ status: "completed" }));
-    mod.recordSubAgentRun(makeInfo(), makeResult({ status: "cancelled" }));
-    mod.recordSubAgentRun(makeInfo(), makeResult({ status: "error" }));
-    mod.recordSubAgentRun(makeInfo(), makeResult({ status: "timeout" }));
-    mod.recordSubAgentRun(makeInfo(), makeResult({ status: "completed" }));
-
-    const stats = mod.getSubAgentStats();
-    expect(stats.byStatus.completed).toBe(2);
-    expect(stats.byStatus.cancelled).toBe(1);
-    expect(stats.byStatus.error).toBe(1);
-    expect(stats.byStatus.timeout).toBe(1);
-  });
-});

package/test/subagent-toolset-allowlist.test.ts

@@ -1,146 +0,0 @@
-/**
- * v4.12.2 — Sub-agent toolset allowlist (Task G).
- *
- * Sub-agents can now be spawned with a toolset preset that restricts which
- * tools Claude has access to:
- *   - "full"     — all tools (default, matches pre-v4.12.2 behavior)
- *   - "readonly" — Read, Glob, Grep (analyze, no write, no shell, no net)
- *   - "research" — Read, Glob, Grep, WebSearch, WebFetch (no write, no shell)
- *
- * This test verifies that the preset → allowedTools mapping is correct
- * and that the provider honors the override. The integration path
- * (spawnSubAgent → registry.queryWithFallback → claude-sdk-provider) is
- * exercised via mocked SDK.
- */
-import { describe, it, expect, vi, beforeEach } from "vitest";
-import type { StreamChunk } from "../src/providers/types.js";
-
-beforeEach(() => vi.resetModules());
-
-describe("claude-sdk-provider honors options.allowedTools (v4.12.2)", () => {
-  it("uses the default full toolset when options.allowedTools is undefined", async () => {
-    let capturedOpts: Record<string, unknown> | undefined;
-    vi.doMock("../src/find-claude-binary.js", () => ({
-      findClaudeBinary: () => "/usr/bin/false",
-    }));
-    vi.doMock("@anthropic-ai/claude-agent-sdk", () => ({
-      query: (opts: { options: Record<string, unknown> }) => {
-        capturedOpts = opts.options;
-        return (async function* () {
-          yield { type: "system", subtype: "init", session_id: "s1" };
-          yield { type: "result", session_id: "s1", total_cost_usd: 0, usage: null };
-        })();
-      },
-    }));
-
-    const { ClaudeSDKProvider } = await import("../src/providers/claude-sdk-provider.js");
-    const provider = new ClaudeSDKProvider();
-
-    for await (const _c of provider.query({ prompt: "test", systemPrompt: "test" })) {
-      void _c;
-    }
-
-    expect(capturedOpts).toBeDefined();
-    expect(capturedOpts!.allowedTools).toEqual([
-      "Read", "Write", "Edit", "Bash", "Glob", "Grep",
-      "WebSearch", "WebFetch", "Task",
-    ]);
-  });
-
-  it("overrides allowedTools when caller passes a restricted list (readonly preset)", async () => {
-    let capturedOpts: Record<string, unknown> | undefined;
-    vi.doMock("../src/find-claude-binary.js", () => ({
-      findClaudeBinary: () => "/usr/bin/false",
-    }));
-    vi.doMock("@anthropic-ai/claude-agent-sdk", () => ({
-      query: (opts: { options: Record<string, unknown> }) => {
-        capturedOpts = opts.options;
-        return (async function* () {
-          yield { type: "system", subtype: "init", session_id: "s1" };
-          yield { type: "result", session_id: "s1", total_cost_usd: 0, usage: null };
-        })();
-      },
-    }));
-
-    const { ClaudeSDKProvider } = await import("../src/providers/claude-sdk-provider.js");
-    const provider = new ClaudeSDKProvider();
-
-    const readonlyTools = ["Read", "Glob", "Grep"];
-    for await (const _c of provider.query({
-      prompt: "test",
-      systemPrompt: "test",
-      allowedTools: readonlyTools,
-    })) {
-      void _c;
-    }
-
-    expect(capturedOpts!.allowedTools).toEqual(readonlyTools);
-    // Critically: Bash, Write, Edit are NOT in the list
-    expect(capturedOpts!.allowedTools).not.toContain("Bash");
-    expect(capturedOpts!.allowedTools).not.toContain("Write");
-    expect(capturedOpts!.allowedTools).not.toContain("Edit");
-  });
-
-  it("overrides allowedTools with research preset (adds web tools)", async () => {
-    let capturedOpts: Record<string, unknown> | undefined;
-    vi.doMock("../src/find-claude-binary.js", () => ({
-      findClaudeBinary: () => "/usr/bin/false",
-    }));
-    vi.doMock("@anthropic-ai/claude-agent-sdk", () => ({
-      query: (opts: { options: Record<string, unknown> }) => {
-        capturedOpts = opts.options;
-        return (async function* () {
-          yield { type: "system", subtype: "init", session_id: "s1" };
-          yield { type: "result", session_id: "s1", total_cost_usd: 0, usage: null };
-        })();
-      },
-    }));
-
-    const { ClaudeSDKProvider } = await import("../src/providers/claude-sdk-provider.js");
-    const provider = new ClaudeSDKProvider();
-
-    const researchTools = ["Read", "Glob", "Grep", "WebSearch", "WebFetch"];
-    for await (const _c of provider.query({
-      prompt: "test",
-      systemPrompt: "test",
-      allowedTools: researchTools,
-    })) {
-      void _c;
-    }
-
-    expect(capturedOpts!.allowedTools).toEqual(researchTools);
-    expect(capturedOpts!.allowedTools).toContain("WebSearch");
-    expect(capturedOpts!.allowedTools).not.toContain("Bash");
-  });
-
-  it("empty allowedTools array is honored as such (no tools at all)", async () => {
-    let capturedOpts: Record<string, unknown> | undefined;
-    vi.doMock("../src/find-claude-binary.js", () => ({
-      findClaudeBinary: () => "/usr/bin/false",
-    }));
-    vi.doMock("@anthropic-ai/claude-agent-sdk", () => ({
-      query: (opts: { options: Record<string, unknown> }) => {
-        capturedOpts = opts.options;
-        return (async function* () {
-          yield { type: "system", subtype: "init", session_id: "s1" };
-          yield { type: "result", session_id: "s1", total_cost_usd: 0, usage: null };
-        })();
-      },
-    }));
-
-    const { ClaudeSDKProvider } = await import("../src/providers/claude-sdk-provider.js");
-    const provider = new ClaudeSDKProvider();
-
-    for await (const _c of provider.query({
-      prompt: "test",
-      systemPrompt: "test",
-      allowedTools: [],
-    })) {
-      void _c;
-    }
-
-    // Empty array → no tools. Note: JS ?? operator treats [] as truthy,
-    // so this IS honored as "empty allowlist" not "use default".
-    expect(capturedOpts!.allowedTools).toEqual([]);
-  });
-});

package/test/subagents-commands.test.ts

@@ -1,64 +0,0 @@
-import { describe, it, expect, beforeEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-bot-cmds-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  delete process.env.MAX_SUBAGENTS;
-  vi.resetModules();
-});
-
-vi.mock("../src/engine.js", () => ({
-  getRegistry: () => ({
-    queryWithFallback: async function* () {
-      await new Promise((r) => setTimeout(r, 500));
-      yield { type: "done", text: "ok", inputTokens: 0, outputTokens: 0 };
-    },
-  }),
-}));
-
-describe("cancelSubAgentByName / getSubAgentResultByName (B2 helpers)", () => {
-  it("cancels an agent by its exact name", async () => {
-    const mod = await import("../src/services/subagents.js");
-    const id = await mod.spawnSubAgent({ name: "foo", prompt: "a" });
-    const ok = mod.cancelSubAgentByName("foo");
-    expect(ok).toBe(true);
-
-    const info = mod.listSubAgents().find((a) => a.id === id);
-    expect(info?.status).toBe("cancelled");
-  });
-
-  it("cancels the base-name when unambiguous", async () => {
-    const mod = await import("../src/services/subagents.js");
-    await mod.spawnSubAgent({ name: "bar", prompt: "a" });
-    expect(mod.cancelSubAgentByName("bar")).toBe(true);
-  });
-
-  it("returns false for unknown name", async () => {
-    const mod = await import("../src/services/subagents.js");
-    expect(mod.cancelSubAgentByName("ghost")).toBe(false);
-  });
-
-  it("cancels the #N variant when addressed directly", async () => {
-    const mod = await import("../src/services/subagents.js");
-    await mod.spawnSubAgent({ name: "baz", prompt: "a" });
-    await mod.spawnSubAgent({ name: "baz", prompt: "b" });
-    const ok = mod.cancelSubAgentByName("baz#2");
-    expect(ok).toBe(true);
-
-    const agents = mod.listSubAgents();
-    const canceledNames = agents.filter((a) => a.status === "cancelled").map((a) => a.name);
-    expect(canceledNames).toEqual(["baz#2"]);
-  });
-
-  it("getSubAgentResultByName returns null when still running", async () => {
-    const mod = await import("../src/services/subagents.js");
-    await mod.spawnSubAgent({ name: "running", prompt: "a" });
-    expect(mod.getSubAgentResultByName("running")).toBeNull();
-  });
-});

package/test/subagents-config.test.ts

@@ -1,114 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import fs from "fs";
-import { resolve } from "path";
-import os from "os";
-
-/**
- * Tests for the file-backed sub-agents config.
- *
- * We isolate via ALVIN_DATA_DIR pointing at a temp directory, so the test
- * never touches the real ~/.alvin-bot/sub-agents.json. vi.resetModules()
- * clears Vitest's module cache between tests so each import() gets a
- * fresh module with a fresh configCache.
- */
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-bot-test-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) {
-    fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  }
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  delete process.env.MAX_SUBAGENTS;
-  vi.resetModules(); // force re-import of subagents.ts next time
-});
-
-afterEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) {
-    fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  }
-});
-
-describe("sub-agents config", () => {
-  it("returns 0 as the configured value on a fresh install", async () => {
-    const mod = await import("../src/services/subagents.js");
-    expect(mod.getConfiguredMaxParallel()).toBe(0);
-  });
-
-  it("resolves 0 to min(cpuCount, 16) in getMaxParallelAgents", async () => {
-    const mod = await import("../src/services/subagents.js");
-    const effective = mod.getMaxParallelAgents();
-    const cpuCount = os.cpus().length;
-    expect(effective).toBe(Math.min(cpuCount, 16));
-  });
-
-  it("setMaxParallelAgents persists the value to disk", async () => {
-    const mod = await import("../src/services/subagents.js");
-    mod.setMaxParallelAgents(5);
-    expect(mod.getConfiguredMaxParallel()).toBe(5);
-    expect(mod.getMaxParallelAgents()).toBe(5);
-
-    // Verify file on disk
-    const configPath = resolve(TEST_DATA_DIR, "sub-agents.json");
-    expect(fs.existsSync(configPath)).toBe(true);
-    const persisted = JSON.parse(fs.readFileSync(configPath, "utf-8"));
-    expect(persisted.maxParallel).toBe(5);
-  });
-
-  it("clamps values above ABSOLUTE_MAX (16) down to 16", async () => {
-    const mod = await import("../src/services/subagents.js");
-    const effective = mod.setMaxParallelAgents(500);
-    expect(effective).toBe(16);
-    expect(mod.getConfiguredMaxParallel()).toBe(16);
-  });
-
-  it("clamps negative values to 0 (which then resolves to auto)", async () => {
-    const mod = await import("../src/services/subagents.js");
-    const effective = mod.setMaxParallelAgents(-5);
-    expect(mod.getConfiguredMaxParallel()).toBe(0);
-    expect(effective).toBe(Math.min(os.cpus().length, 16));
-  });
-
-  it("floors fractional values", async () => {
-    const mod = await import("../src/services/subagents.js");
-    mod.setMaxParallelAgents(7.8);
-    expect(mod.getConfiguredMaxParallel()).toBe(7);
-  });
-});
-
-describe("sub-agents visibility config (A4)", () => {
-  it("defaults visibility to 'auto' on a fresh install", async () => {
-    const mod = await import("../src/services/subagents.js");
-    expect(mod.getVisibility()).toBe("auto");
-  });
-
-  it("setVisibility persists the value to disk", async () => {
-    const mod = await import("../src/services/subagents.js");
-    mod.setVisibility("banner");
-    expect(mod.getVisibility()).toBe("banner");
-
-    const configPath = resolve(TEST_DATA_DIR, "sub-agents.json");
-    expect(fs.existsSync(configPath)).toBe(true);
-    const persisted = JSON.parse(fs.readFileSync(configPath, "utf-8"));
-    expect(persisted.visibility).toBe("banner");
-  });
-
-  it("rejects invalid visibility values", async () => {
-    const mod = await import("../src/services/subagents.js");
-    expect(() => mod.setVisibility("bogus" as "auto")).toThrow(/invalid/i);
-  });
-
-  it("accepts 'live' as a valid visibility mode (A4 Stufe 2)", async () => {
-    const mod = await import("../src/services/subagents.js");
-    mod.setVisibility("live");
-    expect(mod.getVisibility()).toBe("live");
-  });
-
-  it("setVisibility('auto') round-trips through disk", async () => {
-    const mod = await import("../src/services/subagents.js");
-    mod.setVisibility("banner");
-    mod.setVisibility("auto");
-    expect(mod.getVisibility()).toBe("auto");
-  });
-});

package/test/subagents-depth.test.ts

@@ -1,58 +0,0 @@
-import { describe, it, expect, beforeEach, vi } from "vitest";
-import fs from "fs";
-import os from "os";
-import { resolve } from "path";
-
-const TEST_DATA_DIR = resolve(os.tmpdir(), `alvin-bot-depth-${process.pid}-${Date.now()}`);
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DATA_DIR)) fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
-  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
-  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
-  delete process.env.MAX_SUBAGENTS;
-  vi.resetModules();
-});
-
-// Stub the engine so spawnSubAgent doesn't actually invoke any LLM.
-vi.mock("../src/engine.js", () => ({
-  getRegistry: () => ({
-    queryWithFallback: async function* () {
-      yield { type: "text", text: "ok" };
-      yield { type: "done", text: "ok", inputTokens: 1, outputTokens: 1 };
-    },
-  }),
-}));
-
-describe("sub-agents depth-cap (F2)", () => {
-  it("accepts depth 0 (root)", async () => {
-    const mod = await import("../src/services/subagents.js");
-    const id = await mod.spawnSubAgent({ name: "d0", prompt: "hi", depth: 0 });
-    expect(id).toMatch(/^[0-9a-f-]{36}$/);
-  });
-
-  it("accepts depth 1", async () => {
-    const mod = await import("../src/services/subagents.js");
-    const id = await mod.spawnSubAgent({ name: "d1", prompt: "hi", depth: 1 });
-    expect(id).toMatch(/^[0-9a-f-]{36}$/);
-  });
-
-  it("accepts depth 2 (the cap)", async () => {
-    const mod = await import("../src/services/subagents.js");
-    const id = await mod.spawnSubAgent({ name: "d2", prompt: "hi", depth: 2 });
-    expect(id).toMatch(/^[0-9a-f-]{36}$/);
-  });
-
-  it("rejects depth 3 with a clear error", async () => {
-    const mod = await import("../src/services/subagents.js");
-    await expect(
-      mod.spawnSubAgent({ name: "d3", prompt: "hi", depth: 3 }),
-    ).rejects.toThrow(/depth limit/i);
-  });
-
-  it("defaults depth to 0 when omitted", async () => {
-    const mod = await import("../src/services/subagents.js");
-    const id = await mod.spawnSubAgent({ name: "nodepth", prompt: "hi" });
-    const info = mod.listSubAgents().find((a) => a.id === id);
-    expect(info?.depth).toBe(0);
-  });
-});