agentic-orchestrator 0.1.6 → 0.1.8

package/apps/control-plane/src/application/services/notifier-service.ts

@@ -54,7 +54,7 @@ export interface NotificationConfig {
 const DEFAULT_ROUTING: Record<NotificationPriority, string[]> = {
   critical: ['desktop', 'slack'],
   warning: ['slack', 'desktop'],
-  info: ['slack']
+  info: ['slack'],
 };
 
 const EVENT_PRIORITY: Record<NotificationEvent, CanonicalPriority> = {
@@ -67,7 +67,7 @@ const EVENT_PRIORITY: Record<NotificationEvent, CanonicalPriority> = {
   agent_stuck: 'warning',
   changes_requested: 'warning',
   budget_exceeded: 'critical',
-  budget_alert: 'warning'
+  budget_alert: 'warning',
 };
 
 const THROTTLE_WINDOW_MS = 5 * 60 * 1000; // 5 minutes
@@ -116,17 +116,22 @@ export class SlackNotifierChannel implements NotifierChannel {
           : null;
     const detailsJson = JSON.stringify(details);
     const detailsSuffix =
-      detailsJson !== '{}' ? `\nContext: \`${detailsJson.length > 800 ? `${detailsJson.slice(0, 800)}…` : detailsJson}\`` : '';
+      detailsJson !== '{}'
+        ? `\nContext: \`${detailsJson.length > 800 ? `${detailsJson.slice(0, 800)}…` : detailsJson}\``
+        : '';
     const dashboardSuffix = dashboardFeatureUrl ? `\nDashboard: ${dashboardFeatureUrl}` : '';
     const text = payload.feature_id
       ? `*[${payload.priority.toUpperCase()}]* \`${payload.feature_id}\`: ${payload.message}`
       : `*[${payload.priority.toUpperCase()}]* ${payload.message}`;
 
-    const body = JSON.stringify({ channel: this.channel, text: `${text}${dashboardSuffix}${detailsSuffix}` });
+    const body = JSON.stringify({
+      channel: this.channel,
+      text: `${text}${dashboardSuffix}${detailsSuffix}`,
+    });
     const response = await fetch(this.webhookUrl, {
       method: 'POST',
       headers: { 'Content-Type': 'application/json' },
-      body
+      body,
     });
     if (!response.ok) {
       throw new Error(`Slack webhook returned ${response.status}`);
@@ -146,7 +151,7 @@ export class WebhookNotifierChannel implements NotifierChannel {
     const response = await fetch(this.url, {
       method: 'POST',
       headers: { 'Content-Type': 'application/json' },
-      body: JSON.stringify(payload)
+      body: JSON.stringify(payload),
     });
     if (!response.ok) {
       throw new Error(`Webhook returned ${response.status}`);
@@ -169,16 +174,21 @@ export class NotifierService {
     this.dashboardUrl = dashboardUrl;
   }
 
-  private buildRouting(routing: NotificationRoutingConfig | undefined): Record<CanonicalPriority, string[]> {
-    const critical = routing?.critical ?? routing?.urgent ?? routing?.action ?? DEFAULT_ROUTING.critical;
+  private buildRouting(
+    routing: NotificationRoutingConfig | undefined,
+  ): Record<CanonicalPriority, string[]> {
+    const critical =
+      routing?.critical ?? routing?.urgent ?? routing?.action ?? DEFAULT_ROUTING.critical;
     return {
       critical,
       warning: routing?.warning ?? DEFAULT_ROUTING.warning,
-      info: routing?.info ?? DEFAULT_ROUTING.info
+      info: routing?.info ?? DEFAULT_ROUTING.info,
     };
   }
 
-  private buildChannels(channelsConfig: NotificationChannelConfig | undefined): Map<string, NotifierChannel> {
+  private buildChannels(
+    channelsConfig: NotificationChannelConfig | undefined,
+  ): Map<string, NotifierChannel> {
     const map = new Map<string, NotifierChannel>();
     if (!channelsConfig) {
       return map;
@@ -214,7 +224,7 @@ export class NotifierService {
 
   async notify(
     event: NotificationEvent,
-    context: { feature_id?: string; message: string; details?: Record<string, unknown> }
+    context: { feature_id?: string; message: string; details?: Record<string, unknown> },
   ): Promise<void> {
     if (!this.config.enabled) {
       return;
@@ -225,7 +235,7 @@ export class NotifierService {
 
     const priority = EVENT_PRIORITY[event];
     const details: Record<string, unknown> = {
-      ...(context.details ?? {})
+      ...(context.details ?? {}),
     };
     if (this.dashboardUrl) {
       details.dashboard_url = this.dashboardUrl;
@@ -239,7 +249,7 @@ export class NotifierService {
       feature_id: context.feature_id,
       message: context.message,
       details,
-      timestamp: new Date().toISOString()
+      timestamp: new Date().toISOString(),
     };
 
     const targetChannelNames = this.routing[priority] ?? [];
@@ -260,7 +270,7 @@ export class NotifierService {
 
 export function createNotifierService(
   policySnapshot: Record<string, unknown>,
-  preferredChannel: string | null = null
+  preferredChannel: string | null = null,
 ): NotifierService {
   const raw = policySnapshot.notifications;
   if (!raw || typeof raw !== 'object') {
@@ -270,15 +280,24 @@ export function createNotifierService(
   const config: NotificationConfig = {
     enabled: n.enabled === true,
     channels: (n.channels as NotificationChannelConfig | undefined) ?? {},
-    routing: (n.routing as NotificationRoutingConfig | undefined) ?? {}
+    routing: (n.routing as NotificationRoutingConfig | undefined) ?? {},
   };
   if (preferredChannel) {
     const channels = config.channels ?? {};
     const forceEnabled = { enabled: true };
     config.channels = {
-      desktop: preferredChannel === 'desktop' ? { ...(channels.desktop ?? {}), ...forceEnabled } : { enabled: false },
-      slack: preferredChannel === 'slack' ? { ...(channels.slack ?? {}), ...forceEnabled } : { enabled: false },
-      webhook: preferredChannel === 'webhook' ? { ...(channels.webhook ?? {}), ...forceEnabled } : { enabled: false }
+      desktop:
+        preferredChannel === 'desktop'
+          ? { ...(channels.desktop ?? {}), ...forceEnabled }
+          : { enabled: false },
+      slack:
+        preferredChannel === 'slack'
+          ? { ...(channels.slack ?? {}), ...forceEnabled }
+          : { enabled: false },
+      webhook:
+        preferredChannel === 'webhook'
+          ? { ...(channels.webhook ?? {}), ...forceEnabled }
+          : { enabled: false },
     };
   }
   const dashboardRaw =
@@ -286,9 +305,12 @@ export function createNotifierService(
       ? (policySnapshot.dashboard as Record<string, unknown>)
       : {};
   const dashboardPort =
-    typeof dashboardRaw.port === 'number' && Number.isFinite(dashboardRaw.port) ? Math.floor(dashboardRaw.port) : 3000;
+    typeof dashboardRaw.port === 'number' && Number.isFinite(dashboardRaw.port)
+      ? Math.floor(dashboardRaw.port)
+      : 3000;
   const dashboardUrl =
-    typeof process.env.AOP_DASHBOARD_URL === 'string' && process.env.AOP_DASHBOARD_URL.trim().length > 0
+    typeof process.env.AOP_DASHBOARD_URL === 'string' &&
+    process.env.AOP_DASHBOARD_URL.trim().length > 0
       ? process.env.AOP_DASHBOARD_URL.trim()
       : `http://localhost:${dashboardPort}`;
   return new NotifierService(config, dashboardUrl);

package/apps/control-plane/src/application/services/patch-service.ts

@@ -1,18 +1,22 @@
 import path from 'node:path';
-import {atomicWriteJson, readJson} from '../../core/fs.js';
-import {parseUnifiedDiff, touchedPathsFromDiff} from '../../core/patch.js';
-import {anyAreaMatch, normalizeRepoPath, sortResourcesDeterministically} from '../../core/path-rules.js';
-import {runGit} from '../../core/git.js';
-import {buildQaIndex, makeRequiredTests} from '../../core/qa-index.js';
-import {ERROR_CODES} from '../../core/error-codes.js';
-import {fail} from '../../core/response.js';
+import { atomicWriteJson, readJson } from '../../core/fs.js';
+import { parseUnifiedDiff, touchedPathsFromDiff } from '../../core/patch.js';
+import {
+  anyAreaMatch,
+  normalizeRepoPath,
+  sortResourcesDeterministically,
+} from '../../core/path-rules.js';
+import { runGit } from '../../core/git.js';
+import { buildQaIndex, makeRequiredTests } from '../../core/qa-index.js';
+import { ERROR_CODES } from '../../core/error-codes.js';
+import { fail } from '../../core/response.js';
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 type AnyRecord = Record<string, any>;
 
 type StateUpdater = (
   frontMatter: AnyRecord,
-  body: string
+  body: string,
 ) => Promise<{ frontMatter?: AnyRecord; body?: string }>;
 
 function asArray<T = unknown>(value: unknown): T[] {
@@ -29,7 +33,11 @@ function readHeldLocks(frontMatter: AnyRecord): string[] {
   return asArray<string>(locks.held).filter((item) => typeof item === 'string');
 }
 
-function normalizeFromWorktree(worktreePath: string, repoRoot: string, repoRelativeFromWorktree: string): string {
+function normalizeFromWorktree(
+  worktreePath: string,
+  repoRoot: string,
+  repoRelativeFromWorktree: string,
+): string {
   const absolute = path.resolve(repoRoot, repoRelativeFromWorktree);
   const maybeRelativeToWorktree = path.relative(worktreePath, absolute).replaceAll('\\\\', '/');
   if (!maybeRelativeToWorktree.startsWith('../')) {
@@ -47,7 +55,11 @@ export interface PatchServicePort {
   worktreePath(featureId: string): string;
   readState(featureId: string): Promise<{ frontMatter: AnyRecord }>;
   validateSchema(schemaName: string, value: unknown): Promise<{ valid: boolean; errors?: unknown }>;
-  updateState(featureId: string, expectedVersion: number | null, updater: StateUpdater): Promise<AnyRecord>;
+  updateState(
+    featureId: string,
+    expectedVersion: number | null,
+    updater: StateUpdater,
+  ): Promise<AnyRecord>;
 }
 
 export class PatchService {
@@ -65,8 +77,8 @@ export class PatchService {
           feature_id: featureId,
           retryable: false,
           requires_human: true,
-          suggested_next_actions: ['Submit plan before applying patches']
-        })
+          suggested_next_actions: ['Submit plan before applying patches'],
+        }),
       };
     }
     return plan;
@@ -94,13 +106,17 @@ export class PatchService {
     const missing = required.filter((resource) => !held.has(resource));
     if (missing.length > 0) {
       throw {
-        normalizedResponse: fail(ERROR_CODES.LOCK_NOT_HELD, 'Plan requires lock(s) that are not held', {
-          feature_id: featureId,
-          missing_resources: missing,
-          retryable: true,
-          requires_human: false,
-          suggested_next_actions: ['Acquire required locks before applying patch']
-        })
+        normalizedResponse: fail(
+          ERROR_CODES.LOCK_NOT_HELD,
+          'Plan requires lock(s) that are not held',
+          {
+            feature_id: featureId,
+            missing_resources: missing,
+            retryable: true,
+            requires_human: false,
+            suggested_next_actions: ['Acquire required locks before applying patch'],
+          },
+        ),
       };
     }
   }
@@ -108,7 +124,7 @@ export class PatchService {
   async validatePatchPaths(
     featureId: string,
     parsedDiff: ReturnType<typeof parseUnifiedDiff>,
-    plan: AnyRecord | null
+    plan: AnyRecord | null,
   ): Promise<string[]> {
     const policy = this.port.getPolicySnapshot();
     const repoRoot = this.port.getRepoRoot();
@@ -121,9 +137,11 @@ export class PatchService {
       const normalized = await normalizeRepoPath(
         repoRoot,
         path.join(this.port.worktreePath(featureId), touchedPath),
-        allowSymlinkTraversal
+        allowSymlinkTraversal,
       )
-        .then((relativePath) => normalizeFromWorktree(this.port.worktreePath(featureId), repoRoot, relativePath))
+        .then((relativePath) =>
+          normalizeFromWorktree(this.port.worktreePath(featureId), repoRoot, relativePath),
+        )
         .catch(async () => {
           return await normalizeRepoPath(repoRoot, touchedPath, allowSymlinkTraversal);
         });
@@ -137,12 +155,16 @@ export class PatchService {
     const plannedFiles = new Set([
       ...asArray<string>(plan?.files?.create),
       ...asArray<string>(plan?.files?.modify),
-      ...asArray<string>(plan?.files?.delete)
+      ...asArray<string>(plan?.files?.delete),
     ]);
 
     const violations: Array<{ path: string; reason: string }> = [];
     for (const filePath of normalizedTouched) {
-      if (policy.patch_policy.enforce_allowed_areas && allowed.length > 0 && !anyAreaMatch(filePath, allowed, matchingMode)) {
+      if (
+        policy.patch_policy.enforce_allowed_areas &&
+        allowed.length > 0 &&
+        !anyAreaMatch(filePath, allowed, matchingMode)
+      ) {
         violations.push({ path: filePath, reason: 'outside_allowed_areas' });
       }
       if (forbidden.length > 0 && anyAreaMatch(filePath, forbidden, matchingMode)) {
@@ -158,12 +180,16 @@ export class PatchService {
 
     if (violations.length > 0) {
       throw {
-        normalizedResponse: fail(ERROR_CODES.PATCH_POLICY_VIOLATION, 'Patch violates plan/policy constraints', {
-          feature_id: featureId,
-          violations,
-          retryable: false,
-          requires_human: true
-        })
+        normalizedResponse: fail(
+          ERROR_CODES.PATCH_POLICY_VIOLATION,
+          'Patch violates plan/policy constraints',
+          {
+            feature_id: featureId,
+            violations,
+            retryable: false,
+            requires_human: true,
+          },
+        ),
       };
     }
 
@@ -172,7 +198,7 @@ export class PatchService {
 
   async repoApplyPatch(
     featureId: string,
-    unifiedDiff: string
+    unifiedDiff: string,
   ): Promise<{
     data: {
       feature_id: string;
@@ -185,13 +211,16 @@ export class PatchService {
     const parsedDiff = parseUnifiedDiff(unifiedDiff);
 
     await this.validatePatchPaths(featureId, parsedDiff, plan);
-    await this.assertPlanLocksHeld(featureId, plan ?? { contracts: { openapi: 'none', events: 'none', db: 'none' } });
+    await this.assertPlanLocksHeld(
+      featureId,
+      plan ?? { contracts: { openapi: 'none', events: 'none', db: 'none' } },
+    );
 
     const repoRoot = this.port.getRepoRoot();
     const worktree = this.port.worktreePath(featureId);
     const apply = await runGit(repoRoot, ['apply', '--whitespace=nowarn', '-'], {
       cwd: worktree,
-      stdin: unifiedDiff
+      stdin: unifiedDiff,
     });
 
     if (apply.code !== 0) {
@@ -202,13 +231,13 @@ export class PatchService {
           {
             stderr: apply.stderr,
             retryable: true,
-            requires_human: false
+            requires_human: false,
           },
           {
             command: ['git', 'apply', '--whitespace=nowarn', '-'],
-            exit_code: apply.code
-          }
-        )
+            exit_code: apply.code,
+          },
+        ),
       };
     }
 
@@ -230,8 +259,8 @@ export class PatchService {
         normalizedResponse: fail(ERROR_CODES.INTERNAL_ERROR, 'qa_test_index validation failed', {
           errors: qaValidation.errors,
           retryable: false,
-          requires_human: true
-        })
+          requires_human: true,
+        }),
       };
     }
 
@@ -241,10 +270,10 @@ export class PatchService {
       Promise.resolve({
         frontMatter: {
           status: frontMatter.status,
-          gates: frontMatter.gates
+          gates: frontMatter.gates,
         },
-        body
-      })
+        body,
+      }),
     );
 
     return {
@@ -252,8 +281,8 @@ export class PatchService {
         feature_id: featureId,
         changed_files: changedFiles,
         status_porcelain: status.stdout.trim().split('\n').filter(Boolean),
-        qa_index_version: qaIndex.version
-      }
+        qa_index_version: qaIndex.version,
+      },
     };
   }
 }

package/apps/control-plane/src/application/services/performance-analytics-service.ts

@@ -66,7 +66,7 @@ function computeAggregates(outcomes: FeatureOutcome[]): ProviderModelStats[] {
       avg_retry_count: total > 0 ? sumRetry / total : 0,
       avg_duration_ms: total > 0 ? sumDuration / total : 0,
       avg_cost_usd: total > 0 ? sumCost / total : 0,
-      last_updated: nowIso()
+      last_updated: nowIso(),
     });
   }
 
@@ -113,10 +113,12 @@ export class PerformanceAnalyticsService {
 
   private async readSnapshot(): Promise<AnalyticsSnapshot> {
     const existing = await readJson<AnalyticsSnapshot>(this.port.analyticsPath(), null);
-    return existing ?? {
-      outcomes: [],
-      aggregates: [],
-      generated_at: nowIso()
-    };
+    return (
+      existing ?? {
+        outcomes: [],
+        aggregates: [],
+        generated_at: nowIso(),
+      }
+    );
   }
 }