agentic-orchestrator 0.1.6 → 0.1.8

package/apps/control-plane/test/reactions.spec.ts

@@ -1,6 +1,9 @@
 import { describe, expect, it, vi } from 'vitest';
 import { ReactionsService } from '../src/application/services/reactions-service.js';
-import type { GateRepairContext, ReactionsPolicy } from '../src/application/services/reactions-service.js';
+import type {
+  GateRepairContext,
+  ReactionsPolicy,
+} from '../src/application/services/reactions-service.js';
 import type { ToolCaller } from '../src/core/tool-caller.js';
 import { TOOLS } from '../src/core/constants.js';
 
@@ -8,7 +11,10 @@ function makeToolCaller(statePatchFn?: () => Promise<Record<string, unknown>>):
   return {
     callTool: vi.fn(async (_role: string, toolName: string, _args?: Record<string, unknown>) => {
       if (toolName === TOOLS.FEATURE_STATE_GET) {
-        return { ok: true, data: { front_matter: { version: 1, status: 'qa', gate_retry_count: 0 } } };
+        return {
+          ok: true,
+          data: { front_matter: { version: 1, status: 'qa', gate_retry_count: 0 } },
+        };
       }
       if (toolName === TOOLS.FEATURE_STATE_PATCH) {
         if (statePatchFn) {
@@ -17,17 +23,19 @@ function makeToolCaller(statePatchFn?: () => Promise<Record<string, unknown>>):
         return { ok: true, data: { updated: true } };
       }
       return { ok: true, data: {} };
-    }) as unknown as ToolCaller['callTool']
+    }) as unknown as ToolCaller['callTool'],
   };
 }
 
 function makeNotifier() {
   return {
-    notify: vi.fn(async () => undefined)
+    notify: vi.fn(async () => undefined),
   };
 }
 
-function makeEnabledPolicy(overrides: Partial<ReactionsPolicy['gate_failed']> = {}): ReactionsPolicy {
+function makeEnabledPolicy(
+  overrides: Partial<ReactionsPolicy['gate_failed']> = {},
+): ReactionsPolicy {
   return {
     gate_failed: {
       enabled: true,
@@ -35,8 +43,8 @@ function makeEnabledPolicy(overrides: Partial<ReactionsPolicy['gate_failed']> =
       action: 'retry_with_agent_repair',
       escalate_after: 2,
       retry_delay_ms: 30000,
-      ...overrides
-    }
+      ...overrides,
+    },
   };
 }
 
@@ -45,7 +53,7 @@ describe('ReactionsService', () => {
     const toolCaller = makeToolCaller();
     const service = new ReactionsService({
       toolCaller: toolCaller as never,
-      policy: makeEnabledPolicy()
+      policy: makeEnabledPolicy(),
     });
 
     const ctx: GateRepairContext = {
@@ -54,7 +62,7 @@ describe('ReactionsService', () => {
       exitCode: 1,
       logs: 'Test run failed',
       evidenceSummary: '.aop/features/feature_a/evidence/full.json',
-      retryCount: 0
+      retryCount: 0,
     };
 
     const shouldRetry = service.shouldRetry('feature_a', 0);
@@ -72,7 +80,7 @@ describe('ReactionsService', () => {
     const service = new ReactionsService({
       toolCaller: toolCaller as never,
       notifier: notifier as never,
-      policy: makeEnabledPolicy({ max_retries: 2, escalate_after: 2 })
+      policy: makeEnabledPolicy({ max_retries: 2, escalate_after: 2 }),
     });
 
     const ctx: GateRepairContext = {
@@ -81,7 +89,7 @@ describe('ReactionsService', () => {
       exitCode: 1,
       logs: 'error',
       evidenceSummary: '',
-      retryCount: 2
+      retryCount: 2,
     };
 
     const shouldEscalate = service.shouldEscalate(2);
@@ -90,7 +98,7 @@ describe('ReactionsService', () => {
     expect(shouldEscalate).toBe(true);
     expect(notifier.notify).toHaveBeenCalledWith(
       'gate_failed',
-      expect.objectContaining({ feature_id: 'feature_b' })
+      expect.objectContaining({ feature_id: 'feature_b' }),
     );
   });
 
@@ -104,9 +112,9 @@ describe('ReactionsService', () => {
           max_retries: 2,
           action: 'retry_with_agent_repair',
           escalate_after: 2,
-          retry_delay_ms: 30000
-        }
-      }
+          retry_delay_ms: 30000,
+        },
+      },
     });
 
     const shouldRetry = service.shouldRetry('feature_c', 0);
@@ -121,13 +129,15 @@ describe('ReactionsService', () => {
     });
     const service = new ReactionsService({
       toolCaller: toolCaller as never,
-      policy: makeEnabledPolicy()
+      policy: makeEnabledPolicy(),
     });
 
     await service.recordRetry('feature_d', 1);
 
     expect(patchCallCount).toBe(1);
-    const patchCall = vi.mocked(toolCaller.callTool).mock.calls.find(([, tool]) => tool === TOOLS.FEATURE_STATE_PATCH);
+    const patchCall = vi
+      .mocked(toolCaller.callTool)
+      .mock.calls.find(([, tool]) => tool === TOOLS.FEATURE_STATE_PATCH);
     expect(patchCall).toBeDefined();
     const patchArgs = patchCall?.[2] ?? {};
     const patch = (patchArgs['patch'] ?? {}) as Record<string, unknown>;
@@ -139,13 +149,15 @@ describe('ReactionsService', () => {
     const toolCaller = makeToolCaller();
     const service = new ReactionsService({
       toolCaller: toolCaller as never,
-      policy: makeEnabledPolicy()
+      policy: makeEnabledPolicy(),
     });
 
     // Simulate force reset by calling recordRetry with 0
     await service.recordRetry('feature_e', 0);
 
-    const patchCall = vi.mocked(toolCaller.callTool).mock.calls.find(([, tool]) => tool === TOOLS.FEATURE_STATE_PATCH);
+    const patchCall = vi
+      .mocked(toolCaller.callTool)
+      .mock.calls.find(([, tool]) => tool === TOOLS.FEATURE_STATE_PATCH);
     expect(patchCall).toBeDefined();
     const patchArgs = patchCall?.[2] ?? {};
     const patch = (patchArgs['patch'] ?? {}) as Record<string, unknown>;
@@ -159,7 +171,7 @@ describe('ReactionsService', () => {
     const service = new ReactionsService({
       toolCaller: toolCaller as never,
       notifier: notifier as never,
-      policy: makeEnabledPolicy({ escalate_after: 2 })
+      policy: makeEnabledPolicy({ escalate_after: 2 }),
     });
 
     const shouldEscalateAt2 = service.shouldEscalate(2);
@@ -176,7 +188,7 @@ describe('ReactionsService', () => {
       exitCode: 1,
       logs: 'failed',
       evidenceSummary: 'no evidence',
-      retryCount: 2
+      retryCount: 2,
     };
     await service.notifyEscalation('feature_f', ctx);
     expect(notifier.notify).toHaveBeenCalledOnce();
@@ -186,7 +198,7 @@ describe('ReactionsService', () => {
     const toolCaller = makeToolCaller();
     const service = new ReactionsService({
       toolCaller: toolCaller as never,
-      policy: makeEnabledPolicy()
+      policy: makeEnabledPolicy(),
     });
 
     const ctx: GateRepairContext = {
@@ -195,7 +207,7 @@ describe('ReactionsService', () => {
       exitCode: 2,
       logs: 'compilation error on line 42',
       evidenceSummary: 'build-fast.json summary',
-      retryCount: 1
+      retryCount: 1,
     };
 
     const prompt = service.buildRepairPrompt(ctx);
@@ -210,7 +222,7 @@ describe('ReactionsService', () => {
   it('GIVEN policy undefined WHEN reactions service created THEN defaults applied (disabled)', () => {
     const toolCaller = makeToolCaller();
     const service = new ReactionsService({
-      toolCaller: toolCaller as never
+      toolCaller: toolCaller as never,
     });
 
     const shouldRetry = service.shouldRetry('feature_h', 0);
@@ -231,9 +243,9 @@ describe('ReactionsService', () => {
           max_retries: 3,
           action: 'notify_only',
           escalate_after: 2,
-          retry_delay_ms: 5000
-        }
-      }
+          retry_delay_ms: 5000,
+        },
+      },
     });
 
     const shouldRetry = service.shouldRetry('feature_i', 0);
@@ -244,7 +256,7 @@ describe('ReactionsService', () => {
     const toolCaller = makeToolCaller();
     const service = new ReactionsService({
       toolCaller: toolCaller as never,
-      policy: makeEnabledPolicy()
+      policy: makeEnabledPolicy(),
       // no notifier provided
     });
 
@@ -254,7 +266,7 @@ describe('ReactionsService', () => {
       exitCode: 1,
       logs: 'error log',
       evidenceSummary: 'no evidence',
-      retryCount: 3
+      retryCount: 3,
     };
 
     // notifier is undefined → early return, no notification sent
@@ -266,7 +278,7 @@ describe('ReactionsService branch coverage', () => {
   it('GIVEN_policy_with_retry_delay_ms_WHEN_retryDelayMs_called_THEN_returns_configured_value', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: makeEnabledPolicy({ retry_delay_ms: 5000 })
+      policy: makeEnabledPolicy({ retry_delay_ms: 5000 }),
     });
     expect(service.retryDelayMs()).toBe(5000);
   });
@@ -274,7 +286,7 @@ describe('ReactionsService branch coverage', () => {
   it('GIVEN_policy_with_invalid_retry_delay_ms_WHEN_retryDelayMs_called_THEN_returns_default', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: makeEnabledPolicy({ retry_delay_ms: -1 })
+      policy: makeEnabledPolicy({ retry_delay_ms: -1 }),
     });
     // Negative → falls through to default (30000)
     expect(service.retryDelayMs()).toBe(30000);
@@ -283,7 +295,7 @@ describe('ReactionsService branch coverage', () => {
   it('GIVEN_policy_with_max_retries_WHEN_maxRetries_called_THEN_returns_configured_value', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: makeEnabledPolicy({ max_retries: 5 })
+      policy: makeEnabledPolicy({ max_retries: 5 }),
     });
     expect(service.maxRetries()).toBe(5);
   });
@@ -291,7 +303,7 @@ describe('ReactionsService branch coverage', () => {
   it('GIVEN_no_policy_WHEN_maxRetries_called_THEN_returns_default', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: {}
+      policy: {},
     });
     expect(service.maxRetries()).toBeGreaterThanOrEqual(0);
   });
@@ -299,7 +311,7 @@ describe('ReactionsService branch coverage', () => {
   it('GIVEN_delay_ms_zero_WHEN_waitBeforeRetry_called_THEN_resolves_immediately', async () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: makeEnabledPolicy({ retry_delay_ms: 0 })
+      policy: makeEnabledPolicy({ retry_delay_ms: 0 }),
     });
     await expect(service.waitBeforeRetry()).resolves.toBeUndefined();
   });
@@ -308,7 +320,7 @@ describe('ReactionsService branch coverage', () => {
     vi.useFakeTimers();
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: makeEnabledPolicy({ retry_delay_ms: 1000 })
+      policy: makeEnabledPolicy({ retry_delay_ms: 1000 }),
     });
     const waitPromise = service.waitBeforeRetry();
     vi.advanceTimersByTime(1001);
@@ -319,7 +331,7 @@ describe('ReactionsService branch coverage', () => {
   it('GIVEN_buildRepairPrompt_with_empty_failure_history_WHEN_called_THEN_shows_none', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: makeEnabledPolicy()
+      policy: makeEnabledPolicy(),
     });
     const ctx: GateRepairContext = {
       featureId: 'feature_history_none',
@@ -327,7 +339,7 @@ describe('ReactionsService branch coverage', () => {
       exitCode: 1,
       logs: 'test output',
       evidenceSummary: 'summary',
-      retryCount: 0
+      retryCount: 0,
     };
     const prompt = service.buildRepairPrompt(ctx);
     expect(prompt).toContain('(none)');
@@ -338,7 +350,15 @@ describe('ReactionsService additional coverage', () => {
   it('GIVEN_policy_with_valid_max_retries_number_WHEN_maxRetries_called_THEN_returns_floor_of_value', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: { gate_failed: { enabled: true, action: 'retry_with_agent_repair', max_retries: 3.7, escalate_after: 2, retry_delay_ms: 0 } }
+      policy: {
+        gate_failed: {
+          enabled: true,
+          action: 'retry_with_agent_repair',
+          max_retries: 3.7,
+          escalate_after: 2,
+          retry_delay_ms: 0,
+        },
+      },
     });
     expect(service.maxRetries()).toBe(3);
   });
@@ -346,7 +366,15 @@ describe('ReactionsService additional coverage', () => {
   it('GIVEN_non_finite_max_retries_WHEN_maxRetries_called_THEN_returns_default', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: { gate_failed: { enabled: true, action: 'retry_with_agent_repair', max_retries: Infinity, escalate_after: 2, retry_delay_ms: 0 } }
+      policy: {
+        gate_failed: {
+          enabled: true,
+          action: 'retry_with_agent_repair',
+          max_retries: Infinity,
+          escalate_after: 2,
+          retry_delay_ms: 0,
+        },
+      },
     });
     expect(service.maxRetries()).toBeGreaterThanOrEqual(0);
   });
@@ -354,7 +382,7 @@ describe('ReactionsService additional coverage', () => {
   it('GIVEN_failure_history_with_items_WHEN_buildRepairPrompt_called_THEN_shows_history', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: makeEnabledPolicy()
+      policy: makeEnabledPolicy(),
     });
     const ctx: GateRepairContext = {
       featureId: 'feat_hist',
@@ -364,8 +392,16 @@ describe('ReactionsService additional coverage', () => {
       evidenceSummary: 'summary',
       retryCount: 1,
       failureHistory: [
-        { attempt: 1, gate_name: 'fast', exit_code: 1, evidence_summary: 'ev1', logs_excerpt: 'log1', failed_at: new Date().toISOString(), retry_delay_ms: 1000 }
-      ]
+        {
+          attempt: 1,
+          gate_name: 'fast',
+          exit_code: 1,
+          evidence_summary: 'ev1',
+          logs_excerpt: 'log1',
+          failed_at: new Date().toISOString(),
+          retry_delay_ms: 1000,
+        },
+      ],
     };
     const prompt = service.buildRepairPrompt(ctx);
     expect(prompt).toContain('attempt=1');
@@ -375,7 +411,7 @@ describe('ReactionsService additional coverage', () => {
   it('GIVEN_evidence_summary_empty_in_history_WHEN_buildRepairPrompt_called_THEN_shows_n_a', () => {
     const service = new ReactionsService({
       toolCaller: makeToolCaller(),
-      policy: makeEnabledPolicy()
+      policy: makeEnabledPolicy(),
     });
     const ctx: GateRepairContext = {
       featureId: 'feat_hist2',
@@ -385,8 +421,15 @@ describe('ReactionsService additional coverage', () => {
       evidenceSummary: '',
       retryCount: 1,
       failureHistory: [
-        { attempt: 1, gate_name: 'fast', exit_code: 1, evidence_summary: '', logs_excerpt: '', failed_at: new Date().toISOString() }
-      ]
+        {
+          attempt: 1,
+          gate_name: 'fast',
+          exit_code: 1,
+          evidence_summary: '',
+          logs_excerpt: '',
+          failed_at: new Date().toISOString(),
+        },
+      ],
     };
     const prompt = service.buildRepairPrompt(ctx);
     expect(prompt).toContain('n/a');

package/apps/control-plane/test/response.spec.ts

@@ -6,7 +6,7 @@ describe('response helpers', () => {
   it('GIVEN_data_without_evidence_WHEN_ok_THEN_returns_minimal_success_shape', () => {
     expect(ok({ feature_id: 'feature_a' })).toEqual({
       ok: true,
-      data: { feature_id: 'feature_a' }
+      data: { feature_id: 'feature_a' },
     });
   });
 
@@ -14,7 +14,7 @@ describe('response helpers', () => {
     expect(ok({ accepted: true }, { trace_id: 'trace-1' })).toEqual({
       ok: true,
       data: { accepted: true },
-      evidence: { trace_id: 'trace-1' }
+      evidence: { trace_id: 'trace-1' },
     });
   });
 
@@ -36,20 +36,20 @@ describe('response helpers', () => {
       feature_id: 'feature_a',
       retryable: false,
       requires_human: false,
-      suggested_next_actions: ['Retry', 'Escalate']
+      suggested_next_actions: ['Retry', 'Escalate'],
     });
   });
 
   it('GIVEN_existing_flags_WHEN_withSuggestedActions_THEN_keeps_existing_flags', () => {
     const details = withSuggestedActions(
       { retryable: true, requires_human: true, reason: 'manual' },
-      ['Open incident']
+      ['Open incident'],
     );
     expect(details).toEqual({
       retryable: true,
       requires_human: true,
       reason: 'manual',
-      suggested_next_actions: ['Open incident']
+      suggested_next_actions: ['Open incident'],
     });
   });
 });