agentic-orchestrator 0.1.6 → 0.1.8

package/apps/control-plane/test/supervisor-collaborators.spec.ts

@@ -14,31 +14,31 @@ describe('QaWaveExecutor collaborator branches', () => {
       runId: 'run-qa',
       ownerInstanceId: 'owner-qa',
       orchestratorSessionId: null,
-      sessionsByFeature: new Map<string, { planner: string; builder: string; qa: string }>()
+      sessionsByFeature: new Map<string, { planner: string; builder: string; qa: string }>(),
     };
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string) => {
         if (toolName === TOOLS.FEATURE_STATE_GET) {
           return {
             ok: true,
-            data: { front_matter: { status: STATUS.QA } }
+            data: { front_matter: { status: STATUS.QA } },
           };
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const provider = {
       closeSession: vi.fn(async () => ({ closed: true })),
-      createSession: vi.fn(async () => ({ session_id: 'qa-new' }))
+      createSession: vi.fn(async () => ({ session_id: 'qa-new' })),
     };
     const kernel = {
-      updateFeatureSessionAssignment: vi.fn(async () => ({ data: { updated: true } }))
+      updateFeatureSessionAssignment: vi.fn(async () => ({ data: { updated: true } })),
     };
     const promptProvider = {
-      loadRolePrompts: vi.fn(async () => ({ planner: null, builder: null, qa: 'qa prompt' }))
+      loadRolePrompts: vi.fn(async () => ({ planner: null, builder: null, qa: 'qa prompt' })),
     };
     const featureClusterPatcher = {
-      patchFeatureCluster: vi.fn(async () => undefined)
+      patchFeatureCluster: vi.fn(async () => undefined),
     };
     const executor = new QaWaveExecutor({
       kernel: kernel as any,
@@ -46,7 +46,7 @@ describe('QaWaveExecutor collaborator branches', () => {
       toolCaller: toolCaller as any,
       promptProvider: promptProvider as any,
       featureClusterPatcher: featureClusterPatcher as any,
-      state: state as any
+      state: state as any,
     });
 
     await executor.run(['feature_a'], 1);
@@ -57,17 +57,19 @@ describe('QaWaveExecutor collaborator branches', () => {
         feature_id: 'feature_a',
         planner_session_id: UNASSIGNED_SESSION_ID,
         builder_session_id: UNASSIGNED_SESSION_ID,
-        qa_session_id: 'qa-new'
-      })
+        qa_session_id: 'qa-new',
+      }),
     );
     expect(featureClusterPatcher.patchFeatureCluster).toHaveBeenCalledWith('feature_a', {
       orchestrator_session_id: 'unknown',
-      qa_session_id: 'qa-new'
+      qa_session_id: 'qa-new',
     });
   });
 
   describe('QaWaveExecutor catch and reactions branches', () => {
-    beforeEach(() => { vi.clearAllMocks(); });
+    beforeEach(() => {
+      vi.clearAllMocks();
+    });
 
     function makeBaseDeps() {
       const state = {
@@ -75,21 +77,21 @@ describe('QaWaveExecutor collaborator branches', () => {
         ownerInstanceId: 'owner-qa',
         orchestratorSessionId: 'orch-qa',
         sessionsByFeature: new Map<string, { planner: string; builder: string; qa: string }>([
-          ['feature_x', { planner: 'p-1', builder: 'b-1', qa: 'q-old' }]
-        ])
+          ['feature_x', { planner: 'p-1', builder: 'b-1', qa: 'q-old' }],
+        ]),
       };
       const provider = {
         closeSession: vi.fn(async () => ({ closed: true })),
-        createSession: vi.fn(async () => ({ session_id: 'qa-new' }))
+        createSession: vi.fn(async () => ({ session_id: 'qa-new' })),
       };
       const kernel = {
-        updateFeatureSessionAssignment: vi.fn(async () => ({ data: {} }))
+        updateFeatureSessionAssignment: vi.fn(async () => ({ data: {} })),
       };
       const promptProvider = {
-        loadRolePrompts: vi.fn(async () => ({ planner: null, builder: null, qa: 'qa-prompt' }))
+        loadRolePrompts: vi.fn(async () => ({ planner: null, builder: null, qa: 'qa-prompt' })),
       };
       const featureClusterPatcher = {
-        patchFeatureCluster: vi.fn(async () => undefined)
+        patchFeatureCluster: vi.fn(async () => undefined),
       };
       return { state, provider, kernel, promptProvider, featureClusterPatcher };
     }
@@ -105,7 +107,7 @@ describe('QaWaveExecutor collaborator branches', () => {
             throw new Error('gates failed unexpectedly');
           }
           return { ok: true, data: {} };
-        })
+        }),
       };
 
       const executor = new QaWaveExecutor({
@@ -114,7 +116,7 @@ describe('QaWaveExecutor collaborator branches', () => {
         toolCaller: toolCaller as never,
         promptProvider: promptProvider as never,
         featureClusterPatcher: featureClusterPatcher as never,
-        state: state as never
+        state: state as never,
       });
 
       await executor.run(['feature_x'], 1);
@@ -132,10 +134,13 @@ describe('QaWaveExecutor collaborator branches', () => {
           }
           if (toolName === TOOLS.GATES_RUN) {
             gateCallCount += 1;
-            return { ok: true, data: { overall: gateCallCount === 1 ? GATE_RESULT.FAIL : GATE_RESULT.PASS } };
+            return {
+              ok: true,
+              data: { overall: gateCallCount === 1 ? GATE_RESULT.FAIL : GATE_RESULT.PASS },
+            };
           }
           return { ok: true, data: {} };
-        })
+        }),
       };
       const reactionsService = {
         retryDelayMs: vi.fn(() => 5),
@@ -143,7 +148,7 @@ describe('QaWaveExecutor collaborator branches', () => {
         buildRepairPrompt: vi.fn(() => 'repair prompt'),
         recordRetry: vi.fn(async () => undefined),
         shouldEscalate: vi.fn(() => false),
-        notifyEscalation: vi.fn(async () => undefined)
+        notifyEscalation: vi.fn(async () => undefined),
       };
 
       const executor = new QaWaveExecutor({
@@ -153,7 +158,7 @@ describe('QaWaveExecutor collaborator branches', () => {
         promptProvider: promptProvider as never,
         featureClusterPatcher: featureClusterPatcher as never,
         state: state as never,
-        reactionsService: reactionsService as never
+        reactionsService: reactionsService as never,
       });
 
       await executor.run(['feature_x'], 1);
@@ -173,7 +178,7 @@ describe('QaWaveExecutor collaborator branches', () => {
             return { ok: true, data: { overall: GATE_RESULT.FAIL } };
           }
           return { ok: true, data: {} };
-        })
+        }),
       };
       const reactionsService = {
         retryDelayMs: vi.fn(() => 5),
@@ -181,7 +186,7 @@ describe('QaWaveExecutor collaborator branches', () => {
         buildRepairPrompt: vi.fn(() => 'repair prompt'),
         recordRetry: vi.fn(async () => undefined),
         shouldEscalate: vi.fn(() => true),
-        notifyEscalation: vi.fn(async () => undefined)
+        notifyEscalation: vi.fn(async () => undefined),
       };
 
       const executor = new QaWaveExecutor({
@@ -191,14 +196,14 @@ describe('QaWaveExecutor collaborator branches', () => {
         promptProvider: promptProvider as never,
         featureClusterPatcher: featureClusterPatcher as never,
         state: state as never,
-        reactionsService: reactionsService as never
+        reactionsService: reactionsService as never,
       });
 
       await executor.run(['feature_x'], 1);
 
       expect(reactionsService.notifyEscalation).toHaveBeenCalledWith(
         'feature_x',
-        expect.objectContaining({ featureId: 'feature_x', gateName: 'full' })
+        expect.objectContaining({ featureId: 'feature_x', gateName: 'full' }),
       );
     });
 
@@ -213,7 +218,7 @@ describe('QaWaveExecutor collaborator branches', () => {
             return { ok: true, data: { overall: GATE_RESULT.PASS } };
           }
           return { ok: true, data: {} };
-        })
+        }),
       };
       const reactionsService = {
         retryDelayMs: vi.fn(() => 5),
@@ -221,7 +226,7 @@ describe('QaWaveExecutor collaborator branches', () => {
         buildRepairPrompt: vi.fn(() => 'repair prompt'),
         recordRetry: vi.fn(async () => undefined),
         shouldEscalate: vi.fn(() => false),
-        notifyEscalation: vi.fn(async () => undefined)
+        notifyEscalation: vi.fn(async () => undefined),
       };
 
       const executor = new QaWaveExecutor({
@@ -231,7 +236,7 @@ describe('QaWaveExecutor collaborator branches', () => {
         promptProvider: promptProvider as never,
         featureClusterPatcher: featureClusterPatcher as never,
         state: state as never,
-        reactionsService: reactionsService as never
+        reactionsService: reactionsService as never,
       });
 
       await executor.run(['feature_x'], 1);
@@ -247,13 +252,17 @@ describe('QaWaveExecutor collaborator branches', () => {
             return { ok: true, data: { front_matter: { status: STATUS.PLANNING } } };
           }
           return { ok: true, data: {} };
-        })
+        }),
       };
       const workerDecisionRunner = {
         execute: vi.fn(async () => ({
-          planSubmission: false, patchApplied: false, noteLogged: false,
-          requestHandled: false, priorityOrder: [] as string[], toolResults: []
-        }))
+          planSubmission: false,
+          patchApplied: false,
+          noteLogged: false,
+          requestHandled: false,
+          priorityOrder: [] as string[],
+          toolResults: [],
+        })),
       };
 
       const executor = new QaWaveExecutor({
@@ -263,7 +272,7 @@ describe('QaWaveExecutor collaborator branches', () => {
         promptProvider: promptProvider as never,
         featureClusterPatcher: featureClusterPatcher as never,
         state: state as never,
-        workerDecisionRunner: workerDecisionRunner as never
+        workerDecisionRunner: workerDecisionRunner as never,
       });
 
       await executor.run(['feature_x'], 1);
@@ -280,8 +289,8 @@ describe('SessionOrchestrator collaborator branches', () => {
       getRuntimeSessions: vi.fn(async () => ({
         run_id: 'run-session',
         owner_instance_id: 'owner-session',
-        orchestrator_session_id: 'orch-session'
-      }))
+        orchestrator_session_id: 'orch-session',
+      })),
     };
     const provider = {
       createSession: vi
@@ -290,14 +299,14 @@ describe('SessionOrchestrator collaborator branches', () => {
         .mockResolvedValueOnce({ session_id: 'builder-1' })
         .mockResolvedValueOnce({ session_id: 'qa-1' })
         .mockResolvedValue({ session_id: 'generic-1' }),
-      closeSession: vi.fn(async () => ({ closed: true }))
+      closeSession: vi.fn(async () => ({ closed: true })),
     };
     const kernel = {
       updateOrchestratorSession: vi.fn(async () => ({ data: {} })),
-      updateFeatureSessionAssignment: vi.fn(async () => ({ data: {} }))
+      updateFeatureSessionAssignment: vi.fn(async () => ({ data: {} })),
     };
     const promptProvider = {
-      loadRolePrompts: vi.fn(async () => ({ planner: 'p', builder: 'b', qa: 'q' }))
+      loadRolePrompts: vi.fn(async () => ({ planner: 'p', builder: 'b', qa: 'q' })),
     };
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string, args: any) => {
@@ -307,14 +316,16 @@ describe('SessionOrchestrator collaborator branches', () => {
         if (toolName === TOOLS.FEATURE_STATE_GET && args.feature_id === 'feature_b') {
           return {
             ok: true,
-            data: { front_matter: { version: 3, cluster: { orchestrator_session_id: 'orch-main' } } }
+            data: {
+              front_matter: { version: 3, cluster: { orchestrator_session_id: 'orch-main' } },
+            },
           };
         }
         if (toolName === TOOLS.FEATURE_STATE_GET && args.feature_id === 'feature_patch') {
           return { ok: true, data: { front_matter: { version: 7 } } };
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const state = {
       runId: 'run-session',
@@ -322,7 +333,7 @@ describe('SessionOrchestrator collaborator branches', () => {
       orchestratorSessionId: null as string | null,
       runMetadata: {},
       queue: [{ feature_id: 'feature_q' }],
-      sessionsByFeature: new Map<string, { planner: string; builder: string; qa: string }>()
+      sessionsByFeature: new Map<string, { planner: string; builder: string; qa: string }>(),
     };
 
     return {
@@ -338,8 +349,8 @@ describe('SessionOrchestrator collaborator branches', () => {
         kernel: kernel as any,
         promptProvider: promptProvider as any,
         toolCaller: toolCaller as any,
-        state: state as any
-      })
+        state: state as any,
+      }),
     };
   }
 
@@ -359,11 +370,11 @@ describe('SessionOrchestrator collaborator branches', () => {
 
     expect(patchSpy).toHaveBeenCalledWith(
       'feature_init',
-      expect.objectContaining({ orchestrator_session_id: 'unknown' })
+      expect.objectContaining({ orchestrator_session_id: 'unknown' }),
     );
     expect(patchSpy).toHaveBeenCalledWith(
       'feature_q',
-      expect.objectContaining({ orchestrator_session_id: 'unknown' })
+      expect.objectContaining({ orchestrator_session_id: 'unknown' }),
     );
   });
 
@@ -374,7 +385,7 @@ describe('SessionOrchestrator collaborator branches', () => {
     await orchestrator.enforceActiveFeatureInvariant(['feature_a', 'feature_b']);
 
     const patchCalls = toolCaller.callTool.mock.calls.filter(
-      (call: any[]) => call[1] === TOOLS.FEATURE_STATE_PATCH
+      (call: any[]) => call[1] === TOOLS.FEATURE_STATE_PATCH,
     );
     expect(patchCalls).toHaveLength(1);
     expect(patchCalls[0][2]).toMatchObject({
@@ -382,10 +393,10 @@ describe('SessionOrchestrator collaborator branches', () => {
       patch: {
         front_matter: {
           cluster: {
-            orchestrator_session_id: 'orch-main'
-          }
-        }
-      }
+            orchestrator_session_id: 'orch-main',
+          },
+        },
+      },
     });
   });
 
@@ -402,11 +413,11 @@ describe('SessionOrchestrator collaborator branches', () => {
         patch: {
           front_matter: {
             cluster: {
-              qa_session_id: 'qa-new'
-            }
-          }
-        }
-      })
+              qa_session_id: 'qa-new',
+            },
+          },
+        },
+      }),
     );
   });
 
@@ -415,7 +426,7 @@ describe('SessionOrchestrator collaborator branches', () => {
     state.sessionsByFeature.set('feature_close', {
       planner: 'planner-c',
       builder: UNASSIGNED_SESSION_ID,
-      qa: 'qa-c'
+      qa: 'qa-c',
     });
 
     await orchestrator.closeFeatureCluster('feature_close');
@@ -444,8 +455,8 @@ describe('BuildWaveExecutor catch and reactions branches', () => {
         noteLogged: false,
         requestHandled: false,
         priorityOrder: [] as string[],
-        toolResults: []
-      }))
+        toolResults: [],
+      })),
     };
     return { workerDecisionRunner };
   }
@@ -456,7 +467,10 @@ describe('BuildWaveExecutor catch and reactions branches', () => {
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string) => {
         if (toolName === TOOLS.FEATURE_STATE_GET) {
-          return { ok: true, data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } } };
+          return {
+            ok: true,
+            data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } },
+          };
         }
         if (toolName === TOOLS.FEATURE_GET_CONTEXT) {
           return { ok: true, data: {} };
@@ -469,7 +483,7 @@ describe('BuildWaveExecutor catch and reactions branches', () => {
           throw new Error('retry gate exploded');
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const reactionsService = {
       retryDelayMs: vi.fn(() => 5),
@@ -477,13 +491,13 @@ describe('BuildWaveExecutor catch and reactions branches', () => {
       buildRepairPrompt: vi.fn(() => 'repair prompt'),
       recordRetry: vi.fn(async () => undefined),
       shouldEscalate: vi.fn(() => false),
-      notifyEscalation: vi.fn(async () => undefined)
+      notifyEscalation: vi.fn(async () => undefined),
     };
 
     const executor = new BuildWaveExecutor({
       toolCaller: toolCaller as never,
       workerDecisionRunner: workerDecisionRunner as never,
-      reactionsService: reactionsService as never
+      reactionsService: reactionsService as never,
     });
 
     await executor.run(['feature_build'], 1);
@@ -498,17 +512,23 @@ describe('BuildWaveExecutor catch and reactions branches', () => {
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string) => {
         if (toolName === TOOLS.FEATURE_STATE_GET) {
-          return { ok: true, data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } } };
+          return {
+            ok: true,
+            data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } },
+          };
         }
         if (toolName === TOOLS.FEATURE_GET_CONTEXT) {
           return { ok: true, data: {} };
         }
         if (toolName === TOOLS.GATES_RUN) {
           gatesCallCount += 1;
-          return { ok: true, data: { overall: gatesCallCount === 1 ? GATE_RESULT.FAIL : GATE_RESULT.PASS } };
+          return {
+            ok: true,
+            data: { overall: gatesCallCount === 1 ? GATE_RESULT.FAIL : GATE_RESULT.PASS },
+          };
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const reactionsService = {
       retryDelayMs: vi.fn(() => 5),
@@ -516,13 +536,13 @@ describe('BuildWaveExecutor catch and reactions branches', () => {
       buildRepairPrompt: vi.fn(() => 'repair prompt'),
       recordRetry: vi.fn(async () => undefined),
       shouldEscalate: vi.fn(() => false),
-      notifyEscalation: vi.fn(async () => undefined)
+      notifyEscalation: vi.fn(async () => undefined),
     };
 
     const executor = new BuildWaveExecutor({
       toolCaller: toolCaller as never,
       workerDecisionRunner: workerDecisionRunner as never,
-      reactionsService: reactionsService as never
+      reactionsService: reactionsService as never,
     });
 
     await executor.run(['feature_build'], 1);
@@ -536,18 +556,20 @@ describe('BuildWaveExecutor catch and reactions branches', () => {
 
 describe('PromptBundleLoader behavior', () => {
   it('GIVEN_missing_prompt_behavior_error_WHEN_file_not_found_THEN_throws_missing_role_prompt', async () => {
-    const readFileSpy = vi.spyOn(fs, 'readFile').mockRejectedValue(new Error('ENOENT: no such file') as never);
+    const readFileSpy = vi
+      .spyOn(fs, 'readFile')
+      .mockRejectedValue(new Error('ENOENT: no such file') as never);
     const runtimeStateReader = {
       getRepoRoot: vi.fn(() => '/fake/repo'),
       getAgentsConfig: vi.fn(() => ({
         roles: { planner: { system_prompt_path: 'prompts/planner.md' } },
-        missing_prompt_behavior: 'error'
-      }))
+        missing_prompt_behavior: 'error',
+      })),
     };
     const loader = new PromptBundleLoader(runtimeStateReader as never);
 
     await expect(loader.loadRolePrompts()).rejects.toMatchObject({
-      code: ERROR_CODES.MISSING_ROLE_PROMPT
+      code: ERROR_CODES.MISSING_ROLE_PROMPT,
     });
 
     readFileSpy.mockRestore();
@@ -556,7 +578,7 @@ describe('PromptBundleLoader behavior', () => {
   it('GIVEN_cache_set_WHEN_peek_cache_called_THEN_returns_cached_value', () => {
     const runtimeStateReader = {
       getRepoRoot: vi.fn(() => '/fake/repo'),
-      getAgentsConfig: vi.fn(() => ({ roles: {}, missing_prompt_behavior: 'ignore' }))
+      getAgentsConfig: vi.fn(() => ({ roles: {}, missing_prompt_behavior: 'ignore' })),
     };
     const loader = new PromptBundleLoader(runtimeStateReader as never);
     const bundle = { planner: 'planner prompt', builder: null, qa: 'qa prompt' };
@@ -569,7 +591,7 @@ describe('PromptBundleLoader behavior', () => {
   it('GIVEN_cache_set_to_null_WHEN_peek_cache_called_THEN_returns_null', () => {
     const runtimeStateReader = {
       getRepoRoot: vi.fn(() => '/fake/repo'),
-      getAgentsConfig: vi.fn(() => ({ roles: {}, missing_prompt_behavior: 'ignore' }))
+      getAgentsConfig: vi.fn(() => ({ roles: {}, missing_prompt_behavior: 'ignore' })),
     };
     const loader = new PromptBundleLoader(runtimeStateReader as never);
 
@@ -581,7 +603,7 @@ describe('PromptBundleLoader behavior', () => {
   it('GIVEN_agentsConfig_without_roles_or_behavior_WHEN_loadRolePrompts_THEN_uses_defaults', async () => {
     const runtimeStateReader = {
       getRepoRoot: vi.fn(() => '/fake/repo'),
-      getAgentsConfig: vi.fn(() => ({}))
+      getAgentsConfig: vi.fn(() => ({})),
     };
     const loader = new PromptBundleLoader(runtimeStateReader as never);
     const bundle = await loader.loadRolePrompts();
@@ -600,8 +622,8 @@ describe('BuildWaveExecutor waitBeforeRetry branch', () => {
         noteLogged: false,
         requestHandled: false,
         priorityOrder: [] as string[],
-        toolResults: []
-      }))
+        toolResults: [],
+      })),
     };
     return { workerDecisionRunner };
   }
@@ -612,17 +634,23 @@ describe('BuildWaveExecutor waitBeforeRetry branch', () => {
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string) => {
         if (toolName === TOOLS.FEATURE_STATE_GET) {
-          return { ok: true, data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } } };
+          return {
+            ok: true,
+            data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } },
+          };
         }
         if (toolName === TOOLS.FEATURE_GET_CONTEXT) {
           return { ok: true, data: {} };
         }
         if (toolName === TOOLS.GATES_RUN) {
           gatesCallCount += 1;
-          return { ok: true, data: { overall: gatesCallCount === 1 ? GATE_RESULT.FAIL : GATE_RESULT.PASS } };
+          return {
+            ok: true,
+            data: { overall: gatesCallCount === 1 ? GATE_RESULT.FAIL : GATE_RESULT.PASS },
+          };
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const waitBeforeRetry = vi.fn(async () => undefined);
     const reactionsService = {
@@ -632,13 +660,13 @@ describe('BuildWaveExecutor waitBeforeRetry branch', () => {
       buildRepairPrompt: vi.fn(() => 'repair prompt'),
       recordRetry: vi.fn(async () => undefined),
       shouldEscalate: vi.fn(() => false),
-      notifyEscalation: vi.fn(async () => undefined)
+      notifyEscalation: vi.fn(async () => undefined),
     };
 
     const executor = new BuildWaveExecutor({
       toolCaller: toolCaller as never,
       workerDecisionRunner: workerDecisionRunner as never,
-      reactionsService: reactionsService as never
+      reactionsService: reactionsService as never,
     });
 
     await executor.run(['feature_wait'], 1);
@@ -656,14 +684,14 @@ describe('QaWaveExecutor waitBeforeRetry branch', () => {
         noteLogged: false,
         requestHandled: false,
         priorityOrder: [] as string[],
-        toolResults: []
-      }))
+        toolResults: [],
+      })),
     };
     const state = {
       runId: 'run-qa-retry',
       ownerInstanceId: 'owner-qa-retry',
       orchestratorSessionId: null,
-      sessionsByFeature: new Map<string, { planner: string; builder: string; qa: string }>()
+      sessionsByFeature: new Map<string, { planner: string; builder: string; qa: string }>(),
     };
     let gatesCallCount = 0;
     const toolCaller = {
@@ -676,10 +704,13 @@ describe('QaWaveExecutor waitBeforeRetry branch', () => {
         }
         if (toolName === TOOLS.GATES_RUN) {
           gatesCallCount += 1;
-          return { ok: true, data: { overall: gatesCallCount === 1 ? GATE_RESULT.FAIL : GATE_RESULT.PASS } };
+          return {
+            ok: true,
+            data: { overall: gatesCallCount === 1 ? GATE_RESULT.FAIL : GATE_RESULT.PASS },
+          };
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const waitBeforeRetry = vi.fn(async () => undefined);
     const reactionsService = {
@@ -689,20 +720,20 @@ describe('QaWaveExecutor waitBeforeRetry branch', () => {
       buildRepairPrompt: vi.fn(() => 'repair prompt'),
       recordRetry: vi.fn(async () => undefined),
       shouldEscalate: vi.fn(() => false),
-      notifyEscalation: vi.fn(async () => undefined)
+      notifyEscalation: vi.fn(async () => undefined),
     };
     const provider = {
       closeSession: vi.fn(async () => ({ closed: true })),
-      createSession: vi.fn(async () => ({ session_id: 'qa-retry-session' }))
+      createSession: vi.fn(async () => ({ session_id: 'qa-retry-session' })),
     };
     const kernel = {
-      updateFeatureSessionAssignment: vi.fn(async () => ({ data: { updated: true } }))
+      updateFeatureSessionAssignment: vi.fn(async () => ({ data: { updated: true } })),
     };
     const promptProvider = {
-      loadRolePrompts: vi.fn(async () => ({ planner: null, builder: null, qa: null }))
+      loadRolePrompts: vi.fn(async () => ({ planner: null, builder: null, qa: null })),
     };
     const featureClusterPatcher = {
-      patchFeatureCluster: vi.fn(async () => undefined)
+      patchFeatureCluster: vi.fn(async () => undefined),
     };
     const executor = new QaWaveExecutor({
       kernel: kernel as never,
@@ -712,7 +743,7 @@ describe('QaWaveExecutor waitBeforeRetry branch', () => {
       featureClusterPatcher: featureClusterPatcher as never,
       state: state as never,
       workerDecisionRunner: workerDecisionRunner as never,
-      reactionsService: reactionsService as never
+      reactionsService: reactionsService as never,
     });
 
     await executor.run(['feature_qa_wait'], 1);
@@ -726,7 +757,10 @@ describe('BuildWaveExecutor error message fallback', () => {
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string) => {
         if (toolName === TOOLS.FEATURE_STATE_GET) {
-          return { ok: true, data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } } };
+          return {
+            ok: true,
+            data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } },
+          };
         }
         if (toolName === TOOLS.FEATURE_GET_CONTEXT) {
           return { ok: true, data: {} };
@@ -735,7 +769,7 @@ describe('BuildWaveExecutor error message fallback', () => {
           throw {}; // no message property → typed.message ?? '' = ''
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const workerDecisionRunner = {
       execute: vi.fn(async () => ({
@@ -744,8 +778,8 @@ describe('BuildWaveExecutor error message fallback', () => {
         noteLogged: false,
         requestHandled: false,
         priorityOrder: [] as string[],
-        toolResults: []
-      }))
+        toolResults: [],
+      })),
     };
     const reactionsService = {
       retryDelayMs: vi.fn(() => 0),
@@ -753,12 +787,12 @@ describe('BuildWaveExecutor error message fallback', () => {
       buildRepairPrompt: vi.fn(() => 'prompt'),
       recordRetry: vi.fn(async () => undefined),
       shouldEscalate: vi.fn(() => false),
-      notifyEscalation: vi.fn(async () => undefined)
+      notifyEscalation: vi.fn(async () => undefined),
     };
     const executor = new BuildWaveExecutor({
       toolCaller: toolCaller as never,
       workerDecisionRunner: workerDecisionRunner as never,
-      reactionsService: reactionsService as never
+      reactionsService: reactionsService as never,
     });
     await executor.run(['feature_x'], 1);
   });
@@ -768,18 +802,23 @@ describe('BuildWaveExecutor error message fallback', () => {
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string) => {
         if (toolName === TOOLS.FEATURE_STATE_GET) {
-          return { ok: true, data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } } };
+          return {
+            ok: true,
+            data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } },
+          };
         }
         if (toolName === TOOLS.FEATURE_GET_CONTEXT) {
           return { ok: true, data: {} };
         }
         if (toolName === TOOLS.GATES_RUN) {
           gatesCallCount++;
-          if (gatesCallCount === 1) {return { ok: true, data: { overall: GATE_RESULT.FAIL } };}
+          if (gatesCallCount === 1) {
+            return { ok: true, data: { overall: GATE_RESULT.FAIL } };
+          }
           return { ok: true, data: {} };
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const workerDecisionRunner = {
       execute: vi.fn(async () => ({
@@ -788,8 +827,8 @@ describe('BuildWaveExecutor error message fallback', () => {
         noteLogged: false,
         requestHandled: false,
         priorityOrder: [] as string[],
-        toolResults: []
-      }))
+        toolResults: [],
+      })),
     };
     const reactionsService = {
       retryDelayMs: vi.fn(() => 0),
@@ -797,12 +836,12 @@ describe('BuildWaveExecutor error message fallback', () => {
       buildRepairPrompt: vi.fn(() => 'repair'),
       recordRetry: vi.fn(async () => undefined),
       shouldEscalate: vi.fn(() => false),
-      notifyEscalation: vi.fn(async () => undefined)
+      notifyEscalation: vi.fn(async () => undefined),
     };
     const executor = new BuildWaveExecutor({
       toolCaller: toolCaller as never,
       workerDecisionRunner: workerDecisionRunner as never,
-      reactionsService: reactionsService as never
+      reactionsService: reactionsService as never,
     });
     await executor.run(['feature_x'], 1);
     // retry returned no overall → defaults to PASS → gateOverall = PASS → shouldEscalate not called
@@ -813,7 +852,10 @@ describe('BuildWaveExecutor error message fallback', () => {
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string) => {
         if (toolName === TOOLS.FEATURE_STATE_GET) {
-          return { ok: true, data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } } };
+          return {
+            ok: true,
+            data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } },
+          };
         }
         if (toolName === TOOLS.FEATURE_GET_CONTEXT) {
           return { ok: true, data: {} };
@@ -822,7 +864,7 @@ describe('BuildWaveExecutor error message fallback', () => {
           return { ok: true, data: { overall: GATE_RESULT.FAIL } };
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const workerDecisionRunner = {
       execute: vi.fn(async () => ({
@@ -831,8 +873,8 @@ describe('BuildWaveExecutor error message fallback', () => {
         noteLogged: false,
         requestHandled: false,
         priorityOrder: [] as string[],
-        toolResults: []
-      }))
+        toolResults: [],
+      })),
     };
     const reactionsService = {
       retryDelayMs: vi.fn(() => 0),
@@ -840,12 +882,12 @@ describe('BuildWaveExecutor error message fallback', () => {
       buildRepairPrompt: vi.fn(() => 'repair'),
       recordRetry: vi.fn(async () => undefined),
       shouldEscalate: vi.fn(() => false),
-      notifyEscalation: vi.fn(async () => undefined)
+      notifyEscalation: vi.fn(async () => undefined),
     };
     const executor = new BuildWaveExecutor({
       toolCaller: toolCaller as never,
       workerDecisionRunner: workerDecisionRunner as never,
-      reactionsService: reactionsService as never
+      reactionsService: reactionsService as never,
     });
     await executor.run(['feature_x'], 1);
     // retry still fails (FAIL) → shouldEscalate should be checked
@@ -857,18 +899,23 @@ describe('BuildWaveExecutor error message fallback', () => {
     const toolCaller = {
       callTool: vi.fn(async (_role: string, toolName: string) => {
         if (toolName === TOOLS.FEATURE_STATE_GET) {
-          return { ok: true, data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } } };
+          return {
+            ok: true,
+            data: { front_matter: { status: STATUS.BUILDING, gate_retry_count: 0 } },
+          };
         }
         if (toolName === TOOLS.FEATURE_GET_CONTEXT) {
           return { ok: true, data: {} };
         }
         if (toolName === TOOLS.GATES_RUN) {
           gatesCallCount++;
-          if (gatesCallCount === 1) {return { ok: true, data: { overall: GATE_RESULT.FAIL } };}
+          if (gatesCallCount === 1) {
+            return { ok: true, data: { overall: GATE_RESULT.FAIL } };
+          }
           throw {}; // retry throws without message → typed.message ?? '' = ''
         }
         return { ok: true, data: {} };
-      })
+      }),
     };
     const workerDecisionRunner = {
       execute: vi.fn(async () => ({
@@ -877,8 +924,8 @@ describe('BuildWaveExecutor error message fallback', () => {
         noteLogged: false,
         requestHandled: false,
         priorityOrder: [] as string[],
-        toolResults: []
-      }))
+        toolResults: [],
+      })),
     };
     const reactionsService = {
       retryDelayMs: vi.fn(() => 0),
@@ -886,12 +933,12 @@ describe('BuildWaveExecutor error message fallback', () => {
       buildRepairPrompt: vi.fn(() => 'repair'),
       recordRetry: vi.fn(async () => undefined),
       shouldEscalate: vi.fn(() => false),
-      notifyEscalation: vi.fn(async () => undefined)
+      notifyEscalation: vi.fn(async () => undefined),
     };
     const executor = new BuildWaveExecutor({
       toolCaller: toolCaller as never,
       workerDecisionRunner: workerDecisionRunner as never,
-      reactionsService: reactionsService as never
+      reactionsService: reactionsService as never,
     });
     await executor.run(['feature_x'], 1);
   });