agentic-orchestrator 0.1.6 → 0.1.8

package/apps/control-plane/test/kernel.coverage2.spec.ts

@@ -40,9 +40,9 @@ async function writePassingGates(root: string): Promise<void> {
       '      coverage:',
       '        type: none',
       'capabilities:',
-      '  - none'
+      '  - none',
     ].join('\n'),
-    'utf8'
+    'utf8',
   );
 }
 
@@ -157,21 +157,23 @@ describe('normalizeRuntimeSessions edge cases', () => {
 
   it('skips feature_sessions entry with empty string key (line 260 true branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { '': { planner_session_id: 'p1', builder_session_id: 'b1', qa_session_id: 'q1' } }
+      feature_sessions: {
+        '': { planner_session_id: 'p1', builder_session_id: 'b1', qa_session_id: 'q1' },
+      },
     });
     expect(Object.keys(result.feature_sessions)).toHaveLength(0);
   });
 
   it('skips feature_sessions entry where raw is null (line 260 true branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { feature_a: null }
+      feature_sessions: { feature_a: null },
     });
     expect(Object.keys(result.feature_sessions)).toHaveLength(0);
   });
 
   it('skips feature_sessions entry where raw is non-object (line 260 true branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { feature_a: 42 }
+      feature_sessions: { feature_a: 42 },
     });
     expect(Object.keys(result.feature_sessions)).toHaveLength(0);
   });
@@ -179,8 +181,8 @@ describe('normalizeRuntimeSessions edge cases', () => {
   it('includes valid feature_sessions entry (line 260 false branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
       feature_sessions: {
-        feature_a: { planner_session_id: 'p1', builder_session_id: 'b1', qa_session_id: 'q1' }
-      }
+        feature_a: { planner_session_id: 'p1', builder_session_id: 'b1', qa_session_id: 'q1' },
+      },
     });
     expect(result.feature_sessions['feature_a']).toBeDefined();
     expect(result.feature_sessions['feature_a'].planner_session_id).toBe('p1');
@@ -188,42 +190,48 @@ describe('normalizeRuntimeSessions edge cases', () => {
 
   it('falls back to unassigned for missing planner_session_id (line 266 false branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { feature_a: { builder_session_id: 'b1', qa_session_id: 'q1' } }
+      feature_sessions: { feature_a: { builder_session_id: 'b1', qa_session_id: 'q1' } },
     });
     expect(result.feature_sessions['feature_a'].planner_session_id).toBe('unassigned');
   });
 
   it('falls back to unassigned for non-string planner_session_id (line 266 false branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { feature_a: { planner_session_id: 123, builder_session_id: 'b1', qa_session_id: 'q1' } }
+      feature_sessions: {
+        feature_a: { planner_session_id: 123, builder_session_id: 'b1', qa_session_id: 'q1' },
+      },
     });
     expect(result.feature_sessions['feature_a'].planner_session_id).toBe('unassigned');
   });
 
   it('falls back to unassigned for missing builder_session_id (line 268 false branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { feature_a: { planner_session_id: 'p1', qa_session_id: 'q1' } }
+      feature_sessions: { feature_a: { planner_session_id: 'p1', qa_session_id: 'q1' } },
     });
     expect(result.feature_sessions['feature_a'].builder_session_id).toBe('unassigned');
   });
 
   it('falls back to unassigned for non-string builder_session_id (line 268 false branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { feature_a: { planner_session_id: 'p1', builder_session_id: false, qa_session_id: 'q1' } }
+      feature_sessions: {
+        feature_a: { planner_session_id: 'p1', builder_session_id: false, qa_session_id: 'q1' },
+      },
     });
     expect(result.feature_sessions['feature_a'].builder_session_id).toBe('unassigned');
   });
 
   it('falls back to unassigned for missing qa_session_id (line 269 false branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { feature_a: { planner_session_id: 'p1', builder_session_id: 'b1' } }
+      feature_sessions: { feature_a: { planner_session_id: 'p1', builder_session_id: 'b1' } },
     });
     expect(result.feature_sessions['feature_a'].qa_session_id).toBe('unassigned');
   });
 
   it('falls back to unassigned for non-string qa_session_id (line 269 false branch)', () => {
     const result = kernel.normalizeRuntimeSessions({
-      feature_sessions: { feature_a: { planner_session_id: 'p1', builder_session_id: 'b1', qa_session_id: [] } }
+      feature_sessions: {
+        feature_a: { planner_session_id: 'p1', builder_session_id: 'b1', qa_session_id: [] },
+      },
     });
     expect(result.feature_sessions['feature_a'].qa_session_id).toBe('unassigned');
   });
@@ -327,7 +335,10 @@ describe('normalizeError edge cases', () => {
   });
 
   it('returns normalizedResponse when error contains it', () => {
-    const normalizedResponse = { ok: false as const, error: { code: 'test_code', message: 'test' } };
+    const normalizedResponse = {
+      ok: false as const,
+      error: { code: 'test_code', message: 'test' },
+    };
     const result = kernel.normalizeError({ normalizedResponse });
     expect(result).toBe(normalizedResponse);
   });
@@ -419,9 +430,9 @@ describe('AopKernel invoke with edge-case args', () => {
       {
         feature_id: 'feat_cost',
         tokens_used_delta: 'not-a-number',
-        estimated_cost_usd_delta: 'also-not-a-number'
+        estimated_cost_usd_delta: 'also-not-a-number',
       },
-      ORCH
+      ORCH,
     );
     expect(result.ok).toBe(true);
   });
@@ -433,7 +444,7 @@ describe('AopKernel invoke with edge-case args', () => {
     const result = await kernel.invoke(
       'cost.record',
       { feature_id: 'feat_cost2', tokens_used_delta: 100, estimated_cost_usd_delta: 0.05 },
-      ORCH
+      ORCH,
     );
     expect(result.ok).toBe(true);
   });
@@ -443,16 +454,16 @@ describe('AopKernel invoke with edge-case args', () => {
     const result = await kernel.invoke(
       'performance.record_outcome',
       {
-        feature_id: 123,        // not string → ''
-        provider: true,         // not string → ''
-        model: null,            // not string → ''
-        status: [],             // not string → ''
-        gate_pass: 'yes',       // not boolean → false
-        retry_count: 'two',     // not number → 0
-        duration_ms: '5000',    // not number → 0
-        cost_usd: '1.5'         // not number → 0
+        feature_id: 123, // not string → ''
+        provider: true, // not string → ''
+        model: null, // not string → ''
+        status: [], // not string → ''
+        gate_pass: 'yes', // not boolean → false
+        retry_count: 'two', // not number → 0
+        duration_ms: '5000', // not number → 0
+        cost_usd: '1.5', // not number → 0
       },
-      ORCH
+      ORCH,
     );
     expect(result.ok).toBe(true);
   });
@@ -468,9 +479,9 @@ describe('AopKernel invoke with edge-case args', () => {
         gate_pass: true,
         retry_count: 1,
         duration_ms: 3000,
-        cost_usd: 0.10
+        cost_usd: 0.1,
       },
-      ORCH
+      ORCH,
     );
     expect(result.ok).toBe(true);
   });
@@ -480,7 +491,7 @@ describe('AopKernel invoke with edge-case args', () => {
     const result = await kernel.invoke(
       'performance.get_analytics',
       { provider: 'openai', model: 'gpt-4' },
-      ORCH
+      ORCH,
     );
     expect(result.ok).toBe(true);
     expect(result.data).toHaveProperty('outcomes');
@@ -495,7 +506,7 @@ describe('AopKernel invoke with edge-case args', () => {
     const result = await kernel.invoke(
       'performance.get_analytics',
       { provider: 'anthropic' },
-      ORCH
+      ORCH,
     );
     expect(result.ok).toBe(true);
   });
@@ -511,7 +522,7 @@ describe('AopKernel invoke with edge-case args', () => {
     const result = await kernel.invoke(
       'feature.delete',
       { feature_id: 'feat_del', dry_run: 'yes', confirm: 'true' },
-      ORCH
+      ORCH,
     );
     // May succeed or fail, but the branch is covered
     expect(result).toBeDefined();
@@ -534,8 +545,14 @@ describe('AopKernel invoke with edge-case args', () => {
     // Invoke with boolean fields set → readBooleanField returns boolean → passed as boolean
     const result = await kernel.invoke(
       'feature.delete',
-      { feature_id: 'feat_del3', dry_run: true, confirm: false, remove_worktree: false, remove_branch: 'feat_del3' },
-      ORCH
+      {
+        feature_id: 'feat_del3',
+        dry_run: true,
+        confirm: false,
+        remove_worktree: false,
+        remove_branch: 'feat_del3',
+      },
+      ORCH,
     );
     expect(result).toBeDefined();
   });
@@ -578,7 +595,7 @@ describe('featureSendMessage edge cases', () => {
     const result = await kernel.invoke(
       'feature.send_message',
       { feature_id: 'feat_msg', message: 'hello' },
-      ORCH
+      ORCH,
     );
     // No active session cluster → session_not_found
     expect(result.ok).toBe(false);
@@ -602,14 +619,14 @@ describe('featureSendMessage edge cases', () => {
     sessions.feature_sessions['feat_msg2'] = {
       planner_session_id: 'planner-001',
       builder_session_id: 'builder-001',
-      qa_session_id: 'qa-001'
+      qa_session_id: 'qa-001',
     };
     await kernel.writeRunLease(sessions);
 
     const result = await kernel.invoke(
       'feature.send_message',
       { feature_id: 'feat_msg2', message: 'hello' },
-      ORCH
+      ORCH,
     );
     // Provider has no sendMessage → provider_unsupported
     expect(result.ok).toBe(false);
@@ -622,12 +639,20 @@ describe('featureSendMessage edge cases', () => {
     await kernel.invoke('feature.init', { feature_id: 'feat_building' }, ORCH);
 
     // Patch feature state to BUILDING
-    const stateResult = await kernel.invoke('feature.state_get', { feature_id: 'feat_building' }, ORCH);
+    const stateResult = await kernel.invoke(
+      'feature.state_get',
+      { feature_id: 'feat_building' },
+      ORCH,
+    );
     const version = (stateResult.data as { version: number }).version;
     await kernel.invoke(
       'feature.state_patch',
-      { feature_id: 'feat_building', expected_version: version, patch: { status: STATUS.BUILDING } },
-      ORCH
+      {
+        feature_id: 'feat_building',
+        expected_version: version,
+        patch: { status: STATUS.BUILDING },
+      },
+      ORCH,
     );
 
     // Set up runtime sessions with a feature session having 'unassigned' builder_session_id
@@ -637,14 +662,14 @@ describe('featureSendMessage edge cases', () => {
     sessions.feature_sessions['feat_building'] = {
       planner_session_id: 'planner-001',
       builder_session_id: 'unassigned', // line 1275 – will fall back to orchestrator
-      qa_session_id: 'qa-001'
+      qa_session_id: 'qa-001',
     };
     await kernel.writeRunLease(sessions);
 
     const result = await kernel.invoke(
       'feature.send_message',
       { feature_id: 'feat_building', message: 'hey' },
-      ORCH
+      ORCH,
     );
     // No sendMessage provider → provider_unsupported
     expect(result.ok).toBe(false);
@@ -667,7 +692,11 @@ describe('load() failure branches', () => {
 
   it('throws on invalid gates YAML schema (line 343)', async () => {
     const gatesPath = path.join(repoRoot, 'agentic', 'orchestrator', 'gates.yaml');
-    await fs.writeFile(gatesPath, 'version: "not_a_number"\nprofiles: []\ncapabilities: []\n', 'utf8');
+    await fs.writeFile(
+      gatesPath,
+      'version: "not_a_number"\nprofiles: []\ncapabilities: []\n',
+      'utf8',
+    );
     const kernel = new AopKernel(repoRoot);
     await expect(kernel.load()).rejects.toThrow(/invalid_gates_yaml/);
   });
@@ -676,7 +705,9 @@ describe('load() failure branches', () => {
     const policyPath = path.join(repoRoot, 'agentic', 'orchestrator', 'policy.yaml');
     await fs.writeFile(policyPath, 'version: "not_valid"\n', 'utf8');
     const kernel = new AopKernel(repoRoot);
-    await expect(kernel.load()).rejects.toThrow(/invalid_policy_yaml|invalid_gates_yaml|INVALID_WORKSPACE/);
+    await expect(kernel.load()).rejects.toThrow(
+      /invalid_policy_yaml|invalid_gates_yaml|INVALID_WORKSPACE/,
+    );
   });
 
   it('schema rejects wrong workspace value (schema enforces const:nx before line 356)', async () => {
@@ -751,7 +782,8 @@ describe('AopKernel unknown tool and repo status coverage', () => {
     const featureId = 'feat_repo_status';
     const worktreePath = path.join(repoRoot2, '.worktrees', featureId);
     await runGit(repoRoot2, ['worktree', 'add', worktreePath, 'feat_repo_status']);
-    const frontmatter = '---\nfeature_id: feat_repo_status\nversion: 1\nbranch: feat_repo_status\nstatus: building\ngate_profile: default\ngates:\n  plan: na\n  fast: na\n  full: na\nworktree_path: .worktrees/feat_repo_status\n---\n';
+    const frontmatter =
+      '---\nfeature_id: feat_repo_status\nversion: 1\nbranch: feat_repo_status\nstatus: building\ngate_profile: default\ngates:\n  plan: na\n  fast: na\n  full: na\nworktree_path: .worktrees/feat_repo_status\n---\n';
     const featureDir = path.join(repoRoot2, '.aop', 'features', featureId);
     await fs.mkdir(featureDir, { recursive: true });
     await fs.writeFile(path.join(featureDir, 'state.md'), frontmatter, 'utf8');
@@ -764,14 +796,22 @@ describe('AopKernel unknown tool and repo status coverage', () => {
   it('GIVEN_unknown_tool_name_WHEN_dispatchTool_THEN_returns_invalid_argument_error', async () => {
     // Covers lines 169-174: the unknown tool callback body in ToolRouter
     // Must call dispatchTool directly to bypass the RBAC check in invoke()
-    const result = await (kernel2 as any).dispatchTool('tool.does_not_exist_xyz', {}, { actorType: 'orchestrator', actorId: 'orch:test' });
+    const result = await (kernel2 as any).dispatchTool(
+      'tool.does_not_exist_xyz',
+      {},
+      { actorType: 'orchestrator', actorId: 'orch:test' },
+    );
     expect(result.ok).toBe(false);
     expect(result.error?.code).toBe('invalid_argument');
   });
 
   it('GIVEN_valid_feature_WHEN_repo_status_THEN_returns_file_status', async () => {
     // Covers line 543: REPO_STATUS tool handler body
-    const result = await kernel2.invoke('repo.status', { feature_id: 'feat_repo_status' }, { actor_type: 'orchestrator', actor_id: 'orch:test' });
+    const result = await kernel2.invoke(
+      'repo.status',
+      { feature_id: 'feat_repo_status' },
+      { actor_type: 'orchestrator', actor_id: 'orch:test' },
+    );
     expect(result.ok).toBe(true);
   });
 });
@@ -795,25 +835,29 @@ describe('AopKernel readRunLease migration path coverage', () => {
     // Write an index with runtime_sessions.run_id set
     const indexPath = path.join(repoRoot3, '.aop', 'features', 'index.json');
     await fs.mkdir(path.dirname(indexPath), { recursive: true });
-    await fs.writeFile(indexPath, JSON.stringify({
-      version: 1,
-      active: [],
-      blocked: [],
-      merged: [],
-      blocked_queue: [],
-      dep_blocked: [],
-      locks: {},
-      lock_leases: {},
-      updated_at: new Date().toISOString(),
-      runtime_sessions: {
-        run_id: 'run:migrated-id',
-        owner_instance_id: 'owner:migrated',
-        orchestrator_session_id: 'orch-migrated',
-        orchestrator_epoch: 1,
-        lease_expires_at: new Date(Date.now() + 3600000).toISOString(),
-        feature_sessions: {}
-      }
-    }), 'utf8');
+    await fs.writeFile(
+      indexPath,
+      JSON.stringify({
+        version: 1,
+        active: [],
+        blocked: [],
+        merged: [],
+        blocked_queue: [],
+        dep_blocked: [],
+        locks: {},
+        lock_leases: {},
+        updated_at: new Date().toISOString(),
+        runtime_sessions: {
+          run_id: 'run:migrated-id',
+          owner_instance_id: 'owner:migrated',
+          orchestrator_session_id: 'orch-migrated',
+          orchestrator_epoch: 1,
+          lease_expires_at: new Date(Date.now() + 3600000).toISOString(),
+          feature_sessions: {},
+        },
+      }),
+      'utf8',
+    );
     const sessions = await kernel3.readRunLease();
     expect(sessions.run_id).toBe('run:migrated-id');
   });