agentic-orchestrator 0.1.6 → 0.1.8

package/apps/control-plane/test/dashboard-api.integration.spec.ts

@@ -5,14 +5,21 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 
 const resolveProjectRootMock = vi.hoisted(() => vi.fn(async () => '/tmp'));
 const readDashboardStatusMock = vi.hoisted(() =>
-  vi.fn(async () => ({ index: { active: [], blocked: [], merged: [], blocked_queue: [] }, features: [] }))
+  vi.fn(async () => ({
+    index: { active: [], blocked: [], merged: [], blocked_queue: [] },
+    features: [],
+  })),
 );
 const readFeatureStateMock = vi.hoisted(() => vi.fn(async () => null));
 const getAopRootMock = vi.hoisted(() => vi.fn(() => process.cwd()));
-const approveFeatureReviewMock = vi.hoisted(() => vi.fn(async () => ({ ok: true, data: { merged: true } })));
-const denyFeatureReviewMock = vi.hoisted(() => vi.fn(async () => ({ ok: true, data: { blocked: true } })));
+const approveFeatureReviewMock = vi.hoisted(() =>
+  vi.fn(async () => ({ ok: true, data: { merged: true } })),
+);
+const denyFeatureReviewMock = vi.hoisted(() =>
+  vi.fn(async () => ({ ok: true, data: { blocked: true } })),
+);
 const requestFeatureChangesMock = vi.hoisted(() =>
-  vi.fn(async () => ({ ok: true, data: { delivered: true } }))
+  vi.fn(async () => ({ ok: true, data: { delivered: true } })),
 );
 const execFileMock = vi.hoisted(() => vi.fn());
 
@@ -20,24 +27,27 @@ vi.mock('../../../packages/web-dashboard/src/lib/aop-client.js', () => ({
   resolveProjectRoot: resolveProjectRootMock,
   readDashboardStatus: readDashboardStatusMock,
   readFeatureState: readFeatureStateMock,
-  getAopRoot: getAopRootMock
+  getAopRoot: getAopRootMock,
 }));
 
 vi.mock('../../../packages/web-dashboard/src/lib/orchestrator-tools.js', () => ({
   approveFeatureReview: approveFeatureReviewMock,
   denyFeatureReview: denyFeatureReviewMock,
-  requestFeatureChanges: requestFeatureChangesMock
+  requestFeatureChanges: requestFeatureChangesMock,
 }));
 
 vi.mock('node:child_process', () => ({
   execFile: (...args: unknown[]) => {
-    const callback = args[args.length - 1] as (err: null | Error, result?: { stdout: string; stderr: string }) => void;
+    const callback = args[args.length - 1] as (
+      err: null | Error,
+      result?: { stdout: string; stderr: string },
+    ) => void;
     const call = execFileMock(...args.slice(0, -1)) as Promise<{ stdout: string; stderr: string }>;
     void call.then(
       (result) => callback(null, result),
-      (error: Error) => callback(error)
+      (error: Error) => callback(error),
     );
-  }
+  },
 }));
 
 import { POST as actionsPost } from '../../../packages/web-dashboard/src/app/api/actions/route.js';
@@ -75,9 +85,9 @@ describe('dashboard api integration', () => {
           phase: 'ready_to_merge',
           branch: 'feature/feature_checkout',
           worktree_path: path.join(repoRoot, '.worktrees', 'feature_checkout'),
-          pr: null
-        }
-      ]
+          pr: null,
+        },
+      ],
     });
   });
 
@@ -92,9 +102,9 @@ describe('dashboard api integration', () => {
         body: JSON.stringify({
           action: 'review.approve',
           feature_id: 'feature_checkout',
-          approval_token: 'approved'
-        })
-      })
+          approval_token: 'approved',
+        }),
+      }),
     );
 
     expect(response.status).toBe(200);
@@ -103,7 +113,7 @@ describe('dashboard api integration', () => {
       'approved',
       'merge_commit',
       undefined,
-      repoRoot
+      repoRoot,
     );
   });
 
@@ -114,13 +124,17 @@ describe('dashboard api integration', () => {
         body: JSON.stringify({
           action: 'review.request_changes',
           feature_id: 'feature_checkout',
-          message: 'Please address CI failures'
-        })
-      })
+          message: 'Please address CI failures',
+        }),
+      }),
     );
 
     expect(response.status).toBe(200);
-    expect(requestFeatureChangesMock).toHaveBeenCalledWith('feature_checkout', 'Please address CI failures', repoRoot);
+    expect(requestFeatureChangesMock).toHaveBeenCalledWith(
+      'feature_checkout',
+      'Please address CI failures',
+      repoRoot,
+    );
   });
 
   it('GIVEN_review_deny_without_reason_WHEN_posted_THEN_returns_400', async () => {
@@ -129,9 +143,9 @@ describe('dashboard api integration', () => {
         method: 'POST',
         body: JSON.stringify({
           action: 'review.deny',
-          feature_id: 'feature_checkout'
-        })
-      })
+          feature_id: 'feature_checkout',
+        }),
+      }),
     );
 
     const body = (await response.json()) as { ok: boolean; error: { code: string } };
@@ -148,7 +162,7 @@ describe('dashboard api integration', () => {
       phase: 'ready_to_merge',
       branch: 'feature/feature_checkout',
       worktree_path: path.join(repoRoot, '.worktrees', 'feature_checkout'),
-      pr: null
+      pr: null,
     });
 
     execFileMock.mockImplementation(async (_file: string, args: string[]) => {
@@ -174,11 +188,14 @@ describe('dashboard api integration', () => {
     const checkoutResponse = await checkoutPost(
       new Request('http://localhost/api/features/feature_checkout/checkout?project=alpha', {
         method: 'POST',
-        body: JSON.stringify({ action: 'checkout', stash_changes: false })
+        body: JSON.stringify({ action: 'checkout', stash_changes: false }),
       }),
-      { params: { id: 'feature_checkout' } }
+      { params: { id: 'feature_checkout' } },
     );
-    const checkoutBody = (await checkoutResponse.json()) as { ok: boolean; data: { previous_branch: string } };
+    const checkoutBody = (await checkoutResponse.json()) as {
+      ok: boolean;
+      data: { previous_branch: string };
+    };
     expect(checkoutResponse.status).toBe(200);
     expect(checkoutBody.ok).toBe(true);
     expect(checkoutBody.data.previous_branch).toBe('main');
@@ -189,11 +206,14 @@ describe('dashboard api integration', () => {
     const restoreResponse = await checkoutPost(
       new Request('http://localhost/api/features/feature_checkout/checkout?project=alpha', {
         method: 'POST',
-        body: JSON.stringify({ action: 'restore' })
+        body: JSON.stringify({ action: 'restore' }),
       }),
-      { params: { id: 'feature_checkout' } }
+      { params: { id: 'feature_checkout' } },
     );
-    const restoreBody = (await restoreResponse.json()) as { ok: boolean; data: { restored_to: string } };
+    const restoreBody = (await restoreResponse.json()) as {
+      ok: boolean;
+      data: { restored_to: string };
+    };
     expect(restoreResponse.status).toBe(200);
     expect(restoreBody.ok).toBe(true);
     expect(restoreBody.data.restored_to).toBe('main');
@@ -215,22 +235,34 @@ describe('dashboard api integration', () => {
   it('GIVEN_multi_project_config_WHEN_projects_endpoint_called_THEN_returns_switchable_projects', async () => {
     const projectAlpha = path.join(repoRoot, 'project-alpha');
     const projectBeta = path.join(repoRoot, 'project-beta');
-    await fs.mkdir(path.join(repoRoot, 'agentic', 'orchestrator', 'schemas'), { recursive: true });
+    await fs.mkdir(path.join(repoRoot, 'config', 'agentic', 'orchestrator', 'schemas'), {
+      recursive: true,
+    });
     await fs.copyFile(
-      path.resolve(import.meta.dirname, '../../../agentic/orchestrator/schemas/multi-project.schema.json'),
-      path.join(repoRoot, 'agentic', 'orchestrator', 'schemas', 'multi-project.schema.json')
+      path.resolve(
+        import.meta.dirname,
+        '../../../agentic/orchestrator/schemas/multi-project.schema.json',
+      ),
+      path.join(
+        repoRoot,
+        'config',
+        'agentic',
+        'orchestrator',
+        'schemas',
+        'multi-project.schema.json',
+      ),
     );
     await fs.writeFile(
-      path.join(repoRoot, 'agentic', 'orchestrator', 'multi-project.yaml'),
+      path.join(repoRoot, 'config', 'agentic', 'orchestrator', 'multi-project.yaml'),
       [
         'version: "1.0"',
         'projects:',
         `  - name: alpha`,
         `    path: ${projectAlpha}`,
         `  - name: beta`,
-        `    path: ${projectBeta}`
+        `    path: ${projectBeta}`,
       ].join('\n'),
-      'utf8'
+      'utf8',
     );
 
     const response = await projectsGet();

package/apps/control-plane/test/dashboard-client.spec.ts

@@ -2,7 +2,7 @@ import fs from 'node:fs/promises';
 import os from 'node:os';
 import path from 'node:path';
 import { afterEach, describe, expect, it } from 'vitest';
-import { readDashboardStatus } from '../../../packages/web-dashboard/src/lib/aop-client.js';
+import { readDashboardStatus } from '@/lib/aop-client.js';
 
 async function writeState(repoRoot: string, featureId: string, frontMatter: string): Promise<void> {
   const featureDir = path.join(repoRoot, '.aop', 'features', featureId);
@@ -25,7 +25,7 @@ describe('dashboard aop client mapping', () => {
     await fs.writeFile(
       path.join(repoRoot, '.aop', 'features', 'index.json'),
       JSON.stringify({ active: ['feature_a'], blocked: [], merged: [], blocked_queue: [] }),
-      'utf8'
+      'utf8',
     );
     await writeState(
       repoRoot,
@@ -37,8 +37,8 @@ describe('dashboard aop client mapping', () => {
         'branch: feature_a',
         'worktree_path: /tmp/worktrees/feature_a',
         'gate_profile: default',
-        'last_updated: 2026-03-03T00:00:00Z'
-      ].join('\n')
+        'last_updated: 2026-03-03T00:00:00Z',
+      ].join('\n'),
     );
 
     const payload = await readDashboardStatus(repoRoot);
@@ -46,7 +46,7 @@ describe('dashboard aop client mapping', () => {
     expect(payload.features[0]).toMatchObject({
       feature_id: 'feature_a',
       status: 'unknown_status',
-      phase: 'planning'
+      phase: 'planning',
     });
   });
 
@@ -57,7 +57,7 @@ describe('dashboard aop client mapping', () => {
     await fs.writeFile(
       path.join(repoRoot, '.aop', 'features', 'index.json'),
       JSON.stringify({ active: ['feature_pr'], blocked: [], merged: [], blocked_queue: [] }),
-      'utf8'
+      'utf8',
     );
     await writeState(
       repoRoot,
@@ -78,8 +78,8 @@ describe('dashboard aop client mapping', () => {
         '  merge_ready: true',
         '  pending_review_threads: 0',
         '  has_conflicts: false',
-        '  merge_score: 100'
-      ].join('\n')
+        '  merge_score: 100',
+      ].join('\n'),
     );
 
     const payload = await readDashboardStatus(repoRoot);
@@ -87,7 +87,7 @@ describe('dashboard aop client mapping', () => {
       number: 42,
       ci_status: 'passing',
       review_decision: 'approved',
-      merge_score: 100
+      merge_score: 100,
     });
   });
 
@@ -101,16 +101,22 @@ describe('dashboard aop client mapping', () => {
         active: [],
         blocked: [],
         merged: [],
-        blocked_queue: [{ feature_id: 'feature_q', detected_at: '2026-03-03T00:00:00Z', collision_fingerprint: 'abc' }]
+        blocked_queue: [
+          {
+            feature_id: 'feature_q',
+            detected_at: '2026-03-03T00:00:00Z',
+            collision_fingerprint: 'abc',
+          },
+        ],
       }),
-      'utf8'
+      'utf8',
     );
 
     const payload = await readDashboardStatus(repoRoot);
     expect(payload.features).toHaveLength(1);
     expect(payload.features[0]).toMatchObject({
       feature_id: 'feature_q',
-      phase: 'blocked'
+      phase: 'blocked',
     });
   });
 });

package/apps/control-plane/test/dashboard-command.spec.ts

@@ -28,12 +28,12 @@ describe('DashboardCommandHandler', () => {
       'npm',
       ['run', '--workspace', '@aop/web-dashboard', 'build'],
       expect.any(Object),
-      expect.any(Function)
+      expect.any(Function),
     );
     expect(spawn).toHaveBeenCalledWith(
       'npm',
       ['run', '--workspace', '@aop/web-dashboard', 'start'],
-      expect.objectContaining({ detached: true })
+      expect.objectContaining({ detached: true }),
     );
     expect(mockChild.unref).toHaveBeenCalled();
     expect(result).toMatchObject({ ok: true, data: { port: 3000, background: true, built: true } });
@@ -43,7 +43,9 @@ describe('DashboardCommandHandler', () => {
     const { spawn } = await import('node:child_process');
     const mockChild = {
       on: vi.fn((event: string, cb: () => void) => {
-        if (event === 'close') { setTimeout(cb, 0); }
+        if (event === 'close') {
+          setTimeout(cb, 0);
+        }
         return mockChild;
       }),
     } as unknown as ChildProcess;
@@ -55,7 +57,7 @@ describe('DashboardCommandHandler', () => {
     expect(spawn).toHaveBeenCalledWith(
       'npm',
       ['run', '--workspace', '@aop/web-dashboard', 'start'],
-      expect.objectContaining({ stdio: 'inherit' })
+      expect.objectContaining({ stdio: 'inherit' }),
     );
     expect(result).toMatchObject({ ok: true, data: { port: 3000, mode: 'production' } });
   });
@@ -75,7 +77,7 @@ describe('DashboardCommandHandler', () => {
     expect(spawn).toHaveBeenCalledWith(
       'npm',
       ['run', '--workspace', '@aop/web-dashboard', 'start'],
-      expect.objectContaining({ env: expect.objectContaining({ PORT: '4000' }) })
+      expect.objectContaining({ env: expect.objectContaining({ PORT: '4000' }) }),
     );
     expect(result).toMatchObject({ ok: true, data: { port: 4000 } });
   });
@@ -84,7 +86,9 @@ describe('DashboardCommandHandler', () => {
     const { spawn } = await import('node:child_process');
     const mockChild = {
       on: vi.fn((event: string, cb: () => void) => {
-        if (event === 'close') { setTimeout(cb, 0); }
+        if (event === 'close') {
+          setTimeout(cb, 0);
+        }
         return mockChild;
       }),
     } as unknown as ChildProcess;
@@ -96,7 +100,7 @@ describe('DashboardCommandHandler', () => {
     expect(spawn).toHaveBeenCalledWith(
       'npm',
       ['run', '--workspace', '@aop/web-dashboard', 'dev'],
-      expect.objectContaining({ stdio: 'inherit' })
+      expect.objectContaining({ stdio: 'inherit' }),
     );
     expect(result).toMatchObject({ ok: true, data: { mode: 'dev' } });
   });

package/apps/control-plane/test/delete-command-handler.spec.ts

@@ -5,9 +5,11 @@ import { TOOLS } from '../src/core/constants.js';
 
 type ToolClientCall = ReturnType<typeof vi.fn>;
 
-function makeHandler(callImpl: ToolClientCall = vi.fn(async () => ({ ok: true, data: { feature_id: 'feature_a' } }))) {
+function makeHandler(
+  callImpl: ToolClientCall = vi.fn(async () => ({ ok: true, data: { feature_id: 'feature_a' } })),
+) {
   const toolClient = {
-    call: callImpl
+    call: callImpl,
   };
   const handler = new DeleteCommandHandler(toolClient as never, 'run:test');
   return { handler, toolClient };
@@ -15,12 +17,15 @@ function makeHandler(callImpl: ToolClientCall = vi.fn(async () => ({ ok: true, d
 
 describe('DeleteCommandHandler', () => {
   it('GIVEN_valid_defaults_WHEN_execute_called_THEN_calls_feature_delete_in_preview_mode', async () => {
-    const call = vi.fn(async () => ({ ok: true, data: { feature_id: 'feature_a', dry_run: true } }));
+    const call = vi.fn(async () => ({
+      ok: true,
+      data: { feature_id: 'feature_a', dry_run: true },
+    }));
     const { handler, toolClient } = makeHandler(call);
 
     const result = await handler.execute({
       command: 'delete',
-      feature_id: 'feature_a'
+      feature_id: 'feature_a',
     });
 
     expect(toolClient.call).toHaveBeenCalledWith(
@@ -31,40 +36,43 @@ describe('DeleteCommandHandler', () => {
         confirm: false,
         remove_worktree: true,
         remove_branch: 'none',
-        operation_id: expect.any(String)
+        operation_id: expect.any(String),
       }),
       expect.objectContaining({
         run_id: 'run:test',
-        actor_type: 'system'
-      })
+        actor_type: 'system',
+      }),
     );
     expect(result).toMatchObject({
       ok: true,
       data: {
         command: 'delete',
         feature_id: 'feature_a',
-        dry_run: true
-      }
+        dry_run: true,
+      },
     });
   });
 
   it('GIVEN_yes_without_dry_run_WHEN_execute_called_THEN_runs_destructive_mode_by_default', async () => {
-    const call = vi.fn(async () => ({ ok: true, data: { feature_id: 'feature_a', dry_run: false } }));
+    const call = vi.fn(async () => ({
+      ok: true,
+      data: { feature_id: 'feature_a', dry_run: false },
+    }));
     const { handler, toolClient } = makeHandler(call);
 
     await handler.execute({
       command: 'delete',
       feature_id: 'feature_a',
-      yes: true
+      yes: true,
     });
 
     expect(toolClient.call).toHaveBeenCalledWith(
       TOOLS.FEATURE_DELETE,
       expect.objectContaining({
         dry_run: false,
-        confirm: true
+        confirm: true,
       }),
-      expect.any(Object)
+      expect.any(Object),
     );
   });
 
@@ -78,7 +86,7 @@ describe('DeleteCommandHandler', () => {
       yes: true,
       dry_run: true,
       remove_worktree: false,
-      remove_branch: 'force'
+      remove_branch: 'force',
     });
 
     expect(toolClient.call).toHaveBeenCalledWith(
@@ -87,9 +95,9 @@ describe('DeleteCommandHandler', () => {
         dry_run: true,
         confirm: true,
         remove_worktree: false,
-        remove_branch: 'force'
+        remove_branch: 'force',
       }),
-      expect.any(Object)
+      expect.any(Object),
     );
   });
 
@@ -98,13 +106,13 @@ describe('DeleteCommandHandler', () => {
 
     await expect(
       handler.execute({
-        command: 'delete'
-      })
+        command: 'delete',
+      }),
     ).rejects.toMatchObject({
       code: ERROR_CODES.INVALID_CLI_ARGS,
       details: expect.objectContaining({
-        reason: '--feature-id is required for delete'
-      })
+        reason: '--feature-id is required for delete',
+      }),
     });
   });
 
@@ -114,13 +122,13 @@ describe('DeleteCommandHandler', () => {
     await expect(
       handler.execute({
         command: 'delete',
-        feature_id: 'FeatureBad'
-      })
+        feature_id: 'FeatureBad',
+      }),
     ).rejects.toMatchObject({
       code: ERROR_CODES.INVALID_CLI_ARGS,
       details: expect.objectContaining({
-        reason: 'Invalid --feature-id value'
-      })
+        reason: 'Invalid --feature-id value',
+      }),
     });
   });
 
@@ -131,13 +139,13 @@ describe('DeleteCommandHandler', () => {
       handler.execute({
         command: 'delete',
         feature_id: 'feature_a',
-        remove_branch: 'hard'
-      })
+        remove_branch: 'hard',
+      }),
     ).rejects.toMatchObject({
       code: ERROR_CODES.INVALID_CLI_ARGS,
       details: expect.objectContaining({
-        reason: 'Invalid --remove-branch value'
-      })
+        reason: 'Invalid --remove-branch value',
+      }),
     });
   });
 
@@ -149,13 +157,13 @@ describe('DeleteCommandHandler', () => {
         command: 'delete',
         feature_id: 'feature_a',
         dry_run: false,
-        yes: false
-      })
+        yes: false,
+      }),
     ).rejects.toMatchObject({
       code: ERROR_CODES.INVALID_CLI_ARGS,
       details: expect.objectContaining({
-        reason: 'Destructive delete requires --yes'
-      })
+        reason: 'Destructive delete requires --yes',
+      }),
     });
   });
 
@@ -165,21 +173,21 @@ describe('DeleteCommandHandler', () => {
       error: {
         code: ERROR_CODES.RUN_ALREADY_ACTIVE,
         message: 'run active',
-        details: { stale: false }
-      }
+        details: { stale: false },
+      },
     }));
     const { handler } = makeHandler(call);
 
     await expect(
       handler.execute({
         command: 'delete',
-        feature_id: 'feature_a'
-      })
+        feature_id: 'feature_a',
+      }),
     ).rejects.toMatchObject({
       code: ERROR_CODES.RUN_ALREADY_ACTIVE,
       details: {
-        stale: false
-      }
+        stale: false,
+      },
     });
   });
 
@@ -189,14 +197,14 @@ describe('DeleteCommandHandler', () => {
 
     const result = await handler.execute({
       command: 'delete',
-      feature_id: 'feature_a'
+      feature_id: 'feature_a',
     });
 
     expect(result).toEqual({
       ok: true,
       data: {
-        command: 'delete'
-      }
+        command: 'delete',
+      },
     });
   });
 });