@vellumai/assistant 0.10.2 → 0.10.3-dev.202606252046.9075fd5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (546) hide show
  1. package/bun.lock +20 -0
  2. package/docs/workspace-tools.md +42 -33
  3. package/eslint-rules/cli-no-daemon-internals.js +6 -0
  4. package/node_modules/@vellumai/gateway-client/src/__tests__/guardian-delivery-contract.test.ts +91 -0
  5. package/node_modules/@vellumai/gateway-client/src/__tests__/trust-verdict-contract.test.ts +31 -0
  6. package/node_modules/@vellumai/gateway-client/src/gateway-ipc-contracts.ts +44 -0
  7. package/node_modules/@vellumai/gateway-client/src/guardian-delivery-contract.ts +48 -0
  8. package/node_modules/@vellumai/gateway-client/src/index.ts +14 -0
  9. package/node_modules/@vellumai/gateway-client/src/trust-verdict-contract.ts +17 -0
  10. package/node_modules/@vellumai/service-contracts/package.json +1 -0
  11. package/node_modules/@vellumai/service-contracts/src/__tests__/channels.test.ts +28 -0
  12. package/node_modules/@vellumai/service-contracts/src/channels.ts +41 -0
  13. package/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  14. package/openapi.yaml +196 -56
  15. package/package.json +4 -1
  16. package/scripts/test.sh +36 -15
  17. package/src/__tests__/actor-token-service.test.ts +36 -14
  18. package/src/__tests__/actor-trust-resolver-address-fallback.test.ts +83 -31
  19. package/src/__tests__/agent-loop-override-profile.test.ts +1 -0
  20. package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts +2 -0
  21. package/src/__tests__/agent-wake-override-profile.test.ts +2 -0
  22. package/src/__tests__/annotate-activity-metadata.test.ts +2 -0
  23. package/src/__tests__/annotate-risk-options.test.ts +2 -0
  24. package/src/__tests__/approval-cascade.test.ts +2 -0
  25. package/src/__tests__/assistant-attachments.test.ts +42 -0
  26. package/src/__tests__/background-workers-disk-pressure.test.ts +2 -0
  27. package/src/__tests__/btw-routes.test.ts +2 -0
  28. package/src/__tests__/build-persisted-content.test.ts +2 -0
  29. package/src/__tests__/call-controller.test.ts +19 -0
  30. package/src/__tests__/channel-approval-routes.test.ts +21 -26
  31. package/src/__tests__/channel-delivery-store.test.ts +28 -0
  32. package/src/__tests__/channel-guardian.test.ts +164 -78
  33. package/src/__tests__/channel-inbound-disk-pressure.test.ts +11 -19
  34. package/src/__tests__/channel-reply-delivery.test.ts +2 -0
  35. package/src/__tests__/code-search-tool.test.ts +585 -0
  36. package/src/__tests__/compaction-events.test.ts +2 -0
  37. package/src/__tests__/compaction-ledger-store.test.ts +128 -0
  38. package/src/__tests__/compaction.benchmark.test.ts +2 -0
  39. package/src/__tests__/compactor-call-site-logging.test.ts +2 -0
  40. package/src/__tests__/compactor-low-watermark-cut.test.ts +2 -0
  41. package/src/__tests__/compactor-preserved-tail-count.test.ts +2 -0
  42. package/src/__tests__/compactor-summary-call-truncation.test.ts +2 -0
  43. package/src/__tests__/compactor-web-search-strip.test.ts +2 -0
  44. package/src/__tests__/config-loader-backfill.test.ts +123 -10
  45. package/src/__tests__/config-schema.test.ts +1 -0
  46. package/src/__tests__/confirmation-request-guardian-bridge.test.ts +31 -29
  47. package/src/__tests__/consult-deadline.test.ts +60 -0
  48. package/src/__tests__/contact-store-interaction-info.test.ts +156 -0
  49. package/src/__tests__/contact-store-user-file.test.ts +7 -10
  50. package/src/__tests__/contacts-relay-reads.test.ts +19 -24
  51. package/src/__tests__/contacts-write.test.ts +0 -2
  52. package/src/__tests__/conversation-abort-tool-results.test.ts +2 -0
  53. package/src/__tests__/conversation-agent-loop-disk-pressure.test.ts +2 -0
  54. package/src/__tests__/conversation-agent-loop-inference-profile.test.ts +2 -0
  55. package/src/__tests__/conversation-agent-loop-overflow.test.ts +2 -0
  56. package/src/__tests__/conversation-agent-loop.test.ts +134 -0
  57. package/src/__tests__/conversation-analysis-routes.test.ts +2 -0
  58. package/src/__tests__/conversation-app-control-lifecycle.test.ts +2 -0
  59. package/src/__tests__/conversation-attention-telegram.test.ts +9 -11
  60. package/src/__tests__/conversation-confirmation-signals.test.ts +2 -0
  61. package/src/__tests__/conversation-fork-crud.test.ts +354 -24
  62. package/src/__tests__/conversation-history-web-search.test.ts +2 -0
  63. package/src/__tests__/conversation-load-history-repair.test.ts +2 -0
  64. package/src/__tests__/conversation-load-history-stripped.test.ts +2 -0
  65. package/src/__tests__/conversation-pairing.test.ts +2 -0
  66. package/src/__tests__/conversation-process-app-control-preactivation.test.ts +2 -0
  67. package/src/__tests__/conversation-process-callsite.test.ts +2 -0
  68. package/src/__tests__/conversation-provider-retry-repair.test.ts +2 -0
  69. package/src/__tests__/conversation-queue.test.ts +91 -0
  70. package/src/__tests__/conversation-routes-guardian-reply.test.ts +14 -0
  71. package/src/__tests__/conversation-routes-slash-commands.test.ts +14 -0
  72. package/src/__tests__/conversation-slash-queue.test.ts +2 -0
  73. package/src/__tests__/conversation-slash-unknown.test.ts +2 -0
  74. package/src/__tests__/conversation-speed-override.test.ts +2 -0
  75. package/src/__tests__/conversation-surfaces-task-progress.test.ts +29 -0
  76. package/src/__tests__/conversation-title-service.test.ts +2 -0
  77. package/src/__tests__/conversation-tool-setup-attribution.test.ts +47 -0
  78. package/src/__tests__/conversation-usage.test.ts +2 -0
  79. package/src/__tests__/conversation-workspace-cache-state.test.ts +2 -0
  80. package/src/__tests__/conversation-workspace-injection.test.ts +2 -0
  81. package/src/__tests__/conversation-workspace-tool-tracking.test.ts +2 -0
  82. package/src/__tests__/credential-security-invariants.test.ts +1 -1
  83. package/src/__tests__/db-compaction-events-migration.test.ts +129 -0
  84. package/src/__tests__/db-migration-rollback.test.ts +205 -171
  85. package/src/__tests__/db-test-helpers.ts +5 -4
  86. package/src/__tests__/delete-propagation.test.ts +5 -3
  87. package/src/__tests__/deterministic-verification-control-plane.test.ts +4 -2
  88. package/src/__tests__/disk-pressure-guard.test.ts +41 -0
  89. package/src/__tests__/dm-backfill.test.ts +6 -4
  90. package/src/__tests__/dm-persistence.test.ts +2 -0
  91. package/src/__tests__/emit-signal-routing-intent.test.ts +7 -6
  92. package/src/__tests__/events-dev-bypass-actor.test.ts +7 -1
  93. package/src/__tests__/exploration-drift-hook.test.ts +3 -2
  94. package/src/__tests__/filing-service.test.ts +2 -0
  95. package/src/__tests__/guardian-binding-drift-heal.test.ts +104 -19
  96. package/src/__tests__/guardian-dispatch.test.ts +140 -1
  97. package/src/__tests__/guardian-expiry-notifier.test.ts +282 -0
  98. package/src/__tests__/guardian-outbound-http.test.ts +13 -0
  99. package/src/__tests__/guardian-routing-state.test.ts +6 -10
  100. package/src/__tests__/heartbeat-disk-pressure.test.ts +2 -0
  101. package/src/__tests__/heartbeat-service.test.ts +2 -0
  102. package/src/__tests__/helpers/channel-test-adapter.ts +46 -19
  103. package/src/__tests__/helpers/create-guardian-binding.ts +15 -23
  104. package/src/__tests__/helpers/mock-logger.ts +1 -0
  105. package/src/__tests__/helpers/seed-contact-channel.ts +96 -0
  106. package/src/__tests__/host-app-control-routes.test.ts +24 -30
  107. package/src/__tests__/host-bash-routes.test.ts +31 -41
  108. package/src/__tests__/host-browser-routes.test.ts +26 -32
  109. package/src/__tests__/host-cu-routes-targeted.test.ts +25 -33
  110. package/src/__tests__/host-file-routes-targeted.test.ts +40 -52
  111. package/src/__tests__/host-transfer-routes-targeted.test.ts +31 -43
  112. package/src/__tests__/http-user-message-parity.test.ts +290 -8
  113. package/src/__tests__/inbound-invite-redemption.test.ts +115 -10
  114. package/src/__tests__/inbound-slack-persistence.test.ts +2 -0
  115. package/src/__tests__/invite-redemption-service.test.ts +471 -53
  116. package/src/__tests__/invite-routes-http.test.ts +34 -0
  117. package/src/__tests__/invite-service-ipc.test.ts +65 -2
  118. package/src/__tests__/llm-context-normalization.test.ts +105 -0
  119. package/src/__tests__/llm-request-log-error-payload.test.ts +71 -9
  120. package/src/__tests__/llm-usage-store.test.ts +25 -0
  121. package/src/__tests__/mcp-config-secret-boundary.test.ts +392 -0
  122. package/src/__tests__/mcp-health-check.test.ts +2 -1
  123. package/src/__tests__/media-stream-server-integration.test.ts +127 -0
  124. package/src/__tests__/memory-retrieval-hook.test.ts +2 -0
  125. package/src/__tests__/messaging-send-tool.test.ts +2 -0
  126. package/src/__tests__/migration-import-from-url.test.ts +2 -2
  127. package/src/__tests__/mtime-cache.test.ts +275 -5
  128. package/src/__tests__/native-web-search.test.ts +2 -0
  129. package/src/__tests__/non-member-access-request.test.ts +191 -17
  130. package/src/__tests__/notification-broadcaster.test.ts +4 -0
  131. package/src/__tests__/notification-decision-recipient-context.test.ts +33 -32
  132. package/src/__tests__/notification-deep-link.test.ts +6 -0
  133. package/src/__tests__/notification-guardian-path.test.ts +19 -0
  134. package/src/__tests__/onboarding-persona-write.test.ts +52 -22
  135. package/src/__tests__/openai-provider.test.ts +22 -12
  136. package/src/__tests__/openai-responses-provider.test.ts +12 -2
  137. package/src/__tests__/outbound-slack-persistence.test.ts +2 -0
  138. package/src/__tests__/pending-interactions-resolved-event.test.ts +7 -4
  139. package/src/__tests__/persist-onboarding-artifacts.test.ts +1 -0
  140. package/src/__tests__/persistence-secret-redaction.test.ts +2 -0
  141. package/src/__tests__/persona-resolver.test.ts +75 -45
  142. package/src/__tests__/plugin-bootstrap.test.ts +21 -83
  143. package/src/__tests__/plugin-disabled-state.test.ts +190 -0
  144. package/src/__tests__/plugin-pipeline.test.ts +96 -0
  145. package/src/__tests__/plugin-route-contribution.test.ts +6 -19
  146. package/src/__tests__/plugin-tool-contribution.test.ts +5 -20
  147. package/src/__tests__/plugin-types.test.ts +2 -4
  148. package/src/__tests__/process-message-background-slack.test.ts +2 -0
  149. package/src/__tests__/process-message-display-content.test.ts +2 -0
  150. package/src/__tests__/provider-error-scenarios.test.ts +5 -4
  151. package/src/__tests__/provider-usage-tracking.test.ts +39 -0
  152. package/src/__tests__/reaction-intercept-cold-cache-warm.test.ts +135 -0
  153. package/src/__tests__/reaction-intercept-member-verdict-warm.test.ts +158 -0
  154. package/src/__tests__/reaction-persistence.test.ts +51 -4
  155. package/src/__tests__/regenerate-fire-and-forget-trace.test.ts +2 -0
  156. package/src/__tests__/registry.test.ts +4 -1
  157. package/src/__tests__/relay-server.test.ts +758 -32
  158. package/src/__tests__/runtime-attachment-metadata.test.ts +9 -12
  159. package/src/__tests__/secret-ingress-http.test.ts +14 -0
  160. package/src/__tests__/send-endpoint-busy.test.ts +30 -8
  161. package/src/__tests__/settings-routes.test.ts +32 -0
  162. package/src/__tests__/skills.test.ts +44 -0
  163. package/src/__tests__/slack-inbound-verification.test.ts +47 -2
  164. package/src/__tests__/sse-actor-principal-guardian-source.test.ts +79 -0
  165. package/src/__tests__/steer-on-enqueue-question.test.ts +181 -0
  166. package/src/__tests__/stt-hints.test.ts +49 -15
  167. package/src/__tests__/subagent-detail.test.ts +27 -0
  168. package/src/__tests__/subagent-disposal.test.ts +65 -0
  169. package/src/__tests__/subagent-fork-prompt-role.test.ts +195 -0
  170. package/src/__tests__/subagent-fork-spawn.test.ts +6 -7
  171. package/src/__tests__/subagent-notify-parent.test.ts +2 -0
  172. package/src/__tests__/subagent-role-registry.test.ts +24 -6
  173. package/src/__tests__/subagent-spawn-and-await.test.ts +546 -0
  174. package/src/__tests__/subagent-spawn-tool-fork.test.ts +2 -0
  175. package/src/__tests__/subagent-tools.test.ts +398 -1
  176. package/src/__tests__/suggestion-routes.test.ts +2 -0
  177. package/src/__tests__/thread-backfill.test.ts +3 -3
  178. package/src/__tests__/title-generate-hook.test.ts +2 -0
  179. package/src/__tests__/tool-executor-lifecycle-events.test.ts +2 -0
  180. package/src/__tests__/tool-executor.test.ts +16 -11
  181. package/src/__tests__/tool-preview-lifecycle.test.ts +2 -0
  182. package/src/__tests__/tool-result-metadata-plumbing.test.ts +2 -0
  183. package/src/__tests__/tool-start-timestamp.test.ts +2 -0
  184. package/src/__tests__/trusted-contact-approval-notifier.test.ts +37 -51
  185. package/src/__tests__/trusted-contact-inline-approval-integration.test.ts +12 -12
  186. package/src/__tests__/trusted-contact-lifecycle-notifications.test.ts +9 -7
  187. package/src/__tests__/trusted-contact-multichannel.test.ts +16 -7
  188. package/src/__tests__/trusted-contact-verification.test.ts +79 -54
  189. package/src/__tests__/twilio-routes.test.ts +96 -0
  190. package/src/__tests__/ui-file-upload-surface.test.ts +86 -0
  191. package/src/__tests__/verification-control-plane-policy.test.ts +2 -0
  192. package/src/__tests__/voice-guardian-cold-cache-warm.test.ts +137 -0
  193. package/src/__tests__/voice-invite-redemption.test.ts +216 -20
  194. package/src/__tests__/web-search-backend-failure.test.ts +2 -0
  195. package/src/__tests__/workspace-migration-102-preserve-heartbeat-enabled-for-existing-workspaces.test.ts +3 -3
  196. package/src/__tests__/workspace-migration-111-prune-seeded-callsite-defaults.test.ts +208 -0
  197. package/src/__tests__/workspace-migration-112-remove-advisor-callsite-override.test.ts +170 -0
  198. package/src/__tests__/workspace-migration-drop-user-md.test.ts +196 -238
  199. package/src/__tests__/workspace-migration-remove-hooks.test.ts +14 -35
  200. package/src/__tests__/workspace-tool-loader.test.ts +195 -2
  201. package/src/a2a/__tests__/e2e-a2a-channel.test.ts +35 -47
  202. package/src/agent/loop-exclusive-tool.test.ts +154 -0
  203. package/src/agent/loop-native-web-search.test.ts +200 -0
  204. package/src/agent/loop.ts +164 -1
  205. package/src/api/constants/sse-replay.ts +41 -0
  206. package/src/api/events/conversation-notice.ts +26 -0
  207. package/src/api/index.ts +19 -1
  208. package/src/api/responses/llm-request-log-entry.ts +29 -0
  209. package/src/api/responses/subagent-detail.ts +17 -0
  210. package/src/api/surfaces.ts +39 -3
  211. package/src/approvals/guardian-channel-delivery.ts +30 -0
  212. package/src/approvals/guardian-expiry-notifier.ts +148 -0
  213. package/src/approvals/guardian-request-resolvers.ts +17 -15
  214. package/src/calls/__tests__/relay-setup-router.test.ts +267 -17
  215. package/src/calls/call-domain.ts +3 -3
  216. package/src/calls/guardian-dispatch.ts +14 -9
  217. package/src/calls/inbound-trust-reader.ts +24 -2
  218. package/src/calls/media-stream-server.ts +21 -0
  219. package/src/calls/relay-access-wait.ts +6 -6
  220. package/src/calls/relay-server.ts +188 -51
  221. package/src/calls/relay-setup-router.ts +47 -17
  222. package/src/calls/relay-verification.ts +4 -4
  223. package/src/calls/stt-hints.ts +9 -12
  224. package/src/calls/twilio-routes.ts +14 -4
  225. package/src/channels/types.ts +10 -20
  226. package/src/cli/commands/__tests__/cache.test.ts +8 -1
  227. package/src/cli/commands/__tests__/conversations-slack.test.ts +1 -0
  228. package/src/cli/commands/cache.ts +194 -181
  229. package/src/cli/commands/contacts.ts +10 -7
  230. package/src/cli/commands/db/__tests__/repair.test.ts +6 -5
  231. package/src/cli/commands/db/status.ts +37 -1
  232. package/src/cli/commands/mcp.ts +252 -218
  233. package/src/cli/commands/memory/__tests__/worker.test.ts +432 -0
  234. package/src/cli/commands/memory/index.ts +2 -0
  235. package/src/cli/commands/memory/worker.ts +242 -0
  236. package/src/cli/commands/plugins.ts +125 -13
  237. package/src/cli/lib/__tests__/install-from-github.test.ts +102 -0
  238. package/src/cli/lib/__tests__/list-installed-plugins.test.ts +160 -1
  239. package/src/cli/lib/__tests__/publish-plugin.test.ts +404 -0
  240. package/src/cli/lib/list-installed-plugins.ts +179 -1
  241. package/src/cli/lib/publish-plugin.ts +633 -0
  242. package/src/config/__tests__/loader-callsite-strip-fallback.test.ts +143 -0
  243. package/src/config/__tests__/sync-gated-profiles.test.ts +16 -10
  244. package/src/config/bundled-skills/contacts/tools/contact-merge.ts +27 -17
  245. package/src/config/bundled-skills/contacts/tools/contact-search.ts +13 -3
  246. package/src/config/bundled-skills/subagent/SKILL.md +17 -2
  247. package/src/config/bundled-skills/subagent/TOOLS.json +5 -4
  248. package/src/config/call-site-defaults.ts +0 -6
  249. package/src/config/feature-flag-registry.json +5 -13
  250. package/src/config/llm-resolver.ts +0 -3
  251. package/src/config/loader.ts +38 -5
  252. package/src/config/prune-seeded-callsite-defaults.ts +110 -0
  253. package/src/config/schemas/__tests__/memory-v3.test.ts +1 -0
  254. package/src/config/schemas/call-site-catalog.ts +0 -7
  255. package/src/config/schemas/heartbeat.ts +2 -5
  256. package/src/config/schemas/llm.ts +3 -12
  257. package/src/config/schemas/memory-lifecycle.ts +12 -0
  258. package/src/config/schemas/memory-v3.ts +7 -0
  259. package/src/config/schemas/memory.ts +4 -0
  260. package/src/config/schemas/timeouts.ts +8 -0
  261. package/src/config/seed-inference-profiles.ts +30 -34
  262. package/src/config/skills.ts +27 -5
  263. package/src/config/sync-gated-profiles.ts +12 -16
  264. package/src/contacts/__tests__/contacts-write-revoke-relay.test.ts +128 -0
  265. package/src/contacts/__tests__/guardian-delivery-reader.test.ts +312 -0
  266. package/src/contacts/__tests__/member-write-relay.test.ts +226 -0
  267. package/src/contacts/contact-store.ts +27 -237
  268. package/src/contacts/contacts-write.ts +18 -55
  269. package/src/contacts/gateway-channel-read.ts +51 -0
  270. package/src/contacts/guardian-delivery-reader.ts +223 -0
  271. package/src/contacts/member-write-relay.ts +183 -0
  272. package/src/contacts/types.ts +3 -15
  273. package/src/daemon/__tests__/conversation-tool-setup-exclude.test.ts +35 -0
  274. package/src/daemon/__tests__/conversation-tool-setup.test.ts +0 -44
  275. package/src/daemon/assistant-attachments.ts +27 -4
  276. package/src/daemon/conversation-agent-loop.ts +28 -0
  277. package/src/daemon/conversation-notices.ts +60 -0
  278. package/src/daemon/conversation-process.ts +35 -16
  279. package/src/daemon/conversation-surfaces.ts +111 -38
  280. package/src/daemon/conversation-tool-setup.ts +71 -30
  281. package/src/daemon/conversation.ts +23 -1
  282. package/src/daemon/disk-pressure-guard.ts +12 -2
  283. package/src/daemon/event-loop-watchdog.ts +28 -1
  284. package/src/daemon/external-plugins-bootstrap.ts +17 -41
  285. package/src/daemon/handlers/__tests__/config-a2a-accept.test.ts +0 -1
  286. package/src/daemon/handlers/__tests__/config-a2a-complete.test.ts +0 -2
  287. package/src/daemon/handlers/__tests__/config-a2a-redeem.test.ts +25 -2
  288. package/src/daemon/handlers/__tests__/config-channels.test.ts +220 -0
  289. package/src/daemon/handlers/config-a2a.ts +6 -14
  290. package/src/daemon/handlers/config-channels.ts +67 -26
  291. package/src/daemon/handlers/conversations.ts +77 -0
  292. package/src/daemon/lifecycle.ts +16 -0
  293. package/src/daemon/mcp-reload-service.ts +10 -0
  294. package/src/daemon/memory-v2-startup.test.ts +72 -0
  295. package/src/daemon/memory-v2-startup.ts +87 -19
  296. package/src/daemon/message-types/conversations.ts +2 -0
  297. package/src/daemon/message-types/surfaces.ts +12 -12
  298. package/src/daemon/server.ts +0 -4
  299. package/src/daemon/shutdown-handlers.ts +20 -0
  300. package/src/daemon/tool-setup-types.ts +9 -0
  301. package/src/heartbeat/heartbeat-service.ts +5 -0
  302. package/src/home/relationship-state-writer.ts +5 -0
  303. package/src/hooks/hook-loader.ts +341 -0
  304. package/src/ipc/__tests__/clients-list-ipc.test.ts +1 -1
  305. package/src/ipc/assistant-server.ts +2 -2
  306. package/src/mcp/__tests__/mcp-auth-orchestrator.test.ts +1 -0
  307. package/src/mcp/client.ts +15 -1
  308. package/src/mcp/mcp-auth-orchestrator.ts +6 -1
  309. package/src/mcp/mcp-header-store.ts +134 -0
  310. package/src/mcp/mcp-oauth-provider.ts +19 -8
  311. package/src/memory/__tests__/301-create-watchdog-events.test.ts +110 -0
  312. package/src/memory/__tests__/memory-retrospective-job.test.ts +8 -0
  313. package/src/memory/__tests__/prompt-override.test.ts +192 -0
  314. package/src/memory/__tests__/watchdog-events-store.test.ts +161 -0
  315. package/src/memory/compaction-ledger-store.ts +107 -0
  316. package/src/memory/conversation-crud.ts +129 -61
  317. package/src/memory/db-connection.ts +22 -3
  318. package/src/memory/db-init.ts +37 -503
  319. package/src/memory/db-singleton.ts +6 -4
  320. package/src/memory/jobs-worker.ts +104 -0
  321. package/src/memory/llm-request-log-store.ts +26 -1
  322. package/src/memory/llm-usage-store.ts +48 -20
  323. package/src/memory/memory-retrospective-job.ts +14 -8
  324. package/src/memory/migrations/209-strip-thinking-from-consolidated.ts +152 -56
  325. package/src/memory/migrations/300-add-processing-started-at.ts +30 -0
  326. package/src/memory/migrations/301-create-watchdog-events.ts +45 -0
  327. package/src/memory/migrations/302-create-compaction-events.ts +107 -0
  328. package/src/memory/migrations/__tests__/209-strip-thinking-from-consolidated.test.ts +297 -0
  329. package/src/memory/migrations/__tests__/run-migrations.test.ts +2 -2
  330. package/src/memory/migrations/run-migrations.ts +106 -10
  331. package/src/memory/migrations/validate-migration-state.ts +105 -67
  332. package/src/memory/prompt-override.ts +129 -0
  333. package/src/memory/schema/contacts.ts +6 -2
  334. package/src/memory/schema/conversations.ts +37 -0
  335. package/src/memory/schema/infrastructure.ts +20 -0
  336. package/src/memory/steps.ts +1294 -0
  337. package/src/memory/v2/__tests__/cli-command-store.test.ts +25 -0
  338. package/src/memory/v2/__tests__/skill-store.test.ts +80 -0
  339. package/src/memory/v2/cli-command-store.ts +75 -38
  340. package/src/memory/v2/prompts/consolidation.ts +13 -82
  341. package/src/memory/v2/prompts/router.ts +21 -93
  342. package/src/memory/v2/skill-store.ts +68 -31
  343. package/src/memory/watchdog-events-store.ts +87 -0
  344. package/src/memory/worker-control.ts +204 -0
  345. package/src/memory/worker-process.ts +89 -0
  346. package/src/messaging/channel-binding-metadata.ts +31 -0
  347. package/src/messaging/provider-types.ts +8 -0
  348. package/src/messaging/providers/slack/binding-metadata.ts +60 -0
  349. package/src/notifications/__tests__/broadcaster.test.ts +8 -8
  350. package/src/notifications/__tests__/connected-channels.test.ts +86 -0
  351. package/src/notifications/__tests__/decision-engine.test.ts +78 -9
  352. package/src/notifications/__tests__/destination-resolver.test.ts +151 -0
  353. package/src/notifications/broadcaster.ts +8 -1
  354. package/src/notifications/decision-engine.ts +15 -7
  355. package/src/notifications/destination-resolver.ts +53 -25
  356. package/src/notifications/emit-signal.ts +34 -15
  357. package/src/onboarding/checkin-event.test.ts +222 -0
  358. package/src/onboarding/checkin-event.ts +321 -0
  359. package/src/onboarding/schedule-checkin.ts +190 -0
  360. package/src/permissions/question-prompter.test.ts +1 -1
  361. package/src/permissions/question-prompter.ts +7 -4
  362. package/src/plugin-api/index.ts +12 -12
  363. package/src/plugin-api/types.ts +12 -14
  364. package/src/plugin-api/vision-support.test.ts +28 -4
  365. package/src/plugin-api/vision-support.ts +66 -31
  366. package/src/plugins/defaults/empty-response/hooks/post-model-call.ts +2 -2
  367. package/src/plugins/defaults/empty-response/hooks/stop.ts +2 -2
  368. package/src/plugins/defaults/exploration-drift/hooks/post-tool-use.ts +4 -3
  369. package/src/plugins/defaults/history-repair/hooks/post-model-call.ts +2 -2
  370. package/src/plugins/defaults/history-repair/hooks/stop.ts +2 -2
  371. package/src/plugins/defaults/history-repair/hooks/user-prompt-submit.ts +2 -2
  372. package/src/plugins/defaults/image-fallback/__tests__/image-fallback.test.ts +47 -7
  373. package/src/plugins/defaults/image-fallback/hooks/post-tool-use.ts +12 -13
  374. package/src/plugins/defaults/image-fallback/hooks/user-prompt-submit.ts +14 -22
  375. package/src/plugins/defaults/image-fallback/src/caption-blocks.ts +42 -11
  376. package/src/plugins/defaults/image-recovery/hooks/post-model-call.ts +2 -2
  377. package/src/plugins/defaults/image-recovery/hooks/stop.ts +2 -2
  378. package/src/plugins/defaults/index.ts +0 -35
  379. package/src/plugins/defaults/max-tokens-continue/hooks/post-model-call.ts +2 -2
  380. package/src/plugins/defaults/max-tokens-continue/hooks/stop.ts +2 -2
  381. package/src/plugins/defaults/memory-retrieval/hooks/post-compact.ts +2 -2
  382. package/src/plugins/defaults/memory-retrieval/hooks/user-prompt-submit.ts +2 -2
  383. package/src/plugins/defaults/memory-v3-shadow/__tests__/injection.test.ts +33 -3
  384. package/src/plugins/defaults/memory-v3-shadow/__tests__/pool-select.test.ts +48 -4
  385. package/src/plugins/defaults/memory-v3-shadow/__tests__/shadow-plugin.test.ts +4 -8
  386. package/src/plugins/defaults/memory-v3-shadow/hooks/post-compact.ts +2 -2
  387. package/src/plugins/defaults/memory-v3-shadow/hooks/user-prompt-submit.ts +2 -2
  388. package/src/plugins/defaults/memory-v3-shadow/injector.ts +43 -15
  389. package/src/plugins/defaults/memory-v3-shadow/orchestrate.ts +11 -2
  390. package/src/plugins/defaults/memory-v3-shadow/pool-select.test.ts +146 -0
  391. package/src/plugins/defaults/memory-v3-shadow/pool-select.ts +77 -13
  392. package/src/plugins/defaults/memory-v3-shadow/shadow-plugin.ts +12 -11
  393. package/src/plugins/defaults/surface-completion-nudge/hooks/post-model-call.ts +2 -2
  394. package/src/plugins/defaults/surface-completion-nudge/hooks/stop.ts +2 -2
  395. package/src/plugins/defaults/task-progress-nudge/hooks/post-tool-use.ts +2 -2
  396. package/src/plugins/defaults/title-generate/hooks/stop.ts +2 -2
  397. package/src/plugins/defaults/title-generate/hooks/user-prompt-submit.ts +2 -2
  398. package/src/plugins/defaults/tool-error/hooks/post-tool-use.ts +2 -2
  399. package/src/plugins/defaults/tool-result-truncate/hooks/post-tool-use.ts +2 -2
  400. package/src/plugins/disabled-state.ts +31 -0
  401. package/src/plugins/external-plugin-loader.ts +2 -2
  402. package/src/plugins/mtime-cache.ts +186 -330
  403. package/src/plugins/pipeline.ts +111 -13
  404. package/src/plugins/registry.ts +59 -16
  405. package/src/plugins/surface-import.ts +121 -0
  406. package/src/plugins/types.ts +7 -9
  407. package/src/prompts/persona-resolver.ts +43 -11
  408. package/src/providers/anthropic/client.ts +5 -0
  409. package/src/providers/call-site-routing.ts +45 -0
  410. package/src/providers/model-catalog.ts +16 -0
  411. package/src/providers/openai/__tests__/api-error-normalization.test.ts +321 -0
  412. package/src/providers/openai/api-error-normalization.ts +270 -0
  413. package/src/providers/openai/chat-completions-provider.ts +37 -83
  414. package/src/providers/openai/responses-provider.ts +50 -46
  415. package/src/providers/openrouter/client.ts +5 -0
  416. package/src/providers/provider-send-message.ts +10 -0
  417. package/src/providers/ratelimit.ts +10 -0
  418. package/src/providers/registry.ts +1 -1
  419. package/src/providers/retry.ts +10 -0
  420. package/src/providers/types.ts +22 -0
  421. package/src/providers/usage-tracking.ts +10 -0
  422. package/src/runtime/__tests__/channel-verification-service.test.ts +133 -0
  423. package/src/runtime/__tests__/guardian-vellum-migration.test.ts +184 -0
  424. package/src/runtime/__tests__/is-guardian-bound-for-channel.test.ts +66 -0
  425. package/src/runtime/__tests__/local-principal-trust.test.ts +162 -0
  426. package/src/runtime/__tests__/member-verdict-cache.test.ts +119 -0
  427. package/src/runtime/__tests__/trust-verdict-consumer.test.ts +402 -123
  428. package/src/runtime/access-request-helper.ts +18 -39
  429. package/src/runtime/actor-trust-resolver.ts +46 -19
  430. package/src/runtime/anchored-guardian.test.ts +109 -0
  431. package/src/runtime/anchored-guardian.ts +86 -0
  432. package/src/runtime/assistant-event-hub.ts +1 -1
  433. package/src/runtime/assistant-stream-state.ts +9 -2
  434. package/src/runtime/auth/__tests__/require-bound-guardian.test.ts +99 -0
  435. package/src/runtime/auth/require-bound-guardian.ts +21 -11
  436. package/src/runtime/channel-verification-service.ts +56 -31
  437. package/src/runtime/confirmation-request-guardian-bridge.ts +3 -3
  438. package/src/runtime/guardian-vellum-migration.ts +69 -8
  439. package/src/runtime/invite-redemption-service.ts +213 -187
  440. package/src/runtime/local-actor-identity.test.ts +108 -0
  441. package/src/runtime/local-actor-identity.ts +85 -13
  442. package/src/runtime/local-principal-trust.ts +52 -0
  443. package/src/runtime/member-verdict-cache.ts +0 -0
  444. package/src/runtime/pending-interactions.ts +11 -1
  445. package/src/runtime/routes/__tests__/channel-verification-revoke.test.ts +56 -5
  446. package/src/runtime/routes/__tests__/channel-verification-routes.test.ts +1 -1
  447. package/src/runtime/routes/__tests__/contact-routes.test.ts +305 -0
  448. package/src/runtime/routes/__tests__/global-search-routes.test.ts +92 -0
  449. package/src/runtime/routes/__tests__/http-adapter-actor-header.test.ts +129 -0
  450. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +188 -0
  451. package/src/runtime/routes/browser-routes.ts +1 -1
  452. package/src/runtime/routes/canonical-guardian-expiry-sweep.ts +13 -5
  453. package/src/runtime/routes/channel-verification-routes.ts +3 -3
  454. package/src/runtime/routes/contact-routes.ts +48 -57
  455. package/src/runtime/routes/conversation-cli-routes.ts +4 -5
  456. package/src/runtime/routes/conversation-list-routes.ts +4 -7
  457. package/src/runtime/routes/conversation-query-routes.ts +72 -0
  458. package/src/runtime/routes/conversation-routes.ts +84 -85
  459. package/src/runtime/routes/events-routes.ts +2 -2
  460. package/src/runtime/routes/global-search-routes.ts +3 -1
  461. package/src/runtime/routes/guardian-action-routes.ts +4 -5
  462. package/src/runtime/routes/host-app-control-routes.ts +5 -4
  463. package/src/runtime/routes/host-bash-routes.ts +5 -4
  464. package/src/runtime/routes/host-browser-routes.ts +9 -11
  465. package/src/runtime/routes/host-cu-routes.ts +5 -4
  466. package/src/runtime/routes/host-file-routes.ts +5 -4
  467. package/src/runtime/routes/host-transfer-routes.ts +6 -6
  468. package/src/runtime/routes/http-adapter.ts +16 -1
  469. package/src/runtime/routes/identity-routes.ts +3 -2
  470. package/src/runtime/routes/inbound-message-handler.ts +5 -5
  471. package/src/runtime/routes/inbound-stages/acl-enforcement.test.ts +97 -5
  472. package/src/runtime/routes/inbound-stages/acl-enforcement.ts +61 -59
  473. package/src/runtime/routes/inbound-stages/background-dispatch.ts +13 -5
  474. package/src/runtime/routes/inbound-stages/escalation-intercept.ts +7 -7
  475. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.test.ts +21 -8
  476. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.ts +14 -3
  477. package/src/runtime/routes/inbound-stages/reaction-intercept.ts +19 -0
  478. package/src/runtime/routes/index.ts +2 -0
  479. package/src/runtime/routes/llm-context-normalization.ts +83 -0
  480. package/src/runtime/routes/mcp-auth-routes.ts +171 -19
  481. package/src/runtime/routes/migration-rollback-routes.ts +4 -3
  482. package/src/runtime/routes/migration-routes.ts +4 -1
  483. package/src/runtime/routes/onboarding-checkin-routes.ts +86 -0
  484. package/src/runtime/routes/settings-routes.ts +8 -3
  485. package/src/runtime/routes/subagents-routes.ts +5 -0
  486. package/src/runtime/routes/surface-action-routes.ts +42 -56
  487. package/src/runtime/services/__tests__/conversation-serializer.test.ts +1 -0
  488. package/src/runtime/services/conversation-serializer.ts +13 -58
  489. package/src/runtime/tool-grant-request-helper.ts +3 -3
  490. package/src/runtime/trust-verdict-consumer.ts +111 -40
  491. package/src/runtime/verification-outbound-actions.ts +18 -18
  492. package/src/signals/user-message.ts +16 -0
  493. package/src/subagent/__tests__/consult-prompt.test.ts +35 -0
  494. package/src/{plugins/defaults/advisor/__tests__/transcript.test.ts → subagent/__tests__/consult-transcript.test.ts} +47 -10
  495. package/src/{plugins/defaults/advisor/steering.ts → subagent/consult-prompt.ts} +22 -32
  496. package/src/{plugins/defaults/advisor/transcript.ts → subagent/consult-transcript.ts} +18 -8
  497. package/src/subagent/index.ts +1 -1
  498. package/src/subagent/manager.ts +254 -33
  499. package/src/subagent/types.ts +11 -4
  500. package/src/telemetry/types.ts +34 -1
  501. package/src/telemetry/usage-telemetry-reporter.test.ts +3 -2
  502. package/src/telemetry/usage-telemetry-reporter.ts +87 -3
  503. package/src/tools/ask-question/ask-question-tool.test.ts +29 -0
  504. package/src/tools/ask-question/ask-question-tool.ts +13 -0
  505. package/src/tools/executor.ts +4 -4
  506. package/src/tools/filesystem/search.ts +543 -0
  507. package/src/tools/registry.ts +38 -0
  508. package/src/tools/shared/filesystem/path-policy.ts +12 -5
  509. package/src/tools/subagent/consult-deadline.ts +49 -0
  510. package/src/tools/subagent/spawn.ts +234 -5
  511. package/src/tools/tool-approval-handler.ts +1 -1
  512. package/src/tools/tool-defaults.ts +9 -2
  513. package/src/tools/tool-manifest.ts +3 -0
  514. package/src/tools/types.ts +131 -25
  515. package/src/tools/workspace-tools/loader.ts +348 -244
  516. package/src/util/errors.ts +26 -1
  517. package/src/util/logger.ts +9 -0
  518. package/src/util/platform.ts +19 -0
  519. package/src/util/telemetry-db-path.ts +24 -0
  520. package/src/workflows/library.test.ts +140 -0
  521. package/src/workflows/library.ts +82 -28
  522. package/src/workspace/migrations/017-seed-persona-dirs.ts +3 -34
  523. package/src/workspace/migrations/019-scope-journal-to-guardian.ts +3 -24
  524. package/src/workspace/migrations/031-drop-user-md.ts +232 -148
  525. package/src/workspace/migrations/048-remove-workspace-hooks.ts +14 -66
  526. package/src/workspace/migrations/111-prune-seeded-callsite-defaults.ts +134 -0
  527. package/src/workspace/migrations/112-remove-advisor-callsite-override.ts +64 -0
  528. package/src/workspace/migrations/registry.ts +4 -0
  529. package/src/__tests__/workspace-tools-watcher-flag.test.ts +0 -70
  530. package/src/daemon/workspace-tools-watcher.ts +0 -328
  531. package/src/memory/migrations/registry.ts +0 -573
  532. package/src/plugins/defaults/advisor/__tests__/advisor-gate.test.ts +0 -56
  533. package/src/plugins/defaults/advisor/__tests__/advisor-state-store.test.ts +0 -43
  534. package/src/plugins/defaults/advisor/__tests__/agent-loop-integration.test.ts +0 -137
  535. package/src/plugins/defaults/advisor/__tests__/consult.test.ts +0 -153
  536. package/src/plugins/defaults/advisor/__tests__/hooks.test.ts +0 -138
  537. package/src/plugins/defaults/advisor/advisor-gate.ts +0 -29
  538. package/src/plugins/defaults/advisor/advisor-state-store.ts +0 -94
  539. package/src/plugins/defaults/advisor/config.ts +0 -21
  540. package/src/plugins/defaults/advisor/consult.ts +0 -93
  541. package/src/plugins/defaults/advisor/hooks/post-model-call.ts +0 -34
  542. package/src/plugins/defaults/advisor/hooks/pre-model-call.ts +0 -30
  543. package/src/plugins/defaults/advisor/hooks/user-prompt-submit.ts +0 -19
  544. package/src/plugins/defaults/advisor/package.json +0 -14
  545. package/src/plugins/defaults/advisor/tools/advisor.ts +0 -65
  546. package/src/providers/openai/__tests__/api-error-detail.test.ts +0 -120
@@ -0,0 +1,86 @@
1
+ /**
2
+ * Tests for getConnectedChannels connectivity resolution.
3
+ *
4
+ * Connectivity mirrors destination-resolver's `resolveGuardian`: guardian
5
+ * delivery is sourced solely from the gateway. A channel with no active gateway
6
+ * binding is not connected, keeping connectivity aligned with deliverability.
7
+ */
8
+
9
+ import { beforeEach, describe, expect, mock, test } from "bun:test";
10
+
11
+ import type { GuardianDelivery } from "@vellumai/gateway-client";
12
+
13
+ mock.module("../../util/logger.js", () => ({
14
+ getLogger: () =>
15
+ new Proxy({} as Record<string, unknown>, { get: () => () => {} }),
16
+ truncateForLog: (value: string) => value,
17
+ }));
18
+
19
+ let deliverableChannels: string[] = [];
20
+ let gatewayGuardians: GuardianDelivery[] | null = null;
21
+
22
+ const realConfig = await import("../../channels/config.js");
23
+
24
+ mock.module("../../channels/config.js", () => ({
25
+ ...realConfig,
26
+ getDeliverableChannels: () => deliverableChannels,
27
+ }));
28
+
29
+ const realReader = await import("../../contacts/guardian-delivery-reader.js");
30
+
31
+ mock.module("../../contacts/guardian-delivery-reader.js", () => ({
32
+ ...realReader,
33
+ getGuardianDelivery: async () => gatewayGuardians,
34
+ }));
35
+
36
+ const { getConnectedChannels } = await import("../emit-signal.js");
37
+
38
+ function gatewayBinding(channelType: string, externalChatId: string): GuardianDelivery {
39
+ return { channelType, contactId: "c1", address: "addr", externalChatId, status: "active" };
40
+ }
41
+
42
+ beforeEach(() => {
43
+ deliverableChannels = [];
44
+ gatewayGuardians = null;
45
+ });
46
+
47
+ describe("getConnectedChannels gateway connectivity", () => {
48
+ test("marks telegram connected from a gateway binding", async () => {
49
+ deliverableChannels = ["telegram"];
50
+ gatewayGuardians = [gatewayBinding("telegram", "123")];
51
+
52
+ expect(await getConnectedChannels()).toContain("telegram");
53
+ });
54
+
55
+ test("marks telegram disconnected when the gateway is unreachable (null)", async () => {
56
+ deliverableChannels = ["telegram"];
57
+ gatewayGuardians = null;
58
+
59
+ expect(await getConnectedChannels()).not.toContain("telegram");
60
+ });
61
+
62
+ test("marks telegram disconnected when the gateway has no binding", async () => {
63
+ deliverableChannels = ["telegram"];
64
+ gatewayGuardians = [];
65
+
66
+ expect(await getConnectedChannels()).not.toContain("telegram");
67
+ });
68
+
69
+ test("only marks slack connected for D-prefixed (DM) chat IDs", async () => {
70
+ deliverableChannels = ["slack"];
71
+ gatewayGuardians = [gatewayBinding("slack", "C-public")];
72
+ expect(await getConnectedChannels()).not.toContain("slack");
73
+
74
+ gatewayGuardians = [gatewayBinding("slack", "D-dm")];
75
+ expect(await getConnectedChannels()).toContain("slack");
76
+ });
77
+
78
+ test("always reports vellum and platform connected", async () => {
79
+ deliverableChannels = ["vellum", "platform"];
80
+ gatewayGuardians = null;
81
+
82
+ const connected = await getConnectedChannels();
83
+ expect(connected).toContain("vellum");
84
+ expect(connected).toContain("platform");
85
+ });
86
+ });
@@ -34,19 +34,38 @@ mock.module("../../prompts/system-prompt.js", () => ({
34
34
  buildCoreIdentityContext: () => null,
35
35
  }));
36
36
 
37
+ // Guardian binding (ACL) is resolved via the gateway pull; notes (INFO) are
38
+ // joined locally by contactId. Tests drive both via mutable slots.
39
+ let guardianDeliveryFixture: Array<{ contactId: string }> = [];
40
+ let contactInfoFixture: Record<string, { notes: string | null } | null> = {};
41
+
42
+ mock.module("../../contacts/guardian-delivery-reader.js", () => ({
43
+ getGuardianDelivery: async () => guardianDeliveryFixture,
44
+ anyGuardian: (list: Array<{ contactId: string }>) => list[0],
45
+ }));
46
+
37
47
  mock.module("../../contacts/contact-store.js", () => ({
38
- listGuardianChannels: () => null,
48
+ findContactInfoById: (contactId: string) =>
49
+ contactInfoFixture[contactId] ?? null,
39
50
  }));
40
51
 
41
- // Provider mock — if `getConfiguredProvider` is ever called by the
42
- // assistant_tool pass-through path, this throw makes the test fail
43
- // loudly instead of silently exercising the LLM path.
52
+ // Provider mock. By default `sendMessage` throws so the assistant_tool
53
+ // pass-through path (which must skip the LLM) fails loudly if it reaches the
54
+ // provider. LLM-path tests override `providerSendMessage` to capture inputs.
55
+ let providerSendMessage: (
56
+ messages: unknown[],
57
+ opts: { systemPrompt?: string },
58
+ ) => Promise<unknown> = () => {
59
+ throw new Error(
60
+ "provider.sendMessage should NOT be invoked for assistant_tool pass-through",
61
+ );
62
+ };
63
+
44
64
  mock.module("../../providers/provider-send-message.js", () => ({
45
- getConfiguredProvider: async () => {
46
- throw new Error(
47
- "getConfiguredProvider should NOT be invoked for assistant_tool pass-through",
48
- );
49
- },
65
+ getConfiguredProvider: async () => ({
66
+ sendMessage: (messages: unknown[], opts: { systemPrompt?: string }) =>
67
+ providerSendMessage(messages, opts),
68
+ }),
50
69
  createTimeout: () => ({
51
70
  signal: new AbortController().signal,
52
71
  cleanup: () => {},
@@ -281,3 +300,53 @@ describe("assistant_tool pass-through in notification decision engine", () => {
281
300
  expect(decision.renderedCopy.vellum?.body).toBe("fyi");
282
301
  });
283
302
  });
303
+
304
+ describe("recipient notes injection (ACL from gateway, notes joined locally)", () => {
305
+ function makeLlmSignal(): NotificationSignal {
306
+ return {
307
+ signalId: "sig-llm-notes-1",
308
+ createdAt: Date.now(),
309
+ sourceChannel: "scheduler",
310
+ sourceContextId: "schedule-1",
311
+ sourceEventName: "schedule.notify",
312
+ contextPayload: {},
313
+ attentionHints: {
314
+ requiresAction: false,
315
+ urgency: "low",
316
+ isAsyncBackground: false,
317
+ visibleInSourceNow: false,
318
+ },
319
+ };
320
+ }
321
+
322
+ test("injects the guardian's local notes, resolved via the gateway contactId", async () => {
323
+ guardianDeliveryFixture = [{ contactId: "contact-42" }];
324
+ contactInfoFixture = { "contact-42": { notes: "Prefers terse updates." } };
325
+
326
+ let capturedSystemPrompt: string | undefined;
327
+ providerSendMessage = async (_messages, opts) => {
328
+ capturedSystemPrompt = opts.systemPrompt;
329
+ return {};
330
+ };
331
+
332
+ await evaluateSignal(makeLlmSignal(), ["vellum"] as NotificationChannel[]);
333
+
334
+ expect(capturedSystemPrompt).toContain("<recipient-context>");
335
+ expect(capturedSystemPrompt).toContain("Prefers terse updates.");
336
+ });
337
+
338
+ test("omits recipient context when no guardian is bound", async () => {
339
+ guardianDeliveryFixture = [];
340
+ contactInfoFixture = {};
341
+
342
+ let capturedSystemPrompt: string | undefined;
343
+ providerSendMessage = async (_messages, opts) => {
344
+ capturedSystemPrompt = opts.systemPrompt;
345
+ return {};
346
+ };
347
+
348
+ await evaluateSignal(makeLlmSignal(), ["vellum"] as NotificationChannel[]);
349
+
350
+ expect(capturedSystemPrompt).not.toContain("<recipient-context>");
351
+ });
352
+ });
@@ -0,0 +1,151 @@
1
+ /**
2
+ * Verifies resolveDestinations resolves guardian delivery endpoints from the
3
+ * gateway-provided guardian list, and omits a channel when the list is
4
+ * null/empty or carries no entry for it.
5
+ */
6
+
7
+ import { describe, expect, mock, test } from "bun:test";
8
+
9
+ import type { GuardianDelivery } from "@vellumai/gateway-client";
10
+
11
+ mock.module("../../util/logger.js", () => ({
12
+ getLogger: () =>
13
+ new Proxy({} as Record<string, unknown>, {
14
+ get: () => () => {},
15
+ }),
16
+ }));
17
+
18
+ const { resolveDestinations } = await import("../destination-resolver.js");
19
+
20
+ function guardian(
21
+ overrides: Partial<GuardianDelivery> & Pick<GuardianDelivery, "channelType" | "address">,
22
+ ): GuardianDelivery {
23
+ return {
24
+ contactId: "contact-1",
25
+ status: "active",
26
+ ...overrides,
27
+ } as GuardianDelivery;
28
+ }
29
+
30
+ describe("resolveDestinations — gateway guardian list", () => {
31
+ test("vellum carries guardianPrincipalId from the gateway list", () => {
32
+ const list = [
33
+ guardian({ channelType: "vellum", address: "user@example.com", principalId: "prin-1" }),
34
+ ];
35
+ const result = resolveDestinations(["vellum"], list);
36
+ expect(result.get("vellum")).toEqual({
37
+ channel: "vellum",
38
+ metadata: { guardianPrincipalId: "prin-1" },
39
+ });
40
+ });
41
+
42
+ test("platform carries guardianPrincipalId from the vellum guardian", () => {
43
+ const list = [
44
+ guardian({ channelType: "vellum", address: "user@example.com", principalId: "prin-1" }),
45
+ ];
46
+ const result = resolveDestinations(["platform"], list);
47
+ expect(result.get("platform")).toEqual({
48
+ channel: "platform",
49
+ metadata: { guardianPrincipalId: "prin-1" },
50
+ });
51
+ });
52
+
53
+ test("telegram resolves endpoint and binding context", () => {
54
+ const list = [
55
+ guardian({
56
+ channelType: "telegram",
57
+ address: "tg-user",
58
+ externalChatId: "12345",
59
+ }),
60
+ ];
61
+ const result = resolveDestinations(["telegram"], list);
62
+ expect(result.get("telegram")).toEqual({
63
+ channel: "telegram",
64
+ endpoint: "12345",
65
+ metadata: { externalUserId: "tg-user" },
66
+ bindingContext: {
67
+ sourceChannel: "telegram",
68
+ externalChatId: "12345",
69
+ externalUserId: "tg-user",
70
+ },
71
+ });
72
+ });
73
+
74
+ test("telegram without externalChatId is omitted", () => {
75
+ const list = [guardian({ channelType: "telegram", address: "tg-user" })];
76
+ const result = resolveDestinations(["telegram"], list);
77
+ expect(result.has("telegram")).toBe(false);
78
+ });
79
+
80
+ test("slack resolves DM endpoint and binding context", () => {
81
+ const list = [
82
+ guardian({
83
+ channelType: "slack",
84
+ address: "slack-user",
85
+ externalChatId: "D123",
86
+ }),
87
+ ];
88
+ const result = resolveDestinations(["slack"], list);
89
+ expect(result.get("slack")).toEqual({
90
+ channel: "slack",
91
+ endpoint: "D123",
92
+ metadata: { externalUserId: "slack-user" },
93
+ bindingContext: {
94
+ sourceChannel: "slack",
95
+ externalChatId: "D123",
96
+ externalUserId: "slack-user",
97
+ },
98
+ });
99
+ });
100
+
101
+ test("slack non-DM channel is dropped", () => {
102
+ const list = [
103
+ guardian({
104
+ channelType: "slack",
105
+ address: "slack-user",
106
+ externalChatId: "C123",
107
+ }),
108
+ ];
109
+ const result = resolveDestinations(["slack"], list);
110
+ expect(result.has("slack")).toBe(false);
111
+ });
112
+
113
+ test("inactive guardian is ignored", () => {
114
+ const list = [
115
+ guardian({
116
+ channelType: "telegram",
117
+ address: "tg-user",
118
+ externalChatId: "12345",
119
+ status: "revoked",
120
+ }),
121
+ ];
122
+ const result = resolveDestinations(["telegram"], list);
123
+ expect(result.has("telegram")).toBe(false);
124
+ });
125
+ });
126
+
127
+ describe("resolveDestinations — gateway empty or missing channel", () => {
128
+ test("null gateway list omits telegram", () => {
129
+ const result = resolveDestinations(["telegram"], null);
130
+ expect(result.has("telegram")).toBe(false);
131
+ });
132
+
133
+ test("null gateway list omits vellum principalId metadata", () => {
134
+ const result = resolveDestinations(["vellum"], null);
135
+ expect(result.get("vellum")).toEqual({ channel: "vellum" });
136
+ });
137
+
138
+ test("empty gateway list omits telegram", () => {
139
+ const result = resolveDestinations(["telegram"], []);
140
+ expect(result.has("telegram")).toBe(false);
141
+ });
142
+
143
+ test("gateway list missing the channel omits slack", () => {
144
+ // Gateway returns a telegram guardian but no slack entry.
145
+ const list = [
146
+ guardian({ channelType: "telegram", address: "tg", externalChatId: "999" }),
147
+ ];
148
+ const result = resolveDestinations(["slack"], list);
149
+ expect(result.has("slack")).toBe(false);
150
+ });
151
+ });
@@ -11,6 +11,7 @@
11
11
 
12
12
  import { v4 as uuid } from "uuid";
13
13
 
14
+ import { getGuardianDelivery } from "../contacts/guardian-delivery-reader.js";
14
15
  import { getConversation } from "../memory/conversation-crud.js";
15
16
  import type { ApprovalUIMetadata } from "../runtime/channel-approval-types.js";
16
17
  import { getLogger } from "../util/logger.js";
@@ -171,7 +172,13 @@ export class NotificationBroadcaster {
171
172
  decision: NotificationDecision,
172
173
  options?: BroadcastDecisionOptions,
173
174
  ): Promise<NotificationDeliveryResult[]> {
174
- const destinations = resolveDestinations(decision.selectedChannels);
175
+ // Pull the guardian list once so the resolver stays pure. A null list
176
+ // (gateway unreachable) falls back to the local contacts read.
177
+ const guardians = await getGuardianDelivery();
178
+ const destinations = resolveDestinations(
179
+ decision.selectedChannels,
180
+ guardians,
181
+ );
175
182
 
176
183
  // Ensure vellum is processed first so the notification_conversation_created
177
184
  // event fires immediately, before slower channel sends (e.g. Telegram 30s
@@ -12,7 +12,11 @@
12
12
  import { v4 as uuid } from "uuid";
13
13
 
14
14
  import { getDeliverableChannels } from "../channels/config.js";
15
- import { listGuardianChannels } from "../contacts/contact-store.js";
15
+ import { findContactInfoById } from "../contacts/contact-store.js";
16
+ import {
17
+ anyGuardian,
18
+ getGuardianDelivery,
19
+ } from "../contacts/guardian-delivery-reader.js";
16
20
  import { buildCoreIdentityContext } from "../prompts/system-prompt.js";
17
21
  import {
18
22
  createTimeout,
@@ -963,15 +967,19 @@ async function classifyWithLLM(
963
967
  ? truncate(rawIdentityContext, MAX_IDENTITY_CONTEXT_CHARS, "\n…[truncated]")
964
968
  : undefined;
965
969
 
966
- // Resolve guardian contact notes for recipient context. Use the channel-
967
- // agnostic guardian lookup so notes are available even when the only
968
- // deliverable channel is "vellum" (which has no contact channel type).
970
+ // Resolve guardian contact notes for recipient context. The guardian's
971
+ // identity (ACL) comes from the gateway pull, channel-agnostic so notes are
972
+ // available even when the only deliverable channel is "vellum". Notes (INFO)
973
+ // stay local and are joined by contactId.
969
974
  let recipientNotes: string | undefined;
970
975
  try {
971
- const guardianResult = listGuardianChannels();
972
- if (guardianResult?.contact.notes) {
976
+ const guardian = anyGuardian((await getGuardianDelivery()) ?? []);
977
+ const notes = guardian
978
+ ? findContactInfoById(guardian.contactId)?.notes
979
+ : undefined;
980
+ if (notes) {
973
981
  recipientNotes = truncate(
974
- guardianResult.contact.notes,
982
+ notes,
975
983
  MAX_IDENTITY_CONTEXT_CHARS,
976
984
  "\n…[truncated]",
977
985
  );
@@ -1,7 +1,7 @@
1
1
  /**
2
2
  * Resolves per-channel destination endpoints for notification delivery.
3
3
  *
4
- * Reads guardian delivery info from the contacts table.
4
+ * Reads guardian delivery info from the gateway-backed guardian list.
5
5
  *
6
6
  * - Vellum: no external endpoint needed — delivery goes through the event
7
7
  * broadcast mechanism to connected desktop/mobile clients. The
@@ -11,14 +11,39 @@
11
11
  * sourced from the guardian contact's channel record.
12
12
  */
13
13
 
14
+ import type { GuardianDelivery } from "@vellumai/gateway-client";
15
+
14
16
  import { isNotificationDeliverable } from "../channels/config.js";
15
17
  import type { ChannelId } from "../channels/types.js";
16
- import { findGuardianForChannel } from "../contacts/contact-store.js";
18
+ import { guardianForChannel } from "../contacts/guardian-delivery-reader.js";
17
19
  import { getLogger } from "../util/logger.js";
18
20
  import type { ChannelDestination, NotificationChannel } from "./types.js";
19
21
 
20
22
  const log = getLogger("destination-resolver");
21
23
 
24
+ /** Guardian delivery endpoint for a channel, flattened from either source. */
25
+ interface ResolvedGuardian {
26
+ principalId?: string;
27
+ address: string;
28
+ externalChatId?: string;
29
+ }
30
+
31
+ /** Resolve the guardian delivery endpoint for a channel from the gateway list. */
32
+ function resolveGuardian(
33
+ guardians: GuardianDelivery[] | null,
34
+ channelType: string,
35
+ ): ResolvedGuardian | undefined {
36
+ const g = guardians
37
+ ? guardianForChannel(guardians, channelType)
38
+ : undefined;
39
+ if (!g) return undefined;
40
+ return {
41
+ principalId: g.principalId ?? undefined,
42
+ address: g.address,
43
+ externalChatId: g.externalChatId ?? undefined,
44
+ };
45
+ }
46
+
22
47
  /**
23
48
  * Resolve destination information for each requested channel.
24
49
  *
@@ -26,9 +51,13 @@ const log = getLogger("destination-resolver");
26
51
  * the function skips non-deliverable channels via `isNotificationDeliverable`.
27
52
  * Returns a map keyed by `NotificationChannel`. Channels that cannot be
28
53
  * resolved (e.g. no Telegram binding configured) are omitted from the result.
54
+ *
55
+ * `guardians` is the gateway-resolved guardian list; a channel with no entry
56
+ * in the list is omitted from the result.
29
57
  */
30
58
  export function resolveDestinations(
31
59
  channels: readonly (ChannelId | NotificationChannel)[],
60
+ guardians: GuardianDelivery[] | null,
32
61
  ): Map<NotificationChannel, ChannelDestination> {
33
62
  const result = new Map<NotificationChannel, ChannelDestination>();
34
63
 
@@ -43,10 +72,10 @@ export function resolveDestinations(
43
72
  // Vellum delivery is local — no external endpoint required.
44
73
  // Include the guardianPrincipalId so the adapter can annotate
45
74
  // guardian-sensitive notifications for scoped delivery.
46
- const guardianResult = findGuardianForChannel("vellum");
75
+ const guardian = resolveGuardian(guardians, "vellum");
47
76
  const metadata: Record<string, unknown> = {};
48
- if (guardianResult) {
49
- metadata.guardianPrincipalId = guardianResult.contact.principalId;
77
+ if (guardian?.principalId) {
78
+ metadata.guardianPrincipalId = guardian.principalId;
50
79
  }
51
80
  result.set("vellum", {
52
81
  channel: "vellum",
@@ -55,7 +84,7 @@ export function resolveDestinations(
55
84
  log.debug(
56
85
  {
57
86
  channel: "vellum",
58
- source: "contacts",
87
+ source: "guardian-delivery",
59
88
  hasEndpoint: false,
60
89
  },
61
90
  "destination resolved",
@@ -63,52 +92,52 @@ export function resolveDestinations(
63
92
  break;
64
93
  }
65
94
  case "telegram": {
66
- const guardianResult = findGuardianForChannel(channel);
67
- if (guardianResult && guardianResult.channel.externalChatId) {
68
- const externalChatId = guardianResult.channel.externalChatId;
95
+ const guardian = resolveGuardian(guardians, channel);
96
+ if (guardian?.externalChatId) {
97
+ const externalChatId = guardian.externalChatId;
69
98
  result.set(channel as NotificationChannel, {
70
99
  channel: channel as NotificationChannel,
71
100
  endpoint: externalChatId,
72
101
  metadata: {
73
- externalUserId: guardianResult.channel.address,
102
+ externalUserId: guardian.address,
74
103
  },
75
104
  bindingContext: {
76
105
  sourceChannel: channel as NotificationChannel,
77
106
  externalChatId,
78
- externalUserId: guardianResult.channel.address,
107
+ externalUserId: guardian.address,
79
108
  },
80
109
  });
81
110
  }
82
111
  log.debug(
83
112
  {
84
113
  channel,
85
- source: "contacts",
86
- hasEndpoint: !!guardianResult?.channel.externalChatId,
114
+ source: "guardian-delivery",
115
+ hasEndpoint: !!guardian?.externalChatId,
87
116
  },
88
117
  "destination resolved",
89
118
  );
90
119
  break;
91
120
  }
92
121
  case "slack": {
93
- const guardianResult = findGuardianForChannel("slack");
94
- const chatId = guardianResult?.channel.externalChatId;
122
+ const guardian = resolveGuardian(guardians, "slack");
123
+ const chatId = guardian?.externalChatId;
95
124
  // Slack bindings can originate from app_mention in shared channels.
96
125
  // Only route notifications to DM channels (IDs starting with "D")
97
126
  // to prevent leaking notifications into shared workspaces.
98
- if (guardianResult && chatId && isSlackDmChannel(chatId)) {
127
+ if (guardian && chatId && isSlackDmChannel(chatId)) {
99
128
  result.set("slack", {
100
129
  channel: "slack",
101
130
  endpoint: chatId,
102
131
  metadata: {
103
- externalUserId: guardianResult.channel.address,
132
+ externalUserId: guardian.address,
104
133
  },
105
134
  bindingContext: {
106
135
  sourceChannel: "slack",
107
136
  externalChatId: chatId,
108
- externalUserId: guardianResult.channel.address,
137
+ externalUserId: guardian.address,
109
138
  },
110
139
  });
111
- } else if (guardianResult && chatId) {
140
+ } else if (guardian && chatId) {
112
141
  log.warn(
113
142
  { channel: "slack", chatId },
114
143
  "skipping non-DM Slack channel for notification delivery",
@@ -117,7 +146,7 @@ export function resolveDestinations(
117
146
  log.debug(
118
147
  {
119
148
  channel: "slack",
120
- source: "contacts",
149
+ source: "guardian-delivery",
121
150
  hasEndpoint: !!(chatId && isSlackDmChannel(chatId)),
122
151
  },
123
152
  "destination resolved",
@@ -128,11 +157,10 @@ export function resolveDestinations(
128
157
  // Platform delivery goes through the daemon's VellumPlatformClient —
129
158
  // no external binding needed. Include guardianPrincipalId so the
130
159
  // adapter can scope guardian-sensitive notifications.
131
- const platformGuardian = findGuardianForChannel("vellum");
160
+ const platformGuardian = resolveGuardian(guardians, "vellum");
132
161
  const platformMeta: Record<string, unknown> = {};
133
- if (platformGuardian) {
134
- platformMeta.guardianPrincipalId =
135
- platformGuardian.contact.principalId;
162
+ if (platformGuardian?.principalId) {
163
+ platformMeta.guardianPrincipalId = platformGuardian.principalId;
136
164
  }
137
165
  result.set("platform", {
138
166
  channel: "platform",
@@ -140,7 +168,7 @@ export function resolveDestinations(
140
168
  Object.keys(platformMeta).length > 0 ? platformMeta : undefined,
141
169
  });
142
170
  log.debug(
143
- { channel: "platform", source: "contacts", hasEndpoint: false },
171
+ { channel: "platform", source: "guardian-delivery", hasEndpoint: false },
144
172
  "destination resolved",
145
173
  );
146
174
  break;
@@ -9,10 +9,14 @@
9
9
  * propagated unless `throwOnError` is enabled.
10
10
  */
11
11
 
12
+ import type { GuardianDelivery } from "@vellumai/gateway-client";
12
13
  import { v4 as uuid } from "uuid";
13
14
 
14
15
  import { getDeliverableChannels } from "../channels/config.js";
15
- import { findGuardianForChannel } from "../contacts/contact-store.js";
16
+ import {
17
+ getGuardianDelivery,
18
+ guardianForChannel,
19
+ } from "../contacts/guardian-delivery-reader.js";
16
20
  import type { ConversationCreateType } from "../memory/conversation-crud.js";
17
21
  import { broadcastMessage } from "../runtime/assistant-event-hub.js";
18
22
  import { getLogger } from "../util/logger.js";
@@ -89,9 +93,28 @@ export function getBroadcaster(): NotificationBroadcaster {
89
93
 
90
94
  // ── Connected channels resolution ──────────────────────────────────────
91
95
 
92
- function getConnectedChannels(): NotificationChannel[] {
96
+ /**
97
+ * Resolve a binding-based channel's delivery endpoint (externalChatId) the
98
+ * SAME way destination-resolver's `resolveGuardian` does: from the gateway
99
+ * guardian delivery for this channel. Keeping connectivity aligned with
100
+ * delivery prevents a channel being marked connected but then skipped with no
101
+ * destination (or vice-versa).
102
+ */
103
+ function resolveChannelChatId(
104
+ guardians: GuardianDelivery[] | null,
105
+ channelType: string,
106
+ ): string | undefined {
107
+ const g = guardians ? guardianForChannel(guardians, channelType) : undefined;
108
+ return g?.externalChatId ?? undefined;
109
+ }
110
+
111
+ export async function getConnectedChannels(): Promise<NotificationChannel[]> {
93
112
  const channels: NotificationChannel[] = [];
94
113
 
114
+ // Guardian bindings (ACL) come from the gateway pull; null ⇒ gateway
115
+ // unreachable, so binding-based connectivity falls back to the local read.
116
+ const guardians = await getGuardianDelivery();
117
+
95
118
  // getDeliverableChannels() returns ChannelId[] but every returned channel
96
119
  // has deliveryEnabled: true, making it a valid NotificationChannel at
97
120
  // runtime. We iterate over the broad type and narrow via the switch.
@@ -110,24 +133,20 @@ function getConnectedChannels(): NotificationChannel[] {
110
133
  channels.push(channel);
111
134
  break;
112
135
  case "telegram": {
113
- // A binding-based channel is connected when the guardian has an
114
- // active channel entry with a valid delivery endpoint. The
115
- // externalChatId check ensures we don't report a channel as
116
- // connected when the contacts record exists but lacks the
117
- // delivery address the destination-resolver needs.
118
- const guardian = findGuardianForChannel(channel);
119
- if (guardian && guardian.channel.externalChatId) {
136
+ // Connected when the resolved guardian has a delivery endpoint —
137
+ // mirroring destination-resolver so we never mark connected what
138
+ // can't be delivered.
139
+ if (resolveChannelChatId(guardians, channel)) {
120
140
  channels.push(channel);
121
141
  }
122
142
  break;
123
143
  }
124
144
  case "slack": {
125
145
  // Slack bindings can originate from shared channels (app_mention).
126
- // Only consider Slack connected when the stored chat ID is a DM
127
- // channel (D-prefixed) to prevent leaking notifications.
128
- const slackGuardian = findGuardianForChannel("slack");
129
- const chatId = slackGuardian?.channel.externalChatId;
130
- if (slackGuardian && chatId && chatId.startsWith("D")) {
146
+ // Only consider Slack connected when the resolved chat ID is a DM
147
+ // channel (D-prefixed), matching destination-resolver's DM gate.
148
+ const chatId = resolveChannelChatId(guardians, "slack");
149
+ if (chatId && chatId.startsWith("D")) {
131
150
  channels.push(channel);
132
151
  }
133
152
  break;
@@ -290,7 +309,7 @@ export async function emitNotificationSignal<TEventName extends string>(
290
309
  }
291
310
 
292
311
  // Step 2: Evaluate the signal through the decision engine
293
- const connectedChannels = getConnectedChannels();
312
+ const connectedChannels = await getConnectedChannels();
294
313
 
295
314
  log.debug(
296
315
  {