@vellumai/assistant 0.10.2 → 0.10.3-dev.202606252046.9075fd5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (546) hide show
  1. package/bun.lock +20 -0
  2. package/docs/workspace-tools.md +42 -33
  3. package/eslint-rules/cli-no-daemon-internals.js +6 -0
  4. package/node_modules/@vellumai/gateway-client/src/__tests__/guardian-delivery-contract.test.ts +91 -0
  5. package/node_modules/@vellumai/gateway-client/src/__tests__/trust-verdict-contract.test.ts +31 -0
  6. package/node_modules/@vellumai/gateway-client/src/gateway-ipc-contracts.ts +44 -0
  7. package/node_modules/@vellumai/gateway-client/src/guardian-delivery-contract.ts +48 -0
  8. package/node_modules/@vellumai/gateway-client/src/index.ts +14 -0
  9. package/node_modules/@vellumai/gateway-client/src/trust-verdict-contract.ts +17 -0
  10. package/node_modules/@vellumai/service-contracts/package.json +1 -0
  11. package/node_modules/@vellumai/service-contracts/src/__tests__/channels.test.ts +28 -0
  12. package/node_modules/@vellumai/service-contracts/src/channels.ts +41 -0
  13. package/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  14. package/openapi.yaml +196 -56
  15. package/package.json +4 -1
  16. package/scripts/test.sh +36 -15
  17. package/src/__tests__/actor-token-service.test.ts +36 -14
  18. package/src/__tests__/actor-trust-resolver-address-fallback.test.ts +83 -31
  19. package/src/__tests__/agent-loop-override-profile.test.ts +1 -0
  20. package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts +2 -0
  21. package/src/__tests__/agent-wake-override-profile.test.ts +2 -0
  22. package/src/__tests__/annotate-activity-metadata.test.ts +2 -0
  23. package/src/__tests__/annotate-risk-options.test.ts +2 -0
  24. package/src/__tests__/approval-cascade.test.ts +2 -0
  25. package/src/__tests__/assistant-attachments.test.ts +42 -0
  26. package/src/__tests__/background-workers-disk-pressure.test.ts +2 -0
  27. package/src/__tests__/btw-routes.test.ts +2 -0
  28. package/src/__tests__/build-persisted-content.test.ts +2 -0
  29. package/src/__tests__/call-controller.test.ts +19 -0
  30. package/src/__tests__/channel-approval-routes.test.ts +21 -26
  31. package/src/__tests__/channel-delivery-store.test.ts +28 -0
  32. package/src/__tests__/channel-guardian.test.ts +164 -78
  33. package/src/__tests__/channel-inbound-disk-pressure.test.ts +11 -19
  34. package/src/__tests__/channel-reply-delivery.test.ts +2 -0
  35. package/src/__tests__/code-search-tool.test.ts +585 -0
  36. package/src/__tests__/compaction-events.test.ts +2 -0
  37. package/src/__tests__/compaction-ledger-store.test.ts +128 -0
  38. package/src/__tests__/compaction.benchmark.test.ts +2 -0
  39. package/src/__tests__/compactor-call-site-logging.test.ts +2 -0
  40. package/src/__tests__/compactor-low-watermark-cut.test.ts +2 -0
  41. package/src/__tests__/compactor-preserved-tail-count.test.ts +2 -0
  42. package/src/__tests__/compactor-summary-call-truncation.test.ts +2 -0
  43. package/src/__tests__/compactor-web-search-strip.test.ts +2 -0
  44. package/src/__tests__/config-loader-backfill.test.ts +123 -10
  45. package/src/__tests__/config-schema.test.ts +1 -0
  46. package/src/__tests__/confirmation-request-guardian-bridge.test.ts +31 -29
  47. package/src/__tests__/consult-deadline.test.ts +60 -0
  48. package/src/__tests__/contact-store-interaction-info.test.ts +156 -0
  49. package/src/__tests__/contact-store-user-file.test.ts +7 -10
  50. package/src/__tests__/contacts-relay-reads.test.ts +19 -24
  51. package/src/__tests__/contacts-write.test.ts +0 -2
  52. package/src/__tests__/conversation-abort-tool-results.test.ts +2 -0
  53. package/src/__tests__/conversation-agent-loop-disk-pressure.test.ts +2 -0
  54. package/src/__tests__/conversation-agent-loop-inference-profile.test.ts +2 -0
  55. package/src/__tests__/conversation-agent-loop-overflow.test.ts +2 -0
  56. package/src/__tests__/conversation-agent-loop.test.ts +134 -0
  57. package/src/__tests__/conversation-analysis-routes.test.ts +2 -0
  58. package/src/__tests__/conversation-app-control-lifecycle.test.ts +2 -0
  59. package/src/__tests__/conversation-attention-telegram.test.ts +9 -11
  60. package/src/__tests__/conversation-confirmation-signals.test.ts +2 -0
  61. package/src/__tests__/conversation-fork-crud.test.ts +354 -24
  62. package/src/__tests__/conversation-history-web-search.test.ts +2 -0
  63. package/src/__tests__/conversation-load-history-repair.test.ts +2 -0
  64. package/src/__tests__/conversation-load-history-stripped.test.ts +2 -0
  65. package/src/__tests__/conversation-pairing.test.ts +2 -0
  66. package/src/__tests__/conversation-process-app-control-preactivation.test.ts +2 -0
  67. package/src/__tests__/conversation-process-callsite.test.ts +2 -0
  68. package/src/__tests__/conversation-provider-retry-repair.test.ts +2 -0
  69. package/src/__tests__/conversation-queue.test.ts +91 -0
  70. package/src/__tests__/conversation-routes-guardian-reply.test.ts +14 -0
  71. package/src/__tests__/conversation-routes-slash-commands.test.ts +14 -0
  72. package/src/__tests__/conversation-slash-queue.test.ts +2 -0
  73. package/src/__tests__/conversation-slash-unknown.test.ts +2 -0
  74. package/src/__tests__/conversation-speed-override.test.ts +2 -0
  75. package/src/__tests__/conversation-surfaces-task-progress.test.ts +29 -0
  76. package/src/__tests__/conversation-title-service.test.ts +2 -0
  77. package/src/__tests__/conversation-tool-setup-attribution.test.ts +47 -0
  78. package/src/__tests__/conversation-usage.test.ts +2 -0
  79. package/src/__tests__/conversation-workspace-cache-state.test.ts +2 -0
  80. package/src/__tests__/conversation-workspace-injection.test.ts +2 -0
  81. package/src/__tests__/conversation-workspace-tool-tracking.test.ts +2 -0
  82. package/src/__tests__/credential-security-invariants.test.ts +1 -1
  83. package/src/__tests__/db-compaction-events-migration.test.ts +129 -0
  84. package/src/__tests__/db-migration-rollback.test.ts +205 -171
  85. package/src/__tests__/db-test-helpers.ts +5 -4
  86. package/src/__tests__/delete-propagation.test.ts +5 -3
  87. package/src/__tests__/deterministic-verification-control-plane.test.ts +4 -2
  88. package/src/__tests__/disk-pressure-guard.test.ts +41 -0
  89. package/src/__tests__/dm-backfill.test.ts +6 -4
  90. package/src/__tests__/dm-persistence.test.ts +2 -0
  91. package/src/__tests__/emit-signal-routing-intent.test.ts +7 -6
  92. package/src/__tests__/events-dev-bypass-actor.test.ts +7 -1
  93. package/src/__tests__/exploration-drift-hook.test.ts +3 -2
  94. package/src/__tests__/filing-service.test.ts +2 -0
  95. package/src/__tests__/guardian-binding-drift-heal.test.ts +104 -19
  96. package/src/__tests__/guardian-dispatch.test.ts +140 -1
  97. package/src/__tests__/guardian-expiry-notifier.test.ts +282 -0
  98. package/src/__tests__/guardian-outbound-http.test.ts +13 -0
  99. package/src/__tests__/guardian-routing-state.test.ts +6 -10
  100. package/src/__tests__/heartbeat-disk-pressure.test.ts +2 -0
  101. package/src/__tests__/heartbeat-service.test.ts +2 -0
  102. package/src/__tests__/helpers/channel-test-adapter.ts +46 -19
  103. package/src/__tests__/helpers/create-guardian-binding.ts +15 -23
  104. package/src/__tests__/helpers/mock-logger.ts +1 -0
  105. package/src/__tests__/helpers/seed-contact-channel.ts +96 -0
  106. package/src/__tests__/host-app-control-routes.test.ts +24 -30
  107. package/src/__tests__/host-bash-routes.test.ts +31 -41
  108. package/src/__tests__/host-browser-routes.test.ts +26 -32
  109. package/src/__tests__/host-cu-routes-targeted.test.ts +25 -33
  110. package/src/__tests__/host-file-routes-targeted.test.ts +40 -52
  111. package/src/__tests__/host-transfer-routes-targeted.test.ts +31 -43
  112. package/src/__tests__/http-user-message-parity.test.ts +290 -8
  113. package/src/__tests__/inbound-invite-redemption.test.ts +115 -10
  114. package/src/__tests__/inbound-slack-persistence.test.ts +2 -0
  115. package/src/__tests__/invite-redemption-service.test.ts +471 -53
  116. package/src/__tests__/invite-routes-http.test.ts +34 -0
  117. package/src/__tests__/invite-service-ipc.test.ts +65 -2
  118. package/src/__tests__/llm-context-normalization.test.ts +105 -0
  119. package/src/__tests__/llm-request-log-error-payload.test.ts +71 -9
  120. package/src/__tests__/llm-usage-store.test.ts +25 -0
  121. package/src/__tests__/mcp-config-secret-boundary.test.ts +392 -0
  122. package/src/__tests__/mcp-health-check.test.ts +2 -1
  123. package/src/__tests__/media-stream-server-integration.test.ts +127 -0
  124. package/src/__tests__/memory-retrieval-hook.test.ts +2 -0
  125. package/src/__tests__/messaging-send-tool.test.ts +2 -0
  126. package/src/__tests__/migration-import-from-url.test.ts +2 -2
  127. package/src/__tests__/mtime-cache.test.ts +275 -5
  128. package/src/__tests__/native-web-search.test.ts +2 -0
  129. package/src/__tests__/non-member-access-request.test.ts +191 -17
  130. package/src/__tests__/notification-broadcaster.test.ts +4 -0
  131. package/src/__tests__/notification-decision-recipient-context.test.ts +33 -32
  132. package/src/__tests__/notification-deep-link.test.ts +6 -0
  133. package/src/__tests__/notification-guardian-path.test.ts +19 -0
  134. package/src/__tests__/onboarding-persona-write.test.ts +52 -22
  135. package/src/__tests__/openai-provider.test.ts +22 -12
  136. package/src/__tests__/openai-responses-provider.test.ts +12 -2
  137. package/src/__tests__/outbound-slack-persistence.test.ts +2 -0
  138. package/src/__tests__/pending-interactions-resolved-event.test.ts +7 -4
  139. package/src/__tests__/persist-onboarding-artifacts.test.ts +1 -0
  140. package/src/__tests__/persistence-secret-redaction.test.ts +2 -0
  141. package/src/__tests__/persona-resolver.test.ts +75 -45
  142. package/src/__tests__/plugin-bootstrap.test.ts +21 -83
  143. package/src/__tests__/plugin-disabled-state.test.ts +190 -0
  144. package/src/__tests__/plugin-pipeline.test.ts +96 -0
  145. package/src/__tests__/plugin-route-contribution.test.ts +6 -19
  146. package/src/__tests__/plugin-tool-contribution.test.ts +5 -20
  147. package/src/__tests__/plugin-types.test.ts +2 -4
  148. package/src/__tests__/process-message-background-slack.test.ts +2 -0
  149. package/src/__tests__/process-message-display-content.test.ts +2 -0
  150. package/src/__tests__/provider-error-scenarios.test.ts +5 -4
  151. package/src/__tests__/provider-usage-tracking.test.ts +39 -0
  152. package/src/__tests__/reaction-intercept-cold-cache-warm.test.ts +135 -0
  153. package/src/__tests__/reaction-intercept-member-verdict-warm.test.ts +158 -0
  154. package/src/__tests__/reaction-persistence.test.ts +51 -4
  155. package/src/__tests__/regenerate-fire-and-forget-trace.test.ts +2 -0
  156. package/src/__tests__/registry.test.ts +4 -1
  157. package/src/__tests__/relay-server.test.ts +758 -32
  158. package/src/__tests__/runtime-attachment-metadata.test.ts +9 -12
  159. package/src/__tests__/secret-ingress-http.test.ts +14 -0
  160. package/src/__tests__/send-endpoint-busy.test.ts +30 -8
  161. package/src/__tests__/settings-routes.test.ts +32 -0
  162. package/src/__tests__/skills.test.ts +44 -0
  163. package/src/__tests__/slack-inbound-verification.test.ts +47 -2
  164. package/src/__tests__/sse-actor-principal-guardian-source.test.ts +79 -0
  165. package/src/__tests__/steer-on-enqueue-question.test.ts +181 -0
  166. package/src/__tests__/stt-hints.test.ts +49 -15
  167. package/src/__tests__/subagent-detail.test.ts +27 -0
  168. package/src/__tests__/subagent-disposal.test.ts +65 -0
  169. package/src/__tests__/subagent-fork-prompt-role.test.ts +195 -0
  170. package/src/__tests__/subagent-fork-spawn.test.ts +6 -7
  171. package/src/__tests__/subagent-notify-parent.test.ts +2 -0
  172. package/src/__tests__/subagent-role-registry.test.ts +24 -6
  173. package/src/__tests__/subagent-spawn-and-await.test.ts +546 -0
  174. package/src/__tests__/subagent-spawn-tool-fork.test.ts +2 -0
  175. package/src/__tests__/subagent-tools.test.ts +398 -1
  176. package/src/__tests__/suggestion-routes.test.ts +2 -0
  177. package/src/__tests__/thread-backfill.test.ts +3 -3
  178. package/src/__tests__/title-generate-hook.test.ts +2 -0
  179. package/src/__tests__/tool-executor-lifecycle-events.test.ts +2 -0
  180. package/src/__tests__/tool-executor.test.ts +16 -11
  181. package/src/__tests__/tool-preview-lifecycle.test.ts +2 -0
  182. package/src/__tests__/tool-result-metadata-plumbing.test.ts +2 -0
  183. package/src/__tests__/tool-start-timestamp.test.ts +2 -0
  184. package/src/__tests__/trusted-contact-approval-notifier.test.ts +37 -51
  185. package/src/__tests__/trusted-contact-inline-approval-integration.test.ts +12 -12
  186. package/src/__tests__/trusted-contact-lifecycle-notifications.test.ts +9 -7
  187. package/src/__tests__/trusted-contact-multichannel.test.ts +16 -7
  188. package/src/__tests__/trusted-contact-verification.test.ts +79 -54
  189. package/src/__tests__/twilio-routes.test.ts +96 -0
  190. package/src/__tests__/ui-file-upload-surface.test.ts +86 -0
  191. package/src/__tests__/verification-control-plane-policy.test.ts +2 -0
  192. package/src/__tests__/voice-guardian-cold-cache-warm.test.ts +137 -0
  193. package/src/__tests__/voice-invite-redemption.test.ts +216 -20
  194. package/src/__tests__/web-search-backend-failure.test.ts +2 -0
  195. package/src/__tests__/workspace-migration-102-preserve-heartbeat-enabled-for-existing-workspaces.test.ts +3 -3
  196. package/src/__tests__/workspace-migration-111-prune-seeded-callsite-defaults.test.ts +208 -0
  197. package/src/__tests__/workspace-migration-112-remove-advisor-callsite-override.test.ts +170 -0
  198. package/src/__tests__/workspace-migration-drop-user-md.test.ts +196 -238
  199. package/src/__tests__/workspace-migration-remove-hooks.test.ts +14 -35
  200. package/src/__tests__/workspace-tool-loader.test.ts +195 -2
  201. package/src/a2a/__tests__/e2e-a2a-channel.test.ts +35 -47
  202. package/src/agent/loop-exclusive-tool.test.ts +154 -0
  203. package/src/agent/loop-native-web-search.test.ts +200 -0
  204. package/src/agent/loop.ts +164 -1
  205. package/src/api/constants/sse-replay.ts +41 -0
  206. package/src/api/events/conversation-notice.ts +26 -0
  207. package/src/api/index.ts +19 -1
  208. package/src/api/responses/llm-request-log-entry.ts +29 -0
  209. package/src/api/responses/subagent-detail.ts +17 -0
  210. package/src/api/surfaces.ts +39 -3
  211. package/src/approvals/guardian-channel-delivery.ts +30 -0
  212. package/src/approvals/guardian-expiry-notifier.ts +148 -0
  213. package/src/approvals/guardian-request-resolvers.ts +17 -15
  214. package/src/calls/__tests__/relay-setup-router.test.ts +267 -17
  215. package/src/calls/call-domain.ts +3 -3
  216. package/src/calls/guardian-dispatch.ts +14 -9
  217. package/src/calls/inbound-trust-reader.ts +24 -2
  218. package/src/calls/media-stream-server.ts +21 -0
  219. package/src/calls/relay-access-wait.ts +6 -6
  220. package/src/calls/relay-server.ts +188 -51
  221. package/src/calls/relay-setup-router.ts +47 -17
  222. package/src/calls/relay-verification.ts +4 -4
  223. package/src/calls/stt-hints.ts +9 -12
  224. package/src/calls/twilio-routes.ts +14 -4
  225. package/src/channels/types.ts +10 -20
  226. package/src/cli/commands/__tests__/cache.test.ts +8 -1
  227. package/src/cli/commands/__tests__/conversations-slack.test.ts +1 -0
  228. package/src/cli/commands/cache.ts +194 -181
  229. package/src/cli/commands/contacts.ts +10 -7
  230. package/src/cli/commands/db/__tests__/repair.test.ts +6 -5
  231. package/src/cli/commands/db/status.ts +37 -1
  232. package/src/cli/commands/mcp.ts +252 -218
  233. package/src/cli/commands/memory/__tests__/worker.test.ts +432 -0
  234. package/src/cli/commands/memory/index.ts +2 -0
  235. package/src/cli/commands/memory/worker.ts +242 -0
  236. package/src/cli/commands/plugins.ts +125 -13
  237. package/src/cli/lib/__tests__/install-from-github.test.ts +102 -0
  238. package/src/cli/lib/__tests__/list-installed-plugins.test.ts +160 -1
  239. package/src/cli/lib/__tests__/publish-plugin.test.ts +404 -0
  240. package/src/cli/lib/list-installed-plugins.ts +179 -1
  241. package/src/cli/lib/publish-plugin.ts +633 -0
  242. package/src/config/__tests__/loader-callsite-strip-fallback.test.ts +143 -0
  243. package/src/config/__tests__/sync-gated-profiles.test.ts +16 -10
  244. package/src/config/bundled-skills/contacts/tools/contact-merge.ts +27 -17
  245. package/src/config/bundled-skills/contacts/tools/contact-search.ts +13 -3
  246. package/src/config/bundled-skills/subagent/SKILL.md +17 -2
  247. package/src/config/bundled-skills/subagent/TOOLS.json +5 -4
  248. package/src/config/call-site-defaults.ts +0 -6
  249. package/src/config/feature-flag-registry.json +5 -13
  250. package/src/config/llm-resolver.ts +0 -3
  251. package/src/config/loader.ts +38 -5
  252. package/src/config/prune-seeded-callsite-defaults.ts +110 -0
  253. package/src/config/schemas/__tests__/memory-v3.test.ts +1 -0
  254. package/src/config/schemas/call-site-catalog.ts +0 -7
  255. package/src/config/schemas/heartbeat.ts +2 -5
  256. package/src/config/schemas/llm.ts +3 -12
  257. package/src/config/schemas/memory-lifecycle.ts +12 -0
  258. package/src/config/schemas/memory-v3.ts +7 -0
  259. package/src/config/schemas/memory.ts +4 -0
  260. package/src/config/schemas/timeouts.ts +8 -0
  261. package/src/config/seed-inference-profiles.ts +30 -34
  262. package/src/config/skills.ts +27 -5
  263. package/src/config/sync-gated-profiles.ts +12 -16
  264. package/src/contacts/__tests__/contacts-write-revoke-relay.test.ts +128 -0
  265. package/src/contacts/__tests__/guardian-delivery-reader.test.ts +312 -0
  266. package/src/contacts/__tests__/member-write-relay.test.ts +226 -0
  267. package/src/contacts/contact-store.ts +27 -237
  268. package/src/contacts/contacts-write.ts +18 -55
  269. package/src/contacts/gateway-channel-read.ts +51 -0
  270. package/src/contacts/guardian-delivery-reader.ts +223 -0
  271. package/src/contacts/member-write-relay.ts +183 -0
  272. package/src/contacts/types.ts +3 -15
  273. package/src/daemon/__tests__/conversation-tool-setup-exclude.test.ts +35 -0
  274. package/src/daemon/__tests__/conversation-tool-setup.test.ts +0 -44
  275. package/src/daemon/assistant-attachments.ts +27 -4
  276. package/src/daemon/conversation-agent-loop.ts +28 -0
  277. package/src/daemon/conversation-notices.ts +60 -0
  278. package/src/daemon/conversation-process.ts +35 -16
  279. package/src/daemon/conversation-surfaces.ts +111 -38
  280. package/src/daemon/conversation-tool-setup.ts +71 -30
  281. package/src/daemon/conversation.ts +23 -1
  282. package/src/daemon/disk-pressure-guard.ts +12 -2
  283. package/src/daemon/event-loop-watchdog.ts +28 -1
  284. package/src/daemon/external-plugins-bootstrap.ts +17 -41
  285. package/src/daemon/handlers/__tests__/config-a2a-accept.test.ts +0 -1
  286. package/src/daemon/handlers/__tests__/config-a2a-complete.test.ts +0 -2
  287. package/src/daemon/handlers/__tests__/config-a2a-redeem.test.ts +25 -2
  288. package/src/daemon/handlers/__tests__/config-channels.test.ts +220 -0
  289. package/src/daemon/handlers/config-a2a.ts +6 -14
  290. package/src/daemon/handlers/config-channels.ts +67 -26
  291. package/src/daemon/handlers/conversations.ts +77 -0
  292. package/src/daemon/lifecycle.ts +16 -0
  293. package/src/daemon/mcp-reload-service.ts +10 -0
  294. package/src/daemon/memory-v2-startup.test.ts +72 -0
  295. package/src/daemon/memory-v2-startup.ts +87 -19
  296. package/src/daemon/message-types/conversations.ts +2 -0
  297. package/src/daemon/message-types/surfaces.ts +12 -12
  298. package/src/daemon/server.ts +0 -4
  299. package/src/daemon/shutdown-handlers.ts +20 -0
  300. package/src/daemon/tool-setup-types.ts +9 -0
  301. package/src/heartbeat/heartbeat-service.ts +5 -0
  302. package/src/home/relationship-state-writer.ts +5 -0
  303. package/src/hooks/hook-loader.ts +341 -0
  304. package/src/ipc/__tests__/clients-list-ipc.test.ts +1 -1
  305. package/src/ipc/assistant-server.ts +2 -2
  306. package/src/mcp/__tests__/mcp-auth-orchestrator.test.ts +1 -0
  307. package/src/mcp/client.ts +15 -1
  308. package/src/mcp/mcp-auth-orchestrator.ts +6 -1
  309. package/src/mcp/mcp-header-store.ts +134 -0
  310. package/src/mcp/mcp-oauth-provider.ts +19 -8
  311. package/src/memory/__tests__/301-create-watchdog-events.test.ts +110 -0
  312. package/src/memory/__tests__/memory-retrospective-job.test.ts +8 -0
  313. package/src/memory/__tests__/prompt-override.test.ts +192 -0
  314. package/src/memory/__tests__/watchdog-events-store.test.ts +161 -0
  315. package/src/memory/compaction-ledger-store.ts +107 -0
  316. package/src/memory/conversation-crud.ts +129 -61
  317. package/src/memory/db-connection.ts +22 -3
  318. package/src/memory/db-init.ts +37 -503
  319. package/src/memory/db-singleton.ts +6 -4
  320. package/src/memory/jobs-worker.ts +104 -0
  321. package/src/memory/llm-request-log-store.ts +26 -1
  322. package/src/memory/llm-usage-store.ts +48 -20
  323. package/src/memory/memory-retrospective-job.ts +14 -8
  324. package/src/memory/migrations/209-strip-thinking-from-consolidated.ts +152 -56
  325. package/src/memory/migrations/300-add-processing-started-at.ts +30 -0
  326. package/src/memory/migrations/301-create-watchdog-events.ts +45 -0
  327. package/src/memory/migrations/302-create-compaction-events.ts +107 -0
  328. package/src/memory/migrations/__tests__/209-strip-thinking-from-consolidated.test.ts +297 -0
  329. package/src/memory/migrations/__tests__/run-migrations.test.ts +2 -2
  330. package/src/memory/migrations/run-migrations.ts +106 -10
  331. package/src/memory/migrations/validate-migration-state.ts +105 -67
  332. package/src/memory/prompt-override.ts +129 -0
  333. package/src/memory/schema/contacts.ts +6 -2
  334. package/src/memory/schema/conversations.ts +37 -0
  335. package/src/memory/schema/infrastructure.ts +20 -0
  336. package/src/memory/steps.ts +1294 -0
  337. package/src/memory/v2/__tests__/cli-command-store.test.ts +25 -0
  338. package/src/memory/v2/__tests__/skill-store.test.ts +80 -0
  339. package/src/memory/v2/cli-command-store.ts +75 -38
  340. package/src/memory/v2/prompts/consolidation.ts +13 -82
  341. package/src/memory/v2/prompts/router.ts +21 -93
  342. package/src/memory/v2/skill-store.ts +68 -31
  343. package/src/memory/watchdog-events-store.ts +87 -0
  344. package/src/memory/worker-control.ts +204 -0
  345. package/src/memory/worker-process.ts +89 -0
  346. package/src/messaging/channel-binding-metadata.ts +31 -0
  347. package/src/messaging/provider-types.ts +8 -0
  348. package/src/messaging/providers/slack/binding-metadata.ts +60 -0
  349. package/src/notifications/__tests__/broadcaster.test.ts +8 -8
  350. package/src/notifications/__tests__/connected-channels.test.ts +86 -0
  351. package/src/notifications/__tests__/decision-engine.test.ts +78 -9
  352. package/src/notifications/__tests__/destination-resolver.test.ts +151 -0
  353. package/src/notifications/broadcaster.ts +8 -1
  354. package/src/notifications/decision-engine.ts +15 -7
  355. package/src/notifications/destination-resolver.ts +53 -25
  356. package/src/notifications/emit-signal.ts +34 -15
  357. package/src/onboarding/checkin-event.test.ts +222 -0
  358. package/src/onboarding/checkin-event.ts +321 -0
  359. package/src/onboarding/schedule-checkin.ts +190 -0
  360. package/src/permissions/question-prompter.test.ts +1 -1
  361. package/src/permissions/question-prompter.ts +7 -4
  362. package/src/plugin-api/index.ts +12 -12
  363. package/src/plugin-api/types.ts +12 -14
  364. package/src/plugin-api/vision-support.test.ts +28 -4
  365. package/src/plugin-api/vision-support.ts +66 -31
  366. package/src/plugins/defaults/empty-response/hooks/post-model-call.ts +2 -2
  367. package/src/plugins/defaults/empty-response/hooks/stop.ts +2 -2
  368. package/src/plugins/defaults/exploration-drift/hooks/post-tool-use.ts +4 -3
  369. package/src/plugins/defaults/history-repair/hooks/post-model-call.ts +2 -2
  370. package/src/plugins/defaults/history-repair/hooks/stop.ts +2 -2
  371. package/src/plugins/defaults/history-repair/hooks/user-prompt-submit.ts +2 -2
  372. package/src/plugins/defaults/image-fallback/__tests__/image-fallback.test.ts +47 -7
  373. package/src/plugins/defaults/image-fallback/hooks/post-tool-use.ts +12 -13
  374. package/src/plugins/defaults/image-fallback/hooks/user-prompt-submit.ts +14 -22
  375. package/src/plugins/defaults/image-fallback/src/caption-blocks.ts +42 -11
  376. package/src/plugins/defaults/image-recovery/hooks/post-model-call.ts +2 -2
  377. package/src/plugins/defaults/image-recovery/hooks/stop.ts +2 -2
  378. package/src/plugins/defaults/index.ts +0 -35
  379. package/src/plugins/defaults/max-tokens-continue/hooks/post-model-call.ts +2 -2
  380. package/src/plugins/defaults/max-tokens-continue/hooks/stop.ts +2 -2
  381. package/src/plugins/defaults/memory-retrieval/hooks/post-compact.ts +2 -2
  382. package/src/plugins/defaults/memory-retrieval/hooks/user-prompt-submit.ts +2 -2
  383. package/src/plugins/defaults/memory-v3-shadow/__tests__/injection.test.ts +33 -3
  384. package/src/plugins/defaults/memory-v3-shadow/__tests__/pool-select.test.ts +48 -4
  385. package/src/plugins/defaults/memory-v3-shadow/__tests__/shadow-plugin.test.ts +4 -8
  386. package/src/plugins/defaults/memory-v3-shadow/hooks/post-compact.ts +2 -2
  387. package/src/plugins/defaults/memory-v3-shadow/hooks/user-prompt-submit.ts +2 -2
  388. package/src/plugins/defaults/memory-v3-shadow/injector.ts +43 -15
  389. package/src/plugins/defaults/memory-v3-shadow/orchestrate.ts +11 -2
  390. package/src/plugins/defaults/memory-v3-shadow/pool-select.test.ts +146 -0
  391. package/src/plugins/defaults/memory-v3-shadow/pool-select.ts +77 -13
  392. package/src/plugins/defaults/memory-v3-shadow/shadow-plugin.ts +12 -11
  393. package/src/plugins/defaults/surface-completion-nudge/hooks/post-model-call.ts +2 -2
  394. package/src/plugins/defaults/surface-completion-nudge/hooks/stop.ts +2 -2
  395. package/src/plugins/defaults/task-progress-nudge/hooks/post-tool-use.ts +2 -2
  396. package/src/plugins/defaults/title-generate/hooks/stop.ts +2 -2
  397. package/src/plugins/defaults/title-generate/hooks/user-prompt-submit.ts +2 -2
  398. package/src/plugins/defaults/tool-error/hooks/post-tool-use.ts +2 -2
  399. package/src/plugins/defaults/tool-result-truncate/hooks/post-tool-use.ts +2 -2
  400. package/src/plugins/disabled-state.ts +31 -0
  401. package/src/plugins/external-plugin-loader.ts +2 -2
  402. package/src/plugins/mtime-cache.ts +186 -330
  403. package/src/plugins/pipeline.ts +111 -13
  404. package/src/plugins/registry.ts +59 -16
  405. package/src/plugins/surface-import.ts +121 -0
  406. package/src/plugins/types.ts +7 -9
  407. package/src/prompts/persona-resolver.ts +43 -11
  408. package/src/providers/anthropic/client.ts +5 -0
  409. package/src/providers/call-site-routing.ts +45 -0
  410. package/src/providers/model-catalog.ts +16 -0
  411. package/src/providers/openai/__tests__/api-error-normalization.test.ts +321 -0
  412. package/src/providers/openai/api-error-normalization.ts +270 -0
  413. package/src/providers/openai/chat-completions-provider.ts +37 -83
  414. package/src/providers/openai/responses-provider.ts +50 -46
  415. package/src/providers/openrouter/client.ts +5 -0
  416. package/src/providers/provider-send-message.ts +10 -0
  417. package/src/providers/ratelimit.ts +10 -0
  418. package/src/providers/registry.ts +1 -1
  419. package/src/providers/retry.ts +10 -0
  420. package/src/providers/types.ts +22 -0
  421. package/src/providers/usage-tracking.ts +10 -0
  422. package/src/runtime/__tests__/channel-verification-service.test.ts +133 -0
  423. package/src/runtime/__tests__/guardian-vellum-migration.test.ts +184 -0
  424. package/src/runtime/__tests__/is-guardian-bound-for-channel.test.ts +66 -0
  425. package/src/runtime/__tests__/local-principal-trust.test.ts +162 -0
  426. package/src/runtime/__tests__/member-verdict-cache.test.ts +119 -0
  427. package/src/runtime/__tests__/trust-verdict-consumer.test.ts +402 -123
  428. package/src/runtime/access-request-helper.ts +18 -39
  429. package/src/runtime/actor-trust-resolver.ts +46 -19
  430. package/src/runtime/anchored-guardian.test.ts +109 -0
  431. package/src/runtime/anchored-guardian.ts +86 -0
  432. package/src/runtime/assistant-event-hub.ts +1 -1
  433. package/src/runtime/assistant-stream-state.ts +9 -2
  434. package/src/runtime/auth/__tests__/require-bound-guardian.test.ts +99 -0
  435. package/src/runtime/auth/require-bound-guardian.ts +21 -11
  436. package/src/runtime/channel-verification-service.ts +56 -31
  437. package/src/runtime/confirmation-request-guardian-bridge.ts +3 -3
  438. package/src/runtime/guardian-vellum-migration.ts +69 -8
  439. package/src/runtime/invite-redemption-service.ts +213 -187
  440. package/src/runtime/local-actor-identity.test.ts +108 -0
  441. package/src/runtime/local-actor-identity.ts +85 -13
  442. package/src/runtime/local-principal-trust.ts +52 -0
  443. package/src/runtime/member-verdict-cache.ts +0 -0
  444. package/src/runtime/pending-interactions.ts +11 -1
  445. package/src/runtime/routes/__tests__/channel-verification-revoke.test.ts +56 -5
  446. package/src/runtime/routes/__tests__/channel-verification-routes.test.ts +1 -1
  447. package/src/runtime/routes/__tests__/contact-routes.test.ts +305 -0
  448. package/src/runtime/routes/__tests__/global-search-routes.test.ts +92 -0
  449. package/src/runtime/routes/__tests__/http-adapter-actor-header.test.ts +129 -0
  450. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +188 -0
  451. package/src/runtime/routes/browser-routes.ts +1 -1
  452. package/src/runtime/routes/canonical-guardian-expiry-sweep.ts +13 -5
  453. package/src/runtime/routes/channel-verification-routes.ts +3 -3
  454. package/src/runtime/routes/contact-routes.ts +48 -57
  455. package/src/runtime/routes/conversation-cli-routes.ts +4 -5
  456. package/src/runtime/routes/conversation-list-routes.ts +4 -7
  457. package/src/runtime/routes/conversation-query-routes.ts +72 -0
  458. package/src/runtime/routes/conversation-routes.ts +84 -85
  459. package/src/runtime/routes/events-routes.ts +2 -2
  460. package/src/runtime/routes/global-search-routes.ts +3 -1
  461. package/src/runtime/routes/guardian-action-routes.ts +4 -5
  462. package/src/runtime/routes/host-app-control-routes.ts +5 -4
  463. package/src/runtime/routes/host-bash-routes.ts +5 -4
  464. package/src/runtime/routes/host-browser-routes.ts +9 -11
  465. package/src/runtime/routes/host-cu-routes.ts +5 -4
  466. package/src/runtime/routes/host-file-routes.ts +5 -4
  467. package/src/runtime/routes/host-transfer-routes.ts +6 -6
  468. package/src/runtime/routes/http-adapter.ts +16 -1
  469. package/src/runtime/routes/identity-routes.ts +3 -2
  470. package/src/runtime/routes/inbound-message-handler.ts +5 -5
  471. package/src/runtime/routes/inbound-stages/acl-enforcement.test.ts +97 -5
  472. package/src/runtime/routes/inbound-stages/acl-enforcement.ts +61 -59
  473. package/src/runtime/routes/inbound-stages/background-dispatch.ts +13 -5
  474. package/src/runtime/routes/inbound-stages/escalation-intercept.ts +7 -7
  475. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.test.ts +21 -8
  476. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.ts +14 -3
  477. package/src/runtime/routes/inbound-stages/reaction-intercept.ts +19 -0
  478. package/src/runtime/routes/index.ts +2 -0
  479. package/src/runtime/routes/llm-context-normalization.ts +83 -0
  480. package/src/runtime/routes/mcp-auth-routes.ts +171 -19
  481. package/src/runtime/routes/migration-rollback-routes.ts +4 -3
  482. package/src/runtime/routes/migration-routes.ts +4 -1
  483. package/src/runtime/routes/onboarding-checkin-routes.ts +86 -0
  484. package/src/runtime/routes/settings-routes.ts +8 -3
  485. package/src/runtime/routes/subagents-routes.ts +5 -0
  486. package/src/runtime/routes/surface-action-routes.ts +42 -56
  487. package/src/runtime/services/__tests__/conversation-serializer.test.ts +1 -0
  488. package/src/runtime/services/conversation-serializer.ts +13 -58
  489. package/src/runtime/tool-grant-request-helper.ts +3 -3
  490. package/src/runtime/trust-verdict-consumer.ts +111 -40
  491. package/src/runtime/verification-outbound-actions.ts +18 -18
  492. package/src/signals/user-message.ts +16 -0
  493. package/src/subagent/__tests__/consult-prompt.test.ts +35 -0
  494. package/src/{plugins/defaults/advisor/__tests__/transcript.test.ts → subagent/__tests__/consult-transcript.test.ts} +47 -10
  495. package/src/{plugins/defaults/advisor/steering.ts → subagent/consult-prompt.ts} +22 -32
  496. package/src/{plugins/defaults/advisor/transcript.ts → subagent/consult-transcript.ts} +18 -8
  497. package/src/subagent/index.ts +1 -1
  498. package/src/subagent/manager.ts +254 -33
  499. package/src/subagent/types.ts +11 -4
  500. package/src/telemetry/types.ts +34 -1
  501. package/src/telemetry/usage-telemetry-reporter.test.ts +3 -2
  502. package/src/telemetry/usage-telemetry-reporter.ts +87 -3
  503. package/src/tools/ask-question/ask-question-tool.test.ts +29 -0
  504. package/src/tools/ask-question/ask-question-tool.ts +13 -0
  505. package/src/tools/executor.ts +4 -4
  506. package/src/tools/filesystem/search.ts +543 -0
  507. package/src/tools/registry.ts +38 -0
  508. package/src/tools/shared/filesystem/path-policy.ts +12 -5
  509. package/src/tools/subagent/consult-deadline.ts +49 -0
  510. package/src/tools/subagent/spawn.ts +234 -5
  511. package/src/tools/tool-approval-handler.ts +1 -1
  512. package/src/tools/tool-defaults.ts +9 -2
  513. package/src/tools/tool-manifest.ts +3 -0
  514. package/src/tools/types.ts +131 -25
  515. package/src/tools/workspace-tools/loader.ts +348 -244
  516. package/src/util/errors.ts +26 -1
  517. package/src/util/logger.ts +9 -0
  518. package/src/util/platform.ts +19 -0
  519. package/src/util/telemetry-db-path.ts +24 -0
  520. package/src/workflows/library.test.ts +140 -0
  521. package/src/workflows/library.ts +82 -28
  522. package/src/workspace/migrations/017-seed-persona-dirs.ts +3 -34
  523. package/src/workspace/migrations/019-scope-journal-to-guardian.ts +3 -24
  524. package/src/workspace/migrations/031-drop-user-md.ts +232 -148
  525. package/src/workspace/migrations/048-remove-workspace-hooks.ts +14 -66
  526. package/src/workspace/migrations/111-prune-seeded-callsite-defaults.ts +134 -0
  527. package/src/workspace/migrations/112-remove-advisor-callsite-override.ts +64 -0
  528. package/src/workspace/migrations/registry.ts +4 -0
  529. package/src/__tests__/workspace-tools-watcher-flag.test.ts +0 -70
  530. package/src/daemon/workspace-tools-watcher.ts +0 -328
  531. package/src/memory/migrations/registry.ts +0 -573
  532. package/src/plugins/defaults/advisor/__tests__/advisor-gate.test.ts +0 -56
  533. package/src/plugins/defaults/advisor/__tests__/advisor-state-store.test.ts +0 -43
  534. package/src/plugins/defaults/advisor/__tests__/agent-loop-integration.test.ts +0 -137
  535. package/src/plugins/defaults/advisor/__tests__/consult.test.ts +0 -153
  536. package/src/plugins/defaults/advisor/__tests__/hooks.test.ts +0 -138
  537. package/src/plugins/defaults/advisor/advisor-gate.ts +0 -29
  538. package/src/plugins/defaults/advisor/advisor-state-store.ts +0 -94
  539. package/src/plugins/defaults/advisor/config.ts +0 -21
  540. package/src/plugins/defaults/advisor/consult.ts +0 -93
  541. package/src/plugins/defaults/advisor/hooks/post-model-call.ts +0 -34
  542. package/src/plugins/defaults/advisor/hooks/pre-model-call.ts +0 -30
  543. package/src/plugins/defaults/advisor/hooks/user-prompt-submit.ts +0 -19
  544. package/src/plugins/defaults/advisor/package.json +0 -14
  545. package/src/plugins/defaults/advisor/tools/advisor.ts +0 -65
  546. package/src/providers/openai/__tests__/api-error-detail.test.ts +0 -120
@@ -44,7 +44,6 @@ mock.module("../daemon/approval-generators.js", () => ({
44
44
  createApprovalConversationGenerator: () => undefined,
45
45
  }));
46
46
 
47
- import { upsertContact } from "../contacts/contact-store.js";
48
47
  import {
49
48
  linkAttachmentToMessage,
50
49
  uploadAttachment,
@@ -58,7 +57,10 @@ import { resetTestTables } from "../memory/raw-query.js";
58
57
  import { RuntimeHttpServer } from "../runtime/http-server.js";
59
58
  import * as pendingInteractions from "../runtime/pending-interactions.js";
60
59
  import { resetDbForTesting } from "./db-test-helpers.js";
61
- import { resolveLocalTrustVerdict } from "./helpers/channel-test-adapter.js";
60
+ import {
61
+ resolveLocalTrustVerdict,
62
+ seedContactChannel,
63
+ } from "./helpers/channel-test-adapter.js";
62
64
 
63
65
  await initializeDb();
64
66
 
@@ -251,16 +253,12 @@ describe("WhatsApp channel ingress attachment resolution", () => {
251
253
  }
252
254
 
253
255
  function ensureWhatsAppContact(): void {
254
- upsertContact({
256
+ seedContactChannel({
257
+ sourceChannel: "whatsapp",
258
+ externalUserId: WHATSAPP_USER_ID,
255
259
  displayName: "WhatsApp Test User",
256
- channels: [
257
- {
258
- type: "whatsapp",
259
- address: WHATSAPP_USER_ID,
260
- status: "active",
261
- policy: "allow",
262
- },
263
- ],
260
+ status: "active",
261
+ policy: "allow",
264
262
  });
265
263
  }
266
264
 
@@ -272,7 +270,6 @@ describe("WhatsApp channel ingress attachment resolution", () => {
272
270
  const trustVerdict = resolveLocalTrustVerdict({
273
271
  channelType: "whatsapp",
274
272
  actorExternalId: WHATSAPP_USER_ID,
275
- externalChatId: "whatsapp-chat-1",
276
273
  });
277
274
  return {
278
275
  sourceChannel: "whatsapp",
@@ -96,6 +96,8 @@ const addMessageMock = mock(
96
96
  );
97
97
 
98
98
  mock.module("../memory/conversation-crud.js", () => ({
99
+ setConversationProcessingStartedAt: () => {},
100
+ isConversationProcessing: () => false,
99
101
  addMessage: (
100
102
  conversationId: string,
101
103
  role: string,
@@ -127,6 +129,18 @@ mock.module("../runtime/trust-context-resolver.js", () => ({
127
129
  }),
128
130
  }));
129
131
 
132
+ mock.module("../contacts/guardian-delivery-reader.js", () => ({
133
+ getGuardianDelivery: async () => [
134
+ {
135
+ channelType: "vellum",
136
+ contactId: "guardian-contact",
137
+ principalId: "test-user",
138
+ address: "test-user",
139
+ status: "active",
140
+ },
141
+ ],
142
+ }));
143
+
130
144
  mock.module("../runtime/guardian-reply-router.js", () => ({
131
145
  routeGuardianReply: async () => ({
132
146
  consumed: false,
@@ -109,17 +109,38 @@ mock.module("../daemon/approval-generators.js", () => ({
109
109
  createApprovalConversationGenerator: () => _approvalGenerator,
110
110
  }));
111
111
 
112
- // Mock local-actor-identity to return a stable guardian context that uses
113
- // the same principal as the canonical requests created in tests.
112
+ // Dev-bypass resolves the real guardian principal, then runs the real
113
+ // local-principal trust mapper against the gateway delivery read.
114
114
  mock.module("../runtime/local-actor-identity.js", () => ({
115
- resolveLocalTrustContext: () => ({
116
- sourceChannel: "vellum",
117
- trustClass: "guardian",
118
- guardianPrincipalId: "test-principal-id",
119
- guardianExternalUserId: "test-principal-id",
120
- }),
115
+ findLocalGuardianPrincipalId: async () => "test-principal-id",
116
+ }));
117
+
118
+ // Mock the IPC transport rather than local-principal-trust.js so the sibling
119
+ // resolver unit test (which mocks guardian-delivery-reader, not ipcCall) isn't
120
+ // shadowed when both files run in one Bun process. resolve_guardian_delivery
121
+ // returns a single active vellum guardian whose principal matches the
122
+ // dev-bypass-resolved id; any other method throws so unexpected IPC surfaces.
123
+ mock.module("../ipc/gateway-client.js", () => ({
124
+ ipcCall: async (method: string) => {
125
+ if (method === "resolve_guardian_delivery") {
126
+ return {
127
+ guardians: [
128
+ {
129
+ channelType: "vellum",
130
+ contactId: "test-contact-id",
131
+ principalId: "test-principal-id",
132
+ address: "test-principal-id",
133
+ externalChatId: "test-principal-id",
134
+ status: "active",
135
+ },
136
+ ],
137
+ };
138
+ }
139
+ throw new Error(`Unexpected ipcCall in test: ${method}`);
140
+ },
121
141
  }));
122
142
 
143
+ import { __resetGuardianDeliveryCacheForTest } from "../contacts/guardian-delivery-reader.js";
123
144
  import { getDb } from "../memory/db-connection.js";
124
145
  import { initializeDb } from "../memory/db-init.js";
125
146
  import type { AssistantEvent } from "../runtime/assistant-event.js";
@@ -343,6 +364,7 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
343
364
  db.run("DELETE FROM contact_channels");
344
365
  db.run("DELETE FROM contacts");
345
366
  pendingInteractions.clear();
367
+ __resetGuardianDeliveryCacheForTest();
346
368
 
347
369
  createGuardianBinding({
348
370
  channel: "vellum",
@@ -17,6 +17,34 @@ mock.module("../util/logger.js", () => ({
17
17
  }),
18
18
  }));
19
19
 
20
+ // Guardian identity resolves via the gateway delivery cache, not the local
21
+ // contacts DB. Seed it per-test via seedGatewayGuardian; persona resolution
22
+ // joins the local contact (userFile) by the delivery's channelType + address.
23
+ interface GatewayGuardian {
24
+ channelType: string;
25
+ address: string;
26
+ status: string;
27
+ }
28
+ let gatewayGuardians: GatewayGuardian[] = [];
29
+ mock.module("../contacts/guardian-delivery-reader.js", () => ({
30
+ peekCachedGuardianDelivery: (input?: { channelTypes?: string[] }) => {
31
+ if (!input?.channelTypes) return gatewayGuardians;
32
+ return gatewayGuardians.filter((g) =>
33
+ input.channelTypes!.includes(g.channelType),
34
+ );
35
+ },
36
+ guardianForChannel: (list: GatewayGuardian[], channelType: string) =>
37
+ list.find((g) => g.channelType === channelType && g.status === "active"),
38
+ anyGuardian: (list: GatewayGuardian[]) => list[0],
39
+ }));
40
+
41
+ function seedGatewayGuardian(g: {
42
+ channelType: string;
43
+ address: string;
44
+ }): void {
45
+ gatewayGuardians.push({ status: "active", ...g });
46
+ }
47
+
20
48
  import { getSqlite } from "../memory/db-connection.js";
21
49
  import { initializeDb } from "../memory/db-init.js";
22
50
  import { BadRequestError, NotFoundError } from "../runtime/routes/errors.js";
@@ -32,6 +60,7 @@ function resetContactTables(): void {
32
60
  const sqlite = getSqlite();
33
61
  sqlite.run("DELETE FROM contact_channels");
34
62
  sqlite.run("DELETE FROM contacts");
63
+ gatewayGuardians = [];
35
64
  }
36
65
 
37
66
  // ---------------------------------------------------------------------------
@@ -76,6 +105,7 @@ describe("GET /workspace-files", () => {
76
105
  });
77
106
 
78
107
  test("with a guardian: includes users/<slug>.md", async () => {
108
+ seedGatewayGuardian({ channelType: "telegram", address: "Alice" });
79
109
  createGuardianBinding({
80
110
  channel: "telegram",
81
111
  guardianExternalUserId: "Alice",
@@ -103,6 +133,7 @@ describe("GET /workspace-files", () => {
103
133
  };
104
134
  expect(result.files.map((f) => f.path)).not.toContain("users/alice.md");
105
135
 
136
+ seedGatewayGuardian({ channelType: "telegram", address: "Alice" });
106
137
  createGuardianBinding({
107
138
  channel: "telegram",
108
139
  guardianExternalUserId: "Alice",
@@ -130,6 +161,7 @@ describe("GET /workspace-files/read", () => {
130
161
  });
131
162
 
132
163
  test("reads a guardian users/<slug>.md file", async () => {
164
+ seedGatewayGuardian({ channelType: "telegram", address: "Alice" });
133
165
  createGuardianBinding({
134
166
  channel: "telegram",
135
167
  guardianExternalUserId: "Alice",
@@ -351,6 +351,50 @@ describe("plugin-resident skills", () => {
351
351
  expect(skill).toBeUndefined();
352
352
  });
353
353
 
354
+ test("warns when a plugin directory is missing package.json", () => {
355
+ const warnings: unknown[][] = [];
356
+ const originalWarn = noopLogger.warn;
357
+ noopLogger.warn = (...args: unknown[]) => {
358
+ warnings.push(args);
359
+ };
360
+ try {
361
+ writePluginSkill(
362
+ "the-force",
363
+ "software-engineering",
364
+ "Software Engineering",
365
+ "Engineering workflow",
366
+ "body",
367
+ { withPackageJson: false },
368
+ );
369
+
370
+ const skill = loadSkillCatalog().find(
371
+ (s) => s.id === "software-engineering",
372
+ );
373
+ expect(skill).toBeUndefined();
374
+
375
+ const warnedForDir = warnings.some(
376
+ (args) =>
377
+ typeof args[0] === "object" &&
378
+ args[0] !== null &&
379
+ "pluginDir" in args[0] &&
380
+ (args[0] as { pluginDir: string }).pluginDir.endsWith("the-force") &&
381
+ typeof args[1] === "string" &&
382
+ args[1].includes("missing package.json"),
383
+ );
384
+ expect(warnedForDir).toBe(true);
385
+ } finally {
386
+ noopLogger.warn = originalWarn;
387
+ }
388
+ });
389
+
390
+ test("does not load resident skills from a plugin disabled via .disabled", () => {
391
+ writePluginSkill("caveman", "caveman", "Caveman", "Terse mode");
392
+ writeFileSync(join(pluginsDir, "caveman", ".disabled"), "");
393
+
394
+ const skill = loadSkillCatalog().find((s) => s.id === "caveman");
395
+ expect(skill).toBeUndefined();
396
+ });
397
+
354
398
  test("workspace skill overrides a plugin-resident skill with the same id", () => {
355
399
  const WORKSPACE_DIR = join(
356
400
  tmpdir(),
@@ -55,6 +55,35 @@ mock.module("../runtime/gateway-client.js", () => ({
55
55
  },
56
56
  }));
57
57
 
58
+ // Guardian identity resolves via the gateway delivery reader, not the local
59
+ // contacts DB. Seed it to mirror the createGuardianBinding calls below.
60
+ interface GatewayGuardian {
61
+ channelType: string;
62
+ contactId: string;
63
+ principalId?: string | null;
64
+ displayName?: string | null;
65
+ address: string;
66
+ externalChatId?: string | null;
67
+ status: string;
68
+ verifiedAt?: number | null;
69
+ }
70
+ let gatewayGuardians: GatewayGuardian[] = [];
71
+ mock.module("../contacts/guardian-delivery-reader.js", () => ({
72
+ getGuardianDelivery: async () => gatewayGuardians,
73
+ guardianForChannel: (list: GatewayGuardian[], channelType: string) =>
74
+ list.find((g) => g.channelType === channelType && g.status === "active"),
75
+ }));
76
+
77
+ function seedGatewayGuardian(
78
+ g: Partial<GatewayGuardian> & { channelType: string; address: string },
79
+ ): void {
80
+ gatewayGuardians.push({
81
+ contactId: `c-${g.channelType}`,
82
+ status: "active",
83
+ ...g,
84
+ });
85
+ }
86
+
58
87
  import { getDb } from "../memory/db-connection.js";
59
88
  import { initializeDb } from "../memory/db-init.js";
60
89
  import { findActiveSession } from "../runtime/channel-verification-service.js";
@@ -80,7 +109,16 @@ function resetState(): void {
80
109
  db.run("DELETE FROM canonical_guardian_deliveries");
81
110
  db.run("DELETE FROM contact_channels");
82
111
  db.run("DELETE FROM contacts");
83
- // Seed the vellum guardian binding (gateway does this at startup in production)
112
+ gatewayGuardians = [];
113
+ // Seed the vellum guardian binding (gateway does this at startup in
114
+ // production). The gateway list is the source of truth for guardian
115
+ // resolution; the DB write mirrors it for any local INFO reads.
116
+ seedGatewayGuardian({
117
+ channelType: "vellum",
118
+ address: "guardian-principal",
119
+ principalId: "guardian-principal",
120
+ displayName: "guardian-principal",
121
+ });
84
122
  createGuardianBinding({
85
123
  channel: "vellum",
86
124
  guardianExternalUserId: "guardian-principal",
@@ -162,7 +200,14 @@ describe("Slack inbound trusted contact verification", () => {
162
200
  });
163
201
 
164
202
  test("guardian is notified of the access attempt alongside verification", async () => {
165
- // Set up a guardian binding so the notification can target it
203
+ // Set up a guardian binding so the notification can target it. The gateway
204
+ // list resolves guardian identity; the DB write mirrors it.
205
+ seedGatewayGuardian({
206
+ channelType: "slack",
207
+ address: "U_GUARDIAN",
208
+ externalChatId: "D_GUARDIAN_DM",
209
+ principalId: "guardian-principal",
210
+ });
166
211
  createGuardianBinding({
167
212
  channel: "slack",
168
213
  guardianExternalUserId: "U_GUARDIAN",
@@ -0,0 +1,79 @@
1
+ /**
2
+ * Regression: the SSE subscribe path must resolve the actor principal from the
3
+ * SAME guardian source as the send/result routes.
4
+ *
5
+ * The send/result routes resolve the actor principal via the async
6
+ * `findLocalGuardianPrincipalId`. The SSE eager-subscribe path cannot await and
7
+ * uses the sync `findLocalGuardianPrincipalIdFromStore`. Both read the
8
+ * gateway-owned guardian binding — async via the cached IPC read, sync via the
9
+ * IO-free cache snapshot — so the event hub registers the SSE client under the
10
+ * SAME principal the turn/result paths use; otherwise targeted result
11
+ * submissions 403.
12
+ *
13
+ * These tests pin the invariant by priming the gateway-delivery cache and
14
+ * asserting both resolvers agree; and that a cold cache yields no principal.
15
+ */
16
+
17
+ import { beforeEach, describe, expect, mock, test } from "bun:test";
18
+
19
+ import type { GuardianDelivery } from "@vellumai/gateway-client";
20
+
21
+ // ── Controllable IPC mock (drives the gateway-delivery cache) ────────────────
22
+
23
+ let ipcGuardians: GuardianDelivery[] = [];
24
+
25
+ mock.module("../ipc/gateway-client.js", () => ({
26
+ ipcCall: async () => ({ guardians: ipcGuardians }),
27
+ ipcCallPersistent: async () => undefined,
28
+ resetPersistentClient: () => {},
29
+ }));
30
+
31
+ import {
32
+ __resetGuardianDeliveryCacheForTest,
33
+ getGuardianDelivery,
34
+ } from "../contacts/guardian-delivery-reader.js";
35
+ import {
36
+ findLocalGuardianPrincipalId,
37
+ findLocalGuardianPrincipalIdFromStore,
38
+ } from "../runtime/local-actor-identity.js";
39
+
40
+ const gatewayVellumGuardian: GuardianDelivery = {
41
+ channelType: "vellum",
42
+ contactId: "contact-gw",
43
+ principalId: "guardian-from-gateway",
44
+ address: "vellum:self",
45
+ status: "active",
46
+ };
47
+
48
+ describe("SSE actor principal resolves from the same guardian source as send/result routes", () => {
49
+ beforeEach(() => {
50
+ __resetGuardianDeliveryCacheForTest();
51
+ ipcGuardians = [];
52
+ });
53
+
54
+ test("warm gateway cache: sync (SSE) and async (send/result) resolve the SAME principal", async () => {
55
+ ipcGuardians = [gatewayVellumGuardian];
56
+
57
+ // Prime the cache the way the async hot paths do.
58
+ const asyncPrincipalId = await findLocalGuardianPrincipalId();
59
+ expect(asyncPrincipalId).toBe("guardian-from-gateway");
60
+
61
+ // SSE's sync resolver reads the same cached gateway snapshot — so the
62
+ // principals match and host-proxy targeting works.
63
+ expect(findLocalGuardianPrincipalIdFromStore()).toBe(asyncPrincipalId);
64
+ });
65
+
66
+ test("cold cache: sync resolver returns undefined", () => {
67
+ expect(findLocalGuardianPrincipalIdFromStore()).toBeUndefined();
68
+ });
69
+
70
+ test("warm gateway cache primes via the vellum-filtered read the async path uses", async () => {
71
+ ipcGuardians = [gatewayVellumGuardian];
72
+
73
+ // The async path filters by channelType vellum; the sync peek must read
74
+ // the same cache key, not the unfiltered "ALL" entry.
75
+ await getGuardianDelivery({ channelTypes: ["vellum"] });
76
+
77
+ expect(findLocalGuardianPrincipalIdFromStore()).toBe("guardian-from-gateway");
78
+ });
79
+ });
@@ -0,0 +1,181 @@
1
+ /**
2
+ * Enqueue-steer contract: when a chat message is enqueued while an
3
+ * `ask_question` prompt is open for the same conversation, the user has chosen
4
+ * to move on rather than answer it. `steerOnEnqueuedMessageIfQuestionParked`
5
+ * steers to that message — aborting the parked turn (which settles the open
6
+ * question via its turn-abort signal) and draining the message — instead of
7
+ * stranding it behind a prompt no one will answer.
8
+ *
9
+ * Only `kind: "question"` interactions trigger the steer; pending confirmations
10
+ * are handled separately by the enqueue path's auto-deny.
11
+ */
12
+ import { afterEach, describe, expect, test } from "bun:test";
13
+
14
+ import type { Conversation } from "../daemon/conversation.js";
15
+ import {
16
+ deleteConversation,
17
+ setConversation,
18
+ } from "../daemon/conversation-registry.js";
19
+ import {
20
+ steerOnEnqueuedMessageIfQuestionParked,
21
+ supersedePendingInteractionsOnEnqueue,
22
+ } from "../daemon/handlers/conversations.js";
23
+ import * as pendingInteractions from "../runtime/pending-interactions.js";
24
+
25
+ interface ParkedTurn {
26
+ abortCount: () => number;
27
+ fake: { pendingSteerRepair: boolean };
28
+ }
29
+
30
+ /**
31
+ * Register a fake conversation whose in-flight turn is parked. The fake exposes
32
+ * just the surface `steerToMessage` touches: a processing flag, a queue whose
33
+ * head can be promoted, an abort controller that records aborts, and the
34
+ * confirmation-deny hook.
35
+ */
36
+ function registerParkedTurn(id: string): ParkedTurn {
37
+ let abortCount = 0;
38
+ const fake = {
39
+ isProcessing: () => true,
40
+ queue: {
41
+ promoteToHead: (requestId: string) => ({ requestId }),
42
+ },
43
+ pendingSteerRepair: false,
44
+ abortController: {
45
+ abort: () => {
46
+ abortCount += 1;
47
+ },
48
+ },
49
+ hasAnyPendingConfirmation: () => false,
50
+ denyAllPendingConfirmations: () => {},
51
+ };
52
+ setConversation(id, fake as unknown as Conversation);
53
+ return { abortCount: () => abortCount, fake };
54
+ }
55
+
56
+ const registeredRequestIds: string[] = [];
57
+ function registerInteraction(
58
+ conversationId: string,
59
+ kind: "question" | "confirmation",
60
+ ): void {
61
+ const requestId = `pending-${kind}-${conversationId}`;
62
+ pendingInteractions.register(requestId, { conversationId, kind });
63
+ registeredRequestIds.push(requestId);
64
+ }
65
+
66
+ const QUESTION_CONV = "steer-enqueue-question";
67
+ const CONFIRMATION_CONV = "steer-enqueue-confirmation";
68
+ const NONE_CONV = "steer-enqueue-none";
69
+
70
+ describe("steerOnEnqueuedMessageIfQuestionParked", () => {
71
+ afterEach(() => {
72
+ for (const id of registeredRequestIds) {
73
+ pendingInteractions.resolve(id, "cancelled");
74
+ }
75
+ registeredRequestIds.length = 0;
76
+ deleteConversation(QUESTION_CONV);
77
+ deleteConversation(CONFIRMATION_CONV);
78
+ deleteConversation(NONE_CONV);
79
+ });
80
+
81
+ test("steers to the enqueued message when an ask_question is parked", () => {
82
+ const conv = registerParkedTurn(QUESTION_CONV);
83
+ registerInteraction(QUESTION_CONV, "question");
84
+
85
+ const steered = steerOnEnqueuedMessageIfQuestionParked(
86
+ QUESTION_CONV,
87
+ "msg-1",
88
+ );
89
+
90
+ // The parked turn is aborted (which settles the open question) and marked
91
+ // for tool-result repair so the drain path can pick up the new message.
92
+ expect(steered).toBe(true);
93
+ expect(conv.abortCount()).toBe(1);
94
+ expect(conv.fake.pendingSteerRepair).toBe(true);
95
+ });
96
+
97
+ test("steers for a parked question even when a confirmation is also pending", () => {
98
+ // A single model response can open an ask_question and a confirmation
99
+ // concurrently (tools run via Promise.all), so both interactions can be
100
+ // registered at once. The steer must still fire for the question — the
101
+ // enqueue path runs it before the confirmation auto-deny clears entries.
102
+ const conv = registerParkedTurn(QUESTION_CONV);
103
+ registerInteraction(QUESTION_CONV, "confirmation");
104
+ registerInteraction(QUESTION_CONV, "question");
105
+
106
+ const steered = steerOnEnqueuedMessageIfQuestionParked(
107
+ QUESTION_CONV,
108
+ "msg-1",
109
+ );
110
+
111
+ expect(steered).toBe(true);
112
+ expect(conv.abortCount()).toBe(1);
113
+ });
114
+
115
+ test("does not steer for a pending confirmation (not a question)", () => {
116
+ const conv = registerParkedTurn(CONFIRMATION_CONV);
117
+ registerInteraction(CONFIRMATION_CONV, "confirmation");
118
+
119
+ const steered = steerOnEnqueuedMessageIfQuestionParked(
120
+ CONFIRMATION_CONV,
121
+ "msg-1",
122
+ );
123
+
124
+ expect(steered).toBe(false);
125
+ expect(conv.abortCount()).toBe(0);
126
+ });
127
+
128
+ test("does not steer when no prompt is parked", () => {
129
+ const conv = registerParkedTurn(NONE_CONV);
130
+
131
+ const steered = steerOnEnqueuedMessageIfQuestionParked(NONE_CONV, "msg-1");
132
+
133
+ expect(steered).toBe(false);
134
+ expect(conv.abortCount()).toBe(0);
135
+ });
136
+
137
+ test("supersedePendingInteractionsOnEnqueue steers a parked question", () => {
138
+ // The centralized routine is invoked by both the HTTP send handler and the
139
+ // CLI signal path. With no pending confirmation it steers a parked question
140
+ // — the behavior the CLI signal path previously lacked.
141
+ const conv = registerParkedTurn(QUESTION_CONV);
142
+ registerInteraction(QUESTION_CONV, "question");
143
+
144
+ supersedePendingInteractionsOnEnqueue(QUESTION_CONV, "msg-1");
145
+
146
+ expect(conv.abortCount()).toBe(1);
147
+ expect(conv.fake.pendingSteerRepair).toBe(true);
148
+ });
149
+ });
150
+
151
+ describe("removeByConversation preserves question interactions", () => {
152
+ // The enqueue path's confirmation auto-deny calls removeByConversation before
153
+ // the steer runs. Questions must survive it — they are settled instead by the
154
+ // steer's turn abort — or, when an ask_question and a confirmation are pending
155
+ // concurrently, the queued message would strand behind a question whose entry
156
+ // was cleared (and whose Promise was never settled) before the steer fired.
157
+ const CONV = "remove-by-conv-preserve-question";
158
+ const ids: string[] = [];
159
+ function register(kind: "question" | "confirmation"): void {
160
+ const requestId = `rbc-${kind}`;
161
+ pendingInteractions.register(requestId, { conversationId: CONV, kind });
162
+ ids.push(requestId);
163
+ }
164
+
165
+ afterEach(() => {
166
+ for (const id of ids) pendingInteractions.resolve(id, "cancelled");
167
+ ids.length = 0;
168
+ });
169
+
170
+ test("removes confirmations but leaves questions registered", () => {
171
+ register("confirmation");
172
+ register("question");
173
+
174
+ pendingInteractions.removeByConversation(CONV);
175
+
176
+ const remaining = pendingInteractions
177
+ .getByConversation(CONV)
178
+ .map((interaction) => interaction.kind);
179
+ expect(remaining).toEqual(["question"]);
180
+ });
181
+ });