@vellumai/assistant 0.10.2 → 0.10.3-dev.202606252046.9075fd5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (546) hide show
  1. package/bun.lock +20 -0
  2. package/docs/workspace-tools.md +42 -33
  3. package/eslint-rules/cli-no-daemon-internals.js +6 -0
  4. package/node_modules/@vellumai/gateway-client/src/__tests__/guardian-delivery-contract.test.ts +91 -0
  5. package/node_modules/@vellumai/gateway-client/src/__tests__/trust-verdict-contract.test.ts +31 -0
  6. package/node_modules/@vellumai/gateway-client/src/gateway-ipc-contracts.ts +44 -0
  7. package/node_modules/@vellumai/gateway-client/src/guardian-delivery-contract.ts +48 -0
  8. package/node_modules/@vellumai/gateway-client/src/index.ts +14 -0
  9. package/node_modules/@vellumai/gateway-client/src/trust-verdict-contract.ts +17 -0
  10. package/node_modules/@vellumai/service-contracts/package.json +1 -0
  11. package/node_modules/@vellumai/service-contracts/src/__tests__/channels.test.ts +28 -0
  12. package/node_modules/@vellumai/service-contracts/src/channels.ts +41 -0
  13. package/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  14. package/openapi.yaml +196 -56
  15. package/package.json +4 -1
  16. package/scripts/test.sh +36 -15
  17. package/src/__tests__/actor-token-service.test.ts +36 -14
  18. package/src/__tests__/actor-trust-resolver-address-fallback.test.ts +83 -31
  19. package/src/__tests__/agent-loop-override-profile.test.ts +1 -0
  20. package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts +2 -0
  21. package/src/__tests__/agent-wake-override-profile.test.ts +2 -0
  22. package/src/__tests__/annotate-activity-metadata.test.ts +2 -0
  23. package/src/__tests__/annotate-risk-options.test.ts +2 -0
  24. package/src/__tests__/approval-cascade.test.ts +2 -0
  25. package/src/__tests__/assistant-attachments.test.ts +42 -0
  26. package/src/__tests__/background-workers-disk-pressure.test.ts +2 -0
  27. package/src/__tests__/btw-routes.test.ts +2 -0
  28. package/src/__tests__/build-persisted-content.test.ts +2 -0
  29. package/src/__tests__/call-controller.test.ts +19 -0
  30. package/src/__tests__/channel-approval-routes.test.ts +21 -26
  31. package/src/__tests__/channel-delivery-store.test.ts +28 -0
  32. package/src/__tests__/channel-guardian.test.ts +164 -78
  33. package/src/__tests__/channel-inbound-disk-pressure.test.ts +11 -19
  34. package/src/__tests__/channel-reply-delivery.test.ts +2 -0
  35. package/src/__tests__/code-search-tool.test.ts +585 -0
  36. package/src/__tests__/compaction-events.test.ts +2 -0
  37. package/src/__tests__/compaction-ledger-store.test.ts +128 -0
  38. package/src/__tests__/compaction.benchmark.test.ts +2 -0
  39. package/src/__tests__/compactor-call-site-logging.test.ts +2 -0
  40. package/src/__tests__/compactor-low-watermark-cut.test.ts +2 -0
  41. package/src/__tests__/compactor-preserved-tail-count.test.ts +2 -0
  42. package/src/__tests__/compactor-summary-call-truncation.test.ts +2 -0
  43. package/src/__tests__/compactor-web-search-strip.test.ts +2 -0
  44. package/src/__tests__/config-loader-backfill.test.ts +123 -10
  45. package/src/__tests__/config-schema.test.ts +1 -0
  46. package/src/__tests__/confirmation-request-guardian-bridge.test.ts +31 -29
  47. package/src/__tests__/consult-deadline.test.ts +60 -0
  48. package/src/__tests__/contact-store-interaction-info.test.ts +156 -0
  49. package/src/__tests__/contact-store-user-file.test.ts +7 -10
  50. package/src/__tests__/contacts-relay-reads.test.ts +19 -24
  51. package/src/__tests__/contacts-write.test.ts +0 -2
  52. package/src/__tests__/conversation-abort-tool-results.test.ts +2 -0
  53. package/src/__tests__/conversation-agent-loop-disk-pressure.test.ts +2 -0
  54. package/src/__tests__/conversation-agent-loop-inference-profile.test.ts +2 -0
  55. package/src/__tests__/conversation-agent-loop-overflow.test.ts +2 -0
  56. package/src/__tests__/conversation-agent-loop.test.ts +134 -0
  57. package/src/__tests__/conversation-analysis-routes.test.ts +2 -0
  58. package/src/__tests__/conversation-app-control-lifecycle.test.ts +2 -0
  59. package/src/__tests__/conversation-attention-telegram.test.ts +9 -11
  60. package/src/__tests__/conversation-confirmation-signals.test.ts +2 -0
  61. package/src/__tests__/conversation-fork-crud.test.ts +354 -24
  62. package/src/__tests__/conversation-history-web-search.test.ts +2 -0
  63. package/src/__tests__/conversation-load-history-repair.test.ts +2 -0
  64. package/src/__tests__/conversation-load-history-stripped.test.ts +2 -0
  65. package/src/__tests__/conversation-pairing.test.ts +2 -0
  66. package/src/__tests__/conversation-process-app-control-preactivation.test.ts +2 -0
  67. package/src/__tests__/conversation-process-callsite.test.ts +2 -0
  68. package/src/__tests__/conversation-provider-retry-repair.test.ts +2 -0
  69. package/src/__tests__/conversation-queue.test.ts +91 -0
  70. package/src/__tests__/conversation-routes-guardian-reply.test.ts +14 -0
  71. package/src/__tests__/conversation-routes-slash-commands.test.ts +14 -0
  72. package/src/__tests__/conversation-slash-queue.test.ts +2 -0
  73. package/src/__tests__/conversation-slash-unknown.test.ts +2 -0
  74. package/src/__tests__/conversation-speed-override.test.ts +2 -0
  75. package/src/__tests__/conversation-surfaces-task-progress.test.ts +29 -0
  76. package/src/__tests__/conversation-title-service.test.ts +2 -0
  77. package/src/__tests__/conversation-tool-setup-attribution.test.ts +47 -0
  78. package/src/__tests__/conversation-usage.test.ts +2 -0
  79. package/src/__tests__/conversation-workspace-cache-state.test.ts +2 -0
  80. package/src/__tests__/conversation-workspace-injection.test.ts +2 -0
  81. package/src/__tests__/conversation-workspace-tool-tracking.test.ts +2 -0
  82. package/src/__tests__/credential-security-invariants.test.ts +1 -1
  83. package/src/__tests__/db-compaction-events-migration.test.ts +129 -0
  84. package/src/__tests__/db-migration-rollback.test.ts +205 -171
  85. package/src/__tests__/db-test-helpers.ts +5 -4
  86. package/src/__tests__/delete-propagation.test.ts +5 -3
  87. package/src/__tests__/deterministic-verification-control-plane.test.ts +4 -2
  88. package/src/__tests__/disk-pressure-guard.test.ts +41 -0
  89. package/src/__tests__/dm-backfill.test.ts +6 -4
  90. package/src/__tests__/dm-persistence.test.ts +2 -0
  91. package/src/__tests__/emit-signal-routing-intent.test.ts +7 -6
  92. package/src/__tests__/events-dev-bypass-actor.test.ts +7 -1
  93. package/src/__tests__/exploration-drift-hook.test.ts +3 -2
  94. package/src/__tests__/filing-service.test.ts +2 -0
  95. package/src/__tests__/guardian-binding-drift-heal.test.ts +104 -19
  96. package/src/__tests__/guardian-dispatch.test.ts +140 -1
  97. package/src/__tests__/guardian-expiry-notifier.test.ts +282 -0
  98. package/src/__tests__/guardian-outbound-http.test.ts +13 -0
  99. package/src/__tests__/guardian-routing-state.test.ts +6 -10
  100. package/src/__tests__/heartbeat-disk-pressure.test.ts +2 -0
  101. package/src/__tests__/heartbeat-service.test.ts +2 -0
  102. package/src/__tests__/helpers/channel-test-adapter.ts +46 -19
  103. package/src/__tests__/helpers/create-guardian-binding.ts +15 -23
  104. package/src/__tests__/helpers/mock-logger.ts +1 -0
  105. package/src/__tests__/helpers/seed-contact-channel.ts +96 -0
  106. package/src/__tests__/host-app-control-routes.test.ts +24 -30
  107. package/src/__tests__/host-bash-routes.test.ts +31 -41
  108. package/src/__tests__/host-browser-routes.test.ts +26 -32
  109. package/src/__tests__/host-cu-routes-targeted.test.ts +25 -33
  110. package/src/__tests__/host-file-routes-targeted.test.ts +40 -52
  111. package/src/__tests__/host-transfer-routes-targeted.test.ts +31 -43
  112. package/src/__tests__/http-user-message-parity.test.ts +290 -8
  113. package/src/__tests__/inbound-invite-redemption.test.ts +115 -10
  114. package/src/__tests__/inbound-slack-persistence.test.ts +2 -0
  115. package/src/__tests__/invite-redemption-service.test.ts +471 -53
  116. package/src/__tests__/invite-routes-http.test.ts +34 -0
  117. package/src/__tests__/invite-service-ipc.test.ts +65 -2
  118. package/src/__tests__/llm-context-normalization.test.ts +105 -0
  119. package/src/__tests__/llm-request-log-error-payload.test.ts +71 -9
  120. package/src/__tests__/llm-usage-store.test.ts +25 -0
  121. package/src/__tests__/mcp-config-secret-boundary.test.ts +392 -0
  122. package/src/__tests__/mcp-health-check.test.ts +2 -1
  123. package/src/__tests__/media-stream-server-integration.test.ts +127 -0
  124. package/src/__tests__/memory-retrieval-hook.test.ts +2 -0
  125. package/src/__tests__/messaging-send-tool.test.ts +2 -0
  126. package/src/__tests__/migration-import-from-url.test.ts +2 -2
  127. package/src/__tests__/mtime-cache.test.ts +275 -5
  128. package/src/__tests__/native-web-search.test.ts +2 -0
  129. package/src/__tests__/non-member-access-request.test.ts +191 -17
  130. package/src/__tests__/notification-broadcaster.test.ts +4 -0
  131. package/src/__tests__/notification-decision-recipient-context.test.ts +33 -32
  132. package/src/__tests__/notification-deep-link.test.ts +6 -0
  133. package/src/__tests__/notification-guardian-path.test.ts +19 -0
  134. package/src/__tests__/onboarding-persona-write.test.ts +52 -22
  135. package/src/__tests__/openai-provider.test.ts +22 -12
  136. package/src/__tests__/openai-responses-provider.test.ts +12 -2
  137. package/src/__tests__/outbound-slack-persistence.test.ts +2 -0
  138. package/src/__tests__/pending-interactions-resolved-event.test.ts +7 -4
  139. package/src/__tests__/persist-onboarding-artifacts.test.ts +1 -0
  140. package/src/__tests__/persistence-secret-redaction.test.ts +2 -0
  141. package/src/__tests__/persona-resolver.test.ts +75 -45
  142. package/src/__tests__/plugin-bootstrap.test.ts +21 -83
  143. package/src/__tests__/plugin-disabled-state.test.ts +190 -0
  144. package/src/__tests__/plugin-pipeline.test.ts +96 -0
  145. package/src/__tests__/plugin-route-contribution.test.ts +6 -19
  146. package/src/__tests__/plugin-tool-contribution.test.ts +5 -20
  147. package/src/__tests__/plugin-types.test.ts +2 -4
  148. package/src/__tests__/process-message-background-slack.test.ts +2 -0
  149. package/src/__tests__/process-message-display-content.test.ts +2 -0
  150. package/src/__tests__/provider-error-scenarios.test.ts +5 -4
  151. package/src/__tests__/provider-usage-tracking.test.ts +39 -0
  152. package/src/__tests__/reaction-intercept-cold-cache-warm.test.ts +135 -0
  153. package/src/__tests__/reaction-intercept-member-verdict-warm.test.ts +158 -0
  154. package/src/__tests__/reaction-persistence.test.ts +51 -4
  155. package/src/__tests__/regenerate-fire-and-forget-trace.test.ts +2 -0
  156. package/src/__tests__/registry.test.ts +4 -1
  157. package/src/__tests__/relay-server.test.ts +758 -32
  158. package/src/__tests__/runtime-attachment-metadata.test.ts +9 -12
  159. package/src/__tests__/secret-ingress-http.test.ts +14 -0
  160. package/src/__tests__/send-endpoint-busy.test.ts +30 -8
  161. package/src/__tests__/settings-routes.test.ts +32 -0
  162. package/src/__tests__/skills.test.ts +44 -0
  163. package/src/__tests__/slack-inbound-verification.test.ts +47 -2
  164. package/src/__tests__/sse-actor-principal-guardian-source.test.ts +79 -0
  165. package/src/__tests__/steer-on-enqueue-question.test.ts +181 -0
  166. package/src/__tests__/stt-hints.test.ts +49 -15
  167. package/src/__tests__/subagent-detail.test.ts +27 -0
  168. package/src/__tests__/subagent-disposal.test.ts +65 -0
  169. package/src/__tests__/subagent-fork-prompt-role.test.ts +195 -0
  170. package/src/__tests__/subagent-fork-spawn.test.ts +6 -7
  171. package/src/__tests__/subagent-notify-parent.test.ts +2 -0
  172. package/src/__tests__/subagent-role-registry.test.ts +24 -6
  173. package/src/__tests__/subagent-spawn-and-await.test.ts +546 -0
  174. package/src/__tests__/subagent-spawn-tool-fork.test.ts +2 -0
  175. package/src/__tests__/subagent-tools.test.ts +398 -1
  176. package/src/__tests__/suggestion-routes.test.ts +2 -0
  177. package/src/__tests__/thread-backfill.test.ts +3 -3
  178. package/src/__tests__/title-generate-hook.test.ts +2 -0
  179. package/src/__tests__/tool-executor-lifecycle-events.test.ts +2 -0
  180. package/src/__tests__/tool-executor.test.ts +16 -11
  181. package/src/__tests__/tool-preview-lifecycle.test.ts +2 -0
  182. package/src/__tests__/tool-result-metadata-plumbing.test.ts +2 -0
  183. package/src/__tests__/tool-start-timestamp.test.ts +2 -0
  184. package/src/__tests__/trusted-contact-approval-notifier.test.ts +37 -51
  185. package/src/__tests__/trusted-contact-inline-approval-integration.test.ts +12 -12
  186. package/src/__tests__/trusted-contact-lifecycle-notifications.test.ts +9 -7
  187. package/src/__tests__/trusted-contact-multichannel.test.ts +16 -7
  188. package/src/__tests__/trusted-contact-verification.test.ts +79 -54
  189. package/src/__tests__/twilio-routes.test.ts +96 -0
  190. package/src/__tests__/ui-file-upload-surface.test.ts +86 -0
  191. package/src/__tests__/verification-control-plane-policy.test.ts +2 -0
  192. package/src/__tests__/voice-guardian-cold-cache-warm.test.ts +137 -0
  193. package/src/__tests__/voice-invite-redemption.test.ts +216 -20
  194. package/src/__tests__/web-search-backend-failure.test.ts +2 -0
  195. package/src/__tests__/workspace-migration-102-preserve-heartbeat-enabled-for-existing-workspaces.test.ts +3 -3
  196. package/src/__tests__/workspace-migration-111-prune-seeded-callsite-defaults.test.ts +208 -0
  197. package/src/__tests__/workspace-migration-112-remove-advisor-callsite-override.test.ts +170 -0
  198. package/src/__tests__/workspace-migration-drop-user-md.test.ts +196 -238
  199. package/src/__tests__/workspace-migration-remove-hooks.test.ts +14 -35
  200. package/src/__tests__/workspace-tool-loader.test.ts +195 -2
  201. package/src/a2a/__tests__/e2e-a2a-channel.test.ts +35 -47
  202. package/src/agent/loop-exclusive-tool.test.ts +154 -0
  203. package/src/agent/loop-native-web-search.test.ts +200 -0
  204. package/src/agent/loop.ts +164 -1
  205. package/src/api/constants/sse-replay.ts +41 -0
  206. package/src/api/events/conversation-notice.ts +26 -0
  207. package/src/api/index.ts +19 -1
  208. package/src/api/responses/llm-request-log-entry.ts +29 -0
  209. package/src/api/responses/subagent-detail.ts +17 -0
  210. package/src/api/surfaces.ts +39 -3
  211. package/src/approvals/guardian-channel-delivery.ts +30 -0
  212. package/src/approvals/guardian-expiry-notifier.ts +148 -0
  213. package/src/approvals/guardian-request-resolvers.ts +17 -15
  214. package/src/calls/__tests__/relay-setup-router.test.ts +267 -17
  215. package/src/calls/call-domain.ts +3 -3
  216. package/src/calls/guardian-dispatch.ts +14 -9
  217. package/src/calls/inbound-trust-reader.ts +24 -2
  218. package/src/calls/media-stream-server.ts +21 -0
  219. package/src/calls/relay-access-wait.ts +6 -6
  220. package/src/calls/relay-server.ts +188 -51
  221. package/src/calls/relay-setup-router.ts +47 -17
  222. package/src/calls/relay-verification.ts +4 -4
  223. package/src/calls/stt-hints.ts +9 -12
  224. package/src/calls/twilio-routes.ts +14 -4
  225. package/src/channels/types.ts +10 -20
  226. package/src/cli/commands/__tests__/cache.test.ts +8 -1
  227. package/src/cli/commands/__tests__/conversations-slack.test.ts +1 -0
  228. package/src/cli/commands/cache.ts +194 -181
  229. package/src/cli/commands/contacts.ts +10 -7
  230. package/src/cli/commands/db/__tests__/repair.test.ts +6 -5
  231. package/src/cli/commands/db/status.ts +37 -1
  232. package/src/cli/commands/mcp.ts +252 -218
  233. package/src/cli/commands/memory/__tests__/worker.test.ts +432 -0
  234. package/src/cli/commands/memory/index.ts +2 -0
  235. package/src/cli/commands/memory/worker.ts +242 -0
  236. package/src/cli/commands/plugins.ts +125 -13
  237. package/src/cli/lib/__tests__/install-from-github.test.ts +102 -0
  238. package/src/cli/lib/__tests__/list-installed-plugins.test.ts +160 -1
  239. package/src/cli/lib/__tests__/publish-plugin.test.ts +404 -0
  240. package/src/cli/lib/list-installed-plugins.ts +179 -1
  241. package/src/cli/lib/publish-plugin.ts +633 -0
  242. package/src/config/__tests__/loader-callsite-strip-fallback.test.ts +143 -0
  243. package/src/config/__tests__/sync-gated-profiles.test.ts +16 -10
  244. package/src/config/bundled-skills/contacts/tools/contact-merge.ts +27 -17
  245. package/src/config/bundled-skills/contacts/tools/contact-search.ts +13 -3
  246. package/src/config/bundled-skills/subagent/SKILL.md +17 -2
  247. package/src/config/bundled-skills/subagent/TOOLS.json +5 -4
  248. package/src/config/call-site-defaults.ts +0 -6
  249. package/src/config/feature-flag-registry.json +5 -13
  250. package/src/config/llm-resolver.ts +0 -3
  251. package/src/config/loader.ts +38 -5
  252. package/src/config/prune-seeded-callsite-defaults.ts +110 -0
  253. package/src/config/schemas/__tests__/memory-v3.test.ts +1 -0
  254. package/src/config/schemas/call-site-catalog.ts +0 -7
  255. package/src/config/schemas/heartbeat.ts +2 -5
  256. package/src/config/schemas/llm.ts +3 -12
  257. package/src/config/schemas/memory-lifecycle.ts +12 -0
  258. package/src/config/schemas/memory-v3.ts +7 -0
  259. package/src/config/schemas/memory.ts +4 -0
  260. package/src/config/schemas/timeouts.ts +8 -0
  261. package/src/config/seed-inference-profiles.ts +30 -34
  262. package/src/config/skills.ts +27 -5
  263. package/src/config/sync-gated-profiles.ts +12 -16
  264. package/src/contacts/__tests__/contacts-write-revoke-relay.test.ts +128 -0
  265. package/src/contacts/__tests__/guardian-delivery-reader.test.ts +312 -0
  266. package/src/contacts/__tests__/member-write-relay.test.ts +226 -0
  267. package/src/contacts/contact-store.ts +27 -237
  268. package/src/contacts/contacts-write.ts +18 -55
  269. package/src/contacts/gateway-channel-read.ts +51 -0
  270. package/src/contacts/guardian-delivery-reader.ts +223 -0
  271. package/src/contacts/member-write-relay.ts +183 -0
  272. package/src/contacts/types.ts +3 -15
  273. package/src/daemon/__tests__/conversation-tool-setup-exclude.test.ts +35 -0
  274. package/src/daemon/__tests__/conversation-tool-setup.test.ts +0 -44
  275. package/src/daemon/assistant-attachments.ts +27 -4
  276. package/src/daemon/conversation-agent-loop.ts +28 -0
  277. package/src/daemon/conversation-notices.ts +60 -0
  278. package/src/daemon/conversation-process.ts +35 -16
  279. package/src/daemon/conversation-surfaces.ts +111 -38
  280. package/src/daemon/conversation-tool-setup.ts +71 -30
  281. package/src/daemon/conversation.ts +23 -1
  282. package/src/daemon/disk-pressure-guard.ts +12 -2
  283. package/src/daemon/event-loop-watchdog.ts +28 -1
  284. package/src/daemon/external-plugins-bootstrap.ts +17 -41
  285. package/src/daemon/handlers/__tests__/config-a2a-accept.test.ts +0 -1
  286. package/src/daemon/handlers/__tests__/config-a2a-complete.test.ts +0 -2
  287. package/src/daemon/handlers/__tests__/config-a2a-redeem.test.ts +25 -2
  288. package/src/daemon/handlers/__tests__/config-channels.test.ts +220 -0
  289. package/src/daemon/handlers/config-a2a.ts +6 -14
  290. package/src/daemon/handlers/config-channels.ts +67 -26
  291. package/src/daemon/handlers/conversations.ts +77 -0
  292. package/src/daemon/lifecycle.ts +16 -0
  293. package/src/daemon/mcp-reload-service.ts +10 -0
  294. package/src/daemon/memory-v2-startup.test.ts +72 -0
  295. package/src/daemon/memory-v2-startup.ts +87 -19
  296. package/src/daemon/message-types/conversations.ts +2 -0
  297. package/src/daemon/message-types/surfaces.ts +12 -12
  298. package/src/daemon/server.ts +0 -4
  299. package/src/daemon/shutdown-handlers.ts +20 -0
  300. package/src/daemon/tool-setup-types.ts +9 -0
  301. package/src/heartbeat/heartbeat-service.ts +5 -0
  302. package/src/home/relationship-state-writer.ts +5 -0
  303. package/src/hooks/hook-loader.ts +341 -0
  304. package/src/ipc/__tests__/clients-list-ipc.test.ts +1 -1
  305. package/src/ipc/assistant-server.ts +2 -2
  306. package/src/mcp/__tests__/mcp-auth-orchestrator.test.ts +1 -0
  307. package/src/mcp/client.ts +15 -1
  308. package/src/mcp/mcp-auth-orchestrator.ts +6 -1
  309. package/src/mcp/mcp-header-store.ts +134 -0
  310. package/src/mcp/mcp-oauth-provider.ts +19 -8
  311. package/src/memory/__tests__/301-create-watchdog-events.test.ts +110 -0
  312. package/src/memory/__tests__/memory-retrospective-job.test.ts +8 -0
  313. package/src/memory/__tests__/prompt-override.test.ts +192 -0
  314. package/src/memory/__tests__/watchdog-events-store.test.ts +161 -0
  315. package/src/memory/compaction-ledger-store.ts +107 -0
  316. package/src/memory/conversation-crud.ts +129 -61
  317. package/src/memory/db-connection.ts +22 -3
  318. package/src/memory/db-init.ts +37 -503
  319. package/src/memory/db-singleton.ts +6 -4
  320. package/src/memory/jobs-worker.ts +104 -0
  321. package/src/memory/llm-request-log-store.ts +26 -1
  322. package/src/memory/llm-usage-store.ts +48 -20
  323. package/src/memory/memory-retrospective-job.ts +14 -8
  324. package/src/memory/migrations/209-strip-thinking-from-consolidated.ts +152 -56
  325. package/src/memory/migrations/300-add-processing-started-at.ts +30 -0
  326. package/src/memory/migrations/301-create-watchdog-events.ts +45 -0
  327. package/src/memory/migrations/302-create-compaction-events.ts +107 -0
  328. package/src/memory/migrations/__tests__/209-strip-thinking-from-consolidated.test.ts +297 -0
  329. package/src/memory/migrations/__tests__/run-migrations.test.ts +2 -2
  330. package/src/memory/migrations/run-migrations.ts +106 -10
  331. package/src/memory/migrations/validate-migration-state.ts +105 -67
  332. package/src/memory/prompt-override.ts +129 -0
  333. package/src/memory/schema/contacts.ts +6 -2
  334. package/src/memory/schema/conversations.ts +37 -0
  335. package/src/memory/schema/infrastructure.ts +20 -0
  336. package/src/memory/steps.ts +1294 -0
  337. package/src/memory/v2/__tests__/cli-command-store.test.ts +25 -0
  338. package/src/memory/v2/__tests__/skill-store.test.ts +80 -0
  339. package/src/memory/v2/cli-command-store.ts +75 -38
  340. package/src/memory/v2/prompts/consolidation.ts +13 -82
  341. package/src/memory/v2/prompts/router.ts +21 -93
  342. package/src/memory/v2/skill-store.ts +68 -31
  343. package/src/memory/watchdog-events-store.ts +87 -0
  344. package/src/memory/worker-control.ts +204 -0
  345. package/src/memory/worker-process.ts +89 -0
  346. package/src/messaging/channel-binding-metadata.ts +31 -0
  347. package/src/messaging/provider-types.ts +8 -0
  348. package/src/messaging/providers/slack/binding-metadata.ts +60 -0
  349. package/src/notifications/__tests__/broadcaster.test.ts +8 -8
  350. package/src/notifications/__tests__/connected-channels.test.ts +86 -0
  351. package/src/notifications/__tests__/decision-engine.test.ts +78 -9
  352. package/src/notifications/__tests__/destination-resolver.test.ts +151 -0
  353. package/src/notifications/broadcaster.ts +8 -1
  354. package/src/notifications/decision-engine.ts +15 -7
  355. package/src/notifications/destination-resolver.ts +53 -25
  356. package/src/notifications/emit-signal.ts +34 -15
  357. package/src/onboarding/checkin-event.test.ts +222 -0
  358. package/src/onboarding/checkin-event.ts +321 -0
  359. package/src/onboarding/schedule-checkin.ts +190 -0
  360. package/src/permissions/question-prompter.test.ts +1 -1
  361. package/src/permissions/question-prompter.ts +7 -4
  362. package/src/plugin-api/index.ts +12 -12
  363. package/src/plugin-api/types.ts +12 -14
  364. package/src/plugin-api/vision-support.test.ts +28 -4
  365. package/src/plugin-api/vision-support.ts +66 -31
  366. package/src/plugins/defaults/empty-response/hooks/post-model-call.ts +2 -2
  367. package/src/plugins/defaults/empty-response/hooks/stop.ts +2 -2
  368. package/src/plugins/defaults/exploration-drift/hooks/post-tool-use.ts +4 -3
  369. package/src/plugins/defaults/history-repair/hooks/post-model-call.ts +2 -2
  370. package/src/plugins/defaults/history-repair/hooks/stop.ts +2 -2
  371. package/src/plugins/defaults/history-repair/hooks/user-prompt-submit.ts +2 -2
  372. package/src/plugins/defaults/image-fallback/__tests__/image-fallback.test.ts +47 -7
  373. package/src/plugins/defaults/image-fallback/hooks/post-tool-use.ts +12 -13
  374. package/src/plugins/defaults/image-fallback/hooks/user-prompt-submit.ts +14 -22
  375. package/src/plugins/defaults/image-fallback/src/caption-blocks.ts +42 -11
  376. package/src/plugins/defaults/image-recovery/hooks/post-model-call.ts +2 -2
  377. package/src/plugins/defaults/image-recovery/hooks/stop.ts +2 -2
  378. package/src/plugins/defaults/index.ts +0 -35
  379. package/src/plugins/defaults/max-tokens-continue/hooks/post-model-call.ts +2 -2
  380. package/src/plugins/defaults/max-tokens-continue/hooks/stop.ts +2 -2
  381. package/src/plugins/defaults/memory-retrieval/hooks/post-compact.ts +2 -2
  382. package/src/plugins/defaults/memory-retrieval/hooks/user-prompt-submit.ts +2 -2
  383. package/src/plugins/defaults/memory-v3-shadow/__tests__/injection.test.ts +33 -3
  384. package/src/plugins/defaults/memory-v3-shadow/__tests__/pool-select.test.ts +48 -4
  385. package/src/plugins/defaults/memory-v3-shadow/__tests__/shadow-plugin.test.ts +4 -8
  386. package/src/plugins/defaults/memory-v3-shadow/hooks/post-compact.ts +2 -2
  387. package/src/plugins/defaults/memory-v3-shadow/hooks/user-prompt-submit.ts +2 -2
  388. package/src/plugins/defaults/memory-v3-shadow/injector.ts +43 -15
  389. package/src/plugins/defaults/memory-v3-shadow/orchestrate.ts +11 -2
  390. package/src/plugins/defaults/memory-v3-shadow/pool-select.test.ts +146 -0
  391. package/src/plugins/defaults/memory-v3-shadow/pool-select.ts +77 -13
  392. package/src/plugins/defaults/memory-v3-shadow/shadow-plugin.ts +12 -11
  393. package/src/plugins/defaults/surface-completion-nudge/hooks/post-model-call.ts +2 -2
  394. package/src/plugins/defaults/surface-completion-nudge/hooks/stop.ts +2 -2
  395. package/src/plugins/defaults/task-progress-nudge/hooks/post-tool-use.ts +2 -2
  396. package/src/plugins/defaults/title-generate/hooks/stop.ts +2 -2
  397. package/src/plugins/defaults/title-generate/hooks/user-prompt-submit.ts +2 -2
  398. package/src/plugins/defaults/tool-error/hooks/post-tool-use.ts +2 -2
  399. package/src/plugins/defaults/tool-result-truncate/hooks/post-tool-use.ts +2 -2
  400. package/src/plugins/disabled-state.ts +31 -0
  401. package/src/plugins/external-plugin-loader.ts +2 -2
  402. package/src/plugins/mtime-cache.ts +186 -330
  403. package/src/plugins/pipeline.ts +111 -13
  404. package/src/plugins/registry.ts +59 -16
  405. package/src/plugins/surface-import.ts +121 -0
  406. package/src/plugins/types.ts +7 -9
  407. package/src/prompts/persona-resolver.ts +43 -11
  408. package/src/providers/anthropic/client.ts +5 -0
  409. package/src/providers/call-site-routing.ts +45 -0
  410. package/src/providers/model-catalog.ts +16 -0
  411. package/src/providers/openai/__tests__/api-error-normalization.test.ts +321 -0
  412. package/src/providers/openai/api-error-normalization.ts +270 -0
  413. package/src/providers/openai/chat-completions-provider.ts +37 -83
  414. package/src/providers/openai/responses-provider.ts +50 -46
  415. package/src/providers/openrouter/client.ts +5 -0
  416. package/src/providers/provider-send-message.ts +10 -0
  417. package/src/providers/ratelimit.ts +10 -0
  418. package/src/providers/registry.ts +1 -1
  419. package/src/providers/retry.ts +10 -0
  420. package/src/providers/types.ts +22 -0
  421. package/src/providers/usage-tracking.ts +10 -0
  422. package/src/runtime/__tests__/channel-verification-service.test.ts +133 -0
  423. package/src/runtime/__tests__/guardian-vellum-migration.test.ts +184 -0
  424. package/src/runtime/__tests__/is-guardian-bound-for-channel.test.ts +66 -0
  425. package/src/runtime/__tests__/local-principal-trust.test.ts +162 -0
  426. package/src/runtime/__tests__/member-verdict-cache.test.ts +119 -0
  427. package/src/runtime/__tests__/trust-verdict-consumer.test.ts +402 -123
  428. package/src/runtime/access-request-helper.ts +18 -39
  429. package/src/runtime/actor-trust-resolver.ts +46 -19
  430. package/src/runtime/anchored-guardian.test.ts +109 -0
  431. package/src/runtime/anchored-guardian.ts +86 -0
  432. package/src/runtime/assistant-event-hub.ts +1 -1
  433. package/src/runtime/assistant-stream-state.ts +9 -2
  434. package/src/runtime/auth/__tests__/require-bound-guardian.test.ts +99 -0
  435. package/src/runtime/auth/require-bound-guardian.ts +21 -11
  436. package/src/runtime/channel-verification-service.ts +56 -31
  437. package/src/runtime/confirmation-request-guardian-bridge.ts +3 -3
  438. package/src/runtime/guardian-vellum-migration.ts +69 -8
  439. package/src/runtime/invite-redemption-service.ts +213 -187
  440. package/src/runtime/local-actor-identity.test.ts +108 -0
  441. package/src/runtime/local-actor-identity.ts +85 -13
  442. package/src/runtime/local-principal-trust.ts +52 -0
  443. package/src/runtime/member-verdict-cache.ts +0 -0
  444. package/src/runtime/pending-interactions.ts +11 -1
  445. package/src/runtime/routes/__tests__/channel-verification-revoke.test.ts +56 -5
  446. package/src/runtime/routes/__tests__/channel-verification-routes.test.ts +1 -1
  447. package/src/runtime/routes/__tests__/contact-routes.test.ts +305 -0
  448. package/src/runtime/routes/__tests__/global-search-routes.test.ts +92 -0
  449. package/src/runtime/routes/__tests__/http-adapter-actor-header.test.ts +129 -0
  450. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +188 -0
  451. package/src/runtime/routes/browser-routes.ts +1 -1
  452. package/src/runtime/routes/canonical-guardian-expiry-sweep.ts +13 -5
  453. package/src/runtime/routes/channel-verification-routes.ts +3 -3
  454. package/src/runtime/routes/contact-routes.ts +48 -57
  455. package/src/runtime/routes/conversation-cli-routes.ts +4 -5
  456. package/src/runtime/routes/conversation-list-routes.ts +4 -7
  457. package/src/runtime/routes/conversation-query-routes.ts +72 -0
  458. package/src/runtime/routes/conversation-routes.ts +84 -85
  459. package/src/runtime/routes/events-routes.ts +2 -2
  460. package/src/runtime/routes/global-search-routes.ts +3 -1
  461. package/src/runtime/routes/guardian-action-routes.ts +4 -5
  462. package/src/runtime/routes/host-app-control-routes.ts +5 -4
  463. package/src/runtime/routes/host-bash-routes.ts +5 -4
  464. package/src/runtime/routes/host-browser-routes.ts +9 -11
  465. package/src/runtime/routes/host-cu-routes.ts +5 -4
  466. package/src/runtime/routes/host-file-routes.ts +5 -4
  467. package/src/runtime/routes/host-transfer-routes.ts +6 -6
  468. package/src/runtime/routes/http-adapter.ts +16 -1
  469. package/src/runtime/routes/identity-routes.ts +3 -2
  470. package/src/runtime/routes/inbound-message-handler.ts +5 -5
  471. package/src/runtime/routes/inbound-stages/acl-enforcement.test.ts +97 -5
  472. package/src/runtime/routes/inbound-stages/acl-enforcement.ts +61 -59
  473. package/src/runtime/routes/inbound-stages/background-dispatch.ts +13 -5
  474. package/src/runtime/routes/inbound-stages/escalation-intercept.ts +7 -7
  475. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.test.ts +21 -8
  476. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.ts +14 -3
  477. package/src/runtime/routes/inbound-stages/reaction-intercept.ts +19 -0
  478. package/src/runtime/routes/index.ts +2 -0
  479. package/src/runtime/routes/llm-context-normalization.ts +83 -0
  480. package/src/runtime/routes/mcp-auth-routes.ts +171 -19
  481. package/src/runtime/routes/migration-rollback-routes.ts +4 -3
  482. package/src/runtime/routes/migration-routes.ts +4 -1
  483. package/src/runtime/routes/onboarding-checkin-routes.ts +86 -0
  484. package/src/runtime/routes/settings-routes.ts +8 -3
  485. package/src/runtime/routes/subagents-routes.ts +5 -0
  486. package/src/runtime/routes/surface-action-routes.ts +42 -56
  487. package/src/runtime/services/__tests__/conversation-serializer.test.ts +1 -0
  488. package/src/runtime/services/conversation-serializer.ts +13 -58
  489. package/src/runtime/tool-grant-request-helper.ts +3 -3
  490. package/src/runtime/trust-verdict-consumer.ts +111 -40
  491. package/src/runtime/verification-outbound-actions.ts +18 -18
  492. package/src/signals/user-message.ts +16 -0
  493. package/src/subagent/__tests__/consult-prompt.test.ts +35 -0
  494. package/src/{plugins/defaults/advisor/__tests__/transcript.test.ts → subagent/__tests__/consult-transcript.test.ts} +47 -10
  495. package/src/{plugins/defaults/advisor/steering.ts → subagent/consult-prompt.ts} +22 -32
  496. package/src/{plugins/defaults/advisor/transcript.ts → subagent/consult-transcript.ts} +18 -8
  497. package/src/subagent/index.ts +1 -1
  498. package/src/subagent/manager.ts +254 -33
  499. package/src/subagent/types.ts +11 -4
  500. package/src/telemetry/types.ts +34 -1
  501. package/src/telemetry/usage-telemetry-reporter.test.ts +3 -2
  502. package/src/telemetry/usage-telemetry-reporter.ts +87 -3
  503. package/src/tools/ask-question/ask-question-tool.test.ts +29 -0
  504. package/src/tools/ask-question/ask-question-tool.ts +13 -0
  505. package/src/tools/executor.ts +4 -4
  506. package/src/tools/filesystem/search.ts +543 -0
  507. package/src/tools/registry.ts +38 -0
  508. package/src/tools/shared/filesystem/path-policy.ts +12 -5
  509. package/src/tools/subagent/consult-deadline.ts +49 -0
  510. package/src/tools/subagent/spawn.ts +234 -5
  511. package/src/tools/tool-approval-handler.ts +1 -1
  512. package/src/tools/tool-defaults.ts +9 -2
  513. package/src/tools/tool-manifest.ts +3 -0
  514. package/src/tools/types.ts +131 -25
  515. package/src/tools/workspace-tools/loader.ts +348 -244
  516. package/src/util/errors.ts +26 -1
  517. package/src/util/logger.ts +9 -0
  518. package/src/util/platform.ts +19 -0
  519. package/src/util/telemetry-db-path.ts +24 -0
  520. package/src/workflows/library.test.ts +140 -0
  521. package/src/workflows/library.ts +82 -28
  522. package/src/workspace/migrations/017-seed-persona-dirs.ts +3 -34
  523. package/src/workspace/migrations/019-scope-journal-to-guardian.ts +3 -24
  524. package/src/workspace/migrations/031-drop-user-md.ts +232 -148
  525. package/src/workspace/migrations/048-remove-workspace-hooks.ts +14 -66
  526. package/src/workspace/migrations/111-prune-seeded-callsite-defaults.ts +134 -0
  527. package/src/workspace/migrations/112-remove-advisor-callsite-override.ts +64 -0
  528. package/src/workspace/migrations/registry.ts +4 -0
  529. package/src/__tests__/workspace-tools-watcher-flag.test.ts +0 -70
  530. package/src/daemon/workspace-tools-watcher.ts +0 -328
  531. package/src/memory/migrations/registry.ts +0 -573
  532. package/src/plugins/defaults/advisor/__tests__/advisor-gate.test.ts +0 -56
  533. package/src/plugins/defaults/advisor/__tests__/advisor-state-store.test.ts +0 -43
  534. package/src/plugins/defaults/advisor/__tests__/agent-loop-integration.test.ts +0 -137
  535. package/src/plugins/defaults/advisor/__tests__/consult.test.ts +0 -153
  536. package/src/plugins/defaults/advisor/__tests__/hooks.test.ts +0 -138
  537. package/src/plugins/defaults/advisor/advisor-gate.ts +0 -29
  538. package/src/plugins/defaults/advisor/advisor-state-store.ts +0 -94
  539. package/src/plugins/defaults/advisor/config.ts +0 -21
  540. package/src/plugins/defaults/advisor/consult.ts +0 -93
  541. package/src/plugins/defaults/advisor/hooks/post-model-call.ts +0 -34
  542. package/src/plugins/defaults/advisor/hooks/pre-model-call.ts +0 -30
  543. package/src/plugins/defaults/advisor/hooks/user-prompt-submit.ts +0 -19
  544. package/src/plugins/defaults/advisor/package.json +0 -14
  545. package/src/plugins/defaults/advisor/tools/advisor.ts +0 -65
  546. package/src/providers/openai/__tests__/api-error-detail.test.ts +0 -120
@@ -0,0 +1,282 @@
1
+ /**
2
+ * Tests for guardian request expiry side effects:
3
+ *
4
+ * 1. notifyExpiredGuardianRequest — per-kind behavior (requester notice for
5
+ * access_request / tool_grant_request, interaction release for tool_approval,
6
+ * no-op for pending_question), Slack DM routing, non-deliverable channels,
7
+ * and best-effort (non-throwing) delivery.
8
+ * 2. Sweep integration — an expired request is transitioned to `expired` and the
9
+ * requester is notified through the wired-in notifier.
10
+ */
11
+
12
+ import { beforeEach, describe, expect, mock, test } from "bun:test";
13
+
14
+ // Silence logging.
15
+ mock.module("../util/logger.js", () => ({
16
+ getLogger: () =>
17
+ new Proxy({} as Record<string, unknown>, {
18
+ get: () => () => {},
19
+ }),
20
+ truncateForLog: (value: string) => value,
21
+ }));
22
+
23
+ // Capture requester channel deliveries; optionally fail to exercise the
24
+ // best-effort path.
25
+ const deliveredReplies: Array<{
26
+ url: string;
27
+ payload: { chatId: string; text: string; assistantId?: string };
28
+ }> = [];
29
+ let deliveryError: Error | null = null;
30
+ mock.module("../runtime/gateway-client.js", () => ({
31
+ deliverChannelReply: async (
32
+ url: string,
33
+ payload: { chatId: string; text: string; assistantId?: string },
34
+ ) => {
35
+ if (deliveryError) throw deliveryError;
36
+ deliveredReplies.push({ url, payload });
37
+ },
38
+ }));
39
+
40
+ // Capture hub broadcasts (interaction_resolved) emitted by pendingInteractions.
41
+ const broadcasts: Array<Record<string, unknown>> = [];
42
+ mock.module("../runtime/assistant-event-hub.js", () => ({
43
+ broadcastMessage: (msg: Record<string, unknown>) => {
44
+ broadcasts.push(msg);
45
+ },
46
+ }));
47
+
48
+ // The sweep withdraws cards via this module; we only assert it is invoked, and
49
+ // mocking it keeps the sweep import light (no surface/slack transitive deps).
50
+ let withdrawCalls = 0;
51
+ mock.module("../approvals/guardian-card-withdrawal.js", () => ({
52
+ withdrawGuardianRequestCards: async () => {
53
+ withdrawCalls++;
54
+ },
55
+ }));
56
+
57
+ import { notifyExpiredGuardianRequest } from "../approvals/guardian-expiry-notifier.js";
58
+ import type { CanonicalGuardianRequest } from "../memory/canonical-guardian-store.js";
59
+ import {
60
+ createCanonicalGuardianRequest,
61
+ getCanonicalGuardianRequest,
62
+ } from "../memory/canonical-guardian-store.js";
63
+ import { getDb } from "../memory/db-connection.js";
64
+ import { initializeDb } from "../memory/db-init.js";
65
+ import * as pendingInteractions from "../runtime/pending-interactions.js";
66
+ import { sweepExpiredCanonicalGuardianRequests } from "../runtime/routes/canonical-guardian-expiry-sweep.js";
67
+
68
+ await initializeDb();
69
+
70
+ /** Build a fully-populated canonical request, overriding the interesting bits. */
71
+ function makeRequest(
72
+ overrides: Partial<CanonicalGuardianRequest> & { kind: string },
73
+ ): CanonicalGuardianRequest {
74
+ return {
75
+ id: "req-1",
76
+ sourceType: "channel",
77
+ sourceChannel: "telegram",
78
+ conversationId: "conv-1",
79
+ requesterExternalUserId: "req-user",
80
+ requesterChatId: "req-chat",
81
+ guardianExternalUserId: "guardian-user",
82
+ guardianPrincipalId: "guardian-principal",
83
+ callSessionId: null,
84
+ pendingQuestionId: null,
85
+ questionText: null,
86
+ requestCode: "ABC123",
87
+ toolName: null,
88
+ inputDigest: null,
89
+ commandPreview: null,
90
+ riskLevel: null,
91
+ activityText: null,
92
+ executionTarget: null,
93
+ status: "expired",
94
+ answerText: null,
95
+ decidedByExternalUserId: null,
96
+ decidedByPrincipalId: null,
97
+ followupState: null,
98
+ expiresAt: 1000,
99
+ createdAt: 1000,
100
+ updatedAt: 2000,
101
+ ...overrides,
102
+ };
103
+ }
104
+
105
+ beforeEach(() => {
106
+ deliveredReplies.length = 0;
107
+ broadcasts.length = 0;
108
+ deliveryError = null;
109
+ withdrawCalls = 0;
110
+ pendingInteractions.clear();
111
+ });
112
+
113
+ describe("notifyExpiredGuardianRequest", () => {
114
+ test("access_request: notifies the requester on their channel", async () => {
115
+ await notifyExpiredGuardianRequest(
116
+ makeRequest({
117
+ kind: "access_request",
118
+ sourceChannel: "telegram",
119
+ requesterChatId: "tg-chat",
120
+ requesterExternalUserId: "tg-user",
121
+ }),
122
+ );
123
+
124
+ expect(deliveredReplies).toHaveLength(1);
125
+ expect(deliveredReplies[0].url).toBe("/deliver/telegram");
126
+ expect(deliveredReplies[0].payload.chatId).toBe("tg-chat");
127
+ expect(deliveredReplies[0].payload.text).toContain(
128
+ "access request expired",
129
+ );
130
+ });
131
+
132
+ test("access_request on Slack: routes to the requester DM, not the channel", async () => {
133
+ await notifyExpiredGuardianRequest(
134
+ makeRequest({
135
+ kind: "access_request",
136
+ sourceChannel: "slack",
137
+ requesterChatId: "C0SHARED",
138
+ requesterExternalUserId: "U123",
139
+ }),
140
+ );
141
+
142
+ expect(deliveredReplies).toHaveLength(1);
143
+ expect(deliveredReplies[0].url).toBe("/deliver/slack");
144
+ // DM via the user id, never the shared channel id.
145
+ expect(deliveredReplies[0].payload.chatId).toBe("U123");
146
+ });
147
+
148
+ test("tool_grant_request: notice names the tool", async () => {
149
+ await notifyExpiredGuardianRequest(
150
+ makeRequest({
151
+ kind: "tool_grant_request",
152
+ sourceChannel: "telegram",
153
+ requesterChatId: "tg-chat",
154
+ toolName: "bash",
155
+ }),
156
+ );
157
+
158
+ expect(deliveredReplies).toHaveLength(1);
159
+ expect(deliveredReplies[0].payload.text).toContain('"bash"');
160
+ expect(deliveredReplies[0].payload.text).toContain("expired");
161
+ });
162
+
163
+ test("tool_approval: releases the pending interaction, sends no channel notice", async () => {
164
+ pendingInteractions.register("req-ta", {
165
+ conversationId: "conv-1",
166
+ kind: "confirmation",
167
+ });
168
+
169
+ await notifyExpiredGuardianRequest(
170
+ makeRequest({ id: "req-ta", kind: "tool_approval" }),
171
+ );
172
+
173
+ expect(pendingInteractions.get("req-ta")).toBeUndefined();
174
+ const resolvedEvent = broadcasts.find(
175
+ (b) => b.type === "interaction_resolved",
176
+ );
177
+ expect(resolvedEvent).toMatchObject({
178
+ requestId: "req-ta",
179
+ state: "cancelled",
180
+ });
181
+ expect(deliveredReplies).toHaveLength(0);
182
+ });
183
+
184
+ test("tool_approval: no registered interaction is a safe no-op", async () => {
185
+ await notifyExpiredGuardianRequest(
186
+ makeRequest({ id: "req-none", kind: "tool_approval" }),
187
+ );
188
+
189
+ expect(deliveredReplies).toHaveLength(0);
190
+ expect(broadcasts).toHaveLength(0);
191
+ });
192
+
193
+ test("pending_question: no notice (voice owns its lifecycle)", async () => {
194
+ await notifyExpiredGuardianRequest(
195
+ makeRequest({ kind: "pending_question", sourceChannel: "phone" }),
196
+ );
197
+
198
+ expect(deliveredReplies).toHaveLength(0);
199
+ });
200
+
201
+ test("non-deliverable channel: no notice", async () => {
202
+ await notifyExpiredGuardianRequest(
203
+ makeRequest({ kind: "access_request", sourceChannel: "vellum" }),
204
+ );
205
+
206
+ expect(deliveredReplies).toHaveLength(0);
207
+ });
208
+
209
+ test("missing requester chat: no notice", async () => {
210
+ await notifyExpiredGuardianRequest(
211
+ makeRequest({
212
+ kind: "access_request",
213
+ sourceChannel: "telegram",
214
+ requesterChatId: null,
215
+ requesterExternalUserId: null,
216
+ }),
217
+ );
218
+
219
+ expect(deliveredReplies).toHaveLength(0);
220
+ });
221
+
222
+ test("delivery failure is swallowed (best-effort)", async () => {
223
+ deliveryError = new Error("gateway down");
224
+
225
+ await expect(
226
+ notifyExpiredGuardianRequest(
227
+ makeRequest({
228
+ kind: "access_request",
229
+ sourceChannel: "telegram",
230
+ requesterChatId: "tg-chat",
231
+ }),
232
+ ),
233
+ ).resolves.toBeUndefined();
234
+ });
235
+ });
236
+
237
+ describe("sweep integration", () => {
238
+ beforeEach(() => {
239
+ const db = getDb();
240
+ db.run("DELETE FROM canonical_guardian_requests");
241
+ db.run("DELETE FROM canonical_guardian_deliveries");
242
+ });
243
+
244
+ test("expired access_request is transitioned and the requester is notified", async () => {
245
+ const request = createCanonicalGuardianRequest({
246
+ kind: "access_request",
247
+ sourceType: "channel",
248
+ sourceChannel: "telegram",
249
+ requesterChatId: "tg-chat",
250
+ requesterExternalUserId: "tg-user",
251
+ guardianPrincipalId: "guardian-principal",
252
+ expiresAt: Date.now() - 1000, // already past
253
+ });
254
+
255
+ const expiredCount = await sweepExpiredCanonicalGuardianRequests();
256
+
257
+ expect(expiredCount).toBe(1);
258
+ expect(getCanonicalGuardianRequest(request.id)?.status).toBe("expired");
259
+ expect(withdrawCalls).toBe(1);
260
+ expect(deliveredReplies).toHaveLength(1);
261
+ expect(deliveredReplies[0].payload.text).toContain(
262
+ "access request expired",
263
+ );
264
+ });
265
+
266
+ test("not-yet-expired requests are left pending and unnotified", async () => {
267
+ const request = createCanonicalGuardianRequest({
268
+ kind: "access_request",
269
+ sourceType: "channel",
270
+ sourceChannel: "telegram",
271
+ requesterChatId: "tg-chat",
272
+ guardianPrincipalId: "guardian-principal",
273
+ expiresAt: Date.now() + 60_000, // still in the future
274
+ });
275
+
276
+ const expiredCount = await sweepExpiredCanonicalGuardianRequests();
277
+
278
+ expect(expiredCount).toBe(0);
279
+ expect(getCanonicalGuardianRequest(request.id)?.status).toBe("pending");
280
+ expect(deliveredReplies).toHaveLength(0);
281
+ });
282
+ });
@@ -84,6 +84,19 @@ globalThis.fetch = (async (
84
84
  return originalFetch(input, init as never);
85
85
  }) as unknown as typeof fetch;
86
86
 
87
+ // Guardian-delivery reader mock — the inbound challenge guard reads guardian
88
+ // existence from the gateway. These tests seed no binding, so report an empty
89
+ // list (not bound) rather than a null that would fail closed as already-bound.
90
+ mock.module("../contacts/guardian-delivery-reader.js", () => ({
91
+ getGuardianDelivery: async () => [],
92
+ getGuardianDeliveryFresh: async () => [],
93
+ guardianForChannel: (
94
+ list: Array<{ channelType: string; status: string }>,
95
+ channelType: string,
96
+ ) =>
97
+ list.find((g) => g.channelType === channelType && g.status === "active"),
98
+ }));
99
+
87
100
  // ---------------------------------------------------------------------------
88
101
  // Now import modules under test (after mocks are in place)
89
102
  // ---------------------------------------------------------------------------
@@ -14,7 +14,6 @@ mock.module("../util/logger.js", () => ({
14
14
  }),
15
15
  }));
16
16
 
17
- import { upsertContact } from "../contacts/contact-store.js";
18
17
  import type { TrustContext } from "../daemon/trust-context.js";
19
18
  import { getDb } from "../memory/db-connection.js";
20
19
  import { initializeDb } from "../memory/db-init.js";
@@ -27,6 +26,7 @@ import {
27
26
  } from "../runtime/trust-context-resolver.js";
28
27
  import {
29
28
  handleChannelInbound,
29
+ seedContactChannel,
30
30
  setAdapterProcessMessage,
31
31
  } from "./helpers/channel-test-adapter.js";
32
32
  import { createGuardianBinding } from "./helpers/create-guardian-binding.js";
@@ -155,16 +155,12 @@ describe("inbound-message-handler trusted-contact interactivity", () => {
155
155
  resetTables();
156
156
  setAdapterProcessMessage(undefined);
157
157
  // Insert a test contact so the contacts-based ACL lookup passes
158
- upsertContact({
158
+ seedContactChannel({
159
+ sourceChannel: "telegram",
160
+ externalUserId: "telegram-user-default",
159
161
  displayName: "Test User",
160
- channels: [
161
- {
162
- type: "telegram",
163
- address: "telegram-user-default",
164
- status: "active",
165
- policy: "allow",
166
- },
167
- ],
162
+ status: "active",
163
+ policy: "allow",
168
164
  });
169
165
  });
170
166
 
@@ -70,6 +70,8 @@ mock.module("../schedule/recurrence-engine.js", () => ({
70
70
 
71
71
  const createdConversations: Array<{ conversationType: string }> = [];
72
72
  mock.module("../memory/conversation-crud.js", () => ({
73
+ setConversationProcessingStartedAt: () => {},
74
+ isConversationProcessing: () => false,
73
75
  getConversation: () => null,
74
76
  getMessages: () => [],
75
77
  createConversation: (opts: { conversationType: string }) => {
@@ -137,6 +137,8 @@ const mockStoredMessages: Array<{
137
137
  }> = [];
138
138
 
139
139
  mock.module("../memory/conversation-crud.js", () => ({
140
+ setConversationProcessingStartedAt: () => {},
141
+ isConversationProcessing: () => false,
140
142
  setConversationOriginChannelIfUnset: () => {},
141
143
  updateConversationContextWindow: () => {},
142
144
  deleteMessageById: () => {},
@@ -62,11 +62,11 @@ mock.module("../../daemon/approval-generators.js", () => ({
62
62
  }));
63
63
 
64
64
  import type { TrustClass, TrustVerdict } from "@vellumai/gateway-client";
65
+ import { and, desc, eq } from "drizzle-orm";
65
66
 
66
- import {
67
- findContactChannel,
68
- findGuardianForChannel,
69
- } from "../../contacts/contact-store.js";
67
+ import { findContactChannel } from "../../contacts/contact-store.js";
68
+ import { getDb } from "../../memory/db-connection.js";
69
+ import { contactChannels, contacts } from "../../memory/schema.js";
70
70
  import type {
71
71
  ApprovalConversationGenerator,
72
72
  ApprovalCopyGenerator,
@@ -138,47 +138,72 @@ function stampTrustVerdict(body: Record<string, unknown>): void {
138
138
  const channelType = String(body.sourceChannel ?? "");
139
139
  const actorExternalId =
140
140
  typeof body.actorExternalId === "string" ? body.actorExternalId : undefined;
141
- const externalChatId =
142
- typeof body.conversationExternalId === "string"
143
- ? body.conversationExternalId
144
- : undefined;
145
141
  if (!channelType) return;
146
142
 
147
143
  const verdict = resolveLocalTrustVerdict({
148
144
  channelType,
149
145
  actorExternalId,
150
- externalChatId,
151
146
  });
152
147
  body.sourceMetadata = { ...(meta ?? {}), trustVerdict: verdict };
153
148
  }
154
149
 
150
+ /**
151
+ * Local mirror of the gateway's active-guardian-channel resolution, querying
152
+ * the contact store directly (the production query now lives in the gateway).
153
+ */
154
+ function localGuardianForChannel(channelType: string) {
155
+ const row = getDb()
156
+ .select({ contact: contacts, channel: contactChannels })
157
+ .from(contacts)
158
+ .innerJoin(contactChannels, eq(contacts.id, contactChannels.contactId))
159
+ .where(
160
+ and(
161
+ eq(contacts.role, "guardian"),
162
+ eq(contactChannels.type, channelType),
163
+ eq(contactChannels.status, "active"),
164
+ ),
165
+ )
166
+ .orderBy(desc(contactChannels.verifiedAt))
167
+ .get();
168
+ return row ? { contact: row.contact, channel: row.channel } : null;
169
+ }
170
+
155
171
  /** Local mirror of the gateway resolver, reading the daemon contact store. */
156
172
  export function resolveLocalTrustVerdict(input: {
157
173
  channelType: string;
158
174
  actorExternalId?: string;
159
- externalChatId?: string;
160
175
  }): TrustVerdict {
161
176
  const canonicalSenderId = input.actorExternalId ?? null;
162
177
 
178
+ // Match the gateway's address-only member resolution (no externalChatId).
163
179
  const member = input.actorExternalId
164
180
  ? findContactChannel({
165
181
  channelType: input.channelType,
166
182
  address: input.actorExternalId,
167
- externalChatId: input.externalChatId,
168
183
  })
169
184
  : null;
170
- const guardian = findGuardianForChannel(input.channelType);
185
+ const guardian = localGuardianForChannel(input.channelType);
171
186
 
172
187
  const isGuardian =
173
188
  !!guardian &&
174
189
  !!canonicalSenderId &&
175
190
  guardian.channel.address.toLowerCase() === canonicalSenderId.toLowerCase();
176
191
 
192
+ // ACL columns are no longer on the slimmed ContactChannel type; read the raw
193
+ // row (columns still exist) so this local mirror sees status/policy/verified.
194
+ const memberRow = member
195
+ ? (getDb()
196
+ .select()
197
+ .from(contactChannels)
198
+ .where(eq(contactChannels.id, member.channel.id))
199
+ .get() ?? null)
200
+ : null;
201
+
177
202
  let trustClass: TrustClass;
178
203
  if (isGuardian) {
179
204
  trustClass = "guardian";
180
- } else if (member) {
181
- const status = member.channel.status;
205
+ } else if (memberRow) {
206
+ const status = memberRow.status;
182
207
  if (status === "active") trustClass = "trusted_contact";
183
208
  else if (status === "unverified" || status === "pending")
184
209
  trustClass = "unverified_contact";
@@ -197,22 +222,24 @@ export function resolveLocalTrustVerdict(input: {
197
222
  verdict.guardianDisplayName = guardian.contact.displayName;
198
223
  }
199
224
 
200
- if (member) {
225
+ if (member && memberRow) {
201
226
  verdict.contactId = member.channel.contactId;
202
227
  verdict.channelId = member.channel.id;
203
228
  verdict.type = member.channel.type;
204
229
  verdict.address = member.channel.address;
205
230
  verdict.externalChatId = member.channel.externalChatId;
206
- verdict.status = member.channel.status;
207
- verdict.policy = member.channel.policy;
208
- verdict.verifiedAt = member.channel.verifiedAt;
209
- verdict.verifiedVia = member.channel.verifiedVia;
231
+ verdict.status = memberRow.status;
232
+ verdict.policy = memberRow.policy;
233
+ verdict.verifiedAt = memberRow.verifiedAt;
234
+ verdict.verifiedVia = memberRow.verifiedVia;
210
235
  verdict.memberDisplayName = member.contact.displayName;
211
236
  }
212
237
 
213
238
  return verdict;
214
239
  }
215
240
 
241
+ export { seedContactChannel } from "./seed-contact-channel.js";
242
+
216
243
  // ---------------------------------------------------------------------------
217
244
  // handleDeleteConversation adapter
218
245
  // ---------------------------------------------------------------------------
@@ -4,11 +4,10 @@
4
4
  * path was moved to the gateway.
5
5
  */
6
6
 
7
- import type { ChannelId } from "../../channels/types.js";
8
- import { upsertContact } from "../../contacts/contact-store.js";
7
+ import { getContact } from "../../contacts/contact-store.js";
9
8
  import type { GuardianBinding } from "../../memory/channel-verification-sessions.js";
10
9
  import { ensureGuardianPersonaFile } from "../../prompts/persona-resolver.js";
11
- import { canonicalizeInboundIdentity } from "../../util/canonicalize-identity.js";
10
+ import { seedContactChannel } from "./seed-contact-channel.js";
12
11
 
13
12
  function parseDisplayNameFromMetadata(
14
13
  metadataJson: string | null | undefined,
@@ -36,37 +35,30 @@ export function createGuardianBinding(params: {
36
35
  verifiedVia?: string;
37
36
  metadataJson?: string | null;
38
37
  }): GuardianBinding {
39
- const canonicalId =
40
- canonicalizeInboundIdentity(
41
- params.channel as ChannelId,
42
- params.guardianExternalUserId,
43
- ) ?? params.guardianExternalUserId;
44
-
45
38
  const displayName =
46
39
  parseDisplayNameFromMetadata(params.metadataJson) ??
47
40
  params.guardianExternalUserId;
48
41
 
49
- const contact = upsertContact({
42
+ // The production identity upsert no longer writes ACL columns (gateway-owned);
43
+ // seedContactChannel stamps the guardian ACL state directly so the local
44
+ // guardian-resolution reads still under test resolve this binding.
45
+ const { contactId } = seedContactChannel({
46
+ sourceChannel: params.channel,
47
+ externalUserId: params.guardianExternalUserId,
48
+ externalChatId: params.guardianDeliveryChatId,
50
49
  displayName,
51
50
  role: "guardian",
52
- notes: "guardian",
53
51
  principalId: params.guardianPrincipalId,
54
- channels: [
55
- {
56
- type: params.channel,
57
- address: canonicalId,
58
- externalChatId: params.guardianDeliveryChatId,
59
- status: "active",
60
- verifiedAt: Date.now(),
61
- verifiedVia: params.verifiedVia ?? "challenge",
62
- },
63
- ],
52
+ status: "active",
53
+ verifiedAt: Date.now(),
54
+ verifiedVia: params.verifiedVia ?? "challenge",
64
55
  });
65
56
 
66
57
  // Seed persona file (mirrors gateway's production behavior)
67
- if (contact.userFile) {
58
+ const userFile = getContact(contactId)?.userFile;
59
+ if (userFile) {
68
60
  try {
69
- ensureGuardianPersonaFile(contact.userFile);
61
+ ensureGuardianPersonaFile(userFile);
70
62
  } catch {
71
63
  // Tolerate filesystem failures in tests
72
64
  }
@@ -56,6 +56,7 @@ export function createMockLoggerModule(
56
56
  initLogger: () => {},
57
57
  truncateForLog: (value: string) => value,
58
58
  pruneOldLogFiles: () => 0,
59
+ getCurrentLogFilePath: () => "/tmp/assistant-test-mock.log",
59
60
  LOG_FILE_PATTERN: /^assistant-(\d{4}-\d{2}-\d{2})\.log$/,
60
61
  ...overrides,
61
62
  };
@@ -0,0 +1,96 @@
1
+ /**
2
+ * Test-only member seeding.
3
+ *
4
+ * Production identity upserts no longer write ACL columns (gateway-owned).
5
+ * Tests that simulate gateway-resolved members stamp the ACL columns directly
6
+ * and warm the member-verdict cache so verdict synthesis and the sync trust
7
+ * fallback resolve the intended trust.
8
+ */
9
+
10
+ import { eq } from "drizzle-orm";
11
+
12
+ import { isChannelId } from "../../channels/types.js";
13
+ import { upsertContact } from "../../contacts/contact-store.js";
14
+ import type {
15
+ ChannelPolicy,
16
+ ChannelStatus,
17
+ ContactRole,
18
+ } from "../../contacts/types.js";
19
+ import { getDb } from "../../memory/db-connection.js";
20
+ import { contactChannels, contacts } from "../../memory/schema.js";
21
+ import { setMemberVerdict } from "../../runtime/member-verdict-cache.js";
22
+
23
+ export function seedContactChannel(params: {
24
+ sourceChannel: string;
25
+ externalUserId?: string;
26
+ externalChatId?: string;
27
+ displayName?: string;
28
+ username?: string;
29
+ contactId?: string;
30
+ role?: ContactRole;
31
+ status?: ChannelStatus;
32
+ policy?: string;
33
+ verifiedAt?: number | null;
34
+ verifiedVia?: string | null;
35
+ inviteId?: string | null;
36
+ revokedReason?: string | null;
37
+ blockedReason?: string | null;
38
+ principalId?: string | null;
39
+ }): { contactId: string; channelId: string } {
40
+ const address = params.externalUserId ?? params.externalChatId;
41
+ if (!address) throw new Error("seedContactChannel requires an address");
42
+
43
+ const contact = upsertContact({
44
+ id: params.contactId,
45
+ displayName: params.displayName ?? address,
46
+ channels: [
47
+ {
48
+ type: params.sourceChannel,
49
+ address,
50
+ externalChatId: params.externalChatId ?? null,
51
+ inviteId: params.inviteId ?? null,
52
+ },
53
+ ],
54
+ reassignConflictingChannels: !!params.contactId,
55
+ });
56
+
57
+ const db = getDb();
58
+ if (params.role !== undefined || params.principalId !== undefined) {
59
+ const set: Record<string, unknown> = {};
60
+ if (params.role !== undefined) set.role = params.role;
61
+ if (params.principalId !== undefined) set.principalId = params.principalId;
62
+ db.update(contacts).set(set).where(eq(contacts.id, contact.id)).run();
63
+ }
64
+
65
+ const channel = contact.channels.find(
66
+ (ch) => ch.type === params.sourceChannel,
67
+ )!;
68
+ const aclSet: Record<string, unknown> = { updatedAt: Date.now() };
69
+ if (params.status !== undefined) aclSet.status = params.status;
70
+ if (params.policy !== undefined) aclSet.policy = params.policy;
71
+ if (params.verifiedAt !== undefined) aclSet.verifiedAt = params.verifiedAt;
72
+ if (params.verifiedVia !== undefined) aclSet.verifiedVia = params.verifiedVia;
73
+ if (params.revokedReason !== undefined)
74
+ aclSet.revokedReason = params.revokedReason;
75
+ if (params.blockedReason !== undefined)
76
+ aclSet.blockedReason = params.blockedReason;
77
+ db.update(contactChannels)
78
+ .set(aclSet)
79
+ .where(eq(contactChannels.id, channel.id))
80
+ .run();
81
+
82
+ // Warm the verdict cache so the sync trust fallback resolves this member, as
83
+ // a gateway verdict fetch would in production.
84
+ if (isChannelId(params.sourceChannel)) {
85
+ setMemberVerdict(params.sourceChannel, address, {
86
+ trustClass: params.role === "guardian" ? "guardian" : "unknown",
87
+ canonicalSenderId: address,
88
+ contactId: contact.id,
89
+ channelId: channel.id,
90
+ status: (params.status ?? "active") as ChannelStatus,
91
+ policy: (params.policy ?? "allow") as ChannelPolicy,
92
+ });
93
+ }
94
+
95
+ return { contactId: contact.id, channelId: channel.id };
96
+ }